On Wed, Jan 9, 2019 at 5:07 PM Ioana Ciornei <[email protected]> wrote: > > Use optind as index for argv instead of a hardcoded value. > When the program has options this leads to improper parameter handling. > > Fixes: dc378a1ab5b6 ("samples: bpf: get ifindex from ifname") > > Signed-off-by: Ioana Ciornei <[email protected]> > --- > samples/bpf/xdp1_user.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/samples/bpf/xdp1_user.c b/samples/bpf/xdp1_user.c > index 0a197f8..8bfda95 100644 > --- a/samples/bpf/xdp1_user.c > +++ b/samples/bpf/xdp1_user.c > @@ -103,7 +103,7 @@ int main(int argc, char **argv) > return 1; > } > > - ifindex = if_nametoindex(argv[1]); > + ifindex = if_nametoindex(argv[optind]); > if (!ifindex) { > perror("if_nametoindex"); > return 1; > -- > 1.9.1 >
ACK -- Matteo Croce per aspera ad upstream
