On Wed 2018-12-19 22:50:16, tristram...@microchip.com wrote: > > >>>> This header file makes no sense. Please move the functions into .c > > >>> > > >>> No, that would make code bigger & slower. > > >>> > > >>> It makes sense to me. But I'd add "inline" keyword to make the goal > > >>> explicit. > > >> > > >> 1) It makes no sense to have header files for things like this. The > > >> functions are only used within the single .c file. > > >> > > >> 2) You cannot inline them, as they are used as ops. > > > > > > Ok, sorry for the noise. > > > > If you were to use regmap, this whole boilerplate would go away ... > > Sometimes I am confused about this review process. > > The new code is same as previous code submitted. The old code was accepted, > but then there are objections to the new code.
Sometimes you just need to reject review comment...
It took extremely long to merge this driver; that does not help,
either.
Good luck,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
signature.asc
Description: Digital signature
