Re: [PATCH] vti4: Fix a ipip packet processing bug in 'IPCOMP' virtual tunnel

2019-01-03 Thread Steffen Klassert
On Thu, Jan 03, 2019 at 07:48:41AM -0500, Su Yanjun wrote: > Recently we run a network test over ipcomp virtual tunnel.We find that > if a ipv4 packet needs fragment, then the peer can't receive > it. > > We deep into the code and find that when packet need fragment the smaller > fragment will be

Re: Problem with queuing vlan tagged packets after migration from 3.16.0 to 4.9.0

2019-01-03 Thread Bartek Kois
Hi Is this equally fast as hashing tables? Best regards Bartek Kois W dniu 03.01.2019 o 22:49, Anton Danilov pisze: Hi. There is the workaround - classify the packets with iptables+ipset - it's enough fast and more friendly. On Fri, 4 Jan 2019 at 00:21, Bartek Kois wrote: Hi 1. What exactly

Re: [Patch net] xfrm: fix reinsert in xfrm_hash_rebuild()

2019-01-03 Thread Florian Westphal
Cong Wang wrote: > xfrm_hash_rebuild() re-inserts existing policies into the hashtables, > so it should not insert a same policy in the same place twice. This > means we have to pass excl==1 to xfrm_policy_inexact_insert() and ignore > the -EEXIST error. Otherwise we end up having an entry in the

[PATCH 1/1] net-next/hinic: replace disable_irq_nosync/enable_irq

2019-01-03 Thread Xue Chaojing
In order to avoid frequent system interrupts when sending and receiving packets. we replace disable_irq_nosync/enable_irq with hinic_set_msix_state(), hinic_set_msix_state is used to access memory mapped hinic devices. Signed-off-by: Xue Chaojing --- .../net/ethernet/huawei/hinic/hinic_hw_dev.c

[PATCH v3] net/smc: fix TCP fallback socket release

2019-01-03 Thread Myungho Jung
clcsock can be released while kernel_accept() references it in TCP listen worker. Also, clcsock needs to wake up before released if TCP fallback is used and the clcsock is blocked by accept. Add a lock to safely release clcsock and call kernel_sock_shutdown() to wake up clcsock from accept in smc_r

Re: [PATCH bpf] selftests/bpf: fix incorrect users of create_and_get_cgroup

2019-01-03 Thread Y Song
On Thu, Jan 3, 2019 at 12:02 PM Stanislav Fomichev wrote: > > create_and_get_cgroup returns 0 on error, fix the users that assume > negative value in case of an error. > > Signed-off-by: Stanislav Fomichev Thanks for the fix! Acked-by: Yonghong Song > --- > tools/testing/selftests/bpf/get_cgr

Re: [RFC bpf-next v3 3/9] tools: bpftool: add probes for kernel configuration options

2019-01-03 Thread Y Song
On Thu, Jan 3, 2019 at 9:27 AM Quentin Monnet wrote: > > Add probes to dump a number of options set (or not set) for compiling > the kernel image. These parameters provide information about what BPF > components should be available on the system. A number of them are not > directly related to eBPF

Re: [PATCH ipsec] xfrm: fix non-GRO codepath for IPsec hardware offloading

2019-01-03 Thread Steffen Klassert
On Thu, Dec 27, 2018 at 01:32:14PM +, Raed Salem wrote: > In xfrm_input() when called with IPsec hardware offload done and without GRO, > encap_type == 0, we end up skipping esp_input_tail as crypto_done is set only > within GRO code path, fix by move out crypto_done assignment from the GRO

Re: [RFC bpf-next v3 2/9] tools: bpftool: add probes for /proc/ eBPF parameters

2019-01-03 Thread Y Song
On Thu, Jan 3, 2019 at 9:26 AM Quentin Monnet wrote: > > Add a set of probes to dump the eBPF-related parameters available from > /proc/: availability of bpf() syscall for unprivileged users, > JIT compiler status and hardening status, kallsyms exports status. > > Sample output: > > # bpftool

Re: [RFC] phylink: support for devices with MAC sharing SFP cage & PHY (e.g. Turris Omnia)

2019-01-03 Thread Klaus Kudielka
On 31.12.18 18:43, Andrew Lunn wrote: The Marvell documentation is not public. I would have to check, but i think there is a bit which tells you. But as Florian pointed out, this can be indirectly controlled from software, in that a PHY which is configured down will never get link, in the same w

Re: PROBLEM: xfrm: XFRMINSTATEMODEERROR for transport mode IPsec SA when IP VTI is active

2019-01-03 Thread Steffen Klassert
On Sat, Dec 22, 2018 at 06:38:57PM +0800, Lemon Lam wrote: > Thanks Steffen, but I don't think it is the case. > > I shut down VTI interface toward another VPS and GRE on top of it, > enabled the plain GRE for transport SA. It works on one end, but not for > the other end which has to leave VTI wi

[PATCH] fsl/fman: avoid sleeping in atomic context while adding an address

2019-01-03 Thread Yi Wang
From: Junhua Huang dev_set_rx_mode will call function pointer mac_dev->add_hash_mac_addr while holding spin_lock_bh. The function pointer points to memac_add_hash_mac_address when ethernet type is fman-memac, which will kmalloc use GFP_KERNEL flag. / # ifconfig eth2 192.168.1.168 [ 576.604544]

Re: [PATCH V3] net: phy: tja11xx: Add TJA11xx PHY driver

2019-01-03 Thread Marek Vasut
On 1/4/19 3:57 AM, Florian Fainelli wrote: > > > On 1/3/2019 6:53 PM, Marek Vasut wrote: >> On 1/4/19 3:19 AM, Marek Vasut wrote: >> >> [...] >> >> On a separate note, I was pondering about the master/slave mode of the >> TJA11xx PHY. Right now, the driver only operates in Automatic mode, >> howe

[Patch net] xfrm: fix reinsert in xfrm_hash_rebuild()

2019-01-03 Thread Cong Wang
xfrm_hash_rebuild() re-inserts existing policies into the hashtables, so it should not insert a same policy in the same place twice. This means we have to pass excl==1 to xfrm_policy_inexact_insert() and ignore the -EEXIST error. Otherwise we end up having an entry in the hashtable points to itself

Re: [GIT] Networking

2019-01-03 Thread pr-tracker-bot
The pull request you sent on Wed, 02 Jan 2019 22:12:13 -0800 (PST): > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net master has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/43d86ee8c639df750529b4d8f062b328b61c423e Thank you! -- Deet-doot-dot, I am a bot. http

Re: [PATCH] PCI: Add no-D3 quirk for Mellanox ConnectX-[45]

2019-01-03 Thread David Gibson
On Thu, Dec 06, 2018 at 08:45:09AM +0200, Leon Romanovsky wrote: > On Thu, Dec 06, 2018 at 03:19:51PM +1100, David Gibson wrote: > > Mellanox ConnectX-5 IB cards (MT27800) seem to cause a call trace when > > unbound from their regular driver and attached to vfio-pci in order to pass > > them throug

Re: [PATCH V3] net: phy: tja11xx: Add TJA11xx PHY driver

2019-01-03 Thread Florian Fainelli
On 1/3/2019 6:53 PM, Marek Vasut wrote: > On 1/4/19 3:19 AM, Marek Vasut wrote: > > [...] > > On a separate note, I was pondering about the master/slave mode of the > TJA11xx PHY. Right now, the driver only operates in Automatic mode, > however the PHY can be force-configured as either master

Re: [PATCH V3] net: phy: tja11xx: Add TJA11xx PHY driver

2019-01-03 Thread Marek Vasut
On 1/3/19 7:23 AM, Heiner Kallweit wrote: > On 03.01.2019 03:09, Marek Vasut wrote: >> On 12/23/18 10:16 AM, Marek Vasut wrote: >>> On 12/22/18 6:39 PM, Heiner Kallweit wrote: On 22.12.2018 00:35, Marek Vasut wrote: > Add driver for the NXP TJA1100 and TJA1101 PHYs. These PHYs are special

Re: [PATCH 10/19] usbnet: smsc95xx: Replace smsc95xx_mdio_read() with phy_read()

2019-01-03 Thread Marek Vasut
On 1/3/19 2:39 PM, Andrew Lunn wrote: >> static int get_mdix_status(struct net_device *net) >> { >> struct usbnet *dev = netdev_priv(net); >> +struct smsc95xx_priv *pdata = (struct smsc95xx_priv *)(dev->data[0]); >> u32 val; >> int buf; >> >> -buf = smsc95xx_mdio_read(dev

Re: [PATCH V3] net: phy: tja11xx: Add TJA11xx PHY driver

2019-01-03 Thread Marek Vasut
On 1/4/19 3:19 AM, Marek Vasut wrote: [...] On a separate note, I was pondering about the master/slave mode of the TJA11xx PHY. Right now, the driver only operates in Automatic mode, however the PHY can be force-configured as either master or slave. Would using .set_tunable with a new tunable typ

Re: [PATCH 12/19] usbnet: smsc95xx: Replace ad-hoc PHY functions with generic ones

2019-01-03 Thread Marek Vasut
On 1/3/19 2:28 PM, Andrew Lunn wrote: > On Thu, Jan 03, 2019 at 02:10:33AM +0100, Marek Vasut wrote: >> Replace the ad-hoc reimplementation of genphy_soft_reset() and >> genphy_config_aneg() with the generic functions. > > phylib will either call the phy driver specific reset function, or > genphy

Re: [PATCH 09/19] usbnet: smsc95xx: Connect to phydev

2019-01-03 Thread Marek Vasut
On 1/3/19 2:22 PM, Andrew Lunn wrote: > On Thu, Jan 03, 2019 at 02:10:30AM +0100, Marek Vasut wrote: >> Add code to detect and connect to PHY. The internal PHY of the SMSC95xx >> is a regular SMSC LAN8700 and the driver only supports the internal PHY, >> so just use the SMSC PHY driver to configure

Re: [PATCH ghak90 (was ghak32) V4 01/10] audit: collect audit task parameters

2019-01-03 Thread Guenter Roeck
Hi Richard, On Tue, Jul 31, 2018 at 04:07:36PM -0400, Richard Guy Briggs wrote: > The audit-related parameters in struct task_struct should ideally be > collected together and accessed through a standard audit API. > > Collect the existing loginuid, sessionid and audit_context together in a > new

[PATCH V4] net: phy: tja11xx: Add TJA11xx PHY driver

2019-01-03 Thread Marek Vasut
Add driver for the NXP TJA1100 and TJA1101 PHYs. These PHYs are special BroadRReach 100BaseT1 PHYs used in automotive. Signed-off-by: Marek Vasut Cc: Andrew Lunn Cc: Florian Fainelli Cc: Guenter Roeck Cc: Heiner Kallweit Cc: Jean Delvare Cc: linux-hw...@vger.kernel.org --- V2: - Use phy_modi

[net v2] ixgbe: fix Kconfig when driver is not a module

2019-01-03 Thread Jeff Kirsher
The new ability added to the driver to use mii_bus to handle MII related ioctls is causing compile issues when the driver is compiled into the kernel (i.e. not a module). The simple solution of requiring the driver to be compiled as a module when MDIO_BUS is a module, causes a recursion Kconfig is

Re: [PATCH] ixgbe: fix Kconfig when driver is not a module

2019-01-03 Thread Jeff Kirsher
On Fri, 2019-01-04 at 00:00 +, Steve Douthit wrote: > Just tested this against a DSA dev in hardware and it works, but I > still think the simpler solution would be to just select PHYLIB: > > diff --git a/drivers/net/ethernet/intel/Kconfig > b/drivers/net/ethernet/intel/Kconfig > index 31fb76e

Re: [PATCH 3/8] i40e: increase indentation

2019-01-03 Thread Jeff Kirsher
On Thu, 2019-01-03 at 16:37 -0800, David Miller wrote: > From: Jeff Kirsher > Date: Thu, 03 Jan 2019 15:58:10 -0800 > > > On Sun, 2018-12-30 at 16:53 +0100, Julia Lawall wrote: > > > Convert spaces to tabs to get correct alignment. > > > > > > Found with the help of Coccinelle. > > > > > > Sign

Re: [PATCH net-next] Amiga PCMCIA 100 MBit card support

2019-01-03 Thread Michael Schmitz
Hi Andrew, On 31/12/18 11:47 PM, Andrew Lunn wrote: Having so many front end drivers for a chipset should be done in a more modular manner, so that in fact they could all coexist if necessary. Not sure I follow your meaning ... are you suggesting to allow the back end driver to use run-time sel

Re: [PATCH 3/8] i40e: increase indentation

2019-01-03 Thread David Miller
From: Jeff Kirsher Date: Thu, 03 Jan 2019 15:58:10 -0800 > On Sun, 2018-12-30 at 16:53 +0100, Julia Lawall wrote: >> Convert spaces to tabs to get correct alignment. >> >> Found with the help of Coccinelle. >> >> Signed-off-by: Julia Lawall >> >> --- >> drivers/net/ethernet/intel/i40e/i40e_m

Re: [PATCH] ixgbe: fix Kconfig when driver is not a module

2019-01-03 Thread Steve Douthit
On 1/3/19 4:35 PM, Jeff Kirsher wrote: > The new ability added to the driver to use mii_bus to handle MII related > ioctls is causing compile issues when the driver is compiled into the > kernel (i.e. not a module). > > The simple solution of requiring the driver to be compiled as a module when >

RE: [Intel-wired-lan] [PATCH] ixgbe: fix Kconfig when driver is not a module

2019-01-03 Thread Bowers, AndrewX
> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On > Behalf Of Jeff Kirsher > Sent: Thursday, January 3, 2019 1:35 PM > To: intel-wired-...@lists.osuosl.org > Cc: netdev@vger.kernel.org; Florian Fainelli ; Dave > Jones > Subject: [Intel-wired-lan] [

Re: [PATCH 3/8] i40e: increase indentation

2019-01-03 Thread Jeff Kirsher
On Sun, 2018-12-30 at 16:53 +0100, Julia Lawall wrote: > Convert spaces to tabs to get correct alignment. > > Found with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > drivers/net/ethernet/intel/i40e/i40e_main.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Ack

Re: "bpf: Improve the info.func_info and info.func_info_rec_size behavior" breaks strace self tests

2019-01-03 Thread Martin Lau
On Thu, Jan 03, 2019 at 11:41:18PM +0100, Heiko Carstens wrote: > On Thu, Jan 03, 2019 at 07:12:05PM +, Martin Lau wrote: > > On Thu, Jan 03, 2019 at 12:46:13PM +0100, Heiko Carstens wrote: > > > Hello, > > > > > > the kernel commit 7337224fc150 ("bpf: Improve the info.func_info and > > > info

Re: [PATCH net-next v2] Documentation: networking: Clarify switchdev devices behavior

2019-01-03 Thread Randy Dunlap
Hi, Comments below. On 1/3/19 2:47 PM, Florian Fainelli wrote: > This patch provides details on the expected behavior of switchdev > enabled network devices when operating in a "stand alone" mode, as well > as when being bridge members. This clarifies a number of things that > recently came up d

Re: [PATCH bpf v3 8/9] bpf: prevent out of bounds speculation on pointer arithmetic

2019-01-03 Thread Daniel Borkmann
Hi Jann, On 01/03/2019 10:13 PM, Jann Horn wrote: > Hi! > > Sorry about the extremely slow reply, I was on vacation over the > holidays and only got back today. > > On Thu, Jan 3, 2019 at 12:58 AM Daniel Borkmann wrote: >> Jann reported that the original commit back in b2157399cc98 >> ("bpf: pr

[PATCH net-next v2] Documentation: networking: Clarify switchdev devices behavior

2019-01-03 Thread Florian Fainelli
This patch provides details on the expected behavior of switchdev enabled network devices when operating in a "stand alone" mode, as well as when being bridge members. This clarifies a number of things that recently came up during a bug fixing session on the b53 DSA switch driver. Signed-off-by: F

[PATCH bpf 0/2] bpf: Fix [::] -> [::1] rewrite in sys_sendmsg

2019-01-03 Thread Andrey Ignatov
The patch set fixes BSD'ism in sys_sendmsg to rewrite unspecified destination IPv6 for unconnected UDP sockets in sys_sendmsg with [::1] in case when either CONFIG_CGROUP_BPF is enabled or when sys_sendmsg BPF hook sets destination IPv6 to [::]. Patch 1 is the fix and provides more details. Patch

[PATCH bpf 2/2] selftests/bpf: Test [::] -> [::1] rewrite in sys_sendmsg in test_sock_addr

2019-01-03 Thread Andrey Ignatov
Test that sys_sendmsg BPF hook doesn't break sys_sendmsg behaviour to rewrite destination IPv6 = [::] with [::1] (BSD'ism). Two test cases are added: 1) User passes dst IPv6 = [::] and BPF_CGROUP_UDP6_SENDMSG program doesn't touch it. 2) User passes dst IPv6 != [::], but BPF_CGROUP_UDP6_SENDM

[PATCH bpf 1/2] bpf: Fix [::] -> [::1] rewrite in sys_sendmsg

2019-01-03 Thread Andrey Ignatov
sys_sendmsg has supported unspecified destination IPv6 (wildcard) for unconnected UDP sockets since 876c7f41. When [::] is passed by user as destination, sys_sendmsg rewrites it with [::1] to be consistent with BSD (see "BSD'ism" comment in the code). This didn't work when cgroup-bpf was enabled t

Re: "bpf: Improve the info.func_info and info.func_info_rec_size behavior" breaks strace self tests

2019-01-03 Thread Heiko Carstens
On Thu, Jan 03, 2019 at 07:12:05PM +, Martin Lau wrote: > On Thu, Jan 03, 2019 at 12:46:13PM +0100, Heiko Carstens wrote: > > Hello, > > > > the kernel commit 7337224fc150 ("bpf: Improve the info.func_info and > > info.func_info_rec_size behavior") breaks one of strace's self tests: > > > > F

Re: [PATCH RFC net-next 00/19] Devlink health reporting and recovery system

2019-01-03 Thread Jakub Kicinski
On Thu, 3 Jan 2019 13:31:59 +, Eran Ben Elisha wrote: > Arch wise those are two different features which we shouldn't mix. > The region dump is aiming at dumping of information for monitoring of > "HW memory" at real time, more like a dumb channel to provide memory > chunks from HW to user.

Re: [PATCH net] ipv6: Consider sk_bound_dev_if when binding a socket to an address

2019-01-03 Thread Ralf Jung
Hi all, thanks a lot! I can confirm that this fixes my test script. Kind regards, Ralf On 03.01.19 03:57, David Ahern wrote: > From: David Ahern > > IPv6 does not consider if the socket is bound to a device when binding > to an address. The result is that a socket can be bound to eth0 and the

Re: [PATCH] net: dsa: mt7530: Drop unused GPIO include

2019-01-03 Thread Vivien Didelot
On Thu, 3 Jan 2019 22:31:32 +0100, Linus Walleij wrote: > This driver uses GPIO descriptors only, > is not used so drop the include. > > Signed-off-by: Linus Walleij Reviewed-by: Vivien Didelot

Re: kernel panic: stack is corrupted in udp4_lib_lookup2

2019-01-03 Thread Stefano Brivio
On Thu, 3 Jan 2019 15:15:06 -0600 Willem de Bruijn wrote: > syzbot generated stack traces with > > [ 183.517380] udpv6_err+0x46/0x60 > [ 183.520739] ? __udp6_lib_err+0x1890/0x1890 > [ 183.525054] gue6_err_proto_handler+0x199/0x280 Where? I can't find that in any logs linked from the dashb

Re: Problem with queuing vlan tagged packets after migration from 3.16.0 to 4.9.0

2019-01-03 Thread Anton Danilov
Hi. There is the workaround - classify the packets with iptables+ipset - it's enough fast and more friendly. On Fri, 4 Jan 2019 at 00:21, Bartek Kois wrote: > > Hi > 1. What exactly caused this change in the kernel? > 2. I don`t understand why adding VLAN tag, which is just 4 additional > bytes

Re: [PATCH] ixgbe: fix Kconfig when driver is not a module

2019-01-03 Thread Jeff Kirsher
On Thu, 2019-01-03 at 13:35 -0800, Jeff Kirsher wrote: > The new ability added to the driver to use mii_bus to handle MII > related > ioctls is causing compile issues when the driver is compiled into the > kernel (i.e. not a module). > > The simple solution of requiring the driver to be compiled a

[PATCH] ixgbe: fix Kconfig when driver is not a module

2019-01-03 Thread Jeff Kirsher
The new ability added to the driver to use mii_bus to handle MII related ioctls is causing compile issues when the driver is compiled into the kernel (i.e. not a module). The simple solution of requiring the driver to be compiled as a module when MDIO_BUS is a module, causes a recursion Kconfig is

[PATCH] net: dsa: mt7530: Drop unused GPIO include

2019-01-03 Thread Linus Walleij
This driver uses GPIO descriptors only, is not used so drop the include. Signed-off-by: Linus Walleij --- drivers/net/dsa/mt7530.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index 74547f43b938..a8a2c728afba 100644 --- a/drivers/net/dsa

Re: kernel panic: stack is corrupted in udp4_lib_lookup2

2019-01-03 Thread Willem de Bruijn
On Thu, Jan 3, 2019 at 2:07 PM Stefano Brivio wrote: > > On Thu, 3 Jan 2019 12:01:29 -0800 > Eric Dumazet wrote: > > > On 01/03/2019 05:07 AM, syzbot wrote: > > > Hello, > > > > > > syzbot found the following crash on: > > > > > > HEAD commit:195303136f19 Merge tag 'kconfig-v4.21-2' of > > >

Re: [PATCH bpf v3 8/9] bpf: prevent out of bounds speculation on pointer arithmetic

2019-01-03 Thread Jann Horn
Hi! Sorry about the extremely slow reply, I was on vacation over the holidays and only got back today. On Thu, Jan 3, 2019 at 12:58 AM Daniel Borkmann wrote: > Jann reported that the original commit back in b2157399cc98 > ("bpf: prevent out-of-bounds speculation") was not sufficient > to stop CP

Re: [PATCH] can: gw: ensure DLC boundaries after CAN frame modification

2019-01-03 Thread Oliver Hartkopp
Hi Michal, On 1/3/19 9:33 PM, Michal Kubecek wrote: On Thu, Jan 03, 2019 at 08:31:51PM +0100, Oliver Hartkopp wrote: Anyway your modification makes definitely sense, as it allows to process CAN FD frames in struct canfd_frame as long as only data is modified that is also available in a struct

Re: [PATCH bpf 1/2] bpftool: support queues and stacks in update command

2019-01-03 Thread Stanislav Fomichev
On Thu, Jan 3, 2019 at 11:43 AM Jakub Kicinski wrote: > > On Thu, 3 Jan 2019 10:33:05 -0800, Stanislav Fomichev wrote: > > Bpftool expects both key and value for 'update' operations. For some > > map types, key should not be specified. Support updating those map types. > > > > Before: > > bpftool

[PATCH net 2/2] fou6: Prevent unbounded recursion in GUE error handler

2019-01-03 Thread Stefano Brivio
I forgot to deal with IPv6 in commit 11789039da53 ("fou: Prevent unbounded recursion in GUE error handler"). Now syzbot reported what might be the same type of issue, caused by gue6_err(), that is, handling exceptions for direct UDP encapsulation in GUE (UDP-in-UDP) leads to unbounded recursion in

[PATCH net 1/2] fou: Prevent unbounded recursion in GUE error handler also with UDP-Lite

2019-01-03 Thread Stefano Brivio
In commit 11789039da53 ("fou: Prevent unbounded recursion in GUE error handler"), I didn't take care of the case where UDP-Lite is encapsulated into UDP or UDP-Lite with GUE. From a syzbot report about a possibly similar issue with GUE on IPv6, I just realised the same thing might happen with a UDP

[PATCH net 0/2] Fix two further potential unbounded recursions in GUE error handlers

2019-01-03 Thread Stefano Brivio
Patch 1/2 takes care of preventing the issue fixed by commit 11789039da53 ("fou: Prevent unbounded recursion in GUE error handler") also with UDP-Lite payloads -- I just realised this might happen from a syzbot report. Patch 2/2 fixes the issue for both UDP and UDP-Lite on IPv6, which I also forgo

Re: Problem with queuing vlan tagged packets after migration from 3.16.0 to 4.9.0

2019-01-03 Thread Cong Wang
On Thu, Jan 3, 2019 at 7:25 AM Bartek Kois wrote: > > Hi > 1. What exactly caused this change in the kernel? I don't follow VLAN changes, I guess it must be some change which inserts the VLAN tag before this ->ndo_start_xmit(). > 2. I don`t understand why adding VLAN tag, which is just 4 addi

Re: [PATCH] can: gw: ensure DLC boundaries after CAN frame modification

2019-01-03 Thread Michal Kubecek
On Thu, Jan 03, 2019 at 08:31:51PM +0100, Oliver Hartkopp wrote: > Hi Michal, > > On 1/3/19 3:01 PM, Michal Kubecek wrote: > > On Thu, Jan 03, 2019 at 01:26:34PM +0100, Oliver Hartkopp wrote: > (..) > > > /* check for checksum updates when the CAN frame has been > > > modified */ > > >

Re: [PATCH ghak90 (was ghak32) V4 00/10] audit: implement container identifier

2019-01-03 Thread Richard Guy Briggs
On 2019-01-03 10:58, Guenter Roeck wrote: > Hi Richard, > > On Thu, Jan 03, 2019 at 12:36:13PM -0500, Richard Guy Briggs wrote: > > On 2019-01-03 08:15, Guenter Roeck wrote: > > > Hi, > > > > > > On Tue, Jul 31, 2018 at 04:07:35PM -0400, Richard Guy Briggs wrote: > > > > Implement kernel audit co

Re: [PATCH net] net: phy: replace preliminary fix for PHY driver sometimes not binding to the device

2019-01-03 Thread Heiner Kallweit
On 29.12.2018 12:46, Norbert Jurkeit wrote: > Am 29.12.18 um 03:48 schrieb Florian Fainelli: >> Heiner; are you positive that the PHY is not in a power down mode >> (BMCR.PDOWN = 1) at the time the r8169 probe is done? Because if that >> was the case, there is no guarantee (per 802.3 clause 22 spec

Re: [PATCH ghak90 (was ghak32) V4 00/10] audit: implement container identifier

2019-01-03 Thread Paul Moore
On Thu, Jan 3, 2019 at 12:36 PM Richard Guy Briggs wrote: > On 2019-01-03 08:15, Guenter Roeck wrote: > > Hi, > > > > On Tue, Jul 31, 2018 at 04:07:35PM -0400, Richard Guy Briggs wrote: > > > Implement kernel audit container identifier. > > > > I don't see a follow-up submission of this patch seri

Re: kernel panic: stack is corrupted in udp4_lib_lookup2

2019-01-03 Thread Stefano Brivio
On Thu, 3 Jan 2019 12:01:29 -0800 Eric Dumazet wrote: > On 01/03/2019 05:07 AM, syzbot wrote: > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:    195303136f19 Merge tag 'kconfig-v4.21-2' of git://git.kern.. > > git tree:   upstream > > console output: https://syz

Re: kernel panic: stack is corrupted in udp4_lib_lookup2

2019-01-03 Thread Eric Dumazet
On 01/03/2019 05:07 AM, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:    195303136f19 Merge tag 'kconfig-v4.21-2' of git://git.kern.. > git tree:   upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=12245d8f40 > kernel config:  https

Re: kernel panic: stack is corrupted in udp4_lib_lookup2

2019-01-03 Thread Stefano Brivio
Hi Willem, On Thu, 3 Jan 2019 13:41:43 -0600 Willem de Bruijn wrote: > On Thu, Jan 3, 2019 at 1:39 PM Willem de Bruijn > wrote: > > > > On Thu, Jan 3, 2019 at 7:07 AM syzbot > > wrote: > > > > > > Hello, > > > > > > syzbot found the following crash on: > > > > > > HEAD commit:195303136f1

Re: [PATCH bpf 1/2] bpftool: support queues and stacks in update command

2019-01-03 Thread Jakub Kicinski
On Thu, 3 Jan 2019 10:33:05 -0800, Stanislav Fomichev wrote: > Bpftool expects both key and value for 'update' operations. For some > map types, key should not be specified. Support updating those map types. > > Before: > bpftool map create /sys/fs/bpf/q type queue value 4 entries 10 name q > bpf

Re: kernel panic: stack is corrupted in udp4_lib_lookup2

2019-01-03 Thread Willem de Bruijn
On Thu, Jan 3, 2019 at 1:39 PM Willem de Bruijn wrote: > > On Thu, Jan 3, 2019 at 7:07 AM syzbot > wrote: > > > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:195303136f19 Merge tag 'kconfig-v4.21-2' of git://git.kern.. > > git tree: upstream > > console outpu

Re: kernel panic: stack is corrupted in udp4_lib_lookup2

2019-01-03 Thread Willem de Bruijn
On Thu, Jan 3, 2019 at 7:07 AM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:195303136f19 Merge tag 'kconfig-v4.21-2' of git://git.kern.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=12245d8f40 > kernel config:

Re: [PATCH] can: gw: ensure DLC boundaries after CAN frame modification

2019-01-03 Thread Oliver Hartkopp
Hi Michal, On 1/3/19 3:01 PM, Michal Kubecek wrote: On Thu, Jan 03, 2019 at 01:26:34PM +0100, Oliver Hartkopp wrote: (..) /* check for checksum updates when the CAN frame has been modified */ if (modidx) { + /* ensure DLC boundaries after the different mods */ +

Re: "bpf: Improve the info.func_info and info.func_info_rec_size behavior" breaks strace self tests

2019-01-03 Thread Martin Lau
On Thu, Jan 03, 2019 at 12:46:13PM +0100, Heiko Carstens wrote: > Hello, > > the kernel commit 7337224fc150 ("bpf: Improve the info.func_info and > info.func_info_rec_size behavior") breaks one of strace's self tests: > > FAIL: bpf-obj_get_info_by_fd-prog-v.gen The strace's bpf-obj_get_info_by_fd

Re: [PATCH ghak90 (was ghak32) V4 00/10] audit: implement container identifier

2019-01-03 Thread Guenter Roeck
Hi Richard, On Thu, Jan 03, 2019 at 12:36:13PM -0500, Richard Guy Briggs wrote: > On 2019-01-03 08:15, Guenter Roeck wrote: > > Hi, > > > > On Tue, Jul 31, 2018 at 04:07:35PM -0400, Richard Guy Briggs wrote: > > > Implement kernel audit container identifier. > > > > I don't see a follow-up submi

[PATCH bpf] selftests/bpf: fix incorrect users of create_and_get_cgroup

2019-01-03 Thread Stanislav Fomichev
create_and_get_cgroup returns 0 on error, fix the users that assume negative value in case of an error. Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/bpf/get_cgroup_id_user.c | 2 +- tools/testing/selftests/bpf/test_sockmap.c | 2 +- 2 files changed, 2 insertions(+), 2 dele

[PATCH bpf 2/2] bpftool: support queues and stacks in lookup command

2019-01-03 Thread Stanislav Fomichev
Bpftool expects key for 'lookup' operations. For some map types, key should not be specified. Support looking up those map types. Before: bpftool map create /sys/fs/bpf/q type queue value 4 entries 10 name q bpftool map update pinned /sys/fs/bpf/q value 0 1 2 3 bpftool map lookup pinned /sys/fs/bp

[PATCH bpf 1/2] bpftool: support queues and stacks in update command

2019-01-03 Thread Stanislav Fomichev
Bpftool expects both key and value for 'update' operations. For some map types, key should not be specified. Support updating those map types. Before: bpftool map create /sys/fs/bpf/q type queue value 4 entries 10 name q bpftool map update pinned /sys/fs/bpf/q value 0 1 2 3 Error: did not find key

[PATCH net] openvswitch: Fix IPv6 later frags parsing

2019-01-03 Thread Yi-Hung Wei
The previous commit fa642f08839b ("openvswitch: Derive IP protocol number for IPv6 later frags") introduces IP protocol number parsing for IPv6 later frags that can mess up the network header length calculation logic, i.e. nh_len < 0. However, the network header length calculation is mainly for der

Re: [PATCH net-next] net: hns3: Config NIC port speed same as that of optical module

2019-01-03 Thread dann frazier
On Wed, Jan 02, 2019 at 08:45:36PM +0800, lipeng (Y) wrote: > > > On 2019/1/1 9:22, dann frazier wrote: > > On Mon, Nov 26, 2018 at 06:43:00PM +, Salil Mehta wrote: > > > From: Peng Li > > > > > > Port 0/1 of HiP08 supports 10G and 25G. This patch adds a > > > change to configure NIC port s

Re: [PATCH net-next] svcrdma: Fix an uninitialized variable false warning

2019-01-03 Thread Bart Van Assche
On Fri, 2018-12-28 at 10:36 -0500, Chuck Lever wrote: > > On Dec 20, 2018, at 4:49 AM, YueHaibing wrote: > > > > smatch warning this: > > net/sunrpc/xprtrdma/svc_rdma_rw.c:351 svc_rdma_post_chunk_ctxt() error: > > uninitialized symbol 'bad_wr' > > net/sunrpc/xprtrdma/verbs.c:1569 rpcrdma_post_re

Re: [PATCH ghak90 (was ghak32) V4 00/10] audit: implement container identifier

2019-01-03 Thread Richard Guy Briggs
On 2019-01-03 08:15, Guenter Roeck wrote: > Hi, > > On Tue, Jul 31, 2018 at 04:07:35PM -0400, Richard Guy Briggs wrote: > > Implement kernel audit container identifier. > > I don't see a follow-up submission of this patch series. Has it been > abandoned, > or do I use the wrong search terms ? G

Re: [RFC bpf-next v3 6/9] tools: bpftool: add probes for eBPF helper functions

2019-01-03 Thread Quentin Monnet
2019-01-03 09:15 UTC-0800 ~ Stanislav Fomichev > On Thu, Jan 3, 2019 at 6:03 AM Quentin Monnet > wrote: >> >> Similarly to what was done for program types and map types, add a set of >> probes to test the availability of the different eBPF helper functions >> on the current system. >> >> For each

[PATCH v4 1/2] net/mlx4: Get rid of page operation after dma_alloc_coherent

2019-01-03 Thread Stephen Warren
From: Stephen Warren This patch solves a crash at the time of mlx4 driver unload or system shutdown. The crash occurs because dma_alloc_coherent() returns one value in mlx4_alloc_icm_coherent(), but a different value is passed to dma_free_coherent() in mlx4_free_icm_coherent(). In turn this is be

[PATCH v4 2/2] net/mlx4: replace pci_{,un}map_sg with dma_{,un}map_sg

2019-01-03 Thread Stephen Warren
From: Stephen Warren pci_{,un}map_sg are deprecated and replaced by dma_{,un}map_sg. This is especially relevant since the rest of the driver uses the DMA API. Fix the driver to use the replacement APIs. Signed-off-by: Stephen Warren --- v4: New patch. --- drivers/net/ethernet/mellanox/mlx4/ic

Re: [RFC bpf-next v3 6/9] tools: bpftool: add probes for eBPF helper functions

2019-01-03 Thread Stanislav Fomichev
On Thu, Jan 3, 2019 at 6:03 AM Quentin Monnet wrote: > > Similarly to what was done for program types and map types, add a set of > probes to test the availability of the different eBPF helper functions > on the current system. > > For each known program type, all known helpers are tested, in orde

Re: [PATCH ghak90 (was ghak32) V4 00/10] audit: implement container identifier

2019-01-03 Thread Guenter Roeck
Hi, On Tue, Jul 31, 2018 at 04:07:35PM -0400, Richard Guy Briggs wrote: > Implement kernel audit container identifier. > I don't see a follow-up submission of this patch series. Has it been abandoned, or do I use the wrong search terms ? Thanks, Guenter > This patchset is a fourth based on the

Re: [PATCH] net: dsa: microchip: Drop unused GPIO includes

2019-01-03 Thread Vivien Didelot
On Thu, 3 Jan 2019 13:36:43 +0100, Linus Walleij wrote: > This driver does not use the old GPIO includes so drop > them. > > Signed-off-by: Linus Walleij Reviewed-by: Vivien Didelot

Re: Problem with queuing vlan tagged packets after migration from 3.16.0 to 4.9.0

2019-01-03 Thread Bartek Kois
Hi 1. What exactly caused this change in the kernel? 2. I don`t understand why adding VLAN tag, which is just 4  additional bytes to the passing packet make it impossible to classify. 3. This whole thing makes the QoS under Linux routers hard to configure in scenarios with more than one VLAN whi

Re: [PATCH RFC 0/4] barriers using data dependency

2019-01-03 Thread Alan Stern
On Wed, 2 Jan 2019, Michael S. Tsirkin wrote: > On Wed, Jan 02, 2019 at 04:36:40PM -0500, Alan Stern wrote: > > On Wed, 2 Jan 2019, Michael S. Tsirkin wrote: > > > > > So as explained in Documentation/memory-barriers.txt e.g. > > > a load followed by a store require a full memory barrier, > > > t

[PATCH] net: macb: remove unnecessary code

2019-01-03 Thread Claudiu.Beznea
From: Claudiu Beznea Commit 653e92a9175e ("net: macb: add support for padding and fcs computation") introduced a bug fixed by commit 899ecaedd155 ("net: ethernet: cadence: fix socket buffer corruption problem"). Code removed in this patch is not reachable at all so remove it. Fixes: 653e92a9175e

Re: [PATCH V3] net/mlx4: Get rid of page operation after dma_alloc_coherent

2019-01-03 Thread Tariq Toukan
On 1/2/2019 6:29 PM, Stephen Warren wrote: > On 12/20/18 10:43 AM, Jason Gunthorpe wrote: >> On Wed, Dec 19, 2018 at 11:20:31AM -0700, Stephen Warren wrote: >>> From: Stephen Warren >>> >>> This patch solves a crash at the time of mlx4 driver unload or system >>> shutdown. The crash occurs becau

Re: [PATCH RFC 1/2] vsock/virtio: fix kernel panic after device hot-unplug

2019-01-03 Thread Stefano Garzarella
On Thu, Jan 3, 2019 at 11:03 AM Stefan Hajnoczi wrote: > > On Wed, Jan 02, 2019 at 11:01:27AM +0100, Stefano Garzarella wrote: > > On Wed, Jan 2, 2019 at 10:39 AM Stefan Hajnoczi wrote: > > > > > > On Thu, Dec 20, 2018 at 01:15:34PM +0100, Stefano Garzarella wrote: > > > > diff --git a/net/vmw_vs

[RFC bpf-next v3 5/9] tools: bpftool: add probes for eBPF map types

2019-01-03 Thread Quentin Monnet
Add new probes for eBPF map types, to detect what are the ones available on the system. Try creating one map of each type, and see if the kernel complains. Sample output: # bpftool feature probe kernel ... Scanning eBPF map types... eBPF map_type hash is available eBPF map_typ

[RFC bpf-next v3 0/9] tools: bpftool: add probes for system and device

2019-01-03 Thread Quentin Monnet
Hi, This set adds a new command to bpftool in order to dump a list of eBPF-related parameters for the system (or for a specific network device) to the console. Once again, this is based on a suggestion from Daniel. At this time, output includes: - Availability of bpf() system call - Avail

[RFC bpf-next v3 9/9] tools: bpftool: add bash completion for bpftool probes

2019-01-03 Thread Quentin Monnet
Add the bash completion related to the newly introduced "bpftool feature probe" command. Signed-off-by: Quentin Monnet Reviewed-by: Jakub Kicinski --- tools/bpf/bpftool/bash-completion/bpftool | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tools/bpf/bpftool/bash-comple

[RFC bpf-next v3 8/9] tools: bpftool: add probes for a network device

2019-01-03 Thread Quentin Monnet
bpftool gained support for probing the current system in order to see what program and map types, and what helpers are available on that system. This patch adds the possibility to pass an interface index to libbpf (and hence to the kernel) when trying to load the programs or to create the maps, in

[RFC bpf-next v3 7/9] tools: bpftool: add C-style "#define" output for probes

2019-01-03 Thread Quentin Monnet
Make bpftool able to dump a subset of the parameters collected by probing the system as a listing of C-style #define macros, so that external projects can reuse the result of this probing and build BPF-based project in accordance with the features available on the system. The new "macros" keyword

[RFC bpf-next v3 6/9] tools: bpftool: add probes for eBPF helper functions

2019-01-03 Thread Quentin Monnet
Similarly to what was done for program types and map types, add a set of probes to test the availability of the different eBPF helper functions on the current system. For each known program type, all known helpers are tested, in order to establish a compatibility matrix. Output is provided as a se

[RFC bpf-next v3 1/9] tools: bpftool: add basic probe capability, probe syscall availability

2019-01-03 Thread Quentin Monnet
Add a new component and command for bpftool, in order to probe the system to dump a set of eBPF-related parameters so that users can know what features are available on the system. Parameters are dumped in plain or JSON output (with -j/-p options). The current patch introduces probing of one simp

[RFC bpf-next v3 4/9] tools: bpftool: add probes for eBPF program types

2019-01-03 Thread Quentin Monnet
Introduce probes for supported BPF program types in libbpf, and call it from bpftool to test what types are available on the system. The probe simply consists in loading a very basic program of that type and see if the verifier complains or not. Sample output: # bpftool feature probe kernel

[RFC bpf-next v3 3/9] tools: bpftool: add probes for kernel configuration options

2019-01-03 Thread Quentin Monnet
Add probes to dump a number of options set (or not set) for compiling the kernel image. These parameters provide information about what BPF components should be available on the system. A number of them are not directly related to eBPF, but are in fact used in the kernel as conditions on which to c

[RFC bpf-next v3 2/9] tools: bpftool: add probes for /proc/ eBPF parameters

2019-01-03 Thread Quentin Monnet
Add a set of probes to dump the eBPF-related parameters available from /proc/: availability of bpf() syscall for unprivileged users, JIT compiler status and hardening status, kallsyms exports status. Sample output: # bpftool feature probe kernel Scanning system configuration... bpf()

Re: [PATCH] can: gw: ensure DLC boundaries after CAN frame modification

2019-01-03 Thread Michal Kubecek
On Thu, Jan 03, 2019 at 01:26:34PM +0100, Oliver Hartkopp wrote: > The CAN frame modification rules allow bitwise logical operations which can > be also applied to the can_dlc field. Ensure the manipulation result to > maintain the can_dlc boundaries so that the CAN drivers do not accidently > writ

Re: [PATCH 10/19] usbnet: smsc95xx: Replace smsc95xx_mdio_read() with phy_read()

2019-01-03 Thread Andrew Lunn
> static int get_mdix_status(struct net_device *net) > { > struct usbnet *dev = netdev_priv(net); > + struct smsc95xx_priv *pdata = (struct smsc95xx_priv *)(dev->data[0]); > u32 val; > int buf; > > - buf = smsc95xx_mdio_read(dev->net, dev->mii.phy_id, SPECIAL_CTRL_STS)

Re: [PATCH RFC net-next 00/19] Devlink health reporting and recovery system

2019-01-03 Thread Eran Ben Elisha
On 1/3/2019 12:46 AM, Jakub Kicinski wrote: > On Tue, 1 Jan 2019 09:58:30 +, Eran Ben Elisha wrote: >> On 1/1/2019 3:47 AM, Jakub Kicinski wrote: >>> The addition of "objdump" and its marshalling is a bit disappointing. >>> It seemed to me when region snapshots were added that they would serv

  1   2   >