On Fri, 2019-01-04 at 00:00 +0000, Steve Douthit wrote: > Just tested this against a DSA dev in hardware and it works, but I > still think the simpler solution would be to just select PHYLIB: > > diff --git a/drivers/net/ethernet/intel/Kconfig > b/drivers/net/ethernet/intel/Kconfig > index 31fb76ee9d82..a1246e89aad4 100644 > --- a/drivers/net/ethernet/intel/Kconfig > +++ b/drivers/net/ethernet/intel/Kconfig > @@ -159,7 +159,7 @@ config IXGBE > tristate "Intel(R) 10GbE PCI Express adapters support" > depends on PCI > select MDIO > - select MDIO_DEVICE > + select PHYLIB > imply PTP_1588_CLOCK > ---help--- > This driver supports Intel(R) 10GbE PCI Express family of > > That seems to be the pattern for most of the other ethernet adapters: > $ grep -r 'select PHYLIB' drivers/net/ethernet/ | wc -l > 71 > > vs checking MDIO_BUS (not counting this patch): > $ grep -r 'depends on.*MDIO_BUS' drivers/net/ethernet/ | wc -l > 0
I initially tried that, but we get a recursive Kconfig dependency error when IPSec is enabled as well, which I noted in the commit message. I agree the help text could be expanded to include the clause 22/45 address information, so I will submit a v2 of the patch.
signature.asc
Description: This is a digitally signed message part
