On 1/4/19 3:57 AM, Florian Fainelli wrote: > > > On 1/3/2019 6:53 PM, Marek Vasut wrote: >> On 1/4/19 3:19 AM, Marek Vasut wrote: >> >> [...] >> >> On a separate note, I was pondering about the master/slave mode of the >> TJA11xx PHY. Right now, the driver only operates in Automatic mode, >> however the PHY can be force-configured as either master or slave. >> Would using .set_tunable with a new tunable type be a good way to expose >> this to userspace ? The ethtool can then configure the PHY mode. > > Using an ethtool u8 tunable would be fine, with something like: > > 0 -> automatic > 1 -> force master > 2 -> force slave
Fine, however I'll send it as a separate patch later. How does this name/macro sound for the tunable ? [ETHTOOL_PHY_BRR_MODE] = "phy-broadrreach-mode", -- Best regards, Marek Vasut
