[PATCH net] net: phy: Fix the issue that netif always links up after resuming

2018-12-17 Thread Kunihiko Hayashi
Even though the link is down before entering hibernation, there is an issue that the network interface always links up after resuming from hibernation. If the link is still down before enabling the network interface, and after resuming from hibernation, the phydev->state is forcibly set to PHY_UP

Re: [PATCH net-next] net: dsa: microchip: fix VLAN filtering operation

2018-12-17 Thread David Miller
From: Date: Mon, 17 Dec 2018 19:31:21 -0800 > From: Tristram Ha > > Fix VLAN filtering operation in kernel 4.15 and later. > > Fixes: b987e98e50ab90e5 ("dsa: add DSA switch driver for Microchip KSZ9477") > Signed-off-by: Tristram Ha If this is a bug fix for v4.15 and later it should target '

Re: [PATCH net-next] nfp: flower: fix cb_ident duplicate in indirect block register

2018-12-17 Thread David Miller
From: Jakub Kicinski Date: Mon, 17 Dec 2018 19:18:39 -0800 > From: John Hurley > > Previously the identifier used for indirect block callback registry and > for block rule cb registry (when done via indirect blocks) was the pointer > to the netdev we were interested in receiving updates on. Thi

Re: [PATCH net-next] mlxsw: spectrum: Update the supported firmware to version 13.1910.622

2018-12-17 Thread David Miller
From: Ido Schimmel Date: Tue, 18 Dec 2018 07:31:31 + > From: Shalom Toledo > > This new firmware contains: > * New packet traps for discarded packets > * Secure firmware flash bug fix > * Fence mechanism bug fix > * TCAM RMA bug fix > > Signed-off-by: Shalom Toledo > Signed-off-by: Id

Re: [PATCH net-next] ip6mr: Drop mfc6_cache argument to ip6mr_forward2

2018-12-17 Thread David Miller
From: David Ahern Date: Mon, 17 Dec 2018 15:36:11 -0800 > From: David Ahern > > mfc6_cache is not needed by ip6mr_forward2 so drop it from the input > argument list. > > Signed-off-by: David Ahern Applied.

Re: [PATCH net-next] ipmr: Drop mfc_cache argument to ipmr_queue_xmit

2018-12-17 Thread David Miller
From: David Ahern Date: Mon, 17 Dec 2018 15:34:48 -0800 > From: David Ahern > > mfc_cache is not needed by ipmr_queue_xmit so drop it from the input > argument list. > > Signed-off-by: David Ahern Applied.

[PATCH net-next] mlxsw: spectrum: Update the supported firmware to version 13.1910.622

2018-12-17 Thread Ido Schimmel
From: Shalom Toledo This new firmware contains: * New packet traps for discarded packets * Secure firmware flash bug fix * Fence mechanism bug fix * TCAM RMA bug fix Signed-off-by: Shalom Toledo Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 4 ++-- 1 fil

Re: [PATCH] net: dsa: mv88e6xxx: set ethtool regs version

2018-12-17 Thread David Miller
From: Vivien Didelot Date: Mon, 17 Dec 2018 16:05:21 -0500 > From: Vivien Didelot > > Currently the ethtool_regs version is set to 0 for all DSA drivers. > > Use this field to store the chip ID to simplify the pretty dump of > any interfaces registered by the "dsa" driver. > > Signed-off-by:

Re: [PATCH net 0/2] SO_TIMESTAMPING fixes

2018-12-17 Thread David Miller
From: Willem de Bruijn Date: Mon, 17 Dec 2018 12:23:58 -0500 > From: Willem de Bruijn > > Fix two omissions: > > - tx timestamping is missing for AF_INET6/SOCK_RAW/IPPROTO_RAW > - SOF_TIMESTAMPING_OPT_ID is missing for IPPROTO_RAW, PF_PACKET, CAN > > Discovered while expanding the selftest in

Re: [PATCH net-next v2] net: dccp: initialize (addr,port) listening hashtable

2018-12-17 Thread David Miller
From: Peter Oskolkov Date: Sun, 16 Dec 2018 15:42:48 -0800 > Commit d9fbc7f6431f "net: tcp: prefer listeners bound to an address" > removes port-only listener lookups. This caused segfaults in DCCP > lookups because DCCP did not initialize the (addr,port) hashtable. > > This patch adds said init

Re: [PATCH net-next 00/13] bnxt_en: Updates for net-next.

2018-12-17 Thread David Miller
From: Michael Chan Date: Sun, 16 Dec 2018 18:46:18 -0500 > Two main changes in this seris plus some miscellaneous changes. > > 1. Improvements and fixes for resource accounting which are required > for enabling SR-IOV and RDMA on the new 57500 chips. Only SR-IOV > for 57500 chips is enabled in

Re: [PATCH v2] net/smc: fix TCP fallback socket release

2018-12-17 Thread Myungho Jung
On Mon, Dec 17, 2018 at 03:58:58PM +0100, Ursula Braun wrote: > Hi Ursula, Thank you for your suggestion. I have a question on your comment. > > On 12/17/2018 06:21 AM, Myungho Jung wrote: > > clcsock can be released while kernel_accept() references it in TCP > > listen worker. Also, clcsock n

Re: [PATCH net-next] Documentation: networking: Clarify switchdev devices behavior

2018-12-17 Thread Ido Schimmel
On Sun, Dec 16, 2018 at 09:14:09AM -0800, Florian Fainelli wrote: > Le 12/16/18 à 12:25 AM, Ido Schimmel a écrit : > > On Wed, Dec 12, 2018 at 03:09:43PM -0800, Florian Fainelli wrote: > >> +Non-bridged network ports of the same switch fabric must not be disturbed > >> in any > >> +way, shape or f

Re: [RFC PATCH net v3] net: phy: Fix the issue that netif always links up after resuming

2018-12-17 Thread Kunihiko Hayashi
Hi Heiner, On Tue, 18 Dec 2018 07:44:33 +0100 wrote: > On 18.12.2018 07:25, Kunihiko Hayashi wrote: > > Hi Heiner, > > > > On Mon, 17 Dec 2018 19:43:31 +0100 wrote: > > > >> On 17.12.2018 19:41, Heiner Kallweit wrote: > >>> On 17.12.2018 07:41, Kunihiko Hayashi wrote: > Hi, > >

Re: selftests/bpf/test_progs: 32-bit: Unable to handle kernel NULL pointer dereference at virtual address 00000000

2018-12-17 Thread Song Liu
> On Dec 17, 2018, at 10:35 PM, Naresh Kamboju > wrote: > > On Tue, 18 Dec 2018 at 05:38, Daniel Borkmann wrote: >> >> On 12/17/2018 11:22 PM, Song Liu wrote: On Dec 17, 2018, at 6:26 AM, Daniel Borkmann wrote: [ +Song, if you get a chance please take a look at the panic in

Re: [RFC PATCH net v3] net: phy: Fix the issue that netif always links up after resuming

2018-12-17 Thread Heiner Kallweit
On 18.12.2018 07:25, Kunihiko Hayashi wrote: > Hi Heiner, > > On Mon, 17 Dec 2018 19:43:31 +0100 wrote: > >> On 17.12.2018 19:41, Heiner Kallweit wrote: >>> On 17.12.2018 07:41, Kunihiko Hayashi wrote: Hi, Gentle ping... Are there any comments about changes since v2? >>>

[PATCH net-next 2/2] net: phy: remove feature definition from 1Gbps PHY drivers

2018-12-17 Thread Heiner Kallweit
Now that 1Gbps is the default for features, let's remove the setting from quite some drivers. For the realtek driver also remove the basic mode definitions because it uses genphy_config_init() and the missing 1Gbps capability will be autodetected. Signed-off-by: Heiner Kallweit --- drivers/net/p

[PATCH net-next 1/2] net: phy: set 1Gbps as default for driver features

2018-12-17 Thread Heiner Kallweit
Whether a PHY is 100MBps or 1Gbps-capable can be autodetected, therefore it's not needed to define this manually in the driver. genphy_config_init() will remove 1Gbps from phydev->supported if not supported. Having said that PHY drivers for 100Mbps not calling genphy_config_init() still have to set

Re: selftests/bpf/test_progs: 32-bit: Unable to handle kernel NULL pointer dereference at virtual address 00000000

2018-12-17 Thread Naresh Kamboju
On Tue, 18 Dec 2018 at 05:38, Daniel Borkmann wrote: > > On 12/17/2018 11:22 PM, Song Liu wrote: > >> On Dec 17, 2018, at 6:26 AM, Daniel Borkmann wrote: > >> > >> [ +Song, if you get a chance please take a look at the panic in > >> stack_map_get_build_id_offset(), thanks! ] > > > > Thanks Danie

[PATCH net-next 0/2] net: phy: set 1Gbps as default for driver features

2018-12-17 Thread Heiner Kallweit
Whether a PHY is 100Mbps or 1Gbps-capable can be autodetected, therefore it's not needed to define this manually in the driver. genphy_config_init() will remove 1Gbps from phydev->supported if not supported. Having said that PHY drivers for 100Mbps not calling genphy_config_init() still have to set

Re: [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode

2018-12-17 Thread Sergio Paracuellos
Hi Florian, On Mon, Dec 17, 2018 at 11:22 PM Florian Fainelli wrote: > > On 12/17/18 12:44 PM, Sergio Paracuellos wrote: > > Add device-tree binding example of the ksz9477 switch managed in i2c mode. > > > > Cc: devicet...@vger.kernel.org > > Signed-off-by: Sergio Paracuellos > > This looks good

Re: [PATCH RFC net-next] net: dsa: microchip: add KSZ9477 I2C driver

2018-12-17 Thread Sergio Paracuellos
Hi Tristam, On Tue, Dec 18, 2018 at 5:16 AM wrote: > > Sorry about the patch. I know you were using the code from the new SPI and > old I2C drivers to come up with your patch. You can incorporate the changes > and test the driver and re-submit the patch if you want. For me is ok to just use

Re: [PATCH RFC net-next] net: dsa: microchip: add KSZ9477 I2C driver

2018-12-17 Thread Sergio Paracuellos
Hi Tristram, Two minor comments. On Tue, Dec 18, 2018 at 2:40 AM wrote: > > From: Tristram Ha > > Add KSZ9477 I2C driver support. The code ksz9477.c and ksz_common.c are > used together to generate the I2C driver. > > Signed-off-by: Tristram Ha > --- > drivers/net/dsa/microchip/Kconfig

Re: [RFC PATCH net v3] net: phy: Fix the issue that netif always links up after resuming

2018-12-17 Thread Kunihiko Hayashi
Hi Heiner, On Mon, 17 Dec 2018 19:43:31 +0100 wrote: > On 17.12.2018 19:41, Heiner Kallweit wrote: > > On 17.12.2018 07:41, Kunihiko Hayashi wrote: > >> Hi, > >> > >> Gentle ping... > >> Are there any comments about changes since v2? > >> > >> v2: https://www.spinics.net/lists/netdev/msg536926.h

[PATCH net-next] net: phy: mscc: Fix the VSC 8530/31/40/41 Chips Init sequence

2018-12-17 Thread Raju Lakkaraju
From: Raju Lakkaraju Fix the VSC 8530/31/40/41 Chips Init sequence - Turn on Broadcast writes - UNH 1.8.1 clear bias for UNH 1000BT distortion - UNH 1.8.7 optimize pre-emphasis for 100BasTx UNH 100W fix - Enable Token-ring during 'Coma Mode' Signed-off-by: Raju Lakkaraju --- drivers/net/phy/ms

[v2, PATCH 2/2] net-next: stmmac: dwmac-mediatek: remove fine-tune property

2018-12-17 Thread Biao Huang
1. remove fine-tune property and related setting to simplify the timing adjustment flow. 2. set timing value according to the value from device tree, and will not care whether PHY insert internal delay. Signed-off-by: Biao Huang --- .../net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 71 +

[v2, PATCH 0/2] add ethernet binding and modify ethernet driver for mt2712

2018-12-17 Thread Biao Huang
changes in v2 as comments from Sean: 1. fix typo. 2. use capital letters for RMII/MII/RGMII in driver and bindings. v1: This new series is the result of discussion in: http://lkml.org/lkml/2018/12/13/1007 http://lkml.org/lkml/2018/12/14/53 1. ethernet binding file move to this series. 2. remove f

[v2, PATCH 1/2] dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC

2018-12-17 Thread Biao Huang
The commit adds the device tree binding documentation for the MediaTek DWMAC found on MediaTek MT2712. Signed-off-by: Biao Huang --- .../devicetree/bindings/net/mediatek-dwmac.txt | 78 1 file changed, 78 insertions(+) create mode 100644 Documentation/devicetree/bindi

[PATCH net] lan78xx: Resolve issue with changing MAC address

2018-12-17 Thread Jason Martinsen
Current state for the lan78xx driver does not allow for changing the MAC address of the interface, without either removing the module (if you compiled it that way) or rebooting the machine. If you attempt to change the MAC address, ifconfig will show the new address, however, the system/interfa

Re: [PATCH net-next] fou: Prevent unbounded recursion in GUE error handler

2018-12-17 Thread David Miller
From: Stefano Brivio Date: Tue, 18 Dec 2018 00:13:17 +0100 > Handling exceptions for direct UDP encapsulation in GUE (that is, > UDP-in-UDP) leads to unbounded recursion in the GUE exception handler, > syzbot reported. > > While draft-ietf-intarea-gue-06 doesn't explicitly forbid direct > encaps

KASAN: stack-out-of-bounds Read in apparmor_cred_prepare

2018-12-17 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:a28777f25031 ucc_geth: Add change_carrier() for Fixed PHYs git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=16f3a88540 kernel config: https://syzkaller.appspot.com/x/.config?x=d9655b05acfc97ff dash

RE: [PATCH RFC net-next] net: dsa: microchip: add KSZ9477 I2C driver

2018-12-17 Thread Tristram.Ha
Sorry about the patch. I know you were using the code from the new SPI and old I2C drivers to come up with your patch. You can incorporate the changes and test the driver and re-submit the patch if you want. Your i2c_probe function displays an error message when ksz9477_switch_register is not

Re: [PATCH 2/2] net-next: stmmac: dwmac-mediatek: remove fine-tune property

2018-12-17 Thread Sean Wang
On Mon, Dec 17, 2018 at 6:43 PM Biao Huang wrote: > > 1. remove fine-tune property and related setting to simplify > the timing adjustment flow. > 2. set timing value according to the value from device tree, > and will not care whether PHY insert internal delay. > > Signed-off-by: Biao Huang > --

[PATCH net-next] net: dsa: microchip: fix VLAN filtering operation

2018-12-17 Thread Tristram.Ha
From: Tristram Ha Fix VLAN filtering operation in kernel 4.15 and later. Fixes: b987e98e50ab90e5 ("dsa: add DSA switch driver for Microchip KSZ9477") Signed-off-by: Tristram Ha --- drivers/net/dsa/microchip/ksz9477.c | 44 ++--- 1 file changed, 36 insertions(+),

[PATCH net-next] nfp: flower: fix cb_ident duplicate in indirect block register

2018-12-17 Thread Jakub Kicinski
From: John Hurley Previously the identifier used for indirect block callback registry and for block rule cb registry (when done via indirect blocks) was the pointer to the netdev we were interested in receiving updates on. This worked fine if a single app existed that registered one callback per

RE: [PATCH RFC net-next] net: dsa: microchip: add KSZ9477 I2C driver

2018-12-17 Thread Woojung.Huh
Tristram, > +++ b/drivers/net/dsa/microchip/ksz9477_i2c.c .. > +MODULE_AUTHOR("Woojung Huh "); Believe this should be your name. Thanks. Woojung

[PATCH 2/2] net-next: stmmac: dwmac-mediatek: remove fine-tune property

2018-12-17 Thread Biao Huang
1. remove fine-tune property and related setting to simplify the timing adjustment flow. 2. set timing value according to the value from device tree, and will not care whether PHY insert internal delay. Signed-off-by: Biao Huang --- .../net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 71 +

[PATCH 1/2] dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC

2018-12-17 Thread Biao Huang
The commit adds the device tree binding documentation for the MediaTek DWMAC found on MediaTek MT2712. Signed-off-by: Biao Huang --- .../devicetree/bindings/net/mediatek-dwmac.txt | 78 1 file changed, 78 insertions(+) create mode 100644 Documentation/devicetree/bindi

[PATCH 0/2] add ethernet binding and modify ethernet driver for mt2712

2018-12-17 Thread Biao Huang
This new series is the result of discussion in: http://lkml.org/lkml/2018/12/13/1007 http://lkml.org/lkml/2018/12/14/53 1. ethernet binding file move to this series. 2. remove fine tune property in device tree 3. remove fine tune flow in ethernet driver 4. set rgmii timing according to the value i

Re: [PATCH bpf-next v2 0/7] Add support for XDP_ATTACH

2018-12-17 Thread Jakub Kicinski
On Mon, 17 Dec 2018 14:39:57 +0100, Björn Töpel wrote: > OTOH the implementation would probably look different if there was a > per-q program, because this would open up for more optimizations. One > could even imagine that the socket fd was part of the program (part of > relocation process) when l

Re: [PATCH] Export mm_update_next_owner function for vhost-net

2018-12-17 Thread Michael S. Tsirkin
On Tue, Dec 18, 2018 at 09:39:16AM +0800, gchen chen wrote: > Yes, I think so.  > and i think the point is that unuse_mm() can't directly set tsk->mm=NULL. So why can't unuse_mm call mm_update_next_owner? -- MST

[PATCH RFC net-next] net: dsa: microchip: add KSZ9477 I2C driver

2018-12-17 Thread Tristram.Ha
From: Tristram Ha Add KSZ9477 I2C driver support. The code ksz9477.c and ksz_common.c are used together to generate the I2C driver. Signed-off-by: Tristram Ha --- drivers/net/dsa/microchip/Kconfig | 6 + drivers/net/dsa/microchip/Makefile | 1 + drivers/net/dsa/microchip/ksz947

[PATCH RFC net-next] net: dsa: microchip: add KSZ9477 I2C driver

2018-12-17 Thread Tristram.Ha
From: Tristram Ha This patch adds KSZ9477 I2C driver support. I know a patch for KSZ9477 I2C driver was already submitted. There is a minor problem though. The structure and code of the I2C driver should match those in the SPI driver. The only difference is the register access. Accordingly t

Re: [PATCH net-next,v6 00/12] add flow_rule infrastructure

2018-12-17 Thread Jakub Kicinski
On Fri, 14 Dec 2018 19:11:53 +0100, Pablo Neira Ayuso wrote: > Hi, > > This patchset introduces a kernel intermediate representation (IR) to > express ACL hardware offloads, this is heavily based on the existing > flow dissector infrastructure and the TC actions. This IR can be used by > different

[PATCH bpf-next] tools/bpf: check precise {func,line,jited_line}_info_rec_size in test_btf

2018-12-17 Thread Yonghong Song
Current btf func_info, line_info and jited_line are designed to be extensible. The record sizes for {func,line}_info are passed to kernel, and the record sizes for {func,line,jited_line}_info are returned to userspace during bpf_prog_info query. In bpf selftests test_btf.c, when testing whether ke

Re: [PATCH net v2 3/4] vxlan: changelink: Fix handling of default remotes

2018-12-17 Thread Roopa Prabhu
On Mon, Dec 17, 2018 at 3:44 PM Petr Machata wrote: > > Roopa Prabhu writes: > > > On Mon, Dec 17, 2018 at 10:10 AM Petr Machata wrote: > >> > >> Default remotes are stored as FDB entries with an Ethernet address of > >> 00:00:00:00:00:00. When a request is made to change a remote address of > >

Re: [PATCH v9 RESEND 0/4] KASLR feature to randomize each loadable module

2018-12-17 Thread Edgecombe, Rick P
On Mon, 2018-12-17 at 05:41 +0100, Jessica Yu wrote: > +++ Edgecombe, Rick P [12/12/18 23:05 +]: > > On Wed, 2018-11-28 at 01:40 +, Edgecombe, Rick P wrote: > > > On Tue, 2018-11-27 at 11:21 +0100, Daniel Borkmann wrote: > > > > On 11/27/2018 01:19 AM, Edgecombe, Rick P wrote: > > > > > On

Re: [PATCH v2 1/4] vmalloc: New flags for safe vfree on special perms

2018-12-17 Thread Andy Lutomirski
On Mon, Dec 17, 2018 at 4:24 PM Edgecombe, Rick P wrote: > > On Sat, 2018-12-15 at 10:52 -0800, Andy Lutomirski wrote: > > On Wed, Dec 12, 2018 at 2:01 PM Edgecombe, Rick P > > wrote: > > > > > > On Wed, 2018-12-12 at 11:57 -0800, Andy Lutomirski wrote: > > > > On Wed, Dec 12, 2018 at 11:50 AM Ed

Re: [PATCH bpf-next 6/8] tools: bpftool: add probes for eBPF helper functions

2018-12-17 Thread Daniel Borkmann
On 12/17/2018 11:18 AM, Quentin Monnet wrote: > 2018-12-16 00:57 UTC+0100 ~ Daniel Borkmann >> On 12/15/2018 04:32 AM, Quentin Monnet wrote: >>> 2018-12-15 01:08 UTC+0100 ~ Daniel Borkmann On 12/13/2018 01:19 PM, Quentin Monnet wrote: > Similarly to what was done for program types and ma

Re: [PATCH v2 1/4] vmalloc: New flags for safe vfree on special perms

2018-12-17 Thread Edgecombe, Rick P
On Sat, 2018-12-15 at 10:52 -0800, Andy Lutomirski wrote: > On Wed, Dec 12, 2018 at 2:01 PM Edgecombe, Rick P > wrote: > > > > On Wed, 2018-12-12 at 11:57 -0800, Andy Lutomirski wrote: > > > On Wed, Dec 12, 2018 at 11:50 AM Edgecombe, Rick P > > > wrote: > > > > > > > > On Tue, 2018-12-11 at 18

Re: [PATCH net-next] bpf: libbpf: fix memleak by freeing line_info

2018-12-17 Thread Daniel Borkmann
On 12/17/2018 08:57 AM, Prashant Bhole wrote: > This patch fixes a memory leak in libbpf by freeing up line_info > member of struct bpf_program while unloading a program. > > Fixes: 3d65014146c6 ("bpf: libbpf: Add btf_line_info support to libbpf") > Signed-off-by: Prashant Bhole Applied to bpf-n

Re: [PATCH bpf-next v3 0/8] bpf: btf: fix struct/union/fwd types with kind_flag

2018-12-17 Thread Daniel Borkmann
On 12/16/2018 07:13 AM, Yonghong Song wrote: > Commit 69b693f0aefa ("bpf: btf: Introduce BPF Type Format (BTF)") > introduced BTF, a debug info format for BTF. > > The original design has a couple of issues though. > First, the bitfield size is only encoded in int type. > If the struct member bitf

Re: [PATCH net-next 5/5] tcp: TFO - cleanup code duplication

2018-12-17 Thread Christoph Paasch
On 16/12/18 - 22:33:52, Eric Dumazet wrote: > > > On 12/14/2018 02:40 PM, Christoph Paasch wrote: > > We can actually easily reuse __tcp_fastopen_cookie_gen_with_ctx to > > generate the cookie based on a give TFO-context. > > > > s/give/given/ Thanks! Will be fixed in the v2. Christoph

Re: selftests/bpf/test_progs: 32-bit: Unable to handle kernel NULL pointer dereference at virtual address 00000000

2018-12-17 Thread Daniel Borkmann
On 12/17/2018 11:22 PM, Song Liu wrote: >> On Dec 17, 2018, at 6:26 AM, Daniel Borkmann wrote: >> >> [ +Song, if you get a chance please take a look at the panic in >> stack_map_get_build_id_offset(), thanks! ] > > Thanks Daniel! I will take a look. > > I don't have an ARM32 system handy for t

Re: [PATCH net-next 3/5] tcp: Print list of TFO-keys from proc

2018-12-17 Thread Yuchung Cheng
On Mon, Dec 17, 2018 at 3:35 PM Christoph Paasch wrote: > > On 17/12/18 - 08:52:22, Yuchung Cheng wrote: > > On Sun, Dec 16, 2018 at 10:32 PM Eric Dumazet > > wrote: > > > > > > > > > > > > On 12/14/2018 02:40 PM, Christoph Paasch wrote: > > > > Print the list of the TFO-keys with a comma separa

Re: [PATCH net v2 3/4] vxlan: changelink: Fix handling of default remotes

2018-12-17 Thread Petr Machata
Roopa Prabhu writes: > On Mon, Dec 17, 2018 at 10:10 AM Petr Machata wrote: >> >> Default remotes are stored as FDB entries with an Ethernet address of >> 00:00:00:00:00:00. When a request is made to change a remote address of >> a VXLAN device, vxlan_changelink() first deletes the existing defa

Re: [PATCH net v2 2/4] vxlan: Fix error path in __vxlan_dev_create()

2018-12-17 Thread Petr Machata
Roopa Prabhu writes: >> @@ -3297,9 +3298,15 @@ static int __vxlan_dev_create(struct net *net, struct >> net_device *dev, >> >> list_add(&vxlan->next, &vn->vxlan_list); >> return 0; >> + >> errout: >> + /* unregister_netdevice() destroys the default FDB entry with >> delet

[PATCH net-next] ip6mr: Drop mfc6_cache argument to ip6mr_forward2

2018-12-17 Thread David Ahern
From: David Ahern mfc6_cache is not needed by ip6mr_forward2 so drop it from the input argument list. Signed-off-by: David Ahern --- net/ipv6/ip6mr.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/net/ipv6/ip6mr.c b/net/ipv6/ip6mr.c index 8c63494400c4..34b8a90e6be2

[PATCH net-next] ipmr: Drop mfc_cache argument to ipmr_queue_xmit

2018-12-17 Thread David Ahern
From: David Ahern mfc_cache is not needed by ipmr_queue_xmit so drop it from the input argument list. Signed-off-by: David Ahern --- net/ipv4/ipmr.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c index ea04e38f56e9..75c654924532 1

Re: [PATCH net-next 3/5] tcp: Print list of TFO-keys from proc

2018-12-17 Thread Christoph Paasch
On 17/12/18 - 08:52:22, Yuchung Cheng wrote: > On Sun, Dec 16, 2018 at 10:32 PM Eric Dumazet wrote: > > > > > > > > On 12/14/2018 02:40 PM, Christoph Paasch wrote: > > > Print the list of the TFO-keys with a comma separated. For setting the > > > keys, we still only allow a single one to be set. >

Re: [RESEND 1/4] mfd: altera-sysmgr: Add SOCFPGA System Manager abstraction

2018-12-17 Thread Thor Thayer
Hi Arnd, On 12/14/18 6:36 AM, Arnd Bergmann wrote: On Tue, Nov 13, 2018 at 5:03 PM wrote: From: Thor Thayer The SOCFPGA System Manager register block aggregate different peripheral functions into one place. On 32 bit ARM parts, the syscon framework fits this problem well. On 64 bit ARM part

Re: WARNING in __rcu_read_unlock

2018-12-17 Thread Stefano Brivio
On Mon, 17 Dec 2018 16:53:36 +0100 Dmitry Vyukov wrote: > On Mon, Dec 17, 2018 at 4:24 PM Stefano Brivio wrote: > > > > On Mon, 17 Dec 2018 06:57:35 -0800 > > Eric Dumazet wrote: > > > > > Might be cause by commit b8a51b38e4d4dec3e379d52c0fe1a66827f7cf1e > > > fou, fou6: ICMP error handlers f

[PATCH net-next] fou: Prevent unbounded recursion in GUE error handler

2018-12-17 Thread Stefano Brivio
Handling exceptions for direct UDP encapsulation in GUE (that is, UDP-in-UDP) leads to unbounded recursion in the GUE exception handler, syzbot reported. While draft-ietf-intarea-gue-06 doesn't explicitly forbid direct encapsulation of UDP in GUE, it probably doesn't make sense to set up GUE this

Re: [PATCH] MAINTAINERS: change my email address

2018-12-17 Thread David Miller
From: Vivien Didelot Date: Mon, 17 Dec 2018 16:29:01 -0500 > Make my Gmail address the primary one from now on. > > Signed-off-by: Vivien Didelot Applied.

Re: [PATCH net-next 2/5] tcp: TFO: search for correct cookie and accept data

2018-12-17 Thread Christoph Paasch
On 16/12/18 - 22:30:51, Eric Dumazet wrote: > > > On 12/14/2018 02:40 PM, Christoph Paasch wrote: > > This change allows to search for the right cookie and accepts old ones > > (announcing a new one if it has changed). > > > > __tcp_fastopen_cookie_gen_with_ctx() allows to generate a cookie base

Re: DSA: external phy address and port number of switch conflicts

2018-12-17 Thread Florian Fainelli
On 12/17/18 2:55 PM, John Rama wrote: > Hi, Andrew, Florian and Viven > > thank you your feedback !! > >>> I would recommend checking a newer kernel anyway which would have >>> support for the mv88e6xxx internal MDIO bus as it might allow you to >>> solve that specific problem. A kernel that cont

Re: DSA: external phy address and port number of switch conflicts

2018-12-17 Thread John Rama
Hi, Andrew, Florian and Viven thank you your feedback !! >> I would recommend checking a newer kernel anyway which would have >> support for the mv88e6xxx internal MDIO bus as it might allow you to >> solve that specific problem. A kernel that contains >> a3c53be55c955b7150cda17874c3fcb4eeb97a89

Re: [PATCH net-next 1/5] tcp: Create list of TFO-contexts

2018-12-17 Thread Christoph Paasch
On 17/12/18 - 14:01:41, Eric Dumazet wrote: > On Mon, Dec 17, 2018 at 1:57 PM Christoph Paasch wrote: > > > > On 17/12/18 - 08:04:08, Eric Dumazet wrote: > > > On Fri, Dec 14, 2018 at 2:40 PM Christoph Paasch > > > wrote: > > > > > > > > > > ... > > > > > > > int tcp_fastopen_reset_cipher(struc

status of llvm BTF support

2018-12-17 Thread Yonghong Song
Hi, As many of you already knew, latest bpf-next/net-next kernel added supports for func_info and line_info. https://www.mail-archive.com/netdev@vger.kernel.org/msg255580.html https://www.mail-archive.com/netdev@vger.kernel.org/msg257914.html https://www.mail-archive.com/netdev@vger.kerne

[PATCH net-next] net: phy: remove unused code in phy_probe

2018-12-17 Thread Heiner Kallweit
3c1bcc8614db ("net: ethernet: Convert phydev advertize and supported from u32 to link mode") left some unused code in phy_probe(), remove it. Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy_device.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/phy/phy_device.c b/driver

Re: [PATCH mlx5-next] net/mlx5: Continue driver initialization despite debugfs failure

2018-12-17 Thread Saeed Mahameed
On Thu, 2018-12-13 at 13:15 +0200, Leon Romanovsky wrote: > From: Leon Romanovsky > > The failure to create debugfs entry is unpleasant event, but not > enough > to abort drier initialization. Align the mlx5_core code to debugfs > design > and continue execution whenever debugfs_create_dir() succ

Re: selftests/bpf/test_progs: 32-bit: Unable to handle kernel NULL pointer dereference at virtual address 00000000

2018-12-17 Thread Song Liu
> On Dec 17, 2018, at 6:26 AM, Daniel Borkmann wrote: > > [ +Song, if you get a chance please take a look at the panic in > stack_map_get_build_id_offset(), thanks! ] > Thanks Daniel! I will take a look. I don't have an ARM32 system handy for tests. Any suggestion on where I can lease/bor

Re: [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode

2018-12-17 Thread Florian Fainelli
On 12/17/18 12:44 PM, Sergio Paracuellos wrote: > Add device-tree binding example of the ksz9477 switch managed in i2c mode. > > Cc: devicet...@vger.kernel.org > Signed-off-by: Sergio Paracuellos This looks good, although it looks like you have 2x the amount of tabs necessary. -- Florian

Re: [PATCH 1/3] 9p/net: implement asynchronous rpc

2018-12-17 Thread Tomas Bortoli
On 12/17/18 12:01 PM, Dominique Martinet wrote: > Tomas Bortoli wrote on Mon, Dec 17, 2018: >> sorry for the delay, I've been quite busy these days. > > No problem. > >> The patches looks good to me and should indeed speed up the code a bit. >> I quickly tested them against Syzkaller tuned for th

Re: linux-next: manual merge of the net-next tree with the net tree

2018-12-17 Thread Stephen Rothwell
Hi, On Tue, 18 Dec 2018 00:01:57 +0200 Or Gerlitz wrote: > > Just a note, > > e88afe759a49 ("net/mlx5e: Err if asked to mirror a goto chain tc eswitch > rule") > > is from net and not net-next Yeah, my mistake ... -- Cheers, Stephen Rothwell pgpTaRVKg5TN6.pgp Description: OpenPGP digital

Re: [PATCH] net: dsa: mv88e6xxx: set ethtool regs version

2018-12-17 Thread Florian Fainelli
On December 17, 2018 1:05:21 PM PST, Vivien Didelot wrote: >From: Vivien Didelot > >Currently the ethtool_regs version is set to 0 for all DSA drivers. > >Use this field to store the chip ID to simplify the pretty dump of >any interfaces registered by the "dsa" driver. > >Signed-off-by: Vivie

Re: linux-next: manual merge of the net-next tree with the net tree

2018-12-17 Thread Or Gerlitz
On Mon, Dec 17, 2018 at 11:29 PM Saeed Mahameed wrote: > On Sun, Dec 16, 2018 at 4:25 PM Stephen Rothwell > wrote: > > I fixed it up (see below) and can carry the fix as necessary. This > Looks good to me. here too > > Today's linux-next merge of the net-next tree got a conflict in: > > d

Re: [PATCH net-next 1/5] tcp: Create list of TFO-contexts

2018-12-17 Thread Eric Dumazet
On Mon, Dec 17, 2018 at 1:57 PM Christoph Paasch wrote: > > On 17/12/18 - 08:04:08, Eric Dumazet wrote: > > On Fri, Dec 14, 2018 at 2:40 PM Christoph Paasch wrote: > > > > > > > ... > > > > > int tcp_fastopen_reset_cipher(struct net *net, struct sock *sk, > > > void

Re: [PATCH net-next 1/5] tcp: Create list of TFO-contexts

2018-12-17 Thread Christoph Paasch
On 17/12/18 - 08:04:08, Eric Dumazet wrote: > On Fri, Dec 14, 2018 at 2:40 PM Christoph Paasch wrote: > > > > ... > > > int tcp_fastopen_reset_cipher(struct net *net, struct sock *sk, > > void *key, unsigned int len) > > { > > @@ -96,13 +131,22 @@ error:

[PATCH v1 net] lan743x: Expand phy search for LAN7431

2018-12-17 Thread Bryan Whitehead
The LAN7431 uses an external phy, and it can be found anywhere in the phy address space. This patch uses phy address 1 for LAN7430 only. And searches all addresses otherwise. Signed-off-by: Bryan Whitehead --- drivers/net/ethernet/microchip/lan743x_main.c | 5 +++-- 1 file changed, 3 insertions(

Re: [PATCH bpf-next] bpf: remove useless version check for prog load

2018-12-17 Thread Alexei Starovoitov
On Mon, Dec 17, 2018 at 09:39:47AM +, Quentin Monnet wrote: > 2018-12-16 00:49 UTC+0100 ~ Daniel Borkmann > > Existing libraries and tracing frameworks work around this kernel > > version check by automatically deriving the kernel version from > > uname(3) or similar such that the user does no

Re: A weird problem of Realtek r8168 after resume from S3

2018-12-17 Thread Heiner Kallweit
On 17.12.2018 14:25, Chris Chiu wrote: > On Fri, Dec 14, 2018 at 3:37 PM Heiner Kallweit wrote: >> >> On 14.12.2018 04:33, Chris Chiu wrote: >>> On Thu, Dec 13, 2018 at 10:20 AM Chris Chiu wrote: Hi, We got an acer laptop which has a problem with ethernet networking after

[PATCH] lib/rhashtable: Fix work initialization in rhashtable_init()

2018-12-17 Thread Bart Van Assche
The test_insert_dup() function from lib/test_rhashtable.c passes a pointer to a stack object to rhltable_init(). Avoid that the following is reported with object debugging enabled while running the selftest from lib/test_rhashtable.c: ODEBUG: object (ptrval) is on stack (ptrval), but NOT annotated

[PATCH] MAINTAINERS: change my email address

2018-12-17 Thread Vivien Didelot
Make my Gmail address the primary one from now on. Signed-off-by: Vivien Didelot --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index a676b40ac1d6..a0045156e883 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8932,7 +8932,7 @@ F:

Re: [PATCH] net: dsa: mv88e6xxx: set ethtool regs version

2018-12-17 Thread Andrew Lunn
On Mon, Dec 17, 2018 at 04:05:21PM -0500, Vivien Didelot wrote: > From: Vivien Didelot > > Currently the ethtool_regs version is set to 0 for all DSA drivers. > > Use this field to store the chip ID to simplify the pretty dump of > any interfaces registered by the "dsa" driver. Hi Vivien. I li

Re: linux-next: manual merge of the rdma tree with the net tree

2018-12-17 Thread Saeed Mahameed
On Sun, Dec 16, 2018 at 4:08 PM Stephen Rothwell wrote: > > Hi all, > > Today's linux-next merge of the rdma tree got a conflict in: > > include/linux/mlx5/mlx5_ifc.h > > between commit: > > 663f146f2ecf ("net/mlx5: E-Switch, Fix fdb cap bits swap") > > from the net tree and commit: > > c74d

Re: linux-next: manual merge of the net-next tree with the net tree

2018-12-17 Thread Saeed Mahameed
On Sun, Dec 16, 2018 at 4:25 PM Stephen Rothwell wrote: > > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c > > between commit: > > 154e62abe9cd ("net/mlx5e: Properly initialize flow attributes for slow path > es

[PATCH] net: dsa: mv88e6xxx: set ethtool regs version

2018-12-17 Thread Vivien Didelot
From: Vivien Didelot Currently the ethtool_regs version is set to 0 for all DSA drivers. Use this field to store the chip ID to simplify the pretty dump of any interfaces registered by the "dsa" driver. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 2 +- 1 file changed,

Re: [PATCH] bpf: promote bpf_perf_event.h to mandatory UAPI header

2018-12-17 Thread Daniel Borkmann
On 12/16/2018 04:04 PM, Masahiro Yamada wrote: > Since commit c895f6f703ad ("bpf: correct broken uapi for > BPF_PROG_TYPE_PERF_EVENT program type"), all architectures > (except um) are required to have bpf_perf_event.h in uapi/asm. > > Add it to mandatory-y so "make headers_install" can check it.

Re: [PATCH 1/2] net: dsa: ksz9477: add I2C managed mode support

2018-12-17 Thread Sergio Paracuellos
On Mon, Dec 17, 2018 at 8:11 PM Dan Carpenter wrote: > > On Mon, Dec 17, 2018 at 07:22:51PM +0100, Sergio Paracuellos wrote: > > > > +static int ksz_i2c_write(struct ksz_device *dev, u32 reg, u8 *val, > > > > + unsigned int len) > > > > +{ > > > > + struct i2c_client *clie

[PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode

2018-12-17 Thread Sergio Paracuellos
Add device-tree binding example of the ksz9477 switch managed in i2c mode. Cc: devicet...@vger.kernel.org Signed-off-by: Sergio Paracuellos --- Changes v3: - No changes. Just resent patches together. Changes v2: - Use generic name for label of the switch and make sure reg and @X ha

[PATCH v3 1/2] net: dsa: ksz9477: add I2C managed mode support

2018-12-17 Thread Sergio Paracuellos
In this mode the switch device and the internal phys will be managed via I2C interface. Signed-off-by: Sergio Paracuellos --- Changes v3: - return -EINVAL if 'ksz_i2c_write' is called with len 0 to avoid a possible memory corruption. Changes v2: - Use dev->txbuf as transmition buff

Re: [PATCH net v2 2/4] vxlan: Fix error path in __vxlan_dev_create()

2018-12-17 Thread Roopa Prabhu
On Mon, Dec 17, 2018 at 10:10 AM Petr Machata wrote: > > When a failure occurs in rtnl_configure_link(), the current code > calls unregister_netdevice() to roll back the earlier call to > register_netdevice(), and jumps to errout, which calls > vxlan_fdb_destroy(). > > However unregister_netdevice

Re: [PATCH net v2 3/4] vxlan: changelink: Fix handling of default remotes

2018-12-17 Thread Roopa Prabhu
On Mon, Dec 17, 2018 at 10:10 AM Petr Machata wrote: > > Default remotes are stored as FDB entries with an Ethernet address of > 00:00:00:00:00:00. When a request is made to change a remote address of > a VXLAN device, vxlan_changelink() first deletes the existing default > remote, and then create

Re: WARNING in __rcu_read_unlock

2018-12-17 Thread Paul E. McKenney
On Mon, Dec 17, 2018 at 07:45:58PM +0100, Dmitry Vyukov wrote: > On Mon, Dec 17, 2018 at 12:29 PM Paul E. McKenney > wrote: > > Any chance of a bisection? > > Better later then never. Bisection also needs testing :) Well, it looks like it did pass the test, arriving at the same commit that Eric

[bpf-next RFC 1/3] xsk: add xsk_umem_consume_tx_virtual.

2018-12-17 Thread William Tu
Currently the xsk_umem_consume_tx expects only the physical NICs so the api returns a dma address. This patch introduce the new function to return the virtual address, when XSK is used by a virtual device. Signed-off-by: William Tu --- include/net/xdp_sock.h | 7 +++ net/xdp/xsk.c

[bpf-next RFC 2/3] veth: support AF_XDP.

2018-12-17 Thread William Tu
The patch adds support for AF_XDP async xmit. Users can use AF_XDP on both side of the veth and get better performance, with the cost of ksoftirqd doing the xmit. The veth_xsk_async_xmit simply kicks the napi function, veth_poll, to run, and the transmit logic is implemented there. Tested using

[bpf-next RFC 0/3] AF_XDP support for veth.

2018-12-17 Thread William Tu
The patch series adds AF_XDP async xmit support for veth device. First patch add a new API for supporting non-physical NIC device to get packet's virtual address. The second patch implements the async xmit, and last patch adds example use cases. I tested with 2 namespaces, one as sender, the othe

[bpf-next RFC 3/3] samples: bpf: add veth AF_XDP example.

2018-12-17 Thread William Tu
Add example use cases for AF_XDP socket on two namespaces. The script runs sender at the root namespace, and receiver at the at_ns0 namespace with different XDP actions. Signed-off-by: William Tu --- samples/bpf/test_veth_afxdp.sh | 67 ++ 1 file changed,

Re: [PATCH 2/8] net: dsa: add helper functions

2018-12-17 Thread David Miller
From: Frank Wunderlich Date: Fri, 14 Dec 2018 17:48:41 +0100 > @@ -255,6 +255,24 @@ static void dsa_tree_teardown_default_cpu(struct > dsa_switch_tree *dst) > dst->cpu_dp = NULL; > } > > +static int dsa_user_parse(struct dsa_port *port, u32 index, > + struct dsa_sw

  1   2   3   >