From: Frank Wunderlich <fran...@public-files.de>
Date: Fri, 14 Dec 2018 17:48:41 +0100
> @@ -255,6 +255,24 @@ static void dsa_tree_teardown_default_cpu(struct
> dsa_switch_tree *dst)
> dst->cpu_dp = NULL;
> }
>
> +static int dsa_user_parse(struct dsa_port *port, u32 index,
> + struct dsa_switch *ds)
> +{
> + struct device_node *cpu_port;
> + const unsigned int *cpu_port_reg;
> + int cpu_port_index;
Please order local variables from longest to shortest line.
Also, for ->upstream_port, since it is ultimately used as a u8 maybe
it's best to define it as a u8 in the structure?
Thanks.
