On 17/12/18 - 08:52:22, Yuchung Cheng wrote: > On Sun, Dec 16, 2018 at 10:32 PM Eric Dumazet <eric.duma...@gmail.com> wrote: > > > > > > > > On 12/14/2018 02:40 PM, Christoph Paasch wrote: > > > Print the list of the TFO-keys with a comma separated. For setting the > > > keys, we still only allow a single one to be set. > > > > > > > I wonder if some applications expecting current format could break > > after a formatting change. > I have the same concern as well. print the extra keys in a different > sysctl maybe? e.g. net.ipv4.tcp_fastopen_alt_keys
True, some apps might break on that. Having a single place where all the keys are shown is still useful as that way the key-rotation can simply check the current keys in one place. I'm fine with adding net.ipv4.tcp_fastopen_key_list or something like that, if we want to keep sysctl-API stable. Christoph
