Re: [PATCH mlx5-next 1/7] net/mlx5: Update mlx5_ifc with DEVX UCTX capabilities bits

2018-12-03 Thread Leon Romanovsky
On Mon, Dec 03, 2018 at 01:32:45PM -0500, Doug Ledford wrote: > On Mon, 2018-11-26 at 08:28 +0200, Leon Romanovsky wrote: > > From: Yishai Hadas > > > > Expose device capabilities for DEVX user context, it includes which caps > > the device is supported and a matching bit to set as part of user >

Re: [Patch net v3] mlx5: force CHECKSUM_NONE for short ethernet frames

2018-12-03 Thread Eric Dumazet
On Mon, Dec 3, 2018 at 11:30 PM Cong Wang wrote: > > On Mon, Dec 3, 2018 at 11:08 PM Eric Dumazet wrote: > > > > The hardware has probably validated the L3 & L4 checksum just fine. > > > > Note that if ip_summed is CHECKSUM_UNNECESSARY, the padding bytes (if any) > > have no impact on the csum th

Re: [Patch net v3] mlx5: force CHECKSUM_NONE for short ethernet frames

2018-12-03 Thread Cong Wang
On Mon, Dec 3, 2018 at 11:08 PM Eric Dumazet wrote: > > The hardware has probably validated the L3 & L4 checksum just fine. > > Note that if ip_summed is CHECKSUM_UNNECESSARY, the padding bytes (if any) > have no impact on the csum that has been verified by the NIC. Why? Why does the hardware va

Re: [PATCH mlx5-next 00/11] Remove SRQ code from mlx5_core

2018-12-03 Thread Leon Romanovsky
On Wed, Nov 28, 2018 at 08:53:32PM +0200, Leon Romanovsky wrote: > From: Leon Romanovsky > > Hi Doug and Jason, > > This series is intended to be applied on mlx5-next after Saeed's > infrastructure changes series are accepted: > https://patchwork.kernel.org/project/linux-rdma/list/?series=47809 >

Re: consistency for statistics with XDP mode

2018-12-03 Thread Jakub Kicinski
On Tue, 04 Dec 2018 09:03:52 +0200, Toke Høiland-Jørgensen wrote: > David Miller writes: > > > From: David Ahern > > Date: Mon, 3 Dec 2018 17:15:03 -0700 > > > >> So, instead of a program tag which the program writer controls, how > >> about some config knob that an admin controls that says at

Re: [PATCH 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC

2018-12-03 Thread Greg Ungerer
Hi Bjorn, On 3/12/18 9:34 pm, Bjørn Mork wrote: [ fixed Johns address - the openwrt.org email was apparently never restored? ] Greg Ungerer writes: The following change helped alot, but I still get some problems under sustained load and some types of port setups. Still trying to figure out w

Re: [Patch net v3] mlx5: force CHECKSUM_NONE for short ethernet frames

2018-12-03 Thread Eric Dumazet
Resent to netdev@ without htm formatting, sorry. On Mon, Dec 3, 2018 at 11:08 PM Eric Dumazet wrote: > > > > On Mon, Dec 3, 2018 at 10:48 PM Cong Wang wrote: >> >> On Mon, Dec 3, 2018 at 10:34 PM Eric Dumazet wrote: >> > >> > On Mon, Dec 3, 2018 at 10:14 PM Cong Wang wrote: >> > > >> > > When

Re: consistency for statistics with XDP mode

2018-12-03 Thread Toke Høiland-Jørgensen
David Miller writes: > From: David Ahern > Date: Mon, 3 Dec 2018 17:15:03 -0700 > >> So, instead of a program tag which the program writer controls, how >> about some config knob that an admin controls that says at attach time >> use standard stats? > > How about, instead of replacing it is in a

Re: [PATCH v2] ptp: fix an IS_ERR() vs NULL check

2018-12-03 Thread Dan Carpenter
Hi Greg, I meant to CC you but I screwed up and added you to the From header instead... :( Why did you commit 3b1ad360acad ("pps: using ERR_PTR instead of NULL while pps_register_source fails")? You're not listed as a maintainer so I wouldn't have known to CC you. The back story is that the las

Re: hard-coded limit on unresolved multicast route cache in ipv4/ipmr.c causes slow, unreliable creation of multicast routes on busy networks

2018-12-03 Thread Hangbin Liu
On Mon, Nov 26, 2018 at 10:44:49AM +0530, Sukumar Gopalakrishnan wrote: > Hi, > >  There is a patch to make this queue len configurable. Is below mentioned > going > to be applied ? > > http://lkml.iu.edu/hypermail/linux/kernel/1810.3/02344.html It looks this topic stuckd again.. > > Regards,

Re: [Patch net v3] mlx5: force CHECKSUM_NONE for short ethernet frames

2018-12-03 Thread Cong Wang
On Mon, Dec 3, 2018 at 10:34 PM Eric Dumazet wrote: > > On Mon, Dec 3, 2018 at 10:14 PM Cong Wang wrote: > > > > When an ethernet frame is padded to meet the minimum ethernet frame > > size, the padding octets are not covered by the hardware checksum. > > Fortunately the padding octets are ususal

[PATCH bpf 0/3] bpf: improve verifier resilience

2018-12-03 Thread Alexei Starovoitov
Three patches to improve verifier ability to handle pathological bpf programs with a lot of branches: - make sure prog_load syscall can be aborted - improve branch taken analysis - introduce per-insn complexity limit for unprivileged programs Alexei Starovoitov (3): bpf: check pending signals wh

[PATCH bpf 3/3] bpf: add per-insn complexity limit

2018-12-03 Thread Alexei Starovoitov
malicious bpf program may try to force the verifier to remember a lot of distinct verifier states. Put a limit to number of per-insn 'struct bpf_verifier_state'. Note that hitting the limit doesn't reject the program. It potentially makes the verifier do more steps to analyze the program. It means

[PATCH bpf 2/3] bpf: improve verifier branch analysis

2018-12-03 Thread Alexei Starovoitov
pathological bpf programs may try to force verifier to explode in the number of branch states: 20: (d5) if r1 s<= 0x2428 goto pc+0 21: (b5) if r0 <= 0xe1fa20 goto pc+2 22: (d5) if r1 s<= 0x7e goto pc+0 23: (b5) if r0 <= 0xe880e000 goto pc+0 24: (c5) if r0 s< 0x2100ecf4 goto pc+0 25:

[PATCH bpf 1/3] bpf: check pending signals while verifying programs

2018-12-03 Thread Alexei Starovoitov
Malicious user space may try to force the verifier to use as much cpu time and memory as possible. Hence check for pending signals while verifying the program. Note that suspend of sys_bpf(PROG_LOAD) syscall will lead to EAGAIN, since the kernel has to release the resources used for program verific

Re: [Patch net v3] mlx5: force CHECKSUM_NONE for short ethernet frames

2018-12-03 Thread Eric Dumazet
On Mon, Dec 3, 2018 at 10:14 PM Cong Wang wrote: > > When an ethernet frame is padded to meet the minimum ethernet frame > size, the padding octets are not covered by the hardware checksum. > Fortunately the padding octets are ususally zero's, which don't affect > checksum. However, we have a swit

[PATCH net-next] can: flexcan: flexcan_chip_start(): fix the error return code in flexcan_setup_stop_mode()

2018-12-03 Thread Wei Yongjun
The error return code PTR_ERR(gpr_np) is always 0 since gpr_np is equal to NULL in this error handling case. Fix it by return -ENOENT. Fixes: de3578c198c6 ("can: flexcan: add self wakeup support") Signed-off-by: Wei Yongjun --- drivers/net/can/flexcan.c | 2 +- 1 file changed, 1 insertion(+), 1

[Patch net v3] mlx5: force CHECKSUM_NONE for short ethernet frames

2018-12-03 Thread Cong Wang
When an ethernet frame is padded to meet the minimum ethernet frame size, the padding octets are not covered by the hardware checksum. Fortunately the padding octets are ususally zero's, which don't affect checksum. However, we have a switch which pads non-zero octets, this causes kernel hardware c

Re: [RFC] Discuss about an new idea "Vsock over Virtio-net"

2018-12-03 Thread jiangyiwen
On 2018/12/4 12:08, Michael S. Tsirkin wrote: > On Tue, Dec 04, 2018 at 10:21:40AM +0800, jiangyiwen wrote: >> On 2018/12/4 9:31, Michael S. Tsirkin wrote: >>> On Mon, Dec 03, 2018 at 11:10:58AM +0800, jiangyiwen wrote: On 2018/11/30 21:40, Michael S. Tsirkin wrote: > On Fri, Nov 30, 2018

Re: [PATCH v2] ptp: fix an IS_ERR() vs NULL check

2018-12-03 Thread Richard Cochran
On Mon, Dec 03, 2018 at 01:55:06PM +0300, Dan Carpenter wrote: > We recently modified pps_register_source() to return error pointers > instead of NULL but this check wasn't updated. But it *was* updated! > Fixes: 3b1ad360acad ("pps: using ERR_PTR instead of NULL while > pps_register_source fail

Re: [RFC] Discuss about an new idea "Vsock over Virtio-net"

2018-12-03 Thread Michael S. Tsirkin
On Tue, Dec 04, 2018 at 10:21:40AM +0800, jiangyiwen wrote: > On 2018/12/4 9:31, Michael S. Tsirkin wrote: > > On Mon, Dec 03, 2018 at 11:10:58AM +0800, jiangyiwen wrote: > >> On 2018/11/30 21:40, Michael S. Tsirkin wrote: > >>> On Fri, Nov 30, 2018 at 09:10:03PM +0800, Jason Wang wrote: > > >

[PATCH bpf-next v2 2/5] bpf: add BPF_PROG_TEST_RUN support for flow dissector

2018-12-03 Thread Stanislav Fomichev
The input is packet data, the output is struct bpf_flow_key. This should make it easy to test flow dissector programs without elaborate setup. Signed-off-by: Stanislav Fomichev --- include/linux/bpf.h | 3 ++ net/bpf/test_run.c | 71 - net/core/filte

[PATCH bpf-next v2 1/5] net/flow_dissector: move bpf case into __skb_flow_bpf_dissect

2018-12-03 Thread Stanislav Fomichev
This way, we can reuse it for flow dissector in BPF_PROG_TEST_RUN. No functional changes. Signed-off-by: Stanislav Fomichev --- include/linux/skbuff.h| 5 +++ net/core/flow_dissector.c | 85 +++ 2 files changed, 56 insertions(+), 34 deletions(-) diff --

[PATCH bpf-next v2 0/5] support flow dissector in BPF_PROG_TEST_RUN

2018-12-03 Thread Stanislav Fomichev
This patch series adds support for testing flow dissector BPF programs by extending already existing BPF_PROG_TEST_RUN. The goal is to have a packet as an input and `struct bpf_flow_key' as an output. That way we can easily test flow dissector programs' behavior. I've also modified existing test_pr

[PATCH bpf-next v2 4/5] net/flow_dissector: correctly cap nhoff and thoff in case of BPF

2018-12-03 Thread Stanislav Fomichev
We want to make sure that the following condition holds: 0 <= nhoff <= thoff <= skb->len BPF program can set out-of-bounds nhoff and thoff, which is dangerous, see recent commit d0c081b49137 ("flow_dissector: properly cap thoff field")'. Signed-off-by: Stanislav Fomichev --- net/core/flow_disse

[PATCH bpf-next v2 3/5] selftests/bpf: use thoff instead of nhoff in BPF flow dissector

2018-12-03 Thread Stanislav Fomichev
We are returning thoff from the flow dissector, not the nhoff. Pass thoff along with nhoff to the bpf program (initially thoff == nhoff) and expect flow dissector amend/return thoff, not nhoff. This avoids confusion, when by the time bpf flow dissector exits, nhoff == thoff, which doesn't make muc

[PATCH bpf-next v2 5/5] selftests/bpf: add simple BPF_PROG_TEST_RUN examples for flow dissector

2018-12-03 Thread Stanislav Fomichev
Use existing pkt_v4 and pkt_v6 to make sure flow_keys are what we want. Also, add new bpf_flow_load routine (and flow_dissector_load.h header) that loads bpf_flow.o program and does all required setup. Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/bpf/Makefile | 3 + .

Re: [PATCH bpf-next 2/3] bpf: add BPF_PROG_TEST_RUN support for flow dissector

2018-12-03 Thread Stanislav Fomichev
On 12/03, Stanislav Fomichev wrote: > On 12/03, Song Liu wrote: > > On Mon, Dec 3, 2018 at 11:00 AM Stanislav Fomichev wrote: > > > > > > The input is packet data, the output is struct bpf_flow_key. This should > > > make it easy to test flow dissector programs without elaborate > > > setup. > > >

Re: [RFC] net: documentation: build a directory structure for drivers

2018-12-03 Thread David Ahern
On 12/3/18 6:43 PM, Jakub Kicinski wrote: > Documentation/networking/ is full of cryptically named files with > driver documentation. This makes finding interesting information > at a glance really hard. Move all those files into a directory > called device_drivers (since not all drivers are for

Re: [RFC] Discuss about an new idea "Vsock over Virtio-net"

2018-12-03 Thread jiangyiwen
On 2018/12/4 9:31, Michael S. Tsirkin wrote: > On Mon, Dec 03, 2018 at 11:10:58AM +0800, jiangyiwen wrote: >> On 2018/11/30 21:40, Michael S. Tsirkin wrote: >>> On Fri, Nov 30, 2018 at 09:10:03PM +0800, Jason Wang wrote: On 2018/11/30 下午8:55, Jason Wang wrote: > > On 2018/11/30 下午

[PATCH v5 02/13] datagram: open-code copy_page_to_iter

2018-12-03 Thread Sagi Grimberg
From: Sagi Grimberg This will be useful to consolidate skb_copy_and_hash_datagram_iter and skb_copy_and_csum_datagram to a single code path. Acked-by: David S. Miller Signed-off-by: Sagi Grimberg --- net/core/datagram.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --gi

[PATCH v5 03/13] iov_iter: pass void csum pointer to csum_and_copy_to_iter

2018-12-03 Thread Sagi Grimberg
From: Sagi Grimberg The single caller to csum_and_copy_to_iter is skb_copy_and_csum_datagram and we are trying to unite its logic with skb_copy_datagram_iter by passing a callback to the copy function that we want to apply. Thus, we need to make the checksum pointer private to the function. Acke

[PATCH v5 01/13] ath6kl: add ath6kl_ prefix to crypto_type

2018-12-03 Thread Sagi Grimberg
From: Sagi Grimberg Prevent a namespace conflict as in following patches as skbuff.h will include the crypto API. Acked-by: David S. Miller Cc: Kalle Valo Signed-off-by: Sagi Grimberg --- drivers/net/wireless/ath/ath6kl/cfg80211.c | 2 +- drivers/net/wireless/ath/ath6kl/common.h | 2 +- dr

[PATCH v5 00/13] TCP transport binding for NVMe over Fabrics

2018-12-03 Thread Sagi Grimberg
This patch set implements the NVMe over Fabrics TCP host and the target drivers. Now NVMe over Fabrics can run on every Ethernet port in the world. The implementation conforms to NVMe over Fabrics 1.1 specification (which will include already publicly available NVMe/TCP transport binding, TP 8000).

[PATCH v5 04/13] datagram: consolidate datagram copy to iter helpers

2018-12-03 Thread Sagi Grimberg
From: Sagi Grimberg skb_copy_datagram_iter and skb_copy_and_csum_datagram are essentialy the same but with a couple of differences: The first is the copy operation used which either a simple copy or a csum_and_copy, and the second are the behavior on the "short copy" path where simply copy needs

[PATCH v5 05/13] iov_iter: introduce hash_and_copy_to_iter helper

2018-12-03 Thread Sagi Grimberg
From: Sagi Grimberg Allow consumers that want to use iov iterator helpers and also update a predefined hash calculation online when copying data. This is useful when copying incoming network buffers to a local iterator and calculate a digest on the incoming stream. nvme-tcp host driver that will

[PATCH v5 06/13] datagram: introduce skb_copy_and_hash_datagram_iter helper

2018-12-03 Thread Sagi Grimberg
From: Sagi Grimberg Introduce a helper to copy datagram into an iovec iterator but also update a predefined hash. This is useful for consumers of skb_copy_datagram_iter to also support inflight data digest without having to finish to copy and only then traverse the iovec and calculate the digest

[PATCH v5 07/13] nvmet: Add install_queue callout

2018-12-03 Thread Sagi Grimberg
From: Sagi Grimberg nvmet-tcp will implement it to allocate queue commands which are only known at nvmf connect time (sq size). Reviewed-by: Christoph Hellwig Signed-off-by: Sagi Grimberg --- drivers/nvme/target/fabrics-cmd.c | 10 ++ drivers/nvme/target/nvmet.h | 1 + 2 files

[PATCH v5 10/13] nvme-tcp: Add protocol header

2018-12-03 Thread Sagi Grimberg
From: Sagi Grimberg Signed-off-by: Sagi Grimberg --- include/linux/nvme-tcp.h | 189 +++ include/linux/nvme.h | 1 + 2 files changed, 190 insertions(+) create mode 100644 include/linux/nvme-tcp.h diff --git a/include/linux/nvme-tcp.h b/include/linux/n

[PATCH v5 08/13] nvme-fabrics: allow user passing header digest

2018-12-03 Thread Sagi Grimberg
From: Sagi Grimberg Header digest is a nvme-tcp specific feature, but nothing prevents other transports reusing the concept so do not associate with tcp transport solely. Reviewed-by: Christoph Hellwig Signed-off-by: Sagi Grimberg --- drivers/nvme/host/fabrics.c | 5 + drivers/nvme/host/f

[PATCH v5 13/13] nvme-tcp: add NVMe over TCP host driver

2018-12-03 Thread Sagi Grimberg
From: Sagi Grimberg This patch implements the NVMe over TCP host driver. It can be used to connect to remote NVMe over Fabrics subsystems over good old TCP/IP. The driver implements the TP 8000 of how nvme over fabrics capsules and data are encapsulated in nvme-tcp pdus and exchaged on top of a

[PATCH v5 11/13] nvmet-tcp: add NVMe over TCP target driver

2018-12-03 Thread Sagi Grimberg
From: Sagi Grimberg This patch implements the TCP transport driver for the NVMe over Fabrics target stack. This allows exporting NVMe over Fabrics functionality over good old TCP/IP. The driver implements the TP 8000 of how nvme over fabrics capsules and data are encapsulated in nvme-tcp pdus an

[PATCH v5 09/13] nvme-fabrics: allow user passing data digest

2018-12-03 Thread Sagi Grimberg
From: Sagi Grimberg Data digest is a nvme-tcp specific feature, but nothing prevents other transports reusing the concept so do not associate with tcp transport solely. Reviewed-by: Christoph Hellwig Signed-off-by: Sagi Grimberg --- drivers/nvme/host/fabrics.c | 5 + drivers/nvme/host/fab

[PATCH v5 12/13] nvmet: allow configfs tcp trtype configuration

2018-12-03 Thread Sagi Grimberg
From: Sagi Grimberg Reviewed-by: Max Gurtovoy Reviewed-by: Christoph Hellwig Signed-off-by: Sagi Grimberg --- drivers/nvme/target/configfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c index db2cb64be7ba..618bbd006544 100

[RFC] net: documentation: build a directory structure for drivers

2018-12-03 Thread Jakub Kicinski
Documentation/networking/ is full of cryptically named files with driver documentation. This makes finding interesting information at a glance really hard. Move all those files into a directory called device_drivers (since not all drivers are for device) and fix up references. RFC v0.1 -> RFC v1

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-03 Thread Nadav Amit
> On Nov 27, 2018, at 4:07 PM, Rick Edgecombe > wrote: > > Since vfree will lazily flush the TLB, but not lazily free the underlying > pages, > it often leaves stale TLB entries to freed pages that could get re-used. This > is > undesirable for cases where the memory being freed has special pe

Re: [RFC PATCH net-next 2/5] net: 8021q: vlan_dev: add vid tag for uc and mc address lists

2018-12-03 Thread Ivan Khoronzhuk
On Mon, Dec 03, 2018 at 03:57:03PM -0800, Florian Fainelli wrote: On 12/3/18 3:51 PM, Ivan Khoronzhuk wrote: On Mon, Dec 03, 2018 at 02:17:00PM -0800, Florian Fainelli wrote: On 12/3/18 10:40 AM, Ivan Khoronzhuk wrote: Update vlan mc and uc addresses with VID tag while propagating address set

Re: [RFC] Discuss about an new idea "Vsock over Virtio-net"

2018-12-03 Thread Michael S. Tsirkin
On Mon, Dec 03, 2018 at 11:10:58AM +0800, jiangyiwen wrote: > On 2018/11/30 21:40, Michael S. Tsirkin wrote: > > On Fri, Nov 30, 2018 at 09:10:03PM +0800, Jason Wang wrote: > >> > >> On 2018/11/30 下午8:55, Jason Wang wrote: > >>> > >>> On 2018/11/30 下午8:52, Michael S. Tsirkin wrote: > >>If y

Re: [PATCH] net: marvell: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-03 Thread David Miller
From: Yangtao Li Date: Mon, 3 Dec 2018 09:34:11 -0500 > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Yangtao Li Applied.

Re: [PATCH] net: stmmac: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-03 Thread David Miller
From: Yangtao Li Date: Mon, 3 Dec 2018 09:22:09 -0500 > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Yangtao Li Applied.

Re: [PATCH] nfp: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-03 Thread David Miller
From: Yangtao Li Date: Mon, 3 Dec 2018 09:13:35 -0500 > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Yangtao Li Applied.

Re: [PATCH] net: qca_spi: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-03 Thread David Miller
From: Yangtao Li Date: Mon, 3 Dec 2018 09:26:38 -0500 > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Yangtao Li Applied.

Re: [RFC PATCH net-next 0/5] net: allow hw addresses for virtual devices

2018-12-03 Thread Ivan Khoronzhuk
On Mon, Dec 03, 2018 at 02:25:40PM -0800, Florian Fainelli wrote: On 12/3/18 10:40 AM, Ivan Khoronzhuk wrote: One of the reasons of this proposition is safety and performance - host should not receive traffic which is not designated for it. Some network devices can hold separate address tables

linux-next: manual merge of the bpf-next tree with the bpf tree

2018-12-03 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the bpf-next tree got a conflict in: net/core/filter.c between commit: b7df9ada9a77 ("bpf: fix pointer offsets in context for 32 bit") from the bpf tree and commit: e3da08d05700 ("bpf: allow BPF read access to qdisc pkt_len") from the bpf-next tree.

[PATCH net-next] net: netem: use a list in addition to rbtree

2018-12-03 Thread Peter Oskolkov
When testing high-bandwidth TCP streams with large windows, high latency, and low jitter, netem consumes a lot of CPU cycles doing rbtree rebalancing. This patch uses a linear list/queue in addition to the rbtree: if an incoming packet is past the tail of the linear queue, it is added there, other

linux-next: manual merge of the bpf-next tree with the bpf tree

2018-12-03 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the bpf-next tree got conflicts in: include/uapi/linux/bpf.h between commit: d74286d2c25a ("bpf: Improve socket lookup reuseport documentation") from the bpf tree and commit: 90b1023f68c7 ("bpf: fix documentation for eBPF helpers") from the bpf-next

Re: consistency for statistics with XDP mode

2018-12-03 Thread David Miller
From: David Ahern Date: Mon, 3 Dec 2018 17:15:03 -0700 > So, instead of a program tag which the program writer controls, how > about some config knob that an admin controls that says at attach time > use standard stats? How about, instead of replacing it is in addition to, and admin can override

Re: [PATCH net-next 0/2] mlx4_core cleanups

2018-12-03 Thread David Miller
From: Tariq Toukan Date: Sun, 2 Dec 2018 17:40:24 +0200 > This patchset by Erez contains cleanups to the mlx4_core driver. > > Patch 1 replaces -EINVAL with -EOPNOTSUPP for unsupported operations. > Patch 2 fixes some coding style issues. > > Series generated against net-next commit: > 97e6c85

Re: [PATCH net-next v2] net: phy: Also request modules for C45 IDs

2018-12-03 Thread David Miller
From: Jose Abreu Date: Sun, 2 Dec 2018 16:33:14 +0100 > Logic of phy_device_create() requests PHY modules according to PHY ID > but for C45 PHYs we use different field for the IDs. > > Let's also request the modules for these IDs. > > Changes from v1: > - Only request C22 modules if C45 are no

Re: [PATCH net-next v2 00/14] octeontx2-af: NIX and NPC enhancements

2018-12-03 Thread David Miller
From: Jerin Jacob Date: Sun, 2 Dec 2018 18:17:35 +0530 > This patchset is a continuation to earlier submitted four patch > series to add a new driver for Marvell's OcteonTX2 SOC's > Resource virtualization unit (RVU) admin function driver. > > 1. octeontx2-af: Add RVU Admin Function driver >

Re: [PATCH v2 bpf] mips: bpf: fix encoding bug for mm_srlv32_op

2018-12-03 Thread Jakub Kicinski
On Tue, 4 Dec 2018 00:06:24 +, Paul Burton wrote: > If you have related patches the best thing to do would be to submit them > together as a series. Then after the maintainers involved can see the > patches we can figure out the best way to apply them. Right, in hindsight that could've worked

Re: [PATCH net 0/2] mlx4 fixes for 4.20-rc

2018-12-03 Thread David Miller
From: Tariq Toukan Date: Sun, 2 Dec 2018 14:34:35 +0200 > This patchset includes small fixes for the mlx4_en driver. > > First patch by Eran fixes the value used to init the netdevice's > min_mtu field. > Please queue it to -stable >= v4.10. > > Second patch by Saeed adds missing Kconfig build

Re: consistency for statistics with XDP mode

2018-12-03 Thread David Ahern
On 12/3/18 5:00 PM, David Miller wrote: > From: Toke Høiland-Jørgensen > Date: Mon, 03 Dec 2018 22:00:32 +0200 > >> I wonder if it would be possible to support both the "give me user >> normal stats" case and the "let me do whatever I want" case by a >> combination of userspace tooling and maybe

Re: [PATCH v2] net/core: tidy up an error message

2018-12-03 Thread David Miller
From: Qian Cai Date: Sat, 1 Dec 2018 21:11:19 -0500 > netif_napi_add() could report an error like this below due to it allows > to pass a format string for wildcarding before calling > dev_get_valid_name(), > > "netif_napi_add() called with weight 256 on device eth%d" > > For example, hns_enet

Re: [PATCH v2 bpf] mips: bpf: fix encoding bug for mm_srlv32_op

2018-12-03 Thread Paul Burton
Hi Jakub, On Mon, Dec 03, 2018 at 03:55:45PM -0800, Jakub Kicinski wrote: > On Mon, 3 Dec 2018 22:42:04 +, Paul Burton wrote: > > Jiong Wang wrote: > > > For micro-mips, srlv inside POOL32A encoding space should use 0x50 > > > sub-opcode, NOT 0x90. > > > > > > Some early version ISA doc descr

Re: [PATCH v3 net] mv88e6060: disable hardware level MAC learning

2018-12-03 Thread David Miller
From: Anderson Luiz Alves Date: Fri, 30 Nov 2018 21:58:36 -0200 > Disable hardware level MAC learning because it breaks station roaming. > When enabled it drops all frames that arrive from a MAC address > that is on a different port at learning table. > > Signed-off-by: Anderson Luiz Alves > --

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-03 Thread Edgecombe, Rick P
It looks like this new flag is in linux-next now. As I am reading it, these architectures have a module_alloc that uses some sort of executable flag and are not using the default module_alloc which is already covered, and so may need it plugged in: arm arm64 parisc s390 unicore32 Thanks, Rick On

Re: [iproute2-next PATCH v6] tc: flower: Classify packets based port ranges

2018-12-03 Thread David Ahern
On 12/3/18 4:58 PM, Nambiar, Amritha wrote: > A previous version v3 of this patch was already applied to iproute2-next. > https://patchwork.ozlabs.org/patch/998644/ > > I think that needs to be reverted for this v6 to apply clean. ugh. That's embarrassing. Looks like I inadvertently pushed the ol

Re: [PATCH net] macvlan: return correct error value

2018-12-03 Thread David Miller
From: Matteo Croce Date: Sat, 1 Dec 2018 00:26:27 +0100 > A MAC address must be unique among all the macvlan devices with the same > lower device. The only exception is the passthru [sic] mode, > which shares the lower device address. > > When duplicate addresses are detected, EBUSY is returned

Re: consistency for statistics with XDP mode

2018-12-03 Thread David Miller
From: Toke Høiland-Jørgensen Date: Mon, 03 Dec 2018 22:00:32 +0200 > I wonder if it would be possible to support both the "give me user > normal stats" case and the "let me do whatever I want" case by a > combination of userspace tooling and maybe a helper or two? > > I.e., create a "do_stats()"

Re: [PATCH net-next v4 0/3] udp msg_zerocopy

2018-12-03 Thread David Miller
From: Willem de Bruijn Date: Fri, 30 Nov 2018 15:32:38 -0500 > Enable MSG_ZEROCOPY for udp sockets Series applied, thanks for keeping up with this.

Re: [iproute2-next PATCH v6] tc: flower: Classify packets based port ranges

2018-12-03 Thread Nambiar, Amritha
On 12/3/2018 3:52 PM, David Ahern wrote: > On 11/27/18 3:40 PM, Amritha Nambiar wrote: >> Added support for filtering based on port ranges. >> UAPI changes have been accepted into net-next. >> >> Example: >> 1. Match on a port range: >> - >> $ tc filter add dev enp4s0 protoc

Re: [RFC PATCH net-next 2/5] net: 8021q: vlan_dev: add vid tag for uc and mc address lists

2018-12-03 Thread Florian Fainelli
On 12/3/18 3:51 PM, Ivan Khoronzhuk wrote: > On Mon, Dec 03, 2018 at 02:17:00PM -0800, Florian Fainelli wrote: >> On 12/3/18 10:40 AM, Ivan Khoronzhuk wrote: >>> Update vlan mc and uc addresses with VID tag while propagating address >>> set to lower devices, do this only if address is not synched.

Re: [PATCH 0/3] net: macb: DMA race condition fixes

2018-12-03 Thread David Miller
From: Date: Mon, 3 Dec 2018 08:26:52 + > Can you please delay a bit the acceptance of this series, I would like > that we assess these findings with tests on our hardware before applying > them. Sure.

Re: [PATCH net] sctp: kfree_rcu asoc

2018-12-03 Thread David Miller
From: Xin Long Date: Sat, 1 Dec 2018 01:36:59 +0800 > In sctp_hash_transport/sctp_epaddr_lookup_transport, it dereferences > a transport's asoc under rcu_read_lock while asoc is freed not after > a grace period, which leads to a use-after-free panic. > > This patch fixes it by calling kfree_rcu

Re: [PATCH v2 bpf] mips: bpf: fix encoding bug for mm_srlv32_op

2018-12-03 Thread Jakub Kicinski
On Mon, 3 Dec 2018 22:42:04 +, Paul Burton wrote: > Jiong Wang wrote: > > For micro-mips, srlv inside POOL32A encoding space should use 0x50 > > sub-opcode, NOT 0x90. > > > > Some early version ISA doc describes the encoding as 0x90 for both srlv and > > srav, this looks to me was a typo. I ch

Re: [RFC PATCH 4/6] dt-bindings: update mvneta binding document

2018-12-03 Thread Rob Herring
On Mon, Nov 12, 2018 at 12:31:02PM +, Russell King wrote: > Signed-off-by: Russell King Needs a better subject and a commit msg. > --- > Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/Documentati

Re: [PATCH net] net/ibmvnic: Fix RTNL deadlock during device reset

2018-12-03 Thread David Miller
From: Thomas Falcon Date: Fri, 30 Nov 2018 10:59:08 -0600 > Commit a5681e20b541 ("net/ibmnvic: Fix deadlock problem > in reset") made the change to hold the RTNL lock during > driver reset but still calls netdev_notify_peers, which > results in a deadlock. Instead, use call_netdevice_notifiers, >

Re: [RFC PATCH 1/6] dt-bindings: phy: Armada 38x common phy bindings

2018-12-03 Thread Rob Herring
On Mon, 12 Nov 2018 12:30:47 +, Russell King wrote: > Add the Marvell Armada 38x common phy bindings. > > Signed-off-by: Russell King > --- > .../bindings/phy/phy-armada38x-comphy.txt | 40 > ++ > 1 file changed, 40 insertions(+) > create mode 100644 > Documen

Re: [PATCH v2] vhost: fix IOTLB locking

2018-12-03 Thread David Miller
From: Jean-Philippe Brucker Date: Fri, 30 Nov 2018 16:05:53 + > Commit 78139c94dc8c ("net: vhost: lock the vqs one by one") moved the vq > lock to improve scalability, but introduced a possible deadlock in > vhost-iotlb. vhost_iotlb_notify_vq() now takes vq->mutex while holding > the device's

Re: [PATCH net] rtnetlink: Refine sanity checks in rtnl_fdb_{add|del}

2018-12-03 Thread David Miller
From: Ido Schimmel Date: Fri, 30 Nov 2018 19:00:24 +0200 > Yes, agree. Patch is good. I'll tag your v2. This means, I assume, that a new version of this fix is coming. Eric, is this correct?

Re: [iproute2-next PATCH v6] tc: flower: Classify packets based port ranges

2018-12-03 Thread David Ahern
On 11/27/18 3:40 PM, Amritha Nambiar wrote: > Added support for filtering based on port ranges. > UAPI changes have been accepted into net-next. > > Example: > 1. Match on a port range: > - > $ tc filter add dev enp4s0 protocol ip parent :\ > prio 1 flower ip_proto tc

Re: [RFC PATCH net-next 2/5] net: 8021q: vlan_dev: add vid tag for uc and mc address lists

2018-12-03 Thread Ivan Khoronzhuk
On Mon, Dec 03, 2018 at 02:17:00PM -0800, Florian Fainelli wrote: On 12/3/18 10:40 AM, Ivan Khoronzhuk wrote: Update vlan mc and uc addresses with VID tag while propagating address set to lower devices, do this only if address is not synched. It allows on end driver level to distinguish address

Re: [PATCH net-next v4 0/2] Add mii_bus to ixgbe driver for dsa devs

2018-12-03 Thread Florian Fainelli
On 12/3/18 3:42 PM, Steve Douthit wrote: >> Not directly related to this patch series, are you using the legacy or >> "new" way of passing platform data in order to register the DSA switch? >> Since you mentioned 6390, I would assume this must be the "new" way of >> registering DSA devices with mdi

Re: [Patch net v2] mlx5: fixup checksum for short ethernet frame padding

2018-12-03 Thread Cong Wang
On Mon, Dec 3, 2018 at 3:17 PM David Miller wrote: > > Saeed, are you going to take care of this? David, I will send v3 to switch to CHECKSUM_NONE for these short frames, which also could avoid parsing IP headers. Thanks.

Re: pull-request: wireless-drivers-next 2018-11-30

2018-12-03 Thread David Miller
From: Kalle Valo Date: Fri, 30 Nov 2018 15:33:29 +0200 > here's a pull request to net-next tree for 4.21, more info below. Please > let me know if you have any problems. Pulled, thank you Kalle.

Re: [PATCH net-next v4 0/2] Add mii_bus to ixgbe driver for dsa devs

2018-12-03 Thread Steve Douthit
> Not directly related to this patch series, are you using the legacy or > "new" way of passing platform data in order to register the DSA switch? > Since you mentioned 6390, I would assume this must be the "new" way of > registering DSA devices with mdio_boardinfo etc. In that case, have you > fou

Re: [net-next][PATCH 0/4] davinci_emac: read the MAC address from nvmem

2018-12-03 Thread David Miller
From: Bartosz Golaszewski Date: Fri, 30 Nov 2018 09:20:56 +0100 > From: Bartosz Golaszewski > > This series is part of a bigger series that aims at removing the platform > data structure from the at24 EEPROM driver[1]. > > We provide a generalized version of of_get_nvmem_mac_address(), switch

Re: [PATCH v2 0/2] net: phy: micrel: add tobling phy reset

2018-12-03 Thread David Miller
From: Florian Fainelli Date: Mon, 3 Dec 2018 15:24:43 -0800 > Meh! I guess we should be faster at reviewing stuff :/ Sorry, it was posted last Wednesday!

[PATCH RFC 2/6] net: dsa: microchip: Add MIB counter reading support

2018-12-03 Thread Tristram.Ha
From: Tristram Ha Add MIB counter reading support. Signed-off-by: Tristram Ha Reviewed-by: Woojung Huh --- drivers/net/dsa/microchip/ksz9477.c| 121 ++--- drivers/net/dsa/microchip/ksz_common.c | 101 +++ drivers/net/dsa/microchip/ksz_co

[PATCH RFC 5/6] net: dsa: microchip: Update tag_ksz.c to access switch driver

2018-12-03 Thread Tristram.Ha
From: Tristram Ha Update tag_ksz.c to access switch driver's tail tagging operations. Signed-off-by: Tristram Ha --- net/dsa/tag_ksz.c | 44 1 file changed, 20 insertions(+), 24 deletions(-) diff --git a/net/dsa/tag_ksz.c b/net/dsa/tag_ksz.c index

[PATCH RFC 6/6] net: dsa: microchip: Add switch offload forwarding support

2018-12-03 Thread Tristram.Ha
From: Tristram Ha The flag offload_fwd_mark is set as the switch can forward frames by itself. Signed-off-by: Tristram Ha --- drivers/net/dsa/microchip/ksz9477.c | 7 --- net/dsa/tag_ksz.c | 2 ++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/

[PATCH RFC 3/6] net: dsa: microchip: Break ksz_priv.h into two files

2018-12-03 Thread Tristram.Ha
From: Tristram Ha Break ksz_priv.h into two files: private and public. The public one is put in include/linux/dsa/ksz_dsa.h. This allows the tail tagging code tag_ksz.c to access the switch driver as the tail tag format can be different when certain switch functions are enabled. Signed-off-by:

[PATCH RFC 4/6] net: dsa: microchip: Each switch driver has its own tail tagging operations

2018-12-03 Thread Tristram.Ha
From: Tristram Ha The tail tagging operations are implemented in each switch driver so that the main tail tagging code tag_ksz.c does not need to be changed after modification to support that mechanism is made. Signed-off-by: Tristram Ha --- drivers/net/dsa/microchip/ksz9477.c| 78

[PATCH RFC 0/6] net: dsa: microchip: Modify KSZ9477 DSA driver to support different tail tag formats

2018-12-03 Thread Tristram.Ha
From: Tristram Ha This series of patches is to modify the KSZ9477 DSA driver to support different tail tag formats such that other new KSZ switch drivers can be added without changing the base tail tagging code. Tristram Ha (6): net: dsa: microchip: Prepare PHY for proper advertisement net:

[PATCH RFC 1/6] net: dsa: microchip: Prepare PHY for proper advertisement

2018-12-03 Thread Tristram.Ha
From: Tristram Ha Prepare PHY for proper advertisement and get link status for the port. Signed-off-by: Tristram Ha Reviewed-by: Woojung Huh --- drivers/net/dsa/microchip/ksz9477.c| 12 drivers/net/dsa/microchip/ksz_common.c | 17 + drivers/net/dsa/microchip/k

Re: [PATCH v3] rhashtable: detect when object movement between tables might have invalidated a lookup

2018-12-03 Thread David Miller
From: NeilBrown Date: Fri, 30 Nov 2018 10:26:50 +1100 > > Some users of rhashtables might need to move an object from one table > to another - this appears to be the reason for the incomplete usage > of NULLS markers. > > To support these, we store a unique NULLS_MARKER at the end of > each ch

Re: [PATCH net-next 0/2] Adds VF/PF PCIe reg dump(ethtool -d) support to HNS3 driver

2018-12-03 Thread David Miller
From: Salil Mehta Date: Thu, 29 Nov 2018 16:40:57 + > This patchset adds VF/PF PCIe register dump support to HNS3 VF and PF driver > using "ethtool -d" command. Series applied, thanks Salil.

Re: [PATCH v2 0/2] net: phy: micrel: add tobling phy reset

2018-12-03 Thread Florian Fainelli
On 12/3/18 3:20 PM, David Miller wrote: > From: Yoshihiro Shimoda > Date: Wed, 28 Nov 2018 09:02:41 + > >> This patch set is for R-Car Gen3 Salvator-XS boards. If we do >> the following method, the phy cannot link up correctly. >> >> 1) Kernel boots by using initramfs. >> --> No open the ni

Re: [PATCH v2 0/2] net: phy: micrel: add tobling phy reset

2018-12-03 Thread David Miller
From: Yoshihiro Shimoda Date: Wed, 28 Nov 2018 09:02:41 + > This patch set is for R-Car Gen3 Salvator-XS boards. If we do > the following method, the phy cannot link up correctly. > > 1) Kernel boots by using initramfs. > --> No open the nic, so phy_device_register() and phy_probe() >

  1   2   3   >