On Mon, Dec 3, 2018 at 11:08 PM Eric Dumazet <eduma...@google.com> wrote: > > The hardware has probably validated the L3 & L4 checksum just fine. > > Note that if ip_summed is CHECKSUM_UNNECESSARY, the padding bytes (if any) > have no impact on the csum that has been verified by the NIC.
Why? Why does the hardware validates L3/L4 checksum when it supplies a full-packet checksum? What's its point here? If it really validates L3/L4 checksum, then a full-packet checksum is not needed. If a full-packet checksum is supplied, the software is able to use it to validate L3/L4 checksum, then the hardware doesn't need to validate it. I see no reason it provides both at the same time. If it really does, then all CHECKSUM_COMPLETE code here could be just removed and would be faster. Something must be wrong with your argument. > > Sorry I do not get your point. I don't get your point either. Thanks.
