[PATCH v2 net-next] net: phy: improve handling delayed work

Using mod_delayed_work() allows to simplify handling delayed work and removes the need for the sync parameter in phy_trigger_machine(). Also introduce a helper phy_queue_state_machine() to encapsulate the low-level delayed work calls. No functional change intended. Signed-off-by: Heiner Kallweit

[PATCH v3 net-next 6/9] bnxt_en: Use msix_vec_per_pf_max and msix_vec_per_pf_min devlink params.

This patch adds support for following generic permanent mode devlink parameters. They can be modified using devlink param commands. msix_vec_per_pf_max - This param sets the number of MSIX vectors that the device requests from the host on driver initialization. This value is set in the device whic

[PATCH v3 net-next 8/9] devlink: Add Documentation/networking/devlink-params.txt

This patch adds a new file to add information about some of the generic configuration parameters set via devlink. Cc: "David S. Miller" Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam --- Documentation/networking/devlink-param

[PATCH v3 net-next 2/9] devlink: Add generic parameter msix_vec_per_pf_max

msix_vec_per_pf_max - This param sets the number of MSIX vectors that the device requests from the host on driver initialization. This value is set in the device which is applicable per PF. Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam --- include/net/devlink.h | 4 net/

[PATCH v3 net-next 4/9] bnxt_en: Use ignore_ari devlink parameter

This patch adds support for ignore_ari generic permanent mode devlink parameter. This parameter is disabled by default. It can be enabled using devlink param commands. ignore_ari - If enabled, device ignores ARI(Alternate Routing ID) capability, even when platforms has the support and creates same

[PATCH v3 net-next 1/9] devlink: Add generic parameter ignore_ari

ignore_ari - Device ignores ARI(Alternate Routing ID) capability, even when platforms has the support and creates same number of partitions when platform does not support ARI capability. Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam --- include/net/devlink.h | 4 net/cor

[PATCH v3 net-next 3/9] devlink: Add generic parameter msix_vec_per_pf_min

msix_vec_per_pf_min - This param sets the number of minimal MSIX vectors required for the device initialization. This value is set in the device which limits MSIX vectors per PF. Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam --- include/net/devlink.h | 4 net/core/devlin

[PATCH v3 net-next 9/9] devlink: Add Documentation/networking/devlink-params-bnxt.txt

This patch adds a new file to add information about configuration parameters that are supported by bnxt_en driver via devlink. Cc: "David S. Miller" Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam --- Documentation/networking/

[PATCH v3 net-next 7/9] bnxt_en: Add a driver specific gre_ver_check devlink parameter.

This patch adds following driver-specific permanent mode boolean parameter. gre_ver_check - Generic Routing Encapsulation(GRE) version check will be enabled in the device. If disabled, device skips version checking for GRE packets. Cc: Michael Chan Signed-off-by: Vasundhara Volam --- drivers/n

[PATCH v3 net-next 5/9] bnxt_en: return proper error when FW returns HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED

Return proper error code when Firmware returns HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED for HWRM_NVM_GET/SET_VARIABLE commands. Cc: Michael Chan Signed-off-by: Vasundhara Volam --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --g

[PATCH v3 net-next 0/9] bnxt_en: devlink param updates

This patchset adds support for 3 generic and 1 driver-specific devlink parameters. Add documentation for these configuration parameters. Also, this patchset adds support to return proper error code if HWRM_NVM_GET/SET_VARIABLE commands return error code HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED. v2->v

Re: re iproute2 - don't return error on success fix

On Thu, Sep 27, 2018 at 3:53 PM Phil Sutter wrote: > Hmm, I can't reproduce this. My HEAD is at the commit you mentioned: > > | % sudo ./tc/tc filter add dev d0 protocol ip parent : flower skip_sw > ip_flags nofirstfrag action drop > | RTNETLINK answers: Operation not supported > | We have a

[PATCH 13/15] octeontx2-af: Add support for CGX link management

From: Linu Cherian CGX LMAC initialization, link status polling etc is done by low level secure firmware. For link management this patch adds a interface or communication mechanism between firmware and this kernel CGX driver. - Firmware interface specification is defined in cgx_fw_if.h. - Suppor

[PATCH 09/15] octeontx2-af: Configure block LF's MSIX vector offset

From: Sunil Goutham Firmware configures a certain number of MSIX vectors to each of enabled RVU PF/VF. When a block LF is attached to a PF/VF, number of MSIX vectors needed by that LF are set aside (out of PF/VF's total MSIX vectors) and LF's msix_offset is configured in HW. Also added support f

[PATCH 05/15] octeontx2-af: Add mailbox IRQ and msg handlers

From: Sunil Goutham This patch adds support for mailbox interrupt and message handling. Mapped mailbox region and registered a workqueue for message handling. Enabled mailbox IRQ of RVU PFs and registered a interrupt handler. When IRQ is triggered work is added to the mbox workqueue for msgs to g

[PATCH 07/15] octeontx2-af: Scan blocks for LFs provisioned to PF/VF

From: Sunil Goutham Scan all RVU blocks to find any 'LF to RVU PF/VF' mapping done by low level firmware. If found any, mark them as used in respective block's LF bitmap and also save mapped PF/VF's PF_FUNC info. This is done to avoid reattaching a block LF to a different RVU PF/VF. Signed-off-

[PATCH 15/15] MAINTAINERS: Add entry for Marvell OcteonTX2 Admin Function driver

From: Sunil Goutham Added maintainers entry for Marvell OcteonTX2 SOC's RVU admin function driver. Signed-off-by: Sunil Goutham --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7233a9e..4f93114 100644 --- a/MAINTAINERS +++ b/MAINTAINE

[PATCH 11/15] octeontx2-af: Add Marvell OcteonTX2 CGX driver

From: Sunil Goutham This patch adds basic template for Marvell OcteonTX2's CGX ethernet interface driver. Just the probe. RVU AF driver will use APIs exported by this driver for various things like PF to physical interface mapping, loopback mode, interface stats etc. Hence marged both drivers int

[PATCH 14/15] octeontx2-af: Register for CGX lmac events

From: Linu Cherian Added support in RVU AF driver to register for CGX LMAC link status change events from firmware and managing them. Processing part will be added in followup patches. - Introduced eventqueue for posting events from cgx lmac. Queueing mechanism will ensure that events can be p

[PATCH 10/15] octeontx2-af: Reconfig MSIX base with IOVA

From: Geetha sowjanya HW interprets RVU_AF_MSIXTR_BASE address as an IOVA, hence create a IOMMU mapping for the physcial address configured by firmware and reconfig RVU_AF_MSIXTR_BASE with IOVA. Signed-off-by: Geetha sowjanya Signed-off-by: Sunil Goutham --- drivers/net/ethernet/marvell/octeo

[PATCH 06/15] octeontx2-af: Convert mbox msg id check to a macro

From: Aleksey Makarov With 10's of mailbox messages expected to be handled in future, checking for message id could become a lengthy switch case. Hence added a macro to auto generate the switch case for each msg id. Signed-off-by: Aleksey Makarov --- drivers/net/ethernet/marvell/octeontx2/af/r

[PATCH 08/15] octeontx2-af: Add RVU block LF provisioning support

From: Sunil Goutham Added support for a RVU PF/VF to request AF via mailbox to attach or detach NPA/NIX/SSO/SSOW/TIM/CPT block LFs. Also supports partial detachment and modifying current LF attached count of a certian block type. Signed-off-by: Sunil Goutham --- drivers/net/ethernet/marvell/oc

[PATCH 12/15] octeontx2-af: Set RVU PFs to CGX LMACs mapping

From: Linu Cherian Each of the enabled CGX LMAC is considered a physical interface and RVU PFs are mapped to these. VFs of these SRIOV PFs will be virtual interfaces and share CGX LMAC along with PF. This mapping info will be used later on for Rx/Tx pkt steering. Signed-off-by: Linu Cherian Si

[PATCH 03/15] octeontx2-af: Gather RVU blocks HW info

From: Sunil Goutham This patch gathers NPA/NIX/SSO/SSOW/TIM/CPT RVU blocks's HW info like number of LFs. Important register offsets saved for later use to avoid code duplication for each block. A bitmap is allocated for each of the blocks which later on will be used to allocate a LF for a RVU PF/

[PATCH 01/15] octeontx2-af: Add Marvell OcteonTX2 RVU AF driver

From: Sunil Goutham This patch adds basic template for Marvell OcteonTX2's resource virtualization unit (RVU) admin function (AF) driver. Just the driver registration and probe. Signed-off-by: Sunil Goutham --- drivers/net/ethernet/marvell/Kconfig | 3 + drivers/net/ethernet/ma

[PATCH 02/15] octeontx2-af: Reset all RVU blocks

From: Sunil Goutham Go through all BLKADDRs and check which ones are implemented on this silicon and do a HW reset of each implemented block. Also added all RVU AF and PF register offsets. Signed-off-by: Sunil Goutham --- drivers/net/ethernet/marvell/octeontx2/af/rvu.c| 78 ++

[PATCH 04/15] octeontx2-af: Add mailbox support infra

From: Sunil Goutham This patch adds mailbox support infrastructure APIs. Each RVU device has a dedicated 64KB mailbox region shared with it's peer for communication. RVU AF has a separate mailbox region shared with each of RVU PFs and a RVU PF has a separate region shared with each of it's VF. T

[PATCH 00/15] octeontx2-af: Add RVU Admin Function driver

From: Sunil Goutham Resource virtualization unit (RVU) on Marvell's OcteonTX2 SOC maps HW resources from the network, crypto and other functional blocks into PCI-compatible physical and virtual functions. Each functional block again has multiple local functions (LFs) for provisioning to PCI devic

Re: [Patch net-next] net_sched: fix an extack message in tcf_block_find()

On 9/27/18 3:36 PM, Cong Wang wrote: > On Thu, Sep 27, 2018 at 2:16 PM Eric Dumazet wrote: >> >> >> >> On 09/27/2018 01:42 PM, Cong Wang wrote: >>> It is clearly a copy-n-paste. >>> >>> Signed-off-by: Cong Wang >>> --- >>> net/sched/cls_api.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletio

Re: [PATCH net] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

On Thu, 2018-09-27 at 21:08 +, justin.l...@dell.com wrote: > The new command (NCSI_CMD_SEND_CMD) is added to allow user space application > to send NC-SI command to the network card. > Also, add a new attribute (NCSI_ATTR_DATA) for transferring request and > response. > > The work flow is as

Re: [PATCH net-next v6 00/23] WireGuard: Secure Network Tunnel

On Thu, Sep 27, 2018 at 11:35:39PM +0200, Jason A. Donenfeld wrote: > Hi Eric, > > On Thu, Sep 27, 2018 at 8:29 PM Eric Biggers wrote: > > Why is Herbert Xu's existing crypto tree being circumvented, especially for > > future patches (the initial merge isn't quite as important as that's a > > on

[PATCH net-next] geneve: fix ttl inherit type

Phil pointed out that there is a mismatch between vxlan and geneve ttl inherit. We should define it as a flag and use nla_put_flag to export this opiton. Fixes: 52d0d404d39dd ("geneve: add ttl inherit support") Reported-by: Phil Sutter Signed-off-by: Hangbin Liu --- drivers/net/geneve.c | 6 +++

Re: [PATCH net-next v6 23/23] net: WireGuard secure network tunnel

On Fri, Sep 28, 2018 at 12:37 AM Jason A. Donenfeld wrote: > Will do. v7 will include the wg_ prefix. $ nm *.o | while read a b c; do [[ $b == T ]] && echo $c; done | grep -v ^wg_ cleanup_module init_module Success.

[PATCH net] vxlan: use nla_put_flag for ttl inherit

Phil pointed out that there is a mismatch between vxlan and geneve ttl inherit. We should define it as a flag and use nla_put_flag to export this opiton. Fixes: 8fd780698745b ("vxlan: fill ttl inherit info") Reported-by: Phil Sutter Signed-off-by: Hangbin Liu --- drivers/net/vxlan.c | 8 +--

Re: [PATCH iproute2-next] geneve: fix ttl inherit behavior

On Thu, Sep 27, 2018 at 11:08:36AM +0200, Phil Sutter wrote: > On Thu, Sep 27, 2018 at 03:27:37PM +0800, Hangbin Liu wrote: > > Currently when we add geneve with "ttl inherit", we set ttl to 0, which > > is actually use whatever default value instead of inherit the inner > > protocol's ttl value. >

Re: [PATCH resend] can: rcar_can: convert to SPDX identifiers

Hi Marc > > From: Kuninori Morimoto > > > > This patch updates license to use SPDX-License-Identifier > > instead of verbose license text. > > > > Signed-off-by: Kuninori Morimoto > > Reviewed-by: Simon Horman > > Wolfram Sang has already supplied a similar patch, but not for Makefile > an

Re: WARN_ON in TLP causing RT throttling

On 09/27/2018 05:16 PM, stran...@codeaurora.org wrote: > Hi Yuchung, > > Based on the dumps we were able to get, it appears that TFO was not used in > this case. > We also tried some local experiments where we dropped incoming SYN packets > after already > successful TFO connections on the r

Re: WARN_ON in TLP causing RT throttling

On 2018-09-27 13:14, Yuchung Cheng wrote: On Wed, Sep 26, 2018 at 5:09 PM, Eric Dumazet wrote: On 09/26/2018 04:46 PM, stran...@codeaurora.org wrote: > Hi Eric, > > Someone recently reported a crash to us on the 4.14.62 kernel where excessive > WARNING prints were spamming the logs and causi

Re: [PATCH net V2] vhost-vsock: fix use after free

On Fri, Sep 28, 2018 at 07:37:37AM +0800, Jason Wang wrote: > > > On 2018年09月28日 01:04, Michael S. Tsirkin wrote: > > On Thu, Sep 27, 2018 at 08:22:04PM +0800, Jason Wang wrote: > > > The access of vsock is not protected by vhost_vsock_lock. This may > > > lead to use after free since vhost_vsock

Re: [PATCH net-next] virtio_net: ethtool tx napi configuration

On 2018年09月27日 21:53, Willem de Bruijn wrote: On Thu, Sep 27, 2018 at 4:51 AM Jason Wang wrote: On 2018年09月14日 12:46, Willem de Bruijn wrote: I'm not sure I get this. If we don't enable tx napi, we tend to delay TX interrupt if we found the ring is about to full to avoid interrupt storm,

Re: [PATCH net V2] vhost-vsock: fix use after free

On 2018年09月28日 01:04, Michael S. Tsirkin wrote: On Thu, Sep 27, 2018 at 08:22:04PM +0800, Jason Wang wrote: The access of vsock is not protected by vhost_vsock_lock. This may lead to use after free since vhost_vsock_dev_release() may free the pointer at the same time. Fix this by holding the

[PATCHv3 bpf-next 00/12] Add socket lookup support

This series proposes a new helper for the BPF API which allows BPF programs to perform lookups for sockets in a network namespace. This would allow programs to determine early on in processing whether the stack is expecting to receive the packet, and perform some action (eg drop, forward somewhere)

[PATCHv3 bpf-next 04/12] bpf: Add PTR_TO_SOCKET verifier type

Teach the verifier a little bit about a new type of pointer, a PTR_TO_SOCKET. This pointer type is accessed from BPF through the 'struct bpf_sock' structure. Signed-off-by: Joe Stringer --- v2: Reuse reg_type_mismatch() in more places Reduce the number of passes at convert_ctx_access() v3: F

[PATCHv3 bpf-next 08/12] selftests/bpf: Generalize dummy program types

Don't hardcode the dummy program types to SOCKET_FILTER type, as this prevents testing bpf_tail_call in conjunction with other program types. Instead, use the program type specified in the test case. Signed-off-by: Joe Stringer --- tools/testing/selftests/bpf/test_verifier.c | 31 +++

[PATCHv3 bpf-next 02/12] bpf: Simplify ptr_min_max_vals adjustment

An upcoming commit will add another two pointer types that need very similar behaviour, so generalise this function now. Signed-off-by: Joe Stringer Acked-by: Alexei Starovoitov --- kernel/bpf/verifier.c | 22 ++--- tools/testing/selftests/bpf/test_verifier

[PATCHv3 bpf-next 05/12] bpf: Macrofy stack state copy

An upcoming commit will need very similar copy/realloc boilerplate, so refactor the existing stack copy/realloc functions into macros to simplify it. Signed-off-by: Joe Stringer Acked-by: Alexei Starovoitov --- kernel/bpf/verifier.c | 106 -- 1 file chang

[PATCHv3 bpf-next 01/12] bpf: Add iterator for spilled registers

Add this iterator for spilled registers, it concentrates the details of how to get the current frame's spilled registers into a single macro while clarifying the intention of the code which is calling the macro. Signed-off-by: Joe Stringer Acked-by: Alexei Starovoitov --- include/linux/bpf_veri

[PATCHv3 bpf-next 11/12] selftests/bpf: Add C tests for reference tracking

Add some tests that demonstrate and test the balanced lookup/free nature of socket lookup. Section names that start with "fail" represent programs that are expected to fail verification; all others should succeed. Signed-off-by: Joe Stringer Acked-by: Alexei Starovoitov --- v3: Rebase against fl

[PATCHv3 bpf-next 12/12] Documentation: Describe bpf reference tracking

Document the new pointer types in the verifier and how the pointer ID tracking works to ensure that references which are taken are later released. Signed-off-by: Joe Stringer Acked-by: Alexei Starovoitov --- Documentation/networking/filter.txt | 64 + 1 file changed,

[PATCHv3 bpf-next 07/12] bpf: Add helper to retrieve socket in BPF

This patch adds new BPF helper functions, bpf_sk_lookup_tcp() and bpf_sk_lookup_udp() which allows BPF programs to find out if there is a socket listening on this host, and returns a socket pointer which the BPF program can then access to determine, for instance, whether to forward or drop traffic.

[PATCHv3 bpf-next 03/12] bpf: Generalize ptr_or_null regs check

This check will be reused by an upcoming commit for conditional jump checks for sockets. Refactor it a bit to simplify the later commit. Signed-off-by: Joe Stringer Acked-by: Alexei Starovoitov --- kernel/bpf/verifier.c | 43 +-- 1 file changed, 25 insert

[PATCHv3 bpf-next 09/12] selftests/bpf: Add tests for reference tracking

reference tracking: leak potential reference reference tracking: leak potential reference on stack reference tracking: leak potential reference on stack 2 reference tracking: zero potential reference reference tracking: copy and zero potential references reference tracking: release reference withou

[PATCHv3 bpf-next 06/12] bpf: Add reference tracking to verifier

Allow helper functions to acquire a reference and return it into a register. Specific pointer types such as the PTR_TO_SOCKET will implicitly represent such a reference. The verifier must ensure that these references are released exactly once in each path through the program. To achieve this, this

[PATCHv3 bpf-next 10/12] libbpf: Support loading individual progs

Allow the individual program load to be invoked. This will help with testing, where a single ELF may contain several sections, some of which denote subprograms that are expected to fail verification, along with some which are expected to pass verification. By allowing programs to be iterated and in

Re: KMSAN: uninit-value in __dev_mc_add

Hello, Eric, all, > I dunno, your patch looks quite not the right fix. I agree, it looks more like a dirty hack. Unfortunately, I lack the deep expertise in the network stack subsystem, so I've posted the patch to, sort of, start a discussion and probably get some hints. > If TUN is able to cha

Re: [PATCH] netfilter: check if the socket netns is correct.

On Thu, Sep 27, 2018 at 07:58:24PM -0300, Flavio Leitner wrote: > On Thu, Sep 27, 2018 at 01:46:29PM -0700, Guenter Roeck wrote: > > Hi Flavio, > > > > On Wed, Jun 27, 2018 at 10:34:25AM -0300, Flavio Leitner wrote: > > > Netfilter assumes that if the socket is present in the skb, then > > > it ca

[PATCH] cfg80211: fix use-after-free in reg_process_hint()

reg_process_hint_country_ie() can free regulatory_request and return REG_REQ_ALREADY_SET. We shouldn't use regulatory_request after it's called. KASAN error was observed when this happens. BUG: KASAN: use-after-free in reg_process_hint+0x839/0x8aa [cfg80211] Read of size 4 at addr 8800c430d434

[PATCH 07/11] net: remove 1 always zero parameter from ip6_redirect_no_header()

From: Maciej Żenczykowski (the parameter in question is mark) Signed-off-by: Maciej Żenczykowski --- include/net/ip6_route.h | 3 +-- net/ipv6/ndisc.c| 2 +- net/ipv6/route.c| 4 +--- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/include/net/ip6_route.h b/inclu

[PATCH 05/11] net: ip6_redirect() - use new style struct initializer instead of memset

From: Maciej Żenczykowski (allows for better compiler optimization) Signed-off-by: Maciej Żenczykowski --- net/ipv6/route.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 9cb024451fc5..e148d197d628 100644 --- a

[PATCH 11/11] net: inet6_rtm_getroute() - use new style struct initializer instead of memset

From: Maciej Żenczykowski Signed-off-by: Maciej Żenczykowski --- net/ipv6/route.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 9aca81772c93..aca6a84de794 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -4819,7 +4819,7 @@

[PATCH 06/11] net: ip6_redirect_no_header() - use new style struct initializer instead of memset

From: Maciej Żenczykowski (allows for better compiler optimization) Signed-off-by: Maciej Żenczykowski --- net/ipv6/route.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index e148d197d628..dd8c04f253d5 100644 --- a/ne

[PATCH 08/11] net: ip6_update_pmtu() - use new style struct initializer instead of memset

From: Maciej Żenczykowski (allows for better compiler optimization) Signed-off-by: Maciej Żenczykowski --- net/ipv6/route.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 27f1260e053a..a87b79574a91 100644 --- a/ne

[PATCH 09/11] net: rtmsg_to_fib6_config() - use new style struct initializer instead of memset

From: Maciej Żenczykowski (allows for better compiler optimization) Signed-off-by: Maciej Żenczykowski --- net/ipv6/route.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index a87b79574a91..b8fece1d602

[PATCH 10/11] net: rtm_to_fib6_config() - use new style struct initializer instead of memset

From: Maciej Żenczykowski (allows for better compiler optimization) Signed-off-by: Maciej Żenczykowski --- net/ipv6/route.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index b8fece1d6021..9aca81772c93 100644

[PATCH 04/11] net: ip6_multipath_l3_keys() - use new style struct initializer instead of memset

From: Maciej Żenczykowski Signed-off-by: Maciej Żenczykowski --- net/ipv6/route.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index d28f83e01593..9cb024451fc5 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -1981,12 +1981,

[PATCH 03/11] net: fib_multipath_hash() - use new style struct initializer instead of memset

From: Maciej Żenczykowski Signed-off-by: Maciej Żenczykowski --- net/ipv4/route.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 048919713f4e..17953a52fbd0 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -1821,12 +1821,

[PATCH 01/11] net: ip_rt_get_source() - use new style struct initializer instead of memset

From: Maciej Żenczykowski (allows for better compiler optimization) Signed-off-by: Maciej Żenczykowski --- net/ipv4/route.c | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index dce2ed66ebe1..02482b71498b 100644 ---

[PATCH 02/11] net: inet_rtm_getroute() - use new style struct initializer instead of memset

From: Maciej Żenczykowski Signed-off-by: Maciej Żenczykowski --- net/ipv4/route.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 02482b71498b..048919713f4e 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -2780,7 +2780,7 @@

Re: [PATCH] netfilter: check if the socket netns is correct.

On Thu, Sep 27, 2018 at 01:46:29PM -0700, Guenter Roeck wrote: > Hi Flavio, > > On Wed, Jun 27, 2018 at 10:34:25AM -0300, Flavio Leitner wrote: > > Netfilter assumes that if the socket is present in the skb, then > > it can be used because that reference is cleaned up while the skb > > is crossing

[PATCH net-next 4/5] net: systemport: Be drop monitor friendly while re-allocating headroom

During bcm_sysport_insert_tsb() make sure we differentiate a SKB headroom re-allocation failure from the normal swap and replace path. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/bcmsysport.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/

[PATCH net-next 2/5] net: systemport: Utilize bcm_sysport_set_features() during resume/open

During driver resume and open, the HW may have lost its context/state, utilize bcm_sysport_set_features() to make sure we do restore the correct set of features that were previously configured. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/bcmsysport.c | 14 +++--- 1

[PATCH net-next 1/5] net: systemport: Refactor bcm_sysport_set_features()

In preparation for unconditionally enabling TX and RX checksum offloads, refactor bcm_sysport_set_features() a bit such that __netdev_update_features() during register_netdev() can make sure that features are correctly programmed during network device registration. Since we can now be called durin

[PATCH net-next 5/5] net: systemport: Add software counters to track reallocations

When inserting the TSB, keep track of how many times we had to do it and if there was a failure in doing so, this helps profile the driver for possibly incorrect headroom settings. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/bcmsysport.c | 5 + drivers/net/ethernet/broa

[PATCH net-next 3/5] net: systemport: Turn on offloads by default

We can turn on the RX/TX checksum offloads by default and make sure that those are properly reflected back to e.g: stacked devices such as VLAN or DSA. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/bcmsysport.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) dif

[PATCH net-next 0/5] net: systemport: Turn on offloads by

Hi David, Up until now, we had added all the code necessary to turn on RX/TX checksum offloads at runtime, but there is no reason why they have to be disabled by default given that this gives a slight performance improvement. Florian Fainelli (5): net: systemport: Refactor bcm_sysport_set_featu

Re: [PATCH net-next v6 23/23] net: WireGuard secure network tunnel

Hi Andrew, Thanks for following up with this. On Thu, Sep 27, 2018 at 3:15 AM Andrew Lunn wrote: > I know you have been concentrating on the crypto code, so i'm not > expecting too many changes at the moment in the network code. I should be addressing things in parallel, actually, so I'm happy

Re: KMSAN: uninit-value in __dev_mc_add

On Thu, Sep 27, 2018 at 2:30 PM Vladis Dronov wrote: > > Hello, > > This report is actually for the same bug which was reported in: > > https://syzkaller.appspot.com/bug?id=088efeac32fdde781038a777a63e436c0d4d7036 > > The note there that the bug was fixed by "Commits: net: fix uninit-value in > __

Re: [Patch net-next] net_sched: fix an extack message in tcf_block_find()

On 09/27/2018 02:36 PM, Cong Wang wrote: > I don't understand what you mean by changing ip command, you must > mean tc command, but still, I have no idea about how restarting failed > syscall could be related to my patch and why we need to restart anything > here. If the refcnt goes to 0, it wi

[PATCH bpf-next] bpf: permit CGROUP_DEVICE programs accessing helper bpf_get_current_cgroup_id()

Currently, helper bpf_get_current_cgroup_id() is not permitted for CGROUP_DEVICE type of programs. If the helper is used in such cases, the verifier will log the following error: 0: (bf) r6 = r1 1: (69) r7 = *(u16 *)(r6 +0) 2: (85) call bpf_get_current_cgroup_id#80 unknown func bpf_get_cur

Re: [Patch net-next] net_sched: fix an extack message in tcf_block_find()

On Thu, Sep 27, 2018 at 2:16 PM Eric Dumazet wrote: > > > > On 09/27/2018 01:42 PM, Cong Wang wrote: > > It is clearly a copy-n-paste. > > > > Signed-off-by: Cong Wang > > --- > > net/sched/cls_api.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/net/sched/cls_api

Re: [PATCH net-next v6 00/23] WireGuard: Secure Network Tunnel

Hi Eric, On Thu, Sep 27, 2018 at 8:29 PM Eric Biggers wrote: > Why is Herbert Xu's existing crypto tree being circumvented, especially for > future patches (the initial merge isn't quite as important as that's a > one-time > event)? I like being able to check out cryptodev to test upcoming cryp

Re: KMSAN: uninit-value in __dev_mc_add

Hello, This report is actually for the same bug which was reported in: https://syzkaller.appspot.com/bug?id=088efeac32fdde781038a777a63e436c0d4d7036 The note there that the bug was fixed by "Commits: net: fix uninit-value in __hw_addr_add_ex()" is wrong. A C-reproducer from the 2nd syzkaller rep

Re: [Patch net-next] net_sched: fix an extack message in tcf_block_find()

On 09/27/2018 01:42 PM, Cong Wang wrote: > It is clearly a copy-n-paste. > > Signed-off-by: Cong Wang > --- > net/sched/cls_api.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c > index 3de47e99b788..8dd7f8af6d54 100644 > ---

Re: [PATCH v3 bpf-next 00/10] bpf: per-cpu cgroup local storage

On 09/26/2018 01:33 PM, Roman Gushchin wrote: > This patchset implements per-cpu cgroup local storage and provides > an example how per-cpu and shared cgroup local storage can be used > for efficient accounting of network traffic. > > v3->v2: > 1) incorporated Song's feedback > 2) rebased on t

[PATCH net] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

The new command (NCSI_CMD_SEND_CMD) is added to allow user space application to send NC-SI command to the network card. Also, add a new attribute (NCSI_ATTR_DATA) for transferring request and response. The work flow is as below. Request: User space application -> Netlink interface (msg)

Re: [PATCH v3] PCI: Reprogram bridge prefetch registers on resume

[+cc LKML] On Tue, Sep 18, 2018 at 04:32:44PM -0500, Bjorn Helgaas wrote: > On Thu, Sep 13, 2018 at 11:37:45AM +0800, Daniel Drake wrote: > > On 38+ Intel-based Asus products, the nvidia GPU becomes unusable > > after S3 suspend/resume. The affected products include multiple > > generations of nvi

Re: [PATCH] netfilter: check if the socket netns is correct.

Hi Flavio, On Wed, Jun 27, 2018 at 10:34:25AM -0300, Flavio Leitner wrote: > Netfilter assumes that if the socket is present in the skb, then > it can be used because that reference is cleaned up while the skb > is crossing netns. > > We want to change that to preserve the socket reference in a f

[Patch net-next] net_sched: fix a crash in tc_new_tfilter()

When tcf_block_find() fails, it already rollbacks the qdisc refcnt, so its caller doesn't need to clean up this again. Avoid calling qdisc_put() again by resetting qdisc to NULL for callers. Reported-by: syzbot+37b8770e6d5a8220a...@syzkaller.appspotmail.com Fixes: e368fdb61d8e ("net: sched: use Qd

[Patch net-next] net_sched: fix an extack message in tcf_block_find()

It is clearly a copy-n-paste. Signed-off-by: Cong Wang --- net/sched/cls_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c index 3de47e99b788..8dd7f8af6d54 100644 --- a/net/sched/cls_api.c +++ b/net/sched/cls_api.c @@ -655,7 +655,

Re: [PATCH v2 07/22] soc/fsl/bman_portals: defer probe after bman's probe

On Wed, Sep 26, 2018 at 8:26 AM wrote: > > From: Laurentiu Tudor > > A crash in bman portal probing could not be triggered (as is the case > with qman portals) but it does make calls [1] into the bman driver so > lets make sure the bman portal probing happens after bman's. > > [1] bman_p_irqsour

Re: [PATCH v2 06/22] soc/fsl/qman_portals: defer probe after qman's probe

On Wed, Sep 26, 2018 at 8:26 AM wrote: > > From: Laurentiu Tudor > > Defer probe of qman portals after qman probing. This fixes the crash > below, seen on NXP LS1043A SoCs: > > Unable to handle kernel NULL pointer dereference at virtual address > 0004 > Mem abort info: > ESR = 0x960

Re: [PATCH v2 05/22] soc/fsl/qbman: add APIs to retrieve the probing status

On Wed, Sep 26, 2018 at 8:26 AM wrote: > > From: Laurentiu Tudor > > Add a couple of new APIs to check the probing status of qman and bman: > 'int bman_is_probed()' and 'int qman_is_probed()'. > They return the following values. > * 1 if qman/bman were probed correctly > * 0 if qman/bman wer

Re: [PATCH net-next 0/7] rtnetlink: add RTM_GETADDR2

On September 27, 2018 10:24:36 PM GMT+02:00, David Ahern wrote: >On 9/27/18 11:58 AM, Christian Brauner wrote: >> Various userspace programs (e.g. iproute2) have sent RTM_GETADDR >> requests with struct ifinfomsg. This is wrong and should have been >> struct ifaddrmsg all along as mandated by the

Re: [PATCH net-next 0/7] rtnetlink: add RTM_GETADDR2

On 9/27/18 11:58 AM, Christian Brauner wrote: > Various userspace programs (e.g. iproute2) have sent RTM_GETADDR > requests with struct ifinfomsg. This is wrong and should have been > struct ifaddrmsg all along as mandated by the manpages. However, dump > requests so far didn't parse the netlink me

RE: bug: 'ethtool -m' reports spurious alarm & warning threshold values for QSFP28 transceivers

Update for posterity- Mellanox support provided a work-around of using mlxcables instead of ethtool to read alarm/warning info for an installed transceiver. I was told that a couple of their engineers are currently looking into the discrepancy between threshold reporting by mlxcables and ethtool,

Re: [PATCH v2 08/22] soc/fsl/qbman_portals: add APIs to retrieve the probing status

On Wed, Sep 26, 2018 at 8:26 AM wrote: > > From: Laurentiu Tudor > > Add a couple of new APIs to check the probing status of the required > cpu bound qman and bman portals: > 'int bman_portals_probed()' and 'int qman_portals_probed()'. > They return the following values. > * 1 if qman/bman por

[PATCH net-next] net: nixge: Address compiler warnings when building for i386

Address compiler warning reported by kbuild autobuilders when building for i386 as a result of dma_addr_t size on different architectures. warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] Fixes: 7e8d5755be0e ("net: nixge: Add support for 64-bit platforms") S

Re: [PATCH v2 net-next 2/2] dt-bindings: net: add support for Microchip KSZ9131 Ethernet PHY

On Thu, Sep 27, 2018 at 04:16:55PM -0400, Yuiko Oshino wrote: > Add support for Microchip Technology KSZ9131 10/100/1000 Ethernet PHY > > Signed-off-by: Yuiko Oshino > --- > .../devicetree/bindings/net/micrel-ksz90x1.txt | 29 > +- > 1 file changed, 28 insertions(+), 1 d

Re: [PATCH net-next] tcp: up initial rmem to 128KB and SYN rwin to around 64KB

On Thu, Sep 27, 2018 at 11:21 AM, Yuchung Cheng wrote: > Previously TCP initial receive buffer is ~87KB by default and > the initial receive window is ~29KB (20 MSS). This patch changes > the two numbers to 128KB and ~64KB (rounding down to the multiples > of MSS) respectively. The patch also simp

Re: kernel 4.18.5 Realtek 8111G network adapter stops responding under high system load

Hi, Heiner Kallweit's patch seems to resolve the problem. The machine was under high disk and network io pressure today and networking was perfectly stable. Bye, David Arendt On 9/25/18 11:03 PM, Heiner Kallweit wrote: > On 19.09.2018 06:12, David Arendt wrote: >> Hi, >> >> Thanks for the patch.

  1   2   3   >