Re: [PATCH net] bnxt_en: don't try to offload VLAN 'modify' action

2018-09-19 Thread Sathya Perla
On Wed, Sep 19, 2018 at 10:31 PM Davide Caratti wrote: > > bnxt offload code currently supports only 'push' and 'pop' operation: let > .ndo_setup_tc() return -EOPNOTSUPP if VLAN 'modify' action is configured. > > Fixes: 2ae7408fedfe ("bnxt_en: bnxt: add TC flower filter offload support") > Signed-

[PATCH net] mlxsw: spectrum: Bump required firmware version

2018-09-19 Thread Ido Schimmel
From: Petr Machata MC-aware mode was introduced to mlxsw in commit 7b8195306694 ("mlxsw: spectrum: Configure MC-aware mode on mlxsw ports") and fixed up later in commit 3a3539cd3632 ("mlxsw: spectrum_buffers: Set up a dedicated pool for BUM traffic"). As the final piece of puzzle, a firmware issu

[PATCH net-next 00/13] mlxsw: Further MC-awareness configuration

2018-09-19 Thread Ido Schimmel
Petr says: Due to an issue in Spectrum chips, when unicast traffic shares the same queue as BUM traffic, and there is congestion, the BUM traffic is admitted to the queue anyway, thus pushing out all UC traffic. In order to give unicast traffic precedence over BUM traffic, multicast-aware mode is

[PATCH net-next 10/13] mlxsw: spectrum_buffers: Tweak SBMM configuration

2018-09-19 Thread Ido Schimmel
From: Petr Machata The SBMM register configures shared buffer allocation and settings for MC packets according to switch priority. The recommended values are no reserved buffer and alpha of 1/4, which corresponds to buf_max of 6. Update mlxsw_sp_sb_mms accordingly. Signed-off-by: Petr Machata R

[PATCH net-next 09/13] mlxsw: spectrum_buffers: Configure MC pool

2018-09-19 Thread Ido Schimmel
From: Petr Machata Pool 15 (indexed as 8) is dedicated to MC traffic. Its configuration has been kept at default, because the table-based configuration wasn't expressive enough to allow the explicit configuration. Now that the configuration of pool 15 can be described, do so. The MC pool should

[PATCH net-next 06/13] mlxsw: spectrum_buffers: Allow an infinite maximum for per-TC pool limit

2018-09-19 Thread Ido Schimmel
From: Petr Machata The SBCM register configures the shared buffer configuration according to port and TC. So far all pools have had a dynamic size, where the infinite size is easy to express by using max_buff of 0xff. However the MC pool should be configured with static size, and the infinite siz

[PATCH net-next 12/13] selftests: forwarding: lib: Add mtu_set(), mtu_restore()

2018-09-19 Thread Ido Schimmel
From: Petr Machata Some selftests need to tweak MTU of an interface, and naturally should at teardown restore the MTU back to the original value. Add two functions to facilitate this MTU handling: mtu_set() to change MTU value, and mtu_reset() to change it back to what it was before. Signed-off-

[PATCH net-next 08/13] mlxsw: spectrum_buffers: Allow configuration of static pools

2018-09-19 Thread Ido Schimmel
From: Petr Machata Some pools configured through the sb_pm entries may have by default static size. The MC pool is now not explicitly configured, however it gets configured as static implicitly by 0-initializing sb->prs, and a follow-up patch adds an explicit configuration to the same effect. To

[PATCH net-next 03/13] mlxsw: spectrum_buffers: Split TC_COUNT into ingress and egress

2018-09-19 Thread Ido Schimmel
From: Petr Machata Current code assumes that ingress and egress has the same number of traffic classes. Since the introduction of MC-aware mode that assumption hasn't held anymore, and there have been 16 TCs on the egress as opposed to 8 on ingress. Break the assumption of symmetry by splitting

[PATCH net-next 11/13] selftests: forwarding: lib: Add ethtool_stats_get()

2018-09-19 Thread Ido Schimmel
From: Petr Machata Add a new service function to obtain ethtool counters. Signed-off-by: Petr Machata Reviewed-by: Jiri Pirko Signed-off-by: Ido Schimmel --- tools/testing/selftests/net/forwarding/lib.sh | 8 1 file changed, 8 insertions(+) diff --git a/tools/testing/selftests/net/

[PATCH net-next 13/13] selftests: mlxsw: Add a test for UC behavior under MC flood

2018-09-19 Thread Ido Schimmel
From: Petr Machata A so-called "MC-aware" mode has recently been enabled in mlxsw. In MC-aware mode, BUM traffic is handled in a special way so that when a switch is flooded with BUM, UC performance isn't unduly impacted. Without enablement of this mode, a stream of BUM traffic can cause sustaine

[PATCH net-next 05/13] mlxsw: spectrum_buffers: Allow pools of infinite size

2018-09-19 Thread Ido Schimmel
From: Petr Machata The MC pool should have an infinite size (i.e. no quota). To that end, add infi_size to the SBPR register and extend mlxsw_reg_sbpr_pack(). Also add MLXSW_SP_SB_INFI to denote buffers that should have an infinite size. Change mlxsw_sp_sb_pr_write() to take as parameter byte s

[PATCH net-next 04/13] mlxsw: spectrum_buffers: Keep shared buffer size in mlxsw_sp_sb

2018-09-19 Thread Ido Schimmel
From: Petr Machata Entities of infinite size will be reported as if they had the maximum size allowed by the chip. To that end, keep track of maximum shared buffer size in mlxsw_sp->sb. Signed-off-by: Petr Machata Reviewed-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/m

[PATCH net-next 02/13] mlxsw: spectrum_buffers: Use devlink pool indices throughout

2018-09-19 Thread Ido Schimmel
From: Petr Machata Currently, mlxsw assumes that each ingress pool has its egress counterpart, and that pool index for purposes of caching matches the index with which the hardware should be configured. As we want to expose the MC pool, both of these assumptions break. Instead, maintain the pool

[PATCH net-next 01/13] mlxsw: spectrum: Init shaper for TCs 8..15

2018-09-19 Thread Ido Schimmel
From: Petr Machata With introduction of MC-aware mode to mlxsw, it became necessary to configure TCs above 7 as well. There is now code in mlxsw to disable ETS for these higher classes, but disablement of max shaper was neglected. By default, max shaper is currently disabled to begin with, so th

[PATCH net-next 07/13] mlxsw: spectrum_buffers: Pass SBPM min_size in cells

2018-09-19 Thread Ido Schimmel
From: Petr Machata The SBPM register configures the shared buffer allocation and configuration per port and pool. The min_buff value is the buffer size dedicated to this single function, and is configured in cells. Currently, all sb_pm entries have 0 for min_buff, and therefore the actual unit is

Re: [PATCH net 0/3] qed: Fix series for multi-function mode implementation.

2018-09-19 Thread David Miller
From: Sudarsana Reddy Kalluru Date: Wed, 19 Sep 2018 21:59:09 -0700 > From: Sudarsana Reddy Kalluru > > The patch series addresses few issues in the switch dependent multi-function > modes. > Please consider applying it to 'net' tree. Series applied, thank you.

Re: [PATCH] net: toshiba: remove a redundant local variable 'index_specified'

2018-09-19 Thread David Miller
From: zhong jiang Date: Thu, 20 Sep 2018 09:56:05 +0800 > The local variable 'index_specified' is never used after being assigned. > hence it should be redundant adn can be removed. > > Signed-off-by: zhong jiang Applied.

Re: [PATCH net-next] atl1: remove set but not used variable 'advertising'

2018-09-19 Thread David Miller
From: YueHaibing Date: Thu, 20 Sep 2018 02:41:30 + > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/atheros/atlx/atl1.c: In function > 'atl1_set_link_ksettings': > drivers/net/ethernet/atheros/atlx/atl1.c:3280:6: warning: > variable 'advertising' set but not used [

Re: [PATCH net-next] nfp: provide a better warning when ring allocation fails

2018-09-19 Thread David Miller
From: Jakub Kicinski Date: Wed, 19 Sep 2018 14:42:50 -0700 > NFP supports fairly enormous ring sizes (up to 256k descriptors). > In commit 466271703867 ("nfp: use kvcalloc() to allocate SW buffer > descriptor arrays") we have started using kvcalloc() functions to > make sure the allocation of sof

Re: [PATCH net-next] e1000: remove set but not used variable 'txb2b'

2018-09-19 Thread David Miller
From: YueHaibing Date: Thu, 20 Sep 2018 02:04:38 + > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/intel/e1000/e1000_main.c: In function 'e1000_watchdog': > drivers/net/ethernet/intel/e1000/e1000_main.c:2436:9: warning: > variable 'txb2b' set but not used [-Wunused

Re: [PATCH net-next 2/2] r8169: remove duplicated RTL8169s PHY initialization steps

2018-09-19 Thread David Miller
From: Heiner Kallweit Date: Wed, 19 Sep 2018 22:02:11 +0200 > Setting register 0x82 to value 01 is done a few lines before for all > chip versions <= 06 anyway. And setting PHY register 0x0b to value 00 > is done at the end of rtl8169s_hw_phy_config() already. So we can > remove this. > > Signed

Re: [PATCH net-next 1/2] r8169: simplify RTL8169 PHY initialization

2018-09-19 Thread David Miller
From: Heiner Kallweit Date: Wed, 19 Sep 2018 22:00:24 +0200 > PCI_LATENCY_TIMER is ignored on PCIe, therefore we have to do this > for the PCI chips (version <= 06) only. Also we can move setting > PCI_CACHE_LINE_SIZE. > > Signed-off-by: Heiner Kallweit Applied.

Re: [PATCH net] mpls: allow routes on ip6gre devices

2018-09-19 Thread David Miller
From: Saif Hasan Date: Wed, 19 Sep 2018 12:59:24 -0700 > @@ -1533,10 +1533,11 @@ static int mpls_dev_notify(struct > notifier_block *this, unsigned long event, > unsigned int flags; > > if (event == NETDEV_REGISTER) { > - /* For now just support Ethernet, IPGRE, SIT

Re: [PATCH bpf-next 2/3] bpf: emit RECORD_MMAP events for bpf prog load/unload

2018-09-19 Thread Song Liu
> On Sep 19, 2018, at 5:59 PM, Alexei Starovoitov wrote: > > On 9/19/18 4:44 PM, Song Liu wrote: >> >> >>> On Sep 19, 2018, at 3:39 PM, Alexei Starovoitov wrote: >>> >>> use perf_event_mmap_bpf_prog() helper to notify user space >>> about JITed bpf programs. >>> Use RECORD_MMAP perf event

Re: [RFC bpf-next 4/4] tools/bpf: handle EOPNOTSUPP when map lookup is failed

2018-09-19 Thread Prashant Bhole
On 9/20/2018 12:29 AM, Jakub Kicinski wrote: On Wed, 19 Sep 2018 16:51:43 +0900, Prashant Bhole wrote: Let's add a check for EOPNOTSUPP error when map lookup is failed. Also in case map doesn't support lookup, the output of map dump is changed from "can't lookup element" to "lookup not suppor

Re: [PATCH rdma-next 00/24] Extend DEVX functionality

2018-09-19 Thread Leon Romanovsky
On Wed, Sep 19, 2018 at 12:17:01PM -0600, Jason Gunthorpe wrote: > On Mon, Sep 17, 2018 at 02:03:53PM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > From Yishai, > > > > This series comes to enable the DEVX functionality in some wider scope, > > specifically, > > - It enables usin

[PATCH net 2/3] qed: Do not add VLAN 0 tag to untagged frames in multi-function mode.

2018-09-19 Thread Sudarsana Reddy Kalluru
In certain multi-function switch dependent modes, firmware adds vlan tag 0 to the untagged frames. This leads to double tagging for the traffic if the dcbx is enabled, which is not the desired behavior. To avoid this, driver needs to set "dcb_dont_add_vlan0" flag. Fixes: cac6f691 ("qed: Add suppor

[PATCH net 0/3] qed: Fix series for multi-function mode implementation.

2018-09-19 Thread Sudarsana Reddy Kalluru
From: Sudarsana Reddy Kalluru The patch series addresses few issues in the switch dependent multi-function modes. Please consider applying it to 'net' tree. Sudarsana Reddy Kalluru (3): qed: Fix populating the invalid stag value in multi function mode. qed: Do not add VLAN 0 tag to untagged

[PATCH net 3/3] qed: Add missing device config for RoCE EDPM in UFP mode.

2018-09-19 Thread Sudarsana Reddy Kalluru
This patch adds support to configure the DORQ to use vlan-id/priority for roce EDPM. Fixes: cac6f691 ("qed: Add support for Unified Fabric Port") Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Tomer Tayar --- drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 40 ++

[PATCH net 1/3] qed: Fix populating the invalid stag value in multi function mode.

2018-09-19 Thread Sudarsana Reddy Kalluru
In multi-function mode, driver receives the stag value (outer vlan) for a PF from management FW (MFW). If the stag value is negotiated prior to the driver load, then the stag is not notified to the driver and hence driver will have the invalid stag value. The fix is to request the MFW for STAG valu

Re: [PATCH mlx5-next 02/25] net/mlx5: Set uid as part of QP commands

2018-09-19 Thread Leon Romanovsky
On Wed, Sep 19, 2018 at 11:27:31AM -0600, Jason Gunthorpe wrote: > On Mon, Sep 17, 2018 at 02:03:55PM +0300, Leon Romanovsky wrote: > > From: Yishai Hadas > > > > Set uid as part of QP commands so that the firmware can manage the > > QP object in a secured way. > > > > That will enable using a QP

Re: [PATCH mlx5-next 07/25] net/mlx5: Update mlx5_ifc with DEVX UID bits

2018-09-19 Thread Leon Romanovsky
On Wed, Sep 19, 2018 at 11:31:47AM -0600, Jason Gunthorpe wrote: > On Mon, Sep 17, 2018 at 02:04:00PM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Add DEVX information to WQ, SRQ, CQ, TRI, TIS, QP, > > RQ, XRCD, PD, MKEY and MCG. > > > > Signed-off-by: Leon Romanovsky > > --- >

Re: [PATCH bpf-next 2/2] xsk: fix bug when trying to use both copy and zero-copy on one queue id

2018-09-19 Thread Y Song
On Wed, Sep 19, 2018 at 12:15 AM Magnus Karlsson wrote: > > On Tue, Sep 18, 2018 at 7:23 PM Y Song wrote: > > > > On Tue, Sep 18, 2018 at 3:13 AM Magnus Karlsson > > wrote: > > > > > > Previously, the xsk code did not record which umem was bound to a > > > specific queue id. This was not require

Re: [PATCH net-next v3 1/2] netlink: ipv4 igmp join notifications

2018-09-19 Thread David Ahern
On 9/18/18 6:12 AM, Patrick Ruddy wrote: > > I've hit a small snag with adding the new groups. The number of defined > groups currently sits at 31 so I can only add one before hitting the I believe you have no more available. RTNLGRP_* has been defined from 0 (RTNLGRP_NONE) to 31 (RTNLGRP_IPV6_MR

Re: [PATCH RFT net-next 0/2] net: phy: Eliminate unnecessary soft

2018-09-19 Thread Chris Healy
> This patch series eliminates unnecessary software resets of the PHY. > This should hopefully not break anybody's hardware; but I would > appreciate testing to make sure this is is the case. Tested-by: Chris Healy Tested with Marvell 88E6161 and Marvell 88E6352 switches (which use Marvell PHY d

Re: [PATCH net] ip6_tunnel: be careful when accessing the inner header

2018-09-19 Thread David Miller
From: Paolo Abeni Date: Wed, 19 Sep 2018 15:02:07 +0200 > the ip6 tunnel xmit ndo assumes that the processed skb always > contains an ip[v6] header, but syzbot has found a way to send > frames that fall short of this assumption, leading to the following splat: ... > This change addresses the iss

Re: [PATCH net] net: mvneta: fix the Rx desc buffer DMA unmapping

2018-09-19 Thread David Miller
From: Antoine Tenart Date: Wed, 19 Sep 2018 15:29:06 +0200 > With CONFIG_DMA_API_DEBUG enabled we now get a warning when using the > mvneta driver: > > mvneta d003.ethernet: DMA-API: device driver frees DMA memory with > wrong function [device address=0x1165b000] [size=4096 bytes

Re: [PATCH net-next] ipv6: Allow the l3mdev to be a loopback

2018-09-19 Thread David Miller
From: David Ahern Date: Wed, 19 Sep 2018 10:19:05 -0700 > On 9/19/18 5:56 AM, Mike Manning wrote: >> From: Robert Shearman >> >> There is no way currently for an IPv6 client connect using a loopback >> address in a VRF, whereas for IPv4 the loopback address can be added: >> >> $ sudo ip ad

Re: [PATCH net-next 0/2] net: phy: make phy_stop() synchronous

2018-09-19 Thread David Miller
From: Heiner Kallweit Date: Tue, 18 Sep 2018 21:54:23 +0200 > There have been few not that successful attempts in the past to make > phy_stop() a synchronous call instead of just changing the state. > Patch 1 of this series addresses an issue which prevented this change. > At least for me it work

Re: [RFC bpf-next 4/4] tools/bpf: handle EOPNOTSUPP when map lookup is failed

2018-09-19 Thread Prashant Bhole
On 9/20/2018 12:29 AM, Jakub Kicinski wrote: On Wed, 19 Sep 2018 16:51:43 +0900, Prashant Bhole wrote: Let's add a check for EOPNOTSUPP error when map lookup is failed. Also in case map doesn't support lookup, the output of map dump is changed from "can't lookup element" to "lookup not suppor

Re: [RFC bpf-next 3/4] tools/bpf: bpftool, split the function do_dump()

2018-09-19 Thread Prashant Bhole
On 9/20/2018 12:26 AM, Jakub Kicinski wrote: On Wed, 19 Sep 2018 16:51:42 +0900, Prashant Bhole wrote: +static int dump_map_elem(int fd, void *key, void *value, +struct bpf_map_info *map_info, struct btf *btf, +json_writer_t *btf_wtr) +{ +

Re: [RFC bpf-next 2/4] bpf: return EOPNOTSUPP when map lookup isn't supported

2018-09-19 Thread Prashant Bhole
On 9/20/2018 12:14 AM, Alexei Starovoitov wrote: On Wed, Sep 19, 2018 at 04:51:41PM +0900, Prashant Bhole wrote: Return ERR_PTR(-EOPNOTSUPP) from map_lookup_elem() methods of below map types: - BPF_MAP_TYPE_PROG_ARRAY - BPF_MAP_TYPE_STACK_TRACE - BPF_MAP_TYPE_XSKMAP - BPF_MAP_TYPE_SOCKMAP/BPF

Re: [RFC bpf-next 2/4] bpf: return EOPNOTSUPP when map lookup isn't supported

2018-09-19 Thread Prashant Bhole
On 9/20/2018 3:40 AM, Mauricio Vasquez wrote: On 09/19/2018 10:14 AM, Alexei Starovoitov wrote: On Wed, Sep 19, 2018 at 04:51:41PM +0900, Prashant Bhole wrote: Return ERR_PTR(-EOPNOTSUPP) from map_lookup_elem() methods of below map types: - BPF_MAP_TYPE_PROG_ARRAY - BPF_MAP_TYPE_STACK_TRAC

Re: [PATCH v2 2/4] dt-bindings: net: qcom: Add binding for shared mdio bus

2018-09-19 Thread Wang, Dongsheng
On 2018/9/19 22:15, Timur Tabi wrote: > On 9/19/18 7:25 AM, Andrew Lunn wrote: >> ACPI is completely separate and should not affect the DT binding. >> I've not yet looked at the ACPI changes you added. > Just FYI, there is no device tree platform on which the upstream EMAC > driver works. All of

Re: [PATCH bpf-next 2/3] bpf: emit RECORD_MMAP events for bpf prog load/unload

2018-09-19 Thread Alexei Starovoitov
On 9/19/18 4:44 PM, Song Liu wrote: On Sep 19, 2018, at 3:39 PM, Alexei Starovoitov wrote: use perf_event_mmap_bpf_prog() helper to notify user space about JITed bpf programs. Use RECORD_MMAP perf event to tell user space where JITed bpf program was loaded. Use empty program name as unload

Re: [PATCH bpf-next 1/3] perf/core: introduce perf_event_mmap_bpf_prog

2018-09-19 Thread Alexei Starovoitov
On 9/19/18 4:30 PM, Song Liu wrote: > > >> On Sep 19, 2018, at 3:39 PM, Alexei Starovoitov wrote: >> >> introduce perf_event_mmap_bpf_prog() helper to emit RECORD_MMAP events >> into perf ring buffer. >> It's used by bpf load/unload logic to notify user space of addresses >> and names of JITed bpf

[PATCH net] af_key: free SKBs under RCU protection

2018-09-19 Thread Sean Tranchetti
pfkey_broadcast() can make calls to pfkey_broadcast_one() which will clone or copy the passed in SKB. This new SKB will be assigned the sock_rfree() function as its destructor, which requires that the socket reference the SKB contains is valid when the SKB is freed. If this SKB is ever passed to p

Re: [PATCH] net: phy: don't reschedule state machine when PHY is halted

2018-09-19 Thread Florian Fainelli
On 09/18/2018 01:17 PM, Heiner Kallweit wrote: > On 18.09.2018 22:02, Florian Fainelli wrote: >> On 09/18/2018 12:12 PM, Heiner Kallweit wrote: >>> I think I've seen a similar or same patch before, not sure why it >>> didn't make it yet. When being in state PHY_HALTED we don't have to >>> reschedul

Re: [PATCH net-next 2/2] net: phy: call state machine synchronously in phy_stop

2018-09-19 Thread Florian Fainelli
On 09/18/2018 12:56 PM, Heiner Kallweit wrote: > phy_stop() may be called e.g. when suspending, therefore all needed > actions should be performed synchronously. Therefore add a synchronous > call to the state machine. > > Signed-off-by: Heiner Kallweit Reviewed-by: Florian Fainelli Yes! -- F

Re: [PATCH net-next 1/2] net: linkwatch: add check for netdevice being present to linkwatch_do_dev

2018-09-19 Thread Florian Fainelli
On 09/18/2018 12:55 PM, Heiner Kallweit wrote: > When bringing down the netdevice (incl. detaching it) and calling > netif_carrier_off directly or indirectly the latter triggers an > asynchronous linkwatch event. > This linkwatch event eventually may fail to access chip registers in > the ndo_get_s

Re: [PATCH bpf-next 2/3] bpf: emit RECORD_MMAP events for bpf prog load/unload

2018-09-19 Thread Song Liu
> On Sep 19, 2018, at 3:39 PM, Alexei Starovoitov wrote: > > use perf_event_mmap_bpf_prog() helper to notify user space > about JITed bpf programs. > Use RECORD_MMAP perf event to tell user space where JITed bpf program was > loaded. > Use empty program name as unload indication. > > Signed-

[Patch net-next v3] net_sched: change tcf_del_walker() to take idrinfo->lock

2018-09-19 Thread Cong Wang
From: Vlad Buslov From: Vlad Buslov Action API was changed to work with actions and action_idr in concurrency safe manner, however tcf_del_walker() still uses actions without taking a reference or idrinfo->lock first, and deletes them directly, disregarding possible concurrent delete. Change t

[PATCH iproute2 v2 0/3] testsuite: make alltests fixes

2018-09-19 Thread Petr Vorel
Hi, here are simply fixes to restore 'make alltests'. Currently it does not run. Kind regards, Petr Petr Vorel (3): testsuite: Fix missing generate_nlmsg testsuite: Generate generate_nlmsg when needed testsuite: Warn about empty $(IPVERS) testsuite/Makefile | 21 ++--- 1

[PATCH iproute2 v2 3/3] testsuite: Warn about empty $(IPVERS)

2018-09-19 Thread Petr Vorel
alltests target requires having symlink created by configure target (default target). Without that there is no test being run. Signed-off-by: Petr Vorel --- testsuite/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/testsuite/Makefile b/testsuite/Makefile index 1c2467f5..b3aebec1

[PATCH iproute2 v2 2/3] testsuite: Generate generate_nlmsg when needed

2018-09-19 Thread Petr Vorel
Commit 886f2c43 added generate_nlmsg.c. Running alltests target, which uses the binary required to run 'make -C tools' before. Fixes: 886f2c43 testsuite: Generate nlmsg blob at runtime Signed-off-by: Petr Vorel --- testsuite/Makefile | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-)

[PATCH iproute2 v2 1/3] testsuite: Fix missing generate_nlmsg

2018-09-19 Thread Petr Vorel
Commit ad23e152 caused generate_nlmsg to be always missing: $ make alltests make: ./tools/generate_nlmsg: Command not found Create testclean: to remove only results directory. Fixes: ad23e152 testsuite: remove all temp files and implement make clean Signed-off-by: Petr Vorel --- testsuite/Mak

Re: [PATCH bpf-next 1/3] perf/core: introduce perf_event_mmap_bpf_prog

2018-09-19 Thread Song Liu
> On Sep 19, 2018, at 3:39 PM, Alexei Starovoitov wrote: > > introduce perf_event_mmap_bpf_prog() helper to emit RECORD_MMAP events > into perf ring buffer. > It's used by bpf load/unload logic to notify user space of addresses > and names of JITed bpf programs. > > Note that event->mmap.pid

[PATCH perf 3/3] tools/perf: recognize and process RECORD_MMAP events for bpf progs

2018-09-19 Thread Alexei Starovoitov
Recognize JITed bpf prog load/unload events. Add/remove kernel symbols accordingly. Signed-off-by: Alexei Starovoitov --- tools/perf/util/machine.c | 27 +++ tools/perf/util/symbol.c | 13 + tools/perf/util/symbol.h | 1 + 3 files changed, 41 insertions(+)

[PATCH bpf-next 2/3] bpf: emit RECORD_MMAP events for bpf prog load/unload

2018-09-19 Thread Alexei Starovoitov
use perf_event_mmap_bpf_prog() helper to notify user space about JITed bpf programs. Use RECORD_MMAP perf event to tell user space where JITed bpf program was loaded. Use empty program name as unload indication. Signed-off-by: Alexei Starovoitov --- kernel/bpf/core.c | 22 --

[PATCH bpf-next 0/3] perf, bpf: reveal invisible bpf programs

2018-09-19 Thread Alexei Starovoitov
Hi All, this patch set adds kernel and user space support to reveal short lived bpf programs. The kernel stores addr+bpf_prog_name information into perf ring buffer. Later 'perf report' can properly attribute the cpu time to the program. The following command was run before and after: 'perf recor

[PATCH bpf-next 1/3] perf/core: introduce perf_event_mmap_bpf_prog

2018-09-19 Thread Alexei Starovoitov
introduce perf_event_mmap_bpf_prog() helper to emit RECORD_MMAP events into perf ring buffer. It's used by bpf load/unload logic to notify user space of addresses and names of JITed bpf programs. Note that event->mmap.pid == -1 is an existing indicator of kernel event. In addition use event->mmap.

Re: [PATCH net-next v2 08/10] net: sched: protect block idr with spinlock

2018-09-19 Thread Cong Wang
On Mon, Sep 17, 2018 at 12:19 AM Vlad Buslov wrote: > @@ -482,16 +483,25 @@ static int tcf_block_insert(struct tcf_block *block, > struct net *net, > struct netlink_ext_ack *extack) > { > struct tcf_net *tn = net_generic(net, tcf_net_id); > + int err; >

Re: [PATCH net-next v2 05/10] net: sched: use Qdisc rcu API instead of relying on rtnl lock

2018-09-19 Thread Cong Wang
On Mon, Sep 17, 2018 at 12:19 AM Vlad Buslov wrote: > +static void tcf_qdisc_put(struct Qdisc *q, bool rtnl_held) > +{ > + if (!q) > + return; > + > + if (rtnl_held) > + qdisc_put(q); > + else > + qdisc_put_unlocked(q); > +} This is very

Re: [PATCH bpf] tools: bpf: fix license for a compat header file

2018-09-19 Thread Daniel Borkmann
On 09/18/2018 07:13 PM, Jakub Kicinski wrote: > libc_compat.h is used by libbpf so make sure it's licensed under > LGPL or BSD license. The license change should be OK, I'm the only > author of the file. > > Signed-off-by: Jakub Kicinski > Reviewed-by: Quentin Monnet Applied to bpf, thanks Jak

Re: [PATCH bpf-next] flow_dissector: fix build failure without CONFIG_NET

2018-09-19 Thread Daniel Borkmann
On 09/18/2018 10:20 PM, Willem de Bruijn wrote: > From: Willem de Bruijn > > If boolean CONFIG_BPF_SYSCALL is enabled, kernel/bpf/syscall.c will > call flow_dissector functions from net/core/flow_dissector.c. > > This causes this build failure if CONFIG_NET is disabled: > > kernel/bpf/sysca

Re: [PATCH net-next v2 01/10] net: core: netlink: add helper refcount dec and lock function

2018-09-19 Thread Cong Wang
On Mon, Sep 17, 2018 at 12:19 AM Vlad Buslov wrote: > --- a/net/core/rtnetlink.c > +++ b/net/core/rtnetlink.c > @@ -130,6 +130,12 @@ int rtnl_is_locked(void) > } > EXPORT_SYMBOL(rtnl_is_locked); > > +bool refcount_dec_and_rtnl_lock(refcount_t *r) > +{ > + return refcount_dec_and_mutex_lock

[PATCH net-next] nfp: provide a better warning when ring allocation fails

2018-09-19 Thread Jakub Kicinski
NFP supports fairly enormous ring sizes (up to 256k descriptors). In commit 466271703867 ("nfp: use kvcalloc() to allocate SW buffer descriptor arrays") we have started using kvcalloc() functions to make sure the allocation of software state arrays doesn't hit the MAX_ORDER limit. Unfortunately, w

Re: [Patch net-next] ipv4: initialize ra_mutex in inet_init_net()

2018-09-19 Thread Cong Wang
On Wed, Sep 19, 2018 at 1:25 AM Kirill Tkhai wrote: > > On 18.09.2018 23:17, Cong Wang wrote: > > On Mon, Sep 17, 2018 at 12:25 AM Kirill Tkhai wrote: > >> In inet_init() the order of registration is: > >> > >> ip_mr_init(); > >> init_inet_pernet_ops(); > >> > >> This means, ipmr_

Re: [RFC 4/5] netlink: prepare validate extack setting for recursion

2018-09-19 Thread Marcelo Ricardo Leitner
On Wed, Sep 19, 2018 at 09:19:31PM +0200, Johannes Berg wrote: > On Wed, 2018-09-19 at 15:46 -0300, Marcelo Ricardo Leitner wrote: > > > > NL_SET_ERR_MSG(extack, "warning: deprecated command"); > > > err = nla_parse(..., extack); > > > if (err) > > > return err; > > > /* do somet

Re: [PATCH mlx5-next 03/25] net/mlx5: Set uid as part of RQ commands

2018-09-19 Thread Jason Gunthorpe
On Wed, Sep 19, 2018 at 11:40:45AM -0700, Saeed Mahameed wrote: > On Wed, Sep 19, 2018 at 10:28 AM Jason Gunthorpe wrote: > > > > On Mon, Sep 17, 2018 at 02:03:56PM +0300, Leon Romanovsky wrote: > > > From: Yishai Hadas > > > > > > Set uid as part of RQ commands so that the firmware can manage th

Re: Bridge connectivity interruptions while devices join or leave the bridge

2018-09-19 Thread Johannes Wienke
On 19.09.18 19:03, Stephen Hemminger wrote: > On Wed, 19 Sep 2018 19:45:08 +0300 > Ido Schimmel wrote: > >> On Wed, Sep 19, 2018 at 01:00:15PM +0200, Johannes Wienke wrote: >>> This behavior of inheriting the mac address is really unexpected to us. >>> Is it documented somewhere? >> >> Not that

[PATCH net] xfrm: validate template mode

2018-09-19 Thread Sean Tranchetti
XFRM mode parameters passed as part of the user templates in the IP_XFRM_POLICY are never properly validated. Passing values other than valid XFRM modes can cause stack-out-of-bounds reads to occur later in the XFRM processing: [ 140.535608] ===

[PATCH net-next 2/2] r8169: remove duplicated RTL8169s PHY initialization steps

2018-09-19 Thread Heiner Kallweit
Setting register 0x82 to value 01 is done a few lines before for all chip versions <= 06 anyway. And setting PHY register 0x0b to value 00 is done at the end of rtl8169s_hw_phy_config() already. So we can remove this. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 9 --

[PATCH net-next 1/2] r8169: simplify RTL8169 PHY initialization

2018-09-19 Thread Heiner Kallweit
PCI_LATENCY_TIMER is ignored on PCIe, therefore we have to do this for the PCI chips (version <= 06) only. Also we can move setting PCI_CACHE_LINE_SIZE. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --gi

[PATCH net] mpls: allow routes on ip6gre devices

2018-09-19 Thread Saif Hasan
>From e4f144286efe0f298c11efe58e17b1ab91c7ee3f Mon Sep 17 00:00:00 2001 From: Saif Hasan Date: Mon, 17 Sep 2018 16:28:54 -0700 Subject: [PATCH] mpls: allow routes on ip6gre devices Summary: This appears to be necessary and sufficient change to enable `MPLS` on `ip6gre` tunnels (RFC4023). This d

[no subject]

2018-09-19 Thread Saif Hasan
>From e4f144286efe0f298c11efe58e17b1ab91c7ee3f Mon Sep 17 00:00:00 2001 From: Saif Hasan Date: Mon, 17 Sep 2018 16:28:54 -0700 Subject: [PATCH] mpls: allow routes on ip6gre devices Summary: This appears to be necessary and sufficient change to enable `MPLS` on `ip6gre` tunnels (RFC4023). This d

Re: [RFC 4/5] netlink: prepare validate extack setting for recursion

2018-09-19 Thread Johannes Berg
On Wed, 2018-09-19 at 15:46 -0300, Marcelo Ricardo Leitner wrote: > > NL_SET_ERR_MSG(extack, "warning: deprecated command"); > > err = nla_parse(..., extack); > > if (err) > > return err; > > /* do something */ > > return 0; > > > > Here you could consider the mess

[PATCH] mpls: allow routes on ip6gre devices

2018-09-19 Thread Saif Hasan
Summary: This appears to be necessary and sufficient change to enable `MPLS` on `ip6gre` tunnels (RFC4023). This diff allows IP6GRE devices to be recognized by MPLS kernel module and hence user can configure interface to accept packets with mpls headers as well setup mpls routes on them. Test Pl

[PATCH] mpls: allow routes on ip6gre devices

2018-09-19 Thread Saif Hhasan
From: Saif Hasan Summary: This appears to be necessary and sufficient change to enable `MPLS` on `ip6gre` tunnels (RFC4023). This diff allows IP6GRE devices to be recognized by MPLS kernel module and hence user can configure interface to accept packets with mpls headers as well setup mpls route

[PATCH] mpls: allow routes on ip6gre devices

2018-09-19 Thread Saif Hasan
Summary: This appears to be necessary and sufficient change to enable `MPLS` on `ip6gre` tunnels (RFC4023). This diff allows IP6GRE devices to be recognized by MPLS kernel module and hence user can configure interface to accept packets with mpls headers as well setup mpls routes on them. Test Pl

Re: [RFC 4/5] netlink: prepare validate extack setting for recursion

2018-09-19 Thread Marcelo Ricardo Leitner
On Wed, Sep 19, 2018 at 11:25:17AM +0200, Johannes Berg wrote: > On Wed, 2018-09-19 at 00:37 -0300, Marcelo Ricardo Leitner wrote: > > > Did you consider indicating the message level, and only overwrite the > > message that is already in there if the new message level is higher > > than the curren

Re: [PATCH mlx5-next 03/25] net/mlx5: Set uid as part of RQ commands

2018-09-19 Thread Saeed Mahameed
On Wed, Sep 19, 2018 at 10:28 AM Jason Gunthorpe wrote: > > On Mon, Sep 17, 2018 at 02:03:56PM +0300, Leon Romanovsky wrote: > > From: Yishai Hadas > > > > Set uid as part of RQ commands so that the firmware can manage the > > RQ object in a secured way. > > > > That will enable using an RQ that

Re: [RFC bpf-next 2/4] bpf: return EOPNOTSUPP when map lookup isn't supported

2018-09-19 Thread Mauricio Vasquez
On 09/19/2018 10:14 AM, Alexei Starovoitov wrote: On Wed, Sep 19, 2018 at 04:51:41PM +0900, Prashant Bhole wrote: Return ERR_PTR(-EOPNOTSUPP) from map_lookup_elem() methods of below map types: - BPF_MAP_TYPE_PROG_ARRAY - BPF_MAP_TYPE_STACK_TRACE - BPF_MAP_TYPE_XSKMAP - BPF_MAP_TYPE_SOCKMAP/BP

Re: kernels > v4.12 oops/crash with ipsec-traffic: bisected to b838d5e1c5b6e57b10ec8af2268824041e3ea911: ipv4: mark DST_NOGC and remove the operation of dst_free()

2018-09-19 Thread Tobias Hommel
> After running for about 24 hours, I now encountered another panic. This time > it > is caused by an out of memory situation. Although the trace shows action in > the > filesystem code I'm posting it here because I cannot isolate the error and > maybe it is caused by our NULL pointer bug or by t

Re: [PATCH rdma-next 00/24] Extend DEVX functionality

2018-09-19 Thread Jason Gunthorpe
On Mon, Sep 17, 2018 at 02:03:53PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > From Yishai, > > This series comes to enable the DEVX functionality in some wider scope, > specifically, > - It enables using kernel objects that were created by the verbs > API in the DEVX flow. > - I

Re: array bounds warning in xfrm_output_resume

2018-09-19 Thread Florian Westphal
David Ahern wrote: > > I believe ef57170bbfdd6 is the commit that introduced the warning > > > > Hi Florian: > > I am still seeing this. I realize the compiler is not understanding the > conditions properly, but it is a distraction every time I do a kernel > build on Debian Stretch having to fi

Re: [PATCH mlx5-next 07/25] net/mlx5: Update mlx5_ifc with DEVX UID bits

2018-09-19 Thread Jason Gunthorpe
On Mon, Sep 17, 2018 at 02:04:00PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Add DEVX information to WQ, SRQ, CQ, TRI, TIS, QP, > RQ, XRCD, PD, MKEY and MCG. > > Signed-off-by: Leon Romanovsky > --- > include/linux/mlx5/mlx5_ifc.h | 67 > +++

[PATCH net-next 11/12] net: hns3: Fix client initialize state issue when roce client initialize failed

2018-09-19 Thread Salil Mehta
From: Jian Shen When roce is loaded before nic, the roce client will not be initialized until nic client is initialized, but roce init flag is set before it. Furthermore, in this case of nic initialized success and roce failed, the nic init flag is not set, and roce init flag is not cleared. Thi

Re: [PATCH mlx5-next 03/25] net/mlx5: Set uid as part of RQ commands

2018-09-19 Thread Jason Gunthorpe
On Mon, Sep 17, 2018 at 02:03:56PM +0300, Leon Romanovsky wrote: > From: Yishai Hadas > > Set uid as part of RQ commands so that the firmware can manage the > RQ object in a secured way. > > That will enable using an RQ that was created by verbs application > to be used by the DEVX flow in case

Re: [PATCH mlx5-next 02/25] net/mlx5: Set uid as part of QP commands

2018-09-19 Thread Jason Gunthorpe
On Mon, Sep 17, 2018 at 02:03:55PM +0300, Leon Romanovsky wrote: > From: Yishai Hadas > > Set uid as part of QP commands so that the firmware can manage the > QP object in a secured way. > > That will enable using a QP that was created by verbs application to > be used by the DEVX flow in case t

Re: [PATCH net-next] ipv6: Allow the l3mdev to be a loopback

2018-09-19 Thread David Ahern
On 9/19/18 5:56 AM, Mike Manning wrote: > From: Robert Shearman > > There is no way currently for an IPv6 client connect using a loopback > address in a VRF, whereas for IPv4 the loopback address can be added: > > $ sudo ip addr add dev vrfred 127.0.0.1/8 > $ sudo ip -6 addr add ::1/128

Re: Bridge connectivity interruptions while devices join or leave the bridge

2018-09-19 Thread Stephen Hemminger
On Wed, 19 Sep 2018 19:45:08 +0300 Ido Schimmel wrote: > On Wed, Sep 19, 2018 at 01:00:15PM +0200, Johannes Wienke wrote: > > This behavior of inheriting the mac address is really unexpected to us. > > Is it documented somewhere? > > Not that I'm aware, but it's a well established behavior. N

[PATCH net] bnxt_en: don't try to offload VLAN 'modify' action

2018-09-19 Thread Davide Caratti
bnxt offload code currently supports only 'push' and 'pop' operation: let .ndo_setup_tc() return -EOPNOTSUPP if VLAN 'modify' action is configured. Fixes: 2ae7408fedfe ("bnxt_en: bnxt: add TC flower filter offload support") Signed-off-by: Davide Caratti --- drivers/net/ethernet/broadcom/bnxt/bnx

Re: array bounds warning in xfrm_output_resume

2018-09-19 Thread David Ahern
On 6/18/18 11:10 AM, David Ahern wrote: > Florian: > > I am seeing this warning: > > $ make O=kbuild/perf -j 24 -s > In file included from /home/dsa/kernel-3.git/include/linux/kernel.h:10:0, > from /home/dsa/kernel-3.git/include/linux/list.h:9, > from /home/dsa/k

Re: Bridge connectivity interruptions while devices join or leave the bridge

2018-09-19 Thread Ido Schimmel
On Wed, Sep 19, 2018 at 01:00:15PM +0200, Johannes Wienke wrote: > This behavior of inheriting the mac address is really unexpected to us. > Is it documented somewhere? Not that I'm aware, but it's a well established behavior.

Re: [PATCH 1/1] macsec: reflect the master interface state

2018-09-19 Thread Radu Rendec
Hello, On Wed, Sep 19, 2018 at 11:24 AM Sabrina Dubroca wrote: > 2018-09-18, 20:16:12 -0400, Radu Rendec wrote: > > This patch makes macsec interfaces reflect the state of the underlying > > interface: if the master interface changes state to up/down, the macsec > > interface changes its state ac

[RFC PATCH ethtool] ethtool: better syntax for combinations of FEC modes

2018-09-19 Thread Edward Cree
Instead of commas, just have them as separate argvs. The parsing state machine might look heavyweight, but it makes it easy to add more parameters later and distinguish parameter names from encoding names. Suggested-by: Michal Kubecek Signed-off-by: Edward Cree --- ethtool.8.in | 6 +++---

Re: [PATCH ethtool] ethtool: support combinations of FEC modes

2018-09-19 Thread Michal Kubecek
On Wed, Sep 19, 2018 at 04:38:27PM +0100, Edward Cree wrote: > On 19/09/18 15:41, Michal Kubecek wrote: > > I'm sorry I didn't notice this before the patch was accepted but as it's > > not in a release yet, maybe it's still not too late. > > > > Could I suggest to make the syntax consistent with ot

Re: [PATCH ethtool] ethtool: support combinations of FEC modes

2018-09-19 Thread Michal Kubecek
On Wed, Sep 19, 2018 at 05:33:38PM +0200, Andrew Lunn wrote: > > One loosely related question: how sure can we be that we are never going > > to need more than 32 bits for FEC encodings? Is it something completely > > hypothetical or is it something that could happen in the future? > > > Hi Michal

  1   2   >