On 9/18/18 6:12 AM, Patrick Ruddy wrote: > > I've hit a small snag with adding the new groups. The number of defined > groups currently sits at 31 so I can only add one before hitting the
I believe you have no more available. RTNLGRP_* has been defined from 0 (RTNLGRP_NONE) to 31 (RTNLGRP_IPV6_MROUTE_R) which covers the u32 range. > limit defined by the 32 bit groups bitmask in socakddr_nl. I can use 1 > group for both v4 and v6 notifications which seems like the sensible > options since the AF is carried separately, but it breaks the precedent > where there are separate IPV4 and IPV6 groups for IFADDR. > > I have the combined group patches ready and can share them if that's > the preference. > > Has there been any previous discussion about extending the number of > availabel groups? > I have not tried it, but from a prior code review I believe you have you use setsockopt to add groups > 31.