Re: [PATCH net] sctp: fix the issue that flags are ignored when using kernel_connect

2018-05-22 Thread Xin Long
On Wed, May 23, 2018 at 1:40 AM, David Miller wrote: > From: Xin Long > Date: Sun, 20 May 2018 16:39:10 +0800 > >> Now sctp uses inet_dgram_connect as its proto_ops .connect, and the flags >> param can't be passed into its proto .connect where this flags is really >> needed. >> >> sctp works arou

Re: [PATCH net-next 2/3] net/ipv6: Udate fib6_table_lookup tracepoint

2018-05-22 Thread kbuild test robot
Hi David, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/dsahern-kernel-org/net-ipv4-Udate-fib_table_lookup-tracepoint/20180523-083238 config: x86_64-randconfig-s4-05231222 (attached as .config) compiler:

Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework

2018-05-22 Thread Jiri Pirko
Tue, May 22, 2018 at 10:54:29PM CEST, sridhar.samudr...@intel.com wrote: > > >On 5/22/2018 9:12 AM, Jiri Pirko wrote: >> Fixing the subj, sorry about that. >> >> Tue, May 22, 2018 at 05:46:21PM CEST, m...@redhat.com wrote: >> > On Tue, May 22, 2018 at 05:36:14PM +0200, Jiri Pirko wrote: >> > > Tue

[PATCH net-next v3 0/7] Add support for QCA8334 switch

2018-05-22 Thread Michal Vokáč
This series basically adds support for a QCA8334 ethernet switch to the qca8k driver. It is a four-port variant of the already supported seven port QCA8337. Register map is the same for the whole familly and all chips have the same device ID. Major part of this series enhances the CPU port setting

[PATCH net-next v3 1/7] net: dsa: qca8k: Add QCA8334 binding documentation

2018-05-22 Thread Michal Vokáč
Add support for the four-port variant of the Qualcomm QCA833x switch. The CPU port default link settings can be reconfigured using a fixed-link sub-node. Signed-off-by: Michal Vokáč Reviewed-by: Rob Herring Reviewed-by: Andrew Lunn --- Changes in v3: - Correct fixed-link node documentation te

[PATCH net-next v3 2/7] net: dsa: qca8k: Add support for QCA8334 switch

2018-05-22 Thread Michal Vokáč
Add support for the four-port variant of the Qualcomm QCA833x switch. Signed-off-by: Michal Vokáč Reviewed-by: Andrew Lunn --- Changes in v3: - Add "Reviewed-by" tag from Andrew Changes in v2: - Add commit message drivers/net/dsa/qca8k.c | 1 + 1 file changed, 1 insertion(+) diff --git a/d

[PATCH net-next v3 5/7] net: dsa: qca8k: Allow overwriting CPU port setting

2018-05-22 Thread Michal Vokáč
Implement adjust_link function that allows to overwrite default CPU port setting using fixed-link device tree subnode. Signed-off-by: Michal Vokáč Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli --- Changes in v3: - none Changes in v2: - Add "Reviewed-by" tags from Andrew and Florian.

[PATCH net-next v3 3/7] net: dsa: qca8k: Enable RXMAC when bringing up a port

2018-05-22 Thread Michal Vokáč
When a port is brought up/down do not enable/disable only the TXMAC but the RXMAC as well. This is essential for the CPU port to work. Fixes: 6b93fb46480a ("net-next: dsa: add new driver for qca8xxx family") Signed-off-by: Michal Vokáč Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli ---

[PATCH net-next v3 6/7] net: dsa: qca8k: Replace GPL boilerplate by SPDX

2018-05-22 Thread Michal Vokáč
Replace the GPLv2 license boilerplate with the SPDX license identifier. Signed-off-by: Michal Vokáč Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli --- Changes in v3: - none Changes in v2: - Add commit message. - Add "Reviewed-by" tags from Andrew and Florian. drivers/net/dsa/qca8k

[PATCH net-next v3 4/7] net: dsa: qca8k: Force CPU port to its highest bandwidth

2018-05-22 Thread Michal Vokáč
By default autonegotiation is enabled to configure MAC on all ports. For the CPU port autonegotiation can not be used so we need to set some sensible defaults manually. This patch forces the default setting of the CPU port to 1000Mbps/full duplex which is the chip maximum capability. Also correct

[PATCH net-next v3 7/7] net: dsa: qca8k: Remove redundant parentheses

2018-05-22 Thread Michal Vokáč
Fix warning reported by checkpatch. Signed-off-by: Michal Vokáč Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli --- Changes in v3: - none Changes in v2: - Fix typo in subject. - Add "Reviewed-by" tags from Andrew and Florian. drivers/net/dsa/qca8k.c | 2 +- 1 file changed, 1 insert

Re: [net-next] i40iw/i40e: Remove link dependency on i40e

2018-05-22 Thread Christoph Hellwig
On Tue, May 22, 2018 at 02:50:32PM -0700, Jeff Kirsher wrote: > The ABI rarely changes, if at all. The issue OSV's are seeing is that > upgrading i40e, requires that i40iw be recompiled even though there > were no updates/changes to the ABI. So fscking what. If you upgrade one part of the kernel

Re: [net-next] i40iw/i40e: Remove link dependency on i40e

2018-05-22 Thread Christoph Hellwig
On Tue, May 22, 2018 at 02:04:06PM -0700, Jeff Kirsher wrote: > > Why would you want to do this? The rdma driver is non-functional > > without the ethernet driver, so why on earth would we want to defeat > > the module dependency mechanism? > > This change is driven by the OSV's like Red Hat, wher

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-22 Thread Or Gerlitz
On Wed, May 23, 2018 at 4:01 AM, Huy Nguyen wrote: > Dear Jakub, PSB. > On 5/22/2018 1:32 PM, Jakub Kicinski wrote: >> Devlink API accommodates requirements of simpler (SwitchX2?) and more >> advanced schemes (present in Spectrum). The simpler/basic static >> threshold configurations is exactly

[PATCH net-next] cxgb4: Add new T6 device ids

2018-05-22 Thread Ganesh Goudar
Add 0x6088 and 0x6089 device ids for new T6 cards. Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h b/drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h in

[PATCH] net: phy: replace bool members in struct phy_device with bit-fields

2018-05-22 Thread Heiner Kallweit
In struct phy_device we have a number of flags being defined as type bool. Similar to e.g. struct pci_dev we can save some space by using bit-fields. Signed-off-by: Heiner Kallweit --- include/linux/phy.h | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git

Re: [PATCH] [RFC] bpf: tracing: new helper bpf_get_current_cgroup_ino

2018-05-22 Thread Y Song
On Tue, May 22, 2018 at 8:35 PM, Alexei Starovoitov wrote: > On Tue, May 22, 2018 at 08:33:24PM -0700, Y Song wrote: >> + struct cgroup *cgrp = task_dfl_cgroup(current); >> + if (!cgrp) >> + return -EINVAL; > > why this check is needed? No reason :-) Originally I am conc

[PATCH] ppp: remove the PPPIOCDETACH ioctl

2018-05-22 Thread Eric Biggers
From: Eric Biggers The PPPIOCDETACH ioctl effectively tries to "close" the given ppp file before f_count has reached 0, which is fundamentally a bad idea. It does check 'f_count < 2', which excludes concurrent operations on the file since they would only be possible with a shared fd table, in wh

Re: [PATCH] [RFC] bpf: tracing: new helper bpf_get_current_cgroup_ino

2018-05-22 Thread Alexei Starovoitov
On Tue, May 22, 2018 at 08:33:24PM -0700, Y Song wrote: > + struct cgroup *cgrp = task_dfl_cgroup(current); > + if (!cgrp) > + return -EINVAL; why this check is needed?

Re: [PATCH] [RFC] bpf: tracing: new helper bpf_get_current_cgroup_ino

2018-05-22 Thread Y Song
I did a quick prototyping and the above interface seems working fine. The kernel change: === [yhs@localhost bpf-next]$ git diff diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h index 97446bbe2ca5..669b7383fddb 100644 --- a/include/uapi/linux/bpf.h +++ b/include/uapi/li

Re: [PATCH] e1000: check the return of pci_get_drvdata() in e1000_remove()

2018-05-22 Thread Bo Chen
Re-send to mailing lists as the previous email was rejected because of not using plain text. - Hi Stephen, Thanks for the quick reply and your comments. I am new to network drivers, and certainly trust your assessment. I was assuming 'pdev->dev.p' can be NULL with a 'kzalloc()' failure in '

Re: [PATCH net-next v2 00/10] qed*: Add support for management firmware TLV request.

2018-05-22 Thread David Miller
From: Sudarsana Reddy Kalluru Date: Tue, 22 May 2018 00:28:36 -0700 > From: Sudarsana Reddy Kalluru > > Management firmware (MFW) requires config and state information from > the driver. It queries this via TLV (type-length-value) request wherein > mfw specificies the list of required TLVs. Dri

Re: [PATCH net-next] cxgb4: do L1 config when module is inserted

2018-05-22 Thread kbuild test robot
Hi Ganesh, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Ganesh-Goudar/cxgb4-do-L1-config-when-module-is-inserted/20180523-085637 config: x86_64-rhel (attached as .config) compiler: gcc-7 (Debian 7.3.0-16

Re: KASAN: use-after-free Read in remove_wait_queue (2)

2018-05-22 Thread Eric Biggers
On Fri, May 18, 2018 at 06:02:23PM +0200, Guillaume Nault wrote: > On Sun, May 13, 2018 at 11:11:55PM -0700, Eric Biggers wrote: > > [+ppp list and maintainer] > > > > This is a bug in ppp_generic.c; it still happens on Linus' tree and it's > > easily > > reproducible, see program below. The bug

Re: [PATCH net-next] cxgb4: do L1 config when module is inserted

2018-05-22 Thread kbuild test robot
Hi Ganesh, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Ganesh-Goudar/cxgb4-do-L1-config-when-module-is-inserted/20180523-085637 config: sparc64-allyesconfig (attached as .config) compiler: sparc64-linux

Re: [PATCH] e1000: check the return of pci_get_drvdata() in e1000_remove()

2018-05-22 Thread Stephen Hemminger
On Tue, 22 May 2018 17:17:43 -0700 Bo Chen wrote: > This check on pci_get_drvdata() prevents potential invalid pointer > dereferences, > and is a common practice in *_remove() functions from other drivers, such as > 'intel/e100.c', 'amd/pcnet32.c', 'realtek/8139too.c', and 'broadcom/tg3.c'. > >

YAaioRace (was Re: [PATCH 08/31] aio: implement IOCB_CMD_POLL)

2018-05-22 Thread Al Viro
On Wed, May 23, 2018 at 01:49:04AM +0100, Al Viro wrote: > > Looks like we want to call ->ki_cancel() *BEFORE* removing from the list, > > as well as doing fput() after aio_complete(). The same ordering, BTW, goes > > for aio_read() et.al. > > > > Look: > > CPU1: io_cancel() grabs ->ctx_lo

Re: [PATCH v3] mlx4_core: allocate ICM memory in page size chunks

2018-05-22 Thread Qing Huang
On 5/22/2018 8:33 AM, Tariq Toukan wrote: On 18/05/2018 12:45 AM, Qing Huang wrote: On 5/17/2018 2:14 PM, Eric Dumazet wrote: On 05/17/2018 01:53 PM, Qing Huang wrote: When a system is under memory presure (high usage with fragments), the original 256KB ICM chunk allocations will likely

Re: [RFC V4 PATCH 7/8] vhost: packed ring support

2018-05-22 Thread Jason Wang
On 2018年05月23日 00:54, Wei Xu wrote: On Wed, May 16, 2018 at 08:32:20PM +0800, Jason Wang wrote: Signed-off-by: Jason Wang --- drivers/vhost/net.c | 3 +- drivers/vhost/vhost.c | 539 ++ drivers/vhost/vhost.h | 8 +- 3 files changed, 5

Re: [PATCH net-next 1/2] tcp: add max_quickacks param to tcp_incr_quickack and tcp_enter_quickack_mode

2018-05-22 Thread Neal Cardwell
On Tue, May 22, 2018 at 8:31 PM kbuild test robot wrote: > Hi Eric, > Thank you for the patch! Yet something to improve: > [auto build test ERROR on net/master] > [also build test ERROR on v4.17-rc6 next-20180517] > [cannot apply to net-next/master] > [if your patch is applied to the wrong git

Re: [PATCH net] net: phy: broadcom: Fix bcm_write_exp()

2018-05-22 Thread Florian Fainelli
Hi Andrew, On 05/22/2018 05:15 PM, Andrew Lunn wrote: > On Tue, May 22, 2018 at 05:04:49PM -0700, Florian Fainelli wrote: >> On newer PHYs, we need to select the expansion register to write with >> setting bits [11:8] to 0xf. This was done correctly by bcm7xxx.c prior >> to being migrated to gener

Re: [PATCH net-next v2] net: sched: don't disable bh when accessing action idr

2018-05-22 Thread Cong Wang
On Mon, May 21, 2018 at 1:03 PM, Vlad Buslov wrote: > Initial net_device implementation used ingress_lock spinlock to synchronize > ingress path of device. This lock was used in both process and bh context. > In some code paths action map lock was obtained while holding ingress_lock. > Commit e1e9

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-22 Thread Huy Nguyen
Dear Jakub, PSB. On 5/22/2018 1:32 PM, Jakub Kicinski wrote: On Tue, 22 May 2018 10:36:17 -0500, Huy Nguyen wrote: On 5/22/2018 12:20 AM, Jakub Kicinski wrote: On Mon, 21 May 2018 14:04:57 -0700, Saeed Mahameed wrote: From: Huy Nguyen In this patch, we add dcbnl buffer attribute to allow us

Re: [PATCH 08/31] aio: implement IOCB_CMD_POLL

2018-05-22 Thread Al Viro
On Wed, May 23, 2018 at 01:45:30AM +0100, Al Viro wrote: > Oh, bugger... > > wakeup > removed from queue > schedule __aio_poll_complete() > > cancel > grab ctx->lock > remove from list > work > aio_complete() > check if it's in the list >

Re: [PATCH 08/31] aio: implement IOCB_CMD_POLL

2018-05-22 Thread Al Viro
On Tue, May 22, 2018 at 11:05:24PM +0100, Al Viro wrote: > > +{ > > + struct aio_kiocb *iocb = container_of(req, struct aio_kiocb, poll); > > + > > + fput(req->file); > > + aio_complete(iocb, mangle_poll(mask), 0); > > +} > > Careful. > > > +static int aio_poll_cancel(struct kiocb *iocb) >

RE: [Intel-wired-lan] [PATCH] e1000e: Ignore TSYNCRXCTL when getting I219 clock attributes

2018-05-22 Thread Brown, Aaron F
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On > Behalf Of Benjamin Poirier > Sent: Thursday, May 10, 2018 12:29 AM > To: Kirsher, Jeffrey T > Cc: ehabk...@redhat.com; netdev@vger.kernel.org; jaya...@goubiq.com; > linux-ker...@vger.kernel.org; bart.vanass...@wdc.com; > post

Re: [PATCH net-next 1/2] tcp: add max_quickacks param to tcp_incr_quickack and tcp_enter_quickack_mode

2018-05-22 Thread kbuild test robot
Hi Eric, Thank you for the patch! Yet something to improve: [auto build test ERROR on net/master] [also build test ERROR on v4.17-rc6 next-20180517] [cannot apply to net-next/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: http

[PATCH] e1000: check the return of pci_get_drvdata() in e1000_remove()

2018-05-22 Thread Bo Chen
This check on pci_get_drvdata() prevents potential invalid pointer dereferences, and is a common practice in *_remove() functions from other drivers, such as 'intel/e100.c', 'amd/pcnet32.c', 'realtek/8139too.c', and 'broadcom/tg3.c'. Signed-off-by: Bo Chen --- drivers/net/ethernet/intel/e1000/e1

Re: [PATCH net] net: phy: broadcom: Fix bcm_write_exp()

2018-05-22 Thread Andrew Lunn
On Tue, May 22, 2018 at 05:04:49PM -0700, Florian Fainelli wrote: > On newer PHYs, we need to select the expansion register to write with > setting bits [11:8] to 0xf. This was done correctly by bcm7xxx.c prior > to being migrated to generic code under bcm-phy-lib.c which > unfortunately used the o

[PATCH net] net: phy: broadcom: Fix bcm_write_exp()

2018-05-22 Thread Florian Fainelli
On newer PHYs, we need to select the expansion register to write with setting bits [11:8] to 0xf. This was done correctly by bcm7xxx.c prior to being migrated to generic code under bcm-phy-lib.c which unfortunately used the older implementation from the BCM54xx days. Fix this by creating an inline

[PATCH v2 bpf-next 3/5] libbpf: Support guessing sendmsg{4,6} progs

2018-05-22 Thread Andrey Ignatov
libbpf can guess prog type and expected attach type based on section name. Add hints for "cgroup/sendmsg4" and "cgroup/sendmsg6" section names. Signed-off-by: Andrey Ignatov Acked-by: Alexei Starovoitov Acked-by: Martin KaFai Lau --- tools/lib/bpf/libbpf.c | 2 ++ 1 file changed, 2 insertions(

[PATCH v2 bpf-next 5/5] selftests/bpf: Selftest for sys_sendmsg hooks

2018-05-22 Thread Andrey Ignatov
Add selftest for BPF_CGROUP_UDP4_SENDMSG and BPF_CGROUP_UDP6_SENDMSG attach types. Try to sendmsg(2) to specific IP:port and test that: * source IP is overridden as expected. * remote IP:port pair is overridden as expected; Both UDPv4 and UDPv6 are tested. Output: # test_sock_addr.sh 2>/dev/nu

[PATCH v2 bpf-next 1/5] bpf: Hooks for sys_sendmsg

2018-05-22 Thread Andrey Ignatov
In addition to already existing BPF hooks for sys_bind and sys_connect, the patch provides new hooks for sys_sendmsg. It leverages existing BPF program type `BPF_PROG_TYPE_CGROUP_SOCK_ADDR` that provides access to socket itlself (properties like family, type, protocol) and user-passed `struct sock

[PATCH v2 bpf-next 4/5] selftests/bpf: Prepare test_sock_addr for extension

2018-05-22 Thread Andrey Ignatov
test_sock_addr was not easy to extend since it was focused on sys_bind and sys_connect quite a bit. Reorganized it so that it'll be easier to cover new test-cases for `BPF_PROG_TYPE_CGROUP_SOCK_ADDR`: - decouple test-cases so that only one BPF prog is tested at a time; - check programmatically t

[PATCH v2 bpf-next 2/5] bpf: Sync bpf.h to tools/

2018-05-22 Thread Andrey Ignatov
Sync new `BPF_CGROUP_UDP4_SENDMSG` and `BPF_CGROUP_UDP6_SENDMSG` attach types to tools/. Signed-off-by: Andrey Ignatov Acked-by: Alexei Starovoitov Acked-by: Martin KaFai Lau --- tools/include/uapi/linux/bpf.h | 8 1 file changed, 8 insertions(+) diff --git a/tools/include/uapi/linux

[PATCH v2 bpf-next 0/5] bpf: Hooks for sys_sendmsg

2018-05-22 Thread Andrey Ignatov
v1 -> v2: * return ENOTSUPP if bpf_prog rewrote IPv6-only with IPv4-mapped IPv6; * add test for IPv4-mapped IPv6 use-case; * fix build for CONFIG_CGROUP_BPF=n; * rebase. This path set adds BPF hooks for sys_sendmsg similar to existing hooks for sys_bind and sys_connect. Hooks allow to override so

[PATCH net] net: phy: broadcom: Fix auxiliary control register reads

2018-05-22 Thread Florian Fainelli
We are currently doing auxiliary control register reads with the shadow register value 0b111 (0x7) which incidentally is also the selector value that should be present in bits [2:0]. Fix this by using the appropriate selector mask which is defined (MII_BCM54XX_AUXCTL_SHDWSEL_MASK). This does not h

Re: [PATCH net-next] r8169: perform reset synchronously in __rtl8169_resume

2018-05-22 Thread Francois Romieu
David Miller : > From: Heiner Kallweit > Date: Mon, 21 May 2018 19:01:19 +0200 > > > The driver uses pm_runtime_get_sync() in few places and relies on the > > device being fully runtime-resumed after this call. So far however > > the runtime resume callback triggers an asynchronous reset. > > A

Proposal

2018-05-22 Thread Miss Zeliha Omer Faruk
Hello Greetings to you please i have a business proposal for you contact me for more detailes asap thanks. Best Regards, Miss.Zeliha ömer faruk Esentepe Mahallesi Büyükdere Caddesi Kristal Kule Binasi No:215 Sisli - Istanbul, Turkey

Re: [PATCH bpf-next 5/5] selftests/bpf: Selftest for sys_sendmsg hooks

2018-05-22 Thread Martin KaFai Lau
On Fri, May 18, 2018 at 07:21:13PM -0700, Andrey Ignatov wrote: > Add selftest for BPF_CGROUP_UDP4_SENDMSG and BPF_CGROUP_UDP6_SENDMSG > attach types. > > Try to sendmsg(2) to specific IP:port and test that: > * source IP is overridden as expected. > * remote IP:port pair is overridden as expected

Re: [PATCH bpf-next 4/5] selftests/bpf: Prepare test_sock_addr for extension

2018-05-22 Thread Martin KaFai Lau
On Fri, May 18, 2018 at 07:21:12PM -0700, Andrey Ignatov wrote: > test_sock_addr was not easy to extend since it was focused on sys_bind > and sys_connect quite a bit. > > Reorganized it so that it'll be easier to cover new test-cases for > `BPF_PROG_TYPE_CGROUP_SOCK_ADDR`: > > - decouple test-ca

Re: [PATCH bpf-next 3/5] libbpf: Support guessing sendmsg{4,6} progs

2018-05-22 Thread Martin KaFai Lau
On Fri, May 18, 2018 at 07:21:11PM -0700, Andrey Ignatov wrote: > libbpf can guess prog type and expected attach type based on section > name. Add hints for "cgroup/sendmsg4" and "cgroup/sendmsg6" section > names. > > Signed-off-by: Andrey Ignatov > Acked-by: Alexei Starovoitov Acked-by: Martin

Re: [PATCH bpf-next 2/5] bpf: Sync bpf.h to tools/

2018-05-22 Thread Martin KaFai Lau
On Fri, May 18, 2018 at 07:21:10PM -0700, Andrey Ignatov wrote: > Sync new `BPF_CGROUP_UDP4_SENDMSG` and `BPF_CGROUP_UDP6_SENDMSG` > attach types to tools/. > > Signed-off-by: Andrey Ignatov > Acked-by: Alexei Starovoitov Acked-by: Martin KaFai Lau

Re: [PATCH v2] ath10k: transmit queued frames after waking queues

2018-05-22 Thread Rajkumar Manoharan
On 2018-05-22 14:15, Niklas Cassel wrote: On Mon, May 21, 2018 at 04:11:38PM -0700, Rajkumar Manoharan wrote: On 2018-05-21 13:43, Niklas Cassel wrote: > The following problem was observed when running iperf: [...] Sorry for the late response. ath10k_mac_tx_push_pending is already called at

Re: aio poll and a new in-kernel poll API V12

2018-05-22 Thread Al Viro
On Tue, May 22, 2018 at 01:30:37PM +0200, Christoph Hellwig wrote: > Hi all, > > this series adds support for the IOCB_CMD_POLL operation to poll for the > readyness of file descriptors using the aio subsystem. The API is based > on patches that existed in RHAS2.1 and RHEL3, which means it alread

Re: [Cake] [PATCH net-next v14 6/7] sch_cake: Add overhead compensation support to the rate shaper

2018-05-22 Thread Toke Høiland-Jørgensen
Marcelo Ricardo Leitner writes: > On Tue, May 22, 2018 at 10:44:53AM +0200, Toke Høiland-Jørgensen wrote: >> >> >> On 22 May 2018 01:45:13 CEST, Marcelo Ricardo Leitner >> wrote: >> >On Mon, May 21, 2018 at 10:35:58PM +0200, Toke Høiland-Jørgensen wrote: >> >> +static u32 cake_overhead(struct

Re: [PATCH 08/31] aio: implement IOCB_CMD_POLL

2018-05-22 Thread Al Viro
On Tue, May 22, 2018 at 01:30:45PM +0200, Christoph Hellwig wrote: > +static inline void __aio_poll_complete(struct poll_iocb *req, __poll_t mask) > +{ > + struct aio_kiocb *iocb = container_of(req, struct aio_kiocb, poll); > + > + fput(req->file); > + aio_complete(iocb, mangle_poll(ma

[PATCH bpf-next v2 7/7] bpf: btf: Add tests for the btf uapi changes

2018-05-22 Thread Martin KaFai Lau
This patch does the followings: 1. Modify libbpf and test_btf to reflect the uapi changes in btf 2. Add test for the btf_header changes 3. Add tests for array->index_type 4. Add err_str check to the tests 5. Fix a 4 bytes hole in "struct test #1" by swapping "m" and "n" Signed-off-by: Martin KaFai

[PATCH bpf-next v2 1/7] bpf: Expose check_uarg_tail_zero()

2018-05-22 Thread Martin KaFai Lau
This patch exposes check_uarg_tail_zero() which will be reused by a later BTF patch. Its name is changed to bpf_check_uarg_tail_zero(). Signed-off-by: Martin KaFai Lau Acked-by: Yonghong Song --- include/linux/bpf.h | 2 ++ kernel/bpf/syscall.c | 14 +++--- 2 files changed, 9 inserti

[PATCH bpf-next v2 3/7] bpf: btf: Check array->index_type

2018-05-22 Thread Martin KaFai Lau
Instead of ingoring the array->index_type field. Enforce that it must be a BTF_KIND_INT in size 1/2/4/8 bytes. Signed-off-by: Martin KaFai Lau --- kernel/bpf/btf.c | 80 +++- 1 file changed, 56 insertions(+), 24 deletions(-) diff --git a/kern

Re: [PATCH net-next v2 2/7] net: dsa: qca8k: Add support for QCA8334 switch'

2018-05-22 Thread Andrew Lunn
On Tue, May 22, 2018 at 01:16:27PM +0200, Michal Vokáč wrote: > Add support for the four-port variant of the Qualcomm QCA833x switch. > > Signed-off-by: Michal Vokáč Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next v2 1/7] net: dsa: qca8k: Add QCA8334 binding documentation

2018-05-22 Thread Andrew Lunn
On Tue, May 22, 2018 at 01:16:26PM +0200, Michal Vokáč wrote: > Add support for the four-port variant of the Qualcomm QCA833x switch. > > The CPU port default link settings can be reconfigured using > a fixed-link sub-node. > > Signed-off-by: Michal Vokáč Reviewed-by: Andrew Lunn Andrew

[PATCH bpf-next v2 6/7] bpf: btf: Sync bpf.h and btf.h to tools

2018-05-22 Thread Martin KaFai Lau
This patch sync the uapi bpf.h and btf.h to tools. Signed-off-by: Martin KaFai Lau Acked-by: Yonghong Song --- tools/include/uapi/linux/bpf.h | 8 tools/include/uapi/linux/btf.h | 37 +++-- 2 files changed, 15 insertions(+), 30 deletions(-) diff --git

[PATCH bpf-next v2 0/7] BTF uapi cleanup

2018-05-22 Thread Martin KaFai Lau
This patch set makes some changes to cleanup the unused bits in BTF uapi. It also makes the btf_header extensible. Please see individual patches for details. v2: - Remove NR_SECS from patch 2 - Remove "unsigned" check on array->index_type from patch 3 - Remove BTF_INT_VARARGS and further limit B

[PATCH bpf-next v2 2/7] bpf: btf: Change how section is supported in btf_header

2018-05-22 Thread Martin KaFai Lau
There are currently unused section descriptions in the btf_header. Those sections are here to support future BTF use cases. For example, the func section (func_off) is to support function signature (e.g. the BPF prog function signature). Instead of spelling out all potential sections up-front in

[PATCH bpf-next v2 5/7] bpf: btf: Rename btf_key_id and btf_value_id in bpf_map_info

2018-05-22 Thread Martin KaFai Lau
In "struct bpf_map_info", the name "btf_id", "btf_key_id" and "btf_value_id" could cause confusion because the "id" of "btf_id" means the BPF obj id given to the BTF object while "btf_key_id" and "btf_value_id" means the BTF type id within that BTF object. To make it clear, btf_key_id and btf_valu

[PATCH bpf-next v2 4/7] bpf: btf: Remove unused bits from uapi/linux/btf.h

2018-05-22 Thread Martin KaFai Lau
This patch does the followings: 1. Limit BTF_MAX_TYPES and BTF_MAX_NAME_OFFSET to 64k. We can raise it later. 2. Remove the BTF_TYPE_PARENT and BTF_STR_TBL_ELF_ID. They are currently encoded at the highest bit of a u32. It is because the current use case does not require supporting p

Re: [net-next] i40iw/i40e: Remove link dependency on i40e

2018-05-22 Thread Jason Gunthorpe
On Tue, May 22, 2018 at 02:50:32PM -0700, Jeff Kirsher wrote: > On Tue, 2018-05-22 at 15:33 -0600, Jason Gunthorpe wrote: > > On Tue, May 22, 2018 at 02:04:06PM -0700, Jeff Kirsher wrote: > > > On Tue, 2018-05-22 at 14:56 -0600, Jason Gunthorpe wrote: > > > > On Tue, May 22, 2018 at 01:38:31PM -070

Re: [net-next] i40iw/i40e: Remove link dependency on i40e

2018-05-22 Thread Jeff Kirsher
On Tue, 2018-05-22 at 15:33 -0600, Jason Gunthorpe wrote: > On Tue, May 22, 2018 at 02:04:06PM -0700, Jeff Kirsher wrote: > > On Tue, 2018-05-22 at 14:56 -0600, Jason Gunthorpe wrote: > > > On Tue, May 22, 2018 at 01:38:31PM -0700, Jeff Kirsher wrote: > > > > From: Sindhu Devale > > > > > > > > C

Re: [net-next] i40iw/i40e: Remove link dependency on i40e

2018-05-22 Thread Jason Gunthorpe
On Tue, May 22, 2018 at 02:04:06PM -0700, Jeff Kirsher wrote: > On Tue, 2018-05-22 at 14:56 -0600, Jason Gunthorpe wrote: > > On Tue, May 22, 2018 at 01:38:31PM -0700, Jeff Kirsher wrote: > > > From: Sindhu Devale > > > > > > Currently i40iw is dependent on i40e symbols > > > i40e_register_client

[PATCH 2/2] rfkill: Create rfkill-none LED trigger

2018-05-22 Thread João Paulo Rechi Vita
Creates a new trigger rfkill-none, as a complement to rfkill-any, which drives LEDs when any radio is enabled. The new trigger is meant to turn a LED ON whenever all radios are OFF, and turn it OFF otherwise. Signed-off-by: João Paulo Rechi Vita --- net/rfkill/core.c | 27 ---

[PATCH 1/2] rfkill: Rename rfkill_any_led_trigger* functions

2018-05-22 Thread João Paulo Rechi Vita
Rename these functions to rfkill_global_led_trigger*, as they are going to be extended to handle another global rfkill led trigger. This commit does not change any functionality. Signed-off-by: João Paulo Rechi Vita --- net/rfkill/core.c | 47 --- 1 f

Re: [PATCH v2] ath10k: transmit queued frames after waking queues

2018-05-22 Thread Niklas Cassel
On Mon, May 21, 2018 at 04:11:38PM -0700, Rajkumar Manoharan wrote: > On 2018-05-21 13:43, Niklas Cassel wrote: > > The following problem was observed when running iperf: > [...] > > > > In order to avoid trying to flush the queue every time we free a frame, > > only do this when there are 3 or le

[PATCH net-next v5 3/3] selftests: net: initial fib rule tests

2018-05-22 Thread Roopa Prabhu
From: Roopa Prabhu This adds a first set of tests for fib rule match/action for ipv4 and ipv6. Initial tests only cover action lookup table. can be extended to cover other actions in the future. Uses ip route get to validate the rule lookup. Signed-off-by: Roopa Prabhu --- tools/testing/selfte

[PATCH net-next v5 0/3] fib rule selftest

2018-05-22 Thread Roopa Prabhu
From: Roopa Prabhu This series adds a new test to test fib rules. ip route get is used to test fib rule matches. This series also extends ip route get to match on sport and dport to test recent support of sport and dport fib rule match. v2 - address ido's commemt to make sport dport ip route get

[PATCH net-next v5 1/3] ipv4: support sport, dport and ip_proto in RTM_GETROUTE

2018-05-22 Thread Roopa Prabhu
From: Roopa Prabhu This is a followup to fib rules sport, dport and ipproto match support. Only supports tcp, udp and icmp for ipproto. Used by fib rule self tests. Signed-off-by: Roopa Prabhu --- include/net/ip.h | 3 + include/uapi/linux/rtnetlink.h | 3 + net/ipv4/Makefile

[PATCH net-next v5 2/3] ipv6: support sport, dport and ip_proto in RTM_GETROUTE

2018-05-22 Thread Roopa Prabhu
From: Roopa Prabhu This is a followup to fib6 rules sport, dport and ipproto match support. Only supports tcp, udp and icmp for ipproto. Used by fib rule self tests. Signed-off-by: Roopa Prabhu --- net/ipv6/route.c | 17 + 1 file changed, 17 insertions(+) diff --git a/net/ipv6

Re: [net-next] i40iw/i40e: Remove link dependency on i40e

2018-05-22 Thread Jeff Kirsher
On Tue, 2018-05-22 at 14:56 -0600, Jason Gunthorpe wrote: > On Tue, May 22, 2018 at 01:38:31PM -0700, Jeff Kirsher wrote: > > From: Sindhu Devale > > > > Currently i40iw is dependent on i40e symbols > > i40e_register_client and i40e_unregister_client due to > > which i40iw cannot be loaded withou

Re: [net-next] i40iw/i40e: Remove link dependency on i40e

2018-05-22 Thread Jason Gunthorpe
On Tue, May 22, 2018 at 01:38:31PM -0700, Jeff Kirsher wrote: > From: Sindhu Devale > > Currently i40iw is dependent on i40e symbols > i40e_register_client and i40e_unregister_client due to > which i40iw cannot be loaded without i40e being loaded. > > This patch allows RDMA driver to build and l

Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework

2018-05-22 Thread Samudrala, Sridhar
On 5/22/2018 9:12 AM, Jiri Pirko wrote: Fixing the subj, sorry about that. Tue, May 22, 2018 at 05:46:21PM CEST, m...@redhat.com wrote: On Tue, May 22, 2018 at 05:36:14PM +0200, Jiri Pirko wrote: Tue, May 22, 2018 at 05:28:42PM CEST, sridhar.samudr...@intel.com wrote: On 5/22/2018 2:08 AM,

Re: [PATCH net-next v2 1/7] net: dsa: qca8k: Add QCA8334 binding documentation

2018-05-22 Thread Michal
On 22.5.2018 21:40, Rob Herring wrote: On Tue, May 22, 2018 at 01:16:26PM +0200, Michal Vokáč wrote: Add support for the four-port variant of the Qualcomm QCA833x switch. The CPU port default link settings can be reconfigured using a fixed-link sub-node. Signed-off-by: Michal Vokáč --- Change

[PATCH net-next] enic: set DMA mask to 47 bit

2018-05-22 Thread Govindarajulu Varadarajan
In commit 624dbf55a359b ("driver/net: enic: Try DMA 64 first, then failover to DMA") DMA mask was changed from 40 bits to 64 bits. Hardware actually supports only 47 bits. Fixes: 624dbf55a359b("driver/net: enic: Try DMA 64 first, then failover to DMA") Signed-off-by: Govindarajulu Varadarajan ---

[PATCH net] net: ipv4: add missing RTA_TABLE to rtm_ipv4_policy

2018-05-22 Thread Roopa Prabhu
From: Roopa Prabhu Signed-off-by: Roopa Prabhu --- net/ipv4/fib_frontend.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c index 4d622112..e66172a 100644 --- a/net/ipv4/fib_frontend.c +++ b/net/ipv4/fib_frontend.c @@ -649,6 +649,7 @@ const s

Re: [PATCH net-next 0/7] net/ipv6: Fix route append and replace use cases

2018-05-22 Thread David Ahern
On 5/22/18 12:46 PM, David Miller wrote: > > Ok, I'll apply this series. > > But if this breaks things for anyone in a practical way, I am unfortunately > going to have to revert no matter how silly the current behavior may be. > Understood. I have to try the best option first. I'll look at reg

Re: [PATCH 07/33] iwlwifi: mvm: use match_string() helper

2018-05-22 Thread Andy Shevchenko
On Tue, May 22, 2018 at 6:30 AM, Yisheng Xie wrote: >> But it's up tu Loca. Shame on me. I meant Luca, of course! Luca, sorry. > OK, I will change it if Loca agree your opinion. -- With Best Regards, Andy Shevchenko

[net-next] i40iw/i40e: Remove link dependency on i40e

2018-05-22 Thread Jeff Kirsher
From: Sindhu Devale Currently i40iw is dependent on i40e symbols i40e_register_client and i40e_unregister_client due to which i40iw cannot be loaded without i40e being loaded. This patch allows RDMA driver to build and load without linking to LAN driver and without LAN driver being loaded first.

Re: [Cake] [PATCH net-next v14 6/7] sch_cake: Add overhead compensation support to the rate shaper

2018-05-22 Thread Marcelo Ricardo Leitner
On Tue, May 22, 2018 at 10:44:53AM +0200, Toke Høiland-Jørgensen wrote: > > > On 22 May 2018 01:45:13 CEST, Marcelo Ricardo Leitner > wrote: > >On Mon, May 21, 2018 at 10:35:58PM +0200, Toke Høiland-Jørgensen wrote: > >> +static u32 cake_overhead(struct cake_sched_data *q, const struct > >sk_bu

Re: Regression: Approximate 34% performance hit in receive throughput over ixgbe seen due to build_skb patch

2018-05-22 Thread Alexander Duyck
On Tue, May 22, 2018 at 12:29 PM, William Kucharski wrote: > > >> On May 22, 2018, at 12:23 PM, Alexander Duyck >> wrote: >> >> 3. There should be a private flag that can be updated via "ethtool >> --set-priv-flags" called "legacy-rx" that you can enable that will >> roll back to the original th

Re: [PATCH bpf-next v3 10/10] tools: bpftool: add delimiters to multi-function JITed dumps

2018-05-22 Thread Jakub Kicinski
On Tue, 22 May 2018 22:46:13 +0530, Sandipan Das wrote: > + if (info.nr_jited_func_lens && info.jited_func_lens) { > + struct kernel_sym *sym = NULL; > + unsigned char *img = buf; > + __u64 *ksyms = NULL; > +

Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework

2018-05-22 Thread Michael S. Tsirkin
On Tue, May 22, 2018 at 07:38:44PM +0200, Jiri Pirko wrote: > >> >> In private > >> >> flag. I don't see no reason to break this pattern here. > >> > > >> >Other masters are setup from userspace, this one is set up automatically > >> >by kernel. So the bar is higher, we need an interface that exist

Re: [PATCH net 1/1] qed: Fix mask for physical address in ILT entry

2018-05-22 Thread David Miller
From: "Shaikh, Shahed" Date: Tue, 22 May 2018 19:42:46 + > Can you please queues this fix for -stable? I did, see: http://patchwork.ozlabs.org/bundle/davem/stable/?series=&submitter=&state=*&q=&archive=

Re: [PATCH bpf-next v3 07/10] bpf: fix multi-function JITed dump obtained via syscall

2018-05-22 Thread Jakub Kicinski
On Tue, 22 May 2018 22:46:10 +0530, Sandipan Das wrote: > Currently, for multi-function programs, we cannot get the JITed > instructions using the bpf system call's BPF_OBJ_GET_INFO_BY_FD > command. Because of this, userspace tools such as bpftool fail > to identify a multi-function program as bein

Re: [net-next 0/9][pull request] 40GbE Intel Wired LAN Driver Updates 2018-05-22

2018-05-22 Thread David Miller
From: Jeff Kirsher Date: Tue, 22 May 2018 10:45:18 -0700 > This series contains updates to i40e only. > > Jake provides all the changes in this series starting with making it > consistent in how we approach the bit lock. Fixed the reporting of the > VEB statistics and the queue statistics to al

Re: [PATCH net-next 0/2] tcp: reduce quickack pressure for ECN

2018-05-22 Thread David Miller
From: Eric Dumazet Date: Mon, 21 May 2018 15:08:55 -0700 > Small patch series changing TCP behavior vs quickack and ECN > > First patch is a refactoring, adding parameter to tcp_incr_quickack() > and tcp_enter_quickack_mode() helpers. > > Second patch implements the change, lowering number of A

RE: [PATCH net 1/1] qed: Fix mask for physical address in ILT entry

2018-05-22 Thread Shaikh, Shahed
> -Original Message- > From: David Miller > Sent: Tuesday, May 22, 2018 12:34 PM > To: Shaikh, Shahed > Cc: netdev@vger.kernel.org; Elior, Ariel ; Dept-Eng > Everest Linux L2 > Subject: Re: [PATCH net 1/1] qed: Fix mask for physical address in ILT entry > > From: Shahed Shaikh > Date

Re: [PATCH] pcnet32: add an error handling path in pcnet32_probe_pci()

2018-05-22 Thread David Miller
From: Bo Chen Date: Mon, 21 May 2018 14:44:49 -0700 > Make sure to invoke pci_disable_device() when errors occur in > pcnet32_probe_pci(). > > Signed-off-by: Bo Chen Applied, thank you.

Re: [PATCH net-next v2 1/7] net: dsa: qca8k: Add QCA8334 binding documentation

2018-05-22 Thread Rob Herring
On Tue, May 22, 2018 at 01:16:26PM +0200, Michal Vokáč wrote: > Add support for the four-port variant of the Qualcomm QCA833x switch. > > The CPU port default link settings can be reconfigured using > a fixed-link sub-node. > > Signed-off-by: Michal Vokáč > --- > Changes in v2: > - Add commit m

Re: [pull request][net-next 0/6] Mellanox, mlx5e updates 2018-05-19

2018-05-22 Thread David Miller
From: Saeed Mahameed Date: Mon, 21 May 2018 14:04:56 -0700 > This is a mlx5e only pull request, for more information please see tag > log below. > > Please pull and let me know if there's any problem. The dcbnl vs. devlink shared buffer API issue needs to be discussed more thoroughly. Even if

Re: [PATCH bpf-next v3 06/10] tools: bpftool: resolve calls without using imm field

2018-05-22 Thread Jakub Kicinski
On Tue, 22 May 2018 22:46:09 +0530, Sandipan Das wrote: > Currently, we resolve the callee's address for a JITed function > call by using the imm field of the call instruction as an offset > from __bpf_call_base. If bpf_jit_kallsyms is enabled, we further > use this address to get the callee's kern

[PATCH] selftests: uevent filtering

2018-05-22 Thread Christian Brauner
Recent discussions around uevent filtering (cf. net-next commit [1], [2], and [3] and discussions in [4], [5], and [6]) have shown that the semantics around uevent filtering where not well understood. Now that we have settled - at least for the moment - how uevent filtering should look like let's a

  1   2   3   4   >