> -----Original Message-----
> From: David Miller <da...@davemloft.net>
> Sent: Tuesday, May 22, 2018 12:34 PM
> To: Shaikh, Shahed <shahed.sha...@cavium.com>
> Cc: netdev@vger.kernel.org; Elior, Ariel <ariel.el...@cavium.com>; Dept-Eng
> Everest Linux L2 <dept-engeverestlinu...@cavium.com>
> Subject: Re: [PATCH net 1/1] qed: Fix mask for physical address in ILT entry
> 
> From: Shahed Shaikh <shahed.sha...@cavium.com>
> Date: Mon, 21 May 2018 12:31:47 -0700
> 
> > ILT entry requires 12 bit right shifted physical address.
> > Existing mask for ILT entry of physical address i.e.
> > ILT_ENTRY_PHY_ADDR_MASK is not sufficient to handle 64bit address
> > because upper 8 bits of 64 bit address were getting masked which
> > resulted in completer abort error on PCIe bus due to invalid address.
> >
> > Fix that mask to handle 64bit physical address.
> >
> > Fixes: fe56b9e6a8d9 ("qed: Add module with basic common support")
> >
> > Signed-off-by: Shahed Shaikh <shahed.sha...@cavium.com>
> > Signed-off-by: Ariel Elior <ariel.el...@cavium.com>
> 
> Please do not put an empty line between Fixes: and other tags in the future.  
> I
> fixed it up this time.

Sorry about this. Thanks for fixing.

> 
> Applied, thanks.
Can you please queues this fix for -stable?

Thanks,
Shahed

Reply via email to