Re: [PATCH bpf-next v3 00/15] Introducing AF_XDP support

2018-05-16 Thread Björn Töpel
2018-05-04 1:38 GMT+02:00 Alexei Starovoitov : > On Fri, May 04, 2018 at 12:49:09AM +0200, Daniel Borkmann wrote: >> On 05/02/2018 01:01 PM, Björn Töpel wrote: >> > From: Björn Töpel >> > >> > This patch set introduces a new address family called AF_XDP that is >> > optimized for high performance

Re: [PATCH] xen-netfront: fix xennet_start_xmit()'s return type

2018-05-16 Thread Juergen Gross
On 24/04/18 15:18, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too. > > Signed-off-by: Luc

Re: linux-next: manual merge of the net-next tree with the vfs tree

2018-05-16 Thread Christoph Hellwig
> + /* Create a new file under /proc/net/ipconfig */ > + static int ipconfig_proc_net_create(const char *name, > + const struct file_operations *fops) > + { > + char *pname; > + struct proc_dir_entry *p; > + > + if (!ipconfig_dir) > + return

Re: [PATCH 11/40] ipv6/flowlabel: simplify pid namespace lookup

2018-05-16 Thread Christoph Hellwig
On Thu, May 17, 2018 at 12:28:01AM -0500, Eric W. Biederman wrote: > > struct pid_namespace *proc_pid_namespace(struct inode *inode) > > { > > // maybe warn on for s_magic not on procfs?? > > return inode->i_sb->s_fs_info; > > } > > That should work. Ideally out of line for the proc_fs.h

[PATCH bpf 2/6] bpf: powerpc64: add JIT support for multi-function programs

2018-05-16 Thread Sandipan Das
This adds support for bpf-to-bpf function calls in the powerpc64 JIT compiler. The JIT compiler converts the bpf call instructions to native branch instructions. After a round of the usual passes, the start addresses of the JITed images for the callee functions are known. Finally, to fixup the bran

[PATCH bpf 1/6] bpf: support 64-bit offsets for bpf function calls

2018-05-16 Thread Sandipan Das
The imm field of a bpf instruction is a signed 32-bit integer. For JIT bpf-to-bpf function calls, it stores the offset of the start address of the callee's JITed image from __bpf_call_base. For some architectures, such as powerpc64, this offset may be as large as 64 bits and cannot be accomodated

[PATCH bpf 4/6] tools: bpf: sync bpf uapi header

2018-05-16 Thread Sandipan Das
Syncing the bpf.h uapi header with tools so that struct bpf_prog_info has the two new fields for passing on the addresses of the kernel symbols corresponding to each function in a JITed program. Signed-off-by: Sandipan Das --- tools/include/uapi/linux/bpf.h | 2 ++ 1 file changed, 2 insertions(+

[PATCH bpf 6/6] bpf: fix JITed dump for multi-function programs via syscall

2018-05-16 Thread Sandipan Das
Currently, for multi-function programs, we cannot get the JITed instructions using the bpf system call's BPF_OBJ_GET_INFO_BY_FD command. Because of this, userspace tools such as bpftool fail to identify a multi-function program as being JITed or not. With the JIT enabled and the test program runni

[PATCH bpf 3/6] bpf: get kernel symbol addresses via syscall

2018-05-16 Thread Sandipan Das
This adds new two new fields to struct bpf_prog_info. For multi-function programs, these fields can be used to pass a list of kernel symbol addresses for all functions in a given program and to userspace using the bpf system call with the BPF_OBJ_GET_INFO_BY_FD command. When bpf_jit_kallsyms is en

[PATCH bpf 0/6] bpf: enhancements for multi-function programs

2018-05-16 Thread Sandipan Das
This patch series introduces the following: [1] Support for bpf-to-bpf function calls in the powerpc64 JIT compiler. [2] Provide a way for resolving function calls because of the way JITed images are allocated in powerpc64. [3] Fix to get JITed instruction dumps for multi-function programs f

[PATCH bpf 5/6] tools: bpftool: resolve calls without using imm field

2018-05-16 Thread Sandipan Das
Currently, we resolve the callee's address for a JITed function call by using the imm field of the call instruction as an offset from __bpf_call_base. If bpf_jit_kallsyms is enabled, we further use this address to get the callee's kernel symbol's name. For some architectures, such as powerpc64, th

Re: [RFC PATCH bpf-next 05/12] xdp: add MEM_TYPE_ZERO_COPY

2018-05-16 Thread Jesper Dangaard Brouer
On Tue, 15 May 2018 21:06:08 +0200 Björn Töpel wrote: > @@ -82,6 +88,10 @@ struct xdp_frame *convert_to_xdp_frame(struct xdp_buff > *xdp) > int metasize; > int headroom; > > + // XXX implement clone, copy, use "native" MEM_TYPE > + if (xdp->rxq->mem.type == MEM_TYPE_ZERO_CO

Re: [PATCH 11/40] ipv6/flowlabel: simplify pid namespace lookup

2018-05-16 Thread Eric W. Biederman
Christoph Hellwig writes: > On Sat, May 05, 2018 at 07:37:33AM -0500, Eric W. Biederman wrote: >> Christoph Hellwig writes: >> >> > The shole seq_file sequence already operates under a single RCU lock pair, >> > so move the pid namespace lookup into it, and stop grabbing a reference >> > and re

Re: [PATCH net-next 1/3] net: ethernet: ti: Allow most drivers with COMPILE_TEST

2018-05-16 Thread kbuild test robot
Hi Florian, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-Allow-more-drivers-with-COMPILE_TEST/20180517-092807 config: xtensa-allyesconfig (attached as .config) compiler: xtensa

Re: Grant

2018-05-16 Thread Maratovich.M. Fridman
I Mikhail Fridman. has selected you specially as one of my beneficiaries for my Charitable Donation, Just as I have declared on May 23, 2016 to give my fortune as charity. Check the link below for confirmation: http://www.ibtimes.co.uk/russias-second-wealthiest-man-mikhail-fridman-plans-leavin

Re: [PATCH net-next 2/3] net: ethernet: freescale: Allow FEC with COMPILE_TEST

2018-05-16 Thread kbuild test robot
Hi Florian, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-Allow-more-drivers-with-COMPILE_TEST/20180517-092807 config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gnu

[PATCH net-next] vmxnet3: Replace msleep(1) with usleep_range()

2018-05-16 Thread YueHaibing
As documented in Documentation/timers/timers-howto.txt, replace msleep(1) with usleep_range(). Signed-off-by: YueHaibing --- drivers/net/vmxnet3/vmxnet3_drv.c | 6 +++--- drivers/net/vmxnet3/vmxnet3_ethtool.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/

Re: [PATCH net-next 2/3] net: ethernet: freescale: Allow FEC with COMPILE_TEST

2018-05-16 Thread kbuild test robot
Hi Florian, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-Allow-more-drivers-with-COMPILE_TEST/20180517-092807 config: m68k-allyesconfig (attached as .config) compiler: m68k-lin

Re: Donation

2018-05-16 Thread M.M. Fridman
I Mikhail Fridman. has selected you specially as one of my beneficiaries for my Charitable Donation, Just as I have declared on May 23, 2016 to give my fortune as charity. Check the link below for confirmation: http://www.ibtimes.co.uk/russias-second-wealthiest-man-mikhail-fridman-plans-leavin

Re: [PATCH net-next 1/3] net: ethernet: ti: Allow most drivers with COMPILE_TEST

2018-05-16 Thread kbuild test robot
Hi Florian, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-Allow-more-drivers-with-COMPILE_TEST/20180517-092807 config: i386-allmodconfig (attached as .config) compiler: gcc-7 (D

Re: xdp and fragments with virtio

2018-05-16 Thread David Ahern
On 5/16/18 1:24 AM, Jason Wang wrote: > > > On 2018年05月16日 11:51, David Ahern wrote: >> Hi Jason: >> >> I am trying to test MTU changes to the BPF fib_lookup helper and seeing >> something odd. Hoping you can help. >> >> I have a VM with multiple virtio based NICs and tap backends. I install >> t

Re: pull-request: bpf-next 2018-05-17

2018-05-16 Thread David Miller
From: Daniel Borkmann Date: Thu, 17 May 2018 03:09:48 +0200 > The following pull-request contains BPF updates for your *net-next* > tree. Looks good, pulled, thanks Daniel.

Re: [PATCH net-next v3 1/3] ipv4: support sport, dport and ip_proto in RTM_GETROUTE

2018-05-16 Thread David Miller
From: Roopa Prabhu Date: Wed, 16 May 2018 13:30:28 -0700 > yes, but we hold rcu read lock before calling the reply function for > fib result. I did consider allocating the skb before the read > lock..but then the refactoring (into a separate netlink reply func) > would seem unnecessary. > > I a

[PATCH] bonding: introduce link change helper

2018-05-16 Thread Tonghao Zhang
Introduce an new common helper to avoid redundancy. Signed-off-by: Tonghao Zhang --- drivers/net/bonding/bond_main.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c in

Re: [PATCH ghak81 V3 3/3] audit: collect audit task parameters

2018-05-16 Thread kbuild test robot
Hi Richard, Thank you for the patch! Yet something to improve: [auto build test ERROR on next-20180516] [cannot apply to linus/master tip/sched/core v4.17-rc5 v4.17-rc4 v4.17-rc3 v4.17-rc5] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url

linux-next: manual merge of the net-next tree with the vfs tree

2018-05-16 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/ipv4/ipconfig.c between commits: 3f3942aca6da ("proc: introduce proc_create_single{,_data}") c04d2cb2009f ("ipconfig: Write NTP server IPs to /proc/net/ipconfig/ntp_servers") from the vfs tree and commit: 4d

Re: [PATCH 34/40] atm: simplify procfs code

2018-05-16 Thread Eric W. Biederman
Christoph Hellwig writes: > On Sat, May 05, 2018 at 07:51:18AM -0500, Eric W. Biederman wrote: >> Christoph Hellwig writes: >> >> > Use remove_proc_subtree to remove the whole subtree on cleanup, and >> > unwind the registration loop into individual calls. Switch to use >> > proc_create_seq wh

pull-request: bpf-next 2018-05-17

2018-05-16 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net-next* tree. The main changes are: 1) Provide a new BPF helper for doing a FIB and neighbor lookup in the kernel tables from an XDP or tc BPF program. The helper provides a fast-path for forwarding packets. The API supp

Re: [RFC bpf-next 06/11] bpf: Add reference tracking to verifier

2018-05-16 Thread Joe Stringer
On 14 May 2018 at 20:04, Alexei Starovoitov wrote: > On Wed, May 09, 2018 at 02:07:04PM -0700, Joe Stringer wrote: >> Allow helper functions to acquire a reference and return it into a >> register. Specific pointer types such as the PTR_TO_SOCKET will >> implicitly represent such a reference. The

Re: [PATCH v3] {net, IB}/mlx5: Use 'kvfree()' for memory allocated by 'kvzalloc()'

2018-05-16 Thread Saeed Mahameed
On Wed, 2018-05-16 at 21:07 +0200, Christophe JAILLET wrote: > When 'kvzalloc()' is used to allocate memory, 'kvfree()' must be used > to > free it. > > Fixes: 1cbe6fc86ccfe ("IB/mlx5: Add support for CQE compressing") > Fixes: fed9ce22bf8ae ("net/mlx5: E-Switch, Add API to create vport rx > rules

[PATCH net] erspan: fix invalid erspan version.

2018-05-16 Thread William Tu
ERSPAN only support version 1 and 2. When packets send to an erspan device which does not have proper version number set, drop the packet. In real case, we observe multicast packets sent to the erspan pernet device, erspan0, which does not have erspan version configured. Reported-by: Greg Rose

Re: [RFC bpf-next 04/11] bpf: Add PTR_TO_SOCKET verifier type

2018-05-16 Thread Joe Stringer
On 14 May 2018 at 19:37, Alexei Starovoitov wrote: > On Wed, May 09, 2018 at 02:07:02PM -0700, Joe Stringer wrote: >> Teach the verifier a little bit about a new type of pointer, a >> PTR_TO_SOCKET. This pointer type is accessed from BPF through the >> 'struct bpf_sock' structure. >> >> Signed-off

Re: [bpf-next PATCH] bpf: sockmap, on update propagate errors back to userspace

2018-05-16 Thread Daniel Borkmann
On 05/17/2018 01:38 AM, John Fastabend wrote: > When an error happens in the update sockmap element logic also pass > the err up to the user. > > Fixes: e5cd3abcb31a ("bpf: sockmap, refactor sockmap routines to work with > hashmap") > Signed-off-by: John Fastabend Agree, applied to bpf-next, th

[PATCH bpf] bpf: fix truncated jump targets on heavy expansions

2018-05-16 Thread Daniel Borkmann
Recently during testing, I ran into the following panic: [ 207.892422] Internal error: Accessing user space memory outside uaccess.h routines: 9604 [#1] SMP [ 207.901637] Modules linked in: binfmt_misc [...] [ 207.966530] CPU: 45 PID: 2256 Comm: test_verifier Tainted: GW

[bpf-next PATCH] bpf: sockmap, on update propagate errors back to userspace

2018-05-16 Thread John Fastabend
When an error happens in the update sockmap element logic also pass the err up to the user. Fixes: e5cd3abcb31a ("bpf: sockmap, refactor sockmap routines to work with hashmap") Signed-off-by: John Fastabend --- kernel/bpf/sockmap.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH net-next 5/8] tcp: new helper tcp_timeout_mark_lost

2018-05-16 Thread Yuchung Cheng
Refactor using a new helper, tcp_timeout_mark_loss(), that marks packets lost upon RTO. Signed-off-by: Yuchung Cheng Signed-off-by: Neal Cardwell Reviewed-by: Eric Dumazet Reviewed-by: Soheil Hassas Yeganeh Reviewed-by: Priyaranjan Jha --- net/ipv4/tcp_input.c | 50 +-

[PATCH net-next 1/8] tcp: support DUPACK threshold in RACK

2018-05-16 Thread Yuchung Cheng
This patch adds support for the classic DUPACK threshold rule (#DupThresh) in RACK. When the number of packets SACKed is greater or equal to the threshold, RACK sets the reordering window to zero which would immediately mark all the unsacked packets below the highest SACKed sequence lost. Since th

[PATCH net-next 4/8] tcp: account lost retransmit after timeout

2018-05-16 Thread Yuchung Cheng
The previous approach for the lost and retransmit bits was to wipe the slate clean: zero all the lost and retransmit bits, correspondingly zero the lost_out and retrans_out counters, and then add back the lost bits (and correspondingly increment lost_out). The new approach is to treat this very mu

[PATCH net-next 8/8] tcp: don't mark recently sent packets lost on RTO

2018-05-16 Thread Yuchung Cheng
An RTO event indicates the head has not been acked for a long time after its last (re)transmission. But the other packets are not necessarily lost if they have been only sent recently (for example due to application limit). This patch would prohibit marking packets sent within an RTT to be lost on

[PATCH net-next 7/8] tcp: new helper tcp_rack_skb_timeout

2018-05-16 Thread Yuchung Cheng
Create and export a new helper tcp_rack_skb_timeout and move tcp_is_rack to prepare the final RTO change. Signed-off-by: Yuchung Cheng Signed-off-by: Neal Cardwell Reviewed-by: Eric Dumazet Reviewed-by: Soheil Hassas Yeganeh Reviewed-by: Priyaranjan Jha --- include/net/tcp.h | 2 ++ n

[PATCH net-next 6/8] tcp: separate loss marking and state update on RTO

2018-05-16 Thread Yuchung Cheng
Previously when TCP times out, it first updates cwnd and ssthresh, marks packets lost, and then updates congestion state again. This was fine because everything not yet delivered is marked lost, so the inflight is always 0 and cwnd can be safely set to 1 to retransmit one packet on timeout. But th

[PATCH net-next 2/8] tcp: disable RFC6675 loss detection

2018-05-16 Thread Yuchung Cheng
This patch disables RFC6675 loss detection and make sysctl net.ipv4.tcp_recovery = 1 controls a binary choice between RACK (1) or RFC6675 (0). Signed-off-by: Yuchung Cheng Signed-off-by: Neal Cardwell Reviewed-by: Eric Dumazet Reviewed-by: Soheil Hassas Yeganeh Reviewed-by: Priyaranjan Jha --

[PATCH net-next 3/8] tcp: simpler NewReno implementation

2018-05-16 Thread Yuchung Cheng
This is a rewrite of NewReno loss recovery implementation that is simpler and standalone for readability and better performance by using less states. Note that NewReno refers to RFC6582 as a modification to the fast recovery algorithm. It is used only if the connection does not support SACK in Lin

[PATCH net-next 0/8] tcp: default RACK loss recovery

2018-05-16 Thread Yuchung Cheng
This patch set implements the features correspond to the draft-ietf-tcpm-rack-03 version of the RACK draft. https://datatracker.ietf.org/meeting/101/materials/slides-101-tcpm-update-on-tcp-rack-00 1. SACK: implement equivalent DUPACK threshold heuristic in RACK to replace existing RFC6675 recov

Proposal

2018-05-16 Thread Miss Zeliha Omer Faruk
Hello Greetings to you please i have a business proposal for you contact me for more detailes asap thanks. Best Regards, Miss.Zeliha ömer faruk Esentepe Mahallesi Büyükdere Caddesi Kristal Kule Binasi No:215 Sisli - Istanbul, Turkey

Re: [PATCH bpf-next] libbpf: add ifindex to enable offload support

2018-05-16 Thread Daniel Borkmann
On 05/16/2018 11:02 PM, Jakub Kicinski wrote: > From: David Beckett > > BPF programs currently can only be offloaded using iproute2. This > patch will allow programs to be offloaded using libbpf calls. > > Signed-off-by: David Beckett > Reviewed-by: Jakub Kicinski Applied to bpf-next, thanks

Re: [PATCH] bpf: add __printf verification to bpf_verifier_vlog

2018-05-16 Thread Daniel Borkmann
On 05/16/2018 10:27 PM, Mathieu Malaterre wrote: > __printf is useful to verify format and arguments. ‘bpf_verifier_vlog’ > function is used twice in verifier.c in both cases the caller function > already uses the __printf gcc attribute. > > Remove the following warning, triggered with W=1: > >

Re: [PATCH bpf-next] bpf: fix sock hashmap kmalloc warning

2018-05-16 Thread Daniel Borkmann
On 05/16/2018 11:06 PM, Yonghong Song wrote: > syzbot reported a kernel warning below: > WARNING: CPU: 0 PID: 4499 at mm/slab_common.c:996 kmalloc_slab+0x56/0x70 > mm/slab_common.c:996 > Kernel panic - not syncing: panic_on_warn set ... > > CPU: 0 PID: 4499 Comm: syz-executor050 Not tainted

Re: kernel BUG at lib/string.c:LINE! (4)

2018-05-16 Thread Julian Anastasov
Hello, On Wed, 16 May 2018, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:0b7d9978406f Merge branch 'Microsemi-Ocelot-Ethernet-switc.. > git tree: net-next > console output: https://syzkaller.appspot.com/x/log.txt?x=16e9101780 > kernel co

Re: [PATCH net-next] erspan: set bso bit based on mirrored packet's len

2018-05-16 Thread Tobin C. Harding
On Wed, May 16, 2018 at 07:05:34AM -0700, William Tu wrote: > On Mon, May 14, 2018 at 10:33 PM, Tobin C. Harding wrote: > > On Mon, May 14, 2018 at 04:54:36PM -0700, William Tu wrote: > >> Before the patch, the erspan BSO bit (Bad/Short/Oversized) is not > >> handled. BSO has 4 possible values: >

[PATCH] net: ethernet: ti: cpsw: disable mq feature for "AM33xx ES1.0" devices

2018-05-16 Thread Ivan Khoronzhuk
The early versions of am33xx devices, related to ES1.0 SoC revision have errata limiting mq support. That's the same errata as commit 7da1160002f1 ("drivers: net: cpsw: add am335x errata workarround for interrutps") AM33xx Errata [1] Advisory 1.0.9 http://www.ti.com/lit/er/sprz360f/sprz360f.pdf A

Re: [PATCH bpf-next 2/7] bpf: introduce bpf subcommand BPF_PERF_EVENT_QUERY

2018-05-16 Thread Yonghong Song
On 5/16/18 4:27 AM, Peter Zijlstra wrote: On Tue, May 15, 2018 at 04:45:16PM -0700, Yonghong Song wrote: Currently, suppose a userspace application has loaded a bpf program and attached it to a tracepoint/kprobe/uprobe, and a bpf introspection tool, e.g., bpftool, wants to show which bpf progr

Re: [PATCH bpf-next v5 3/6] bpf: Add IPv6 Segment Routing helpers

2018-05-16 Thread Mathieu Xhonneux
2018-05-14 23:40 GMT+01:00 Daniel Borkmann : > On 05/12/2018 07:25 PM, Mathieu Xhonneux wrote: > [...] >> +BPF_CALL_4(bpf_lwt_seg6_store_bytes, struct sk_buff *, skb, u32, offset, >> +const void *, from, u32, len) >> +{ >> +#if IS_ENABLED(CONFIG_IPV6_SEG6_BPF) >> + struct seg6_bpf_srh_

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-16 Thread Jiri Pirko
Wed, May 16, 2018 at 11:23:41PM CEST, vla...@mellanox.com wrote: > >On Wed 16 May 2018 at 17:36, Roman Mashak wrote: >> Vlad Buslov writes: >> >>> On Wed 16 May 2018 at 14:38, Roman Mashak wrote: On Wed, May 16, 2018 at 2:43 AM, Vlad Buslov wrote: > I'm trying to run tdc, but keep

[bpf PATCH 1/2] bpf: sockmap update rollback on error can incorrectly dec prog refcnt

2018-05-16 Thread John Fastabend
If the user were to only attach one of the parse or verdict programs then it is possible a subsequent sockmap update could incorrectly decrement the refcnt on the program. This happens because in the rollback logic, after an error, we have to decrement the program reference count when its been incr

[bpf PATCH 2/2] bpf: parse and verdict prog attach may race with bpf map update

2018-05-16 Thread John Fastabend
In the sockmap design BPF programs (SK_SKB_STREAM_PARSER and SK_SKB_STREAM_VERDICT) are attached to the sockmap map type and when a sock is added to the map the programs are used by the socket. However, sockmap updates from both userspace and BPF programs can happen concurrently with the attach and

Re: [PATCH bpf-next v6 1/4] bpf: sockmap, refactor sockmap routines to work with hashmap

2018-05-16 Thread John Fastabend
On 05/15/2018 12:19 PM, Daniel Borkmann wrote: > On 05/14/2018 07:00 PM, John Fastabend wrote: > [...] [...] > > As you say in the comment above the function wrt locking notes that the > __sock_map_ctx_update_elem() can be called concurrently. > > All operations operate on sock_map using cmp

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-16 Thread Vlad Buslov
On Wed 16 May 2018 at 18:10, Davide Caratti wrote: > On Wed, 2018-05-16 at 13:36 -0400, Roman Mashak wrote: >> Vlad Buslov writes: >> >> > On Wed 16 May 2018 at 14:38, Roman Mashak wrote: >> > > On Wed, May 16, 2018 at 2:43 AM, Vlad Buslov wrote: >> > > > > > > > I'm trying to run tdc, but ke

Re: [PATCH iproute2-next] tc-netem: fix limit description in man page

2018-05-16 Thread Stephen Hemminger
On Wed, 16 May 2018 15:17:50 -0600 David Ahern wrote: > On 5/15/18 6:49 PM, Marcelo Ricardo Leitner wrote: > > As the kernel code says, limit is actually the amount of packets it can > > hold queued at a time, as per: > > > > static int netem_enqueue(struct sk_buff *skb, struct Qdisc *sch, > >

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-16 Thread Vlad Buslov
On Wed 16 May 2018 at 17:36, Roman Mashak wrote: > Vlad Buslov writes: > >> On Wed 16 May 2018 at 14:38, Roman Mashak wrote: >>> On Wed, May 16, 2018 at 2:43 AM, Vlad Buslov wrote: I'm trying to run tdc, but keep getting following error even on clean branch without my patches

Re: [PATCH iproute2-next] tc-netem: fix limit description in man page

2018-05-16 Thread David Ahern
On 5/15/18 6:49 PM, Marcelo Ricardo Leitner wrote: > As the kernel code says, limit is actually the amount of packets it can > hold queued at a time, as per: > > static int netem_enqueue(struct sk_buff *skb, struct Qdisc *sch, > struct sk_buff **to_free) > { > ... >

Re: [PATCH net-next v12 2/7] sch_cake: Add ingress mode

2018-05-16 Thread Toke Høiland-Jørgensen
Cong Wang writes: > On Wed, May 16, 2018 at 1:29 PM, Toke Høiland-Jørgensen wrote: >> + if (tb[TCA_CAKE_AUTORATE]) { >> + if (!!nla_get_u32(tb[TCA_CAKE_AUTORATE])) >> + q->rate_flags |= CAKE_FLAG_AUTORATE_INGRESS; >> + else >> +

Re: [PATCH net-next v12 4/7] sch_cake: Add NAT awareness to packet classifier

2018-05-16 Thread Toke Høiland-Jørgensen
Cong Wang writes: > On Wed, May 16, 2018 at 1:29 PM, Toke Høiland-Jørgensen wrote: >> When CAKE is deployed on a gateway that also performs NAT (which is a >> common deployment mode), the host fairness mechanism cannot distinguish >> internal hosts from each other, and so fails to work correctly

Re: [PATCH bpf-next] bpf: fix sock hashmap kmalloc warning

2018-05-16 Thread John Fastabend
On 05/16/2018 02:06 PM, Yonghong Song wrote: > syzbot reported a kernel warning below: > WARNING: CPU: 0 PID: 4499 at mm/slab_common.c:996 kmalloc_slab+0x56/0x70 > mm/slab_common.c:996 > Kernel panic - not syncing: panic_on_warn set ... > > CPU: 0 PID: 4499 Comm: syz-executor050 Not tainted

Re: [iproute2-next v2 1/1] tipc: fixed node and name table listings

2018-05-16 Thread David Ahern
On 5/15/18 7:54 AM, Jon Maloy wrote: > We make it easier for users to correlate between 128-bit node > identities and 32-bit node hash number by extending the 'node list' > command to also show the hash number. > > We also improve the 'nametable show' command to show the node identity > instead of

Re: [PATCH net-next v12 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

2018-05-16 Thread Toke Høiland-Jørgensen
Cong Wang writes: > On Wed, May 16, 2018 at 1:29 PM, Toke Høiland-Jørgensen wrote: >> + >> +static struct Qdisc *cake_leaf(struct Qdisc *sch, unsigned long arg) >> +{ >> + return NULL; >> +} >> + >> +static unsigned long cake_find(struct Qdisc *sch, u32 classid) >> +{ >> + return 0;

Re: [PATCH net-next v12 2/7] sch_cake: Add ingress mode

2018-05-16 Thread Cong Wang
On Wed, May 16, 2018 at 1:29 PM, Toke Høiland-Jørgensen wrote: > + if (tb[TCA_CAKE_AUTORATE]) { > + if (!!nla_get_u32(tb[TCA_CAKE_AUTORATE])) > + q->rate_flags |= CAKE_FLAG_AUTORATE_INGRESS; > + else > + q->rate_flags &=

[PATCH bpf-next] bpf: fix sock hashmap kmalloc warning

2018-05-16 Thread Yonghong Song
syzbot reported a kernel warning below: WARNING: CPU: 0 PID: 4499 at mm/slab_common.c:996 kmalloc_slab+0x56/0x70 mm/slab_common.c:996 Kernel panic - not syncing: panic_on_warn set ... CPU: 0 PID: 4499 Comm: syz-executor050 Not tainted 4.17.0-rc3+ #9 Hardware name: Google Google Compute En

[PATCH v3 1/2] media: rc: introduce BPF_PROG_RAWIR_EVENT

2018-05-16 Thread Sean Young
Add support for BPF_PROG_RAWIR_EVENT. This type of BPF program can call rc_keydown() to reported decoded IR scancodes, or rc_repeat() to report that the last key should be repeated. The bpf program can be attached to using the bpf(BPF_PROG_ATTACH) syscall; the target_fd must be the /dev/lircN devi

[PATCH v3 2/2] bpf: add selftest for rawir_event type program

2018-05-16 Thread Sean Young
This is simple test over rc-loopback. Signed-off-by: Sean Young --- tools/bpf/bpftool/prog.c | 1 + tools/include/uapi/linux/bpf.h| 57 +++- tools/lib/bpf/libbpf.c| 1 + tools/testing/selftests/bpf/Makefile | 8 +-

[PATCH v3 0/2] IR decoding using BPF

2018-05-16 Thread Sean Young
The kernel IR decoders (drivers/media/rc/ir-*-decoder.c) support the most widely used IR protocols, but there are many protocols which are not supported[1]. For example, the lirc-remotes[2] repo has over 2700 remotes, many of which are not supported by rc-core. There is a "long tail" of unsupported

[PATCH bpf-next] libbpf: add ifindex to enable offload support

2018-05-16 Thread Jakub Kicinski
From: David Beckett BPF programs currently can only be offloaded using iproute2. This patch will allow programs to be offloaded using libbpf calls. Signed-off-by: David Beckett Reviewed-by: Jakub Kicinski --- tools/lib/bpf/bpf.c| 2 ++ tools/lib/bpf/bpf.h| 2 ++ tools/lib/bpf/libbpf

Re: [PATCH 0/3] ibmvnic: Fix bugs and memory leaks

2018-05-16 Thread Thomas Falcon
On 05/16/2018 03:49 PM, Thomas Falcon wrote: > This is a small patch series fixing up some bugs and memory leaks > in the ibmvnic driver. The first fix frees up previously allocated > memory that should be freed in case of an error. The second fixes > a reset case that was failing due to TX/RX queu

Re: [PATCH net-next v12 4/7] sch_cake: Add NAT awareness to packet classifier

2018-05-16 Thread Cong Wang
On Wed, May 16, 2018 at 1:29 PM, Toke Høiland-Jørgensen wrote: > When CAKE is deployed on a gateway that also performs NAT (which is a > common deployment mode), the host fairness mechanism cannot distinguish > internal hosts from each other, and so fails to work correctly. > > To fix this, we add

Re: [PATCH v2 net] net/ipv4: Initialize proto and ports in flow struct

2018-05-16 Thread Roopa Prabhu
On Wed, May 16, 2018 at 1:36 PM, David Ahern wrote: > Updating the FIB tracepoint for the recent change to allow rules using > the protocol and ports exposed a few places where the entries in the flow > struct are not initialized. > > For __fib_validate_source add the call to fib4_rules_early_flow

[PATCH 1/3] ibmvnic: Free coherent DMA memory if FW map failed

2018-05-16 Thread Thomas Falcon
If the firmware map fails for whatever reason, remember to free up the memory after. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index 6e8d6a6..9e0

[PATCH 2/3] ibmvnic: Fix non-fatal firmware error reset

2018-05-16 Thread Thomas Falcon
It is not necessary to disable interrupt lines here during a reset to handle a non-fatal firmware error. Move that call within the code block that handles the other cases that do require interrupts to be disabled and re-enabled. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c

[PATCH 3/3] ibmvnic: Fix statistics buffers memory leak

2018-05-16 Thread Thomas Falcon
Move initialization of statistics buffers from ibmvnic_init function into ibmvnic_probe. In the current state, ibmvnic_init will be called again during a device reset, resulting in the allocation of new buffers without freeing the old ones. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/i

[PATCH 0/3] ibmvnic: Fix bugs and memory leaks

2018-05-16 Thread Thomas Falcon
This is a small patch series fixing up some bugs and memory leaks in the ibmvnic driver. The first fix frees up previously allocated memory that should be freed in case of an error. The second fixes a reset case that was failing due to TX/RX queue IRQ's being erroneously disabled without being enab

Re: [PATCH net-next v12 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

2018-05-16 Thread Cong Wang
On Wed, May 16, 2018 at 1:29 PM, Toke Høiland-Jørgensen wrote: > + > +static struct Qdisc *cake_leaf(struct Qdisc *sch, unsigned long arg) > +{ > + return NULL; > +} > + > +static unsigned long cake_find(struct Qdisc *sch, u32 classid) > +{ > + return 0; > +} > + > +static void cake_wa

Re: [PATCH 1/3] sh_eth: add RGMII support

2018-05-16 Thread Andrew Lunn
> > Hi Sergei > > > > What about > > PHY_INTERFACE_MODE_RGMII_ID, > > PHY_INTERFACE_MODE_RGMII_RXID, > > PHY_INTERFACE_MODE_RGMII_TXID, > >Oops, totally forgot about those... :-/ Everybody does. I keep intending to write a email template for this, and phy_interface_mode_is_rgmii(

[PATCH v2 net] net/ipv4: Initialize proto and ports in flow struct

2018-05-16 Thread David Ahern
Updating the FIB tracepoint for the recent change to allow rules using the protocol and ports exposed a few places where the entries in the flow struct are not initialized. For __fib_validate_source add the call to fib4_rules_early_flow_dissect since it is invoked for the input path. For netfilter

Re: [PATCH 1/3] sh_eth: add RGMII support

2018-05-16 Thread Sergei Shtylyov
On 05/16/2018 11:30 PM, Andrew Lunn wrote: >> The R-Car V3H (AKA R8A77980) GEther controller adds support for the RGMII >> PHY interface mode as a new value for the RMII_MII register. >> >> Based on the original (and large) patch by Vladimir Barinov. >> >> Signed-off-by: Vladimir Barinov >> Si

Re: [PATCH 1/3] sh_eth: add RGMII support

2018-05-16 Thread Andrew Lunn
On Wed, May 16, 2018 at 10:56:45PM +0300, Sergei Shtylyov wrote: > The R-Car V3H (AKA R8A77980) GEther controller adds support for the RGMII > PHY interface mode as a new value for the RMII_MII register. > > Based on the original (and large) patch by Vladimir Barinov. > > Signed-off-by: Vladim

Re: [PATCH net-next v3 1/3] ipv4: support sport, dport and ip_proto in RTM_GETROUTE

2018-05-16 Thread Roopa Prabhu
On Wed, May 16, 2018 at 11:37 AM, David Miller wrote: > From: Roopa Prabhu > Date: Tue, 15 May 2018 20:55:06 -0700 > >> +static int inet_rtm_getroute_reply(struct sk_buff *in_skb, struct nlmsghdr >> *nlh, >> +__be32 dst, __be32 src, struct flowi4 *fl4, >> +

[PATCH net-next v12 5/7] sch_cake: Add DiffServ handling

2018-05-16 Thread Toke Høiland-Jørgensen
This adds support for DiffServ-based priority queueing to CAKE. If the shaper is in use, each priority tier gets its own virtual clock, which limits that tier's rate to a fraction of the overall shaped rate, to discourage trying to game the priority mechanism. CAKE defaults to a simple, three-tier

[PATCH net-next v12 7/7] sch_cake: Conditionally split GSO segments

2018-05-16 Thread Toke Høiland-Jørgensen
At lower bandwidths, the transmission time of a single GSO segment can add an unacceptable amount of latency due to HOL blocking. Furthermore, with a software shaper, any tuning mechanism employed by the kernel to control the maximum size of GSO segments is thrown off by the artificial limit on ban

[PATCH net-next v12 6/7] sch_cake: Add overhead compensation support to the rate shaper

2018-05-16 Thread Toke Høiland-Jørgensen
This commit adds configurable overhead compensation support to the rate shaper. With this feature, userspace can configure the actual bottleneck link overhead and encapsulation mode used, which will be used by the shaper to calculate the precise duration of each packet on the wire. This feature is

[PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

2018-05-16 Thread Toke Høiland-Jørgensen
The ACK filter is an optional feature of CAKE which is designed to improve performance on links with very asymmetrical rate limits. On such links (which are unfortunately quite prevalent, especially for DSL and cable subscribers), the downstream throughput can be limited by the number of ACKs capab

[PATCH net-next v12 4/7] sch_cake: Add NAT awareness to packet classifier

2018-05-16 Thread Toke Høiland-Jørgensen
When CAKE is deployed on a gateway that also performs NAT (which is a common deployment mode), the host fairness mechanism cannot distinguish internal hosts from each other, and so fails to work correctly. To fix this, we add an optional NAT awareness mode, which will query the kernel conntrack me

[PATCH net-next v12 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

2018-05-16 Thread Toke Høiland-Jørgensen
sch_cake targets the home router use case and is intended to squeeze the most bandwidth and latency out of even the slowest ISP links and routers, while presenting an API simple enough that even an ISP can configure it. Example of use on a cable ISP uplink: tc qdisc add dev eth0 cake bandwidth 20

[PATCH net-next v12 0/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

2018-05-16 Thread Toke Høiland-Jørgensen
This patch series adds the CAKE qdisc, and has been split up to ease review. I have attempted to split out each configurable feature into its own patch. The first commit adds the base shaper and packet scheduler, while subsequent commits add the optional features. The full userspace API and most d

[PATCH net-next v12 2/7] sch_cake: Add ingress mode

2018-05-16 Thread Toke Høiland-Jørgensen
The ingress mode is meant to be enabled when CAKE runs downlink of the actual bottleneck (such as on an IFB device). The mode changes the shaper to also account dropped packets to the shaped rate, as these have already traversed the bottleneck. Enabling ingress mode will also tune the AQM to alway

[PATCH] bpf: add __printf verification to bpf_verifier_vlog

2018-05-16 Thread Mathieu Malaterre
__printf is useful to verify format and arguments. ‘bpf_verifier_vlog’ function is used twice in verifier.c in both cases the caller function already uses the __printf gcc attribute. Remove the following warning, triggered with W=1: kernel/bpf/verifier.c:176:2: warning: function might be possib

Re: [PATCH net-next v2 2/2] drivers: net: Remove device_node checks with of_mdiobus_register()

2018-05-16 Thread Sergei Shtylyov
Hello! On 05/16/2018 02:56 AM, Florian Fainelli wrote: > A number of drivers have the following pattern: > > if (np) > of_mdiobus_register() > else > mdiobus_register() > > which the implementation of of_mdiobus_register() now takes care of. > Remove that pattern in drivers that str

Re: [PATCH net-next 3/3] udp: only use paged allocation with scatter-gather

2018-05-16 Thread Willem de Bruijn
On Tue, May 15, 2018 at 7:57 PM, Willem de Bruijn wrote: > On Tue, May 15, 2018 at 4:04 PM, Willem de Bruijn > wrote: >> On Tue, May 15, 2018 at 10:14 AM, Willem de Bruijn >> wrote: >>> On Mon, May 14, 2018 at 7:45 PM, Eric Dumazet >>> wrote: On 05/14/2018 04:30 PM, Willem de Br

Re: [PATCH bpf-next] samples/bpf: Decrement ttl in fib forwarding example

2018-05-16 Thread Daniel Borkmann
On 05/16/2018 01:20 AM, David Ahern wrote: > Only consider forwarding packets if ttl in received packet is > 1 and > decrement ttl before handing off to bpf_redirect_map. > > Signed-off-by: David Ahern Looks good, applied to bpf-next, thanks David!

Re: [PATCH bpf-next v6 2/4] bpf: sockmap, add hash map support

2018-05-16 Thread Daniel Borkmann
On 05/15/2018 11:09 PM, Y Song wrote: > On Tue, May 15, 2018 at 12:01 PM, Daniel Borkmann > wrote: >> On 05/14/2018 07:00 PM, John Fastabend wrote: [...] >>> enum bpf_prog_type { >>> @@ -1855,6 +1856,52 @@ struct bpf_stack_build_id { >>> * Egress device index on success, 0 if packe

Re: [RFC bpf-next 00/11] Add socket lookup support

2018-05-16 Thread Alexei Starovoitov
On Wed, May 16, 2018 at 12:05:06PM -0700, Joe Stringer wrote: > > > > A few open points: > > * Currently, the lookup interface only returns either a valid socket or a > > NULL > > pointer. This means that if there is any kind of issue with the tuple, > > such > > as it provides an unsupported

[PATCH 3/3] sh_eth: add R8A77980 support

2018-05-16 Thread Sergei Shtylyov
Finally, add support for the DT probing of the R-Car V3H (AKA R8A77980) -- it's the only R-Car gen3 SoC having the GEther controller -- others have only EtherAVB... Based on the original (and large) patch by Vladimir Barinov. Signed-off-by: Vladimir Barinov Signed-off-by: Sergei Shtylyov ---

  1   2   3   4   >