[PATCH] net: aquantia: Fix an error handling path in 'aq_pci_probe()'

2018-05-07 Thread Christophe JAILLET
The position of 2 labels should be swapped in order to release resources in the correct order and avoid leaks. Fixes: 23ee07ad3c2f ("net: aquantia: Cleanup pci functions module") Signed-off-by: Christophe JAILLET --- The order of 'pci_release_regions()' and 'free_netdev()' is in reverse order in

Re: [PATCH] net: 8390: Fix possible data races in __ei_get_stats

2018-05-07 Thread Jia-Ju Bai
On 2018/5/8 13:04, Eric Dumazet wrote: On 05/07/2018 07:16 PM, Jia-Ju Bai wrote: Yes, "&dev->stats" will not change, because it is a fixed address. But the field data in "dev->stats" is changed (rx_frame_errors, rx_crc_errors and rx_missed_errors). So if the driver returns "&dev->stats" wit

Re: [RFC v3 4/5] virtio_ring: add event idx support in packed ring

2018-05-07 Thread Tiwei Bie
On Tue, May 08, 2018 at 01:40:40PM +0800, Jason Wang wrote: > On 2018年05月08日 11:05, Jason Wang wrote: > > > > > > Because in virtqueue_enable_cb_delayed(), we may set an > > > event_off which is bigger than new and both of them have > > > wrapped. And in this case, although new is smaller than > >

Re: [PATCH net] stmmac: fix reception of 802.1ad Ethernet tagged frames

2018-05-07 Thread Toshiaki Makita
On 2018/05/08 15:01, Elad Nachman wrote: > stmmac reception handler calls stmmac_rx_vlan() to strip the vlan before > calling napi_gro_receive(). > > The function assumes VLAN tagged frames are always tagged with 802.1Q > protocol, > and assigns ETH_P_8021Q to the skb by hard-coding the paramete

Re: [RFC/PATCH] Add a socketoption IPV6_MULTICAST_ALL analogue to the IPV4 version

2018-05-07 Thread Andre Naujoks
On 08.05.2018 08:31, 吉藤英明 wrote: > Hi, > > 2018-05-08 15:03 GMT+09:00 Andre Naujoks : >> On 11.04.2018 13:02, Andre Naujoks wrote: >>> Hi. >> >> Hi again. >> >> Since it has been a month now, I'd like to send a little "ping" on this >> subject. >> >> Is anything wrong with this? Or was it just ba

Re: [RFC/PATCH] Add a socketoption IPV6_MULTICAST_ALL analogue to the IPV4 version

2018-05-07 Thread 吉藤英明
Hi, 2018-05-08 15:03 GMT+09:00 Andre Naujoks : > On 11.04.2018 13:02, Andre Naujoks wrote: >> Hi. > > Hi again. > > Since it has been a month now, I'd like to send a little "ping" on this > subject. > > Is anything wrong with this? Or was it just bad timing? I'm just curious... What kind of beha

Re: BUG: spinlock bad magic in tun_do_read

2018-05-07 Thread Eric Dumazet
On 05/07/2018 10:54 PM, Cong Wang wrote: > On Mon, May 7, 2018 at 10:27 PM, syzbot > wrote: >> Hello, >> >> syzbot found the following crash on: >> >> HEAD commit:75bc37fefc44 Linux 4.17-rc4 >> git tree: upstream >> console output: https://syzkaller.appspot.com/x/log.txt?x=1162c6978000

Re: [RFC/PATCH] Add a socketoption IPV6_MULTICAST_ALL analogue to the IPV4 version

2018-05-07 Thread Andre Naujoks
On 11.04.2018 13:02, Andre Naujoks wrote: > Hi. Hi again. Since it has been a month now, I'd like to send a little "ping" on this subject. Is anything wrong with this? Or was it just bad timing? Regards Andre > > I was running into a problem, when trying to join multiple multicast groups >

[PATCH net] stmmac: fix reception of 802.1ad Ethernet tagged frames

2018-05-07 Thread Elad Nachman
stmmac reception handler calls stmmac_rx_vlan() to strip the vlan before calling napi_gro_receive(). The function assumes VLAN tagged frames are always tagged with 802.1Q protocol, and assigns ETH_P_8021Q to the skb by hard-coding the parameter on call to __vlan_hwaccel_put_tag() . This causes

Re: BUG: spinlock bad magic in tun_do_read

2018-05-07 Thread Cong Wang
On Mon, May 7, 2018 at 10:27 PM, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:75bc37fefc44 Linux 4.17-rc4 > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=1162c69780 > kernel config: https://syzkaller.appspot.com/x/.

Re: [PATCH] net/9p: correct some comment errors in 9p file system code

2018-05-07 Thread Sun Lianwen
On 05/08/2018 12:51 PM, Randy Dunlap wrote: > On 05/07/2018 06:49 PM, Sun Lianwen wrote: >> There are follow comment errors: >> 1 The function name is wrong in p9_release_pages() comment. >> 2 The function name and variable name is wrong in p9_poll_workfn() comment. >> 3 There is no variable dm_m

Re: [RFC v3 4/5] virtio_ring: add event idx support in packed ring

2018-05-07 Thread Jason Wang
On 2018年05月08日 11:05, Jason Wang wrote: Because in virtqueue_enable_cb_delayed(), we may set an event_off which is bigger than new and both of them have wrapped. And in this case, although new is smaller than event_off (i.e. the third param -- old), new shouldn't add vq->num, and actually we a

BUG: spinlock bad magic in tun_do_read

2018-05-07 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:75bc37fefc44 Linux 4.17-rc4 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1162c69780 kernel config: https://syzkaller.appspot.com/x/.config?x=31f4b3733894ef79 dashboard link: https://syzkaller.a

Re: [PATCH net-next] net:sched: add gkprio scheduler

2018-05-07 Thread Cong Wang
On Mon, May 7, 2018 at 2:36 AM, Nishanth Devarajan wrote: > net/sched: add gkprio scheduler > > Gkprio (Gatekeeper Priority Queue) is a queueing discipline that prioritizes > IPv4 and IPv6 packets accordingly to their DSCP field. Although Gkprio can be > employed in any QoS scenario in which a hig

Re: [PATCH] net: 8390: Fix possible data races in __ei_get_stats

2018-05-07 Thread Eric Dumazet
On 05/07/2018 07:16 PM, Jia-Ju Bai wrote: > Yes, "&dev->stats" will not change, because it is a fixed address. > But the field data in "dev->stats" is changed (rx_frame_errors, rx_crc_errors > and rx_missed_errors). > So if the driver returns "&dev->stats" without lock protection (like on line

Re: [PATCH] net/9p: correct some comment errors in 9p file system code

2018-05-07 Thread Randy Dunlap
On 05/07/2018 06:49 PM, Sun Lianwen wrote: > There are follow comment errors: > 1 The function name is wrong in p9_release_pages() comment. > 2 The function name and variable name is wrong in p9_poll_workfn() comment. > 3 There is no variable dm_mr and lkey in struct p9_trans_rdma. > 4 The function

Re: [Bug 199643] New: UBSAN: Undefined behaviour in ./include/net/route.h:240:2

2018-05-07 Thread David Miller
From: Stephen Hemminger Date: Mon, 7 May 2018 10:34:00 -0700 > Subject: [Bug 199643] New: UBSAN: Undefined behaviour in > ./include/net/route.h:240:2 That's an empty line in both of my trees.

Re: [PATCH net-next v8 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

2018-05-07 Thread Cong Wang
On Mon, May 7, 2018 at 11:37 AM, Toke Høiland-Jørgensen wrote: > Cong Wang writes: > >> On Fri, May 4, 2018 at 12:10 PM, Toke Høiland-Jørgensen wrote: >>> Thank you for the review! A few comments below, I'll fix the rest. >>> [...] So sch_cake doesn't accept normal tc filters? Is

Re: [PATCH net] llc: better deal with too small mtu

2018-05-07 Thread David Miller
From: Eric Dumazet Date: Mon, 7 May 2018 09:02:25 -0700 > syzbot loves to set very small mtu on devices, since it brings joy. > We must make llc_ui_sendmsg() fool proof. This thing is just too smart for it's own good :) > usercopy: Kernel memory overwrite attempt detected to wrapped address (o

Re: [net-next 0/6][pull request] 100GbE Intel Wired LAN Driver Updates 2018-05-07

2018-05-07 Thread David Miller
From: Jeff Kirsher Date: Mon, 7 May 2018 07:45:15 -0700 > git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue 100GbE Hmmm... [davem@localhost net-next]$ git pull --no-ff git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue 100GbE >From git://git.kernel.org/pub/scm

Re: [PATCH net-next] net-next/hinic: add pci device ids for 25ge and 100ge card

2018-05-07 Thread David Miller
From: Zhao Chen Date: Mon, 7 May 2018 09:21:57 -0400 > This patch adds PCI device IDs to support 25GE and 100GE card: > > 1. Add device id 0x0201 for HINIC 100GE dual port card. > 2. Add device id 0x0200 for HINIC 25GE dual port card. > 3. Macro of device id 0x1822 is modified for HINIC 25GE qua

Re: [PATCH net 0/2] Aquantia various patches 2018-05

2018-05-07 Thread David Miller
From: Igor Russkikh Date: Mon, 7 May 2018 16:10:37 +0300 > These are two patches covering issues found during test cycles: > > First is that driver should declare valid vlan_features > Second fix is about correct allocation of MSI interrupts on some systems. Series applied, thank you.

Re: [PATCH] trivial: fix inconsistent help texts

2018-05-07 Thread David Miller
From: Georg Hofmann Date: Mon, 7 May 2018 14:03:18 +0200 > This patch removes "experimental" from the help text where depends on > CONFIG_EXPERIMENTAL was already removed. > > Signed-off-by: Georg Hofmann Applied.

Re: [PATCH net] MAINTAINERS: Update the 3c59x network driver entry

2018-05-07 Thread David Miller
From: Steffen Klassert Date: Mon, 7 May 2018 12:39:30 +0200 > Replace my old E-Mail address with a working one. > While at it, change the maintainance status to > 'Odd Fixes'. I'm still around with some knowledge, > but don't actively maintain it anymore. > > Signed-off-by: Steffen Klassert Ap

Re: [PATCH net-next] flow_dissector: do not rely on implicit casts

2018-05-07 Thread David Miller
From: Paolo Abeni Date: Mon, 7 May 2018 12:06:03 +0200 > This change fixes a couple of type mismatch reported by the sparse > tool, explicitly using the requested type for the offending arguments. > > Signed-off-by: Paolo Abeni Applied, thank you.

Re: pull request (net-next): ipsec-next 2018-05-07

2018-05-07 Thread David Miller
From: Steffen Klassert Date: Mon, 7 May 2018 11:01:11 +0200 > 1) Add selftests for the xfrm commands. >From Shannon Nelson. > > 2) Enable hardware checksum offload for ESP encapsulated >UDP packets if the hardware supports this. >From Jacek Kalwas. > > 3) Remove VLA usage in __xfrm6

Re: pull request (net): ipsec 2018-05-07

2018-05-07 Thread David Miller
From: Steffen Klassert Date: Mon, 7 May 2018 10:43:20 +0200 > 1) Always verify length of provided sadb_key to fix a >slab-out-of-bounds read in pfkey_add. From Kevin Easton. > > 2) Make sure that all states are really deleted >before we check that the state lists are empty. >Otherwis

Re: [PATCH net-next 0/2] net/ipv6 misc

2018-05-07 Thread David Miller
From: Tariq Toukan Date: Mon, 7 May 2018 10:45:25 +0300 > This patchset contains two patches for net/ipv6. > > Patch 1 is a trivial typo fix in documentation. > Patch 2 by Eran is a re-spin. It adds GRO support for IPv6 GRE tunnel, > this significantly improves performance in case GRO in native

Re: [PATCH net] net/tls: Fix connection stall on partial tls record

2018-05-07 Thread David Miller
From: Andre Tomt Date: Mon, 7 May 2018 04:24:39 +0200 > In the case of writing a partial tls record we forgot to clear the > ctx->in_tcp_sendpages flag, causing some connections to stall. > > Fixes: c212d2c7fc47 ("net/tls: Don't recursively call push_record during > tls_write_space callbacks")

Re: [PATCH 8/9] net: flow_dissector: fix typo 'can by' to 'can be'

2018-05-07 Thread David Miller
From: Wolfram Sang Date: Sun, 6 May 2018 13:23:52 +0200 > Signed-off-by: Wolfram Sang Applied.

Re: [PATCH net-next 0/4] qed*: Add support for new multi partitioning modes.

2018-05-07 Thread David Miller
From: Sudarsana Reddy Kalluru Date: Sat, 5 May 2018 18:42:58 -0700 > From: Sudarsana Reddy Kalluru > > The patch series simplifies the multi function (MF) mode implementation of > qed/qede drivers, and adds support for new MF modes. > > Please consider applying it to net-next branch. Series

Re: [PATCH net] net: dsa: mv88e6xxx: Fix PHY interrupts by parameterising PHY base address

2018-05-07 Thread David Miller
From: Andrew Lunn Date: Sat, 5 May 2018 20:58:22 +0200 > Most of the mv88e6xxx switches have the PHYs at address 0, 1, 2, ... > The 6341 however has the PHYs at 0x10, 0x11, 0x12. Add a parameter to > the info structure for this base address. > > Testing of 6f88284f3bd7 ("net: dsa: mv88e6xxx: Ad

Re: [PATCH net] tls: fix use after free in tls_sk_proto_close

2018-05-07 Thread David Miller
From: Eric Dumazet Date: Sat, 5 May 2018 08:35:04 -0700 > syzbot reported a use-after-free in tls_sk_proto_close > > Add a boolean value to cleanup a bit this function. ... > Fixes: dd0bed1665d6 ("tls: support for Inline tls record") > Signed-off-by: Eric Dumazet > Cc: Atul Gupta > Cc: Steve

Re: [PATCHv2 net] sctp: delay the authentication for the duplicated cookie-echo chunk

2018-05-07 Thread David Miller
From: Xin Long Date: Sat, 5 May 2018 14:59:47 +0800 > Now sctp only delays the authentication for the normal cookie-echo > chunk by setting chunk->auth_chunk in sctp_endpoint_bh_rcv(). But > for the duplicated one with auth, in sctp_assoc_bh_rcv(), it does > authentication first based on the old

Re: [PATCH] net/9p: correct the variable name in v9fs_get_trans_by_name() comment

2018-05-07 Thread David Miller
From: Sun Lianwen Date: Sat, 5 May 2018 11:29:16 +0800 > The v9fs_get_trans_by_name(char *s) variable name is not "name" but "s". > > Signed-off-by: Sun Lianwen Applied.

Re: [PATCH net-next] vlan: correct the file path in vlan_dev_change_flags() comment

2018-05-07 Thread David Miller
From: Sun Lianwen Date: Sat, 5 May 2018 09:08:18 +0800 > The vlan_flags enum is defined in include/uapi/linux/if_vlan.h file. > not in include/linux/if_vlan.h file. > > Signed-off-by: Sun Lianwen Applied.

Re: pull-request: bpf-next 2018-05-05

2018-05-07 Thread David Miller
From: Daniel Borkmann Date: Sat, 5 May 2018 02:25:47 +0200 > The following pull-request contains BPF updates for your *net-next* tree. > > The main changes are: ... > Please consider pulling these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git Pulled. > Th

Re: [PATCH net] Added support for 802.1ad Q in Q Ethernet tagged frames

2018-05-07 Thread David Miller
From: Elad Nachman Date: Fri, 4 May 2018 21:25:47 +0300 > stmmac reception handler calls stmmac_rx_vlan() to strip the vlan before > calling napi_gro_receive(). Please fix your Subject line. A subject line should have an appropriate subsystem prefix after the "[ ... ]" clause, in this case an

Re: [PATCH 1/2] net: nixge: Fix error path for obtaining mac address

2018-05-07 Thread David Miller
From: Moritz Fischer Date: Fri, 4 May 2018 10:18:33 -0700 > Fix issue where nixge_get_nvmem_address() returns a non-NULL > return value on a failed nvmem_cell_get() that causes an invalid > access when error value encoded in pointer is dereferenced. > > Furthermore ensure that buffer allocated

Re: [PATCH V2 net-next] liquidio: support use of ethtool to set link speed of CN23XX-225 cards

2018-05-07 Thread David Miller
From: Felix Manlunas Date: Fri, 4 May 2018 11:07:19 -0700 > From: Weilin Chang > > Support setting the link speed of CN23XX-225 cards (which can do 25Gbps or > 10Gbps) via ethtool_ops.set_link_ksettings. > > Also fix the function assigned to ethtool_ops.get_link_ksettings to use the > new link

Re: [PATCH 2/2] net: nixge: Address compiler warnings about signedness

2018-05-07 Thread David Miller
From: Moritz Fischer Date: Fri, 4 May 2018 10:18:34 -0700 > Fixes the following warnings: > warning: pointer targets in passing argument 1 of > ‘is_valid_ether_addr’ differ in signedness [-Wpointer-sign] > if (mac_addr && is_valid_ether_addr(mac_addr)) { >

Re: [PATCH] selftests: net: use TEST_PROGS_EXTENDED

2018-05-07 Thread David Miller
From: Anders Roxell Date: Fri, 4 May 2018 18:47:25 +0200 > When a script file that isn't generated uses the variable > TEST_GEN_PROGS_EXTENDED and a 'make -C tools/testing/selftests clean' is > performed the script file gets removed and git shows the file as > deleted. For script files that isn'

Re: 3c59x patches and the removal of an unused function

2018-05-07 Thread David Miller
From: Sebastian Andrzej Siewior Date: Fri, 4 May 2018 17:17:45 +0200 > The first patch removes an unused function. The goal of remaining three > patches is to get rid of the local_irq_save() usage in the driver which > benefits -RT. Series applied, thanks.

Re: [PATCH] selftests: net: add udpgso* to TEST_GEN_FILES

2018-05-07 Thread David Miller
From: Anders Roxell Date: Fri, 4 May 2018 11:17:25 +0200 > The generated files udpgso* shouldn't be part of TEST_PROGS, they are > used by udpgso.sh and udpgsp_bench.sh. They should be added to the > TEST_GEN_FILES to get installed without being added to the main > run_kselftest.sh script. > >

Re: [PATCH net-next v2 00/13] net: mvpp2: phylink conversion

2018-05-07 Thread David Miller
From: Antoine Tenart Date: Fri, 4 May 2018 15:56:30 +0200 > Also as the SFP cages on both DB boards can be considered as non-wired, > the SFP code was reworked to really support when some pins of the SFP > cage aren't described in the device tree. Also a warning was added when > no Tx disable pi

Re: [RFC v3 4/5] virtio_ring: add event idx support in packed ring

2018-05-07 Thread Jason Wang
On 2018年05月03日 21:54, Tiwei Bie wrote: On Thu, May 03, 2018 at 03:25:29PM +0800, Jason Wang wrote: On 2018年05月03日 10:09, Tiwei Bie wrote: So how about we use the straightforward way then? You mean we do new += vq->vring_packed.num instead of event_idx -= vq->vring_packed.num before calling v

Re: [PATCH] net: 8390: Fix possible data races in __ei_get_stats

2018-05-07 Thread Jia-Ju Bai
On 2018/5/8 9:56, Eric Dumazet wrote: On 05/07/2018 05:51 PM, Jia-Ju Bai wrote: On 2018/5/7 22:15, Eric Dumazet wrote: On 05/07/2018 07:08 AM, Jia-Ju Bai wrote: The write operations to "dev->stats" are protected by the spinlock on line 862-864, but the read operations to this data on line

Re: [PATCH] net: 8390: Fix possible data races in __ei_get_stats

2018-05-07 Thread Eric Dumazet
On 05/07/2018 05:51 PM, Jia-Ju Bai wrote: > > > On 2018/5/7 22:15, Eric Dumazet wrote: >> >> On 05/07/2018 07:08 AM, Jia-Ju Bai wrote: >>> The write operations to "dev->stats" are protected by >>> the spinlock on line 862-864, but the read operations to >>> this data on line 858 and 867 are not

[PATCH] net/9p: correct some comment errors in 9p file system code

2018-05-07 Thread Sun Lianwen
There are follow comment errors: 1 The function name is wrong in p9_release_pages() comment. 2 The function name and variable name is wrong in p9_poll_workfn() comment. 3 There is no variable dm_mr and lkey in struct p9_trans_rdma. 4 The function name is wrong in rdma_create_trans() comment. 5 Ther

Re: [PATCH] net/9p: correct some comment errors in 9p file system code

2018-05-07 Thread Randy Dunlap
On 05/07/2018 05:45 PM, Sun Lianwen wrote: > There are follow comment errors: > 1 The function name is wrong in p9_release_pages() comment. > 2 The function name and variable name is wrong in p9_poll_workfn() comment. > 3 There is no variable dm_mr and lkey in struct p9_trans_rdma. > 4 The function

Re: [PATCH 2/8] rhashtable: remove nulls_base and related code.

2018-05-07 Thread NeilBrown
On Mon, May 07 2018, Herbert Xu wrote: > On Sun, May 06, 2018 at 07:37:49AM +1000, NeilBrown wrote: >> >> I can see no evidence that this is required for anything, as it isn't >> use and I'm fairly sure that in it's current form - it cannot be used. > > Search for nulls in net/ipv4. This is defi

Re: [PATCH 6/8] rhashtable: further improve stability of rhashtable_walk

2018-05-07 Thread NeilBrown
On Mon, May 07 2018, Herbert Xu wrote: > On Sun, May 06, 2018 at 07:50:54AM +1000, NeilBrown wrote: >> >> Do we? How could we fix it for both rhashtable and rhltable? > > Well I suggested earlier to insert the walker object into the > hash table, which would be applicable regardless of whether it

Re: [PATCH] net: 8390: Fix possible data races in __ei_get_stats

2018-05-07 Thread Jia-Ju Bai
On 2018/5/7 22:15, Eric Dumazet wrote: On 05/07/2018 07:08 AM, Jia-Ju Bai wrote: The write operations to "dev->stats" are protected by the spinlock on line 862-864, but the read operations to this data on line 858 and 867 are not protected by the spinlock. Thus, there may exist data races for

[PATCH] net/9p: correct some comment errors in 9p file system code

2018-05-07 Thread Sun Lianwen
There are follow comment errors: 1 The function name is wrong in p9_release_pages() comment. 2 The function name and variable name is wrong in p9_poll_workfn() comment. 3 There is no variable dm_mr and lkey in struct p9_trans_rdma. 4 The function name is wrong in rdma_create_trans() comment. 5 Ther

linux-next: manual merge of the bpf-next tree with the s390 tree

2018-05-07 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the bpf-next tree got a conflict in: arch/s390/net/bpf_jit.S between commit: de5cb6eb514e ("s390: use expoline thunks in the BPF JIT") from the s390 tree and commit: e1cf4befa297 ("bpf, s390x: remove ld_abs/ld_ind") from the bpf-next tree. I fixed i

Re: [PATCH net-next v10 2/4] net: Introduce generic failover module

2018-05-07 Thread Samudrala, Sridhar
On 5/7/2018 4:53 PM, Stephen Hemminger wrote: On Mon, 7 May 2018 15:10:44 -0700 Sridhar Samudrala wrote: +static struct net_device *net_failover_get_bymac(u8 *mac, +struct net_failover_ops **ops) +{ + struct net_device *failover_dev; +

Re: [PATCH 8/8] rhashtable: don't hold lock on first table throughout insertion.

2018-05-07 Thread NeilBrown
On Mon, May 07 2018, Herbert Xu wrote: > On Mon, May 07, 2018 at 08:24:41AM +1000, NeilBrown wrote: >> >> This is true, but I don't see how it is relevant. >> At some point, each thread will find that the table they have just >> locked for their search key, has a NULL 'future_tbl' pointer. >> At t

Re: [PATCH net-next v10 2/4] net: Introduce generic failover module

2018-05-07 Thread Samudrala, Sridhar
On 5/7/2018 4:59 PM, Stephen Hemminger wrote: On Mon, 7 May 2018 15:10:44 -0700 Sridhar Samudrala wrote: + if (netif_running(failover_dev)) { + err = dev_open(slave_dev); + if (err && (err != -EBUSY)) { + netdev_err(failover_dev, "Openin

Re: [PATCH net-next v10 2/4] net: Introduce generic failover module

2018-05-07 Thread Stephen Hemminger
On Mon, 7 May 2018 15:10:44 -0700 Sridhar Samudrala wrote: > + if (netif_running(failover_dev)) { > + err = dev_open(slave_dev); > + if (err && (err != -EBUSY)) { > + netdev_err(failover_dev, "Opening slave %s failed > err:%d\n", > +

[for-next 3/6] net/mlx5: Refactor num of blocks in mailbox calculation

2018-05-07 Thread Saeed Mahameed
From: Moshe Shemesh Get the logic that calculates the number of blocks in a command mailbox into a dedicated function. Signed-off-by: Moshe Shemesh Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 24 1 file changed, 12 insertions(+),

[for-next 5/6] net/mlx5: Cleanup unused field in Work Queue parameters

2018-05-07 Thread Saeed Mahameed
From: Tariq Toukan Remove the 'linear' field from struct mlx5_wq_param. It is redundant, set but never read. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 1 - drivers/net/ethernet/mellanox/mlx5/core/wq.h | 1 - 2 files

[for-next 6/6] net/mlx5: fix spelling mistake: "modfiy" -> "modify"

2018-05-07 Thread Saeed Mahameed
From: Colin Ian King Trivial fix to spelling mistake in netdev_warn warning message Signed-off-by: Colin Ian King Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellan

[for-next 4/6] net/mlx5: Fix dump_command mailbox length printed

2018-05-07 Thread Saeed Mahameed
From: Moshe Shemesh Dump command mailbox length printed was correct only if data_only flag was set. For the case that data_only flag was clear the offset to stop printing at was wrong and so the buffer printed was too short. Changed the print loop to stop according to number of buffers in mailbox

[pull request][for-next 0/6] Mellanox, mlx5 updates 2018-05-07

2018-05-07 Thread Saeed Mahameed
Hi Dave & Doug, This pull request includes misc updates and cleanups for mlx5 core driver for both net and rdma next branches, for more information please see tag log below. Please pull and let me know if there's any problem. Thanks, Saeed. --- The following changes since commit 60cc43fc888428

Re: [PATCH net-next v10 2/4] net: Introduce generic failover module

2018-05-07 Thread Stephen Hemminger
On Mon, 7 May 2018 15:10:44 -0700 Sridhar Samudrala wrote: > +static struct net_device *net_failover_get_bymac(u8 *mac, > + struct net_failover_ops **ops) > +{ > + struct net_device *failover_dev; > + struct net_failover *failover; > + > +

[for-next 2/6] net/mlx5: Decrease level of prints about non-existent MKEY

2018-05-07 Thread Saeed Mahameed
From: Leon Romanovsky User-controlled application can cause multiple prints as below to flood dmesg. Since knowledge of failed MKey release is important for debug, let's decrease its level to debug. mlx5_core :00:04.0: mlx5_core_destroy_mkey:127:(pid 2352): failed radix tree delete of mkey 0

[for-next 1/6] net/mlx5: remove some extraneous spaces in indentations

2018-05-07 Thread Saeed Mahameed
From: Colin Ian King There are several lines where there is an extraneous space causing indentation misalignment. Remove them. Cleans up Cocconelle warnings: ./drivers/net/ethernet/mellanox/mlx5/core/qp.c:409:3-18: code aligned with following code on line 410 ./drivers/net/ethernet/mellanox/mlx

Re: [PATCH net-next v10 2/4] net: Introduce generic failover module

2018-05-07 Thread Stephen Hemminger
On Mon, 7 May 2018 15:10:44 -0700 Sridhar Samudrala wrote: > This provides a generic interface for paravirtual drivers to listen > for netdev register/unregister/link change events from pci ethernet > devices with the same MAC and takeover their datapath. The notifier and > event handling code i

[PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-05-07 Thread Sridhar Samudrala
This feature bit can be used by hypervisor to indicate virtio_net device to act as a standby for another device with the same MAC address. I tested this with a small change to the patch to mark the STANDBY feature 'true' by default as i am using libvirt to start the VMs. Is there a way to pass th

Re: [PATCH net-next v10 2/4] net: Introduce generic failover module

2018-05-07 Thread Randy Dunlap
Hi, On 05/07/2018 03:10 PM, Sridhar Samudrala wrote: > > Signed-off-by: Sridhar Samudrala > --- > MAINTAINERS|7 + > include/linux/netdevice.h | 16 + > include/net/net_failover.h | 52 +++ > net/Kconfig| 10 + > net/core/Makefile |1 + >

Sensors Expo

2018-05-07 Thread gemma lavery
Hi, I have noticed that your company is exhibiting in Sensors Expo on JUN 26 - 28 2018. Would you be interested in the complete (B2B) contact information with email addresses of Engineers and Engineering Professionals? Let us know your target contacts that you would like t

Re: [PATCH bpf-next v3 3/6] bpf: Add IPv6 Segment Routing helpers

2018-05-07 Thread Mathieu Xhonneux
I'm not sure what would be the best approach here. These errors appear when CONFIG_IPV6=m and CONFIG_IPV6_SEG6_LWTUNNEL=y (which is bool and depends on IPv6, hence it is also modularized in this case), then IS_ENABLED(CONFIG_IPV6_SEG6_LWTUNNEL) returns true, even though the seg6_* symbols are not a

[PATCH v1 iproute2-next 3/3] rdma: update man pages

2018-05-07 Thread Steve Wise
Update the man pages for the resource attributes as well as the driver-specific attributes. Signed-off-by: Steve Wise --- man/man8/rdma-resource.8 | 29 ++--- man/man8/rdma.8 | 2 +- 2 files changed, 27 insertions(+), 4 deletions(-) diff --git a/man/man8/rdma-r

[PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-07 Thread Steve Wise
This enhancement allows printing rdma device-specific state, if provided by the kernel. This is done in a generic manner, so rdma tool doesn't need to know about the details of every type of rdma device. Driver attributes for a rdma resource are in the form of tuples, where the key is a string a

[PATCH v1 iproute2-next 0/3] RDMA tool driver-specific resource tracking

2018-05-07 Thread Steve Wise
Hello, This series enhances the iproute2 rdma tool to include displaying driver-specific resource attributes. It is the user-space part of the kernel driver resource tracking series that has been accepted for merging into linux-4.18 [1] If there are no additional review comments, it can now be m

[PATCH v1 iproute2-next 1/3] rdma: update rdma_netlink.h to get driver attrs

2018-05-07 Thread Steve Wise
Signed-off-by: Steve Wise --- rdma/include/uapi/rdma/rdma_netlink.h | 37 ++- 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/rdma/include/uapi/rdma/rdma_netlink.h b/rdma/include/uapi/rdma/rdma_netlink.h index 45474f1..40be0d8 100644 --- a/rdma/inclu

[PATCH net-next v10 4/4] netvsc: refactor notifier/event handling code to use the failover framework

2018-05-07 Thread Sridhar Samudrala
Use the registration/notification framework supported by the generic failover infrastructure. Signed-off-by: Sridhar Samudrala --- drivers/net/hyperv/Kconfig | 1 + drivers/net/hyperv/hyperv_net.h | 2 + drivers/net/hyperv/netvsc_drv.c | 134 +++- 3 f

[PATCH net-next v10 1/4] virtio_net: Introduce VIRTIO_NET_F_STANDBY feature bit

2018-05-07 Thread Sridhar Samudrala
This feature bit can be used by hypervisor to indicate virtio_net device to act as a standby for another device with the same MAC address. VIRTIO_NET_F_STANDBY is defined as bit 62 as it is a device feature bit. Signed-off-by: Sridhar Samudrala --- drivers/net/virtio_net.c| 2 +- includ

[PATCH net-next v10 3/4] virtio_net: Extend virtio to use VF datapath when available

2018-05-07 Thread Sridhar Samudrala
This patch enables virtio_net to switch over to a VF datapath when a VF netdev is present with the same MAC address. It allows live migration of a VM with a direct attached VF without the need to setup a bond/team between a VF and virtio net device in the guest. The hypervisor needs to unplug the

[PATCH net-next v10 2/4] net: Introduce generic failover module

2018-05-07 Thread Sridhar Samudrala
This provides a generic interface for paravirtual drivers to listen for netdev register/unregister/link change events from pci ethernet devices with the same MAC and takeover their datapath. The notifier and event handling code is based on the existing netvsc implementation. It exposes 2 sets of i

[PATCH net-next v10 0/4] Enable virtio_net to act as a standby for a passthru device

2018-05-07 Thread Sridhar Samudrala
The main motivation for this patch is to enable cloud service providers to provide an accelerated datapath to virtio-net enabled VMs in a transparent manner with no/minimal guest userspace changes. This also enables hypervisor controlled live migration to be supported with VMs that have direct att

Re: RTL8723BE performance regression

2018-05-07 Thread João Paulo Rechi Vita
On Tue, May 1, 2018 at 10:58 PM, Pkshih wrote: > On Wed, 2018-05-02 at 05:44 +, Pkshih wrote: >> >> > -Original Message- >> > From: João Paulo Rechi Vita [mailto:jprv...@gmail.com] >> > Sent: Wednesday, May 02, 2018 6:41 AM >> > To: Larry Finger >> > Cc: Steve deRosier; 莊彥宣; Pkshih; Bi

Re: The SO_BINDTODEVICE was set to the desired interface, but packets are received from all interfaces.

2018-05-07 Thread David Ahern
On 5/7/18 10:14 AM, Ben Greear wrote: > On 05/07/2018 03:19 AM, Damir Mansurov wrote: >> >> Greetings, >> >> After successful call of the setsockopt(SO_BINDTODEVICE) function to >> set data reception from only one interface, the data is still received >> from all interfaces. >> Function setsockopt(

Re: [ovs-dev] [PATCH] openvswitch: make vport_ops:send()'s return type consistent

2018-05-07 Thread Gregory Rose
On 4/24/2018 6:19 AM, Luc Van Oostenryck wrote: The method struct vport_ops:send() is defined as returning an 'netdev_tx_t', which is defined as a typedef for a bitwise type and otherwise used for the start_xmit() methods. However, most openvswitch drivers use for this method dev_queue_xmit() whi

Re: [ovs-dev] [PATCH] openvswitch: fix internal_dev_xmit()'s return type

2018-05-07 Thread Gregory Rose
On 4/24/2018 6:17 AM, Luc Van Oostenryck wrote: The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Ooste

Re: [net-next PATCH v3 4/6] udp: Partially unroll handling of first segment and last segment

2018-05-07 Thread Willem de Bruijn
On Mon, May 7, 2018 at 3:59 PM, Alexander Duyck wrote: > On Mon, May 7, 2018 at 12:54 PM, Willem de Bruijn > wrote: >> On Mon, May 7, 2018 at 2:57 PM, Willem de Bruijn >> wrote: >>> On Mon, May 7, 2018 at 2:08 PM, Alexander Duyck >>> wrote: From: Alexander Duyck This patch allow

Re: [net-next PATCH v3 0/6] UDP GSO Segmentation clean-ups

2018-05-07 Thread Alexander Duyck
On Mon, May 7, 2018 at 11:08 AM, Alexander Duyck wrote: > This patch set addresses a number of issues I found while sorting out > enabling UDP GSO Segmentation support for ixgbe/ixgbevf. Specifically there > were a number of issues related to the checksum and such that seemed to > cause either min

Re: [PATCH net-next v8 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-05-07 Thread David Miller
From: Rahul Lakkireddy Date: Wed, 2 May 2018 15:17:16 +0530 > This series of patches add new generic framework that enable device > drivers to collect device specific snapshot of the hardware/firmware > state of the underlying device in the crash recovery kernel. In crash > recovery kernel, the

Re: [net-next PATCH v3 4/6] udp: Partially unroll handling of first segment and last segment

2018-05-07 Thread Alexander Duyck
On Mon, May 7, 2018 at 12:54 PM, Willem de Bruijn wrote: > On Mon, May 7, 2018 at 2:57 PM, Willem de Bruijn > wrote: >> On Mon, May 7, 2018 at 2:08 PM, Alexander Duyck >> wrote: >>> From: Alexander Duyck >>> >>> This patch allows us to take care of unrolling the first segment and the >>> last s

Re: [net-next PATCH v3 4/6] udp: Partially unroll handling of first segment and last segment

2018-05-07 Thread Willem de Bruijn
On Mon, May 7, 2018 at 2:57 PM, Willem de Bruijn wrote: > On Mon, May 7, 2018 at 2:08 PM, Alexander Duyck > wrote: >> From: Alexander Duyck >> >> This patch allows us to take care of unrolling the first segment and the >> last segment of the loop for processing the segmented skb. Part of the >>

Re: [PATCH bpf-next v3 00/15] Introducing AF_XDP support

2018-05-07 Thread Björn Töpel
2018-05-07 15:09 GMT+02:00 Jesper Dangaard Brouer : > On Mon, 7 May 2018 11:13:58 +0200 > Magnus Karlsson wrote: > >> On Sat, May 5, 2018 at 2:34 AM, Alexei Starovoitov >> wrote: >> > On Fri, May 04, 2018 at 01:22:17PM +0200, Magnus Karlsson wrote: >> >> On Fri, May 4, 2018 at 1:38 AM, Alexei Sta

Re: [PATCH net] r8169: fix powering up RTL8168h

2018-05-07 Thread Andrew Lunn
On Mon, May 07, 2018 at 07:20:53PM +, ojab // wrote: > On Mon, May 7, 2018 at 7:11 PM, Heiner Kallweit wrote: > > Since commit a92a08499b1f "r8169: improve runtime pm in general and > > suspend unused ports" interfaces w/o link are runtime-suspended after > > 10s. On systems where drivers take

Re: [PATCH v2] net: dsa: drop some VLAs in switch.c

2018-05-07 Thread Andrew Lunn
> >> +++ b/include/net/dsa.h > >> @@ -256,6 +256,9 @@ struct dsa_switch { > >> /* Number of switch port queues */ > >> unsigned intnum_tx_queues; > >> > >> + unsigned long *bitmap; > >> + unsigned long _bitmap; > >> + > >> /* Dynamically all

Re: [PATCH net] r8169: fix powering up RTL8168h

2018-05-07 Thread ojab //
On Mon, May 7, 2018 at 7:11 PM, Heiner Kallweit wrote: > Since commit a92a08499b1f "r8169: improve runtime pm in general and > suspend unused ports" interfaces w/o link are runtime-suspended after > 10s. On systems where drivers take longer to load this can lead to the > situation that the interfa

[PATCH net-next] r8169: fix powering up RTL8168h

2018-05-07 Thread Heiner Kallweit
Since commit a92a08499b1f "r8169: improve runtime pm in general and suspend unused ports" interfaces w/o link are runtime-suspended after 10s. On systems where drivers take longer to load this can lead to the situation that the interface is runtime-suspended already when it's initially brought up.

[PATCH net] r8169: fix powering up RTL8168h

2018-05-07 Thread Heiner Kallweit
Since commit a92a08499b1f "r8169: improve runtime pm in general and suspend unused ports" interfaces w/o link are runtime-suspended after 10s. On systems where drivers take longer to load this can lead to the situation that the interface is runtime-suspended already when it's initially brought up.

Re: [PATCH v2] net: dsa: drop some VLAs in switch.c

2018-05-07 Thread Salvatore Mesoraca
2018-05-07 20:14 GMT+02:00 Florian Fainelli : > On 05/07/2018 08:23 AM, Salvatore Mesoraca wrote: >> We avoid 2 VLAs by using a pre-allocated field in dsa_switch. >> We also try to avoid dynamic allocation whenever possible. >> >> Link: >> http://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6

Re: [net-next PATCH v3 4/6] udp: Partially unroll handling of first segment and last segment

2018-05-07 Thread Willem de Bruijn
On Mon, May 7, 2018 at 2:08 PM, Alexander Duyck wrote: > From: Alexander Duyck > > This patch allows us to take care of unrolling the first segment and the > last segment of the loop for processing the segmented skb. Part of the > motivation for this is that it makes it easier to process the fact

Re: [PATCH v2 net-next 2/4] net: add skeleton of bpfilter kernel module

2018-05-07 Thread Luis R. Rodriguez
On Wed, May 02, 2018 at 09:36:02PM -0700, Alexei Starovoitov wrote: > bpfilter.ko consists of bpfilter_kern.c (normal kernel module code) > and user mode helper code that is embedded into bpfilter.ko > > The steps to build bpfilter.ko are the following: > - main.c is compiled by HOSTCC into the bp

Re: [net-next PATCH v3 3/6] udp: Do not pass checksum as a parameter to GSO segmentation

2018-05-07 Thread Willem de Bruijn
On Mon, May 7, 2018 at 2:08 PM, Alexander Duyck wrote: > From: Alexander Duyck > > This patch is meant to allow us to avoid having to recompute the checksum > from scratch and have it passed as a parameter. > > Instead of taking that approach we can take advantage of the fact that the > length th

  1   2   3   >