[PATCH] tipc: fix a potential missing-check bug

2018-04-30 Thread Wenwen Wang
In tipc_link_xmit(), the member field "len" of l->backlog[imp] must be less than the member field "limit" of l->backlog[imp] when imp is equal to TIPC_SYSTEM_IMPORTANCE. Otherwise, an error code, i.e., -ENOBUFS, is returned. This is enforced by the security check. However, at the end of tipc_link_x

Re: [PATCH] ipv6: Allow non-gateway ECMP for IPv6

2018-04-30 Thread David Ahern
On 4/30/18 3:15 PM, Thomas Winter wrote: > It is valid to have static routes where the nexthop > is an interface not an address such as tunnels. > For IPv4 it was possible to use ECMP on these routes > but not for IPv6. > > Signed-off-by: Thomas Winter > Cc: David Ahern > Cc: "David S. Miller"

Re: [PATCH net-next 0/4] net/smc: fixes 2018/04/30

2018-04-30 Thread David Miller
From: Ursula Braun Date: Mon, 30 Apr 2018 16:51:15 +0200 > From: Ursula Braun > > Dave, > > here are 4 smc patches for net-next covering different areas: >* link health check >* diagnostics for IPv6 smc sockets >* ioctl >* improvement for vlan determination You say "fixes" in

Re: [PATCH RFC 6/9] veth: Add ndo_xdp_xmit

2018-04-30 Thread Toshiaki Makita
On 2018/05/01 2:27, Jesper Dangaard Brouer wrote: > On Thu, 26 Apr 2018 19:52:40 +0900 > Toshiaki Makita wrote: > >> On 2018/04/26 5:24, Jesper Dangaard Brouer wrote: >>> On Tue, 24 Apr 2018 23:39:20 +0900 >>> Toshiaki Makita wrote: >>> +static int veth_xdp_xmit(struct net_device *dev, s

[PATCH net-next] udp: Complement partial checksum for GSO packet

2018-04-30 Thread Sean Tranchetti
Using the udp_v4_check() function to calculate the pseudo header for the newly segmented UDP packets results in assigning the complement of the value to the UDP header checksum field. Always undo the complement the partial checksum value in order to match the case where GSO is not used on the UDP

Re: [RFC net-next 0/5] Support for PHY test modes

2018-04-30 Thread Andrew Lunn
> Turning these tests on will typically result in the link partner > dropping the link with us, and the interface will be non-functional as > far as the data path is concerned (similar to an isolation mode). This > might warrant properly reporting that to user-space through e.g: a > private IFF_* v

Re: [RFC net-next 4/5] net: phy: Add support for IEEE standard test modes

2018-04-30 Thread Andrew Lunn
> +/* genphy_set_test - Make a PHY enter one of the standard IEEE defined > + * test modes > + * @phydev: the PHY device instance > + * @test: the desired test mode > + * @data: test specific data (none) > + * > + * This function makes the designated @phydev enter the desired standard > + * 100Base

Re: [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

2018-04-30 Thread Cong Wang
On Mon, Apr 30, 2018 at 2:27 PM, Dave Taht wrote: > On Mon, Apr 30, 2018 at 2:21 PM, Cong Wang wrote: >> On Sun, Apr 29, 2018 at 2:34 PM, Toke Høiland-Jørgensen wrote: >>> sch_cake targets the home router use case and is intended to squeeze the >>> most bandwidth and latency out of even the slow

Re: [PATCH net-next 2/4] net/smc: ipv6 support for smc_diag.c

2018-04-30 Thread kbuild test robot
Hi Karsten, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Ursula-Braun/net-smc-periodic-testlink-support/20180501-045940 config: x86_64-randconfig-x016-201817 (attached as .config) compiler: gcc-7 (

[PATCH bpf-next 2/3] bpf: centre subprog information fields

2018-04-30 Thread Jiong Wang
It is better to centre all subprog information fields into one structure. This structure could later serve as function node in call graph. Signed-off-by: Jiong Wang --- include/linux/bpf_verifier.h | 9 --- kernel/bpf/verifier.c| 62 +++- 2 fi

[PATCH bpf-next 0/3] bpf: cleanups on managing subprog information

2018-04-30 Thread Jiong Wang
This patch set clean up some code logic related with managing subprog information. Part of the set are inspried by Edwin's code in his RFC: "bpf/verifier: subprog/func_call simplifications" but with clearer separation so it could be easier to review. - Path 1 unifies main prog and subprogs.

[PATCH bpf-next 3/3] bpf: add faked "ending" subprog

2018-04-30 Thread Jiong Wang
There are quite a few code snippet like the following in verifier: subprog_start = 0; if (env->subprog_cnt == cur_subprog + 1) subprog_end = insn_cnt; else subprog_end = env->subprog_info[cur_subprog + 1].start; The reason is there is no marker i

[PATCH bpf-next 1/3] bpf: unify main prog and subprog

2018-04-30 Thread Jiong Wang
Currently, verifier treat main prog and subprog differently. All subprogs detected are kept in env->subprog_starts while main prog is not kept there. Instead, main prog is implicitly defined as the prog start at 0. There is actually no difference between main prog and subprog, it is better to unif

Re: Request for stable 4.14.x inclusion: net: don't call update_pmtu unconditionally

2018-04-30 Thread Thomas Deutschmann
Hi, On 2018-04-30 20:22, Greg KH wrote: > The geneve hunk doesn't apply at all to the 4.14.y tree, so I think > someone has a messed up tree somewhere... > > I'll go look into this now. Mh? > $ git clone > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git > $ cd linux-sta

[PATCH RESEND] connector: add parent pid and tgid to coredump and exit events

2018-04-30 Thread Stefan Strogin
The intention is to get notified of process failures as soon as possible, before a possible core dumping (which could be very long) (e.g. in some process-manager). Coredump and exit process events are perfect for such use cases (see 2b5faa4c553f "connector: Added coredumping event to the process co

[PATCH net-next v3 2/2] openvswitch: Support conntrack zone limit

2018-04-30 Thread Yi-Hung Wei
Currently, nf_conntrack_max is used to limit the maximum number of conntrack entries in the conntrack table for every network namespace. For the VMs and containers that reside in the same namespace, they share the same conntrack table, and the total # of conntrack entries for all the VMs and contai

[PATCH net-next v3 0/2] openvswitch: Support conntrack zone limit

2018-04-30 Thread Yi-Hung Wei
Currently, nf_conntrack_max is used to limit the maximum number of conntrack entries in the conntrack table for every network namespace. For the VMs and containers that reside in the same namespace, they share the same conntrack table, and the total # of conntrack entries for all the VMs and contai

[PATCH net-next v3 1/2] openvswitch: Add conntrack limit netlink definition

2018-04-30 Thread Yi-Hung Wei
Define netlink messages and attributes to support user kernel communication that uses the conntrack limit feature. Signed-off-by: Yi-Hung Wei --- include/uapi/linux/openvswitch.h | 62 1 file changed, 62 insertions(+) diff --git a/include/uapi/linux/open

Re: [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

2018-04-30 Thread Dave Taht
On Mon, Apr 30, 2018 at 2:21 PM, Cong Wang wrote: > On Sun, Apr 29, 2018 at 2:34 PM, Toke Høiland-Jørgensen wrote: >> sch_cake targets the home router use case and is intended to squeeze the >> most bandwidth and latency out of even the slowest ISP links and routers, >> while presenting an API si

Re: [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

2018-04-30 Thread Cong Wang
On Sun, Apr 29, 2018 at 2:34 PM, Toke Høiland-Jørgensen wrote: > sch_cake targets the home router use case and is intended to squeeze the > most bandwidth and latency out of even the slowest ISP links and routers, > while presenting an API simple enough that even an ISP can configure it. > > Examp

[PATCH net-next] net: core: Inline netdev_features_size_check()

2018-04-30 Thread Florian Fainelli
We do not require this inline function to be used in multiple different locations, just inline it where it gets used in register_netdevice(). Suggested-by: David Miller Suggested-by: Stephen Hemminger Signed-off-by: Florian Fainelli --- include/linux/netdevice.h | 6 -- net/core/dev.c

[PATCH] ipv6: Allow non-gateway ECMP for IPv6

2018-04-30 Thread Thomas Winter
It is valid to have static routes where the nexthop is an interface not an address such as tunnels. For IPv4 it was possible to use ECMP on these routes but not for IPv6. Signed-off-by: Thomas Winter Cc: David Ahern Cc: "David S. Miller" Cc: Alexey Kuznetsov Cc: Hideaki YOSHIFUJI --- include

Proposal

2018-04-30 Thread Miss Zeliha Omer Faruk
Hello Greetings to you today i asked before but i did't get a response please i know this might come to you as a surprise because you do not know me personally i have a business proposal for our mutual benefit please let me know if you are interested. Best Regards, Esentepe Mahallesi Büy

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

2018-04-30 Thread Mikulas Patocka
On Mon, 30 Apr 2018, John Stoffel wrote: > > "Mikulas" == Mikulas Patocka writes: > > Mikulas> On Thu, 26 Apr 2018, John Stoffel wrote: > > Mikulas> I see your point - and I think the misunderstanding is this. > > Thanks. > > Mikulas> This patch is not really helping people to debug exi

[PATCH 0/6] Fix XSA-155-like bugs in frontend drivers

2018-04-30 Thread Marek Marczykowski-Górecki
Patches in original Xen Security Advisory 155 cared only about backend drivers while leaving frontend patches to be "developed and released (publicly) after the embargo date". This is said series. Marek Marczykowski-Górecki (6): xen: Add RING_COPY_RESPONSE() xen-netfront: copy response out of

[PATCH 2/6] xen-netfront: copy response out of shared buffer before accessing it

2018-04-30 Thread Marek Marczykowski-Górecki
Make local copy of the response, otherwise backend might modify it while frontend is already processing it - leading to time of check / time of use issue. This is complementary to XSA155. Cc: sta...@vger.kernel.org Signed-off-by: Marek Marczykowski-Górecki --- drivers/net/xen-netfront.c | 51 ++

[PATCH 3/6] xen-netfront: do not use data already exposed to backend

2018-04-30 Thread Marek Marczykowski-Górecki
Backend may freely modify anything on shared page, so use data which was supposed to be written there, instead of reading it back from the shared page. This is complementary to XSA155. CC: sta...@vger.kernel.org Signed-off-by: Marek Marczykowski-Górecki --- drivers/net/xen-netfront.c | 9 +

[PATCH 4/6] xen-netfront: add range check for Tx response id

2018-04-30 Thread Marek Marczykowski-Górecki
Tx response ID is fetched from shared page, so make sure it is sane before using it as an array index. CC: sta...@vger.kernel.org Signed-off-by: Marek Marczykowski-Górecki --- drivers/net/xen-netfront.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/xen-netfront.c b/drivers/net/

Good News

2018-04-30 Thread Mrs Julie Leach
You are a recipient to Mrs Julie Leach Donation of $2 million USD. Contact (julieleach...@gmail.com) for claims.

Re: [PATCH net-next v9 3/4] virtio_net: Extend virtio to use VF datapath when available

2018-04-30 Thread Samudrala, Sridhar
On 4/30/2018 12:12 AM, Jiri Pirko wrote: Mon, Apr 30, 2018 at 05:00:33AM CEST, sridhar.samudr...@intel.com wrote: On 4/28/2018 1:24 AM, Jiri Pirko wrote: Fri, Apr 27, 2018 at 07:06:59PM CEST, sridhar.samudr...@intel.com wrote: This patch enables virtio_net to switch over to a VF datapath when

Re: [PATCH net-next v6 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-04-30 Thread Eric W. Biederman
Rahul Lakkireddy writes: > v6: > - Reworked device dump elf note name to contain vendor identifier. > - Added vmcoredd_header that precedes actual dump in the Elf Note. > - Device dump's name is moved inside vmcoredd_header. > - Added "CHELSIO" string as vendor identifier in the Elf Note name >

Re: [PATCH net-next v2 4/5] ipv6: sr: Add seg6local action End.BPF

2018-04-30 Thread Mathieu Xhonneux
2018-04-28 2:01 GMT+02:00 Alexei Starovoitov : > > On Fri, Apr 27, 2018 at 10:59:19AM -0400, David Miller wrote: > > From: Mathieu Xhonneux > > Date: Tue, 24 Apr 2018 18:44:15 +0100 > > > > > This patch adds the End.BPF action to the LWT seg6local infrastructure. > > > This action works like any o

[PATCH net-next] udp: disable gso with no_check_tx

2018-04-30 Thread Willem de Bruijn
From: Willem de Bruijn Syzbot managed to send a udp gso packet without checksum offload into the gso stack by disabling tx checksum (UDP_NO_CHECK6_TX). This triggered the skb_warn_bad_offload. RIP: 0010:skb_warn_bad_offload+0x2bc/0x600 net/core/dev.c:2658 skb_gso_segment include/linux/netde

Re: Representing cpu-port of a switch

2018-04-30 Thread Florian Fainelli
On 04/30/2018 06:06 AM, sk.syed2 wrote: >> Again, pretty standard. What you probably meant is that for host destined or >> initiated traffic you must use that internal port to egress/ingress frames >> towards the other external ports. >> > Yes. > >> >>> Without tagging, we cant really use DSA, a

Re: [RFC net-next 0/5] Support for PHY test modes

2018-04-30 Thread Florian Fainelli
On 04/30/2018 09:40 AM, Andrew Lunn wrote: >> Turning these tests on will typically result in the link partner >> dropping the link with us, and the interface will be non-functional as >> far as the data path is concerned (similar to an isolation mode). This >> might warrant properly reporting that

Re: [PATCH net-next v9 1/4] virtio_net: Introduce VIRTIO_NET_F_STANDBY feature bit

2018-04-30 Thread Samudrala, Sridhar
On 4/30/2018 12:03 AM, Jiri Pirko wrote: Mon, Apr 30, 2018 at 04:47:03AM CEST, sridhar.samudr...@intel.com wrote: On 4/28/2018 12:50 AM, Jiri Pirko wrote: Fri, Apr 27, 2018 at 07:06:57PM CEST,sridhar.samudr...@intel.com wrote: This feature bit can be used by hypervisor to indicate virtio_net

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

2018-04-30 Thread John Stoffel
> "Mikulas" == Mikulas Patocka writes: Mikulas> On Thu, 26 Apr 2018, John Stoffel wrote: >> > "James" == James Bottomley >> > writes: >> James> I may be an atypical developer but I'd rather have a root canal James> than browse through menuconfig options. The way to get people Jam

Re: Request for stable 4.14.x inclusion: net: don't call update_pmtu unconditionally

2018-04-30 Thread Greg KH
On Fri, Apr 27, 2018 at 07:43:52PM +0100, Eddie Chapman wrote: > On 27/04/18 19:07, Thomas Deutschmann wrote: > > Hi Greg, > > > > first, we need to cherry-pick another patch first: > > > From 52a589d51f1008f62569bf89e95b26221ee76690 Mon Sep 17 00:00:00 2001 > > > From: Xin Long > > > Date: Mon,

INFO: rcu detected stall in kfree_skbmem

2018-04-30 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:5d1365940a68 Merge git://git.kernel.org/pub/scm/linux/kerne... git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?id=5667997129637888 kernel config: https://syzkaller.appspot.com/x/.config?id=-5947642

INFO: rcu detected stall in kmem_cache_alloc_node_trace

2018-04-30 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:17dec0a94915 Merge branch 'userns-linus' of git://git.kerne... git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?id=6093051722203136 kernel config: https://syzkaller.appspot.com/x/.config?id=-2735707

Re: Performance regressions in TCP_STREAM tests in Linux 4.15 (and later)

2018-04-30 Thread Eric Dumazet
On 04/30/2018 09:36 AM, Eric Dumazet wrote: > > > On 04/30/2018 09:14 AM, Ben Greear wrote: >> On 04/27/2018 08:11 PM, Steven Rostedt wrote: >>> >>> We'd like this email archived in netdev list, but since netdev is >>> notorious for blocking outlook email as spam, it didn't go through. So >>> I

Re: [PATCH bpf-next] bpf: relax constraints on formatting for eBPF helper documentation

2018-04-30 Thread Quentin Monnet
2018-04-30 17:33 UTC+0100 ~ Edward Cree > On 30/04/18 16:59, Quentin Monnet wrote: >> The Python script used to parse and extract eBPF helpers documentation >> from include/uapi/linux/bpf.h expects a very specific formatting for the >> descriptions (single dots represent a space, '>' stands for a

Re: [PATCH net-next 1/1] inet_diag: fetch cong algo info when socket is destroyed

2018-04-30 Thread Jamal Hadi Salim
On 29/04/18 08:31 PM, David Miller wrote: Well, two things: 1) The congestion control info is opt-in, meaning that the user gets it in the dump if they ask for it. This information is opt-in, because otherwise the dumps get really large. Therefore, emitting this stuff by defau

[PATCH v2] ethtool: fix a potential missing-check bug

2018-04-30 Thread Wenwen Wang
In ethtool_get_rxnfc(), the object "info" is firstly copied from user-space. If the FLOW_RSS flag is set in the member field flow_type of "info" (and cmd is ETHTOOL_GRXFH), info needs to be copied again from user-space because FLOW_RSS is newer and has new definition, as mentioned in the comment. H

Re: [PATCH RFC 6/9] veth: Add ndo_xdp_xmit

2018-04-30 Thread Jesper Dangaard Brouer
On Thu, 26 Apr 2018 19:52:40 +0900 Toshiaki Makita wrote: > On 2018/04/26 5:24, Jesper Dangaard Brouer wrote: > > On Tue, 24 Apr 2018 23:39:20 +0900 > > Toshiaki Makita wrote: > > > >> +static int veth_xdp_xmit(struct net_device *dev, struct xdp_frame *frame) > >> +{ > >> + struct veth_priv

[PATCH bpf-next] bpf/verifier: enable ctx + const + 0.

2018-04-30 Thread William Tu
Existing verifier does not allow 'ctx + const + const'. However, due to compiler optimization, there is a case where BPF compilerit generates 'ctx + const + 0', as shown below: 599: (1d) if r2 == r4 goto pc+2 R0=inv(id=0) R1=ctx(id=0,off=40,imm=0) R2=inv(id=0,umax_value=4294967295,var_off

[net-next 8/9] i40e/i40evf: take into account queue map from vf when handling queues

2018-04-30 Thread Jeff Kirsher
From: Harshitha Ramamurthy The expectation of the ops VIRTCHNL_OP_ENABLE_QUEUES and VIRTCHNL_OP_DISABLE_QUEUES is that the queue map sent by the VF is taken into account when enabling/disabling queues in the VF VSI. This patch makes sure that happens. By breaking out the individual queue set up

[net-next 9/9] i40e: use %pI4b instead of byte swapping before dev_err

2018-04-30 Thread Jeff Kirsher
From: Jacob Keller Fix warnings regarding restricted __be32 type usage by strictly specifying the type of the ipv4 address being printed in the dev_err statement. Signed-off-by: Jacob Keller Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c

[net-next 7/9] i40e: avoid overflow in i40e_ptp_adjfreq()

2018-04-30 Thread Jeff Kirsher
From: Jacob Keller When operating at 1GbE, the base incval for the PTP clock is so large that multiplying it by numbers close to the max_adj can overflow the u64. Rather than attempting to limit the max_adj to a value small enough to avoid overflow, instead calculate the incvalue adjustment base

Re: [PATCH V2 net-next 1/2] tcp: send in-queue bytes in cmsg upon read

2018-04-30 Thread Soheil Hassas Yeganeh
On Mon, Apr 30, 2018 at 12:10 PM, David Miller wrote: > From: Eric Dumazet > Date: Mon, 30 Apr 2018 09:01:47 -0700 > >> TCP sockets are read by a single thread really (or synchronized >> threads), or garbage is ensured, regardless of how the kernel >> ensures locking while reporting "queue length

[net-next 0/9][pull request] 40GbE Intel Wired LAN Driver Updates 2018-04-30

2018-04-30 Thread Jeff Kirsher
This series contains updates to i40e and i40evf only. Jia-Ju Bai replaces an instance of GFP_ATOMIC to GFP_KERNEL, since i40evf is not in atomic context when i40evf_add_vlan() is called. Jake cleans up function header comments to ensure that the function parameter comments actually match the func

[net-next 4/9] i40e: Add advertising 10G LR mode

2018-04-30 Thread Jeff Kirsher
From: Jakub Pawlak The advertising 10G LR mode should be possible to set but in the function i40e_set_link_ksettings() check for this is missed. This patch adds check for 1baseLR_Full flag for 10G modes. Signed-off-by: Jakub Pawlak Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher ---

[net-next 1/9] i40evf: Replace GFP_ATOMIC with GFP_KERNEL in i40evf_add_vlan

2018-04-30 Thread Jeff Kirsher
From: Jia-Ju Bai i40evf_add_vlan() is never called in atomic context. i40evf_add_vlan() is only called by i40evf_vlan_rx_add_vid(), which is only set as ".ndo_vlan_rx_add_vid" in struct net_device_ops. ".ndo_vlan_rx_add_vid" is not called in atomic context. Despite never getting called from ato

[net-next 2/9] i40e/i40evf: cleanup incorrect function doxygen comments

2018-04-30 Thread Jeff Kirsher
From: Jacob Keller Recent versions of the Linux kernel now warn about incorrect parameter definitions for function comments. Fix up several function comments to correctly reflect the current function arguments. This cleans up the warnings and helps ensure our documentation is accurate. Signed-of

[net-next 6/9] i40e: Fix multiple issues with UDP tunnel offload filter configuration

2018-04-30 Thread Jeff Kirsher
From: Alexander Duyck This fixes at least 2 issues I have found with the UDP tunnel filter configuration. The first issue is the fact that the tunnels didn't have any sort of mutual exclusion in place to prevent an update from racing with a user request to add/remove a port. As such you could re

[net-next 3/9] i40e: fix reading LLDP configuration

2018-04-30 Thread Jeff Kirsher
From: Mariusz Stachura Previous method for reading LLDP config was based on hard-coded offsets. It happened to work, because of structured architecture of the NVM memory. In the new approach, known as FLAT, we need to calculate the absolute address, instead of using relative values. Needed define

[net-next 5/9] i40evf: Fix turning TSO, GSO and GRO on after

2018-04-30 Thread Jeff Kirsher
From: Paweł Jabłoński This patch fixes the problem where each MTU change turns TSO, GSO and GRO on from off state. Now when TSO, GSO or GRO is turned off, MTU change does not turn them on. Signed-off-by: Paweł Jabłoński Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/et

Re: [PATCH] ethtool: fix a potential missing-check bug

2018-04-30 Thread Shannon Nelson
On 4/29/2018 6:31 PM, Wenwen Wang wrote: In ethtool_get_rxnfc(), the object "info" is firstly copied from user-space. If the FLOW_RSS flag is set in the member field flow_type of "info" (and cmd is ETHTOOL_GRXFH), info needs to be copied again from user-space because FLOW_RSS is newer and has new

Re: [PATCH net-next v3 0/6] mlxsw: SPAN: Support routes pointing at bridges

2018-04-30 Thread David Miller
From: Ido Schimmel Date: Sun, 29 Apr 2018 10:56:07 +0300 > Petr says: > > When mirroring to a gretap or ip6gretap netdevice, the route that > directs the encapsulated packets can reference a bridge. In that case, > in the software model, the packet is switched. > > Thus when offloading mirrorin

Re: [PATCH net-next] net: core: Assert the size of netdev_featres_t

2018-04-30 Thread Stephen Hemminger
On Fri, 27 Apr 2018 13:11:14 -0700 Florian Fainelli wrote: > We have about 53 netdev_features_t bits defined and counting, add a > build time check to catch when an u64 type will not be enough and we > will have to convert that to a bitmap. This is done in > register_netdevice() for convenience.

Re: [RFC net-next 0/5] Support for PHY test modes

2018-04-30 Thread Andrew Lunn
> Turning these tests on will typically result in the link partner > dropping the link with us, and the interface will be non-functional as > far as the data path is concerned (similar to an isolation mode). This > might warrant properly reporting that to user-space through e.g: a > private IFF_* v

Re: Performance regressions in TCP_STREAM tests in Linux 4.15 (and later)

2018-04-30 Thread Eric Dumazet
On 04/30/2018 09:14 AM, Ben Greear wrote: > On 04/27/2018 08:11 PM, Steven Rostedt wrote: >> >> We'd like this email archived in netdev list, but since netdev is >> notorious for blocking outlook email as spam, it didn't go through. So >> I'm replying here to help get it into the archives. >> >>

Re: [PATCH bpf-next] bpf: relax constraints on formatting for eBPF helper documentation

2018-04-30 Thread Edward Cree
On 30/04/18 16:59, Quentin Monnet wrote: > The Python script used to parse and extract eBPF helpers documentation > from include/uapi/linux/bpf.h expects a very specific formatting for the > descriptions (single dots represent a space, '>' stands for a tab): > > /* > ... > *.int bpf_h

Re: Performance regressions in TCP_STREAM tests in Linux 4.15 (and later)

2018-04-30 Thread Steven Rostedt
On Mon, 30 Apr 2018 09:14:04 -0700 Ben Greear wrote: > >> As part of VMware's performance testing with the Linux 4.15 kernel, > >> we identified CPU cost and throughput regressions when comparing to > >> the Linux 4.14 kernel. The impacted test cases are mostly TCP_STREAM > >> send tests when usi

Re: [RFC net-next 0/5] Support for PHY test modes

2018-04-30 Thread Florian Fainelli
On 04/29/2018 07:55 PM, David Miller wrote: > From: Florian Fainelli > Date: Fri, 27 Apr 2018 17:32:30 -0700 > >> This patch series adds support for specifying PHY test modes through >> ethtool and paves the ground for adding support for more complex >> test modes that might require data to be ex

[PATCH] net/mlx4: fix spelling mistake: "failedi" -> "failed"

2018-04-30 Thread Colin King
From: Colin Ian King trivial fix to spelling mistake in mlx4_warn message. Signed-off-by: Colin Ian King --- drivers/net/ethernet/mellanox/mlx4/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/

Re: [net-next v2] ipv6: sr: extract the right key values for "seg6_make_flowlabel"

2018-04-30 Thread David Miller
From: Ahmed Abdelsalam Date: Sat, 28 Apr 2018 12:18:35 +0200 > The seg6_make_flowlabel() is used by seg6_do_srh_encap() to compute the > flowlabel from a given skb. It relies on skb_get_hash() which eventually > calls __skb_flow_dissect() to extract the flow_keys struct values from > the skb. >

Re: Performance regressions in TCP_STREAM tests in Linux 4.15 (and later)

2018-04-30 Thread Ben Greear
On 04/27/2018 08:11 PM, Steven Rostedt wrote: We'd like this email archived in netdev list, but since netdev is notorious for blocking outlook email as spam, it didn't go through. So I'm replying here to help get it into the archives. Thanks! -- Steve On Fri, 27 Apr 2018 23:05:46 + Micha

Re: [PATCH V2 net-next 1/2] tcp: send in-queue bytes in cmsg upon read

2018-04-30 Thread David Miller
From: Eric Dumazet Date: Mon, 30 Apr 2018 09:01:47 -0700 > TCP sockets are read by a single thread really (or synchronized > threads), or garbage is ensured, regardless of how the kernel > ensures locking while reporting "queue length" Whatever applications "typically do", we should never return

[PATCH bpf-next] bpf: relax constraints on formatting for eBPF helper documentation

2018-04-30 Thread Quentin Monnet
The Python script used to parse and extract eBPF helpers documentation from include/uapi/linux/bpf.h expects a very specific formatting for the descriptions (single dots represent a space, '>' stands for a tab): /* ... *.int bpf_helper(list of arguments) *.>Description

Re: [PATCH bpf-next] tools include uapi: Grab a copy of linux/erspan.h

2018-04-30 Thread Daniel Borkmann
On 04/30/2018 05:45 PM, Y Song wrote: > On Mon, Apr 30, 2018 at 7:33 AM, Daniel Borkmann wrote: >> On 04/30/2018 04:26 PM, William Tu wrote: >>> Bring the erspan uapi header file so BPF tunnel helpers can use it. >>> >>> Fixes: 933a741e3b82 ("selftests/bpf: bpf tunnel test.") >>> Reported-by: Yong

Re: [PATCH V2 net-next 1/2] tcp: send in-queue bytes in cmsg upon read

2018-04-30 Thread Eric Dumazet
On 04/30/2018 08:56 AM, David Miller wrote: > From: Eric Dumazet > Date: Mon, 30 Apr 2018 08:43:50 -0700 > >> I say sort of, because by the time we have any number, TCP might >> have received more packets anyway. > > That's fine. > > However, the number reported should have been true at least

Re: [PATCH V2 net-next 1/2] tcp: send in-queue bytes in cmsg upon read

2018-04-30 Thread Soheil Hassas Yeganeh
On Mon, Apr 30, 2018 at 11:43 AM, Eric Dumazet wrote: > On 04/30/2018 08:38 AM, David Miller wrote: >> From: Soheil Hassas Yeganeh >> Date: Fri, 27 Apr 2018 14:57:32 -0400 >> >>> Since the socket lock is not held when calculating the size of >>> receive queue, TCP_INQ is a hint. For example, it

Re: [PATCH] change the comment of vti6_ioctl

2018-04-30 Thread David Miller
From: Sun Lianwen Date: Sun, 29 Apr 2018 15:05:52 +0800 > The comment of vti6_ioctl() is wrong. which use vti6_tnl_ioctl > instead of vti6_ioctl. > > Signed-off-by: Sun Lianwen Please CC: the IPSEC maintainers on future patch submissions to IPSEC files, as per the top level MAINTAINERS file.

Re: [PATCH net-next 0/2 v5] netns: uevent filtering

2018-04-30 Thread Eric W. Biederman
Christian Brauner writes: > Hey everyone, > > This is the new approach to uevent filtering as discussed (see the > threads in [1], [2], and [3]). It only contains *non-functional > changes*. > > This series deals with with fixing up uevent filtering logic: > - uevent filtering logic is simplified

Re: [PATCH V2 net-next 1/2] tcp: send in-queue bytes in cmsg upon read

2018-04-30 Thread David Miller
From: Eric Dumazet Date: Mon, 30 Apr 2018 08:43:50 -0700 > I say sort of, because by the time we have any number, TCP might > have received more packets anyway. That's fine. However, the number reported should have been true at least at some finite point in time. If you allow overlapping chang

Re: [PATCH net-next] libcxgb,cxgb4: use __skb_put_zero to simplfy code

2018-04-30 Thread David Miller
From: YueHaibing Date: Sat, 28 Apr 2018 12:35:22 +0800 > use helper __skb_put_zero to replace the pattern of __skb_put() && memset() > > Signed-off-by: YueHaibing Applied, thank you.

Re: [PATCH bpf-next] tools include uapi: Grab a copy of linux/erspan.h

2018-04-30 Thread Y Song
On Mon, Apr 30, 2018 at 7:33 AM, Daniel Borkmann wrote: > On 04/30/2018 04:26 PM, William Tu wrote: >> Bring the erspan uapi header file so BPF tunnel helpers can use it. >> >> Fixes: 933a741e3b82 ("selftests/bpf: bpf tunnel test.") >> Reported-by: Yonghong Song >> Signed-off-by: William Tu > >

RE: smsc95xx: aligment issues

2018-04-30 Thread Woojung.Huh
Hi Stefan, Thanks for report. We will try to repro issue and contact you if need more details. Regards, Woojung > -Original Message- > From: Stefan Wahren [mailto:stefan.wah...@i2se.com] > Sent: Saturday, April 28, 2018 3:59 AM > To: Nisar Sayed - I17970 ; Woojung Huh - C21699 > > Cc:

Re: [PATCH net-next] erspan: auto detect truncated packets.

2018-04-30 Thread David Miller
From: William Tu Date: Fri, 27 Apr 2018 14:16:32 -0700 > Currently the truncated bit is set only when the mirrored packet > is larger than mtu. For certain cases, the packet might already > been truncated before sending to the erspan tunnel. In this case, > the patch detect whether the IP heade

Re: [PATCH V2 net-next 1/2] tcp: send in-queue bytes in cmsg upon read

2018-04-30 Thread Eric Dumazet
On 04/30/2018 08:38 AM, David Miller wrote: > From: Soheil Hassas Yeganeh > Date: Fri, 27 Apr 2018 14:57:32 -0400 > >> Since the socket lock is not held when calculating the size of >> receive queue, TCP_INQ is a hint. For example, it can overestimate >> the queue size by one byte, if FIN is r

Re: KASAN: use-after-free Read in perf_trace_rpc_stats_latency

2018-04-30 Thread Chuck Lever
> On Apr 30, 2018, at 9:34 AM, syzbot > wrote: > > Hello, > > syzbot hit the following crash on bpf-next commit > f60ad0a0c441530280a4918eca781a6a94dffa50 (Sun Apr 29 15:45:55 2018 +) > Merge branch 'bpf_get_stack' > syzbot dashboard link: > https://syzkaller.appspot.com/bug?extid=27db1f

Re: [PATCH V2 net-next 1/2] tcp: send in-queue bytes in cmsg upon read

2018-04-30 Thread David Miller
From: Soheil Hassas Yeganeh Date: Fri, 27 Apr 2018 14:57:32 -0400 > Since the socket lock is not held when calculating the size of > receive queue, TCP_INQ is a hint. For example, it can overestimate > the queue size by one byte, if FIN is received. I think it is even worse than that. If anoth

Re: simplify procfs code for seq_file instances V2

2018-04-30 Thread David Howells
Note that your kernel hits the: inconsistent {HARDIRQ-ON-W} -> {IN-HARDIRQ-W} usage. swapper/0/0 [HC1[1]:SC0[0]:HE0:SE1] takes: (ptrval) (fs_reclaim){?.+.}, at: fs_reclaim_acquire+0x12/0x35 {HARDIRQ-ON-W} state was registered at: fs_reclaim_acquire

Re: [PATCH RFC iproute2-next 2/2] rdma: print provider resource attributes

2018-04-30 Thread Stephen Hemminger
On Mon, 30 Apr 2018 07:36:18 -0700 Steve Wise wrote: > +#define nla_type(attr) ((attr)->nla_type & NLA_TYPE_MASK) > + > +void newline(struct rd *rd) > +{ > + if (rd->json_output) > + jsonw_end_array(rd->jw); > + else > + pr_out("\n"); > +} > + > +void newline_inden

Re: [PATCH] connector: add parent pid and tgid to coredump and exit events

2018-04-30 Thread David Miller
From: Evgeniy Polyakov Date: Mon, 30 Apr 2018 18:01:30 +0300 > Stefan, hi > > Sorry for delay. > > 26.04.2018, 15:04, "Stefan Strogin" : >> Hi David, Evgeniy, >> >> Sorry to bother you, but could you please comment about the UAPI change and >> the patch? > > With 4-bytes pid_t everything look

Re: [PATCH bpf-next 2/3] bpf: fix formatting for bpf_get_stack() helper doc

2018-04-30 Thread Quentin Monnet
2018-04-30 09:12 UTC-0600 ~ David Ahern > On 4/30/18 9:08 AM, Alexei Starovoitov wrote: >>> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h >>> index 530ff6588d8f..8daef7326bb7 100644 >>> --- a/include/uapi/linux/bpf.h >>> +++ b/include/uapi/linux/bpf.h >>> @@ -1770,33 +1770,33 @@

Re: [PATCH bpf-next 2/3] bpf: fix formatting for bpf_get_stack() helper doc

2018-04-30 Thread David Ahern
On 4/30/18 9:08 AM, Alexei Starovoitov wrote: >> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h >> index 530ff6588d8f..8daef7326bb7 100644 >> --- a/include/uapi/linux/bpf.h >> +++ b/include/uapi/linux/bpf.h >> @@ -1770,33 +1770,33 @@ union bpf_attr { >> * >> * int bpf_get_stac

[PATCH RFC iproute2-next 2/2] rdma: print provider resource attributes

2018-04-30 Thread Steve Wise
This enhancement allows printing rdma device-specific state, if provided by the kernel. This is done in a generic manner, so rdma tool doesn't need to know about the details of every type of rdma device. Provider attributes for a rdma resource are in the form of tuples, where the key is a string

[PATCH RFC iproute2-next 1/2] rdma: update rdma_netlink.h to get provider attrs

2018-04-30 Thread Steve Wise
Signed-off-by: Steve Wise --- rdma/include/uapi/rdma/rdma_netlink.h | 37 ++- 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/rdma/include/uapi/rdma/rdma_netlink.h b/rdma/include/uapi/rdma/rdma_netlink.h index 45474f1..faea9d5 100644 --- a/rdma/inclu

[PATCH RFC iproute2-next 0/2] RDMA tool provider resource tracking

2018-04-30 Thread Steve Wise
Hello, This series enhances the iproute2 rdma tool to include displaying provider-specific resource attributes. It is the user-space part of the kernel provider resource tracking series currently under review [1]. This is an RFC and should not be merged yet. Once [1] is in the linux-rdma for-ne

Re: [PATCH bpf-next 2/3] bpf: fix formatting for bpf_get_stack() helper doc

2018-04-30 Thread Alexei Starovoitov
On Mon, Apr 30, 2018 at 11:39:04AM +0100, Quentin Monnet wrote: > Fix formatting (indent) for bpf_get_stack() helper documentation, so > that the doc is rendered correctly with the Python script. > > Fixes: c195651e565a ("bpf: add bpf_get_stack helper") > Cc: Yonghong Song > Signed-off-by: Quenti

Re: [PATCH] connector: add parent pid and tgid to coredump and exit events

2018-04-30 Thread Evgeniy Polyakov
Stefan, hi Sorry for delay. 26.04.2018, 15:04, "Stefan Strogin" : > Hi David, Evgeniy, > > Sorry to bother you, but could you please comment about the UAPI change and > the patch? With 4-bytes pid_t everything looks fine, and I do not know arch where pid is larger currently, so it looks safe.

[PATCH net-next 3/4] net/smc: handle ioctls SIOCINQ, SIOCOUTQ, and SIOCOUTQNSD

2018-04-30 Thread Ursula Braun
SIOCINQ returns the amount of unread data in the RMB. SIOCOUTQ returns the amount of unsent or unacked sent data in the send buffer. SIOCOUTQNSD returns the amount of data prepared for sending, but not yet sent. Signed-off-by: Ursula Braun --- net/smc/af_smc.c | 33 ++

[PATCH net-next 4/4] net/smc: determine vlan_id of stacked net_device

2018-04-30 Thread Ursula Braun
An SMC link group is bound to a specific vlan_id. Its link uses the RoCE-GIDs established for the specific vlan_id. This patch makes sure the appropriate vlan_id is determined for stacked scenarios like for instance a master bonding device with vlan devices enslaved. Signed-off-by: Ursula Braun -

[PATCH net-next 1/4] net/smc: periodic testlink support

2018-04-30 Thread Ursula Braun
From: Karsten Graul Add periodic LLC testlink support to ensure the link is still active. The interval time is initialized using the value of sysctl_tcp_keepalive_time. Signed-off-by: Karsten Graul Signed-off-by: Ursula Braun --- net/smc/af_smc.c | 6 -- net/smc/smc_core.c | 2 ++ net

[PATCH net-next 2/4] net/smc: ipv6 support for smc_diag.c

2018-04-30 Thread Ursula Braun
From: Karsten Graul Update smc_diag.c to support ipv6 addresses on the diagnosis interface. Signed-off-by: Karsten Graul Signed-off-by: Ursula Braun --- net/smc/smc_diag.c | 37 - 1 file changed, 28 insertions(+), 9 deletions(-) diff --git a/net/smc/smc_di

[PATCH net-next 0/4] net/smc: fixes 2018/04/30

2018-04-30 Thread Ursula Braun
From: Ursula Braun Dave, here are 4 smc patches for net-next covering different areas: * link health check * diagnostics for IPv6 smc sockets * ioctl * improvement for vlan determination Thanks, Ursula Karsten Graul (2): net/smc: periodic testlink support net/smc: ipv6 support

Re: [PATCH 20/39] afs: simplify procfs code

2018-04-30 Thread David Howells
Christoph Hellwig wrote: > I don't think you should need any of these. seq_file_net or > seq_file_single_net will return you the net_ns based on a struct > seq_file. And even from your write routines you can reach the > seq_file in file->private pretty easily. You've taken away things like sin

Re: [PATCH bpf-next] tools include uapi: Grab a copy of linux/erspan.h

2018-04-30 Thread Daniel Borkmann
On 04/30/2018 04:26 PM, William Tu wrote: > Bring the erspan uapi header file so BPF tunnel helpers can use it. > > Fixes: 933a741e3b82 ("selftests/bpf: bpf tunnel test.") > Reported-by: Yonghong Song > Signed-off-by: William Tu Thanks for the patch, William! I also Cc'ed Yonghong here, so he h

  1   2   >