2018-04-30 09:12 UTC-0600 ~ David Ahern <dsah...@gmail.com>
> On 4/30/18 9:08 AM, Alexei Starovoitov wrote:
>>> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
>>> index 530ff6588d8f..8daef7326bb7 100644
>>> --- a/include/uapi/linux/bpf.h
>>> +++ b/include/uapi/linux/bpf.h
>>> @@ -1770,33 +1770,33 @@ union bpf_attr {
>>> *
>>> * int bpf_get_stack(struct pt_regs *regs, void *buf, u32 size, u64 flags)
>>> * Description
>>> - * Return a user or a kernel stack in bpf program provided buffer.
>>> - * To achieve this, the helper needs *ctx*, which is a pointer
>>> + * Return a user or a kernel stack in bpf program provided
>>> buffer.
>>> + * To achieve this, the helper needs *ctx*, which is a
>>> pointer
>> I still don't quite get the difference.
>> It's replacing 2 tabs in above with 1 space + 2 tabs ?
Yes, exactly (Plus in this case, the "::" a few line below has a missing
tab).
>> Can you please teach the python script to accept both?
>> I bet that will be recurring mistake and it's impossible to spot in code
>> review.
> And checkpatch throws an error on the 1 space + 2 tabs so it gets
> confusing on which format should be used.
Sorry about that :/. I will send a patch to make the script more flexible.
Quentin
