The latest merge between net and net-next introduced a complier assert in
mlx5 driver. In hca_cap_bits older fields are kept along with newer
fields that should have replaced them.
Fixes: c02b3741eb99 ("Merge
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net")
Signed-off-by: Saeed Mahameed
When program is loaded with a specified ifindex, use that
ifindex also when creating maps.
Signed-off-by: Jakub Kicinski
---
lib/bpf.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/lib/bpf.c b/lib/bpf.c
index d32f1b808180..2db151e4dd3c 100644
--- a/lib/bpf.c
+++ b/li
On Wed, Jan 17, 2018 at 8:12 AM, Eric Biggers wrote:
> On Wed, Jan 17, 2018 at 07:39:24AM +0100, Oliver Hartkopp wrote:
>>
>>
>> On 01/16/2018 07:11 PM, Dmitry Vyukov wrote:
>> > On Tue, Jan 16, 2018 at 7:07 PM, Marc Kleine-Budde
>> > wrote:
>> > > On 01/16/2018 06:58 PM, syzbot wrote:
>> > > >
On Tue, Jan 16, 2018 at 07:41:24PM -0500, Jeff Moyer wrote:
> I'd be willing to bet the issue is in your io_syscall6 implementation.
> You pass in arg5 where arg6 should be used. Don't feel bad, it took me
> the better part of today to figure that out. :)
>
> Here's an incremental diff on top of
> -Original Message-
> From: Jakub Kicinski [mailto:jakub.kicin...@netronome.com]
> Sent: Monday, January 15, 2018 6:01 AM
> To: da...@davemloft.net; j...@resnulli.us; Nogah Frankel
>
> Cc: netdev@vger.kernel.org; oss-driv...@netronome.com;
> xiyou.wangc...@gmail.com; eduma...@google.com;
on T6, IPv6 filter would occupy 2 tids instead of 4.
Signed-off-by: Kumar Sanghvi
Signed-off-by: Ganesh Goudar
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c | 113 +++---
1 file changed, 80 insertions(+), 33 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/c
Dave,
The resolution of the mlx5_ifc conflict was wrong and it causes a build break
in mlx5, oops :(.
I hope my resolution instructions in my pull request didn't mislead you.
I will post a patch.
-Saeed.
Update firmware dump collection logic to use compression when available.
Let collection logic attempt to do compression, instead of returning out
of memory early.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Vishal Kulkarni
Signed-off-by: Ganesh Goudar
---
drivers/net/ethernet/chelsio/cxgb4/
Use zlib deflate to compress firmware dump. Collect and compress
as much firmware dump as possible into a 32 MB buffer.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Vishal Kulkarni
Signed-off-by: Ganesh Goudar
---
drivers/net/ethernet/chelsio/cxgb4/Makefile| 1 +
drivers/net/etherne
Firmware dump can be large (upto 2 GB). In low memory conditions,
ethtool fails to allocate such large memory. So, use zlib deflate
to compress collected firmware dump.
Patch 1 updates collection logic to use compression.
Patch 2 adds zlib deflate to compress collected firmware dump.
Thanks,
R
Hi Skateman,
Fantastic! Many thanks for testing the RC8 of kernel 4.15 without PAMU support.
@All
Further information:
http://forum.hyperion-entertainment.biz/viewtopic.php?f=58&p=43706#p43706
Cheers,
Christian
On 16. Jan 2018, at 23:05, mad skateman wrote:
Fantastic Christian..
Your lates
On Wed, Jan 17, 2018 at 07:39:24AM +0100, Oliver Hartkopp wrote:
>
>
> On 01/16/2018 07:11 PM, Dmitry Vyukov wrote:
> > On Tue, Jan 16, 2018 at 7:07 PM, Marc Kleine-Budde
> > wrote:
> > > On 01/16/2018 06:58 PM, syzbot wrote:
> > > > Hello,
> > > >
> > > > syzkaller hit the following crash on
On Wed, Jan 17, 2018 at 04:27:21AM +, Al Viro wrote:
> On Tue, Jan 16, 2018 at 07:41:24PM -0500, Jeff Moyer wrote:
> > if (sigmask) {
> > - if (copy_from_user(&ksigmask, sigmask, sizeof(ksigmask)))
> > + if (!access_ok(VERIFY_READ, sigmask,
> > +
Hi Florian
for gmac4.x and gmac3.x series the ACS bit is the Automatic Pad or CRC
Stripping, so the
core strips the Pad or FCS on frames if the value of the length field is
< 1536 bytes.
For MAC10-100 there is the Bit 8 (ASTP) of the reg0 that does the same
if len is < 46bytes.
In your patch I
From: Kumar Sanghvi
For ethtype_key = ETH_P_IPV6, set filter type as 1 in cxgb4_tc_flower
code when processing flow match parameters.
Signed-off-by: Kumar Sanghvi
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Ganesh Goudar
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c | 3 +++
1
From: Kumar Sanghvi
Don't change endianness when assigning vlan value in cxgb4_tc_flower
code when processing flow match parameters. The value gets converted
to network order as part of filtering code in set_filter_wr.
Signed-off-by: Kumar Sanghvi
Signed-off-by: Rahul Lakkireddy
Signed-off-by:
Patch 1 sets filter type to indicate IPv6 when processing flow match
parameters.
Patch 2 fixes endianness issue when processing vlan flow match parameters.
Kumar Sanghvi (2):
cxgb4: set filter type to 1 for ETH_P_IPV6
cxgb4: fix endianness for vlan value in cxgb4_tc_flower
drivers/net/ether
The main purpose of this patch is adding a way of checking per-queue stats.
It's useful to debug performance problems on multiqueue environment.
$ ethtool -S ens10
NIC statistics:
rx_queue_0_packets: 2090408
rx_queue_0_bytes: 3164825094
rx_queue_1_packets: 2082531
rx_queue_1_by
On 01/16/2018 07:11 PM, Dmitry Vyukov wrote:
On Tue, Jan 16, 2018 at 7:07 PM, Marc Kleine-Budde wrote:
On 01/16/2018 06:58 PM, syzbot wrote:
Hello,
syzkaller hit the following crash on
a8750ddca918032d6349adbf9a4b6555e7db20da
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/
On Tue, Jan 16, 2018 at 09:49:16PM -0800, John Fastabend wrote:
>
> > but this program will see only first SG ?
>
> Correct, to read further into the msg we would need to have a helper
> or some other way to catch reads/writes past the first 4k and read
> the next sg. We have the same limitation
Greeting's
linux-next kernel booted with kernel Oops on powerpc machine.
Machine Type: Power 8 [bare-metal & PowerVM LPAR]
kernel version: 4.15.0-rc7-next-20180115
test: Boot
config: attached
bootlogs:
-
ses 0:0:3:0: Attached Enclosure device
ses 0:0:4:0: Attached Enclosure device
Roundi
On 01/16/2018 06:25 PM, Alexei Starovoitov wrote:
> On Fri, Jan 12, 2018 at 10:11:11AM -0800, John Fastabend wrote:
>> This implements a BPF ULP layer to allow policy enforcement and
>> monitoring at the socket layer. In order to support this a new
>> program type BPF_PROG_TYPE_SK_MSG is used to ru
Daniel, please double check my merge work especially wrt. your
packet scheduler fix.
Thanks!
On Tue, Jan 16, 2018 at 11:33 PM, Willem de Bruijn
wrote:
> On Tue, Jan 16, 2018 at 11:04 PM, Jason Wang wrote:
>>
>>
>> On 2018年01月17日 04:29, Willem de Bruijn wrote:
>>>
>>> From: Willem de Bruijn
>>>
>>> Validate gso packet type and headers on kernel entry. Reuse the info
>>> gathered by skb_pr
On Tue, Jan 16, 2018 at 11:04 PM, Jason Wang wrote:
>
>
> On 2018年01月17日 04:29, Willem de Bruijn wrote:
>>
>> From: Willem de Bruijn
>>
>> Validate gso packet type and headers on kernel entry. Reuse the info
>> gathered by skb_probe_transport_header.
>>
>> Syzbot found two bugs by passing bad gso
On Tue, Jan 16, 2018 at 07:41:24PM -0500, Jeff Moyer wrote:
> if (sigmask) {
> - if (copy_from_user(&ksigmask, sigmask, sizeof(ksigmask)))
> + if (!access_ok(VERIFY_READ, sigmask,
> +sizeof(void *) + sizeof(size_t)) ||
> + __
On 1/16/18 12:11 PM, Jakub Kicinski wrote:
> On Tue, 16 Jan 2018 10:36:01 +0100, Jiri Pirko wrote:
>>> @@ -303,7 +305,8 @@ static int nfp_net_bpf_load(struct nfp_net *nn, struct
>>> bpf_prog *prog)
>>> /* Load up the JITed code */
>>> err = nfp_net_reconfig(nn, NFP_NET_CFG_UPDATE_BPF);
>>>
On 2018年01月17日 04:29, Willem de Bruijn wrote:
From: Willem de Bruijn
Validate gso packet type and headers on kernel entry. Reuse the info
gathered by skb_probe_transport_header.
Syzbot found two bugs by passing bad gso packets in packet sockets.
Untrusted user packets are limited to a small s
CC: Francois
On Tue, 16 Jan 2018 19:42:15 -0800, Alexei Starovoitov wrote:
> > + switch (vendor_id) {
> > + case 0x19ee:
> > + device_id = read_sysfs_netdev_hex_int(devname, "device");
> > + if (device_id != 0x4000 &&
> > + device_id != 0x6000 &&
> > +
This patch fix the bluetooth 6lowpan disconnect fail bug.
The type of the same address type have different define value in HCI layer
and L2CAP layer.That makes disconnect fail due to wrong network type.User
will not be able to disconnect from console with the network type that used
in connect.
Th
From: Daniel Borkmann
Date: Wed, 17 Jan 2018 02:01:28 +0100
> The following pull-request contains BPF updates for your *net-next* tree.
...
> Please consider pulling these changes from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git
Pulled, thanks Daniel.
On Tue, Jan 16, 2018 at 04:05:21PM -0800, Jakub Kicinski wrote:
> From: Jiong Wang
>
> The current architecture detection method in bpftool is designed for host
> case.
>
> For offload case, we can't use the architecture of "bpftool" itself.
> Instead, we could call the existing "ifindex_to_name
On Tue, Jan 16, 2018 at 04:05:19PM -0800, Jakub Kicinski wrote:
> From: Jiong Wang
>
> For host JIT, there are "jited_len"/"bpf_func" fields in struct bpf_prog
> used by all host JIT targets to get jited image and it's length. While for
> offload, targets are likely to have different offload mech
On 1/16/18 4:19 PM, Jamal Hadi Salim wrote:
> On 18-01-16 06:58 PM, David Ahern wrote:
>> On 1/16/18 9:20 AM, Alexander Aring wrote:
>
>
>>> }
>>> if (n->nlmsg_type != RTM_NEWTFILTER ||
>>> !(n->nlmsg_flags & NLM_F_CREATE)) {
>>> + NL_SET_ERR_MSG(ext
Fixes the following sparse warning:
drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c:289:5: warning:
symbol 'mlxsw_sp_kvdl_part_occ' was not declared. Should it be static?
Signed-off-by: Wei Yongjun
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c | 2 +-
1 file changed, 1 insertion(
Fixes the following sparse warnings:
net/core/devlink.c:2297:25: warning:
symbol 'devlink_resource_find' was not declared. Should it be static?
net/core/devlink.c:2322:6: warning:
symbol 'devlink_resource_validate_children' was not declared. Should it be
static?
Signed-off-by: Wei Yongjun
---
The variable miistat is not used. So it is removed.
CC: Srinivas Eeda
CC: Joe Jin
CC: Junxiao Bi
Signed-off-by: Zhu Yanjun
---
v1->v2: Keep readl function
---
drivers/net/ethernet/nvidia/forcedeth.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethern
On Fri, Jan 12, 2018 at 10:11:11AM -0800, John Fastabend wrote:
> This implements a BPF ULP layer to allow policy enforcement and
> monitoring at the socket layer. In order to support this a new
> program type BPF_PROG_TYPE_SK_MSG is used to run the policy at
> the sendmsg/sendpage hook. To attach
This patch keeps BBR from negotiating ECN if sysctl ECN is
set. Prior to this patch, BBR negotiates ECN if enabled, sends
CWR upon receiving ECE ACKs but does not react to them. This can
cause confusion from the protocol perspective. Therefore this
patch prevents the connection from negotiating ECN
The linux kernel by default uses random MAC address
for l2tp interfaces. However, there are situations
where it is desirable to have a deterministic MAC address.
A sample scenario would be where the host IP stack is attached
directly to a tunnel hence the "random" address is now propagated
via ARP
On 01/17/2018 01:08 AM, Daniel Borkmann wrote:
> Hey David, and others, [+Alexei]
>
> On 01/17/2018 12:27 AM, Jamal Hadi Salim wrote:
>> On 18-01-16 05:41 PM, Jakub Kicinski wrote:
>>> On Tue, 16 Jan 2018 17:12:57 -0500, Jamal Hadi Salim wrote:
On 18-01-16 04:46 PM, Jakub Kicinski wrote:
Hi all,
Today's linux-next merge of the net-next tree got conflicts in:
net/sched/sch_ingress.c
net/sched/sch_api.c
include/net/sch_generic.h
between commit:
81d947e2b8dd ("net, sched: fix panic when updating miniq {b,q}stats")
from the net tree and commits:
54160ef6ec64 ("net: sche
On 01/17/2018 12:20 AM, Jesper Dangaard Brouer wrote:
> This patchset contains some small improvements and cleanup for
> the Makefile in tools/lib/bpf/.
>
> It worries me that the libbpf.so shared library is not versioned, but
> it not addressed in this patchset.
Looks good; applied it to bpf-nex
On 01/17/2018 12:51 AM, Jakub Kicinski wrote:
> Hi!
>
> This series combines a number of random improvements ranging from
> libbpf to nfp driver. NFP patches make better use of the verifier
> log. There is a requested adjustment to the map offload code, and
> a warning fix for a W=1 build to the
Hi David,
The following pull-request contains BPF updates for your *net-next* tree.
The main changes are:
1) Add initial BPF map offloading for nfp driver. Currently only
programs were supported so far w/o being able to access maps.
Offloaded programs are right now only allowed to perform
Hi, Christoph,
Christoph Hellwig writes:
> On Mon, Jan 15, 2018 at 09:53:10AM +0100, Christoph Hellwig wrote:
>> > pselect, as an example, crams the sigmask and size together. Why not
>> > just do that? libaio can take care of setting that up.
>>
>> Yes, I could try that. It's just another d
On Tue, 16 Jan 2018 16:05:18 -0800, Jakub Kicinski wrote:
> Hi,
Ah, forgot to insert "Jiong says:" here :)
> Currently bpftool could disassemble host jited image, for example x86_64,
> using libbfd. However it couldn't disassemble offload jited image.
>
> There are two reasons:
>
> 1. bpf_obj
On 18-01-16 06:58 PM, David Ahern wrote:
On 1/16/18 9:20 AM, Alexander Aring wrote:
}
if (n->nlmsg_type != RTM_NEWTFILTER ||
!(n->nlmsg_flags & NLM_F_CREATE)) {
+ NL_SET_ERR_MSG(extack, "Need both RTM_NEWTFILTER and
NLM_F_CREA
Hey David, and others, [+Alexei]
On 01/17/2018 12:27 AM, Jamal Hadi Salim wrote:
> On 18-01-16 05:41 PM, Jakub Kicinski wrote:
>> On Tue, 16 Jan 2018 17:12:57 -0500, Jamal Hadi Salim wrote:
>>> On 18-01-16 04:46 PM, Jakub Kicinski wrote:
On Tue, 16 Jan 2018 12:20:19 -0500, Alexander Aring wro
From: Jiong Wang
The current architecture detection method in bpftool is designed for host
case.
For offload case, we can't use the architecture of "bpftool" itself.
Instead, we could call the existing "ifindex_to_name_ns" to get DEVNAME,
then read pci id from /sys/class/dev/DEVNAME/device/vendo
From: Jiong Wang
For host JIT, there are "jited_len"/"bpf_func" fields in struct bpf_prog
used by all host JIT targets to get jited image and it's length. While for
offload, targets are likely to have different offload mechanisms that these
info are kept in device private data fields.
Therefore,
From: Jiong Wang
This patch set those new jit info fields introduced in this patch set.
Reviewed-by: Jakub Kicinski
Signed-off-by: Jiong Wang
---
drivers/net/ethernet/netronome/nfp/bpf/offload.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet
Hi,
Currently bpftool could disassemble host jited image, for example x86_64,
using libbfd. However it couldn't disassemble offload jited image.
There are two reasons:
1. bpf_obj_get_info_by_fd/struct bpf_prog_info couldn't get the address
of jited image and image's length.
2. Even aft
On Tue, Jan 16, 2018 at 7:33 AM, Jiri Pirko wrote:
> static int __init tc_filter_init(void)
> {
> + int err;
> +
> tc_filter_wq = alloc_ordered_workqueue("tc_filter_workqueue", 0);
> if (!tc_filter_wq)
> return -ENOMEM;
>
> + err = register_pernet_subs
On 1/16/18 9:20 AM, Alexander Aring wrote:
> This patch adds extack support for generic cls handling. The extack
> will be set deeper to each called function which is not part of netdev
> core api.
>
> Cc: David Ahern
> Signed-off-by: Alexander Aring
> ---
> net/sched/cls_api.c | 55
>
Daniel suggests it would be more logical for bpf_offload_dev_match()
to return false is either the program or the map are not offloaded,
rather than treating the both not offloaded case as a "matching
CPU/host device".
This makes no functional difference today, since verifier only calls
bpf_offloa
Hi!
This series combines a number of random improvements ranging from
libbpf to nfp driver. NFP patches make better use of the verifier
log. There is a requested adjustment to the map offload code, and
a warning fix for a W=1 build to the disassembler. Quentin also
fixes the libbpf program type
Functions of type bpf_insn_print_t take printf-like format
string, mark the type accordingly.
Signed-off-by: Jakub Kicinski
Reviewed-by: Quentin Monnet
---
kernel/bpf/disasm.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/bpf/disasm.h b/kernel/bpf/disasm.h
index
From: Quentin Monnet
If an eBPF instruction is unknown to the driver JIT compiler, we can
reject the program at verification time.
Signed-off-by: Quentin Monnet
Reviewed-by: Jakub Kicinski
Reviewed-by: Jiong Wang
---
drivers/net/ethernet/netronome/nfp/bpf/jit.c | 5 +
drivers/net/et
From: Jiong Wang
bfd.h is requiring including of config.h except when PACKAGE or
PACKAGE_VERSION are defined.
/* PR 14072: Ensure that config.h is included first. */
#if !defined PACKAGE && !defined PACKAGE_VERSION
#error config.h must be included before this header
#endif
This check h
Use the verifier log to output error messages if map lookup
can't be offloaded.
Signed-off-by: Jakub Kicinski
Acked-by: Quentin Monnet
---
drivers/net/ethernet/netronome/nfp/bpf/verifier.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/ne
From: Quentin Monnet
libbpf is able to deduce the type of a program from the name of the ELF
section in which it is located. However, the comparison is made on the
first n characters, n being determined with sizeof() applied to the
reference string (e.g. "xdp"). When such section names are suppos
From: Eric Dumazet
Since commit 41033f029e39 ("snmp: Remove duplicate OUTMCAST stat
increment") one line of code became unneeded.
Signed-off-by: Eric Dumazet
---
net/ipv6/mcast.c |2 --
1 file changed, 2 deletions(-)
diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c
index
40b223a930a39e01
On 1/16/18 7:33 AM, Jiri Pirko wrote:
> From: Jiri Pirko
>
> Currently the filters added to qdiscs are independent. So for example if you
> have 2 netdevices and you create ingress qdisc on both and you want to add
> identical filter rules both, you need to add them twice. This patchset
> makes t
On 18-01-16 10:33 AM, Jiri Pirko wrote:
From: Jiri Pirko
For patches 1-9:
Reviewed-by: Jamal Hadi Salim
Acked-by: Jamal Hadi Salim
cheers,
jamal
On 18-01-16 05:41 PM, Jakub Kicinski wrote:
On Tue, 16 Jan 2018 17:12:57 -0500, Jamal Hadi Salim wrote:
On 18-01-16 04:46 PM, Jakub Kicinski wrote:
On Tue, 16 Jan 2018 12:20:19 -0500, Alexander Aring wrote:
[..]
I would say precedence should be Jiri's patches, Alex's patches
and then your
Broadcom tags inserted by Broadcom switches put a 4 byte header after
the MAC SA and before the EtherType, which may look like some sort of 0
length LLC/SNAP packet (tcpdump and wireshark do think that way). With
ACS enabled in stmmac the packets were truncated to 8 bytes on
reception, whereas clea
On 01/16/2018 03:15 PM, Luis de Bethencourt wrote:
> The trailing semicolon is an empty statement that does no operation.
> Removing it since it doesn't do anything.
>
> Signed-off-by: Luis de Bethencourt
Applied to bpf-next, thanks Luis!
This patchset contains some small improvements and cleanup for
the Makefile in tools/lib/bpf/.
It worries me that the libbpf.so shared library is not versioned, but
it not addressed in this patchset.
---
Jesper Dangaard Brouer (3):
libbpf: install the header file libbpf.h
libbpf: cle
On 01/16/2018 12:31 PM, Jesper Dangaard Brouer wrote:
> Doc BPF ld/ldx size defines, as it help me understand the code in filter.c.
>
> Signed-off-by: Jesper Dangaard Brouer
> ---
> 0 files changed
>
> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
> index 395d261948de..4729d9
It seems like an oversight not to install the header file for libbpf,
given the libbpf.so + libbpf.a files are installed.
Signed-off-by: Jesper Dangaard Brouer
---
tools/lib/bpf/Makefile |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/lib/bpf/Makefile b/tools/lib/b
The plugin_dir_SQ variable is not used, remove it.
The function update_dir is also unused, remove it.
The variable $VERSION_FILES is empty, remove it.
These all originates from the introduction of the Makefile, and is likely a
copy paste
from tools/lib/traceevent/Makefile.
Fixes: 1b76c13e4b36 ("
The third parameter to do_install was not used by $(INSTALL) command.
Fix this by only setting the -m option when the third parameter is supplied.
The use of a third parameter was introduced in commit eb54e522a000 ("bpf:
install libbpf headers on 'make install'").
Without this change, the header
On Tue, Jan 16, 2018 at 9:20 AM, Alexander Aring wrote:
> int tc_setup_cb_call(struct tcf_block *block, struct tcf_exts *exts,
> -enum tc_setup_type type, void *type_data, bool err_stop)
> +enum tc_setup_type type, void *type_data, bool err_stop,
> +
On 01/16/2018 12:27 PM, Wei Yongjun wrote:
> Fixes the following sparse warnings:
>
> kernel/bpf/cpumap.c:146:6: warning:
> symbol '__cpu_map_queue_destructor' was not declared. Should it be static?
> kernel/bpf/cpumap.c:225:16: warning:
> symbol 'cpu_map_build_skb' was not declared. Should it b
On Tue, Jan 16, 2018 at 11:30:10PM +0100, Daniel Borkmann wrote:
> Alexei found that verifier does not reject stores into context
> via BPF_ST instead of BPF_STX. And while looking at it, we
> also should not allow XADD variant of BPF_STX.
>
> The context rewriter is only assuming either BPF_LDX_M
On Tue, Jan 16, 2018 at 9:20 AM, Alexander Aring wrote:
> @@ -1117,8 +1146,10 @@ int tcf_exts_validate(struct net *net, struct
> tcf_proto *tp, struct nlattr **tb,
> }
> #else
> if ((exts->action && tb[exts->action]) ||
> - (exts->police && tb[exts->police]))
> +
Setting th_min and th_max to the same value may be useful for DCTCP
deployments. The original DCTCP paper describes it as a simplest way
of achieving simple ECN threshold marking. Indeed, there doesn't seem
to be any simpler qdisc in Linux which would allow such a setup today.
Signed-off-by: Jak
On Tue, Jan 16, 2018 at 9:20 AM, Alexander Aring wrote:
> - if (root_ht == ht)
> + if (root_ht == ht) {
> + NL_SET_ERR_MSG(extack, "Not allowd to delete root node");
s/allowd/allowed/
On Tue, 16 Jan 2018 17:12:57 -0500, Jamal Hadi Salim wrote:
> On 18-01-16 04:46 PM, Jakub Kicinski wrote:
> > On Tue, 16 Jan 2018 12:20:19 -0500, Alexander Aring wrote:
>
> [..]
>
> > Ugh, this is going to conflict with our series too :( (and I CCed you
> > on ours)
> >
> > Would it be OK for
Alexei found that verifier does not reject stores into context
via BPF_ST instead of BPF_STX. And while looking at it, we
also should not allow XADD variant of BPF_STX.
The context rewriter is only assuming either BPF_LDX_MEM- or
BPF_STX_MEM-type operations, thus reject anything other than
that so
From: Johannes Berg
Fix two places where the structure isn't initialized to zero,
and thus can't be filled properly by the driver.
Fixes: 4a4b8169501b ("cfg80211: Accept multiple RSSI thresholds for CQM")
Fixes: 9930380f0bd8 ("cfg80211: implement IWRATE")
Signed-off-by: Johannes Berg
---
Dave,
On 18-01-16 04:46 PM, Jakub Kicinski wrote:
On Tue, 16 Jan 2018 12:20:19 -0500, Alexander Aring wrote:
[..]
Ugh, this is going to conflict with our series too :( (and I CCed you
on ours)
Would it be OK for you to hold off until Jiri's code gets merged and
ours comes down via bpf-next? That
Remove l2specific_len dependency while building l2tpv3 header or
parsing the received frame since default L2-Specific Sublayer is
always four bytes long and we don't need to rely on a user supplied
value.
Moreover in l2tp netlink code there are no sanity checks to
enforce the relation between l2spe
Remove l2specific_len configuration parameter since now L2-Specific
Sublayer length is computed according to l2specific_type provided by
userspace.
Reviewed-by: Guillaume Nault
Tested-by: Guillaume Nault
Signed-off-by: Lorenzo Bianconi
---
net/l2tp/l2tp_core.c| 1 -
net/l2tp/l2tp_core.h
Reviewed-by: Guillaume Nault
Tested-by: Guillaume Nault
Signed-off-by: Lorenzo Bianconi
---
include/uapi/linux/l2tp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/l2tp.h b/include/uapi/linux/l2tp.h
index 71e62795104d..7d570c7bd117 100644
--- a/include/u
Add sanity check on l2specific_type provided by userspace in
l2tp_nl_cmd_session_create() since just L2TP_L2SPECTYPE_DEFAULT and
L2TP_L2SPECTYPE_NONE are currently supported.
Moreover explicitly set l2specific_type to L2TP_L2SPECTYPE_DEFAULT
only if the userspace does not provide a value for it
Re
Do not rely on l2specific_len value provided by userspace but set sublayer
length according to l2specific_type.
Mark L2TP_ATTR_L2SPEC_LEN attribute as not used
Changes since v2:
- drop the patch related to a fix in the switch default case in
l2tp_nl_cmd_session_create()
- use L2SPECTYPE_NONE as
On Tue, 16 Jan 2018 12:20:27 -0500, Alexander Aring wrote:
> @@ -780,14 +787,18 @@ static int u32_set_parms(struct net *net, struct
> tcf_proto *tp,
> u32 handle = nla_get_u32(tb[TCA_U32_LINK]);
> struct tc_u_hnode *ht_down = NULL, *ht_old;
>
> - if (TC_U3
On Tue, 16 Jan 2018 12:20:19 -0500, Alexander Aring wrote:
> Hi,
>
> this patch adds extack support for TC classifier subsystem. The first
> patch fixes some code style issues for this patch series pointed out
> by checkpatch. The other patches until the last one prepares extack
> handling for the
From: Quentin Monnet
Propagate the extack pointer from the `->change()` classifier operation
to the function used for filter replacement in cls_flower. This makes it
possible to use netlink extack messages in the future at replacement
time for this filter, although it is not used at this point.
From: Quentin Monnet
Pass a pointer to an extack object to nfp_app_xdp_offload() in order to
prepare for extack usage in the nfp driver. Next step will be to forward
this extack pointer to nfp_net_bpf_offload(), once this function is able
to use it for printing error messages.
Signed-off-by: Que
From: Quentin Monnet
Propagate the extack pointer from the `->change()` classifier operation
to the function used for filter replacement in cls_u32. This makes it
possible to use netlink extack messages in the future at replacement
time for this filter, although it is not used at this point.
Sig
From: Quentin Monnet
Add an extra argument to `->change()` operation for passing a pointer to
a struct netlink_ext_ack. Update the operation for all classifiers
accordingly. Extack is not used at this point.
Signed-off-by: Quentin Monnet
Reviewed-by: Jakub Kicinski
---
include/net/sch_generic
From: Quentin Monnet
Create a wrapper around tc_can_offload() that takes an additional
extack pointer argument in order to output an error message if TC
offload is disabled on the device.
In this way, the error message is handled by the core and can be the
same for all drivers.
Signed-off-by: Q
From: Quentin Monnet
Use the recently added extack support for eBPF offload in the driver.
Signed-off-by: Quentin Monnet
Reviewed-by: Jakub Kicinski
---
drivers/net/ethernet/netronome/nfp/bpf/main.c| 31 ++--
drivers/net/ethernet/netronome/nfp/bpf/main.h| 2 +-
dr
From: Quentin Monnet
Add extack support for hardware offload of classifiers. In order
to achieve this, a pointer to a struct netlink_ext_ack is added to the
struct tc_cls_common_offload that is passed to the callback for setting
up the classifier. Function tc_cls_common_offload_init() is updated
From: Quentin Monnet
Use the recently added extack support for TC eBPF filters in netdevsim.
Signed-off-by: Quentin Monnet
Reviewed-by: Jakub Kicinski
---
drivers/net/netdevsim/bpf.c | 35 ---
1 file changed, 28 insertions(+), 7 deletions(-)
diff --git a/drive
From: Quentin Monnet
Propagate the extack pointer from the `->change()` classifier operation
to the function used for filter replacement in cls_matchall. This makes
it possible to use netlink extack messages in the future at replacement
time for this filter, although it is not used at this point.
Hi!
This series adds extack to cls offloads, as such it could arguably be
targeted at net-next. Unfortunately, git am is not able to deal cleanly
with minor conflicts on the nfp patches.. Since the series is really
about cls_bpf I hope it's OK if it went via the bpf-next tree.
There is a very m
1 - 100 of 296 matches
Mail list logo
