On Tue, 16 Jan 2018 12:20:27 -0500, Alexander Aring wrote: > @@ -780,14 +787,18 @@ static int u32_set_parms(struct net *net, struct > tcf_proto *tp, > u32 handle = nla_get_u32(tb[TCA_U32_LINK]); > struct tc_u_hnode *ht_down = NULL, *ht_old; > > - if (TC_U32_KEY(handle)) > + if (TC_U32_KEY(handle)) { > + NL_SET_ERR_MSG(extack, "u32 Link handle must be a hash > table"); > return -EINVAL; > + }
Since classifiers are commonly built as modules would it make more sense to use NL_SET_ERR_MSG_MOD()?