On 1/16/18 12:11 PM, Jakub Kicinski wrote: > On Tue, 16 Jan 2018 10:36:01 +0100, Jiri Pirko wrote: >>> @@ -303,7 +305,8 @@ static int nfp_net_bpf_load(struct nfp_net *nn, struct >>> bpf_prog *prog) >>> /* Load up the JITed code */ >>> err = nfp_net_reconfig(nn, NFP_NET_CFG_UPDATE_BPF); >>> if (err) >>> - nn_err(nn, "FW command error while loading BPF: %d\n", err); >>> + NL_SET_ERR_MSG_MOD(extack, >>> + "FW command error while loading BPF"); >> >> One line please. Same for all others. Strings may overflow 80 cols. > > Sorry, but this is the way I want things in the nfp driver. If the > string would fit 80 chars placed on a new line, it should be placed > on a new line. If it doesn't fit anyway the new line is unnecessary. > This rules is adhered to throughout the driver (to the extent I'm able > to enforce it). >
+1
