Eric Dumazet writes:
> On Wed, 2017-07-26 at 19:03 +0200, Matteo Croce wrote:
>> The following sysctl are global and can't be read or set from a netns:
>>
>> net.core.rmem_default
>> net.core.rmem_max
>> net.core.wmem_default
>> net.core.wmem_max
>>
>> Make the following sysctl parameters avail
On Mon, 31 Jul 2017, Eric Dumazet wrote:
> On Fri, 2017-07-28 at 22:18 +0200, Julia Lawall wrote:
> > The inet6_protocol structure is only passed as the first argument to
> > inet6_add_protocol or inet6_del_protocol, both of which are declared as
> > const. Thus the inet6_protocol structure its
1) Handle notifier registry failures properly in tun/tap driver, from
Tonghao Zhang.
2) Fix bpf verifier handling of subtraction bounds and add a testcase
for this, from Edward Cree.
3) Increase reset timeout in ftgmac100 driver, from Ben Herrenschmidt.
4) Fix use after free in prd_retire
From: William Tu
Date: Mon, 31 Jul 2017 14:40:50 -0700
> test_tunnel_bpf.sh fails to remove the vxlan11 tunnel device, causing the
> next geneve tunnelling test case fails. In addition, the geneve reserved bit
> in tcbpf2_kern.c should be zero, according to the RFC.
>
> Signed-off-by: William T
From: Paolo Abeni
Date: Mon, 31 Jul 2017 16:52:36 +0200
> Since commit 67a51780aebb ("ipv6: udp: leverage scratch area
> helpers") udp6_recvmsg() read the skb len from the scratch area,
> to avoid a cache miss.
> But the UDP6 rx path support RFC 2675 UDPv6 jumbograms, and their
> length exceeds t
From: gfree.w...@vip.163.com
Date: Mon, 31 Jul 2017 18:07:38 +0800
> From: Gao Feng
>
> The PPTP set the pptp_sock_destruct as the sock's sk_destruct, it would
> trigger this bug when __sk_free is invoked in atomic context, because of
> the call path pptp_sock_destruct->del_chan->synchronize_rcu
Mon, Jul 31, 2017 at 11:07:13PM CEST, xiyou.wangc...@gmail.com wrote:
>On Fri, Jul 28, 2017 at 7:40 AM, Jiri Pirko wrote:
>> From: Jiri Pirko
>>
>> Currently the actions are stored in array with array size. To traverse
>> this array in fastpath, tcf_tree_lock is taken to protect it. Convert
>> th
Mon, Jul 31, 2017 at 10:37:21PM CEST, xiyou.wangc...@gmail.com wrote:
>On Fri, Jul 28, 2017 at 7:40 AM, Jiri Pirko wrote:
>> +static inline int
>> +tcf_exts_exec(struct sk_buff *skb, struct tcf_exts *exts,
>> + struct tcf_result *res)
>> +{
>> +#ifdef CONFIG_NET_CLS_ACT
>> + if (
On Mon, 31 Jul 2017 08:06:42 -0400
Jamal Hadi Salim wrote:
> On 17-07-30 10:28 PM, David Miller wrote:
> >
> > Series applied, thanks.
> >
>
> Thanks David.
>
> Attaching the iproute2 patch. I will submit an official one with
> man page changes later. Stephen - you take net-next changes?
>
On Mon, 31 Jul 2017 17:40:50 -0700
Amritha Nambiar wrote:
The concept is fine, bu t the code looks different than the rest which
is never a good sign.
> + if ((argc > 0) && (matches(*argv, "tc") == 0)) {
Extra () are unnecessary in compound conditional.
> +
On Fri, Jul 28, 2017 at 6:54 PM, Neal Cardwell wrote:
> On Wed, Jul 26, 2017 at 3:02 PM, Neal Cardwell wrote:
>> On Wed, Jul 26, 2017 at 2:38 PM, Neal Cardwell wrote:
>>> Yeah, it looks like I can reproduce this issue with (1) bad sacks
>>> causing repeated TLPs, and (2) TLPs timers being pushed
Add support for sockets bound to a network interface enslaved to an
L3 Master device (e.g, VRF). Currently for VRF, skb->dev points to the
VRF device meaning socket lookups only consider this device index. The
real ingress device index is saved to IPCB(skb)->iif and the VRF driver
marks the skb wit
Convert __raw_v6_lookup to use the new sk_lookup struct
Signed-off-by: David Ahern
---
include/net/rawv6.h | 3 +--
net/ipv4/raw_diag.c | 15 ++-
net/ipv6/raw.c | 41 +++--
3 files changed, 34 insertions(+), 25 deletions(-)
diff --git a/incl
Convert __raw_v4_lookup to use the new sk_lookup struct
Signed-off-by: David Ahern
---
include/net/raw.h | 3 +--
net/ipv4/raw.c | 72 ++---
net/ipv4/raw_diag.c | 15 +++
3 files changed, 58 insertions(+), 32 deletions(-)
diff --gi
Add support for sockets bound to a network interface enslaved to an
L3 Master device (e.g, VRF). Currently for VRF, skb->dev points to the
VRF device meaning socket lookups only consider this device index. The
real ingress device index is saved to IP6CB(skb)->iif and the VRF driver
marks the skb wi
A missing piece to the VRF puzzle is the ability to bind sockets to
devices enslaved to a VRF. This patch set adds the enslaved device
index, sdif, to IPv4 and IPv6 socket lookups. The end result for users
is the following scope options for services:
1. "global" services - sockets not bound to any
Convert the various inet6_lookup functions to use the new sk_lookup
struct.
Signed-off-by: David Ahern
---
include/net/inet6_hashtables.h | 39 +++-
net/dccp/ipv6.c | 22
net/ipv4/inet_diag.c| 19 ++
net/ipv4/udp_diag.
Convert the various inet_lookup functions to use the new sk_lookup
struct.
Signed-off-by: David Ahern
---
include/net/inet_hashtables.h | 57 ++
net/dccp/ipv4.c | 19 +---
net/ipv4/inet_diag.c| 33 ++---
Add a second device index, sdif, to the socket lookup struct. sdif
will be the device index for devices enslaved to an l3mdev. It allows
the lookups to consider the enslaved device as well as the L3 master
device when searching for a socket.
Signed-off-by: David Ahern
---
include/net/sock.h | 12
Convert udp4_lib_lookup and __udp4_lib_lookup to use the new sk_lookup
struct.
Signed-off-by: David Ahern
---
include/net/udp.h | 6 +-
net/ipv4/netfilter/nf_socket_ipv4.c | 11 ++-
net/ipv4/udp.c | 170 +++-
net/ipv4/udp_
Consolidate the socket lookup args into a struct.
Add helper that compares sk_bound_dev_if for a socket to the lookup
parameters.
Signed-off-by: David Ahern
---
include/net/sock.h | 38 ++
1 file changed, 38 insertions(+)
diff --git a/include/net/sock.h b/in
Convert udp6_lib_lookup and __udp6_lib_lookup to use the new sk_lookup
struct.
Signed-off-by: David Ahern
---
include/net/udp.h | 12 +--
net/ipv4/udp_diag.c | 33 ---
net/ipv6/netfilter/nf_socket_ipv6.c | 11 ++-
net/ipv6/udp.c | 177
On Mon, Jul 31, 2017 at 11:49 AM, Neal Cardwell wrote:
> On Sun, Jul 30, 2017 at 11:29 PM, maowenan wrote:
>> [Mao Wenan]please refer to the attachment, test.pkt is packetdrill script.
>> In test.pcap, packet number 17 is the TLP probe, packet number 218 is the
>> retransmission packet because cl
Have tcp_schedule_loss_probe() base the TLP scheduling decision based
on when the RTO *should* fire. This is to enable the upcoming xmit
timer fix in this series, where tcp_schedule_loss_probe() cannot
assume that the last timer installed was an RTO timer (because we are
no longer doing the "rearm
Pure refactor. This helper will be required in the xmit timer fix
later in the patch series. (Because the TLP logic will want to make
this calculation.)
Fixes: 6ba8a3b19e76 ("tcp: Tail loss probe (TLP)")
Signed-off-by: Neal Cardwell
Signed-off-by: Yuchung Cheng
Signed-off-by: Nandita Dukkipati
This patch series is a bug fix for a TCP loss recovery performance bug
reported independently in recent netdev threads:
(i) July 26, 2017: netdev thread "TCP fast retransmit issues"
(ii) July 26, 2017: netdev thread:
"[PATCH V2 net-next] TLP: Don't reschedule PTO when there's one
Fix a TCP loss recovery performance bug raised recently on the netdev
list, in two threads:
(i) July 26, 2017: netdev thread "TCP fast retransmit issues"
(ii) July 26, 2017: netdev thread:
"[PATCH V2 net-next] TLP: Don't reschedule PTO when there's one
outstanding TLP retransmission"
T
On Mon, Jul 31, 2017 at 04:10:07PM -0700, Stephen Hemminger wrote:
> On Mon, 31 Jul 2017 10:18:57 -0700
> Shaohua Li wrote:
>
> > From: Shaohua Li
> >
> > In a syn flooding test, the fib6_table rwlock is a significant
> > bottleneck. While converting the rwlock to rcu sounds straighforward,
> >
On Tue, Aug 1, 2017 at 2:01 PM, David Ahern wrote:
> On 7/31/17 7:40 PM, Xin Long wrote:
>> To respect the old code more, setting RTPROT_RA only when
>> it's with the flag (ADDRCONF | DEFAULT | ROUTEINFO),
>> shouldn't it be:
>
> Look at rtm_fill_info:
>
> if (rt->rt6i_flags & (RTF_DEFAULT
On Mon, Jul 31, 2017 at 05:59:37PM -0700, David Miller wrote:
> From: Simon Horman
> Date: Sun, 30 Jul 2017 22:21:04 +0200
>
> > On Fri, Jul 28, 2017 at 11:17:07PM -0700, Felix Manlunas wrote:
> >> From: Veerasenareddy Burru
> >>
> >> The LiquidIO adapter has processor cores that can run Linux.
On 7/31/17 7:40 PM, Xin Long wrote:
> To respect the old code more, setting RTPROT_RA only when
> it's with the flag (ADDRCONF | DEFAULT | ROUTEINFO),
> shouldn't it be:
Look at rtm_fill_info:
if (rt->rt6i_flags & (RTF_DEFAULT | RTF_ROUTEINFO))
rtm->rtm_protocol =
On Tue, Jul 18, 2017 at 11:58:27AM -0700, Jakub Kicinski wrote:
> On Mon, 17 Jul 2017 12:52:17 -0700, Felix Manlunas wrote:
> > From: VSR Burru
> >
> > This patch adds support to create a virtual ethernet interface to
> > communicate with Linux on LiquidIO adapter for management.
> >
> > Signed-
On Tue, Aug 1, 2017 at 12:12 PM, David Ahern wrote:
> On 7/30/17 9:31 PM, Xin Long wrote:
>>> Did you look at removing this hunk from rt6_fill_node:
>>>
>>> if (rt->rt6i_flags & RTF_DYNAMIC)
>>> rtm->rtm_protocol = RTPROT_REDIRECT;
>>> else if (rt->rt6i_flags & RTF_
When using Broadcom Systemport device in 32bit Platform, ifconfig can
only report up to 4G tx,rx status, which will be wrapped to 0 when the
number of incoming or outgoing packets exceeds 4G, only taking
around 2 hours in busy network environment (such as streaming).
Therefore, it makes hard for ne
From: Florian Fainelli
Date: Mon, 31 Jul 2017 11:05:32 -0700
> This reverts commit 28b45910ccda ("net: bcmgenet: Remove init parameter
> from bcmgenet_mii_config") because in the process of moving from
> dev_info() to dev_info_once() we essentially lost the helpful printed
> messages once the sec
From: Jakub Sitnicki
Date: Mon, 31 Jul 2017 10:09:41 +0200
> There is no need to go through sk->sk_net to access the net namespace
> and its sysctl variables because we allocate the sock and initialize
> sk_net just a few lines earlier in the same routine.
>
> Signed-off-by: Jakub Sitnicki
App
From: Andrew Lunn
Date: Sun, 30 Jul 2017 22:41:43 +0200
> Consolidate more duplicated code into helpers, make use of core
> helpers, move code into a helper for later adding functionality to add
> marvell PHYs, etc.
Series applied.
From: Simon Horman
Date: Sun, 30 Jul 2017 22:21:04 +0200
> On Fri, Jul 28, 2017 at 11:17:07PM -0700, Felix Manlunas wrote:
>> From: Veerasenareddy Burru
>>
>> The LiquidIO adapter has processor cores that can run Linux. This patch
>> set adds support to create a virtual Ethernet interface on ho
From: Sergei Shtylyov
Date: Sat, 29 Jul 2017 22:18:41 +0300
> of_irq_to_resource() has recently been fixed to return negative error #'s
> along with 0 in case of failure, however the Marvell MV643xx Ethernet
> driver still only regards 0 as invalid IRQ -- fix it up.
>
> Fixes: 7a4228bbff76 ("
From: Julia Lawall
Date: Sat, 29 Jul 2017 17:54:10 +0200 (CEST)
> Make sure (of/i2c/platform)_device_id tables are NULL terminated
>
> Generated by: scripts/coccinelle/misc/of_table.cocci
>
> Fixes: d5dbe1976d52 ("net-next: stmmac: dwmac-sun8i: choose internal PHY via
> compatible")
> CC: Core
From: Florian Fainelli
Date: Mon, 31 Jul 2017 17:53:07 -0700
> The driver needs CONFIG_HAS_IOMEM and OF to be functional, but we still
> let it build with COMPILE_TEST. This fixes the unmet dependency after
> selecting MDIO_BCM_UNIMAC in commit mentioned below:
>
> warning: (NET_DSA_BCM_SF2 && B
The driver needs CONFIG_HAS_IOMEM and OF to be functional, but we still
let it build with COMPILE_TEST. This fixes the unmet dependency after
selecting MDIO_BCM_UNIMAC in commit mentioned below:
warning: (NET_DSA_BCM_SF2 && BCMGENET) selects MDIO_BCM_UNIMAC which has
unmet direct dependencies (NET
From: Florian Fainelli
Date: Mon, 31 Jul 2017 09:47:50 -0700
> Include missing files that are provided by, used, or directly maintained
> within the PHY LIBRARY, this include uapi header, header files used by
> Device Tree code etc.
>
> Signed-off-by: Florian Fainelli
Applied.
From: Ido Schimmel
Date: Fri, 28 Jul 2017 23:27:44 +0300
> Michał reported a NULL pointer deref during fib_sync_down_dev() when
> unregistering a netdevice. The problem is that we don't check for
> 'in_dev' being NULL, which can happen in very specific cases.
>
> Usually routes are flushed upon
The Mirred/redirect action is extended to accept a traffic
class on the device in addition to the device's ifindex.
Usage: mirred
Example:
# tc qdisc add dev eth0 ingress
# tc filter add dev eth0 protocol ip parent : prio 1 flower\
dst_ip 192.168.1.1/32 ip_proto udp dst_port 22\
inde
Add new admin queue definitions and extended fields for cloud
filter support. Define big buffer for extended general fields
in Add/Remove Cloud filters command.
Signed-off-by: Amritha Nambiar
Signed-off-by: Kiran Patil
Signed-off-by: Store Laura
Signed-off-by: Iremonger Bernard
Signed-off-by:
This patch enables tc-flower based hardware offloads. tc/flower
filter provided by the kernel is configured as driver specific
cloud filter. The patch implements functions and admin queue
commands needed to support cloud filters in the driver and
adds cloud filters to configure these tc-flower filt
Add definitions for L4 filters and switch modes based on cloud filters
modes and extend the set switch config command to include the
additional cloud filter mode.
Signed-off-by: Amritha Nambiar
Signed-off-by: Kiran Patil
---
drivers/net/ethernet/intel/i40e/i40e_adminq_cmd.h | 34 +
Add mapping of TCs with the seids of the channel VSIs. TC0
will be mapped to the main VSI seid and all other TCs are
mapped to the seid of the channel VSI.
Signed-off-by: Amritha Nambiar
---
drivers/net/ethernet/intel/i40e/i40e.h |1 +
drivers/net/ethernet/intel/i40e/i40e_main.c |2
The Mirred/redirect action is extended to forward to a traffic
class on the device. The traffic class index needs to be
provided in addition to the device's ifindex.
Example:
# tc filter add dev eth0 protocol ip parent : prio 1 flower\
dst_ip 192.168.1.1/32 ip_proto udp dst_port 22\
skip_s
Introduce the cloud filter datastructure and cleanup of cloud
filters associated with the device.
Signed-off-by: Amritha Nambiar
---
drivers/net/ethernet/intel/i40e/i40e.h | 11 +++
drivers/net/ethernet/intel/i40e/i40e_main.c | 27 +++
2 files changed, 38
This patch series enables configuring cloud filters in i40e
using the tc/flower classifier. The only tc-filter action
supported is to redirect packets to a traffic class on the
same device. The tc/mirred:redirect action is extended to
accept a traffic class to achieve this.
The cloud filters are a
On 07/31/2017 05:28 PM, kbuild test robot wrote:
> Hi Florian,
>
> [auto build test ERROR on net-next/master]
>
> url:
> https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-bcmgenet-utilize-MDIO-unimac-driver/20170801-075847
> config: xtensa-allmodconfig (attached as .config)
> comp
Hi Florian,
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-bcmgenet-utilize-MDIO-unimac-driver/20170801-075847
config: xtensa-allmodconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 4.9.0
reproduce:
wget
https
From: Florian Fainelli
Date: Fri, 28 Jul 2017 11:58:36 -0700
> Marc reported that he was not getting the PHY library adjust_link()
> callback function to run when calling phy_stop() + phy_disconnect()
> which does not indeed happen because we set the state machine to
> PHY_HALTED but we don't get
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
master
head: 6a95befc8d0346d6cb3b4646c761e8b42e66a4df
commit: 9a4e79697009ddd0d1af52053c830f6e60e1c771 [345/358] net: bcmgenet:
utilize generic Broadcom UniMAC MDIO controller driver
config: x86_64-randconfig-x001-201731
From: Anton Volkov
Date: Fri, 28 Jul 2017 17:53:51 +0300
> The synchronization type that was used earlier to guard the loop that
> deletes unused log buffers may have lead to a situation that prevents
> any thread from going through the loop.
>
> The patch deletes previously used synchronization
From: Wei Wang
Date: Fri, 28 Jul 2017 10:28:20 -0700
> From: Wei Wang
>
> Refactor the code to extract the function to compute delivery rate.
> This function will be used in later commit.
>
> Signed-off-by: Wei Wang
> Acked-by: Yuchung Cheng
> Acked-by: Soheil Hassas Yeganeh
Applied.
From: Wei Wang
Date: Fri, 28 Jul 2017 10:28:21 -0700
> From: Wei Wang
>
> Add the following stats into SCM_TIMESTAMPING_OPT_STATS control msg:
> TCP_NLA_PACING_RATE
> TCP_NLA_DELIVERY_RATE
> TCP_NLA_SND_CWND
> TCP_NLA_REORDERING
> TCP_NLA_MIN_RTT
> TCP_NLA_RECUR_RETRANS
On 7/30/17 9:31 PM, Xin Long wrote:
>> Did you look at removing this hunk from rt6_fill_node:
>>
>> if (rt->rt6i_flags & RTF_DYNAMIC)
>> rtm->rtm_protocol = RTPROT_REDIRECT;
>> else if (rt->rt6i_flags & RTF_ADDRCONF) {
>> if (rt->rt6i_flags & (RTF_DEF
On 7/31/17 4:01 PM, Cong Wang wrote:
>>> diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
>>> index 3a19ea28339f..37db087b6c97 100644
>>> --- a/net/ipv4/tcp_ipv4.c
>>> +++ b/net/ipv4/tcp_ipv4.c
>>> @@ -1855,7 +1855,7 @@ void inet_sk_rx_dst_set(struct sock *sk, const
>>> struct sk_buff *skb)
>
This patch set changes how SR-IOV Virtual Function devices are managed
in the Hyper-V network driver. It was part of earlier bundle, but
is now updated.
Background
In Hyper-V SR-IOV can be enabled (and disabled) by changing guest settings
on host. When SR-IOV is enabled a matching PCI device is h
This patch implements transparent fail over from synthetic NIC to
SR-IOV virtual function NIC in Hyper-V environment. It is a better
alternative to using bonding as is done now. Instead, the receive and
transmit fail over is done internally inside the driver.
Using bonding driver has lots of issue
No longer needed, now all managed by transparent VF logic.
Signed-off-by: Stephen Hemminger
---
tools/hv/bondvf.sh | 255 -
1 file changed, 255 deletions(-)
delete mode 100755 tools/hv/bondvf.sh
diff --git a/tools/hv/bondvf.sh b/tools/hv/bond
Add some background documentation on netvsc device options
and limitations.
Signed-off-by: Stephen Hemminger
---
Documentation/networking/netvsc.txt | 63 +
MAINTAINERS | 1 +
2 files changed, 64 insertions(+)
create mode 100644 Docum
On Mon, 31 Jul 2017 08:06:42 -0400
Jamal Hadi Salim wrote:
> On 17-07-30 10:28 PM, David Miller wrote:
> >
> > Series applied, thanks.
> >
>
> Thanks David.
>
> Attaching the iproute2 patch. I will submit an official one with
> man page changes later. Stephen - you take net-next changes?
>
On Mon, 31 Jul 2017 16:37:12 -0700
Stephen Hemminger wrote:
> The setup of MSI with Hyper-V host was sleeping with locks held.
> This error is reported when doing SR-IOV hotplug with kernel built with
> lockdep.
>
> BUG: sleeping function called from invalid context at
> kernel/sched/compl
From: David Ahern
Date: Mon, 31 Jul 2017 17:34:09 -0600
> On 7/31/17 5:22 PM, David Miller wrote:
>> From: Hangbin Liu
>> Date: Fri, 28 Jul 2017 00:25:36 +0800
>>
>>> After commit 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib
>>> result when requested"). When we get a prohibit ertr
The setup of MSI with Hyper-V host was sleeping with locks held.
This error is reported when doing SR-IOV hotplug with kernel built with lockdep.
BUG: sleeping function called from invalid context at
kernel/sched/completion.c:93
in_atomic(): 1, irqs_disabled(): 1, pid: 1405, name: ip
This patch implements transparent fail over from synthetic NIC to
SR-IOV virtual function NIC in Hyper-V environment. It is a better
alternative to using bonding as is done now. Instead, the receive and
transmit fail over is done internally inside the driver.
Using bonding driver has lots of issue
No longer needed, now all managed by transparent VF logic.
Signed-off-by: Stephen Hemminger
---
tools/hv/bondvf.sh | 255 -
1 file changed, 255 deletions(-)
delete mode 100755 tools/hv/bondvf.sh
diff --git a/tools/hv/bondvf.sh b/tools/hv/bond
This patch set changes how SR-IOV Virtual Function devices are managed
in the Hyper-V network driver. It was part of earlier bundle, but
is now updated.
Background
In Hyper-V SR-IOV can be enabled (and disabled) by changing guest settings
on host. When SR-IOV is enabled a matching PCI device is ho
Add some background documentation on netvsc device options
and limitations.
Signed-off-by: Stephen Hemminger
---
Documentation/networking/netvsc.txt | 63 +
MAINTAINERS | 1 +
2 files changed, 64 insertions(+)
create mode 100644 Docum
On 7/31/17 5:22 PM, David Miller wrote:
> From: Hangbin Liu
> Date: Fri, 28 Jul 2017 00:25:36 +0800
>
>> After commit 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib
>> result when requested"). When we get a prohibit ertry, we will return
>> -EACCES directly instead of dump route info.
From: Hangbin Liu
Date: Fri, 28 Jul 2017 00:25:36 +0800
> After commit 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib
> result when requested"). When we get a prohibit ertry, we will return
> -EACCES directly instead of dump route info.
>
> Fix it by remove the rt->dst.error check.
.
From: Marc Gonzalez
Date: Fri, 28 Jul 2017 13:18:30 +0200
> In the current code, old and new PHY states are always logged.
> From now on, log only PHY state transitions.
>
> Signed-off-by: Marc Gonzalez
Applied to net-next, thanks.
On Mon, 31 Jul 2017 10:18:57 -0700
Shaohua Li wrote:
> From: Shaohua Li
>
> In a syn flooding test, the fib6_table rwlock is a significant
> bottleneck. While converting the rwlock to rcu sounds straighforward,
> but is very challenging if it's possible. A percpu spinlock is quite
> trival for
Hi Rafał,
[auto build test WARNING on driver-core/driver-core-testing]
[also build test WARNING on v4.13-rc3 next-20170731]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Rafa-Mi-ecki/firmware
On Mon, Jul 31, 2017 at 03:35:02PM -0700, Cong Wang wrote:
> On Mon, Jul 31, 2017 at 3:19 PM, Shaohua Li wrote:
> > static inline __be32 ip6_make_flowlabel(struct net *net, struct sk_buff
> > *skb,
> > __be32 flowlabel, bool autolabel,
> > -
On Mon, Jul 31, 2017 at 3:19 PM, Shaohua Li wrote:
> static inline __be32 ip6_make_flowlabel(struct net *net, struct sk_buff *skb,
> __be32 flowlabel, bool autolabel,
> - struct flowi6 *fl6)
> +
Even though EEE implies the port's PHY and MAC of both ends, a switch
may not need to do anything to configure the port's MAC.
This makes it impossible for the DSA layer to distinguish e.g. this case
from a disabled EEE when a driver returns 0 from the get EEE operation.
For this reason, make the
To avoid confusion with the PHY EEE settings, rename the .set_eee and
.get_eee ops to respectively .set_mac_eee and .get_mac_eee.
Signed-off-by: Vivien Didelot
---
drivers/net/dsa/bcm_sf2.c | 12 ++--
drivers/net/dsa/qca8k.c | 4 ++--
include/net/dsa.h | 10 +-
net/dsa
If EEE is queried enabled, qca8k_set_eee calls qca8k_eee_enable_set
twice (because it is already called in qca8k_eee_init). Fix that.
Signed-off-by: Vivien Didelot
---
drivers/net/dsa/qca8k.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/dsa/qca8k.c b/drive
EEE implies configuring the port's PHY and MAC of both ends of the wire.
The current EEE support in DSA mixes PHY and MAC configuration, which is
bad because PHYs must be configured through a proper PHY driver. The DSA
switch operations for EEE are only meant for configuring the port's MAC,
which
It is safer to init the EEE before the DSA layer call
phy_ethtool_set_eee, as sf2 and qca8k are doing.
Signed-off-by: Vivien Didelot
---
drivers/net/dsa/mv88e6xxx/chip.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
The DSA switch operations for EEE are only meant to configure a port's
MAC EEE settings. The port's PHY EEE settings are accessed by the DSA
layer and must be made available via a proper PHY driver.
In order to reduce this confusion, remove the phy_device argument from
the .set_eee operation.
Sig
All DSA drivers are calling phy_init_eee if eee_enabled is true.
Move up this statement in the DSA layer to simplify the DSA drivers.
qca8k does not require to cache the ethtool_eee structures from now on.
Signed-off-by: Vivien Didelot
---
drivers/net/dsa/bcm_sf2.c| 9 +
driver
The PHY's EEE settings are already accessed by the DSA layer through the
Marvell PHY driver and there is nothing to be done for switch's MACs.
Remove all EEE support from the mv88e6xxx driver.
Signed-off-by: Vivien Didelot
---
drivers/net/dsa/mv88e6xxx/chip.c | 82 --
The qca8k obviously copied code from the sf2 driver as how to set EEE:
if (e->eee_enabled) {
p->eee_enabled = qca8k_eee_init(ds, port, phydev);
if (!p->eee_enabled)
ret = -EOPNOTSUPP;
}
But it did not use the same logic for the EEE init routine, which is
"Retur
The qca8k driver is currently caching a bitfield of the supported member
of a ethtool_eee private structure, which is unused.
Only the eee_enabled field of the private ethtool_eee copy is updated,
thus using p->advertised and p->lp_advertised is also erroneous.
Remove the usage of these private e
phy_ethtool_get_eee is already called by the DSA layer, thus remove the
duplicated call in the qca8k driver. qca8k_get_eee becomes unnecessary.
Signed-off-by: Vivien Didelot
---
drivers/net/dsa/qca8k.c | 17 -
1 file changed, 17 deletions(-)
diff --git a/drivers/net/dsa/qca8k.c
The SF2 driver is masking the supported bitfield of its private copy of
the ports' ethtool_eee structures. It is used nowhere, thus remove it.
Signed-off-by: Vivien Didelot
---
drivers/net/dsa/bcm_sf2.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/ne
From: Shaohua Li
According to David Miller, the rotation doesn't really help avoid
security problem, so delte it.
Suggested-by: David Miller
Signed-off-by: Shaohua Li
---
include/net/ipv6.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/include/net/ipv6.h b/include/net/ipv6.h
index
From: Shaohua Li
Please see below tcpdump output:
21:00:48.109122 IP6 (flowlabel 0x43304, hlim 64, next-header TCP (6) payload
length: 40) fec0::5054:ff:fe12:3456.55804 > fec0::5054:ff:fe12:3456.: Flags
[S], cksum 0x0529 (incorrect -> 0xf56c), seq 3282214508, win 43690, options
[mss 65476,
From: Shaohua Li
Please see below tcpdump output:
21:00:48.109122 IP6 (flowlabel 0x43304, hlim 64, next-header TCP (6) payload
length: 40) fec0::5054:ff:fe12:3456.55804 > fec0::5054:ff:fe12:3456.: Flags
[S], cksum 0x0529 (incorrect -> 0xf56c), seq 3282214508, win 43690, options
[mss 65476,
On 07/29/17 01:12 PM, Tom Herbert wrote:
> On Wed, Jun 14, 2017 at 11:37 AM, Dave Watson wrote:
> > Add the infrustructure for attaching Upper Layer Protocols (ULPs) over TCP
> > sockets. Based on a similar infrastructure in tcp_cong. The idea is that
> > any
> > ULP can add its own logic by cha
On Mon, Jul 31, 2017 at 9:22 AM, Rolf Neugebauer
wrote:
> On Fri, Jul 28, 2017 at 8:16 PM, David Ahern wrote:
>> On 7/28/17 12:58 PM, Rolf Neugebauer wrote:
> I can readily reproduce this on 4.9.39, 4.11.12 and another user
> repro-ed it on 4.12.3. It seems to happen every time. At least
On 07/30/17 11:14 PM, David Oberhollenzer wrote:
> On 07/24/2017 11:10 PM, Dave Watson wrote:
> > On 07/23/17 09:39 PM, David Oberhollenzer wrote:
> >> After fixing the benchmark/test tool that the patch description
> >> linked to (https://github.com/Mellanox/tls-af_ktls_tool) to make
> >> sure tha
From: Jiri Pirko
Date: Mon, 31 Jul 2017 09:27:22 +0200
> This patch series is to contribute several fixes for nits that I noticed while
> working on mlxsw. The changes range from typo fixes to local improvements of
> the code and have little in common besides being small in scope.
Series applied
From: Florian Fainelli
Date: Mon, 31 Jul 2017 12:04:21 -0700
> Hi all,
>
> This patch series migrates the Broadcom GENET driver to use the
> mdio-bcm-unimac
> driver. This MDIO HW is the same as the one GENET internally embedds, yet for
> historical reasons the two drivers lived their own lives
1 - 100 of 230 matches
Mail list logo
