From: David Ahern <dsah...@gmail.com> Date: Mon, 31 Jul 2017 17:34:09 -0600
> On 7/31/17 5:22 PM, David Miller wrote: >> From: Hangbin Liu <liuhang...@gmail.com> >> Date: Fri, 28 Jul 2017 00:25:36 +0800 >> >>> After commit 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib >>> result when requested"). When we get a prohibit ertry, we will return >>> -EACCES directly instead of dump route info. >>> >>> Fix it by remove the rt->dst.error check. >> ... >>> Fixes: 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib...") >>> Signed-off-by: Hangbin Liu <liuhang...@gmail.com> >> >> David A., where are we on this? >> > > Dizzy from running in circles. :-) > Question I posed to you Saturday morning, 8:41 MDT [1]: > > "... Roopa's fibmatch patches caused a change in user behavior in IPv6 > getroute for prohibit, blackhole and unreachable route entries. Opinions > on whether we should limit that new behavior to just the fibmatch lookup > in which case a patch is needed or take the new behavior and consistency > in which case nothing is needed?" > > Personally, after all the discussion I think the behavior as it is right > now is best. > > [1] https://www.spinics.net/lists/netdev/msg446571.html I agree with you that we should keep the behavior as is.