Regarding xfrm state search with destination address as wildcard mask

Hi All, Im trying to implement IPSec for ospfv3 as per RFC4552 on Linux kernel version 3.16.39. Requirement is to support IPsec encryption/authentication for ospfv3 traffic. As of now, this can be achieved by following set of SA and SP rules. ip xfrm state add src :: dst ff02::5 proto ah spi 0x40

[PATCH net-next] TLS: Fix length check in do_tls_getsockopt_tx()

copy_to_user() copies the struct the pointer is pointing to, but the length check compares against sizeof(pointer) and not sizeof(struct). On 32-bit the size is probably the same, so it might have worked accidentally. Signed-off-by: Matthias Rosenfelder --- net/tls/tls_main.c | 2 +- 1 file chan

Re: [PATCH v2] arm: eBPF JIT compiler

Hi Kees, Problem is my ARM machine don't have clang and iproute2 which is keeping me from testing the bpf tail calls. You should do the following to test it,. 1. tools/testing/selftests/bpf/ 2. make 3. sudo ./test_progs And, before testing, you have to do "make headers_install". These tests are

[PATCH net V2 1/2] net: hns: Fix a wrong op phy C45 code

From: Yunsheng Lin As the user manual described, the second step to write to C45 phy by mdio should be data, but not address. Here we should fix this issue. Fixes: 5b904d39406a ("net: add Hisilicon Network Subsystem MDIO support") Signed-off-by: Yunsheng Lin Reviewed-by: lipeng --- drivers/ne

[PATCH net V2 2/2] net: hns: Fix a skb used after free bug

From: Yunsheng Lin skb maybe freed in hns_nic_net_xmit_hw() and return NETDEV_TX_OK, which cause hns_nic_net_xmit to use a freed skb. BUG: KASAN: use-after-free in hns_nic_net_xmit_hw+0x62c/0x940... [17659.112635] alloc_debug_processing+0x18c/0x1a0 [17659.117208] __slab

[PATCH net V2 0/2] Bugfixs for hns ethernet driver

This patchset fix skb used after free and C45 op code issues in hns driver. Patch V2: 1. Remove ndev->feature checking in TX description patch. 2. Add Fixes: Tag in patch description. Patch V1: Initial Submit Yunsheng Lin (2): net: hns: Fix a wrong op phy C45 code net

Re: [RFC PATCH linus] tcp: md5: tcp_md5_do_lookup_exact() can be static

Hi, Not sure why you sent this to me ... it fixes a commit in the net-next tree (now in Linus' tree) ... On Thu, 6 Jul 2017 07:58:53 +0800 kbuild test robot wrote: > > Fixes: 0c5f0311f690 ("Add linux-next specific files for 20170705") Actually: Fixes: 6797318e623d (&quo

Re: [PATCH net] virtio-net: unbreak cusmed packet for small buffer XDP

On Tue, Jul 04, 2017 at 08:20:00PM +0800, Jason Wang wrote: > > IIUC XDP generally refuses to attach if checksum offload > > is enabled. > > Any reason to do this? (Looks like I don't see any code for this) Some of it was covered here https://www.mail-archive.com/netdev@vger.kernel.org/msg162577.

Re: [PATCH RFC 21/26] powerpc: Remove spin_unlock_wait() arch-specific definitions

On Sun, Jul 02, 2017 at 11:58:07AM +0800, Boqun Feng wrote: > On Thu, Jun 29, 2017 at 05:01:29PM -0700, Paul E. McKenney wrote: > > There is no agreed-upon definition of spin_unlock_wait()'s semantics, > > and it appears that all callers could do just as well with a lock/unlock > > pair. This comm

net/ipv4/tcp_ipv4.c:950:23: sparse: symbol 'tcp_md5_do_lookup_exact' was not declared. Should it be static?

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: b4b8cbf679c4866a523a35d1454884a31bd5d8dc commit: 6797318e623da68dfbacd0cb5c246f5ecd2baf6e tcp: md5: add an address prefix for key lookup date: 2 weeks ago reproduce: # apt-get install sparse

[RFC PATCH linus] tcp: md5: tcp_md5_do_lookup_exact() can be static

Fixes: 0c5f0311f690 ("Add linux-next specific files for 20170705") Signed-off-by: Fengguang Wu --- tcp_ipv4.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c index 6ec6900..a20e7f0 100644 --- a/net/ipv4/tcp_ipv4.c

[PATCH v2 8/9] locking: Remove spin_unlock_wait() generic definitions

There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore removes spin_unlock_wait() and related definitions from core code. Signed-off-by: Paul E. McKenney Cc: Arnd Bergmann Cc: Ing

[PATCH v2 9/9] arch: Remove spin_unlock_wait() arch-specific definitions

There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore removes the underlying arch-specific arch_spin_unlock_wait() for all architectures providing them. Signed-off-by: Paul E. McKe

[PATCH v2 7/9] drivers/ata: Replace spin_unlock_wait() with lock/unlock pair

There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore eliminates the spin_unlock_wait() call and associated else-clause and hoists the then-clause's lock and unlock out of the "if"

[PATCH v2 6/9] ipc: Replace spin_unlock_wait() with lock/unlock pair

There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore replaces the spin_unlock_wait() call in exit_sem() with spin_lock() followed immediately by spin_unlock(). This should be safe

[PATCH v2 4/9] completion: Replace spin_unlock_wait() with lock/unlock pair

There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore replaces the spin_unlock_wait() call in completion_done() with spin_lock() followed immediately by spin_unlock(). This should b

[PATCH v2 5/9] exit: Replace spin_unlock_wait() with lock/unlock pair

There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore replaces the spin_unlock_wait() call in do_exit() with spin_lock() followed immediately by spin_unlock(). This should be safe f

[PATCH v2 3/9] sched: Replace spin_unlock_wait() with lock/unlock pair

There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore replaces the spin_unlock_wait() call in do_task_dead() with spin_lock() followed immediately by spin_unlock(). This should be s

[PATCH v2 1/9] net/netfilter/nf_conntrack_core: Fix net_conntrack_lock()

From: Manfred Spraul As we want to remove spin_unlock_wait() and replace it with explicit spin_lock()/spin_unlock() calls, we can use this to simplify the locking. In addition: - Reading nf_conntrack_locks_all needs ACQUIRE memory ordering. - The new code avoids the backwards loop. Only slightl

[PATCH v2 2/9] task_work: Replace spin_unlock_wait() with lock/unlock pair

From: Oleg Nesterov There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore replaces the spin_unlock_wait() call in task_work_run() with a spin_lock_irq() and a spin_unlock_irq() ar

[PATCH v2 0/9] Remove spin_unlock_wait()

Hello! There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This series therefore removes spin_unlock_wait() and changes its users to instead use a lock/unlock pair. The commits are as follows, in thr

Re: Way to Know When cleanup_net() Calls Are Done

In my case, as I know the number of unshare(2) calls (say 1), I think there should be same number of net_drop_ns() calls regardless of the userns counter. So the 1th call to net_drop_ns() should be the last one. After some investigation I figure out my problem. When I was running the progr

Re: Way to Know When cleanup_net() Calls Are Done

On Sat, Jul 1, 2017 at 10:50 PM, Leon Yang wrote: > Hi, > > I am measuring the time cost of parallel creation and destruction of > net namespaces. > > As cleanup_net() is invoked from workqueue, the exit of a net > namespace does not mean the cleanup is completed. Therefore I use > ftrace to count

Re: [PATCH 0/2] bring UP loopback device at initialziation

> I wonder if it is too late to change this since this behavior is probably > from the beginning of network namespace. A networkless netns is also > useful at least for testing purpose, we do use it as a sandbox. > Sandbox is my use case too but i'm worried about all other things that a process ins

Re: [PATCH net] ip[6]: don't register inet[6]dev when dev is down

On Wed, Jul 5, 2017 at 8:57 AM, Nicolas Dichtel wrote: > When a device changes from one netns to another, it's first unregistered, > then the netns reference is updated and the dev is registered in the new > netns. Thus, when a slave moves to another netns, it is first > unregistered. This trigger

Re: [PATCH v2] arm: eBPF JIT compiler

On Wed, Jul 5, 2017 at 3:11 PM, Kees Cook wrote: > On Fri, Jun 23, 2017 at 3:39 PM, Shubham Bansal > wrote: >> Hi Russell,Daniel and Kees, >> >> I am attaching the latest patch with this mail. It included support >> for BPF_CALL | BPF_JMP tested with and without constant blinding on >> ARMv7 mach

Re: [PATCH v2] arm: eBPF JIT compiler

On Fri, Jun 23, 2017 at 3:39 PM, Shubham Bansal wrote: > Hi Russell,Daniel and Kees, > > I am attaching the latest patch with this mail. It included support > for BPF_CALL | BPF_JMP tested with and without constant blinding on > ARMv7 machine. > Due to the limitation on my machine I can't test the

Re: [PATCH net] net: ipv6: Compare lwstate in detecting duplicate nexthops

On Wed, Jul 05, 2017 at 02:14:33PM -0700, Roopa Prabhu wrote: > > Lennert reported a failure to add different mpls encaps in a multipath > > route: > > > > $ ip -6 route add 1234::/16 \ > > nexthop encap mpls 10 via fe80::1 dev ens3 \ > > nexthop encap mpls 20 via fe80::1 dev ens

[PATCH net-next v2] net/packet: Fix Tx queue selection for AF_PACKET

When PACKET_QDISC_BYPASS is not used, Tx queue selection will be done before the packet is enqueued, taking into account any mappings set by a queuing discipline such as mqprio without hardware offloading. This selection may be affected by a previously saved queue_mapping, either on the Rx path, or

RE: [Intel-wired-lan] [PATCH 1/2] i40e/i40evf: rename vf_offload_flags to vf_cap_flags in struct virtchnl_vf_resource

> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On Behalf > Of Stefan Assmann > Sent: Thursday, June 29, 2017 6:12 AM > To: intel-wired-...@lists.osuosl.org > Cc: netdev@vger.kernel.org; da...@davemloft.net; sassm...@kpanic.de > Subject: [Intel-wired

Re: [PATCH net] net: ipv6: Compare lwstate in detecting duplicate nexthops

On Wed, Jul 5, 2017 at 1:41 PM, David Ahern wrote: > Lennert reported a failure to add different mpls encaps in a multipath > route: > > $ ip -6 route add 1234::/16 \ > nexthop encap mpls 10 via fe80::1 dev ens3 \ > nexthop encap mpls 20 via fe80::1 dev ens3 > RTNETLINK answers

Re: [PATCH net-next 1/1] net sched actions: rename act_get_notify() to tcf_get_notify()

Jiri Pirko writes: > Wed, Jul 05, 2017 at 09:33:58PM CEST, m...@mojatatu.com wrote: >>Make name consistent with other TC event notification routines. >> >>Signed-off-by: Roman Mashak >>--- >> net/sched/act_api.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >>diff --git a/net/sc

[Patch net] tap: convert a mutex to a spinlock

We are not allowed to block on the RCU reader side, so can't just hold the mutex as before. As a quick fix, convert it to a spinlock. Fixes: d9f1f61c0801 ("tap: Extending tap device create/destroy APIs") Reported-by: Christian Borntraeger Cc: Sainath Grandhi Signed-off-by: Cong Wang --- driver

[PATCH net] net: ipv6: Compare lwstate in detecting duplicate nexthops

Lennert reported a failure to add different mpls encaps in a multipath route: $ ip -6 route add 1234::/16 \ nexthop encap mpls 10 via fe80::1 dev ens3 \ nexthop encap mpls 20 via fe80::1 dev ens3 RTNETLINK answers: File exists The problem is that the duplicate nexthop detectio

Re: [PATCH net-next 1/1] net sched actions: rename act_get_notify() to tcf_get_notify()

Wed, Jul 05, 2017 at 09:33:58PM CEST, m...@mojatatu.com wrote: >Make name consistent with other TC event notification routines. > >Signed-off-by: Roman Mashak >--- > net/sched/act_api.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/net/sched/act_api.c b/net/sched/act_a

Re: [regression v4.11] 617f01211baf ("8139too: use napi_complete_done()")

On Mon, Jun 19, 2017 at 04:44:45PM +0200, Michal Kubecek wrote: > On Fri, Apr 07, 2017 at 11:38:49AM -0700, Eric Dumazet wrote: > > On Fri, 2017-04-07 at 21:17 +0300, Ville Syrjälä wrote: > > > Hi, > > > > > > My old P3 laptop started to die on me in the middle of larger compile > > > jobs (using

Re: [PATCH net-next RFC 08/12] net: dsa: Remove support for bypass bridge port attributes/vlan set

On 07/05/2017 08:36 AM, Arkadi Sharshevsky wrote: > The bridge port attributes/vlan for DSA devices should be set only > from bridge code. Furthermore, The vlans are synced totally with the > bridge so there is no need for special dump support. > > Signed-off-by: Arkadi Sharshevsky I would be mo

Re: [PATCH net-next RFC 04/12] net: dsa: Add ordered workqueue

On 07/05/2017 08:36 AM, Arkadi Sharshevsky wrote: > This workqueue will be used for FDB add/del processing. It should > be destroyed after all devices unregistered successfully. > > Signed-off-by: Arkadi Sharshevsky > --- > include/net/dsa.h | 1 + > net/dsa/dsa.c | 13 + > 2 fi

Re: [PATCH net-next RFC 05/12] net: dsa: Add support for learning FDB through notification

On 07/05/2017 08:36 AM, Arkadi Sharshevsky wrote: > Add support for learning FDB through notification. The driver defers > the hardware update via ordered work queue. In case of a successful > FDB add a notification is sent back to bridge. > > Signed-off-by: Arkadi Sharshevsky > --- > net/dsa/sl

[PATCH net-next 1/1] net sched actions: rename act_get_notify() to tcf_get_notify()

Make name consistent with other TC event notification routines. Signed-off-by: Roman Mashak --- net/sched/act_api.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sched/act_api.c b/net/sched/act_api.c index aed6cf2..f2e9ed3 100644 --- a/net/sched/act_api.c +++ b/net/

Re: [PATCH net-next RFC 03/12] net: dsa: Remove switchdev dependency from DSA switch notifier chain

On 07/05/2017 08:36 AM, Arkadi Sharshevsky wrote: > Currently, the switchdev objects are embedded inside the DSA notifier > info. This patch removes this dependency. This is done as a preparation > stage before adding support for learning FDB through the switchdev > notification chain. > > Signed-

Re: [PATCH net-next RFC 02/12] net: dsa: Remove prepare phase for FDB

On 07/05/2017 08:36 AM, Arkadi Sharshevsky wrote: > The prepare phase for FDB add is unneeded because most of DSA devices > can have failures during bus transactions (SPI, I2C, etc.), thus, the > prepare phase cannot guarantee success of the commit stage. > > The support for learning FDB through n

Re: [PATCH net-next RFC 01/12] net: dsa: Change DSA slave FDB API to be switchdev independent

On 07/05/2017 08:36 AM, Arkadi Sharshevsky wrote: > In order to support FDB add/del to be on a notifier chain the slave > API need to be changed to be switchdev independent. > > Signed-off-by: Arkadi Sharshevsky > Reviewed-by: Vivien Didelot Reviewed-by: Florian Fainelli -- Florian

[PATCH v2 net-next] liquidio: fix bug in soft reset failure detection

From: Derek Chickles The code that detects a failed soft reset of Octeon is comparing the wrong value against the reset value of the Octeon SLI_SCRATCH_1 register, resulting in an inability to detect a soft reset failure. Fix it by using the correct value in the comparison, which is any non-zero

Re: [RFC/RFT PATCH 2/4] net: ethernat: ti: cpts: enable irq

On 07/03/2017 04:53 PM, Ivan Khoronzhuk wrote: > On Mon, Jul 03, 2017 at 02:31:06PM -0500, Grygorii Strashko wrote: >> >> >> On 06/30/2017 08:31 PM, Ivan Khoronzhuk wrote: >>> On Tue, Jun 13, 2017 at 06:16:21PM -0500, Grygorii Strashko wrote: There are two reasons for this change: 1) en

Re: [PATCH] mwifiex: uninit wakeup info when failed to add card

On Mon, Jul 03, 2017 at 03:54:30PM +0800, Jeffy Chen wrote: > We inited wakeup info at the beginning of mwifiex_add_card, so we need > to uninit it in the error handling. > > It's much the same as what we did in: > 36908c4 mwifiex: uninit wakeup info when removing device Yeah, I noticed I hadn't

Re: [PATCH RFC] inetpeer: remove AVL implementation in favor of RB tree

On 05.07.2017 19:48, ericnetdev dumazet wrote: > > > On Jul 5, 2017 5:39 PM, "Mika Penttilä" > wrote: > > Hi! > > > On 05.07.2017 19:00, Eric Dumazet wrote: > > From: Eric Dumazet mailto:eduma...@google.com>> > > > > As discussed in Faro dur

Re: [PATCH 0/2] bring UP loopback device at initialziation

On Wed, Jul 5, 2017 at 9:05 AM, David Miller wrote: > From: Mahesh Bandewar (महेश बंडेवार) > Date: Wed, 5 Jul 2017 08:59:37 -0700 > >> On Wed, Jul 5, 2017 at 1:20 AM, David Miller wrote: >>> From: Mahesh Bandewar >>> Date: Tue, 4 Jul 2017 12:16:15 -0700 >>> In almost every scenario the lo

Re: [PATCH 0/2] bring UP loopback device at initialziation

On Wed, Jul 5, 2017 at 8:59 AM, Mahesh Bandewar (महेश बंडेवार) wrote: > Systems have only one lo device (since ages) and that is usually taken > care at the boot time. Now with the namespaces it's not just one > device as it's per namespace and though not much this patch will > benefit a little. P

Re: [PATCH 1/2] ipv4: initialize fib_trie prior to register_netdev_notifier call.

On Wed, Jul 5, 2017 at 9:24 AM, Eric W. Biederman wrote: > Mahesh Bandewar writes: > >> From: Mahesh Bandewar >> >> Net stack initialization currently initializes fib-trie after the >> first call to netdevice_notifier() call. It does not cause any problem >> since there are no devices UP at this

Re: [PATCH RFC 11/12] net: Remove all references to SKB_GSO_UDP.

On Wed, Jul 5, 2017 at 12:06 PM, Willem de Bruijn wrote: >> diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h >> index 5209b5e..32fb046 100644 >> --- a/include/linux/virtio_net.h >> +++ b/include/linux/virtio_net.h >> @@ -18,9 +18,6 @@ static inline int virtio_net_hdr_to_skb(str

Re: Unable to add v6 multipath route with same nexthops but different MPLS labels

On 7/5/17 9:39 AM, Lennert Buytenhek wrote: > Hi! > > FWIW, this doesn't work: > > # ip -6 route add 1234::/16 \ > nexthop encap mpls 10 via fe80::1 dev ens3 \ > nexthop encap mpls 20 via fe80::1 dev ens3 > RTNETLINK answers: File exists > > While this doe

Re: [Patch net] tcp: reset sk_rx_dst in tcp_disconnect()

On Tue, Jul 4, 2017 at 11:54 PM, Jamie Bainbridge wrote: > On 25 June 2017 at 16:50, Cong Wang wrote: >> We have to reset the sk->sk_rx_dst when we disconnect a TCP >> connection, because otherwise when we re-connect it this >> dst reference is simply overridden in tcp_finish_connect(). >> >> Thi

Re: [PATCH RFC] inetpeer: remove AVL implementation in favor of RB tree

Hi! On 05.07.2017 19:00, Eric Dumazet wrote: > From: Eric Dumazet > > As discussed in Faro during Netfilter Workshop 2017, RB trees can be > used with RCU, using a seqlock. > > Note that net/rxrpc/conn_service.c is already using this. > > This patch converts inetpeer from AVL tree to RB tree, si

Re: [PATCH 1/2] ipv4: initialize fib_trie prior to register_netdev_notifier call.

Mahesh Bandewar writes: > From: Mahesh Bandewar > > Net stack initialization currently initializes fib-trie after the > first call to netdevice_notifier() call. It does not cause any problem > since there are no devices UP at this moment, but trying to bring 'lo' > UP at initialization would mak

Re: [PATCH RFC 11/12] net: Remove all references to SKB_GSO_UDP.

>> --- a/net/ipv4/udp_offload.c >> +++ b/net/ipv4/udp_offload.c >> @@ -21,7 +21,7 @@ static struct sk_buff *__skb_udp_tunnel_segment(struct >> sk_buff *skb, >> __be16 new_protocol, bool is_ipv6) > > In this file, can now remove all of udp4_ufo_fragment, and > udp6_ufo_fragment in net/ipv6.

[ANNOUNCE] iproute2 4.12.0

Release of iproute2 for Linux 4.12 Usual update to iproute2 utility to support new features in Linux 4.12. More changes to flower support and lots of littele TC enhancements. Also the usual array of small manual and documentaton updates. Source: https://www.kernel.org/pub/linux/utils/net/iprout

Re: [PATCH v2 2/2] ARM: shmobile: defconfig: Enable Ethernet AVB

Hello! On 07/05/2017 06:56 PM, Biju Das wrote: The iWave RZ/G1M Q7 SOM supports Gigabit Ethernet Phy (Micrel KSZ9031MNX). Gigabit Ethernet support is available in Renesas AVB driver. To increase hardware support enable the driver in the shmobile_defconfig multiplatform configuration. Signed-of

[PATCH v2 0/2] Add RZ/G1M (R8A7743) Ethernet AVB support

Hi All, This series aims to upstream the Ethernet AVB driver support for RZ/G1M (r8a7743) SoC . The iWave RZ/G1M Qseven SOM supports Gigabit Ethernet Phy from Micrel(KSZ9031MNX). Gigabit Ethernet support is available in Renesas AVB driver. This series has been tested against linux-next tag ne

[PATCH v2 1/2] ravb: Document binding for r8a7743 SoC

Add a new compatible string for the RZ/G1M (R8A7743) SoC. Signed-off-by: Biju Das Reviewed-by: Chris Paterson Reviewed-by: Geert Uytterhoeven --- Documentation/devicetree/bindings/net/renesas,ravb.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetre

[PATCH v2 2/2] ARM: shmobile: defconfig: Enable Ethernet AVB

The iWave RZ/G1M Q7 SOM supports Gigabit Ethernet Phy (Micrel KSZ9031MNX). Gigabit Ethernet support is available in Renesas AVB driver. To increase hardware support enable the driver in the shmobile_defconfig multiplatform configuration. Signed-off-by: Biju Das Reviewed-by: Chris Paterson Acked-

Re: [PATCH RFC 11/12] net: Remove all references to SKB_GSO_UDP.

> diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h > index 5209b5e..32fb046 100644 > --- a/include/linux/virtio_net.h > +++ b/include/linux/virtio_net.h > @@ -18,9 +18,6 @@ static inline int virtio_net_hdr_to_skb(struct sk_buff *skb, > case VIRTIO_NET_HDR_GSO_TCP

Re: [PATCH iproute/master 0/3] lost mpls ip tunnel patches

On Fri, 9 Jun 2017 18:31:29 -0700 Krister Johansen wrote: > Hi Stephen, > I'm a bit unsure of the decorum in this particular situation. Kernel > support for mpls/ip tunnels was integrated back in July of 2016. At the > time, the author of that feature sent out a RFC patch for the iproute > supp

Re: [PATCH 1/1] bridge: mdb: report complete_info ptr as not a kmemleak

On Tue, Jul 04, 2017 at 01:48:42AM -0700, David Miller wrote: > From: Eduardo Valentin > Date: Mon, 3 Jul 2017 10:06:34 -0700 > > > We currently get the following kmemleak report: > ... > > This patch flags the complete_info ptr object as not a leak as it will > > get freed when .complete_priv()

Re: [PATCH 0/2] bring UP loopback device at initialziation

From: Mahesh Bandewar (महेश बंडेवार) Date: Wed, 5 Jul 2017 08:59:37 -0700 > On Wed, Jul 5, 2017 at 1:20 AM, David Miller wrote: >> From: Mahesh Bandewar >> Date: Tue, 4 Jul 2017 12:16:15 -0700 >> >>> In almost every scenario the loopback device is brought UP after >>> initialization. So there

[PATCH net] ip[6]: don't register inet[6]dev when dev is down

From: Hongjun Li When the netdev event NETDEV_CHANGEMTU is triggered, the inet[6]dev may be created even if the corresponding device is down. This may lead to a leak in the procfs when the device is unregistered, and finally trigger a backtrace: [ 114.724500] bond1 (unregistering): Released all

Re: [PATCH iproute2 1/1] Add new man page for tc actions.

On Tue, 4 Jul 2017 17:40:35 -0400 Lucas Bates wrote: > This page is to highlight all operations and options that are > applicable to all tc actions. > > Signed-off-by: Lucas Bates > Signed-off-by: Jamal Hadi Salim Sure looks good, applied

[PATCH RFC] inetpeer: remove AVL implementation in favor of RB tree

From: Eric Dumazet As discussed in Faro during Netfilter Workshop 2017, RB trees can be used with RCU, using a seqlock. Note that net/rxrpc/conn_service.c is already using this. This patch converts inetpeer from AVL tree to RB tree, since it allows to remove private AVL code in favor of shared

Re: [PATCH 0/2] bring UP loopback device at initialziation

On Wed, Jul 5, 2017 at 1:20 AM, David Miller wrote: > From: Mahesh Bandewar > Date: Tue, 4 Jul 2017 12:16:15 -0700 > >> In almost every scenario the loopback device is brought UP after >> initialization. So there is no point of bringing up the device in >> DOWN state followed by device UP operat

Re: [PATCH RFC 0/12] Remove UDP Fragmentation Offload support

On Wed, 05 Jul 2017 16:04:02 +0100 (WEST) David Miller wrote: > This is an RFC patch series, based upon some discussions with > various developers, that removes UFO offloading. > > Very few devices support this operation, it's usefullness is > quesitonable at best, and it adds a non-trivial amou

Unable to add v6 multipath route with same nexthops but different MPLS labels

Hi! FWIW, this doesn't work: # ip -6 route add 1234::/16 \ nexthop encap mpls 10 via fe80::1 dev ens3 \ nexthop encap mpls 20 via fe80::1 dev ens3 RTNETLINK answers: File exists While this does: # ip -6 route chg 1234::/16

[PATCH] net: macb: Adding Support for Jumbo Frames up to 10240 Bytes in SAMA5D3

From: vishnuvardhan As per the SAMA5D3 device specification it supports Jumbo frames. But the suggested flag and length of bytes it supports was not updated in this driver config_structure. The maximum jumbo frames the device supports : 10240 bytes as per the device spec. While changing the MTU

[PATCH net-next RFC 02/12] net: dsa: Remove prepare phase for FDB

The prepare phase for FDB add is unneeded because most of DSA devices can have failures during bus transactions (SPI, I2C, etc.), thus, the prepare phase cannot guarantee success of the commit stage. The support for learning FDB through notification chain, which will be introduced in the following

[PATCH net-next RFC 08/12] net: dsa: Remove support for bypass bridge port attributes/vlan set

The bridge port attributes/vlan for DSA devices should be set only from bridge code. Furthermore, The vlans are synced totally with the bridge so there is no need for special dump support. Signed-off-by: Arkadi Sharshevsky --- drivers/net/dsa/b53/b53_common.c | 44 -

[PATCH net-next RFC 12/12] net: switchdev: Remove bridge bypass support from switchdev

Currently the bridge port flags, vlans, FDBs and MDBs can be offloaded through the bridge code, making the switchdev's SELF bridge bypass implementation to be redundant. This implies several changes: - No need for dump infra in switchdev, DSA's special case is handled privately. - Remove obj_dump

[PATCH net-next RFC 06/12] net: dsa: Remove support for FDB add/del via SELF

FDB add/del can be added via switchdev notification chain. Thus the support for configuration via switchdev objects can be removed. Signed-off-by: Arkadi Sharshevsky --- net/dsa/slave.c | 12 1 file changed, 12 deletions(-) diff --git a/net/dsa/slave.c b/net/dsa/slave.c index d0592

[PATCH net-next RFC 00/12] Change DSA's FDB API and perform switchdev cleanup

The patchset moves the DSA driver into learning static FDB entries via the switchdev notification chain rather then by using bridge bypass SELF flag. The DSA drivers cannot sync the software bridge with hardware learned entries and use the switchdev's implementation of bypass FDB dumping. Because

[PATCH net-next RFC 05/12] net: dsa: Add support for learning FDB through notification

Add support for learning FDB through notification. The driver defers the hardware update via ordered work queue. In case of a successful FDB add a notification is sent back to bridge. Signed-off-by: Arkadi Sharshevsky --- net/dsa/slave.c | 124

[PATCH net-next RFC 03/12] net: dsa: Remove switchdev dependency from DSA switch notifier chain

Currently, the switchdev objects are embedded inside the DSA notifier info. This patch removes this dependency. This is done as a preparation stage before adding support for learning FDB through the switchdev notification chain. Signed-off-by: Arkadi Sharshevsky --- net/dsa/dsa_priv.h | 11 +

[PATCH net-next RFC 09/12] net: dsa: Remove redundant MDB dump support

Currently the MDB HW database is synced with the bridge's one, thus, There is no need to support special dump functionality. Signed-off-by: Arkadi Sharshevsky --- drivers/net/dsa/microchip/ksz_common.c | 9 - drivers/net/dsa/mv88e6xxx/chip.c | 24 include/

[PATCH net-next RFC 01/12] net: dsa: Change DSA slave FDB API to be switchdev independent

In order to support FDB add/del to be on a notifier chain the slave API need to be changed to be switchdev independent. Signed-off-by: Arkadi Sharshevsky Reviewed-by: Vivien Didelot --- drivers/net/dsa/b53/b53_common.c | 12 +--- drivers/net/dsa/b53/b53_priv.h | 8 +++

[PATCH net-next RFC 07/12] net: dsa: Add support for querying supported bridge flags

The DSA drivers do not support bridge flags offload. Yet, this attribute should be added in order for the bridge to fail when one tries set a flag on the port, as explained in commit dc0ecabd6231 ("net: switchdev: Add support for querying supported bridge flags by hardware"). Signed-off-by: Arkadi

[PATCH net-next RFC 10/12] net: dsa: Move FDB dump implementation inside DSA

>From all switchdev devices only DSA requires special FDB dump. This is due to lack of ability for syncing the hardware learned FDBs with the bridge. Due to this it is removed from switchdev and moved inside DSA. Signed-off-by: Arkadi Sharshevsky --- drivers/net/dsa/b53/b53_common.c | 19 +

[PATCH net-next RFC 04/12] net: dsa: Add ordered workqueue

This workqueue will be used for FDB add/del processing. It should be destroyed after all devices unregistered successfully. Signed-off-by: Arkadi Sharshevsky --- include/net/dsa.h | 1 + net/dsa/dsa.c | 13 + 2 files changed, 14 insertions(+) diff --git a/include/net/dsa.h b/in

[PATCH net-next RFC 11/12] net: bridge: Remove FDB deletion through switchdev object

At this point no driver supports FDB add/del through switchdev object but rather via notification chain, thus, it is removed. Signed-off-by: Arkadi Sharshevsky --- net/bridge/br_fdb.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c

[PATCH 06/14] bpf: Implement show_options

Implement the show_options superblock op for bpf as part of a bid to get rid of s_options and generic_show_options() to make it easier to implement a context-based mount where the mount options can be passed individually over a file descriptor. Signed-off-by: David Howells cc: Alexei Starovoitov

Re: [PATCH] net: axienet: add of_phy_connect call for XAE_PHY_TYPE_MII case

> That sounds really respectful with current users and sets the basis for a > future removal of that proprietary parameter without causing more harm than > needed, so I like that a lot. Please feel free to turn it into a real patch and submit it. Andrew

[PATCH RFC 11/12] net: Remove all references to SKB_GSO_UDP.

Such packets are no longer possible. Signed-off-by: David S. Miller --- include/linux/virtio_net.h | 5 - net/core/filter.c | 8 net/ipv4/af_inet.c | 12 ++-- net/ipv4/gre_offload.c | 14 +- net/ipv4/udp_offload.c | 6 ++ net/open

[PATCH RFC 12/12] net: Kill NETIF_F_UFO and SKB_GSO_UDP.

No longer used. Signed-off-by: David S. Miller --- include/linux/netdev_features.h | 4 +--- include/linux/netdevice.h | 1 - include/linux/skbuff.h | 31 +++ 3 files changed, 16 insertions(+), 20 deletions(-) diff --git a/include/linux/netdev_featu

[PATCH RFC 10/12] inet: Stop generating UFO packets.

Signed-off-by: David S. Miller --- net/ipv4/ip_output.c | 76 --- net/ipv6/ip6_output.c | 76 --- 2 files changed, 152 deletions(-) diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c index 7eb

[PATCH RFC 09/12] net: Remove references to NETIF_F_UFO from ethtool.

It is going away. Signed-off-by: David S. Miller --- net/core/ethtool.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/net/core/ethtool.c b/net/core/ethtool.c index 03111a2..46f717a 100644 --- a/net/core/ethtool.c +++ b/net/core/ethtool.c @@ -76,7 +76,6 @@ static const char netdev_f

[PATCH RFC 08/12] net: Remove references to NETIF_F_UFO in netdev_fix_features().

It is going away. Signed-off-by: David S. Miller --- net/core/dev.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index 7098fba..8495ded 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -7234,24 +7234,6 @@ static netdev_features_t netd

[PATCH RFC 07/12] virtio_net: Remove references to NETIF_F_UFO.

It is going away. Signed-off-by: David S. Miller --- drivers/net/virtio_net.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 2e69bcd..eb33e2e 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c

[PATCH RFC 06/12] dummy: Remove references to NETIF_F_UFO.

It is going away. Signed-off-by: David S. Miller --- drivers/net/dummy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dummy.c b/drivers/net/dummy.c index d0c165d..d0a1f9c 100644 --- a/drivers/net/dummy.c +++ b/drivers/net/dummy.c @@ -345,7 +345,7 @@ static voi

[PATCH RFC 05/12] tun/tap: Remove references to NETIF_F_UFO.

It is going away. Signed-off-by: David S. Miller --- drivers/net/tap.c | 7 ++- drivers/net/tun.c | 7 +-- 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/net/tap.c b/drivers/net/tap.c index 9af3239..d4579a3 100644 --- a/drivers/net/tap.c +++ b/drivers/net/tap.c

[PATCH 04/12] macvlan/macvtap: Remove NETIF_F_UFO advertisement.

It is going away. Signed-off-by: David S. Miller --- drivers/net/macvlan.c | 2 +- drivers/net/macvtap.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 0f581ee..ca35c6b 100644 --- a/drivers/net/macvlan.c +++ b/drivers/n

[PATCH RFC 01/12] s2io: Remove UFO support.

Signed-off-by: David S. Miller --- drivers/net/ethernet/neterion/s2io.c | 45 1 file changed, 45 deletions(-) diff --git a/drivers/net/ethernet/neterion/s2io.c b/drivers/net/ethernet/neterion/s2io.c index fd2ec36..462eda9 100644 --- a/drivers/net/ethernet/n

[PATCH RFC 03/12] ipvlan: Stop advertising NETIF_F_UFO support.

It is going away. Signed-off-by: David S. Miller --- drivers/net/ipvlan/ipvlan_main.c | 2 +- drivers/net/ipvlan/ipvtap.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c index f37e3c1..fdde207 100644

[PATCH RFC 02/12] macb: Remove bogus reference to NETIF_F_UFO.

This driver doesn't actually support UFO explicitly yet it advertises this in netdev->features. Signed-off-by: David S. Miller --- drivers/net/ethernet/cadence/macb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net

[PATCH RFC 0/12] Remove UDP Fragmentation Offload support

This is an RFC patch series, based upon some discussions with various developers, that removes UFO offloading. Very few devices support this operation, it's usefullness is quesitonable at best, and it adds a non-trivial amount of complexity to our data paths. Signed-off-by: David S. Miller

  1   2   >