On 07/05/2017 08:36 AM, Arkadi Sharshevsky wrote: > The bridge port attributes/vlan for DSA devices should be set only > from bridge code. Furthermore, The vlans are synced totally with the > bridge so there is no need for special dump support. > > Signed-off-by: Arkadi Sharshevsky <arka...@mellanox.com>
I would be more comfortable if we still had a way to dump HW entries by calling into drivers, because it's useful for debugging, and doing that using standard tools plus an additional flag for instance: bridge fdb show would dump the SW-maintained VLANs, but: bridge fdb show hw would dump the HW-maintained VLANs, or any flag name really, but the point is that we can keep using a standard tool to expose debugging features. debugfs (or something else) could be used, but was rejected by David. Also, technically, it ought to be possible to configure a port's VLAN membership (although using poor semantics) through e.g: vconfig add sw0p0 1, which would call ndo_vlan_rx_add_vid() (DSA does not support it but mlxsw does), and so being able to dump that configuration would be somehow helpful. -- Florian
