Re: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails

2017-06-04 Thread Neftin, Sasha
On 5/31/2017 18:50, Jani Nikula wrote: From: Chris Wilson An error during suspend (e100e_pm_suspend), [ 429.994338] ACPI : EC: event blocked [ 429.994633] e1000e: EEE TX LPI TIMER: 0011 [ 430.955451] pci_pm_suspend(): e1000e_pm_suspend+0x0/0x30 [e1000e] returns -2 [ 430.955454] dpm_run

Re: [PATCH v2] devlink: fix potential memort leak

2017-06-04 Thread Jiri Pirko
Mon, Jun 05, 2017 at 02:57:21AM CEST, yanhaishu...@cmss.chinamobile.com wrote: >We must free allocated skb when genlmsg_put() return fails. > >Fixes: 1555d204e743 ("devlink: Support for pipeline debug (dpipe)") >Signed-off-by: Haishuang Yan Acked-by: Jiri Pirko Thanks.

Re: [PATCH] net: sched: fix mips build failure

2017-06-04 Thread Jiri Pirko
Sun, Jun 04, 2017 at 11:44:13PM CEST, sudipm.mukher...@gmail.com wrote: >The build of mips ar7_defconfig was failing with the error: >../net/sched/act_api.c: In function 'tcf_action_goto_chain_init': >../net/sched/act_api.c:37:18: error: > implicit declaration of function 'tcf_chain_get' >

Re: [patch net-next 0/3] mlxsw: Minor cleanup

2017-06-04 Thread David Miller
From: Jiri Pirko Date: Sun, 4 Jun 2017 16:53:37 +0200 > Fix small issues I noticed during the refactoring. > > First patch adds file name comments in the header file to make it clear > what goes where. Second patch fixes a typo and third patch simply aligns > RIF index allocation with similar a

Re: [patch net-next] mlxsw: spectrum: Rename the firmware file

2017-06-04 Thread David Miller
From: Jiri Pirko Date: Sun, 4 Jun 2017 16:49:58 +0200 > From: Yotam Gigi > > Change the firmware file name to be in "mellanox" directory. > > This commit is a followup to the linux-firmware commit a4c72696f5f4 > ("Mellanox: Add firmware for mlxsw_spectrum") > > Signed-off-by: Yotam Gigi > R

Re: [PATCH net V4] net/mlx4: Fix the check in attaching steering rules

2017-06-04 Thread David Miller
From: Tariq Toukan Date: Sun, 4 Jun 2017 14:30:07 +0300 > From: Talat Batheesh > > Our previous patch (cited below) introduced a regression > for RAW Eth QPs. > > Fix it by checking if the QP number provided by user-space > exists, hence allowing steering rules to be added for valid > QPs onl

[PATCH net-next 00/11] qed*: Support VF XDP attachment

2017-06-04 Thread David Miller
Please no empty primary subject lines next time, thank you. Series applied.

Re: [PATCH] sit: reload iphdr in ipip6_rcv

2017-06-04 Thread David Miller
From: Haishuang Yan Date: Sun, 4 Jun 2017 14:43:43 +0800 > Since iptunnel_pull_header() can call pskb_may_pull(), > we must reload any pointer that was related to skb->head. > > Fixes: a09a4c8dd1ec ("tunnels: Remove encapsulation offloads on decap") > Signed-off-by: Haishuang Yan Applied and

Re: [PATCH net-next v10 0/5] Avoiding stack overflow in skb_to_sgvec

2017-06-04 Thread David Miller
From: "Jason A. Donenfeld" Date: Sun, 4 Jun 2017 04:16:21 +0200 > Changes v9->v10: >- Spaces to tabs on one line. >- Added some acked-by, reviewed-by lines. I wish in the future you would retain the entire change history, and keep it in it's entirety here in the header postings. That l

Re: [PATCH net] net: ping: do not abuse udp_poll()

2017-06-04 Thread David Miller
From: Eric Dumazet Date: Sat, 03 Jun 2017 09:29:25 -0700 > From: Eric Dumazet > > Alexander reported various KASAN messages triggered in recent kernels > > The problem is that ping sockets should not use udp_poll() in the first > place, and recent changes in UDP stack finally exposed this old

Re: [PATCH net] net: dsa: Fix stale cpu_switch reference after unbind then bind

2017-06-04 Thread David Miller
From: Florian Fainelli Date: Fri, 2 Jun 2017 22:05:23 -0700 > Commit 9520ed8fb841 ("net: dsa: use cpu_switch instead of ds[0]") > replaced the use of dst->ds[0] with dst->cpu_switch since that is > functionally equivalent, however, we can now run into an use after free > scenario after unbinding

[PATCH] net: phy: fix kernel-doc warnings

2017-06-04 Thread Randy Dunlap
From: Randy Dunlap Fix kernel-doc warnings (typo) in drivers/net/phy/phy.c: ..//drivers/net/phy/phy.c:259: warning: No description found for parameter 'features' ..//drivers/net/phy/phy.c:259: warning: Excess function parameter 'feature' description in 'phy_lookup_setting' Signed-off-by: Rand

Re: [net-next] openvswitch: add macro MODULE_ALIAS_VPORT_TYPE for vport type alias

2017-06-04 Thread Pravin Shelar
On Sun, Jun 4, 2017 at 1:12 AM, 张胜举 wrote: >> -Original Message- >> From: Pravin Shelar [mailto:pshe...@ovn.org] >> Sent: Sunday, June 04, 2017 1:58 PM >> To: Zhang Shengju >> Cc: Pravin Shelar ; Linux Kernel Network Developers >> ; David S. Miller >> Subject: Re: [net-next] openvswitch:

Re: BUG: KASAN: use-after-free in free_old_xmit_skbs

2017-06-04 Thread Michael S. Tsirkin
On Mon, Jun 05, 2017 at 12:48:53AM +0200, Jean-Philippe Menil wrote: > Hi, > > while playing with xdp and ebpf, i'm hitting the following: > > [ 309.993136] > == > [ 309.994735] BUG: KASAN: use-after-free in > free_old_xmit_skbs.is

Re: [PATCH v4 net-next 0/3] bpf: Add BPF support to all perf_event

2017-06-04 Thread David Miller
From: Alexei Starovoitov Date: Fri, 2 Jun 2017 21:03:51 -0700 > v3->v4: one more tweak to reject unsupported events at map > update time as Peter suggested > > v2->v3: more refactoring to address Peter's feedback. > Now all perf_events are attachable and readable > > v1->v2: address Peter's fee

Re: Leak in ipv6_gso_segment()?

2017-06-04 Thread David Miller
From: Craig Gallek Date: Fri, 2 Jun 2017 15:27:41 -0400 > On Fri, Jun 2, 2017 at 2:25 PM, Craig Gallek wrote: >> On Fri, Jun 2, 2017 at 2:05 PM, David Miller wrote: >>> From: Ben Hutchings >>> Date: Wed, 31 May 2017 13:26:02 +0100 >>> If I'm not mistaken, ipv6_gso_segment() now leaks segs

Re: [PATCHv2 net-next] net: phy: smsc: Implement PHY statistics

2017-06-04 Thread David Miller
From: Andrew Lunn Date: Sat, 3 Jun 2017 20:00:36 +0200 > Most of the PHYs supported by the SMSC driver have a counter of symbol > errors. This is 16 bit wide and wraps around when it reaches its > maximum value. > > Signed-off-by: Andrew Lunn > Reviewed-by: Florian Fainelli > Reviewed-By: Woo

Re: [PATCH V5 net-next] neigh: Really delete an arp/neigh entry on "ip neigh delete" or "arp -d"

2017-06-04 Thread David Miller
From: Sowmini Varadhan Date: Fri, 2 Jun 2017 09:01:49 -0700 > The command > # arp -s 62.2.0.1 a:b:c:d:e:f dev eth2 > adds an entry like the following (listed by "arp -an") > ? (62.2.0.1) at 0a:0b:0c:0d:0e:0f [ether] PERM on eth2 > but the symmetric deletion command > # arp -i eth2 -d 62.2.

Re: [PATCH net-next 0/2] Fixes for mv88e6161

2017-06-04 Thread David Miller
From: Andrew Lunn Date: Fri, 2 Jun 2017 23:22:44 +0200 > Testing a board with an mv88e6161 turned up two issues. The PHYs were > not found, because the wrong method to access them was used. The > statistics did not work, because the wrong snapshot method was used Series applied, thanks Andrew.

Re: [net-next] openvswitch: add macro MODULE_ALIAS_VPORT_TYPE for vport type alias

2017-06-04 Thread David Miller
From: 张胜举 Date: Mon, 5 Jun 2017 09:10:22 +0800 >> -Original Message- >> From: David Miller [mailto:da...@davemloft.net] >> Sent: Monday, June 05, 2017 4:13 AM >> To: pshe...@ovn.org >> Cc: zhangshen...@cmss.chinamobile.com; pshe...@nicira.com; >> netdev@vger.kernel.org >> Subject: Re: [ne

RE: [net-next] openvswitch: add macro MODULE_ALIAS_VPORT_TYPE for vport type alias

2017-06-04 Thread 张胜举
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Monday, June 05, 2017 4:13 AM > To: pshe...@ovn.org > Cc: zhangshen...@cmss.chinamobile.com; pshe...@nicira.com; > netdev@vger.kernel.org > Subject: Re: [net-next] openvswitch: add macro > MODULE_ALIAS_VPORT_TYPE

[PATCH v2] devlink: fix potential memort leak

2017-06-04 Thread Haishuang Yan
We must free allocated skb when genlmsg_put() return fails. Fixes: 1555d204e743 ("devlink: Support for pipeline debug (dpipe)") Signed-off-by: Haishuang Yan --- Changes in v2: - Fix same issue in headers_fill. --- net/core/devlink.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-

Re: [PATCH] ath6kl: fix spelling mistake: "Indicat" -> "Indicate"

2017-06-04 Thread Steve deRosier
On Sun, Jun 4, 2017 at 9:36 AM, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in ath6kl_dbg debug message > > Signed-off-by: Colin Ian King > --- > drivers/net/wireless/ath/ath6kl/htc_pipe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/

Re: [PATCH net-next 0/5] net: dsa: mv88e6xxx: move registers macros

2017-06-04 Thread David Miller
From: Vivien Didelot Date: Fri, 2 Jun 2017 17:06:14 -0400 > This patchset brings no functional changes. > > It is the first step of a cleanup renaming the chip header file and > moving the Register definitions _as is_ in their proper header files. > > A following patchset will prefix them with

Re: [PATCH 0/3] net: dsa: Cleanups before multi-CPU port

2017-06-04 Thread David Miller
From: Florian Fainelli Date: Fri, 2 Jun 2017 12:31:20 -0700 > This patch series does a bunch of cleanups before we start adding support > for multiple CPU ports. Series applied to net-next.

Re: [PATCH net] geneve: fix needed_headroom and max_mtu for collect_metadata

2017-06-04 Thread David Miller
From: Eric Garver Date: Fri, 2 Jun 2017 14:54:10 -0400 > Since commit 9b4437a5b870 ("geneve: Unify LWT and netdev handling.") > when using COLLECT_METADATA geneve devices are created with too small of > a needed_headroom and too large of a max_mtu. This is because > ip_tunnel_info_af() is not va

Re: [PATCH net] sock: reset sk_err when the error queue is empty

2017-06-04 Thread David Miller
From: Soheil Hassas Yeganeh Date: Fri, 2 Jun 2017 12:38:22 -0400 > From: Soheil Hassas Yeganeh > > Prior to f5f99309fa74 (sock: do not set sk_err in > sock_dequeue_err_skb), sk_err was reset to the error of > the skb on the head of the error queue. > > Applications, most notably ping, are rel

Re: [PATCH] amd-xgbe: use PAGE_ALLOC_COSTLY_ORDER in xgbe_map_rx_buffer

2017-06-04 Thread David Miller
From: Michal Hocko Date: Fri, 2 Jun 2017 17:54:08 +0200 > From: Michal Hocko > > xgbe_map_rx_buffer is rather confused about what PAGE_ALLOC_COSTLY_ORDER > means. It uses PAGE_ALLOC_COSTLY_ORDER-1 assuming that > PAGE_ALLOC_COSTLY_ORDER is the first costly order which is not the case > actuall

Re: [PATCH][net-next] rxrpc: remove redundant proc_remove call

2017-06-04 Thread David Miller
From: Colin King Date: Fri, 2 Jun 2017 16:22:27 +0100 > From: Colin Ian King > > The proc_remove call is dead code as it occurs after a return and > hence can never be called. Remove it. > > Detected by CoverityScan, CID#1437743 ("Logically dead code") > > Signed-off-by: Colin Ian King App

Re: [PATCH net-next] dccp: consistently use dccp_write_space()

2017-06-04 Thread David Miller
From: Eric Dumazet Date: Fri, 02 Jun 2017 08:02:26 -0700 > From: Eric Dumazet > > DCCP uses dccp_write_space() for sk->sk_write_space method. > > Unfortunately a passive connection (as provided by accept()) > is using the generic sk_stream_write_space() function. > > Lets simply inherit sk->s

Re: [PATCH] net: stmmac: ensure jumbo_frm error return is correctly checked for -ve value

2017-06-04 Thread David Miller
From: Colin King Date: Fri, 2 Jun 2017 15:58:27 +0100 > From: Colin Ian King > > The current comparison of entry < 0 will never be true since entry is an > unsigned integer. Cast entry to an int to ensure -ve error return values > from the call to jumbo_frm are correctly being caught. > > Det

Re: [PATCH][V2] net: phy: marvell: make some functions static

2017-06-04 Thread David Miller
From: Colin King Date: Fri, 2 Jun 2017 15:13:34 +0100 > From: Colin Ian King > > functions m88e1510_get_temp_critical, m88e1510_set_temp_critical and > m88e1510_get_temp_alarm can be made static as they not need to be > in global scope. > > Cleans up sparse warnings: > "symbol 'm88e1510_get_

Re: [PATCH] netxen: remove writeq/readq function definitions

2017-06-04 Thread David Miller
From: Corentin Labbe Date: Fri, 2 Jun 2017 13:36:27 +0200 > Instead of rewriting write/readq, use linux/io-64-nonatomic-lo-hi.h which > already have them. > > Signed-off-by: Corentin Labbe Applied to net-next.

Re: [PATCH] net-procfs: Use vsnprintf extension %phN

2017-06-04 Thread David Miller
From: Joe Perches Date: Fri, 2 Jun 2017 02:40:44 -0700 > Save a bit of code by using the kernel extension. > > $ size net/core/net-procfs.o* >text data bss dec hex filename >3701 120 03821 eed net/core/net-procfs.o.new >3764 120

Re: [PATCH net] ip6_tunnel: fix traffic class routing for tunnels

2017-06-04 Thread David Miller
From: Liam McBirnie Date: Fri, 2 Jun 2017 15:12:26 +1000 > From: Liam McBirnie > Date: Thu, 1 Jun 2017 15:36:01 +1000 > Subject: [PATCH net] ip6_tunnel: fix traffic class routing for tunnels > > ip6_route_output() requires that the flowlabel contains the traffic > class for policy routing. > >

Re: [for 4.12] net: qcom/emac: do not use hardware mdio automatic polling

2017-06-04 Thread David Miller
From: Timur Tabi Date: Thu, 1 Jun 2017 16:08:13 -0500 > Use software polling (PHY_POLL) to check for link state changes instead > of relying on the EMAC's hardware polling feature. Some PHY drivers > are unable to get a functioning link because the HW polling is not > robust enough. > > The EM

Re: [PATCH net-next] mdio: mux: make child bus walking more permissive and errors more verbose

2017-06-04 Thread David Miller
From: Jon Mason Date: Wed, 31 May 2017 15:44:50 -0400 > If any errors are encountered while walking the device tree structure of > the MDIO bus for children, the code may silently continue, silently > exit, or throw an error and exit. This make it difficult for device > tree writers to know ther

BUG: KASAN: use-after-free in free_old_xmit_skbs

2017-06-04 Thread Jean-Philippe Menil
Hi, while playing with xdp and ebpf, i'm hitting the following: [ 309.993136] == [ 309.994735] BUG: KASAN: use-after-free in free_old_xmit_skbs.isra.29+0x2b7/0x2e0 [virtio_net] [ 309.998396] Read of size 8 at addr 88006aa6

Re: [PATCH net-next V2 0/4] add support for dissection and matching on ip tos and ttl

2017-06-04 Thread David Miller
From: Or Gerlitz Date: Thu, 1 Jun 2017 21:37:36 +0300 > The 1st two patches enable matching/classifying on ip tos and ttl by > the flow dissector and flower. The other two patches offload matching > on tcp flags and ip tos in mlx5. > > The mlx5 patches touch single file/function and not inte

[PATCH] net: sched: fix mips build failure

2017-06-04 Thread Sudip Mukherjee
The build of mips ar7_defconfig was failing with the error: ../net/sched/act_api.c: In function 'tcf_action_goto_chain_init': ../net/sched/act_api.c:37:18: error: implicit declaration of function 'tcf_chain_get' [-Werror=implicit-function-declaration] ../net/sched/act_api.c: In fun

Re: [PATCH v2 4/4] net: macb: Add hardware PTP support

2017-06-04 Thread Richard Cochran
On Fri, Jun 02, 2017 at 03:28:10PM +0100, Rafal Ozieblo wrote: > +int gem_get_hwtst(struct net_device *dev, struct ifreq *rq) > +{ > + struct macb *bp = netdev_priv(dev); > + struct hwtstamp_config *tstamp_config = &bp->tstamp_config; > + > + if ((bp->hw_dma_cap & HW_DMA_CAP_PTP) == 0)

RE: [PATCH net-next] liquidio: add support for OVS offload

2017-06-04 Thread Chickles, Derek
> From: David Miller [mailto:da...@davemloft.net] > Sent: Saturday, May 27, 2017 5:07 PM > Subject: Re: [PATCH net-next] liquidio: add support for OVS offload > > From: Felix Manlunas > Date: Sat, 27 May 2017 08:56:33 -0700 > > > From: VSR Burru > > > > Add support for OVS offload. By defaul

Re: [PATCH net-next] genetlink: remove ops_list from genetlink header.

2017-06-04 Thread David Miller
From: "Rosen, Rami" Date: Sun, 4 Jun 2017 19:20:43 + > Hi, Sergei, > > Thanks! I will send V2 with 12 digits for the commit. Please never top-post.

Re: [net-next] openvswitch: add macro MODULE_ALIAS_VPORT_TYPE for vport type alias

2017-06-04 Thread David Miller
From: Pravin Shelar Date: Sat, 3 Jun 2017 22:58:22 -0700 > On Sat, Jun 3, 2017 at 6:47 AM, Zhang Shengju > wrote: >> Add a new macro MODULE_ALIAS_VPORT_TYPE to unify and simplify the >> declaration of vport type alias, and replace magic numbers with >> symbolic constants. >> >> Signed-off-by: Zh

Re: [PATCH] net/{mii,smsc}: Make mii_ethtool_get_link_ksettings and smc_netdev_get_ecmd return void

2017-06-04 Thread Yuval Shaia
On Sun, Jun 04, 2017 at 09:01:33PM +0200, Andrew Lunn wrote: > > diff --git a/drivers/net/cris/eth_v10.c b/drivers/net/cris/eth_v10.c > > index da02041..017f48c 100644 > > --- a/drivers/net/cris/eth_v10.c > > +++ b/drivers/net/cris/eth_v10.c > > @@ -1417,10 +1417,9 @@ static int e100_get_link_ksett

Re: [PATCH] net/dec: Make __de_get_link_ksettings return void

2017-06-04 Thread Yuval Shaia
On Sun, Jun 04, 2017 at 08:22:05PM +0300, Sergei Shtylyov wrote: > Hello! > > On 6/4/2017 8:08 PM, Yuval Shaia wrote: > > > Make return value void since function never return meaningfull value > > You only make 1 of 2 functions void. It looks like there should be 2 > patches. And what would

[PATCH v2 net-next] genetlink: remove ops_list from genetlink header.

2017-06-04 Thread Rami Rosen
commit d91824c08fbc ("genetlink: register family ops as array") removed the ops_list member from both genl_family and genl_ops; while the documentation of genl_family was updated accordingly by this patch, ops_list remained in the documentation of the genl_ops object. This patch fixes it by rem

RE: [PATCH net-next] genetlink: remove ops_list from genetlink header.

2017-06-04 Thread Rosen, Rami
Hi, Sergei, Thanks! I will send V2 with 12 digits for the commit. Regards, Rami Rosen -Original Message- From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com] Sent: Sunday, June 04, 2017 20:18 To: Rosen, Rami ; da...@davemloft.net Cc: netdev@vger.kernel.org; Berg, Johannes

Re: [PATCH] net/{mii,smsc}: Make mii_ethtool_get_link_ksettings and smc_netdev_get_ecmd return void

2017-06-04 Thread Andrew Lunn
> diff --git a/drivers/net/cris/eth_v10.c b/drivers/net/cris/eth_v10.c > index da02041..017f48c 100644 > --- a/drivers/net/cris/eth_v10.c > +++ b/drivers/net/cris/eth_v10.c > @@ -1417,10 +1417,9 @@ static int e100_get_link_ksettings(struct net_device > *dev, > { > struct net_local *np = net

Re: [PATCH] net/phy: Make phy_ethtool_ksettings_get return void

2017-06-04 Thread kbuild test robot
Hi Yuval, [auto build test ERROR on net-next/master] [also build test ERROR on v4.12-rc3 next-20170602] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Yuval-Shaia/net-phy-Make-phy_ethtool_ksetti

[PATCH] net-next: stmmac: dwmac-sun8i: ensure the EPHY is properly reseted

2017-06-04 Thread Icenowy Zheng
The EPHY may be already enabled by bootloaders which have Ethernet capability (e.g. current U-Boot). Thus it should be reseted properly before doing the enabling sequence in the dwmac-sun8i driver, otherwise the EMAC reset process may fail if no cable is plugged, and then fail the dwmac-sun8i probi

[PATCH] net/{mii,smsc}: Make mii_ethtool_get_link_ksettings and smc_netdev_get_ecmd return void

2017-06-04 Thread Yuval Shaia
Make return value void since functions never returns meaningfull value. Signed-off-by: Yuval Shaia --- drivers/net/cris/eth_v10.c | 5 ++--- drivers/net/ethernet/3com/3c59x.c | 4 +++- drivers/net/ethernet/amd/pcnet32.c |

[PATCH] net/3com: Make el3_netdev_get_ecmd return void

2017-06-04 Thread Yuval Shaia
Make return value void since function never returns meaningfull value. Signed-off-by: Yuval Shaia --- drivers/net/ethernet/3com/3c509.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/3com/3c509.c b/drivers/net/ethernet/3com/3c509.c index db8592d

Re: [PATCH] net/dec: Make __de_get_link_ksettings return void

2017-06-04 Thread Sergei Shtylyov
On 6/4/2017 8:22 PM, Sergei Shtylyov wrote: Make return value void since function never return meaningfull value You only make 1 of 2 functions void. It looks like there should be 2 patches. Oh, sorry, I was just blind. B-) MBR, Sergei

Re: [PATCH] net/dec: Make __de_get_link_ksettings return void

2017-06-04 Thread Sergei Shtylyov
Hello! On 6/4/2017 8:08 PM, Yuval Shaia wrote: Make return value void since function never return meaningfull value You only make 1 of 2 functions void. It looks like there should be 2 patches. Signed-off-by: Yuval Shaia --- drivers/net/ethernet/dec/tulip/de2104x.c | 11 --- 1

Re: [PATCH] net/phy: Delete unused function phy_ethtool_gset

2017-06-04 Thread Florian Fainelli
On 06/04/2017 10:10 AM, Yuval Shaia wrote: > Signed-off-by: Yuval Shaia A commit message that just says: it's unused, so remove it would be nice. You seem to have missed Documentation/networking/phy.txt in this patch, do you mind resubmitting with that fixed? Finally, the subject should be: n

Re: [PATCH net-next] genetlink: remove ops_list from genetlink header.

2017-06-04 Thread Sergei Shtylyov
Hello! On 6/4/2017 10:07 AM, Rami Rosen wrote: commit d91824 ("genetlink: register family ops as array") removed the At least 12 digits required. ops_list member from both genl_family and genl_ops; while the documentation of genl_family was updated accordingly by this patch, ops_list rem

[PATCH] net/phy: Make phy_ethtool_ksettings_get return void

2017-06-04 Thread Yuval Shaia
Make return value void since function never return meaningfull value Signed-off-by: Yuval Shaia --- drivers/net/ethernet/broadcom/b44.c| 3 ++- drivers/net/ethernet/broadcom/bcm63xx_enet.c | 3 ++- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 4 +++- drivers/net/

[PATCH] net/phy: Delete unused function phy_ethtool_gset

2017-06-04 Thread Yuval Shaia
Signed-off-by: Yuval Shaia --- drivers/net/phy/phy.c | 24 include/linux/phy.h | 1 - 2 files changed, 25 deletions(-) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 9c372bf..8e26af5 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -

[PATCH] net/dec: Make __de_get_link_ksettings return void

2017-06-04 Thread Yuval Shaia
Make return value void since function never return meaningfull value Signed-off-by: Yuval Shaia --- drivers/net/ethernet/dec/tulip/de2104x.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c b/drivers/net/ethernet/dec/tulip/

Re: [PATCH 7/7] mlx5: Do not build eswitch_offloads if CONFIG_MLX5_EN_ESWITCH_OFFLOADS is set

2017-06-04 Thread Or Gerlitz
On Sat, Jun 3, 2017 at 10:37 PM, Or Gerlitz wrote: > On Fri, Jun 2, 2017 at 11:22 PM, Jes Sorensen wrote: >> On 05/28/2017 02:03 AM, Or Gerlitz wrote: >>> >>> On Sun, May 28, 2017 at 5:23 AM, Jes Sorensen >>> wrote: On 05/27/2017 05:02 PM, Or Gerlitz wrote: > > > On Sat, Ma

[patch net-next] net: sched: select cls when cls_act is enabled

2017-06-04 Thread Jiri Pirko
From: Jiri Pirko It really makes no sense to have cls_act enabled without cls. In that case, the cls_act code is dead. So select it. This also fixes an issue recently reported by kbuild robot: [linux-next:master 1326/4151] net/sched/act_api.c:37:18: error: implicit declaration of function 'tcf_

[PATCH] ath6kl: fix spelling mistake: "Indicat" -> "Indicate"

2017-06-04 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in ath6kl_dbg debug message Signed-off-by: Colin Ian King --- drivers/net/wireless/ath/ath6kl/htc_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath6kl/htc_pipe.c b/drivers/net/wireless/a

[patch net-next 2/3] mlxsw: Fix typo inside enumeration

2017-06-04 Thread Jiri Pirko
From: Ido Schimmel Signed-off-by: Ido Schimmel Reviewed-by: Petr Machata Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 2 +- drivers/net/ethernet/mellanox/mlxsw/spectrum_fid.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drive

[patch net-next 1/3] mlxsw: spectrum: Tidy up header file

2017-06-04 Thread Jiri Pirko
From: Ido Schimmel Make it clear where functions are defined and move misplaced declaration to their correct place. Signed-off-by: Ido Schimmel Reviewed-by: Petr Machata Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.h | 47 ++ 1 file chang

[patch net-next 3/3] mlxsw: spectrum_router: Align RIF index allocation with existing code

2017-06-04 Thread Jiri Pirko
From: Ido Schimmel The way we usually allocate an index is by letting the allocation function return an error instead of an invalid index. Do the same for RIF index. Signed-off-by: Ido Schimmel Reviewed-by: Petr Machata Signed-off-by: Jiri Pirko --- .../net/ethernet/mellanox/mlxsw/spectrum_

[patch net-next 0/3] mlxsw: Minor cleanup

2017-06-04 Thread Jiri Pirko
From: Jiri Pirko Fix small issues I noticed during the refactoring. First patch adds file name comments in the header file to make it clear what goes where. Second patch fixes a typo and third patch simply aligns RIF index allocation with similar allocations in the driver. Ido Schimmel (3): m

[patch net-next] mlxsw: spectrum: Rename the firmware file

2017-06-04 Thread Jiri Pirko
From: Yotam Gigi Change the firmware file name to be in "mellanox" directory. This commit is a followup to the linux-firmware commit a4c72696f5f4 ("Mellanox: Add firmware for mlxsw_spectrum") Signed-off-by: Yotam Gigi Reviewed-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/net/ether

Re: [net-next PATCH 2/3] net: reduce cycles spend on ICMP replies that gets rate limited

2017-06-04 Thread Jesper Dangaard Brouer
On Sun, 4 Jun 2017 09:11:53 +0200 Florian Weimer wrote: > On 01/09/2017 04:04 PM, Jesper Dangaard Brouer wrote: > > > This patch split the global and per (inet)peer ICMP-reply limiter > > code, and moves the global limit check to earlier in the packet > > processing path. Thus, avoid spending cy

[PATCH net-next] genetlink: remove ops_list from genetlink header.

2017-06-04 Thread Rami Rosen
commit d91824 ("genetlink: register family ops as array") removed the ops_list member from both genl_family and genl_ops; while the documentation of genl_family was updated accordingly by this patch, ops_list remained in the documentation of the genl_ops object. This patch fixes it by removing

Re

2017-06-04 Thread mail
 Hey

Re: [PATCH] devlink: fix potential memort leak

2017-06-04 Thread Arkadi Sharshevsky
On 06/04/2017 03:49 PM, Haishuang Yan wrote: > We must free allocated skb when genlmsg_put() return fails. > > Fixes: 1555d204e743 ("devlink: Support for pipeline debug (dpipe)") > Signed-off-by: Haishuang Yan > --- > net/core/devlink.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-

[PATCH] devlink: fix potential memort leak

2017-06-04 Thread Haishuang Yan
We must free allocated skb when genlmsg_put() return fails. Fixes: 1555d204e743 ("devlink: Support for pipeline debug (dpipe)") Signed-off-by: Haishuang Yan --- net/core/devlink.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/core/devlink.c b/net/core/devlink.c index

[PATCH iproute2 V2] iplink: Update usage in help message

2017-06-04 Thread Tariq Toukan
From: Eli Cohen Add to usage message a description of how to configure Infiniband node and port GUIDs. Also modify the man page to emphasize the GUIDs are configured for Infiniband VFs. Fixes: d91fb3f4c7e4 ("Add support for configuring Infiniband GUIDs") Signed-off-by: Eli Cohen Signed-off-by:

[PATCH net V4] net/mlx4: Fix the check in attaching steering rules

2017-06-04 Thread Tariq Toukan
From: Talat Batheesh Our previous patch (cited below) introduced a regression for RAW Eth QPs. Fix it by checking if the QP number provided by user-space exists, hence allowing steering rules to be added for valid QPs only. Fixes: 89c557687a32 ("net/mlx4_en: Avoid adding steering rules with inv

[PATCH net-next 05/11] qed: Assign a unique per-queue index to queue-cid

2017-06-04 Thread Yuval Mintz
When a queue-cid is allocated, assign an index inside that's CID's queue-zone. For PFs and VFS, this number is going to be unique and derive from a per-queue-zone bitmap, while for PF's VFs queues the number is currently going to constant; Later, we'd add the capability of a VF to communicate such

[PATCH net-next 07/11] qed: IOV db support multiple queues per qzone

2017-06-04 Thread Yuval Mintz
Allow the infrastructure a PF maintains for each one of its VFs to support multiple queue-cids on a single queue-zone. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_l2.c| 12 +- drivers/net/ethernet/qlogic/qed/qed_l2.h| 3 + drivers/net/ethernet/qlogic/qed/qed_sri

[PATCH net-next 11/11] qede: VF XDP support

2017-06-04 Thread Yuval Mintz
This introduces 2 changes needed for XDP to be supported for VFs: a. On VF-side, publish the NDO based on qed outputs b. On PF-side, request qed to allocate sufficient cids per-VF to allow the child vfs to support it Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede_ma

[PATCH net-next 09/11] qed: VFs to try utilizing the doorbell bar

2017-06-04 Thread Yuval Mintz
VFs are currently not mapping their doorbell bar, instead relying on the small doorbell window they have in their limited regview bar. In order to increase the number of possible Tx connections [queues] employeed by VF past 16, we need to start using the doorbell bar if one such is exposed - VF wo

[PATCH net-next 06/11] qed: Make VF legacy a bitfield

2017-06-04 Thread Yuval Mintz
Until now we used to have a single VF legacy compatibility mode, one that affected the place of the Rx producers of those VFs [mostly]. As PF would soon support allocating CIDs for VFs instead of having a static CID<->queue configuration for them, we'll need to have an additional legacy mode since

[PATCH net-next 02/11] qed: Create L2 queue database

2017-06-04 Thread Yuval Mintz
First step in allowing a single PF/VF to open multiple queues on the same queue zone is to add per-hwfn database of queue-cids as a two-dimensional array where entry would be according to [queue zone][internal index]. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed.h | 3

[PATCH net-next 03/11] qed*: L2 interface to use the SB structures directly

2017-06-04 Thread Yuval Mintz
Part of an effort of a cleaner seperation between qed and the protocol drivers, the L2 interface is to use the SB structure for initialization purposes opaquely. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_l2.c | 32 +++- drivers/net/ethernet/ql

[PATCH net-next 10/11] qed: VF XDP support

2017-06-04 Thread Yuval Mintz
The final addition on the qed front - - VFs would now require their PFs to provide multiple CIDs - Based on the availability of connections from PF, determine whether XDP is feasible and share it with qede via dev_info. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_l2.c

[PATCH net-next 04/11] qed: Pass vf_params when creating a queue-cid

2017-06-04 Thread Yuval Mintz
We're going to need additional information for queue-cids that a PF creates for its VFs, so start by refactoring existing logic used for initializing said struct into receiving a structure encapsulating the VF-specific information that needs to be provided. This also introduces QED_QUEUE_CID_SELF

[PATCH net-next 08/11] qed: Multiple qzone queues for VFs

2017-06-04 Thread Yuval Mintz
This adds the infrastructure for supporting VFs that want to open multiple transmission queues on the same queue-zone. At this point, there are no VFs that actually request this functionality, but later patches would remedy that. a. VF and PF would communicate the capability during ACQUIRE; L

[no subject]

2017-06-04 Thread Yuval Mintz
Subject: [PATCH net-next 00/11] qed*: Support VF XDP attachment Each driver queue [Rx, Tx, XDP-forwarding] requires an allocated HW/FW connection + configured queue-zone. VF handling by the PF has several limitations that prevented adding the capability to perform XDP at driver-level: - The VF

[PATCH net-next 01/11] qed: Add bitmaps for VF CIDs

2017-06-04 Thread Yuval Mintz
Each PF has a bitmap for its own ranges of CIDs, to allow easy grabbing of an available CID when such is needed. But VFs are not using the same mechanism, instead relying on hard-coded CIDs [ queue-index == cid ]. As an infrastructure step toward increasing number of CIDs of VFs, the PF is going t

RE: [net-next] openvswitch: add macro MODULE_ALIAS_VPORT_TYPE for vport type alias

2017-06-04 Thread 张胜举
> -Original Message- > From: Pravin Shelar [mailto:pshe...@ovn.org] > Sent: Sunday, June 04, 2017 1:58 PM > To: Zhang Shengju > Cc: Pravin Shelar ; Linux Kernel Network Developers > ; David S. Miller > Subject: Re: [net-next] openvswitch: add macro > MODULE_ALIAS_VPORT_TYPE for vport type

Re: [PATCH 04/12] fs: ceph: CURRENT_TIME with ktime_get_real_ts()

2017-06-04 Thread Yan, Zheng
On Fri, Jun 2, 2017 at 10:18 PM, Arnd Bergmann wrote: > On Fri, Jun 2, 2017 at 2:18 PM, Yan, Zheng wrote: >> On Fri, Jun 2, 2017 at 7:33 PM, Arnd Bergmann wrote: >>> On Fri, Jun 2, 2017 at 1:18 PM, Yan, Zheng wrote: >>> What I meant is another related problem in ceph_mkdir() where the >>> i_cti

RE: [for-next 4/6] net/mlx5: FPGA, Add basic support for Innova

2017-06-04 Thread Ilan Tayari
> -Original Message- > From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Subject: Re: [for-next 4/6] net/mlx5: FPGA, Add basic support for Innova > > On Mon, May 29, 2017 at 04:09:06PM +, Ilan Tayari wrote: > > > > For IPSec, this is already in the kernel. > > > See thi

Re: [net-next PATCH 2/3] net: reduce cycles spend on ICMP replies that gets rate limited

2017-06-04 Thread Florian Weimer
On 01/09/2017 04:04 PM, Jesper Dangaard Brouer wrote: > This patch split the global and per (inet)peer ICMP-reply limiter > code, and moves the global limit check to earlier in the packet > processing path. Thus, avoid spending cycles on ICMP replies that > gets limited/suppressed anyhow. > > The