Re: [PATCH v2 4/4] net: macb: Add hardware PTP support

[Richard Cochran]

On Fri, Jun 02, 2017 at 03:28:10PM +0100, Rafal Ozieblo wrote:

> +int gem_get_hwtst(struct net_device *dev, struct ifreq *rq)
> +{
> +     struct macb *bp = netdev_priv(dev);
> +     struct hwtstamp_config *tstamp_config = &bp->tstamp_config;
> +
> +     if ((bp->hw_dma_cap & HW_DMA_CAP_PTP) == 0)
> +             return -EFAULT;

Segmentation fault?  Really?

...

> +int gem_set_hwtst(struct net_device *dev, struct ifreq *ifr, int cmd)
> +{
> +     struct macb *bp = netdev_priv(dev);
> +     struct hwtstamp_config *tstamp_config = &bp->tstamp_config;
> +     enum macb_bd_control tx_bd_control = TSTAMP_DISABLED;
> +     enum macb_bd_control rx_bd_control = TSTAMP_DISABLED;
> +     u32 regval;
> +
> +     if ((bp->hw_dma_cap & HW_DMA_CAP_PTP) == 0)
> +             return -EFAULT;

here again

Thanks,
Richard