From: Yotam Gigi
Make the spectrum module check the current device firmware version, and if
it is below the supported version, use the libfirmware API to request a
firmware file with the supported firmware version and flash it to the
device using the mlxfw module.
The firmware file names are exp
From: Ido Schimmel
In new firmware versions, when configuring a {Port, VID} as a router
interface, the driver is responsible for enabling the STP filter and
disabling learning. Otherwise, packets are discarded.
This change doesn't break existing firmware versions, but is required
for newer firm
From: Yotam Gigi
The MCQI register queries information about firmware components. It will
be needed by the mlxfw module to query various options about the
components, such as their max size, alignment and max write size.
Signed-off-by: Yotam Gigi
Reviewed-by: Ido Schimmel
Signed-off-by: Jiri P
From: Yotam Gigi
This struct was previously an anonymous struct defined inside the
mlxsw_bus_info struct. Extract it to a struct named mlxsw_fw_rev, as it
will be needed later by the spectrum driver.
Signed-off-by: Yotam Gigi
Reviewed-by: Ido Schimmel
Signed-off-by: Jiri Pirko
---
drivers/ne
From: Yotam Gigi
The MCDA register allows reading and writing a firmware component.
Signed-off-by: Yotam Gigi
Reviewed-by: Ido Schimmel
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/reg.h | 52 +++
1 file changed, 52 insertions(+)
diff --git a
From: Yotam Gigi
The MCC register allows controlling and querying the firmware flash state
machine (FSM).
Signed-off-by: Yotam Gigi
Reviewed-by: Ido Schimmel
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/reg.h | 83 +++
1 file changed, 83 inser
From: Yotam Gigi
The mlxfw module is in charge of common logic needed to flash Mellanox
devices firmware, which consists of:
- Parse the Mellanox Firmware Archive version 2 (MFA2) format, which is
the format used to store the Mellanox firmware. The MFA2 format file can
hold firmware for ma
From: Yotam Gigi
The mlxfw module defines several needed callbacks in order to flash the
device's firmware. As the mlxfw module is shared between several different
drivers, those callbacks are the glue functionality that is responsible
for hardware interaction. Add those callbacks using the MCQI,
From: Yotam Gigi
Add callback to the ethtool flash_device op. This callback uses the mlxfw
module to flash the new firmware file to the device.
As the firmware burn process takes about 20 seconds and ethtool takes the
rtnl lock during the flash_device callback, release the rtnl lock at the
begin
From: Jiri Pirko
Add support for device firmware flash on mlxsw spectrum. The firmware files
are expected to be in the Mellanox Firmware Archive version 2 (MFA2)
format.
The firmware flash can be triggered via "ethtool -f" or on driver
initialization time if the device firmware version does not
> > - #1, #2 and #9 correct small missing ethtool functionality.
> > - #3, #6 and #8 correct minor issues in driver, but those are either
> >print-related or unexposed in existing code.
> > - #4 adds proper support to TLB mode bonding.
> > - #10 is meant to improve performance on varying c
From: Tomer Tayar
Today, driver has a synchronization point while closing
the device which synchronizes its slowpath interrupt line.
However, that's insufficient as that ISR would schedule the
slowpath-tasklet - so even after ISR is over it's possible the
handling of the interrupt has not complet
From: Tomer Tayar
Pass additional information about package installed on persistent memory
so that protocol drivers would be able to log it.
Signed-off-by: Tomer Tayar
Signed-off-by: Yuval Mintz
---
drivers/net/ethernet/qlogic/qed/qed_hsi.h | 6 ++
drivers/net/ethernet/qlogic/qed/qed_ma
Replace meaningless logged print ('Ending successfully qede probe')
with a single-liner containing interesting information about probed
device.
Signed-off-by: Yuval Mintz
---
drivers/net/ethernet/qlogic/qede/qede_main.c | 40 ++--
1 file changed, 38 insertions(+), 2 delet
Current API between qed and protocol modules allows passing an
additional private string - but it doesn't get utilized by qed
anywhere.
Clarify the API by removing it and renaming it 'set_name'.
CC: Manish Rangankar
Signed-off-by: Yuval Mintz
---
drivers/net/ethernet/qlogic/qed/qed.h|
From: Tomer Tayar
In case nvram layout of board is incorrect, board may exhibit peculiar
oddities. Log such a rare event.
Signed-off-by: Tomer Tayar
Signed-off-by: Yuval Mintz
---
drivers/net/ethernet/qlogic/qed/qed_dev.c | 5 +
drivers/net/ethernet/qlogic/qed/qed_hsi.h | 2 ++
2 files ch
From: Tomer Tayar
The parameter reflects the number of physical ports connected to a single
engine, not all.
Signed-off-by: Tomer Tayar
Signed-off-by: Yuval Mintz
---
drivers/net/ethernet/qlogic/qed/qed.h | 2 +-
drivers/net/ethernet/qlogic/qed/qed_dev.c | 36 +++-
Signed-off-by: Yuval Mintz
---
include/linux/qed/qed_if.h | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/include/linux/qed/qed_if.h b/include/linux/qed/qed_if.h
index c70ac13..ff590cb 100644
--- a/include/linux/qed/qed_if.h
+++ b/include/linux/qed/qed_if.h
@@ -70
A0 never went public, so no need to protect against it.
Signed-off-by: Yuval Mintz
---
drivers/net/ethernet/qlogic/qed/qed.h | 6 --
drivers/net/ethernet/qlogic/qed/qed_dev.c | 6 --
2 files changed, 12 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qed/qed.h
b/drivers/net/e
From: Michal Kalderon
Since we're closing the parser searching for RDMA when stoping the
fastpath, we need to re-enable it when starting the fastpath once again.
Signed-off-by: Michal Kalderon
Signed-off-by: Yuval Mintz
---
drivers/net/ethernet/qlogic/qed/qed_dev.c | 7 +++
1 file changed
From: Manish Chopra
Flows configuring tunnel ports in HW use the main_ptt which should
be reserved for core-functionality.
Signed-off-by: Manish Chopra
Signed-off-by: Yuval Mintz
---
drivers/net/ethernet/qlogic/qed/qed_dev.c | 3 ++-
drivers/net/ethernet/qlogic/qed/qed_l2.c
From: Manish Chopra
Solves the following warning in qede -
- Several cases of missing cpu_to_le16() conversions
- Adds 'static' to one function declaration
- Removes dcbnl operation that's currently getting populated twice
Signed-off-by: Manish Chopra
Signed-off-by: Yuval Mintz
---
drivers
This series contains some cleanup of the qed and qede code:
- #1 contains mostly static/endian changes in order to allow qede to
pass sparse compilation cleanly.
- #2, #5 and #6 are either semantic or remove dead-code from driver.
- #9, #10 and #11 relate to printing and slightly change some
On Tue, May 23, 2017 at 12:35 AM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Mon, 22 May 2017 18:30:45 +0200
>
> A few update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (5):
> Use kmalloc_array() in sctp_init()
> Delete an error mes
sctp_assoc_set_id has already done the asoc_id check in the beginning
when processing dupcook, no need to do the same check before calling
it.
Signed-off-by: Xin Long
---
net/sctp/associola.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/net/sctp/associola.c b/net/s
> -Original Message-
> From: Andrew Lunn [mailto:and...@lunn.ch]
> Sent: Tuesday, May 23, 2017 4:59 AM
> To: David Miller
> Cc: Daniel Walker ; Harini Katakam
> ; Florian Fainelli ; netdev
> ; Andrew Lunn
> Subject: [PATCH v2 netdev] net: phy: marvell: Limit errata to 88m1101
>
> The 8
On Sat, May 20, 2017 at 6:01 AM, Jiri Pirko wrote:
> From: Jiri Pirko
>
> When user instructs to remove all filters from chain, we cannot destroy
> the chain as other actions may hold a reference. Also the put in errout
> would try to destroy it again. So instead, just walk the chain and remove
>
On Mon, May 22, 2017 at 10:17 PM, Jiri Pirko wrote:
> Mon, May 22, 2017 at 11:04:58PM CEST, xiyou.wangc...@gmail.com wrote:
>>On Mon, May 22, 2017 at 1:54 PM, Cong Wang wrote:
>>> On Sun, May 21, 2017 at 12:19 PM, Jiri Pirko wrote:
>You can't claim you really delete it as long as actions can
On Mon, May 22, 2017 at 10:03 PM, Shubham Bansal
wrote:
> On Tue, May 23, 2017 at 9:52 AM, Kees Cook wrote:
>> On Mon, May 22, 2017 at 8:34 PM, Shubham Bansal
>> wrote:
>>> I would post them as soon as I test them on ARMv5 and ARMv6. If you
>>> can help me with that, please let me know.
>>
>> Pl
From: Sabrina Dubroca
When CONFIG_XFRM_SUB_POLICY=y, xfrm_dst stores a copy of the flowi for
that dst. Unfortunately, the code that allocates and fills this copy
doesn't care about what type of flowi (flowi, flowi4, flowi6) gets
passed. In multiple code paths (from raw_sendmsg, from TCP when
repl
1) Fix wrong header offset for esp4 udpencap packets.
2) Fix a stack access out of bounds when creating a bundle
with sub policies. From Sabrina Dubroca.
3) Fix slab-out-of-bounds in pfkey due to an incorrect
sadb_x_sec_len calculation.
4) We checked the wrong feature flags when taking dow
The sadb_x_sec_len is stored in the unit 'byte divided by eight'.
So we have to multiply this value by eight before we can do
size checks. Otherwise we may get a slab-out-of-bounds when
we memcpy the user sec_ctx.
Fixes: df71837d502 ("[LSM-IPSec]: Security association restriction.")
Reported-by: A
From: Ilan Tayari
Upon NETDEV_DOWN event, all xfrm_state objects which are bound to
the device are flushed.
The condition for this is wrong, though, testing dev->hw_features
instead of dev->features. If a device has non-user-modifiable
NETIF_F_HW_ESP, then its xfrm_state objects are not flushed,
From: Antony Antony
During xfrm migration copy replay and preplay sequence numbers
from the previous state.
Here is a tcpdump output showing the problem.
10.0.10.46 is running vanilla kernel, is the IKE/IPsec responder.
After the migration it sent wrong sequence number, reset to 1.
The migration
Locally generated TCP packets are usually cloned, so we
do skb_cow_data() on this packets. After that we need to
reload the pointer to the esp header. On udpencap this
header has an offset to skb_transport_header, so take this
offset into account.
Fixes: 67d349ed603 ("net/esp4: Fix invalid esph po
This patch fixes the kernel oops when release net_device reference in
advance. In function raw_sendmsg(i think the dgram_sendmsg has the same
problem), there is a race condition between dev_put and dev_queue_xmit
when the device is gong that maybe lead to dev_queue_ximt to see
an illegal net_device
Since commit 3dbcc105d556 ("sctp: alloc stream info when initializing
asoc"), stream and stream.out info are always alloced when creating
an asoc.
So it's not correct to check !asoc->stream before updating stream
info when processing dupcookie, but would be better to check asoc
state instead.
Fix
After sctp changed to use transport hashtable, a transport would be
added into global hashtable when adding the peer to an asoc, then
the asoc can be got by searching the transport in the hashtbale.
The problem is when processing dupcookie in sctp_sf_do_5_2_4_dupcook,
a new asoc would be created.
After introducing transport hashtable and per stream info into sctp,
some regressions were caused when processing dupcookie, this patchset
is to fix them.
Xin Long (2):
sctp: fix stream update when processing dupcookie
sctp: set new_asoc temp when processing dupcookie
net/sctp/associola.c
Explicit set skb->sk is needless, sock_alloc_send_skb is already set it.
Signed-off-by: Lin Zhang
Acked-by: Stefan Schmidt
---
changelog:
v1 -> v2:
* split v1 into two patches, per Stefan Schmidt.
Thanks to Stefan Schmidt for reviewing !
---
net/ieee802154/socket.c | 2 --
1 file chan
Mon, May 22, 2017 at 11:04:58PM CEST, xiyou.wangc...@gmail.com wrote:
>On Mon, May 22, 2017 at 1:54 PM, Cong Wang wrote:
>> On Sun, May 21, 2017 at 12:19 PM, Jiri Pirko wrote:
You can't claim you really delete it as long as actions can still
see it and dump it.
>>>
>>> No, user just wants
Tue, May 23, 2017 at 01:57:47AM CEST, xiyou.wangc...@gmail.com wrote:
>On Mon, May 22, 2017 at 8:09 AM, Jiri Pirko wrote:
>> From: Jiri Pirko
>>
>> With the introduction of chain goto action, the reclassification would
>> cause the re-iteration of the actual chain. But it perhaps makes more
>> se
Hi Kees,
I already have ARMv5 and ARMv6 code written. I just haven't tested it
yet. Should i send the patch with those as well ?
Best,
Shubham Bansal
On Tue, May 23, 2017 at 9:52 AM, Kees Cook wrote:
> On Mon, May 22, 2017 at 8:34 PM, Shubham Bansal
> wrote:
>> I would post them as soon as I
This fix addresses two problems in the way the DSCP field is formulated
on the encapsulating header of IPv6 tunnels.
1) The IPv6 tunneling code was manipulating the DSCP field of the
encapsulating packet using the 32b flowlabel. Since the flowlabel is
only the lower 20b it was incorrect to assu
On Sun, May 21, 2017 at 1:12 PM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Sun, 21 May 2017 22:09:11 +0200
>
> A few update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (5):
> Improve a size determination in four functions
> Delete a
On Mon, May 22, 2017 at 7:58 PM, Shubham Bansal
wrote:
> On testing the eBPF JIT with CONFIG_FRAME_POINTER I got the following
> crash for non jitted testcase.
It's just a softlockup WARN, not a crash, and I think it'd to be
expected given the large runtime test_bpf reports:
> [ 72.032494] tes
On Mon, May 22, 2017 at 8:34 PM, Shubham Bansal
wrote:
> I would post them as soon as I test them on ARMv5 and ARMv6. If you
> can help me with that, please let me know.
Please post what you have: it would be better to see what you've got
now in case additional changes are needed so you don't hav
From: David Miller
Date: Mon, 22 May 2017 19:54:44 -0400 (EDT)
> From: Pablo Neira Ayuso
> Date: Mon, 22 May 2017 00:25:38 +0200
>
>> Could you merge net into net-next as well? I have several patches for
>> net-next that need to apply on these fixes. No rush BTW.
>
> Sure, no problem.
>
> As
Hi Florian,
>> I think it is fine to only target ARMv7. It is harder and harder to
>> find devices on v5 or v6 CPUs that would want to be using BPF JIT,
>> IMO.
>
> There are still a ton of Marvell-based routers out there (e.g: Kirkwood,
> Orion5x) that are ARMv5 and that prompted Nicholas (hey th
On 5/22/17, 20:08, "David Miller" wrote:
From: Teng Qin
Date: Tue, 23 May 2017 00:39:34 +
> diff --git a/samples/bpf/bpf_helpers.h b/samples/bpf/bpf_helpers.h
> index 9a9c95f..a94ce42 100644
> --- a/samples/bpf/bpf_helpers.h
> +++ b/samples/bpf/bpf_helpers.h
On 2017/05/21 11:28, Manohar Kumar wrote:
> Hello,
>
> In 3.19 the following bridge fdb command to delete a dynamically
> learned entry fails..
>
> root@net-3:~# bridge fdb show | grep 02:42:0a:ff:00:06
> 02:42:0a:ff:00:06 dev vxlan0 master br0
> root@net-3:~# bridge fdb del 02:42:0a:ff:00:06 dev
At 2017-05-23 11:02:20, "David Miller" wrote:
>From: gfree.w...@vip.163.com
>Date: Tue, 23 May 2017 08:45:11 +0800
>
>> From: Gao Feng
>>
>> When the new RFS table size specified by sysctl equals the old one,
>> there is nothing changed actually. So it is unnecessary to reset the
>> RFS table en
From: Teng Qin
Date: Tue, 23 May 2017 00:39:34 +
> diff --git a/samples/bpf/bpf_helpers.h b/samples/bpf/bpf_helpers.h
> index 9a9c95f..a94ce42 100644
> --- a/samples/bpf/bpf_helpers.h
> +++ b/samples/bpf/bpf_helpers.h
> @@ -37,9 +37,8 @@ static int (*bpf_clone_redirect)(void *ctx, int ifindex
From: gfree.w...@vip.163.com
Date: Tue, 23 May 2017 08:45:11 +0800
> From: Gao Feng
>
> When the new RFS table size specified by sysctl equals the old one,
> there is nothing changed actually. So it is unnecessary to reset the
> RFS table entris.
>
> Signed-off-by: Gao Feng
It seems like an i
Hi,
On testing the eBPF JIT with CONFIG_FRAME_POINTER I got the following
crash for non jitted testcase.
[ 72.032494] test_bpf: #267 BPF_MAXINSNS: Call heavy transformations
jited:0 1112799
[ 92.304815] NMI watchdog: BUG: soft lockup - CPU#0 stuck for 22s!
[insmod:104]
[ 92.305050] Modules
From: Quentin Schulz Sent: Monday, May 22,
2017 5:15 PM
>Some PHY require to wait for a bit after the reset GPIO has been toggled. This
>adds support for the DT property `phy-reset-post-delay` which gives the delay
>in milliseconds to wait after reset.
>
>If the DT property is not given, no delay
Hello.
Sorry too late to reply.
>
> Hello.
>
> On Thu, 2017-05-18 at 15:14, Stefan Schmidt wrote:
> > Hello.
> >
> > On Thu, 2017-05-18 at 15:50, linzhang wrote:
> > > This patch fixes the kernel oops when release net_device reference in
> > > advance. In function raw_sendmsg(i think the dgram_sen
From: Gao Feng
When the new RFS table size specified by sysctl equals the old one,
there is nothing changed actually. So it is unnecessary to reset the
RFS table entris.
Signed-off-by: Gao Feng
---
net/core/sysctl_net_core.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --gi
From: Teng Qin
This commit updates function signature of the bpf_perf_event_output and
bpf_perf_event_read helpers to match their implementation. Also updates
their documentation in the header files.
Signed-off-by: Teng Qin
Acked-by: Alexei Starovoitov
---
include/uapi/linux/bpf.h | 11
From: Vladislav Yasevich
Date: Thu, 18 May 2017 09:31:03 -0400
> It appears that since commit 8cb65d000, Q-in-Q vlans have been
> broken. The series that commit is part of enabled TSO and checksum
> offloading on Q-in-Q vlans. However, most HW we support can't handle
> it. To work around the i
On Mon, May 22, 2017 at 8:09 AM, Jiri Pirko wrote:
> From: Jiri Pirko
>
> With the introduction of chain goto action, the reclassification would
> cause the re-iteration of the actual chain. But it perhaps makes more
> sense to restart the whole thing. Thoughts?
I think reclassification is meant
From: Pablo Neira Ayuso
Date: Mon, 22 May 2017 00:25:38 +0200
> Could you merge net into net-next as well? I have several patches for
> net-next that need to apply on these fixes. No rush BTW.
Sure, no problem.
As soon as Linus takes in my pull request from today, I will do this
and let you kno
On Mon, May 22, 2017 at 4:38 PM, Andy Lutomirski wrote:
> I think that having the un-resettable mode is unnecessary. We should
> have option that disables loading modules entirely and cannot be
> unset. (That means no explicit loads and not implicit loads.) Maybe
> we already have this. Otherw
From: Alexei Starovoitov
Date: Mon, 22 May 2017 16:35:07 -0700
> yet perf_event_read() is least documented. hmm.
> * u64 bpf_perf_event_read(&map, index)
> * Return: Number events read or error code
>
> that needs to be fixed.
That's exactly what I was talking about :-)
On Mon, May 22, 2017 at 4:07 PM, Kees Cook wrote:
> On Mon, May 22, 2017 at 12:55 PM, Djalal Harouni wrote:
>> On Mon, May 22, 2017 at 6:43 PM, Solar Designer wrote:
>>> On Mon, May 22, 2017 at 03:49:15PM +0200, Djalal Harouni wrote:
On Mon, May 22, 2017 at 2:08 PM, Solar Designer wrote:
>
On 5/22/17 4:26 PM, David Miller wrote:
From: Alexei Starovoitov
Date: Mon, 22 May 2017 15:48:40 -0700
@@ -31,7 +31,7 @@ static unsigned long long (*bpf_get_current_uid_gid)(void) =
(void *) BPF_FUNC_get_current_uid_gid;
static int (*bpf_get_current_comm)(void *buf, int buf_size) =
From: Florian Fainelli
Date: Mon, 22 May 2017 13:01:06 -0700
> For this entire series:
>
> Tested-by: Florian Fainelli
>
> on a 7445 (bcm-sf2), normal bridging still worked, and bridging with
> VLAN filtering also did, just like adding VLANs to user-facing ports
> also did.
>
> Great job!
Se
The 88m1101 has an errata when configuring autoneg. However, it was
being applied to many other Marvell PHYs as well. Limit its scope to
just the 88m1101.
Fixes: 76884679c644 ("phylib: Add support for Marvell 88eS and 88e1145")
Reported-by: Daniel Walker
Signed-off-by: Andrew Lunn
---
v2:
From: Alexei Starovoitov
Date: Mon, 22 May 2017 15:48:40 -0700
> @@ -31,7 +31,7 @@ static unsigned long long (*bpf_get_current_uid_gid)(void) =
> (void *) BPF_FUNC_get_current_uid_gid;
> static int (*bpf_get_current_comm)(void *buf, int buf_size) =
> (void *) BPF_FUNC_get_current_com
On Mon, May 22, 2017 at 12:55 PM, Djalal Harouni wrote:
> On Mon, May 22, 2017 at 6:43 PM, Solar Designer wrote:
>> On Mon, May 22, 2017 at 03:49:15PM +0200, Djalal Harouni wrote:
>>> On Mon, May 22, 2017 at 2:08 PM, Solar Designer wrote:
>>> > On Mon, May 22, 2017 at 01:57:03PM +0200, Djalal Ha
From: Teng Qin
This commit adds support for attach BPF program to RAW and HW_CACHE type
events, and support for read HW_CACHE type event counters in BPF
program. Existing code logic already supports them, so this commit is
just update Enum value checks.
Signed-off-by: Teng Qin
Signed-off-by: Al
Patch 1: add support for HW_CACHE and RAW perf events to bpf:
- similar to PERF_TYPE_RAW and PERF_TYPE_HARDWARE allow PERF_TYPE_HW_CACHE
events to be accessed via bpf_perf_event_read()
- similar to PERF_TYPE_HARDWARE and PERF_TYPE_SOFTWARE allow bpf programs
to attch to PERF_TYPE_HW_CACHE and P
From: Teng Qin
This commit adds sample to test attach BPF to HW_CACHE and RAW type
events into the trace_event sample. The test outputs a lot of things to
screen, therefore make sure it aborts on error so it's easier to see if
everything works. Also update clean-up logic to disable the perf event
On Mon, May 22, 2017 at 4:57 AM, Djalal Harouni wrote:
> [...]
> diff --git a/kernel/module.c b/kernel/module.c
> index 4a3665f..ce7a146 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -282,6 +282,8 @@ module_param(sig_enforce, bool_enable_only, 0644);
>
> /* Block module loading/unlo
> > > > +static int get_vlan_table(struct dsa_switch *ds, u16 vid, u32
> *vlan_table)
> > > > +{
> > > > + struct ksz_device *dev = ds->priv;
> > > > + u8 data;
> > > > + int timeout = 1000;
> > > > +
> > > > + ksz_write16(dev, REG_SW_VLAN_ENTRY_INDEX__2, vid &
> > > VLAN_IN
On Mon, May 22, 2017 at 4:57 AM, Djalal Harouni wrote:
> This is a preparation patch for the module auto-load restriction feature.
>
> In order to restrict module auto-load operations we need to check if the
> caller has CAP_SYS_MODULE capability. This allows to align security
> checks of automati
On 05/22/2017 02:19 PM, Timur Tabi wrote:
> On 05/22/2017 04:10 PM, Florian Fainelli wrote:
>> Even a module argument would be rejected. If you need platform/SoC
>> specific behavior propagated down to the PHY driver, several options exist:
>>
>> - pass an agreed upon value for phy_flags to of_phy_
On Mon, 22 May 2017, Michael S. Tsirkin wrote:
> On Mon, May 22, 2017 at 10:25:19AM -0400, Mikulas Patocka wrote:
> > Hi
> >
> > I see severe network performance degradation with the kernels 4.12-rc1 and
> > 4.12-rc2 in the network virtio driver. Download rate drops down to about
> > 100kB/s.
Hi Andreas,
On Sun, May 21, 2017 at 9:20 AM, Andreas Färber wrote:
> Hello,
>
> The NanoPi K2 has an Ampak AP6212 SDIO module. brcmfmac driver loads
> brcmfmac43430-sdio.bin.
>
> When using the firmware file from linux-firmware.git that openSUSE ships
> I get the following errors on 4.11.0 and ne
> I'll have to test this, but what do I do if I don't get another interrupt?
It probably means interrupts cannot be used. Poll it.
Andrew
On Mon, May 22, 2017 at 1:42 PM, Jesper Dangaard Brouer
wrote:
> On Mon, 22 May 2017 08:39:35 +0200
> Jesper Dangaard Brouer wrote:
>
>> On Sun, 21 May 2017 15:10:29 -0700
>> Tom Herbert wrote:
>>
>> > On Sun, May 21, 2017 at 9:04 AM, Jesper Dangaard Brouer
>> > wrote:
>> > > On Sat, 20 May 201
On 05/22/2017 04:09 PM, Andrew Lunn wrote:
> Are you using interrupts? Or polling?
adpt->phydev->irq = PHY_IGNORE_INTERRUPT;
ret = phy_connect_direct(netdev, adpt->phydev, emac_adjust_link,
PHY_INTERFACE_MODE_SGMII);
Technically it's polling, except that it's my NIC's har
On Mon, May 22, 2017 at 09:21:28PM +, woojung@microchip.com wrote:
> Hi Andres,
>
> > > +static struct {
> > > + int index;
> > > + char string[ETH_GSTRING_LEN];
> >
> > Hi Woojung
> >
> > Since you need to respin for the skb_put_padto(), please make this
> > const.
> OK.
>
> > > +stati
On Mon, May 22, 2017 at 12:26 PM, Sebastian Andrzej Siewior
wrote:
> Since commit 217f69743681 ("net: busy-poll: allow preemption in
> sk_busy_loop()") there is an explicit do_softirq() invocation after
> local_bh_enable() has been invoked.
> I don't understand why we need this because local_bh_en
Hi Andres,
> > +static struct {
> > + int index;
> > + char string[ETH_GSTRING_LEN];
>
> Hi Woojung
>
> Since you need to respin for the skb_put_padto(), please make this
> const.
OK.
> > +static int get_vlan_table(struct dsa_switch *ds, u16 vid, u32 *vlan_table)
> > +{
> > + struct ksz_d
This field is sizeof of corresponding kmem_cache so it can't be negative.
Space will be saved after 32-bit kmem_cache_create() patch.
Signed-off-by: Alexey Dobriyan
---
include/net/request_sock.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/include/net/request_sock.h
+++ b/i
This field is sizeof of corresponding kmem_cache so it can't be negative.
Prepare for 32-bit kmem_cache_create().
Signed-off-by: Alexey Dobriyan
---
include/net/inet_frag.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/include/net/inet_frag.h
+++ b/include/net/inet_frag.h
@@
On 05/22/2017 04:10 PM, Florian Fainelli wrote:
> Even a module argument would be rejected. If you need platform/SoC
> specific behavior propagated down to the PHY driver, several options exist:
>
> - pass an agreed upon value for phy_flags to of_phy_connect() see
> drivers/net/ethernet/broadcom/t
On 05/22/2017 02:02 PM, Andrew Lunn wrote:
>> 2. I'm preparing a patch that adds a command-line parameter to at803x that
>> makes this code conditional.
>
> FYI:
>
> A patch with a command line argument, i think you actually mean a
> module argument, is very likely to be rejected.
Even a module
On Mon, May 22, 2017 at 03:12:03PM -0500, Timur Tabi wrote:
> On 10/24/2016 05:40 AM, Zefir Kurtisi wrote:
> > This commit adds a wrapper function for at8031
> > that in case of operating in SGMII mode double
> > checks SGMII link state when generic aneg_done()
> > succeeds. It prints a warning on
On Mon, May 22, 2017 at 1:54 PM, Cong Wang wrote:
> On Sun, May 21, 2017 at 12:19 PM, Jiri Pirko wrote:
>>>You can't claim you really delete it as long as actions can still
>>>see it and dump it.
>>
>> No, user just wants to delete all the filters. That is done. User does
>> not care if the actua
Hi Arend,
Sorry, I forgot that the original message wasn't Cc'ed to the wireless
list, only netdev.
> +++ b/net/wireless/scan.c
> @@ -322,9 +322,7 @@ static void cfg80211_del_sched_scan_req(struct
> cfg80211_regi
> {
> struct cfg80211_sched_scan_request *pos;
>
> - ASSERT_RTNL();
On 22-5-2017 14:09, Arend van Spriel wrote:
> On 5/22/2017 12:57 PM, Johannes Berg wrote:
>> On Mon, 2017-05-22 at 12:36 +0200, Sander Eikelenboom wrote:
>>> Hi,
>>>
>>> I encountered this splat with 4.12-RC2.
>>
>> Ugh, yeah, I should've seen that in the review.
>>
>> Arend, please take a look a
> 2. I'm preparing a patch that adds a command-line parameter to at803x that
> makes this code conditional.
FYI:
A patch with a command line argument, i think you actually mean a
module argument, is very likely to be rejected.
Andrew
On 05/22/2017 12:39 PM, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Mon, 22 May 2017 17:43:44 +0200
>
> Add a missing character in this description.
>
> Signed-off-by: Markus Elfring
> ---
> net/sctp/protocol.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
On 05/22/2017 12:41 PM, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Mon, 22 May 2017 18:15:12 +0200
>
> The script "checkpatch.pl" pointed information out like the following.
>
> ERROR: do not use assignment in if condition
>
> Thus fix the affected source code place.
>
> Signed-of
On 05/22/2017 12:40 PM, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Mon, 22 May 2017 18:08:24 +0200
>
> Replace the specification of a data structure by a pointer dereference
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer accord
On 05/22/2017 12:38 PM, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Mon, 22 May 2017 17:28:14 +0200
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Link:
> http://events.linuxfoundation.or
On 05/22/2017 12:37 PM, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Mon, 22 May 2017 17:20:11 +0200
>
> * A multiplication for the size determination of a memory allocation
> indicated that an array data structure should be processed.
> Thus use the corresponding function "kmalloc
On Sun, May 21, 2017 at 12:19 PM, Jiri Pirko wrote:
>>You can't claim you really delete it as long as actions can still
>>see it and dump it.
>
> No, user just wants to delete all the filters. That is done. User does
> not care if the actual chain structure is there or not.
>
Hmm, so users see a
1 - 100 of 345 matches
Mail list logo
