[PATCHv2 net-next 0/4] MV88E6390 batch two

2016-12-02 Thread Andrew Lunn
This is the second batch of patches adding support for the MV88e6390. They are not sufficient to make it work properly. The mv88e6390 has a much expanded set of priority maps. Refactor the existing code, and implement basic support for the new device. Similarly, the monitor control register has b

Re: [PATCH net-next 2/4] mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs

2016-12-02 Thread Eric Dumazet
On Fri, 2016-12-02 at 19:42 -0800, Martin KaFai Lau wrote: > On Fri, Dec 02, 2016 at 06:15:26PM -0800, Eric Dumazet wrote: > > My question was more like : > > > > Can we double check all these patches wont break mlx4 driver (non XDP > > path) on arches with PAGE_SIZE=64KB. > The page/pkt requiremen

[PATCH v1 net-next 1/5] net: dsa: mv88e6xxx: Reserved Management frames to CPU

2016-12-02 Thread Andrew Lunn
Older devices have a couple of registers in global2. The mv88e6390 family has a single register in global1 behind which hides similar configuration. Implement and op for this. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 35 drivers/net/dsa/

[PATCH v1 net-next 0/5] mv88e6390 batch 3

2016-12-02 Thread Andrew Lunn
More patches to support the MV88e6390. This is mostly refactoring existing code and adding implementations for the mv88e6390. This patchset set which reserved frames are sent to the cpu, the size of jumbo frames that will be accepted, turn off egress rate limiting, and configuration of pause frame

[PATCH v1 net-next 4/5] net: dsa: mv88e6xxx: Refactor pause configuration

2016-12-02 Thread Andrew Lunn
The mv88e6390 has a different mechanism for configuring pause. Refactor the code into an ops function, and for the moment, don't add any mv88e6390 code yet. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 28 drivers/net/dsa/mv88e6xxx/mv88e6xxx

[PATCH v1 net-next 2/5] net: dsa: mv88e6xxx: Refactor setting of jumbo frames

2016-12-02 Thread Andrew Lunn
Some switches support jumbo frames. Refactor this code into operations in the ops structure. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 26 ++ drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 1 + drivers/net/dsa/mv88e6xxx/port.c | 14

[PATCH v1 net-next 5/5] net: dsa: mv88e6xxx: Implement mv88e6390 pause control

2016-12-02 Thread Andrew Lunn
The mv88e6390 has a number flow control registers accessed via the Flow Control register. Use these to set the pause control. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 7 +++ drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 2 ++ drivers/net/dsa/mv88e6xxx/port.c |

[PATCH v1 net-next 3/5] net: dsa: mv88e6xxx: Refactor egress rate limiting

2016-12-02 Thread Andrew Lunn
There are two different rate limiting configurations, depending on the switch generation. Refactor this into ops. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 31 +++ drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 2 ++ drivers/net/dsa/mv88e6xxx/po

Re: [PATCH net-next 1/4] bpf: xdp: Allow head adjustment in XDP prog

2016-12-02 Thread Martin KaFai Lau
On Sat, Dec 03, 2016 at 01:22:05AM +0100, Daniel Borkmann wrote: > On 12/03/2016 12:23 AM, Martin KaFai Lau wrote: > >This patch allows XDP prog to extend/remove the packet > >data at the head (like adding or removing header). It is > >done by adding a new XDP helper bpf_xdp_adjust_head(). > > > >

Re: [PATCH net-next 2/4] mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs

2016-12-02 Thread Martin KaFai Lau
On Fri, Dec 02, 2016 at 06:15:26PM -0800, Eric Dumazet wrote: > On Fri, 2016-12-02 at 16:53 -0800, Alexei Starovoitov wrote: > > On 12/2/16 4:38 PM, Eric Dumazet wrote: > > > On Fri, 2016-12-02 at 15:23 -0800, Martin KaFai Lau wrote: > > >> When XDP prog is attached, it is currently limiting > > >>

[PATCH v3 net-next 1/4] net: dsa: mv88e6xxx: Implement mv88e6390 tag remap

2016-12-02 Thread Andrew Lunn
The mv88e6390 does not have the two registers to set the frame priority map. Instead it has an indirection registers for setting a number of different priority maps. Refactor the old code into an function, implement the mv88e6390 version, and use an op to call the right one. Signed-off-by: Andrew

[PATCH v3 net-next 2/4] net: dsa: mv88e6xxx: Monitor and Management tables

2016-12-02 Thread Andrew Lunn
The mv88e6390 changes the monitor control register into the Monitor and Management control, which is an indirection register to various registers. Add ops to set the CPU port and the ingress/egress port for both register layouts, to global1 Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6x

[PATCH v3 net-next 4/4] net: dsa: mv88e6xxx: Refactor CPU and DSA port setup

2016-12-02 Thread Andrew Lunn
Older chips only support DSA tagging. Newer chips have both DSA and EDSA tagging. Refactor the code by adding port functions for setting the frame mode, egress mode, and if to forward unknown frames. This results in the helper mv88e6xxx_6065_family() becoming unused, so remove it. Signed-off-by:

[PATCH v3 net-next 3/4] net: dsa: mv88e6xxx: Move the tagging protocol into info

2016-12-02 Thread Andrew Lunn
Older chips support a single tagging protocol, DSA. New chips support both DSA and EDSA, an enhanced version. Having both as an option changes the register layouts. Up until now, it has been assumed that if EDSA is supported, it will be used. Hence the register layout has been determined by which p

Re: [net-next PATCH v4 5/6] virtio_net: add XDP_TX support

2016-12-02 Thread John Fastabend
On 16-12-02 12:51 PM, John Fastabend wrote: > This adds support for the XDP_TX action to virtio_net. When an XDP > program is run and returns the XDP_TX action the virtio_net XDP > implementation will transmit the packet on a TX queue that aligns > with the current CPU that the XDP packet was proce

Re: [PATCH 2/3] uapi: export tc_skbmod.h

2016-12-02 Thread kbuild test robot
Hi Stephen, [auto build test ERROR on linus/master] [also build test ERROR on v4.9-rc7] [cannot apply to next-20161202] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Stephen-Hemminger/UAPI

Re: [PATCH] net: wireless: realtek: constify rate_control_ops structures

2016-12-02 Thread Bhumika Goyal
On Sat, Dec 3, 2016 at 2:09 AM, Larry Finger wrote: > On 12/02/2016 03:50 AM, Bhumika Goyal wrote: >> >> The structures rate_control_ops are only passed as an argument to the >> functions ieee80211_rate_control_{register/unregister}. This argument is >> of type const, so rate_control_ops having th

[PATCH net-next v2 1/4] bnxt_en: Re-factor bnxt_setup_tc().

2016-12-02 Thread Michael Chan
Add a new function bnxt_setup_mq_tc() to handle MQPRIO. This new function will be called during ETS setup when we add DCBNL in the next patch. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 18 ++ drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 + 2 f

[PATCH net-next v2 2/4] bnxt_en: Update firmware header file to latest 1.6.0.

2016-12-02 Thread Michael Chan
Latest interface has the latest DCB command structs. Get and store the max number of lossless TCs the hardware can support. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 28 +- drivers/net/ethernet/broadcom/bnxt/bnxt.h |5 +- drivers/net/ethernet/

[PATCH net-next v2 4/4] bnxt_en: Add PFC statistics.

2016-12-02 Thread Michael Chan
Report PFC statistics to ethtool -S and DCBNL. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 7 +++ drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c | 14 +- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 23 --- 3

[PATCH net-next v2 3/4] bnxt_en: Implement DCBNL to support host-based DCBX.

2016-12-02 Thread Michael Chan
Support only IEEE DCBX initially. Add IEEE DCBNL ops and functions to get and set the hardware DCBX parameters. The DCB code is conditional on Kconfig CONFIG_BNXT_DCB. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/Kconfig | 10 + drivers/net/ethernet/broadcom/bnxt/Make

[PATCH net-next v2 0/4] bnxt_en: Add DCBNL support.

2016-12-02 Thread Michael Chan
This series adds DCBNL operations to support host-based IEEE DCBX. v2: Updated to the latest firmware interface spec. David, please consider this series for net-next. Michael Chan (4): bnxt_en: Re-factor bnxt_setup_tc(). bnxt_en: Update firmware header file to latest 1.6.0. bnxt_en: Implem

Re: [PATCH net-next 2/4] mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs

2016-12-02 Thread Eric Dumazet
On Fri, 2016-12-02 at 16:53 -0800, Alexei Starovoitov wrote: > On 12/2/16 4:38 PM, Eric Dumazet wrote: > > On Fri, 2016-12-02 at 15:23 -0800, Martin KaFai Lau wrote: > >> When XDP prog is attached, it is currently limiting > >> MTU to be FRAG_SZ0 - ETH_HLEN - (2 * VLAN_HLEN) which is 1514 > >> in x

[PATCH] net: ethernet: ti: cpdma: use desc_read in chan_process instead of raw read

2016-12-02 Thread Ivan Khoronzhuk
There is desc_read() macros to read desc fields, so no need to use __raw_readl(); Signed-off-by: Ivan Khoronzhuk --- Based on net-next/master drivers/net/ethernet/ti/davinci_cpdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/dr

Re: [PATCH net-next] liquidio: 'imply' ptp instead of 'select'

2016-12-02 Thread kbuild test robot
Hi Arnd, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Arnd-Bergmann/liquidio-imply-ptp-instead-of-select/20161203-084019 config: x86_64-allmodconfig compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: make ARCH=x86_64 allmodconfig

[PATCH] net: ping: check minimum size on ICMP header length

2016-12-02 Thread Kees Cook
Prior to commit c0371da6047a ("put iov_iter into msghdr") in v3.19, there was no check that the iovec contained enough bytes for a icmp header, and the read loop would walk across neighboring stack contents. Since the iov_iter conversion, bad arguments are noticed, but the returned error is EFAULT.

Re: [PATCH net-next 2/4] mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs

2016-12-02 Thread Alexei Starovoitov
On 12/2/16 4:38 PM, Eric Dumazet wrote: On Fri, 2016-12-02 at 15:23 -0800, Martin KaFai Lau wrote: When XDP prog is attached, it is currently limiting MTU to be FRAG_SZ0 - ETH_HLEN - (2 * VLAN_HLEN) which is 1514 in x86. AFAICT, since mlx4 is doing one page per packet for XDP, we can at least r

Re: [PATCH net-next 2/4] mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs

2016-12-02 Thread Eric Dumazet
On Fri, 2016-12-02 at 15:23 -0800, Martin KaFai Lau wrote: > When XDP prog is attached, it is currently limiting > MTU to be FRAG_SZ0 - ETH_HLEN - (2 * VLAN_HLEN) which is 1514 > in x86. > > AFAICT, since mlx4 is doing one page per packet for XDP, > we can at least raise the MTU limitation up to >

Re: [PATCH 5/7] Documentation: DT: net: cpsw: allow to specify descriptors pool size

2016-12-02 Thread Ivan Khoronzhuk
On Fri, Dec 02, 2016 at 11:22:28AM -0600, Grygorii Strashko wrote: > > > On 12/02/2016 05:28 AM, Ivan Khoronzhuk wrote: > > On Thu, Dec 01, 2016 at 05:34:30PM -0600, Grygorii Strashko wrote: > >> Add optional property "descs_pool_size" to specify buffer descriptor's > >> pool size. The "descs_poo

Re: [PATCH net] geneve: avoid use-after-free of skb->data

2016-12-02 Thread Sabrina Dubroca
2016-12-02, 14:09:25 -0500, David Miller wrote: > From: Sabrina Dubroca > Date: Fri, 2 Dec 2016 16:49:29 +0100 > > > geneve{,6}_build_skb can end up doing a pskb_expand_head(), which > > makes the ip_hdr(skb) reference we stashed earlier stale. Since it's > > only needed as an argument to ip_tun

Re: [PATCH net-next 1/4] bpf: xdp: Allow head adjustment in XDP prog

2016-12-02 Thread Daniel Borkmann
On 12/03/2016 12:23 AM, Martin KaFai Lau wrote: This patch allows XDP prog to extend/remove the packet data at the head (like adding or removing header). It is done by adding a new XDP helper bpf_xdp_adjust_head(). It also renames bpf_helper_changes_skb_data() to bpf_helper_changes_pkt_data() t

Re: bpf bounded loops. Was: [flamebait] xdp

2016-12-02 Thread Alexei Starovoitov
On Fri, Dec 02, 2016 at 11:42:15AM -0800, John Fastabend wrote: > >> As far as pattern search for DNS packets... > >> it was requested by Cloudflare guys back in March: > >> https://github.com/iovisor/bcc/issues/471 > >> and it is useful for several tracing use cases as well. > >> Unfortunately no

[PATCH net-next 3/4] mlx4: xdp: Reserve headroom for receiving packet when XDP prog is active

2016-12-02 Thread Martin KaFai Lau
Reserve XDP_PACKET_HEADROOM when XDP prog is active. Signed-off-by: Martin KaFai Lau --- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 17 +++-- drivers/net/ethernet/mellanox/mlx4/en_rx.c | 23 +-- drivers/net/ethernet/mellanox/mlx4/en_tx.c | 9 +--

Re: [PATCH net-next 2/4] mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs

2016-12-02 Thread Rick Jones
On 12/02/2016 03:23 PM, Martin KaFai Lau wrote: When XDP prog is attached, it is currently limiting MTU to be FRAG_SZ0 - ETH_HLEN - (2 * VLAN_HLEN) which is 1514 in x86. AFAICT, since mlx4 is doing one page per packet for XDP, we can at least raise the MTU limitation up to PAGE_SIZE - ETH_HLEN -

[PATCH net-next 1/4] bpf: xdp: Allow head adjustment in XDP prog

2016-12-02 Thread Martin KaFai Lau
This patch allows XDP prog to extend/remove the packet data at the head (like adding or removing header). It is done by adding a new XDP helper bpf_xdp_adjust_head(). It also renames bpf_helper_changes_skb_data() to bpf_helper_changes_pkt_data() to better reflect that XDP prog does not work on sk

[PATCH net-next 2/4] mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs

2016-12-02 Thread Martin KaFai Lau
When XDP prog is attached, it is currently limiting MTU to be FRAG_SZ0 - ETH_HLEN - (2 * VLAN_HLEN) which is 1514 in x86. AFAICT, since mlx4 is doing one page per packet for XDP, we can at least raise the MTU limitation up to PAGE_SIZE - ETH_HLEN - (2 * VLAN_HLEN) which this patch is doing. It wi

Re: [PATCH v2 0/7] stmmac: dwmac-meson8b: configurable RGMII TX delay

2016-12-02 Thread Martin Blumenstingl
On Mon, Nov 28, 2016 at 2:33 AM, David Miller wrote: > From: Martin Blumenstingl > Date: Fri, 25 Nov 2016 14:01:49 +0100 > >> Currently the dwmac-meson8b stmmac glue driver uses a hardcoded 1/4 >> cycle TX clock delay. This seems to work fine for many boards (for >> example Odroid-C2 or Amlogic's

[PATCH net-next 4/4] bpf: xdp: Add XDP example for head adjustment

2016-12-02 Thread Martin KaFai Lau
The XDP prog checks if the incoming packet matches any VIP:PORT combination in the BPF hashmap. If it is, it will encapsulate the packet with a IPv4/v6 header as instructed by the value of the BPF hashmap and then XDP_TX it out. The VIP:PORT -> IP-Encap-Info can be specified by the cmd args of th

[PATCH net-next 0/4]: Allow head adjustment in XDP prog

2016-12-02 Thread Martin KaFai Lau
This series adds a helper to allow head adjustment in XDP prog. mlx4 driver has been modified to support this feature. An example is written to encapsulate a packet with an IPv4/v6 header and then XDP_TX it out. Thanks, --Martin

Re: [PATCH net-next] liquidio: 'imply' ptp instead of 'select'

2016-12-02 Thread David Daney
On 12/02/2016 03:04 PM, Arnd Bergmann wrote: ptp now depends on the optional POSIX_TIMERS setting and fails to build if we select it without that: warning: (LIQUIDIO_VF && TI_CPTS) selects PTP_1588_CLOCK which has unmet direct dependencies (NET && POSIX_TIMERS) warning: (LIQUIDIO_VF && TI_CPTS)

Re: bpf bounded loops. Was: [flamebait] xdp

2016-12-02 Thread Alexei Starovoitov
On Fri, Dec 02, 2016 at 08:42:41PM +0100, Hannes Frederic Sowa wrote: > On Fri, Dec 2, 2016, at 20:25, Hannes Frederic Sowa wrote: > > On 02.12.2016 19:39, Alexei Starovoitov wrote: > > > On Thu, Dec 01, 2016 at 10:27:12PM +0100, Hannes Frederic Sowa wrote: > > >> like") and the problematic of pars

[PATCH net-next v3 2/2] net: stmmac: dwmac-meson8b: make the RGMII TX delay configurable

2016-12-02 Thread Martin Blumenstingl
Prior to this patch we were using a hardcoded RGMII TX clock delay of 2ns (= 1/4 cycle of the 125MHz RGMII TX clock). This value works for many boards, but unfortunately not for all (due to the way the actual circuit is designed, sometimes because the TX delay is enabled in the PHY, etc.). Making t

[PATCH net-next v3 1/2] net: dt-bindings: add RGMII TX delay configuration to meson8b-dwmac

2016-12-02 Thread Martin Blumenstingl
This allows configuring the RGMII TX clock delay. The RGMII clock is generated by underlying hardware of the the Meson 8b / GXBB DWMAC glue. The configuration depends on the actual hardware (no delay may be needed due to the design of the actual circuit, the PHY might add this delay, etc.). Signed

[PATCH net-next v3 0/2] stmmac: dwmac-meson8b: configurable RGMII TX delay

2016-12-02 Thread Martin Blumenstingl
Currently the dwmac-meson8b stmmac glue driver uses a hardcoded 1/4 cycle (= 2ns) TX clock delay. This seems to work fine for many boards (for example Odroid-C2 or Amlogic's reference boards) but there are some others where TX traffic is simply broken. There are probably multiple reasons why it's w

Re: [PATCH 2/7] net: ethernet: ti: cpdma: fix desc re-queuing

2016-12-02 Thread Ivan Khoronzhuk
On Fri, Dec 02, 2016 at 10:45:07AM -0600, Grygorii Strashko wrote: > > > On 12/02/2016 05:03 AM, Ivan Khoronzhuk wrote: > > On Thu, Dec 01, 2016 at 05:34:27PM -0600, Grygorii Strashko wrote: > >> The currently processing cpdma descriptor with EOQ flag set may > >> contain two values in Next Descr

Re: [PATCH] iproute2: ss: escape all null bytes in abstract unix domain socket

2016-12-02 Thread Eric Dumazet
On Fri, 2016-12-02 at 15:18 -0800, Stephen Hemminger wrote: > name[i] = '@'; > > > > ss.c: In function 'unix_show_sock': > > ss.c:3128:4: error: 'for' loop initial declarations are only allowed in C99 > > mode > > ss.c:3128:4: note: use option -std=c99 or -std=

Re: [PATCH net-next] liquidio: 'imply' ptp instead of 'select'

2016-12-02 Thread Nicolas Pitre
On Sat, 3 Dec 2016, Arnd Bergmann wrote: > ptp now depends on the optional POSIX_TIMERS setting and fails to build > if we select it without that: > > warning: (LIQUIDIO_VF && TI_CPTS) selects PTP_1588_CLOCK which has unmet > direct dependencies (NET && POSIX_TIMERS) > warning: (LIQUIDIO_VF && T

Re: [PATCH] iproute2: ss: escape all null bytes in abstract unix domain socket

2016-12-02 Thread Stephen Hemminger
On Fri, 02 Dec 2016 10:59:56 -0800 Eric Dumazet wrote: > On Sat, 2016-11-12 at 10:17 +0300, Stephen Hemminger wrote: > > On Sat, 29 Oct 2016 22:20:19 +0300 > > Isaac Boukris wrote: > > > > > Abstract unix domain socket may embed null characters, > > > these should be translated to '@' when pr

Re: iproute2 public git outdated?

2016-12-02 Thread Stephen Hemminger
On Thu, 1 Dec 2016 13:18:06 +0100 Phil Sutter wrote: > Hi, > > I am using iproute2's public git repo at this URL: > > git://git.kernel.org/pub/scm/linux/kernel/git/shemminger/iproute2.git > > To my surprise, neither master nor net-next branches have received new > commits since end of October.

Avoid deadlock situation due to use of xmit_lock

2016-12-02 Thread Lino Sanfilippo
Hi, after stumbling over a potential deadlock situation in the altera driver (see http://marc.info/?l=linux-netdev&m=148054615230447&w=2), I checked all other ethernet drivers for the same issue and actually found it in 2 more, namely stmmac, and sxgbe. Please see the commit messages for a descr

[PATCH 1/2] net: ethernet: sxgbe: do not use xmit_lock in tx completion handler

2016-12-02 Thread Lino Sanfilippo
The driver already uses its private lock for synchronization between the xmit function and the xmit completion handler, making the additional use of the xmit_lock unnecessary. Furthermore the driver does not set NETIF_F_LLTX resulting in xmit to be called with the xmit_lock held and then taking the

[PATCH 2/2] net: ethernet: stmmac: do not use xmit_lock in tx completion handler

2016-12-02 Thread Lino Sanfilippo
The driver already uses its private lock for synchronization between the xmit function and the xmit completion handler, making the additional use of the xmit_lock unnecessary. Furthermore the driver does not set NETIF_F_LLTX resulting in xmit to be called with the xmit_lock held and then taking the

Re: [PATCH/RFC iproute2/net-next 1/3] tc: flower: update headers for TCA_FLOWER_KEY_ICMP*

2016-12-02 Thread Stephen Hemminger
On Fri, 2 Dec 2016 10:59:43 +0100 Simon Horman wrote: > These are proposed changes for net-next. > > Signed-off-by: Simon Horman > --- > include/linux/pkt_cls.h | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/include/linux/pkt_cls.h b/include/linux/pkt_cls.h > index a3d8

Re: [[PATCH iproute2/net-next v2] 2/4] tc: flower: document SCTP ip_proto

2016-12-02 Thread Stephen Hemminger
On Fri, 2 Dec 2016 09:45:19 +0100 Simon Horman wrote: > Add SCTP ip_proto to help text and man page. > > Signed-off-by: Simon Horman This doesn't apply cleanly to current net-next git. Probably some of the other man page changes caused reject.

Re: [[PATCH iproute2/net-next v2] 1/4] tc: flower: remove references to eth_type in manpage

2016-12-02 Thread Stephen Hemminger
On Fri, 2 Dec 2016 09:45:18 +0100 Simon Horman wrote: > Remove references to eth_type and ether_type (spelling error) in > the tc flower manpage. > > Also correct formatting of boldface text with whitespace. > > Cc: Paul Blakey > Signed-off-by: Simon Horman Applied this one. Later ones stil

[PATCH net-next] liquidio: 'imply' ptp instead of 'select'

2016-12-02 Thread Arnd Bergmann
ptp now depends on the optional POSIX_TIMERS setting and fails to build if we select it without that: warning: (LIQUIDIO_VF && TI_CPTS) selects PTP_1588_CLOCK which has unmet direct dependencies (NET && POSIX_TIMERS) warning: (LIQUIDIO_VF && TI_CPTS) selects PTP_1588_CLOCK which has unmet direct

[PATCH net-next] phy: add phy fixup unregister functions

2016-12-02 Thread Woojung.Huh
From: Woojung Huh Add functions to unregister phy fixup for modules. phy_unregister_fixup(const char *bus_id, u32 phy_uid, u32 phy_uid_mask) Unregister phy fixup matches bus_id, phy_uid and phy_uid_mask from phy_fixup_list. Return 0 when find matched one and remove from the list. Return -ENO

Re: [PATCH net-next v2 6/6] tcp: SOF_TIMESTAMPING_OPT_STATS option for SO_TIMESTAMPING

2016-12-02 Thread Yuchung Cheng
On Fri, Dec 2, 2016 at 2:30 PM, Paul Gortmaker wrote: > On Mon, Nov 28, 2016 at 2:07 AM, Yuchung Cheng wrote: >> From: Francis Yan >> >> This patch exports the sender chronograph stats via the socket >> SO_TIMESTAMPING channel. Currently we can instrument how long a >> particular application uni

[PATCH 3/3] uapi: export nf_log.h

2016-12-02 Thread Stephen Hemminger
File is in uapi directory but not being copied on make install_headers Fixes commit 4ec9c8fbbc22 ("netfilter: nft_log: complete NFTA_LOG_FLAGS attr support"). Signed-off-by: Stephen Hemminger --- include/uapi/linux/netfilter/Kbuild | 1 + 1 file changed, 1 insertion(+) diff --git a/include/ua

[PATCH 2/3] uapi: export tc_skbmod.h

2016-12-02 Thread Stephen Hemminger
Fixes commit 735cffe5d800 ("net_sched: Introduce skbmod action") Not used by iproute2 but maybe in future. Signed-off-by: Stephen Hemminger --- include/uapi/linux/tc_act/Kbuild | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/tc_act/Kbuild b/include/uapi/linux/tc_act/Kbuild

[PATCH 1/3] uapi: export tc tunnel key file

2016-12-02 Thread Stephen Hemminger
Fixes commit 21609ae32aaf6c6fab0e ("net/sched: Introduce act_tunnel_key") The file is necessary for iproute2 headers but was not being copied by make install_headers Signed-off-by: Stephen Hemminger --- include/uapi/linux/tc_act/Kbuild | 1 + 1 file changed, 1 insertion(+) diff --git a/include/

[PATCH 0/3] UAPI export missing headers

2016-12-02 Thread Stephen Hemminger
Files not being exported by make install headers Stephen Hemminger (3): tc: export tunnel key file uapi: export tc_skbmod.h uapi: export nf_log.h include/uapi/linux/netfilter/Kbuild | 1 + include/uapi/linux/tc_act/Kbuild| 2 ++ 2 files changed, 3 insertions(+) -- 2.10.2

[PATCH v2 0/3] uapi: add kbuild for some files

2016-12-02 Thread Stephen Hemminger
Some files which are in uapi but not being copied by make headers_install Stephen Hemminger (3): tc: export tunnel key file uapi: export tc_skbmod.h uapi: export nf_log.h include/uapi/linux/netfilter/Kbuild | 1 + include/uapi/linux/tc_act/Kbuild| 2 ++ 2 files changed, 3 insertions(+)

[PATCH 2/3] uapi: export tc_skbmod.h

2016-12-02 Thread Stephen Hemminger
Fixes commit 735cffe5d800 ("net_sched: Introduce skbmod action") Not used by iproute2 but maybe in future. Signed-off-by: Stephen Hemminger --- include/uapi/linux/tc_act/Kbuild | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/tc_act/Kbuild b/include/uapi/linux/tc_act/Kbuild

[PATCH 3/3] uapi: export nf_log.h

2016-12-02 Thread Stephen Hemminger
File is in uapi directory but not being copied on make install_headers Fixes commit 4ec9c8fbbc22 ("netfilter: nft_log: complete NFTA_LOG_FLAGS attr support"). Signed-off-by: Stephen Hemminger --- include/uapi/linux/netfilter/Kbuild | 1 + 1 file changed, 1 insertion(+) diff --git a/include/ua

[PATCH 1/3] uapi: export tc tunnel key file

2016-12-02 Thread Stephen Hemminger
Fixes commit 21609ae32aaf6c6fab0e ("net/sched: Introduce act_tunnel_key") The file is necessary for iproute2 headers but was not being copied by make install_headers Signed-off-by: Stephen Hemminger --- include/uapi/linux/tc_act/Kbuild | 1 + 1 file changed, 1 insertion(+) diff --git a/include/

[PATCH net v3] tcp: warn on bogus MSS and try to amend it

2016-12-02 Thread Marcelo Ricardo Leitner
There have been some reports lately about TCP connection stalls caused by NIC drivers that aren't setting gso_size on aggregated packets on rx path. This causes TCP to assume that the MSS is actually the size of the aggregated packet, which is invalid. Although the proper fix is to be done at each

Re: [PATCH net v2] tcp: warn on bogus MSS and try to amend it

2016-12-02 Thread Marcelo Ricardo Leitner
On Fri, Dec 02, 2016 at 06:45:24AM -0800, Eric Dumazet wrote: > On Fri, 2016-12-02 at 08:55 -0200, Marcelo Ricardo Leitner wrote: > > There have been some reports lately about TCP connection stalls caused > > by NIC drivers that aren't setting gso_size on aggregated packets on rx > > path. This cau

Re: [PATCH net-next v2 6/6] tcp: SOF_TIMESTAMPING_OPT_STATS option for SO_TIMESTAMPING

2016-12-02 Thread Paul Gortmaker
On Mon, Nov 28, 2016 at 2:07 AM, Yuchung Cheng wrote: > From: Francis Yan > > This patch exports the sender chronograph stats via the socket > SO_TIMESTAMPING channel. Currently we can instrument how long a > particular application unit of data was queued in TCP by tracking > SOF_TIMESTAMPING_TX_

Re: [PATCH iproute2/net-next] ss: initialise variables outside of for loop

2016-12-02 Thread Stephen Hemminger
On Fri, 2 Dec 2016 12:56:05 +0100 Simon Horman wrote: > Initialise for loops outside of for loops. GCC flags this as being > out of spec unless C99 or C11 mode is used. > > With this change the entire tree appears to compile cleanly with -Wall. > > $ gcc --version > gcc (Debian 4.9.2-10) 4.9.2

Re: [PATCH iproute2 V5 0/3] tc: Support for ip tunnel metadata set/unset/classify

2016-12-02 Thread Stephen Hemminger
On Fri, 2 Dec 2016 13:25:12 +0200 Amir Vadai wrote: > Hi, > > This short series adds support for matching and setting metadata for ip tunnel > shared device using the TC system, introduced in kernel 4.9 [1]. > > Applied and tested on top of commit b6c7fc61faab ("ss: print new tcp_info > fields

Re: [PATCH net-next 3/4] tcp: tsq: add shortcut in tcp_tasklet_func()

2016-12-02 Thread Eric Dumazet
On Fri, 2016-12-02 at 10:25 -0800, Eric Dumazet wrote: > Under high stress, I've seen tcp_tasklet_func() consuming > ~700 usec, handling ~150 tcp sockets. > > By setting TCP_TSQ_DEFERRED in tcp_wfree(), we give a chance > for other cpus/threads entering tcp_write_xmit() to grab it, > allowing tcp_

Re: [iproute PATCH v2 00/18] ss: Minor code review

2016-12-02 Thread Stephen Hemminger
On Fri, 2 Dec 2016 11:39:44 +0100 Phil Sutter wrote: > This is a series of misc changes to ss code which happened as fall-out > when working on a unified output formatter (still unfinished). > > Changes since v1: > - Rebased onto current upstream, resolved conflicts in patch 4 generated > by

Re: [PATCH iproute2 1/1] tc: updated man page to reflect handle-id use in filter GET command.

2016-12-02 Thread Stephen Hemminger
On Thu, 1 Dec 2016 15:20:44 -0500 Roman Mashak wrote: > Signed-off-by: Roman Mashak > --- > man/man8/tc.8 | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/man/man8/tc.8 b/man/man8/tc.8 > index 8a47a2b..d957ffa 100644 > --- a/man/man8/tc.8 > +++ b/man/man8/tc.8 >

Re: [PATCHv2 net-next 4/4] net: dsa: mv88e6xxx: Refactor CPU and DSA port setup

2016-12-02 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: >> The port's EgressMode, FrameMode and EtherType are really tied together >> to compose the mode of the port. > > Setting the EtherType is somewhat separate. It is only needed on ports > using EDSA. And that can only happen on a CPU port. Humm, actually, i > set i

[PATCH net-next] tools: hv: Enable network manager for bonding scripts on RHEL

2016-12-02 Thread Haiyang Zhang
From: Haiyang Zhang We found network manager is necessary on RHEL to make the synthetic NIC, VF NIC bonding operations handled automatically. So, enabling network manager here. Signed-off-by: Haiyang Zhang Reviewed-by: K. Y. Srinivasan --- tools/hv/bondvf.sh |4 ++-- 1 files changed, 2 in

[PATCH net-next v5] ipv6 addrconf: Implemented enhanced DAD (RFC7527)

2016-12-02 Thread Erik Nordmark
Implemented RFC7527 Enhanced DAD. IPv6 duplicate address detection can fail if there is some temporary loopback of Ethernet frames. RFC7527 solves this by including a random nonce in the NS messages used for DAD, and if an NS is received with the same nonce it is assumed to be a looped back DAD pro

Re: [PATCHv2 net-next 2/4] net: dsa: mv88e6xxx: Monitor and Management tables

2016-12-02 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > On Fri, Dec 02, 2016 at 02:32:39PM -0500, Vivien Didelot wrote: >> Hi Andrew, >> >> Andrew Lunn writes: >> >> > @@ -3184,6 +3186,8 @@ static const struct mv88e6xxx_ops mv88e6085_ops = { >> >.stats_get_sset_count = mv88e6095_stats_get_sset_count, >> >.s

[PATCH] adm80211: add checks for dma mapping errors

2016-12-02 Thread Alexey Khoroshilov
The driver does not check if mapping dma memory succeed. The patch adds the checks and failure handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/wireless/admtek/adm8211.c | 24 ++-- 1 file changed, 22 i

Re: [PATCH next] dctcp: update cwnd on congestion event

2016-12-02 Thread Florian Westphal
Neal Cardwell wrote: > On Mon, Nov 14, 2016 at 10:42 AM, Florian Westphal wrote: > > > > draft-ietf-tcpm-dctcp-02 says: > > > > ... when the sender receives an indication of congestion > > (ECE), the sender SHOULD update cwnd as follows: > > > > cwnd = cwnd * (1 - DCTCP.Alpha / 2) > > >

Re: [PATCHv2 net-next 2/4] net: dsa: mv88e6xxx: Monitor and Management tables

2016-12-02 Thread Andrew Lunn
On Fri, Dec 02, 2016 at 02:32:39PM -0500, Vivien Didelot wrote: > Hi Andrew, > > Andrew Lunn writes: > > > @@ -3184,6 +3186,8 @@ static const struct mv88e6xxx_ops mv88e6085_ops = { > > .stats_get_sset_count = mv88e6095_stats_get_sset_count, > > .stats_get_strings = mv88e6095_stats_get_st

Re: [PATCHv2 net-next 4/4] net: dsa: mv88e6xxx: Refactor CPU and DSA port setup

2016-12-02 Thread Andrew Lunn
> The port's EgressMode, FrameMode and EtherType are really tied together > to compose the mode of the port. Setting the EtherType is somewhat separate. It is only needed on ports using EDSA. And that can only happen on a CPU port. Humm, actually, i set it when i should not. But putting this in a

Re: [PATCHv2 net-next 4/4] net: dsa: mv88e6xxx: Refactor CPU and DSA port setup

2016-12-02 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > +static int mv88e6xxx_setup_port_dsa(struct mv88e6xxx_chip *chip, int port, > + int upstream_port) > +{ > + int err; > + > + err = chip->info->ops->port_set_frame_mode( > + chip, port, MV88E6XXX_FRAME_MODE_DSA);

Re: [PATCH net-next 0/4] tcp: tsq: performance series

2016-12-02 Thread Eric Dumazet
On Fri, Dec 2, 2016 at 10:25 AM, Eric Dumazet wrote: > Under very high TX stress, CPU handling NIC TX completions can spend > considerable amount of cycles handling TSQ (TCP Small Queues) logic. > > This patch series avoids some atomic operations, but more important > patch is the 3rd one, allowin

Re: [PATCH next] dctcp: update cwnd on congestion event

2016-12-02 Thread Neal Cardwell
On Mon, Nov 14, 2016 at 10:42 AM, Florian Westphal wrote: > > draft-ietf-tcpm-dctcp-02 says: > > ... when the sender receives an indication of congestion > (ECE), the sender SHOULD update cwnd as follows: > > cwnd = cwnd * (1 - DCTCP.Alpha / 2) > > So, lets do this and reduce cwnd more sm

Re: [PATCHv2 net-next 3/4] net: dsa: mv88e6xxx: Move the tagging protocol into info

2016-12-02 Thread Andrew Lunn
On Fri, Dec 02, 2016 at 02:41:08PM -0500, Vivien Didelot wrote: > Hi Andrew, > > Andrew Lunn writes: > > > @@ -3749,6 +3756,7 @@ static const struct mv88e6xxx_info mv88e6xxx_table[] > > = { > > .global1_addr = 0x1b, > > .age_time_coeff = 15000, > > .g1_irqs =

[net-next PATCH v4 6/6] virtio_net: xdp, add slowpath case for non contiguous buffers

2016-12-02 Thread John Fastabend
virtio_net XDP support expects receive buffers to be contiguous. If this is not the case we enable a slowpath to allow connectivity to continue but at a significan performance overhead associated with linearizing data. To make it painfully aware to users that XDP is running in a degraded mode we th

[net-next PATCH v4 5/6] virtio_net: add XDP_TX support

2016-12-02 Thread John Fastabend
This adds support for the XDP_TX action to virtio_net. When an XDP program is run and returns the XDP_TX action the virtio_net XDP implementation will transmit the packet on a TX queue that aligns with the current CPU that the XDP packet was processed on. Before sending the packet the header is ze

[net-next PATCH v4 4/6] virtio_net: add dedicated XDP transmit queues

2016-12-02 Thread John Fastabend
XDP requires using isolated transmit queues to avoid interference with normal networking stack (BQL, NETDEV_TX_BUSY, etc). This patch adds a XDP queue per cpu when a XDP program is loaded and does not expose the queues to the OS via the normal API call to netif_set_real_num_tx_queues(). This way th

[net-next PATCH v4 3/6] virtio_net: Add XDP support

2016-12-02 Thread John Fastabend
From: John Fastabend This adds XDP support to virtio_net. Some requirements must be met for XDP to be enabled depending on the mode. First it will only be supported with LRO disabled so that data is not pushed across multiple buffers. Second the MTU must be less than a page size to avoid having t

[net-next PATCH v4 2/6] net: xdp: add invalid buffer warning

2016-12-02 Thread John Fastabend
This adds a warning for drivers to use when encountering an invalid buffer for XDP. For normal cases this should not happen but to catch this in virtual/qemu setups that I may not have expected from the emulation layer having a standard warning is useful. Signed-off-by: John Fastabend --- includ

[net-next PATCH v4 1/6] net: virtio dynamically disable/enable LRO

2016-12-02 Thread John Fastabend
This adds support for dynamically setting the LRO feature flag. The message to control guest features in the backend uses the CTRL_GUEST_OFFLOADS msg type. Signed-off-by: John Fastabend --- drivers/net/virtio_net.c | 45 - 1 file changed, 44 insertio

[net-next PATCH v4 0/6] XDP for virtio_net

2016-12-02 Thread John Fastabend
This implements virtio_net for the mergeable buffers and big_packet modes. I tested this with vhost_net running on qemu and did not see any issues. For testing num_buf > 1 I added a hack to vhost driver to only use 100 bytes per buffer so that packets were pushed across multiple buffers. There are

Re: [PATCH] net: wireless: realtek: constify rate_control_ops structures

2016-12-02 Thread Larry Finger
On 12/02/2016 03:50 AM, Bhumika Goyal wrote: The structures rate_control_ops are only passed as an argument to the functions ieee80211_rate_control_{register/unregister}. This argument is of type const, so rate_control_ops having this property can also be declared as const. Done using Coccinelle:

[PATCH v3 05/13] net: ethernet: ti: cpts: fix registration order

2016-12-02 Thread Grygorii Strashko
The ptp clock registered before spinlock, which is protecting it, and before timecounter and cyclecounter initialization in cpts_register(). So, ensure that ptp clock is registered the last, after everything else is done. Acked-by: Richard Cochran Signed-off-by: Grygorii Strashko --- drivers/n

[PATCH v3 08/13] net: ethernet: ti: cpts: drop excessive writes to CTRL and INT_EN regs

2016-12-02 Thread Grygorii Strashko
CPTS module and IRQs are always enabled when CPTS is registered, before starting overflow check work, and disabled during deregistration, when overflow check work has been canceled already. So, It doesn't require to (re)enable CPTS module and IRQs in cpts_overflow_check(). Acked-by: Richard Cochra

[PATCH v3 01/13] net: ethernet: ti: cpts: switch to readl/writel_relaxed()

2016-12-02 Thread Grygorii Strashko
Switch to readl/writel_relaxed() APIs, because this is recommended API and the CPTS IP is reused on Keystone 2 SoCs where LE/BE modes are supported. Acked-by: Richard Cochran Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpts.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletio

[PATCH v3 09/13] net: ethernet: ti: cpts: rework initialization/deinitialization

2016-12-02 Thread Grygorii Strashko
The current implementation CPTS initialization and deinitialization (represented by cpts_register/unregister()) does too many static initialization from .ndo_open(), which is reasonable to do once at probe time instead, and also require caller to allocate memory for struct cpts, which is internal f

Re: [PATCH net-next 2/2] net/sched: cls_flower: Support matching on ICMP type and code

2016-12-02 Thread Simon Horman
Hi Jiri, On Fri, Dec 02, 2016 at 08:17:13PM +0100, Simon Horman wrote: > On Fri, Dec 02, 2016 at 07:38:48PM +0100, Jiri Pirko wrote: > > Fri, Dec 02, 2016 at 07:05:51PM CET, simon.hor...@netronome.com wrote: > > >Support matching on ICMP type and code. ... > > This hunk looks like it should be s

[PATCH v3 12/13] net: ethernet: ti: cpts: calc mult and shift from refclk freq

2016-12-02 Thread Grygorii Strashko
The cyclecounter mult and shift values can be calculated based on the CPTS rfclk frequency and timekeepnig framework provides required algos and API's. Hence, calc mult and shift basing on CPTS rfclk frequency if both cpts_clock_shift and cpts_clock_mult properties are not provided in DT (the basi

  1   2   3   4   >