Hi Jiri, On Fri, Dec 02, 2016 at 08:17:13PM +0100, Simon Horman wrote: > On Fri, Dec 02, 2016 at 07:38:48PM +0100, Jiri Pirko wrote: > > Fri, Dec 02, 2016 at 07:05:51PM CET, simon.hor...@netronome.com wrote: > > >Support matching on ICMP type and code.
... > > This hunk looks like it should be squashed to the previous patch. > > I included it in this patch as it is where these helpers are used > for the first time. I can shuffle it into the first patch if you prefer; > I agree it does make sense to put all the dissector changes there. I moved things around as you suggested and posted v2.
