On Mon, Nov 14, 2016 at 10:42 AM, Florian Westphal <f...@strlen.de> wrote: > > draft-ietf-tcpm-dctcp-02 says: > > ... when the sender receives an indication of congestion > (ECE), the sender SHOULD update cwnd as follows: > > cwnd = cwnd * (1 - DCTCP.Alpha / 2) > > So, lets do this and reduce cwnd more smoothly (and faster), as per > current congestion estimate.
AFAICT this is doing a multiplicative decrease of cwnd on every ACK that has an ECE bit. If I am reading the code correctly, then I would have two concerns: 1) Has that been tested? That seems like an extremely dramatic decrease in cwnd. For example, if the cwnd is 80, and there are 40 ACKs, and half the ACKs are ECE marked, then my back-of-the-envelope calculations seem to suggest that after just 11 ACKs the cwnd would be down to a minimal value of 2: ack 1 cwnd=60 ack 2 cwnd=45 ack 3 cwnd=33 ack 4 cwnd=24 ack 5 cwnd=18 ack 6 cwnd=13 ack 7 cwnd=9 ack 8 cwnd=6 ack 9 cwnd=4 ack 10 cwnd=3 ack 11 cwnd=2 2) That seems to contradict another passage in the draft (v 02 or 03). Consider https://tools.ietf.org/html/draft-ietf-tcpm-dctcp-03 where it says Just as specified in [RFC3168], DCTCP does not react to congestion indications more than once for every window of data. So the draft seems to advocate not reacting to congestion indications more than once per window. Yet this patch reacts on every ECE-marked ACK within a window. Am I reading something incorrectly? cheers, neal