Re: [PATCH v8 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

2016-09-29 Thread David Miller
From: Greg KH Date: Fri, 30 Sep 2016 08:30:05 +0200 > On Fri, Sep 30, 2016 at 01:55:55AM -0400, David Miller wrote: >> From: Amir Levy >> Date: Wed, 28 Sep 2016 17:44:22 +0300 >> >> > This driver enables Thunderbolt Networking on non-Apple platforms >> > running Linux. >> >> Greg, any idea whe

Re: [net-next PATCH] i40e: Clean up handling of msg_enable flags and debug parameter

2016-09-29 Thread Stefan Assmann
On 29.09.2016 14:05, Alexander Duyck wrote: > So the i40e driver had a really convoluted configuration for how to handle > the debug flags contained in msg_enable. Part of the issue is that the > driver has its own 32 bit mask that it was using to track a separate set of > debug features. From wh

Re: [PATCH v8 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

2016-09-29 Thread Greg KH
On Fri, Sep 30, 2016 at 01:55:55AM -0400, David Miller wrote: > From: Amir Levy > Date: Wed, 28 Sep 2016 17:44:22 +0300 > > > This driver enables Thunderbolt Networking on non-Apple platforms > > running Linux. > > Greg, any idea where this should get merged once fully vetted? I can > take it t

Loan

2016-09-29 Thread Sarah Collins
Do You Need A Loan Of Any Kind ? If Yes Email Now For More Info on internationalloanp...@gmail.com

Re: [PATCH v6 0/7] Reduce cache miss for snmp_fold_field

2016-09-29 Thread David Miller
From: Jia He Date: Fri, 30 Sep 2016 11:28:57 +0800 > In a PowerPc server with large cpu number(160), besides commit > a3a773726c9f ("net: Optimize snmp stat aggregation by walking all > the percpu data at once"), I watched several other snmp_fold_field > callsites which would cause high cache mis

Re: [PATCH v2 net-next] mlx5: Add ndo_poll_controller() implementation

2016-09-29 Thread David Miller
From: Calvin Owens Date: Wed, 28 Sep 2016 21:46:39 -0700 > This implements ndo_poll_controller in net_device_ops callbacks for mlx5, > which is necessary to use netconsole with this driver. > > Acked-By: Saeed Mahameed > Signed-off-by: Calvin Owens > --- > Changes in v2: > * Only iterate

Re: [PATCH net-next] nfp: bpf: zero extend 4 byte context loads

2016-09-29 Thread David Miller
From: Jakub Kicinski Date: Wed, 28 Sep 2016 23:47:37 +0100 > Set upper 32 bits of destination register to zeros after > load from the context structure. > > Signed-off-by: Jakub Kicinski Applied, thanks.

Re: [PATCH net] sctp: fix the issue sctp_diag uses lock_sock in rcu_read_lock

2016-09-29 Thread David Miller
From: Xin Long Date: Thu, 29 Sep 2016 02:55:44 +0800 > When sctp dumps all the ep->assocs, it needs to lock_sock first, > but now it locks sock in rcu_read_lock, and lock_sock may sleep, > which would break rcu_read_lock. > > This patch is to get and hold one sock when traversing the list. > Aft

Re: [PATCHv3 net 0/3] sctp: a bunch of fixes for prsctp polices

2016-09-29 Thread David Miller
From: Xin Long Date: Thu, 29 Sep 2016 02:37:25 +0800 > This patchset is to fix 2 issues for prsctp polices: > > 1. patch 1 and 2 fix "netperf-Throughput_Mbps -37.2% regression" issue > when overloading the CPU. > > 2. patch 3 fix "prsctp polices should check both sides' prsctp_capable,

Re: [PATCH v1] mlx4: remove unused fields

2016-09-29 Thread David Miller
From: David Decotigny Date: Wed, 28 Sep 2016 11:00:04 -0700 > From: David Decotigny > > This also can address following UBSAN warnings: > [ 36.640343] > > [ 36.648772] UBSAN: Undefined behaviour in > drivers/

Re: [PATCH v8 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

2016-09-29 Thread David Miller
From: Amir Levy Date: Wed, 28 Sep 2016 17:44:22 +0300 > This driver enables Thunderbolt Networking on non-Apple platforms > running Linux. Greg, any idea where this should get merged once fully vetted? I can take it through the net-next tree, but I'm fine with another more appropriate tree taki

Re: [PATCH] ipv6 addrconf: implement RFC7559 router solicitation backoff

2016-09-29 Thread David Miller
From: Maciej Żenczykowski Date: Tue, 27 Sep 2016 23:57:58 -0700 > From: Maciej Żenczykowski > > This implements: > https://tools.ietf.org/html/rfc7559 > > Backoff is performed according to RFC3315 section 14: > https://tools.ietf.org/html/rfc3315#section-14 > > We allow setting /proc/sys/

Re: [PATCH net-next 0/6] rxrpc: Fixes and adjustments

2016-09-29 Thread David Miller
husly: > > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > rxrpc-rewrite-20160929 Pulled, thanks David.

Re: [PATCH V2 for-next 0/8] Bug Fixes and Code Improvement in HNS driver

2016-09-29 Thread David Miller
From: Salil Mehta Date: Thu, 29 Sep 2016 18:09:08 +0100 > This patch-set introduces fix to some Bugs, potential problems > and code improvements identified during internal review and > testing of Hisilicon Network Subsystem driver. > > Submit Change > V1->V2: This addresses the feedbacks provide

Re: pull-request: wireless-drivers-next 2016-09-29

2016-09-29 Thread David Miller
From: Kalle Valo Date: Thu, 29 Sep 2016 19:57:28 +0300 > this should be the last wireless-drivers-next pull request for 4.9, from > now on only important bugfixes. Nothing really special stands out, > iwlwifi being most active but other drivers also getting attention. More > details in the signed

Re: [PATCH net v2] tg3: Avoid NULL pointer dereference in tg3_io_error_detected()

2016-09-29 Thread David Miller
From: "Guilherme G. Piccoli" Date: Thu, 29 Sep 2016 13:24:08 -0300 > From: Milton Miller > > While the driver is probing the adapter, an error may occur before the > netdev structure is allocated and attached to pci_dev. In this case, > not only netdev isn't available, but the tg3 private struc

Re: [PATCH net-next 00/10] net: dsa: mv88e6xxx: Global (1) cosmetics

2016-09-29 Thread David Miller
From: Vivien Didelot Date: Thu, 29 Sep 2016 12:21:52 -0400 > The Global (1) internal SMI device of Marvell switches is a set of > registers providing support to different units for MAC addresses (ATU), > VLANs (VTU), PHY polling (PPU), etc. ... Looks like a very nice set of cleanups to me. Ser

Re: [PATCH RFC net-next] bnx2x: avoid printing unnecessary messages during register dump

2016-09-29 Thread David Miller
From: "Guilherme G. Piccoli" Date: Thu, 29 Sep 2016 13:19:39 -0300 > David, thanks for your comment. I confess I didn't understand your > statement quite well. You say we shouldn't dump registers that will > cause timeouts, that's it? Yes, basically. If this happened infrequently for one or two

Re: [PATCH v2 3/3] net: make net namespace sysctls belong to container's owner

2016-09-29 Thread David Miller
From: Dmitry Torokhov Date: Thu, 29 Sep 2016 08:46:05 -0700 > Hi David, > > On Wed, Aug 10, 2016 at 2:36 PM, Dmitry Torokhov > wrote: >> If net namespace is attached to a user namespace let's make container's >> root owner of sysctls affecting said network namespace instead of global >> root. >

[PATCH v6 7/7] net: Suppress the "Comparison to NULL could be written" warnings

2016-09-29 Thread Jia He
This is to suppress the checkpatch.pl warning "Comparison to NULL could be written". No functional changes here. Signed-off-by: Jia He --- net/ipv4/proc.c | 32 net/sctp/proc.c | 2 +- 2 files changed, 17 insertions(+), 17 deletions(-) diff --git a/net/ipv4/pro

[PATCH v6 4/7] proc: Reduce cache miss in sctp_snmp_seq_show

2016-09-29 Thread Jia He
This is to use the generic interfaces snmp_get_cpu_field{,64}_batch to aggregate the data by going through all the items of each cpu sequentially. Signed-off-by: Jia He --- net/sctp/proc.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/net/sctp/proc.c b/net/sctp/proc

[PATCH v6 1/7] net:snmp: Introduce generic interfaces for snmp_get_cpu_field{,64}

2016-09-29 Thread Jia He
This is to introduce the generic interfaces for snmp_get_cpu_field{,64}. It exchanges the two for-loops for collecting the percpu statistics data. This can aggregate the data by going through all the items of each cpu sequentially. Signed-off-by: Jia He Suggested-by: Marcelo Ricardo Leitner ---

[PATCH v6 5/7] proc: Reduce cache miss in xfrm_statistics_seq_show

2016-09-29 Thread Jia He
This is to use the generic interfaces snmp_get_cpu_field{,64}_batch to aggregate the data by going through all the items of each cpu sequentially. Signed-off-by: Jia He --- net/xfrm/xfrm_proc.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/net/xfrm/xfrm_proc.c b/

[PATCH v6 2/7] proc: Reduce cache miss in snmp_seq_show

2016-09-29 Thread Jia He
This is to use the generic interfaces snmp_get_cpu_field{,64}_batch to aggregate the data by going through all the items of each cpu sequentially. Then snmp_seq_show is split into 2 parts to avoid build warning "the frame size" larger than 1024. Signed-off-by: Jia He --- net/ipv4/proc.c | 70 +++

[PATCH v6 3/7] proc: Reduce cache miss in snmp6_seq_show

2016-09-29 Thread Jia He
This is to use the generic interfaces snmp_get_cpu_field{,64}_batch to aggregate the data by going through all the items of each cpu sequentially. Signed-off-by: Jia He --- net/ipv6/proc.c | 30 ++ 1 file changed, 22 insertions(+), 8 deletions(-) diff --git a/net/ipv

[PATCH v6 6/7] ipv6: Remove useless parameter in __snmp6_fill_statsdev

2016-09-29 Thread Jia He
The parameter items(is always ICMP6_MIB_MAX) is useless for __snmp6_fill_statsdev Signed-off-by: Jia He --- net/ipv6/addrconf.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 2f1f5d4..35d4baa 100644 --- a/net/ipv6

[PATCH v6 0/7] Reduce cache miss for snmp_fold_field

2016-09-29 Thread Jia He
In a PowerPc server with large cpu number(160), besides commit a3a773726c9f ("net: Optimize snmp stat aggregation by walking all the percpu data at once"), I watched several other snmp_fold_field callsites which would cause high cache miss rate. test source code: My simple test ca

Re: [PATCH net v2] L2TP:Adjust intf MTU,factor underlay L3,overlay L2

2016-09-29 Thread R. Parameswaran
Hi James, On Thu, 29 Sep 2016, James Chapman wrote: > On 22/09/16 21:52, R. Parameswaran wrote: > > From ed585bdd6d3d2b3dec58d414f514cd764d89159d Mon Sep 17 00:00:00 2001 > > From: "R. Parameswaran" > > Date: Thu, 22 Sep 2016 13:19:25 -0700 > > Subject: [PATCH] L2TP:Adjust intf MTU,factor under

Re: [PATCH net-next v3] netfilter: xt_hashlimit: Fix link error in 32bit arch because of 64bit division

2016-09-29 Thread Maciej Żenczykowski
> + return div64_u64((user * HZ * CREDITS_PER_JIFFY_v1), > +XT_HASHLIMIT_SCALE); spurious () > + return div64_u64((user * HZ * CREDITS_PER_JIFFY), > +XT_HASHLIMIT_SCALE_v2); spurious () but: Acked-by: M

Re: How to submit potential patch in linux kernel

2016-09-29 Thread Shyam Saini
On Thu, 2016-09-29 at 13:15 +0300, Daniel Baluta wrote: > Hi Shyam, > > On Thu, Sep 29, 2016 at 1:02 PM, Andrew Lunn wrote: > > > > On Thu, Sep 29, 2016 at 04:32:29AM +0530, Shyam Saini wrote: > > > > > > Hi everyone, > > > > > > I'm Shyam, final year undergraduate student. I wanted to know ho

Re: UDP wierdness around skb_copy_and_csum_datagram_msg()

2016-09-29 Thread Eric Dumazet
On Fri, 2016-09-30 at 01:28 +0200, Christian Lamparter wrote: > On Wednesday, September 28, 2016 7:20:39 PM CEST Jay Smith wrote: > > Actually, on a little more searching of this list's archives, I think > > that this discussion: https://patchwork.kernel.org/patch/9260733/ is > > about exactly the

Re: UDP wierdness around skb_copy_and_csum_datagram_msg()

2016-09-29 Thread Christian Lamparter
On Wednesday, September 28, 2016 7:20:39 PM CEST Jay Smith wrote: > Actually, on a little more searching of this list's archives, I think > that this discussion: https://patchwork.kernel.org/patch/9260733/ is > about exactly the same issue I've found, except from the TCP side. I'm > cc'ing a few o

Re: [PATCH net-next 2/2] openvswitch: remove skb_mpls_header

2016-09-29 Thread pravin shelar
On Thu, Sep 29, 2016 at 12:19 PM, Jiri Benc wrote: > skb_mpls_header is equivalent to skb_network_header now. There's no reason > to keep it. > > Signed-off-by: Jiri Benc > --- > include/net/mpls.h| 11 --- > net/openvswitch/actions.c | 10 +- > 2 files changed, 5 inserti

Re: [PATCH net-next 1/2] openvswitch: mpls: set network header correctly on key extract

2016-09-29 Thread pravin shelar
On Thu, Sep 29, 2016 at 12:19 PM, Jiri Benc wrote: > After the 48d2ab609b6b ("net: mpls: Fixups for GSO"), MPLS handling in > openvswitch was changed to have network header pointing to the start of the > MPLS headers and inner_network_header pointing after the MPLS headers. > > However, key_extrac

Re: next-20160929 build: 2 failures 4 warnings (next-20160929)

2016-09-29 Thread Arnd Bergmann
On Thursday 29 September 2016, Vishwanath Pai wrote: > I have sent a patch for this a couple of days ago to netdev, it hasn't > made it to net-next yet. Here's the latest one: > > [PATCH net-next v3] netfilter: xt_hashlimit: Fix link error in 32bit > arch because of 64bit division > > This should

[PATCH net-next 1/6] rxrpc: Fix exclusive client connections

2016-09-29 Thread David Howells
Exclusive connections are currently reusable (which they shouldn't be) because rxrpc_alloc_client_connection() checks the exclusive flag in the rxrpc_connection struct before it's initialised from the function parameters. This means that the DONT_REUSE flag doesn't get set. Fix this by checking t

[PATCH net-next 2/6] rxrpc: Make Tx loss-injection go through normal return and adjust tracing

2016-09-29 Thread David Howells
In rxrpc_send_data_packet() make the loss-injection path return through the same code as the transmission path so that the RTT determination is initiated and any future timer shuffling will be done, despite the packet having been binned. Whilst we're at it: (1) Add to the tx_data tracepoint an i

[PATCH net-next 3/6] rxrpc: When activating client conn channels, do state check inside lock

2016-09-29 Thread David Howells
In rxrpc_activate_channels(), the connection cache state is checked outside of the lock, which means it can change whilst we're waking calls up, thereby changing whether or not we're allowed to wake calls up. Fix this by moving the check inside the locked region. The check to see if all the chann

[PATCH net-next 6/6] rxrpc: Note serial number being ACK'd in the congestion management trace

2016-09-29 Thread David Howells
Note the serial number of the packet being ACK'd in the congestion management trace rather than the serial number of the ACK packet. Whilst the serial number of the ACK packet is useful for matching ACK packet in the output of wireshark, the serial number that the ACK is in response to is of more

[PATCH net-next 5/6] rxrpc: Request more ACKs in slow-start mode

2016-09-29 Thread David Howells
Set the request-ACK on more DATA packets whilst we're in slow start mode so that we get sufficient ACKs back to supply information to configure the window. Signed-off-by: David Howells --- net/rxrpc/output.c |1 + 1 file changed, 1 insertion(+) diff --git a/net/rxrpc/output.c b/net/rxrpc/o

[PATCH net-next 4/6] rxrpc: Reduce the rxrpc_local::services list to a pointer

2016-09-29 Thread David Howells
Reduce the rxrpc_local::services list to just a pointer as we don't permit multiple service endpoints to bind to a single transport endpoints (this is excluded by rxrpc_lookup_local()). The reason we don't allow this is that if you send a request to an AFS filesystem service, it will try to talk b

[PATCH net-next 0/6] rxrpc: Fixes and adjustments

2016-09-29 Thread David Howells
http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rewrite Tagged thusly: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-rewrite-20160929 David --- David Howells (6): rxrpc: Fix exclusive client connections

Re: [PATCH] brcmfmac: implement more accurate skb tracking

2016-09-29 Thread Rafał Miłecki
On 27 September 2016 at 11:24, Arend Van Spriel wrote: > On 26-9-2016 14:38, Rafał Miłecki wrote: >> On 26 September 2016 at 14:13, Rafał Miłecki wrote: >>> On 26 September 2016 at 13:46, Arend Van Spriel >>> wrote: On 26-9-2016 12:23, Rafał Miłecki wrote: > From: Rafał Miłecki > >

Re: [PATCH v2 net-next 4/5] xps_flows: XPS for packets that don't have a socket

2016-09-29 Thread Tom Herbert
On Thu, Sep 29, 2016 at 11:15 AM, Eric Dumazet wrote: > On Thu, 2016-09-29 at 07:51 -0700, Eric Dumazet wrote: >> On Thu, 2016-09-29 at 10:08 -0400, Tom Herbert wrote: >> >> > It addresses the issue that Rick Jones pointed out was happening with >> > XPS. When packets are sent for a flow that has

[PATCH net-next 2/2] openvswitch: remove skb_mpls_header

2016-09-29 Thread Jiri Benc
skb_mpls_header is equivalent to skb_network_header now. There's no reason to keep it. Signed-off-by: Jiri Benc --- include/net/mpls.h| 11 --- net/openvswitch/actions.c | 10 +- 2 files changed, 5 insertions(+), 16 deletions(-) diff --git a/include/net/mpls.h b/include/

[PATCH net-next 1/2] openvswitch: mpls: set network header correctly on key extract

2016-09-29 Thread Jiri Benc
After the 48d2ab609b6b ("net: mpls: Fixups for GSO"), MPLS handling in openvswitch was changed to have network header pointing to the start of the MPLS headers and inner_network_header pointing after the MPLS headers. However, key_extract was missed by the mentioned commit, causing incorrect heade

[PATCH net-next 0/2] openvswitch: mpls fix and clean up

2016-09-29 Thread Jiri Benc
Convert to the new mpls skb layout the last remaining place in openvswitch, forgotten on the mpls GSO rework. The GSO rework also allows for some nice cleanup in the second patch. Jiri Benc (2): openvswitch: mpls: set network header correctly on key extract openvswitch: remove skb_mpls_header

Re: next-20160929 build: 2 failures 4 warnings (next-20160929)

2016-09-29 Thread Vishwanath Pai
On 09/29/2016 02:47 PM, Mark Brown wrote: > On Thu, Sep 29, 2016 at 12:40:35PM +0100, Build bot for Mark Brown wrote: > > For the past couple of days -next has been failing to build an ARM > allmodconfig due to: > >> arm-allmodconfig >> ERROR: "__aeabi_uldivmod" [net/netfilter/xt_hashlimit.k

Re: next-20160929 build: 2 failures 4 warnings (next-20160929)

2016-09-29 Thread Mark Brown
On Thu, Sep 29, 2016 at 12:40:35PM +0100, Build bot for Mark Brown wrote: For the past couple of days -next has been failing to build an ARM allmodconfig due to: > arm-allmodconfig > ERROR: "__aeabi_uldivmod" [net/netfilter/xt_hashlimit.ko] undefined! which appears to be triggered by 11d5f

Re: pull-request: wireless-drivers-next 2016-09-29

2016-09-29 Thread Pablo Neira Ayuso
On Thu, Sep 29, 2016 at 07:57:28PM +0300, Kalle Valo wrote: > Hi Dave, > > this should be the last wireless-drivers-next pull request for 4.9, from > now on only important bugfixes. Nothing really special stands out, > iwlwifi being most active but other drivers also getting attention. More > deta

[net-next PATCH] i40e: Clean up handling of msg_enable flags and debug parameter

2016-09-29 Thread Alexander Duyck
So the i40e driver had a really convoluted configuration for how to handle the debug flags contained in msg_enable. Part of the issue is that the driver has its own 32 bit mask that it was using to track a separate set of debug features. From what I can tell it was trying to use the upper 4 bits

Re: [PATCH net v2] tg3: Avoid NULL pointer dereference in tg3_io_error_detected()

2016-09-29 Thread Michael Chan
On Thu, Sep 29, 2016 at 9:24 AM, Guilherme G. Piccoli wrote: > From: Milton Miller > > While the driver is probing the adapter, an error may occur before the > netdev structure is allocated and attached to pci_dev. In this case, > not only netdev isn't available, but the tg3 private structure is

[PATCH net-next v3] netfilter: xt_hashlimit: Fix link error in 32bit arch because of 64bit division

2016-09-29 Thread Vishwanath Pai
v2: Remove unnecessary div64_u64 around constants v3: remove backslashes -- Fix link error in 32bit arch because of 64bit division Division of 64bit integers will cause linker error undefined reference to `__udivdi3'. Fix this by replacing divisions with div64_64 Signed-off-by: Vishwanath Pai

Re: [PATCH -next] net: macb: fix missing unlock on error in macb_start_xmit()

2016-09-29 Thread Nicolas Ferre
Le 12/09/2016 à 19:40, Helmut Buchsbaum a écrit : > On 09/10/2016 01:17 PM, Wei Yongjun wrote: >> From: Wei Yongjun >> >> Fix missing unlock before return from function macb_start_xmit() >> in the error handling case. >> >> Fixes: 007e4ba3ee13 ("net: macb: initialize checksum when using >> checksu

[PATCH V2 for-next 7/8] net: hns: bug fix about broadcast/multicast packets

2016-09-29 Thread Salil Mehta
From: Daode Huang When the dsaf mode receives a broadcast packet, it will filter the packet by comparing the received queue number and destination queue number(get from forwarding table), if they are the same, the packet will be filtered. Otherwise, the packet will be loopback. So this patch sele

[PATCH V2 for-next 5/8] net: hns: fix port not available after testing loopback

2016-09-29 Thread Salil Mehta
From: Kejian Yan After running command "ethtool -t eth0", eth0 can not be connected to network. It is caused by the changing the inner loopback register and this register cannot be changed when hns connected to network. The routine of setting this register needs to be removed and using promisc mo

[PATCH V2 for-next 3/8] net: hns: add fini_process for v2 napi process

2016-09-29 Thread Salil Mehta
From: Daode Huang This patch adds fini_process for v2, it handles the packets recevied by the hardware in the napi porcess. With this patch, the hardware irq numbers will drop 50% per sec. Signed-off-by: Daode Huang Reviewed-by: Yisen Zhuang Signed-off-by: Salil Mehta --- drivers/net/etherne

Re: [PATCH net] net: pktgen: fix pkt_size

2016-09-29 Thread Sergei Shtylyov
Hello. On 09/29/2016 05:04 PM, Paolo Abeni wrote: The commit 879c7220e828 ("net: pktgen: Observe needed_headroom of the device") increased the 'pkt_overhead' field value by LL_RESERVED_SPACE. As a side effect the generated packet size, computed as: /* Eth + IPh + UDPh + mpls */

[PATCH V2 for-next 6/8] net: hns: fix the bug of forwarding table

2016-09-29 Thread Salil Mehta
From: Daode Huang As the sub queue id in the broadcast forwarding table is always set to absolute queue 0 rather than the interface's relative queue 0, this will cause the received broadcast packets loopback to rcb. This patch sets the sub queue id to relative queue 0 of each port. Signed-off-by

[PATCH V2 for-next 8/8] net: hns: delete redundant broadcast packet filter process

2016-09-29 Thread Salil Mehta
From: Daode Huang The broadcast packets is filtered in the hardware now, so this process is no need in the driver, just delete it. Signed-off-by: Daode Huang Reviewed-by: Yisen Zhuang Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 10 -- 1 file chang

[PATCH V2 for-next 4/8] net: hns: delete repeat read fbd num after while

2016-09-29 Thread Salil Mehta
From: Daode Huang Because we handle the received packets after napi, so delete the checking before submitting. It delete the code of read the fbd number register, which reduces the cpu usages while receiving packets Signed-off-by: Daode Huang Reviewed-by: Yisen Zhuang Signed-off-by: Salil Meht

[PATCH V2 for-next 1/8] net: hns: fix port unavailable after hnae_reserve_buffer_map fail

2016-09-29 Thread Salil Mehta
From: lipeng When hnae_reserve_buffer_map fail, it will break cycle and some buffer description has no available memory, therefore the port will be unavailable. Signed-off-by: Peng Li Reviewed-by: Yisen Zhuang Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 2

[PATCH V2 for-next 0/8] Bug Fixes and Code Improvement in HNS driver

2016-09-29 Thread Salil Mehta
This patch-set introduces fix to some Bugs, potential problems and code improvements identified during internal review and testing of Hisilicon Network Subsystem driver. Submit Change V1->V2: This addresses the feedbacks provided by David Miller and Doug Ledford Daode Huang (6): net: hn

[PATCH V2 for-next 2/8] net: hns: bug fix about setting coalsecs-usecs to 0

2016-09-29 Thread Salil Mehta
From: Daode Huang When set rx/tx coalesce usecs to 0, the interrupt coalesce will be disabled, but there is a interrupt rate limit which set to 1us, it will cause no interrupt occurs. This patch disable interrupt limit when sets coalsecs usecs to 0, and restores it to 1 in other case. Signed-off

pull-request: wireless-drivers-next 2016-09-29

2016-09-29 Thread Kalle Valo
Hi Dave, this should be the last wireless-drivers-next pull request for 4.9, from now on only important bugfixes. Nothing really special stands out, iwlwifi being most active but other drivers also getting attention. More details in the signed tag. Please let me know if there are any problems. Or

Re: [PATCH v2 net-next 4/5] xps_flows: XPS for packets that don't have a socket

2016-09-29 Thread Rick Jones
On 09/29/2016 06:18 AM, Eric Dumazet wrote: Well, then what this patch series is solving ? You have a producer of packets running on 8 vcpus in a VM. Packets are exiting the VM and need to be queued on a mq NIC in the hypervisor. Flow X can be scheduled on any of these 8 vcpus, so XPS is curre

[PATCH net-next 09/10] net: dsa: mv88e6xxx: add set_switch_mac to ops

2016-09-29 Thread Vivien Didelot
Add a set_switch_mac chip-wide function to mv88e6xxx_ops and remove MV88E6XXX_FLAG_G2_SWITCH_MAC flags. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 28 +--- drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 8 ++-- 2 files changed, 23 insertions(+

[PATCH net-next 00/10] net: dsa: mv88e6xxx: Global (1) cosmetics

2016-09-29 Thread Vivien Didelot
The Global (1) internal SMI device of Marvell switches is a set of registers providing support to different units for MAC addresses (ATU), VLANs (VTU), PHY polling (PPU), etc. Chips (like 88E6060) may use a different address for it, or have subtleties in the units (e.g. different number of databas

[PATCH net-next 03/10] net: dsa: mv88e6xxx: add flags for FID registers

2016-09-29 Thread Vivien Didelot
Add flags to describe the presence of Global 1 ATU FID register (0x01) and VTU FID register (0x02), instead of checking families. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 16 +++- drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 24 2

[PATCH net-next 02/10] net: dsa: mv88e6xxx: abstract REG_GLOBAL2

2016-09-29 Thread Vivien Didelot
Similarly to the ports, phys, and Global SMI devices, abstract the SMI device address of the Global 2 registers in a few g2 static helpers. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/global2.c | 78 ++- drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 1

[PATCH net v2] tg3: Avoid NULL pointer dereference in tg3_io_error_detected()

2016-09-29 Thread Guilherme G. Piccoli
From: Milton Miller While the driver is probing the adapter, an error may occur before the netdev structure is allocated and attached to pci_dev. In this case, not only netdev isn't available, but the tg3 private structure is also not available as it is just math from the NULL pointer, so derefer

[PATCH net-next 01/10] net: dsa: mv88e6xxx: add global1 helpers

2016-09-29 Thread Vivien Didelot
The Global (1) internal SMI device is an extended set of registers containing ATU, PPU, VTU, STU, etc. It is present on every switches, usually at SMI address 0x1B. But old models such as 88E6060 access it at address 0xF, thus using REG_GLOBAL is erroneous. Add a global1_addr info member used by

[PATCH net-next 08/10] net: dsa: mv88e6xxx: add chip-wide ops

2016-09-29 Thread Vivien Didelot
Introduce a mv88e6xxx_ops structure to describe supported chip-wide functions and assign the correct variant to the chip models. For the moment, add only PHY access routines. This allows to get rid of the PHY ops structures and the usage of PHY flags. Signed-off-by: Vivien Didelot --- drivers/n

[PATCH net-next 06/10] net: dsa: mv88e6xxx: rename mv88e6xxx_vtu_stu_entry

2016-09-29 Thread Vivien Didelot
The STU (if the switch has one) is abstracted and accessed through the VTU operations and data registers. Thus rename the mv88e6xxx_vtu_stu_entry struct to mv88e6xxx_vtu_entry. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 46 +-- driv

[PATCH net-next 10/10] net: dsa: mv88e6xxx: add eeprom ops

2016-09-29 Thread Vivien Didelot
Remove EEPROM flags in favor of new {get,set}_eeprom chip-wide functions in the mv88e6xxx_ops structure. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 34 +- drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 16 +--- 2 files changed,

[PATCH net-next 04/10] net: dsa: mv88e6xxx: expose mv88e6xxx_num_databases

2016-09-29 Thread Vivien Didelot
The mv88e6xxx_num_databases will be used by shared code, so move it inline to the header file. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 5 - drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 5 + 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/driver

[PATCH net-next 07/10] net: dsa: mv88e6xxx: rename mv88e6xxx_ops

2016-09-29 Thread Vivien Didelot
The mv88e6xxx_ops is used to describe how to access the chip registers. It can be through SMI (via an MDIO bus), or via another interface such as crafted remote management frames. The correct BUS operations structure is chosen at runtime, depending on the chip address and connectivity. We will ne

[PATCH net-next 05/10] net: dsa: mv88e6xxx: add mv88e6xxx_num_ports helper

2016-09-29 Thread Vivien Didelot
Add an mv88e6xxx_num_ports helper instead of digging in the chip info structure. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 30 +++--- drivers/net/dsa/mv88e6xxx/global2.c | 8 drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 5 + 3 f

Re: [PATCH RFC net-next] bnx2x: avoid printing unnecessary messages during register dump

2016-09-29 Thread Guilherme G. Piccoli
On 09/27/2016 11:43 PM, David Miller wrote: > From: "Guilherme G. Piccoli" > Date: Tue, 27 Sep 2016 15:33:54 -0300 > >> The bnx2x driver prints multiple error messages during register dump, >> with "ethtool -d" for example. The driver even warn that many messages >> might be seen during the reg

Re: [PATCH v2 3/3] net: make net namespace sysctls belong to container's owner

2016-09-29 Thread Dmitry Torokhov
Hi David, On Wed, Aug 10, 2016 at 2:36 PM, Dmitry Torokhov wrote: > If net namespace is attached to a user namespace let's make container's > root owner of sysctls affecting said network namespace instead of global > root. > > This also allows us to clean up net_ctl_permissions() because we do no

Re: [PATCH net v2] L2TP:Adjust intf MTU,factor underlay L3,overlay L2

2016-09-29 Thread James Chapman
On 29/09/16 03:36, R. Parameswaran wrote: > I agree that something like 2. below would be needed in the long run (it > will need some effort and redesign -e.g. how do I lookup the parent tunnel > from the socket when receiving a PMTU update, existing pointer chain runs > from tunnel to socket).

Re: [PATCH net v2] L2TP:Adjust intf MTU,factor underlay L3,overlay L2

2016-09-29 Thread James Chapman
On 22/09/16 21:52, R. Parameswaran wrote: > From ed585bdd6d3d2b3dec58d414f514cd764d89159d Mon Sep 17 00:00:00 2001 > From: "R. Parameswaran" > Date: Thu, 22 Sep 2016 13:19:25 -0700 > Subject: [PATCH] L2TP:Adjust intf MTU,factor underlay L3,overlay L2 > > Take into account all of the tunnel encapsu

Re: [PATCH v2 net-next 4/5] xps_flows: XPS for packets that don't have a socket

2016-09-29 Thread Eric Dumazet
On Thu, 2016-09-29 at 07:51 -0700, Eric Dumazet wrote: > On Thu, 2016-09-29 at 10:08 -0400, Tom Herbert wrote: > > > It addresses the issue that Rick Jones pointed out was happening with > > XPS. When packets are sent for a flow that has no socket and XPS is > > enabled then each packet uses the

Re: [PATCH net-next v3 2/3] udp: implement memory accounting helpers

2016-09-29 Thread Paolo Abeni
On Thu, 2016-09-29 at 07:49 -0700, Eric Dumazet wrote: > On Thu, Sep 29, 2016 at 7:34 AM, Paolo Abeni wrote: > > On Thu, 2016-09-29 at 07:13 -0700, Eric Dumazet wrote: > >> On Thu, 2016-09-29 at 16:01 +0200, Paolo Abeni wrote: > >> > >> > When we reach __sk_mem_reduce_allocated() we are sure we ca

Re: [PATCH v2 net-next 4/5] xps_flows: XPS for packets that don't have a socket

2016-09-29 Thread Eric Dumazet
On Thu, 2016-09-29 at 10:08 -0400, Tom Herbert wrote: > It addresses the issue that Rick Jones pointed out was happening with > XPS. When packets are sent for a flow that has no socket and XPS is > enabled then each packet uses the XPS queue based on the running CPU. > Since the thread sending on

Re: [PATCH net-next v3 2/3] udp: implement memory accounting helpers

2016-09-29 Thread Eric Dumazet
On Thu, Sep 29, 2016 at 7:34 AM, Paolo Abeni wrote: > On Thu, 2016-09-29 at 07:13 -0700, Eric Dumazet wrote: >> On Thu, 2016-09-29 at 16:01 +0200, Paolo Abeni wrote: >> >> > When we reach __sk_mem_reduce_allocated() we are sure we can free the >> > specified amount of memory, so we only need to en

Re: [PATCH net-next v3 2/3] udp: implement memory accounting helpers

2016-09-29 Thread Paolo Abeni
On Thu, 2016-09-29 at 07:13 -0700, Eric Dumazet wrote: > On Thu, 2016-09-29 at 16:01 +0200, Paolo Abeni wrote: > > > When we reach __sk_mem_reduce_allocated() we are sure we can free the > > specified amount of memory, so we only need to ensure consistent > > sk_prot->memory_allocated updates. The

Re: [PATCH net-next v3 2/3] udp: implement memory accounting helpers

2016-09-29 Thread Eric Dumazet
On Thu, 2016-09-29 at 16:01 +0200, Paolo Abeni wrote: > When we reach __sk_mem_reduce_allocated() we are sure we can free the > specified amount of memory, so we only need to ensure consistent > sk_prot->memory_allocated updates. The current atomic operation suffices > to this. Then why are you u

Re: [PATCH v2 net-next 4/5] xps_flows: XPS for packets that don't have a socket

2016-09-29 Thread Tom Herbert
On Thu, Sep 29, 2016 at 9:18 AM, Eric Dumazet wrote: > On Thu, 2016-09-29 at 08:53 -0400, Tom Herbert wrote: >> On Thu, Sep 29, 2016 at 12:54 AM, Eric Dumazet >> wrote: >> > On Wed, 2016-09-28 at 20:54 -0700, Tom Herbert wrote: >> >> xps_flows maintains a per device flow table that is indexed by

[PATCH net] net: pktgen: fix pkt_size

2016-09-29 Thread Paolo Abeni
The commit 879c7220e828 ("net: pktgen: Observe needed_headroom of the device") increased the 'pkt_overhead' field value by LL_RESERVED_SPACE. As a side effect the generated packet size, computed as: /* Eth + IPh + UDPh + mpls */ datalen = pkt_dev->cur_pkt_size - 14 - 20 - 8 -

Re: [PATCH net-next v3 2/3] udp: implement memory accounting helpers

2016-09-29 Thread Paolo Abeni
On Thu, 2016-09-29 at 06:24 -0700, Eric Dumazet wrote: > On Thu, 2016-09-29 at 11:31 +0200, Paolo Abeni wrote: > > On Wed, 2016-09-28 at 18:42 -0700, Eric Dumazet wrote: > > > On Wed, 2016-09-28 at 12:52 +0200, Paolo Abeni wrote: > > > > > > > +static void udp_rmem_release(struct sock *sk, int par

[NetDev] [ANNOUNCE] Netdev 1.2 program announced

2016-09-29 Thread Hajime Tazaki
Hello, The program of Linux netdev 1.2 is now online ! http://netdevconf.org/1.2/schedule.html As we stated, all of registered people is now in the mailing list, people at netdevconf.org. If you wish to communicate with the attendees of netdev 1.2, feel free to exchange messages. -- Hajime

Re: [PATCH net-next v3 2/3] udp: implement memory accounting helpers

2016-09-29 Thread Eric Dumazet
On Thu, 2016-09-29 at 11:31 +0200, Paolo Abeni wrote: > On Wed, 2016-09-28 at 18:42 -0700, Eric Dumazet wrote: > > On Wed, 2016-09-28 at 12:52 +0200, Paolo Abeni wrote: > > > > > +static void udp_rmem_release(struct sock *sk, int partial) > > > +{ > > > + struct udp_sock *up = udp_sk(sk); > > > +

Re: [PATCH v2 net-next 4/5] xps_flows: XPS for packets that don't have a socket

2016-09-29 Thread Eric Dumazet
On Thu, 2016-09-29 at 08:53 -0400, Tom Herbert wrote: > On Thu, Sep 29, 2016 at 12:54 AM, Eric Dumazet wrote: > > On Wed, 2016-09-28 at 20:54 -0700, Tom Herbert wrote: > >> xps_flows maintains a per device flow table that is indexed by the > >> skbuff hash. The table is only consulted when there i

Re: [PATCH v2 net-next 4/5] xps_flows: XPS for packets that don't have a socket

2016-09-29 Thread Tom Herbert
On Thu, Sep 29, 2016 at 12:54 AM, Eric Dumazet wrote: > On Wed, 2016-09-28 at 20:54 -0700, Tom Herbert wrote: >> xps_flows maintains a per device flow table that is indexed by the >> skbuff hash. The table is only consulted when there is no queue saved in >> a transmit socket for an skbuff. >> >>

Re: [PATCH RFC iproute2] iplink: Support envhdrlen

2016-09-29 Thread Jiri Benc
On Tue, 27 Sep 2016 17:55:40 +0900, Toshiaki Makita wrote: > This adds support for envhdrlen. > > Example: > # ip link set eno1 envhdrlen 8 I don't see why this should be user visible, let alone requiring user to set it. This should be transparent, kernel should compute the value as needed based

Re: [PATCH net v2] L2TP:Adjust intf MTU,factor underlay L3,overlay L2

2016-09-29 Thread Jiri Benc
On Wed, 28 Sep 2016 19:36:45 -0700 (PDT), R. Parameswaran wrote: > I'd like to point out one difference with VXLAN - in VXLAN, the > local physical interface is directly specified at the time of > creation of the tunnel, and the data structure seems to have the ifindex > of the local interface w

[PATCH] af_unix: fix garbage collect vs. MSG_PEEK

2016-09-29 Thread Miklos Szeredi
Gc assumes that in-flight sockets that don't have an external ref can't gain one while unix_gc_lock is held. That is true because unix_notinflight() will be called before detaching fds, which takes unix_gc_lock. Only MSG_PEEK was somehow overlooked. That one also clones the fds, also keeping the

Request for backport to 4.4 stable

2016-09-29 Thread Jorgen S. Hansen
Hello, It would be great if the following commit could be backported to 4.4 stable. The commit fixes a bug that was introduced in 4.3 and fixed in 4.6. The bug may cause wrongful termination of vSocket connections, if there is more than one active vSocket connection in a given VM. This affects

Re: [PATCH net-next 1/8] net/ncsi: Avoid unused-value build warning from ia64-linux-gcc

2016-09-29 Thread Gavin Shan
On Thu, Sep 29, 2016 at 01:54:04AM -0400, David Miller wrote: >From: Gavin Shan >Date: Thu, 29 Sep 2016 15:03:08 +1000 > >> This replaces the atomic access to NCSI channel's state with READ_ONCE() >> and WRITE_ONCE() to avoid the above build warning. We needn't hold the >> channel's lock when upda

  1   2   >