Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

2016-07-12 Thread Kalle Valo
Prarit Bhargava writes: >> We implement thermal zone because we do support it, but the problem is >> that we need the firmware to be loaded for that. So you can argue that >> we should register *later* when the firmware is loaded. But this is >> really not helping all that much because the firmwa

Re: [PATCH v6 RESEND] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-07-12 Thread Michał Pecio
> So in order to hit this hypothetical corner case today you would > need to be using a real world type-C device something such as a > Dell WD15 on another OEM's machine that has type-C and the exact > same ACPI object name that does $BADSTUFF other than return a > buffer. Exactly what I meant.

Re: [PATCH net v3 0/2] net: ethoc: Error path and transmit fixes

2016-07-12 Thread David Miller
From: Florian Fainelli Date: Tue, 12 Jul 2016 16:04:34 -0700 > This patch series contains two patches for the ethoc driver while testing on a > TS-7300 board where ethoc is provided by an on-board FPGA. > > First patch was cooked after chasing crashes with invalid resources passed to > the drive

RE: [PATCH v2 0/8] thunderbolt: Introducing Thunderbolt(TM) networking

2016-07-12 Thread Levy, Amir (Jer)
On Wed, Jul 13 2016, 01:19 AM, Andreas Noever wrote: > Since this is now a separate driver I would prefer if it was in a different > (sub)directory (maybe thunderbolt/icm?). > Thanks Andreas for the comment, will change it in the next patch. Any more comments?

Re: [PATCH v8 01/11] bpf: add XDP prog type for early driver filter

2016-07-12 Thread Alexei Starovoitov
On Tue, Jul 12, 2016 at 07:52:53AM -0700, Tom Herbert wrote: > On Tue, Jul 12, 2016 at 6:14 AM, Jesper Dangaard Brouer > wrote: > > > > On Tue, 12 Jul 2016 00:51:24 -0700 Brenden Blanco > > wrote: > > > >> Add a new bpf prog type that is intended to run in early stages of the > >> packet rx path

Re: [net-next PATCH RFC] mlx4: RX prefetch loop

2016-07-12 Thread Alexei Starovoitov
On Tue, Jul 12, 2016 at 09:52:52PM +0200, Jesper Dangaard Brouer wrote: > > > > >> Also unconditionally doing batch of 8 may also hurt depending on what > > >> is happening either with the stack, bpf afterwards or even cpu version. > > > > > > See this as software DDIO, if the unlikely case that

Re: [PATCH v8 06/11] net/mlx4_en: add page recycle to prepare rx ring for tx support

2016-07-12 Thread Brenden Blanco
On Tue, Jul 12, 2016 at 02:18:32PM -0700, David Miller wrote: > From: Brenden Blanco > Date: Tue, 12 Jul 2016 00:51:29 -0700 > > > + mlx4_en_free_resources(priv); > > + > > old_prog = xchg(&priv->prog, prog); > > if (old_prog) > > bpf_prog_put(old_prog); > > > > - return

RE: [PATCH v8 06/11] net/mlx4_en: add page recycle to prepare rx ring for tx support

2016-07-12 Thread Tariq Toukan
>The mlx4 driver by default allocates order-3 pages for the ring to consume in >multiple fragments. When the device has an xdp program, this behavior will >prevent tx actions since the page must be re-mapped in TODEVICE mode, which >cannot be done if the page is still shared. > >Start by making

Re: [PATCH net-next 3/3] bpf: avoid stack copy and use skb ctx for event output

2016-07-12 Thread Fengguang Wu
Hi Daniel, On Wed, Jul 13, 2016 at 01:45:47AM +0200, Daniel Borkmann wrote: On 07/13/2016 01:25 AM, kbuild test robot wrote: Hi, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Daniel-Borkmann/BPF-event-output-helper-improvements/20160713-065944

Re: [PATCH net-next 3/3] bpf: avoid stack copy and use skb ctx for event output

2016-07-12 Thread Daniel Borkmann
On 07/13/2016 01:25 AM, kbuild test robot wrote: Hi, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Daniel-Borkmann/BPF-event-output-helper-improvements/20160713-065944 config: s390-allyesconfig (attached as .config) compiler: s390x-linux-gnu-gcc

Re: [PATCH net-next 3/3] bpf: avoid stack copy and use skb ctx for event output

2016-07-12 Thread kbuild test robot
Hi, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Daniel-Borkmann/BPF-event-output-helper-improvements/20160713-065944 config: s390-allyesconfig (attached as .config) compiler: s390x-linux-gnu-gcc (Debian 5.3.1-8) 5.3.1 20160205 reproduce:

[PATCH net v3 0/2] net: ethoc: Error path and transmit fixes

2016-07-12 Thread Florian Fainelli
Hi all, This patch series contains two patches for the ethoc driver while testing on a TS-7300 board where ethoc is provided by an on-board FPGA. First patch was cooked after chasing crashes with invalid resources passed to the driver. Second patch was cooked after seeing that an interface confi

[PATCH net v3 2/2] net: ethoc: Correctly pad short packets

2016-07-12 Thread Florian Fainelli
Even though the hardware can be doing zero padding, we want the SKB to be going out on the wire with the appropriate size. This fixes packet truncations observed with e.g: ARP packets. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/ethoc.c | 6 ++ 1 file changed, 6 insertions(+) d

[PATCH net v3 1/2] net: ethoc: Fix early error paths

2016-07-12 Thread Florian Fainelli
In case any operation fails before we can successfully go the point where we would register a MDIO bus, we would be going to an error label which involves unregistering then freeing this yet to be created MDIO bus. Update all error paths to go to label free which is the only one valid until either

Re: [PATCH net 2/2] dccp: limit sk_filter trim to payload

2016-07-12 Thread Daniel Borkmann
On 07/13/2016 12:18 AM, Willem de Bruijn wrote: From: Willem de Bruijn Dccp verifies packet integrity, including length, at initial rcv in dccp_invalid_packet, later pulls headers in dccp_enqueue_skb. A call to sk_filter in-between can cause __skb_pull to wrap skb->len. skb_copy_datagram_msg i

Re: [PATCH net 1/2] rose: limit sk_filter trim to payload

2016-07-12 Thread Daniel Borkmann
On 07/13/2016 12:18 AM, Willem de Bruijn wrote: From: Willem de Bruijn Sockets can have a filter program attached that drops or trims incoming packets based on the filter program return value. Rose requires data packets to have at least ROSE_MIN_LEN bytes. It verifies this on arrival in rose_r

[PATCH net-next 1/3] perf, events: add non-linear data support for raw records

2016-07-12 Thread Daniel Borkmann
This patch adds support for non-linear data on raw records. It means that for such data, the newly introduced __output_custom() helper will be used instead of __output_copy(). __output_custom() will invoke whatever custom callback is passed in via struct perf_raw_record_frag to extract the data int

[PATCH net-next 3/3] bpf: avoid stack copy and use skb ctx for event output

2016-07-12 Thread Daniel Borkmann
This work improves bpf_skb_event_output() helper in two ways, i) it avoids that users need to unnecessary extract sampled skb data to stack first via bpf_skb_load_bytes() and then copy once again into the ring buffer slot, and ii) it avoids that only portions can be sampled with bpf_skb_load_bytes(

[PATCH net-next 2/3] bpf, perf: split bpf_perf_event_output

2016-07-12 Thread Daniel Borkmann
Split the bpf_perf_event_output() helper as a preparation into two parts. The newly bpf_perf_event_output() will prepare the raw record itself and test for unknown flags from BPF trace context, where the __bpf_perf_event_output() does the core work and will be reused later as well. Signed-off-by:

[PATCH net-next 0/3] BPF event output helper improvements

2016-07-12 Thread Daniel Borkmann
This set adds improvements to the BPF event output helper to support non-linear data sampling, here specifically, for skb context. For details please see individual patches. The set is based against net-next tree. Thanks a lot! Daniel Borkmann (3): perf, events: add non-linear data support for

[PATCH net 1/2] rose: limit sk_filter trim to payload

2016-07-12 Thread Willem de Bruijn
From: Willem de Bruijn Sockets can have a filter program attached that drops or trims incoming packets based on the filter program return value. Rose requires data packets to have at least ROSE_MIN_LEN bytes. It verifies this on arrival in rose_route_frame and unconditionally pulls the bytes in

[PATCH net 1/2] rose: limit sk_filter trim to payload

2016-07-12 Thread Willem de Bruijn
From: Willem de Bruijn Sockets can have a filter program attached that drops or trims incoming packets based on the filter program return value. Rose requires data packets to have at least ROSE_MIN_LEN bytes. It verifies this on arrival in rose_route_frame and unconditionally pulls the bytes in

[PATCH net 0/2] limit sk_filter trim to payload

2016-07-12 Thread Willem de Bruijn
From: Willem de Bruijn Sockets can apply a filter to incoming packets to drop or trim them. Fix two codepaths that call skb_pull/__skb_pull after sk_filter without checking for packet length. Reading beyond skb->tail after trimming happens in more codepaths, but safety of reading in the linear s

[PATCH net 2/2] dccp: limit sk_filter trim to payload

2016-07-12 Thread Willem de Bruijn
From: Willem de Bruijn Dccp verifies packet integrity, including length, at initial rcv in dccp_invalid_packet, later pulls headers in dccp_enqueue_skb. A call to sk_filter in-between can cause __skb_pull to wrap skb->len. skb_copy_datagram_msg interprets this as a negative value, so (correctly)

Re: [PATCH v2 0/8] thunderbolt: Introducing Thunderbolt(TM) networking

2016-07-12 Thread Andreas Noever
On Tue, Jul 12, 2016 at 12:50 PM, Levy, Amir (Jer) wrote: > On Wed, Jun 29 2016, 11:35 AM, Levy, Amir (Jer) wrote: >> This is version 2 of Thunderbolt(TM) driver for non-Apple hardware. >> >> Changes since v1: >> - Separation to 2 modules. >> - Moved ICM specific registers definition to ICM head

[PATCH net-next 05/10] net/mlx5: E-Switch, Add API to configure rules for the offloaded mode

2016-07-12 Thread Saeed Mahameed
From: Or Gerlitz This allows for upper levels in the driver, e.g the TC offload code to add e-switch offloaded steering rules. The caller provides the rule spec for matching, action, source and destination vports. Signed-off-by: Or Gerlitz Signed-off-by: Saeed Mahameed --- drivers/net/etherne

[PATCH net-next 08/10] net/mlx5e: Add TC drop and mirred/redirect action parsing for SRIOV offloads

2016-07-12 Thread Saeed Mahameed
From: Or Gerlitz Add the setup code that parses the TC actions needed to support offloading drop and mirred/redirect for SRIOV e-switch. We can redirect between two devices if they belong to the same HW switch, compare the switchdev HW ID attribute to enforce that. Signed-off-by: Or Gerlitz Sig

[PATCH net-next 10/10] net/mlx5e: Add TC offload support for the VF representors netdevice

2016-07-12 Thread Saeed Mahameed
From: Or Gerlitz The VF representors support only TC filter/action offloads (not mqprio) and this is enabled for them by default. Signed-off-by: Or Gerlitz Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 35 +++- 1 file changed, 34 inse

[PATCH net-next 01/10] net/mlx5: Store counters in rbtree instead of list

2016-07-12 Thread Saeed Mahameed
From: Amir Vadai In order to use bulk counters, we need to have counters sorted by id. Signed-off-by: Amir Vadai Reviewed-by: Or Gerlitz Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.h | 1 + .../net/ethernet/mellanox/mlx5/core/fs_counters.c | 64 ++

[PATCH net-next 06/10] net/mlx5e: Adjustments in the TC offload code towards reuse for SRIOV

2016-07-12 Thread Saeed Mahameed
From: Or Gerlitz Towards reusing the TC offloads code for an SRIOV use-case, change some of the helper functions to have _nic in their names so it's clear what's NIC unique and what's general. Also group together the NIC related helpers so we can easily branch per the use-case in downstream patch

[PATCH net-next 04/10] net/mlx5: E-Switch, Use two priorities for SRIOV offloads mode

2016-07-12 Thread Saeed Mahameed
From: Or Gerlitz In the offloads mode, some slow path rules are added by the driver (e.g send-to-vport), while offloaded rules are to be added from upper layers. The slow path rules have lower priority and we don't want matching on offloaded rules to suffer from extra steering hops related to th

[PATCH net-next 02/10] net/mlx5: Introduce bulk reading of flow counters

2016-07-12 Thread Saeed Mahameed
From: Amir Vadai This commit utilize the ability of ConnectX-4 to bulk read flow counters. Few bulk counter queries could be done instead of issuing thousands of firmware commands per second to get statistics of all flows set to HW, such as those programmed when we offload tc filters. Counters a

[PATCH net-next 03/10] net/mlx5e: Offload TC flow counters only when supported

2016-07-12 Thread Saeed Mahameed
From: Or Gerlitz Currenly, the code that programs the flow actions into the firmware doesn't check if was actually asked to offload the statistics, fix that. Fixes: aad7e08d39bd ('net/mlx5e: Hardware offloaded flower filter statistics support') Signed-off-by: Or Gerlitz Signed-off-by: Saeed Ma

[PATCH net-next 09/10] net/mlx5e: Add TC HW support for FDB (SRIOV e-switch) offloads

2016-07-12 Thread Saeed Mahameed
From: Or Gerlitz Enhance the TC offload code such that when the eswitch exists and it's mode being SRIOV offloads, we do TC actions parsing and setup targeted for eswitch. Next, we add the offloaded flow to the HW e-switch (fdb). Signed-off-by: Or Gerlitz Signed-off-by: Saeed Mahameed --- dri

[PATCH net-next 07/10] net/switchdev: Export the same parent ID service function

2016-07-12 Thread Saeed Mahameed
From: Or Gerlitz This helper serves to know if two switchdev port netdevices belong to the same HW ASIC, e.g to figure out if forwarding offload is possible between them. Signed-off-by: Or Gerlitz Signed-off-by: Saeed Mahameed --- include/net/switchdev.h | 8 net/switchdev/switchde

[PATCH net-next 00/10] Mellanox 100G mlx5 Bulk flow statistics and SRIOV TC offloads

2016-07-12 Thread Saeed Mahameed
Hi Dave, This series from Amir and Or deals with two enhancements for the mlx5 TC offloads. The 1st two patches add bulk reading of flow counters. Few bulk counter queries are used instead of issuing thousands firmware commands per second to get statistics of all flows set to HW. The next pat

Re: [patch net-next v2 1/2] devlink: add hardware messages tracing facility

2016-07-12 Thread David Miller
From: Jiri Pirko Date: Tue, 12 Jul 2016 18:05:03 +0200 > From: Jiri Pirko > > Define a tracepoint and allow user to trace messages going to and from > hardware associated with devlink instance. > > Signed-off-by: Jiri Pirko Applied.

Re: [patch net-next v2 2/2] mlxsw: core: Trace EMAD messages

2016-07-12 Thread David Miller
From: Jiri Pirko Date: Tue, 12 Jul 2016 18:05:04 +0200 > From: Jiri Pirko > > Trace EMAD messages going down to HW and up from HW. Devlink needs to be > registered before EMAD init so the trace function can be called > with valid devlink handle. > > Signed-off-by: Jiri Pirko > v1->v2: > - Use

Re: [PATCH v8 06/11] net/mlx4_en: add page recycle to prepare rx ring for tx support

2016-07-12 Thread David Miller
From: Brenden Blanco Date: Tue, 12 Jul 2016 00:51:29 -0700 > + mlx4_en_free_resources(priv); > + > old_prog = xchg(&priv->prog, prog); > if (old_prog) > bpf_prog_put(old_prog); > > - return 0; > + err = mlx4_en_alloc_resources(priv); > + if (err) { > +

[PATCH net 2/2] net/mlx5e: start/stop all tx queues upon open/close netdev

2016-07-12 Thread Saeed Mahameed
From: Mohamad Haj Yahia Start all tx queues (including inactive ones) when opening the netdev. Stop all tx queues (including inactive ones) when closing the netdev. This is a workaround for the tx timeout watchdog false alarm issue in which the netdev watchdog is polling all the tx queues which

[PATCH net 1/2] net/mlx5e: Fix TX Timeout to detect queues stuck on BQL

2016-07-12 Thread Saeed Mahameed
From: Daniel Jurgens Change netif_tx_queue_stopped to netif_xmit_stopped. This will show when queues are stopped due to byte queue limits. Fixes: 3947ca185999 ('net/mlx5e: Implement ndo_tx_timeout callback') Signed-off-by: Daniel Jurgens Signed-off-by: Saeed Mahameed --- drivers/net/ethernet

[PATCH net 0/2] mlx5 tx timeout watchdog fixes

2016-07-12 Thread Saeed Mahameed
Hi Dave, This patch set provides two trivial fixes for the tx timeout series lately applied into net 4.7. >From Daniel, detect stuck queues due to BQL >From Mohamad, fix tx timeout watchdog false alarm Hopefully those two fixes will make it to -stable, assuming 3947ca185999 ('net/mlx5e: Implem

[PATCH net-next] net: vrf: Documentation update

2016-07-12 Thread David Ahern
Update vrf documentation for changes made to 4.4 - 4.8 kernels and iproute2 support for vrf keyword. Signed-off-by: David Ahern --- Documentation/networking/vrf.txt | 201 --- 1 file changed, 103 insertions(+), 98 deletions(-) diff --git a/Documentation/netwo

Re: [PATCH 1/1] net: nps_enet: Fix PCS reset

2016-07-12 Thread David Miller
From: Elad Kanfi Date: Tue, 12 Jul 2016 16:01:11 +0300 > From: Noam Camus > > During commit b54b8c2d6e3c > ("net: ezchip: adapt driver to little endian architecture") > adapting to little endian architecture, > zeroing of controller was left out. > > Signed-off-by: Elad Kanfi Applied.

Re: XDP seeking input from NIC hardware vendors

2016-07-12 Thread Jesper Dangaard Brouer
On Tue, 12 Jul 2016 12:13:01 -0700 John Fastabend wrote: > On 16-07-11 07:24 PM, Alexei Starovoitov wrote: > > On Sat, Jul 09, 2016 at 01:27:26PM +0200, Jesper Dangaard Brouer wrote: > >> On Fri, 8 Jul 2016 18:51:07 +0100 > >> Jakub Kicinski wrote: > >> > >>> On Fri, 8 Jul 2016 09:45:25 -070

Re: [net-next PATCH RFC] mlx4: RX prefetch loop

2016-07-12 Thread Jesper Dangaard Brouer
On Tue, 12 Jul 2016 09:46:26 -0700 Alexander Duyck wrote: > On Tue, Jul 12, 2016 at 5:45 AM, Jesper Dangaard Brouer > wrote: > > On Mon, 11 Jul 2016 16:05:11 -0700 > > Alexei Starovoitov wrote: > > > >> On Mon, Jul 11, 2016 at 01:09:22PM +0200, Jesper Dangaard Brouer wrote: > >> > > - /* Pr

Re: XDP seeking input from NIC hardware vendors

2016-07-12 Thread Jakub Kicinski
On Tue, 12 Jul 2016 12:13:01 -0700, John Fastabend wrote: > On 16-07-11 07:24 PM, Alexei Starovoitov wrote: > > On Sat, Jul 09, 2016 at 01:27:26PM +0200, Jesper Dangaard Brouer wrote: > >> On Fri, 8 Jul 2016 18:51:07 +0100 > >> Jakub Kicinski wrote: > >> > >>> On Fri, 8 Jul 2016 09:45:25 -0700

Re: ethtool TODO list - additional info

2016-07-12 Thread John W. Linville
On Tue, Jul 12, 2016 at 11:34:06AM -0700, David Miller wrote: > From: "John W. Linville" > Date: Tue, 12 Jul 2016 14:12:52 -0400 > > > I haven't heard a strong case for why it is necessary. > > Stats on large scale setups/systems is problematic and ethtool > is a part of that problem. > > Exten

Re: [PATCH iptables 3/3] libxt_hashlimit: iptables-restore does not work as expected with xt_hashlimit

2016-07-12 Thread Vishwanath Pai
On 07/08/2016 07:54 AM, Pablo Neira Ayuso wrote: > We have to keep the existing behaviour. Yes, it's broken or ambiguos > but there may be people outthere relying on this. > > What I think we can do to resolve this scenario that you describe > abobe is to provide a new option: > > --hashl

Re: XDP seeking input from NIC hardware vendors

2016-07-12 Thread John Fastabend
On 16-07-11 07:24 PM, Alexei Starovoitov wrote: > On Sat, Jul 09, 2016 at 01:27:26PM +0200, Jesper Dangaard Brouer wrote: >> On Fri, 8 Jul 2016 18:51:07 +0100 >> Jakub Kicinski wrote: >> >>> On Fri, 8 Jul 2016 09:45:25 -0700, John Fastabend wrote: The only distinction between VFs and queue gr

Re: [PATCH -next] net: dsa: Fix non static symbol warning

2016-07-12 Thread David Miller
From: weiyj...@163.com Date: Tue, 12 Jul 2016 15:24:10 + > From: Wei Yongjun > > Fixes the following sparse warning: > > net/dsa/dsa2.c:680:6: warning: > symbol '_dsa_unregister_switch' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun Applied.

Re: ethtool TODO list - additional info

2016-07-12 Thread David Miller
From: "John W. Linville" Date: Tue, 12 Jul 2016 14:12:52 -0400 > I haven't heard a strong case for why it is necessary. Stats on large scale setups/systems is problematic and ethtool is a part of that problem. Extensibility in general suffers because of the ioctl() interface as well. For getti

Re: ethtool TODO list - additional info

2016-07-12 Thread John Fastabend
On 16-07-12 11:12 AM, John W. Linville wrote: > On Tue, Jul 12, 2016 at 01:04:52PM -0500, Jorge Alberto Garcia wrote: >> On Tue, Jul 12, 2016 at 12:55 PM, Jiri Pirko wrote: >>> Tue, Jul 05, 2016 at 05:37:42PM CEST, jorge.garcia.gonza...@gmail.com wrote: Hi ! Some days ago, Jiri Pirk

Re: ethtool TODO list - additional info

2016-07-12 Thread John W. Linville
On Tue, Jul 12, 2016 at 01:04:52PM -0500, Jorge Alberto Garcia wrote: > On Tue, Jul 12, 2016 at 12:55 PM, Jiri Pirko wrote: > > Tue, Jul 05, 2016 at 05:37:42PM CEST, jorge.garcia.gonza...@gmail.com wrote: > >>Hi ! > >> > >>Some days ago, Jiri Pirko was talking about some next steps to > >>implemen

Re: 4.6.3, pppoe + shaper workload, skb_panic / skb_push / ppp_start_xmit

2016-07-12 Thread nuclearcat
On 2016-07-12 21:05, Cong Wang wrote: On Tue, Jul 12, 2016 at 11:03 AM, wrote: On 2016-07-12 20:31, Cong Wang wrote: On Mon, Jul 11, 2016 at 12:45 PM, wrote: Hi On latest kernel i noticed kernel panic happening 1-2 times per day. It is also happening on older kernel (at least 4.5.3).

Re: [PATCH] net: Fragment large datagrams even when IP_HDRINCL is set.

2016-07-12 Thread David Miller
From: Alan Davey Date: Tue, 12 Jul 2016 12:34:07 + > - all future applications have to continue to implement their own > fragmentation code, duplicating that which already exists in the kernel They have to do this anyways, don't you see this? Otherwise they don't support %99 of the kernel

Re: Fwd: Fwd: Re: [PATCH net-next 00/15] net/smc: Shared Memory Communications - RDMA

2016-07-12 Thread Benjamin Poirier
On 2016/07/12 11:08, Benjamin Poirier wrote: > On 2016/07/06 17:29, Ursula Braun wrote: > > Dave, > > > > we still like to see SMC-R included into a future Linux-kernel. After > > answering your first 2 questions, there is no longer a response. What should > > we do next? > > - Still wait for an a

Re: [PATCH -next] rxrpc: Fix error handling in af_rxrpc_init()

2016-07-12 Thread David Miller
From: weiyj...@163.com Date: Tue, 12 Jul 2016 11:21:17 + > From: Wei Yongjun > > security initialized after alloc workqueue, so we should exit security > before destroy workqueue in the error handing. > > Fixes: 648af7fca159 ("rxrpc: Absorb the rxkad security module") > Signed-off-by: Wei Y

Re: Fwd: Fwd: Re: [PATCH net-next 00/15] net/smc: Shared Memory Communications - RDMA

2016-07-12 Thread Benjamin Poirier
On 2016/07/06 17:29, Ursula Braun wrote: > Dave, > > we still like to see SMC-R included into a future Linux-kernel. After > answering your first 2 questions, there is no longer a response. What should > we do next? > - Still wait for an answer from you? > - Resend the same whole SMC-R patch serie

Re: [PATCH -next] net: mediatek: fix non static symbol warnings

2016-07-12 Thread David Miller
From: weiyj...@163.com Date: Tue, 12 Jul 2016 11:36:44 + > From: Wei Yongjun > > Fixes the following sparse warnings: > > drivers/net/ethernet/mediatek/mtk_eth_soc.c:79:5: warning: > symbol '_mtk_mdio_write' was not declared. Should it be static? > drivers/net/ethernet/mediatek/mtk_eth_soc

Re: [PATCH -next] dwc_eth_qos: fix missing clk_disable_unprepare() on error in dwceqos_probe()

2016-07-12 Thread David Miller
From: weiyj...@163.com Date: Tue, 12 Jul 2016 11:43:37 + > From: Wei Yongjun > > Fix missing clk_disable_unprepare() call before return > from dwceqos_probe() in the error handling case of invalid > fixed-link. > > Signed-off-by: Wei Yongjun Applied.

Re: [PATCH -next] stmmac: dwmac-socfpga: fix wrong pointer passed to PTR_ERR()

2016-07-12 Thread David Miller
From: weiyj...@163.com Date: Tue, 12 Jul 2016 11:00:09 + > From: Wei Yongjun > > PTR_ERR should access the value just tested by IS_ERR, otherwise > the wrong error code will be returned. > > Signed-off-by: Wei Yongjun Applied.

Re: 4.6.3, pppoe + shaper workload, skb_panic / skb_push / ppp_start_xmit

2016-07-12 Thread Cong Wang
On Tue, Jul 12, 2016 at 11:03 AM, wrote: > On 2016-07-12 20:31, Cong Wang wrote: >> >> On Mon, Jul 11, 2016 at 12:45 PM, wrote: >>> >>> Hi >>> >>> On latest kernel i noticed kernel panic happening 1-2 times per day. It >>> is >>> also happening on older kernel (at least 4.5.3). >>> >> ... >>> >

Re: ethtool TODO list - additional info

2016-07-12 Thread Jorge Alberto Garcia
On Tue, Jul 12, 2016 at 12:55 PM, Jiri Pirko wrote: > Tue, Jul 05, 2016 at 05:37:42PM CEST, jorge.garcia.gonza...@gmail.com wrote: >>Hi ! >> >>Some days ago, Jiri Pirko was talking about some next steps to >>implement for ethtool. >> >> I haven't seen any follow up since ethtool's maintainer chang

Re: 4.6.3, pppoe + shaper workload, skb_panic / skb_push / ppp_start_xmit

2016-07-12 Thread nuclearcat
On 2016-07-12 20:31, Cong Wang wrote: On Mon, Jul 11, 2016 at 12:45 PM, wrote: Hi On latest kernel i noticed kernel panic happening 1-2 times per day. It is also happening on older kernel (at least 4.5.3). ... [42916.426463] Call Trace: [42916.426658] [42916.426719] [] skb_push+0x

Re: [PATCH 1/1] bonding: restrict the data protected by rcu_read_lock

2016-07-12 Thread David Miller
From: Zhu Yanjun Date: Tue, 12 Jul 2016 15:28:17 +0800 > In this function, origin is a pointer to struct aggregator. > No matter what agg is changed to, it has nothing to do with origin. > > CC: Jay Vosburgh > Signed-off-by: Zhu Yanjun I really hate changes like this. Imagine if a inner func

Re: ethtool TODO list - additional info

2016-07-12 Thread Jiri Pirko
Tue, Jul 05, 2016 at 05:37:42PM CEST, jorge.garcia.gonza...@gmail.com wrote: >Hi ! > >Some days ago, Jiri Pirko was talking about some next steps to >implement for ethtool. > > I haven't seen any follow up since ethtool's maintainer change. Can we have >additional details about these ? > >- libetht

Re: [PATCH net-next,v3] tools: hv: Add a script to help bonding synthetic and VF NICs

2016-07-12 Thread David Miller
From: Haiyang Zhang Date: Mon, 11 Jul 2016 17:06:42 -0700 > From: Haiyang Zhang > > This script helps to create bonding network devices based on synthetic NIC > (the virtual network adapter usually provided by Hyper-V) and the matching > VF NIC (SRIOV virtual function). So the synthetic NIC and

Re: [PATCH] virtio-net: Remove more stack DMA

2016-07-12 Thread David Miller
From: Andy Lutomirski Date: Mon, 11 Jul 2016 14:30:28 -0700 > DaveM, is it okay for this to go in via -tip? Sure.

Re: [RFC PATCH v3] net: sched: convert qdisc linked list to hashtable

2016-07-12 Thread Cong Wang
On Mon, Jul 11, 2016 at 7:02 AM, Jiri Kosina wrote: > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index f45929c..0b5c172e 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -52,6 +52,7 @@ > #include > #include > #include > +#include > >

Re: [PATCH net v2 0/2] net: ethoc: Error path and transmit fixes

2016-07-12 Thread David Miller
From: Max Filippov Date: Tue, 12 Jul 2016 16:51:10 +0300 > Hello, > > On Mon, Jul 11, 2016 at 04:35:53PM -0700, Florian Fainelli wrote: >> This patch series contains two patches for the ethoc driver while testing on >> a >> TS-7300 board where ethoc is provided by an on-board FPGA. >> >> First

Re: 4.6.3, pppoe + shaper workload, skb_panic / skb_push / ppp_start_xmit

2016-07-12 Thread Cong Wang
On Mon, Jul 11, 2016 at 12:45 PM, wrote: > Hi > > On latest kernel i noticed kernel panic happening 1-2 times per day. It is > also happening on older kernel (at least 4.5.3). > ... > [42916.426463] Call Trace: > [42916.426658] > > [42916.426719] [] skb_push+0x36/0x37 > [42916.427111] []

Re: [patch net-next v2 1/2] devlink: add hardware messages tracing facility

2016-07-12 Thread Steven Rostedt
On Tue, 12 Jul 2016 19:10:46 +0200 Jiri Pirko wrote: > Tue, Jul 12, 2016 at 06:38:26PM CEST, rost...@goodmis.org wrote: > >On Tue, 12 Jul 2016 18:05:03 +0200 > >Jiri Pirko wrote: > > > >> From: Jiri Pirko > >> > >> Define a tracepoint and allow user to trace messages going to and from > >> h

Re: [PATCH 0/6] Netfilter/IPVS fixes for net

2016-07-12 Thread David Miller
From: Pablo Neira Ayuso Date: Tue, 12 Jul 2016 18:10:56 +0200 > The following patchset contains Netfilter/IPVS fixes for your net tree. > they are: > > 1) Fix leak in the error path of nft_expr_init(), from Liping Zhang. > > 2) Tracing from nf_tables cannot be disabled, also from Zhang. > > 3)

Re: [RFC PATCH net-next 1/1] Introduce skbmod action

2016-07-12 Thread Cong Wang
On Mon, Jul 11, 2016 at 5:12 AM, Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > > This action is intended to be an upgrade from a usability perspective > from pedit. Compare this: > Definitely agree we need a more user-friendly interface. > > pedit is a good starting point - but once you st

Re: [patch net-next v2 1/2] devlink: add hardware messages tracing facility

2016-07-12 Thread Jiri Pirko
Tue, Jul 12, 2016 at 06:38:26PM CEST, rost...@goodmis.org wrote: >On Tue, 12 Jul 2016 18:05:03 +0200 >Jiri Pirko wrote: > >> From: Jiri Pirko >> >> Define a tracepoint and allow user to trace messages going to and from >> hardware associated with devlink instance. >> >> Signed-off-by: Jiri Pirk

Re: [net-next PATCH RFC] mlx4: RX prefetch loop

2016-07-12 Thread Alexander Duyck
On Tue, Jul 12, 2016 at 5:45 AM, Jesper Dangaard Brouer wrote: > On Mon, 11 Jul 2016 16:05:11 -0700 > Alexei Starovoitov wrote: > >> On Mon, Jul 11, 2016 at 01:09:22PM +0200, Jesper Dangaard Brouer wrote: >> > > - /* Process all completed CQEs */ >> > > + /* Extract and prefetch completed CQEs */

Re: [patch net-next v2 1/2] devlink: add hardware messages tracing facility

2016-07-12 Thread Steven Rostedt
On Tue, 12 Jul 2016 18:05:03 +0200 Jiri Pirko wrote: > From: Jiri Pirko > > Define a tracepoint and allow user to trace messages going to and from > hardware associated with devlink instance. > > Signed-off-by: Jiri Pirko > --- > v1->v2: > - Use EXPORT_TRACEPOINT_SYMBOL_GPL instead of a wrapp

Re: [PATCH v7 04/11] net/mlx4_en: add support for fast rx drop bpf program

2016-07-12 Thread Brenden Blanco
On Mon, Jul 11, 2016 at 11:17:00PM -0700, David Miller wrote: > From: Brenden Blanco > Date: Mon, 11 Jul 2016 14:29:51 -0700 > > > + if (priv->num_frags > 1) > > + return -EOPNOTSUPP; > > I hate to be the user who has to debug why his XDP program won't > load just because he set a ju

Re: [PATCH v3] Marvell phy: add fiber status check and configuration for some phys

2016-07-12 Thread Charles-Antoine Couret
Le 12/07/2016 à 17:18, Andrew Lunn a écrit : > Hi Charles It's Charles-Antoine. ;) > > It is best to submit a number of smaller patches, each doing one > thing, than a single big patch. It makes review and discussion much > simpler. I'm sorry, I will fix that. > So for example, this should be

Re: eBPF tunable max instructions or max tail call?

2016-07-12 Thread Sargun Dhillon
On Mon, Jul 11, 2016 at 8:14 PM, Alexei Starovoitov wrote: > On Mon, Jul 11, 2016 at 05:56:07PM -0700, Sargun Dhillon wrote: >> It would be nice to have eBPF programs that are longer than 4096 >> instructions. I'm trying to implement XSalsa20 in eBPF, and >> unfortunately, it doesn't fit into 4096

[PATCH 0/6] Netfilter/IPVS fixes for net

2016-07-12 Thread Pablo Neira Ayuso
Hi David, The following patchset contains Netfilter/IPVS fixes for your net tree. they are: 1) Fix leak in the error path of nft_expr_init(), from Liping Zhang. 2) Tracing from nf_tables cannot be disabled, also from Zhang. 3) Fix an integer overflow on 32bit archs when setting the number of

[PATCH 6/6] netfilter: conntrack: skip clash resolution if nat is in place

2016-07-12 Thread Pablo Neira Ayuso
The clash resolution is not easy to apply if the NAT table is registered. Even if no NAT rules are installed, the nul-binding ensures that a unique tuple is used, thus, the packet that loses race gets a different source port number, as described by: http://marc.info/?l=netfilter-devel&m=1468180116

[PATCH 3/6] netfilter: conntrack: avoid integer overflow when resizing

2016-07-12 Thread Pablo Neira Ayuso
From: Florian Westphal Can overflow so we might allocate very small table when bucket count is high on a 32bit platform. Note: resize is only possible from init_netns. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_conntrack_core.c | 7 +++ 1 file c

[PATCH 5/6] netfilter: nft_ct: fix expiration getter

2016-07-12 Thread Pablo Neira Ayuso
From: Florian Westphal We need to compute timeout.expires - jiffies, not the other way around. Add a helper, another patch can then later change more places in conntrack code where we currently open-code this. Will allow us to only change one place later when we remove per-ct timer. Signed-off-

[PATCH 1/6] netfilter: nf_tables: fix memory leak if expr init fails

2016-07-12 Thread Pablo Neira Ayuso
From: Liping Zhang If expr init fails then we need to free it. So when the user add a nft rule as follows: # nft add rule filter input tcp dport 22 flow table ssh \ { ip saddr limit rate 0/second } memory leak will happen. Signed-off-by: Liping Zhang Signed-off-by: Pablo Neira Ayuso -

[PATCH 4/6] ipvs: fix bind to link-local mcast IPv6 address in backup

2016-07-12 Thread Pablo Neira Ayuso
From: Quentin Armitage When using HEAD from https://git.kernel.org/cgit/utils/kernel/ipvsadm/ipvsadm.git/, the command: ipvsadm --start-daemon backup --mcast-interface eth0.60 \ --mcast-group ff02::1:81 fails with the error message: Argument list too long whereas both: ipvsadm --start-daemon

[PATCH 2/6] netfilter: nft_meta: set skb->nf_trace appropriately

2016-07-12 Thread Pablo Neira Ayuso
From: Liping Zhang When user add a nft rule to set nftrace to zero, for example: # nft add rule ip filter input nftrace set 0 We should set nf_trace to zero also. Signed-off-by: Liping Zhang Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nft_meta.c | 2 +- 1 file changed, 1 insertion(

[patch net-next v2 1/2] devlink: add hardware messages tracing facility

2016-07-12 Thread Jiri Pirko
From: Jiri Pirko Define a tracepoint and allow user to trace messages going to and from hardware associated with devlink instance. Signed-off-by: Jiri Pirko --- v1->v2: - Use EXPORT_TRACEPOINT_SYMBOL_GPL instead of a wrapper function as suggested by David Ahern and Steven Rostedt --- include

[patch net-next v2 2/2] mlxsw: core: Trace EMAD messages

2016-07-12 Thread Jiri Pirko
From: Jiri Pirko Trace EMAD messages going down to HW and up from HW. Devlink needs to be registered before EMAD init so the trace function can be called with valid devlink handle. Signed-off-by: Jiri Pirko v1->v2: - Use trace_devlink_hwmsg directly --- drivers/net/ethernet/mellanox/mlxsw/core

Re: [PATCH v8 01/11] bpf: add XDP prog type for early driver filter

2016-07-12 Thread Jakub Kicinski
On Tue, 12 Jul 2016 07:52:53 -0700, Tom Herbert wrote: > On Tue, Jul 12, 2016 at 6:14 AM, Jesper Dangaard Brouer > wrote: > > > > On Tue, 12 Jul 2016 00:51:24 -0700 Brenden Blanco > > wrote: > > > >> Add a new bpf prog type that is intended to run in early stages of the > >> packet rx path. On

Re: [PATCH v3] Marvell phy: add fiber status check and configuration for some phys

2016-07-12 Thread Andrew Lunn
> +#define LPA_FIBER_1000HALF 0x40 > +#define LPA_FIBER_1000FULL 0x20 > + > +#define LPA_PAUSE_FIBER 0x180 > +#define LPA_PAUSE_ASYM_FIBER 0x100 > + > +#define ADVERTISE_FIBER_1000HALF 0x40 > +#define ADVERTISE_FIBER_1000FULL 0x20 > + > +#define ADVERTISE_PAUSE_FIBER

[PATCH 1/1] net: nps_enet: Fix PCS reset

2016-07-12 Thread Elad Kanfi
From: Noam Camus During commit b54b8c2d6e3c ("net: ezchip: adapt driver to little endian architecture") adapting to little endian architecture, zeroing of controller was left out. Signed-off-by: Elad Kanfi --- drivers/net/ethernet/ezchip/nps_enet.c |1 + 1 files changed, 1 insertions(+)

[PATCH nf-next v2 1/3] netfilter: bridge: add and use br_nf_hook_thresh

2016-07-12 Thread Aaron Conole
From: Florian Westphal This replaces the last uses of NF_HOOK_THRESH(). Followup patch will remove it and rename nf_hook_thresh. The reason is that inet (non-bridge) netfilter no longer invokes the hooks from hooks, so we do no longer need the thresh value to skip hooks with a lower priority. T

[PATCH nf-next v2 2/3] netfilter: call nf_hook_state_init with rcu_read_lock held

2016-07-12 Thread Aaron Conole
From: Florian Westphal This makes things simpler because we can store the head of the list in the nf_state structure without worrying about concurrent add/delete of hook elements from the list. Signed-off-by: Florian Westphal Signed-off-by: Aaron Conole --- include/linux/netfilter.h

[PATCH nf-next v2 0/3] Compact netfilter hooks list

2016-07-12 Thread Aaron Conole
This series makes a simple change to shrink the netfilter hook list from a double linked list, to a singly linked list. Since the hooks are always traversed in-order, there is no need to maintain a previous pointer. This was jointly developed by Florian Westphal. It has been tested with RCU and

[PATCH v2 3/3] netfilter: replace list_head with single linked list

2016-07-12 Thread Aaron Conole
The netfilter hook list never uses the prev pointer, and so can be trimmed to be a smaller singly-linked list. In addition to having a more light weight structure for hook traversal, struct net becomes 5568 bytes (down from 6400) and struct net_device becomes 2176 bytes (down from 2240). Signed-o

[iproute PATCH v2] ip-macsec.8: fix typo in 'examples' section

2016-07-12 Thread Davide Caratti
fix wrong 'device' keyword in 'ip link add device eth0' changes since v1: while at it, add missing description of 'validate' keyword and remove spurious bracket near 'encrypt' keyword. Also, wrong 'es' and 'encoding' keywords in MACsec section of ip-link.8 have been fixed. Signed-off-by: Davide C

[PATCH -next] net: dsa: Fix non static symbol warning

2016-07-12 Thread weiyj_lk
From: Wei Yongjun Fixes the following sparse warning: net/dsa/dsa2.c:680:6: warning: symbol '_dsa_unregister_switch' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- net/dsa/dsa2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dsa/dsa2.c b/net/d

[PATCH v3] Marvell phy: add fiber status check and configuration for some phys

2016-07-12 Thread Charles-Antoine Couret
Hello, I'm back with another patch evrsion about Marvell phys with a fiber interface. >From the previous release, I fixed some issues reported by yours and I added >some functions around the fiber interface to get statistics, to configure the >aneg, etc. Yes, to implement that, copper and fiber s

  1   2   >