Le 12/07/2016 à 17:18, Andrew Lunn a écrit :
> Hi Charles
It's Charles-Antoine. ;)

> 
> It is best to submit a number of smaller patches, each doing one
> thing, than a single big patch. It makes review and discussion much
> simpler.
I'm sorry, I will fix that.


> So for example, this should be a patch of its own:
> 
>> @@ -151,6 +165,7 @@ struct marvell_hw_stat {
>>  
>>  static struct marvell_hw_stat marvell_hw_stats[] = {
>>      { "phy_receive_errors", 0, 21, 16},
>> +    { "phy_receive_errors_fiber", 1, 21, 16},
>>      { "phy_idle_errors", 0, 10, 8 },
>>  };
> 
> I think we should also rename phy_receive_errors to
> phy_receive_errors_copper.

I agree with you. I will fix that too.
Thanks.
Charles-Antoine Couret

Reply via email to