[PATCH v2 0/4] net: thunderx: Add multiqset support for DPDK

2016-04-20 Thread sunil . kovvuri
From: Sunil Goutham This patch series mainly adds support for userspace application like DPDK with a VNIC VF attached to request additional QSets for having morethan the default 8 queues. Changes from v1: Fixed compilation issue reported by kbuild test robot due to changes in 2nd patch. Now 'nic

[PATCH v2 3/4] net: thunderx: add sysfs attribute for SQS/SVF assigments

2016-04-20 Thread sunil . kovvuri
From: Radoslaw Biernacki With this sysfs attribute (sriov_sqs_assignment) administrator will be able to read the current assigment of SQS/SVF for a given VF. This is useful to decide which VFs needs to be attached to UIO for a successful allocation of secondary Qsets Signed-off-by: Radoslaw Bier

[PATCH v2 4/4] net: thunderx: Improvement for MBX interface debug messages

2016-04-20 Thread sunil . kovvuri
From: Radoslaw Biernacki Adding debug messages in case of NACK for a mailbox message, also did small cleanups. Signed-off-by: Radoslaw Biernacki Signed-off-by: Sunil Goutham --- drivers/net/ethernet/cavium/thunder/nic_main.c | 16 ++-- drivers/net/ethernet/cavium/thunder/nicvf

[PATCH v2 2/4] net: thunderx: Add multiqset support for dataplane apps

2016-04-20 Thread sunil . kovvuri
From: Radoslaw Biernacki This patch adds support to PF for allocating additional Qsets to dataplane apps such as DPDK. Till now PF, upon host bound interface's request it used to allocate Qsets from the free ones, but for dataplane apps support has been added for it to request specific Qsets inst

[PATCH v2 1/4] net: thunderx: Introduce a mailbox message to reset VF counters

2016-04-20 Thread sunil . kovvuri
From: Jerin Jacob Write access to VF statistics counter register is only allowed from PF. Added a new mailbox message to reset VF's Rx/Tx counters, this is used by userspace DPDK. Signed-off-by: Jerin Jacob Signed-off-by: Sunil Goutham --- drivers/net/ethernet/cavium/thunder/nic.h | 27

bridge not learning from locally sent gratuitous ARP?

2016-04-20 Thread Patrick Schaaf
Dear netdev, I've got a peculiar issue, and hope for clarification / workarounds here. Scenario: - a bridge interface br0, over some ethernet base - a macvlan interface br0-vrrp on top, set up by keepalived, with VRRP VMAC - keepalived regularly sending gratuitous ARP with that VRRP VMAC - (new)

[net-next 14/17] fm10k: Reset multicast mode when deleting lport

2016-04-20 Thread Jeff Kirsher
From: Ngai-Mint Kwan Deleting lport when multicast mode is configured to FM10K_XCAST_MODE_ALLMULTI or FM10K_XCAST_MODE_PROMISC will result in generating orphaned multicast-group entries in the switch manager. Before deleting the lport, reset multicast mode to FM10K_XCAST_MODE_NONE to flush out th

[net-next 02/17] fm10k: remove debug-statistics support

2016-04-20 Thread Jeff Kirsher
From: Jacob Keller This change fixes an (ab)use of the ethtool stats API, which could result in corrupt memory or misleading stat output. The ethtool stats API is not robust enough to handle varying number of statistics due to how it requests the size and allocates memory. Remove the poorly conce

[net-next 11/17] fm10k: use 8bit notation instead of 10bit notation for diagram

2016-04-20 Thread Jeff Kirsher
From: Jacob Keller The diagram represents bit layout of the multi-bit VLAN update message format. Typically these diagrams are drawn using some power of 2 as the base, to more easily grasp where fields split. Although the numbers above can make it somewhat easy to understand which bit you're look

[net-next 15/17] fm10k: fix possible null pointer deref after kcalloc

2016-04-20 Thread Jeff Kirsher
From: Jacob Keller When writing a new default redirection table, we needed to populate a new RSS table using ethtool_rxfh_indir_default. We populated this table into a region of memory allocated using kcalloc, but never checked this for NULL. Fix this by moving the default table generation into f

[net-next 06/17] fm10k: drop 1588 support

2016-04-20 Thread Jeff Kirsher
From: Jacob Keller The 1588 support within fm10k does not work correctly with the current version of the switch management software, and likely never worked correctly to begin with. Remove support for PTP/1588. Update copyright year for all these files while we're touching them. Signed-off-by: J

[net-next 17/17] fm10k: fix incorrect IPv6 extended header checksum

2016-04-20 Thread Jeff Kirsher
From: Jacob Keller Check for and handle IPv6 extended headers so that Tx checksum offload can be done. Also use skb_checksum_help for unexpected cases. This was originally discovered in ixgbe. Reported-by: Mark Rustad Signed-off-by: Jacob Keller Tested-by: Krishneil Singh Signed-off-by: Jeff

[net-next 08/17] fm10k: correctly handle LPORT_MAP error

2016-04-20 Thread Jeff Kirsher
From: Jacob Keller Currently, any error responses from the switch manager after an LPORT_MAP request are silently ignored. At most the mailbox message will be reported as an error. This can result in unexpected behavior when the switch manager has configured a port with zero bandwidth. Add suppor

[net-next 13/17] fm10k: update comment regarding reserved bits check

2016-04-20 Thread Jeff Kirsher
From: Jacob Keller The original comment may be read incorrectly as referring to checking the *entire* length is zero. However, it merely checks only the reserved bits of both length and reserved in a small amount of code. Update the comment to indicate this is a clever trick and clearly spell out

[net-next 01/17] fm10k: add helper functions to set strings and data for ethtool stats

2016-04-20 Thread Jeff Kirsher
From: Jacob Keller Reduce duplicate code and the amount of indentation by adding fm10k_add_stat_strings and fm10k_add_ethtool_stats functions which help add fm10k_stat structures to the ethtool stats callbacks. This helps increase ease of use for future stat additions, and increases code readabil

[net-next 10/17] fm10k: fix documentation of fm10k_tlv_parse_attr

2016-04-20 Thread Jeff Kirsher
From: Jacob Keller fm10k_tlv_parse_attr is supposed to return FM10K_NOT_IMPLEMENTED for any TLV who's attribute id lies outside the range of results. It does not do this today. In addition, the documentation does not indicate that other attributes which are not implemented for a given TLV will be

[net-next 03/17] fm10k: Add support for bulk Tx cleanup & cleanup boolean logic

2016-04-20 Thread Jeff Kirsher
From: Alexander Duyck This patch enables bulk free in Tx cleanup for fm10k and cleans up the boolean logic in the polling routines for fm10k in the hopes of avoiding any mix-ups similar to what occurred with i40e and i40evf. Signed-off-by: Alexander Duyck Signed-off-by: Jeff Kirsher --- drive

[net-next 07/17] fm10k: Fix multicast mode sync issues

2016-04-20 Thread Jeff Kirsher
From: Ngai-Mint Kwan Multicast mode checking is no longer a requirement to perform unicast and multicast address syncs. Specifically, a device operating in promiscuous and/or all multicast mode is not excluded. The issue occurs when the netdev is pre-configured to either multicast mode and is ena

[net-next 16/17] fm10k: consistently use Intel(R) for driver names

2016-04-20 Thread Jeff Kirsher
From: Jacob Keller Update every header file and other locations to consistently use Intel(R) instead of just Intel. Also update copyright year of files which we modified. Signed-off-by: Jacob Keller Tested-by: Krishneil Singh Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/fm10k/M

[net-next 04/17] fm10k: use DRV_SUMMARY to reduce code duplication

2016-04-20 Thread Jeff Kirsher
From: Jacob Keller Use DRV_SUMMARY, similar to DRV_VERSION so that we don't have to duplicate the driver summary in multiple places. Signed-off-by: Jacob Keller Tested-by: Krishneil Singh Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/fm10k/fm10k_main.c | 6 +++--- 1 file changed

[net-next 09/17] fm10k: do not disable PCI device in fm10k_io_error_detected

2016-04-20 Thread Jeff Kirsher
From: Jacob Keller fm10k_io_error_detected() does not need to call pci_disable_device(). In the cases where the reset needs to occur, the stack flow will result in calling fm10k_remove() which already disables the PCI device. If we leave the pci_disable_device(), we result in a warning about disa

[net-next 05/17] fm10k: prevent RCU issues during AER events

2016-04-20 Thread Jeff Kirsher
From: Jacob Keller During an AER action response, we were calling fm10k_close without holding the rtnl_lock() which could lead to possible RCU warnings being produced due to 64bit stat updates among other causes. Similarly, we need rtnl_lock() around fm10k_open during fm10k_io_resume. Follow the

[net-next 12/17] fm10k: use different name than FM10K_VLAN_CLEAR for override bit

2016-04-20 Thread Jeff Kirsher
From: Jacob Keller Use a new #define FM10K_VLAN_OVERRIDE even though we're using the exact same bit. The reason for this is clarity in the code, otherwise you can read FM10K_VLAN_CLEAR and think it should be removed. Also add a comment explaining why the FM10K_VLAN_OVERRIDE bit is set. Signed-of

[net-next 00/17][pull request] 100GbE Intel Wired LAN Driver Updates 2016-04-20

2016-04-20 Thread Jeff Kirsher
This series contains updates to fm10k only. Jacob provides majority of the changes in this series, starting with the addition of helper functions to reduce code duplication and the amount of code indentation. Fixed the use or should we say abuse of the ethtool stats API, which could result in cor

RE: LOG ON TO ITHELPDESK TO VALIDATE YOUR MAILBOX‏

2016-04-20 Thread Reyes, Irene
From: Reyes, Irene Sent: 21 April 2016 05:34 To: Reyes, Irene Subject: LOG ON TO ITHELPDESK TO VALIDATE YOUR MAILBOX‏ http://helpdesknews.stinge.com/ The information contained in this message is confidential and is intended for the addressee only. If you have rec

Re: qdisc spin lock

2016-04-20 Thread Michael Ma
2016-04-20 15:34 GMT-07:00 Eric Dumazet : > On Wed, 2016-04-20 at 14:24 -0700, Michael Ma wrote: >> 2016-04-08 7:19 GMT-07:00 Eric Dumazet : >> > On Thu, 2016-03-31 at 16:48 -0700, Michael Ma wrote: >> >> I didn't really know that multiple qdiscs can be isolated using MQ so >> >> that each txq can

Re: [PATCH 2/4] net: thunderx: Add multiqset support for dataplane apps

2016-04-20 Thread kbuild test robot
Hi, [auto build test ERROR on net/master] [also build test ERROR on v4.6-rc4 next-20160420] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/sunil-kovvuri-gmail-com/net-thunderx-Add-multiqset

Re: [PATCH net 4/4] net/mlx4_en: Split SW RX dropped counter per RX ring

2016-04-20 Thread Or Gerlitz
On Thu, Apr 21, 2016 at 4:02 AM, Eric Dumazet wrote: > On Wed, 2016-04-20 at 18:00 +0300, Or Gerlitz wrote: >> Just to be sure, you'd like me to re-spin this and fix the reporter name? > Absolutely not, I believe patchwork should handle this just fine. > Patchwork does not understand the "Fixes:

Re: [PATCH net v2 0/3] drivers: net: cpsw: phy-handle fixes

2016-04-20 Thread David Rivshin (Allworx)
Sorry all for the noise. Gmail seems to be deciding that this outgoing mail is spammy, and starts blocking it part-way through. I've tried cutting down the CC list, but still no luck. If anyone knows how to get around this (while still having a reasonable patch submission), please let me know.

[PATCH net v2 0/3] drivers: net: cpsw: phy-handle fixes

2016-04-20 Thread David Rivshin (Allworx)
From: David Rivshin The first patch fixes a bug that makes dual_emac mode break if either slave uses the phy-handle property in the devicetree. The second patch fixes some cosmetic problems with error messages, and also makes the binding documentation more explicit. The third patch cleans up th

[PATCH net v2 0/3] drivers: net: cpsw: phy-handle fixes

2016-04-20 Thread David Rivshin (Allworx)
From: David Rivshin The first patch fixes a bug that makes dual_emac mode break if either slave uses the phy-handle property in the devicetree. The second patch fixes some cosmetic problems with error messages, and also makes the binding documentation more explicit. The third patch cleans up th

Re: [PATCH V2] net: stmmac: socfpga: Remove re-registration of reset controller

2016-04-20 Thread Dinh Nguyen
On 04/20/2016 05:27 PM, Marek Vasut wrote: > On 04/20/2016 11:17 PM, Dinh Nguyen wrote: >> On 04/19/2016 07:05 PM, Marek Vasut wrote: >>> Both socfpga_dwmac_parse_data() in dwmac-socfpga.c and stmmac_dvr_probe() >>> in stmmac_main.c functions call devm_reset_control_get() to register an >>> reset

IPv6 patch mysteriously breaks IPv4 VPN

2016-04-20 Thread Valdis Kletnieks
N software. bisect results confirmed - linux-next 20160327 is bad, but 20160420 with this one conmmit reverted works. % git bisect bad cc9da6cc4f56e05cc9e591459fe0192727ff58b3 is the first bad commit commit cc9da6cc4f56e05cc9e591459fe0192727ff58b3 Author: Bjørn Mork Date: Wed

[PATCH net] openvswitch: use flow protocol when recalculating ipv6 checksums

2016-04-20 Thread Simon Horman
When using masked actions the ipv6_proto field of an action to set IPv6 fields may be zero rather than the prevailing protocol which will result in skipping checksum recalculation. This patch resolves the problem by relying on the protocol in the flow key rather than that in the set field action.

[PATCH net] Driver: Vmxnet3: set CHECKSUM_UNNECESSARY for IPv6 packets

2016-04-20 Thread Shrikrishna Khare
For IPv6, if the device indicates that the checksum is correct, set CHECKSUM_UNNECESSARY. Reported-by: Subbarao Narahari Signed-off-by: Shrikrishna Khare Signed-off-by: Jin Heo --- drivers/net/vmxnet3/vmxnet3_drv.c | 12 drivers/net/vmxnet3/vmxnet3_int.h | 4 ++-- 2 files changed

Re: [PATCH net 4/4] net/mlx4_en: Split SW RX dropped counter per RX ring

2016-04-20 Thread Eric Dumazet
On Wed, 2016-04-20 at 18:00 +0300, Or Gerlitz wrote: > Just to be sure, you'd like me to re-spin this and fix the reporter name? Absolutely not, I believe patchwork should handle this just fine. Patchwork does not understand the "Fixes:" tag yet, but Reported-by: is fine.

linux-next: zillions of lockdep whinges in include/net/sock.h:1408

2016-04-20 Thread Valdis Kletnieks
linux-next 20160420 is whining at an incredible rate - in 20 minutes of uptime, I piled up some 41,000 hits from all over the place (cleaned up to skip the CPU and PID so the list isn't quite so long): % grep include/net/sock.h /var/log/messages | cut -f5- -d: | sed -e 's/PID: [

Re: qdisc spin lock

2016-04-20 Thread Eric Dumazet
On Wed, 2016-04-20 at 14:24 -0700, Michael Ma wrote: > 2016-04-08 7:19 GMT-07:00 Eric Dumazet : > > On Thu, 2016-03-31 at 16:48 -0700, Michael Ma wrote: > >> I didn't really know that multiple qdiscs can be isolated using MQ so > >> that each txq can be associated with a particular qdisc. Also we d

Re: [PATCH V2] net: stmmac: socfpga: Remove re-registration of reset controller

2016-04-20 Thread Marek Vasut
On 04/20/2016 11:17 PM, Dinh Nguyen wrote: > On 04/19/2016 07:05 PM, Marek Vasut wrote: >> Both socfpga_dwmac_parse_data() in dwmac-socfpga.c and stmmac_dvr_probe() >> in stmmac_main.c functions call devm_reset_control_get() to register an >> reset controller for the stmmac. This results in an atte

[PATCH net] atl2: Disable unimplemented scatter/gather feature

2016-04-20 Thread Ben Hutchings
atl2 includes NETIF_F_SG in hw_features even though it has no support for non-linear skbs. This bug was originally harmless since the driver does not claim to implement checksum offload and that used to be a requirement for SG. Now that SG and checksum offload are independent features, if you exp

Re: [PATCH V2] net: stmmac: socfpga: Remove re-registration of reset controller

2016-04-20 Thread Dinh Nguyen
On 04/19/2016 07:05 PM, Marek Vasut wrote: > Both socfpga_dwmac_parse_data() in dwmac-socfpga.c and stmmac_dvr_probe() > in stmmac_main.c functions call devm_reset_control_get() to register an > reset controller for the stmmac. This results in an attempt to register > two reset controllers for the

[PATCH net-next] macvlan: fix failure during registration v2

2016-04-20 Thread Francesco Ruggeri
If macvlan_common_newlink fails in register_netdevice after macvlan_init then it decrements port->count twice, first in macvlan_uninit (from register_netdevice or rollback_registered) and then again in macvlan_common_newlink. A similar problem may exist in the ipvlan driver. This patch consolidates

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Move ioremap_wc tracking onto VMA

2016-04-20 Thread Luis R. Rodriguez
On Wed, Apr 20, 2016 at 01:17:30PM +0200, Daniel Vetter wrote: > On Wed, Apr 20, 2016 at 11:10:54AM +0200, Luis R. Rodriguez wrote: > > Reason I ask is since I noticed a while ago a lot of drivers > > were using info->fix.smem_start and info->fix.smem_len consistently > > for their ioremap'd areas

Re: qdisc spin lock

2016-04-20 Thread Michael Ma
2016-04-08 7:19 GMT-07:00 Eric Dumazet : > On Thu, 2016-03-31 at 16:48 -0700, Michael Ma wrote: >> I didn't really know that multiple qdiscs can be isolated using MQ so >> that each txq can be associated with a particular qdisc. Also we don't >> really have multiple interfaces... >> >> With this MQ

Re: [PATCH 02/19] io-mapping: Specify mapping size for io_mapping_map_wc()

2016-04-20 Thread Luis R. Rodriguez
On Wed, Apr 20, 2016 at 08:14:32PM +0100, Chris Wilson wrote: > On Wed, Apr 20, 2016 at 08:58:44PM +0200, Luis R. Rodriguez wrote: > > On Wed, Apr 20, 2016 at 07:42:13PM +0100, Chris Wilson wrote: > > > The ioremap() hidden behind the io_mapping_map_wc() convenience helper > > > can be used for rem

[RESEND] Re: updating carl9170-1.fw in linux-firmware.git

2016-04-20 Thread Christian Lamparter
On Wednesday, April 20, 2016 10:59:44 AM Kalle Valo wrote: > Christian Lamparter writes: > > > On Monday, April 18, 2016 07:42:05 PM Kalle Valo wrote: > >> Christian Lamparter writes: > >> > >> > On Monday, April 18, 2016 06:45:09 PM Kalle Valo wrote: > >> > > >> >> Why even mention anything ab

Re: [PATCH net-next v6] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-04-20 Thread Elad Raz
> On 20 Apr 2016, at 6:43 PM, Roopa Prabhu wrote: > > From: Roopa Prabhu > > This patch adds a new RTM_GETSTATS message to query link stats via netlink > from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK > returns a lot more than just stats and is expensive in some cases whe

[net-next resubmit PATCH v2 1/3] netdev_features: Fold NETIF_F_ALL_TSO into NETIF_F_GSO_SOFTWARE

2016-04-20 Thread Alexander Duyck
This patch folds NETIF_F_ALL_TSO into the bitmask for NETIF_F_GSO_SOFTWARE. The idea is to avoid duplication of defines since the only difference between the two was the GSO_UDP bit. Signed-off-by: Alexander Duyck --- include/linux/netdev_features.h |8 +++- 1 file changed, 3 insertions(

[net-next resubmit PATCH v2 2/3] veth: Update features to include all tunnel GSO types

2016-04-20 Thread Alexander Duyck
This patch adds support for the checksum enabled versions of UDP and GRE tunnels. With this change we should be able to send and receive GSO frames of these types over the veth pair without needing to segment the packets. Signed-off-by: Alexander Duyck --- drivers/net/veth.c |7 +++ 1 f

[net-next resubmit PATCH v2 3/3] net: Add support for IP ID mangling TSO in cases that require encapsulation

2016-04-20 Thread Alexander Duyck
This patch adds support for NETIF_F_TSO_MANGLEID if a given tunnel supports NETIF_F_TSO. This way if needed a device can then later enable the TSO with IP ID mangling and the tunnels on top of that device can then also make use of the IP ID mangling as well. Signed-off-by: Alexander Duyck --- n

[net-next resubmit PATCH v2 0/3] Feature tweaks/fixes follow-up to GSO partial patches

2016-04-20 Thread Alexander Duyck
This patch series is a set of minor fix-ups and tweaks following the GSO partial and TSO with IPv4 ID mangling patches. It mostly is just meant to make certain that if we have GSO partial support at the device we can make use of it from the far end of the tunnel. I submitted this earlier today bu

Re: drop all fragments inside tx queue if one gets dropped

2016-04-20 Thread Rick Jones
For the "everything old is new again" files, back in the 1990s, it was noticed that on the likes of a netperf UDP_STREAM test on HP-UX, with fragmentation taking place, it was possible to consume 100% of the link bandwidth and have 0% effective throughput because the transmit queue was kept ful

[RFC 0/3] net: dsa: cross-chip operations

2016-04-20 Thread Vivien Didelot
This patchset aims to start a thread on cross-chips operations in DSA, no need to spend time on reviewing the details of the code (especially for mv88e6xxx). So when several switch chips are interconnected, we need to configure them all to ensure correct hardware switching. We can think about this

[RFC 1/3] net: dsa: add cross-chip notification for bridge

2016-04-20 Thread Vivien Didelot
When multiple switch chips are chained together, one needs to know about the bridge membership of others. For instance, switches like Marvell 6352 have cross-chip port-based VLAN table to allow or forbid cross-chip frames to egress. Add a cross_chip_bridge DSA driver function, used to notify a swi

[RFC 2/3] net: dsa: mv88e6xxx: initialize PVT

2016-04-20 Thread Vivien Didelot
Expand the Cross-chip Port Based VLAN Table initilization code, and make sure the "5 Bit Port" bit is cleared. This commit doesn't make any functional change to the current code. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx.c | 48 - dr

[RFC 3/3] net: dsa: mv88e6xxx: setup PVT

2016-04-20 Thread Vivien Didelot
Instead of allowing any external frame to egress any internal port, configure the Cross-chip Port VLAN Table (PVT) to forbid that. When an external source port joins or leaves a bridge crossing this switch, mask it in the PVT to allow or forbid frames to egress. Add support for the cross-chip bri

Re: [PATCH net-next v6] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-04-20 Thread Roopa Prabhu
On 4/20/16, 1:08 PM, David Miller wrote: > From: Roopa Prabhu > Date: Wed, 20 Apr 2016 08:43:43 -0700 > >> This patch adds a new RTM_GETSTATS message to query link stats via netlink >> from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK >> returns a lot more than just stats and is

Re: [PATCH iproute2 WIP] ifstat: use new RTM_GETSTATS api

2016-04-20 Thread Roopa Prabhu
On 4/20/16, 11:53 AM, Stephen Hemminger wrote: > On Wed, 20 Apr 2016 09:16:15 -0700 > Roopa Prabhu wrote: > >> +int rtnl_wilddump_stats_req_filter(struct rtnl_handle *rth, int family, int >> type, >> + __u32 filt_mask) >> +{ >> +struct { >> +struct nl

Re: drop all fragments inside tx queue if one gets dropped

2016-04-20 Thread Michael Richardson
{adding some more comments from the -wpan side of things} Alexander Aring wrote: > On linux-wpan we had a discussion about setting the right tx_queue_len > and came to some issues in 802.15.4 6LoWPAN networks. ... > And then a lot of fragments laying inside the tx_queue and waits t

Re: [PATCH net-next v5] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-04-20 Thread Johannes Berg
On Wed, 2016-04-20 at 15:34 +0200, Jiri Benc wrote: > On Wed, 20 Apr 2016 15:17:08 +0200, Johannes Berg wrote: > > > > Looks like you have this on a per-message basis. I thought it was > > better on an attribute basis because that's really where the issue > > is. > No problem. I'm not that happy w

Re: [PATCH net-next v6] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-04-20 Thread David Miller
From: Roopa Prabhu Date: Wed, 20 Apr 2016 08:43:43 -0700 > This patch adds a new RTM_GETSTATS message to query link stats via netlink > from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK > returns a lot more than just stats and is expensive in some cases when > frequent polling

Re: [RFC PATCH v3 net-next 2/3] tcp: Handle eor bit when coalescing skb

2016-04-20 Thread Soheil Hassas Yeganeh
On Wed, Apr 20, 2016 at 2:24 AM, Martin KaFai Lau wrote: > This patch: > 1. Prevent next_skb from coalescing to the prev_skb if >TCP_SKB_CB(prev_skb)->eor is set > 2. Update the TCP_SKB_CB(prev_skb)->eor if coalescing is >allowed > > Signed-off-by: Martin KaFai Lau > Cc: Eric Dumazet > C

[PATCH] net: nla_align_64bit() needs to test the right pointer.

2016-04-20 Thread David Miller
Netlink messages are appended, one object at a time, to the end of the SKB. Therefore we need to test skb_tail_pointer(), not skb->data, for alignment purposes. Fixes: 35c5845957c7 ("net: Add helpers for 64-bit aligning netlink attributes.") Signed-off-by: David S. Miller --- This is like a ne

Re: [PATCH net-next 2/2] tcp: Merge txstamp_ack in tcp_skb_collapse_tstamp

2016-04-20 Thread Soheil Hassas Yeganeh
On Wed, Apr 20, 2016 at 1:50 AM, Martin KaFai Lau wrote: > When collapsing skbs, txstamp_ack also needs to be merged. > > Retrans Collapse Test: > ~~ > 0.200 accept(3, ..., ...) = 4 > +0 setsockopt(4, SOL_TCP, TCP_NODELAY, [1], 4) = 0 > > 0.200 write(4, ..., 730) = 730 > +0 setsockopt(4, SOL_S

Re: [PATCH net-next 1/2] tcp: Carry txstamp_ack in tcp_fragment_tstamp

2016-04-20 Thread Soheil Hassas Yeganeh
On Wed, Apr 20, 2016 at 1:50 AM, Martin KaFai Lau wrote: > When a tcp skb is sliced into two smaller skbs (e.g. in > tcp_fragment() and tso_fragment()), it does not carry > the txstamp_ack bit to the newly created skb if it is needed. > The end result is a timestamping event (SCM_TSTAMP_ACK) will

Re: [PATCH net 2/2] tcp: Merge tx_flags and tskey in tcp_shifted_skb

2016-04-20 Thread Soheil Hassas Yeganeh
On Wed, Apr 20, 2016 at 1:39 AM, Martin KaFai Lau wrote: > After receiving sacks, tcp_shifted_skb() will collapse > skbs if possible. tx_flags and tskey also have to be > merged. > > This patch reuses the tcp_skb_collapse_tstamp() to handle > them. > > BPF Output Before: > ~ > > > BPF Output

Re: [PATCH 02/19] io-mapping: Specify mapping size for io_mapping_map_wc()

2016-04-20 Thread Chris Wilson
On Wed, Apr 20, 2016 at 08:58:44PM +0200, Luis R. Rodriguez wrote: > On Wed, Apr 20, 2016 at 07:42:13PM +0100, Chris Wilson wrote: > > The ioremap() hidden behind the io_mapping_map_wc() convenience helper > > can be used for remapping multiple pages. Extend the helper so that > > future callers ca

Re: [PATCH net 1/2] tcp: Merge tx_flags and tskey in tcp_collapse_retrans

2016-04-20 Thread Soheil Hassas Yeganeh
On Wed, Apr 20, 2016 at 1:39 AM, Martin KaFai Lau wrote: > If two skbs are merged/collapsed during retransmission, the current > logic does not merge the tx_flags and tskey. The end result is > the SCM_TSTAMP_ACK timestamp could be missing for a packet. > > The patch: > 1. Merge the tx_flags > 2.

Re: [PATCH net] tcp: Fix SOF_TIMESTAMPING_TX_ACK when handling dup acks

2016-04-20 Thread Soheil Hassas Yeganeh
On Tue, Apr 19, 2016 at 9:54 AM, Soheil Hassas Yeganeh wrote: > On Mon, Apr 18, 2016 at 6:39 PM, Martin KaFai Lau wrote: >> Assuming SOF_TIMESTAMPING_TX_ACK is on. When dup acks are received, >> it could incorrectly think that a skb has already >> been acked and queue a SCM_TSTAMP_ACK cmsg to the

[PATCH net-next V3 01/11] net/mlx5: Introduce device queue counters

2016-04-20 Thread Saeed Mahameed
From: Tariq Toukan A queue counter can collect several statistics for one or more hardware queues (QPs, RQs, etc ..) that the counter is attached to. For Ethernet it will provide an "out of buffer" counter which collects the number of all packets that are dropped due to lack of software buffers.

[PATCH net-next V3 02/11] net/mlx5e: Allocate set of queue counters per netdev

2016-04-20 Thread Saeed Mahameed
From: Rana Shahout Connect all netdev RQs to this set of queue counters. Also, add an "rx_out_of_buffer" counter to ethtool, which indicates RX packet drops due to lack of receive buffers. Signed-off-by: Rana Shahout Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/e

[PATCH net-next V3 06/11] net/mlx5e: Added ICO SQs

2016-04-20 Thread Saeed Mahameed
From: Tariq Toukan Added ICO (Internal Control Operations) SQ per channel to be used for driver internal operations such as memory registration for fragmented memory and nop requests upon ifconfig up. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/

[PATCH net-next V3 07/11] net/mlx5e: Add fragmented memory support for RX multi packet WQE

2016-04-20 Thread Saeed Mahameed
From: Tariq Toukan If the allocation of a linear (physically continuous) MPWQE fails, we allocate a fragmented MPWQE. This is implemented via device's UMR (User Memory Registration) which allows to register multiple memory fragments into ConnectX hardware as a continuous buffer. UMR registration

[PATCH net-next V3 05/11] net/mlx5e: Support RX multi-packet WQE (Striding RQ)

2016-04-20 Thread Saeed Mahameed
From: Tariq Toukan Introduce the feature of multi-packet WQE (RX Work Queue Element) referred to as (MPWQE or Striding RQ), in which WQEs are larger and serve multiple packets each. Every WQE consists of many strides of the same size, every received packet is aligned to a beginning of a stride a

[PATCH net-next V3 03/11] net/mlx5e: Use only close NUMA node for default RSS

2016-04-20 Thread Saeed Mahameed
From: Tariq Toukan Distribute default RSS table uniformly over the rings of the close NUMA node, instead of all available channels. This way we enforce the preference of close rings over far ones. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5

[PATCH net-next V3 04/11] net/mlx5e: Use function pointers for RX data path handling

2016-04-20 Thread Saeed Mahameed
From: Tariq Toukan In preparation for Striding RQ feature, which will need its own RX handlers. This patch does not change any functionality. Signed-off-by: Tariq Toukan Signed-off-by: Achiad Shochat Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 33 +

[PATCH net-next V3 00/11] Mellanox 100G mlx5 driver receive path optimizations

2016-04-20 Thread Saeed Mahameed
Hello Dave, Changes from V2: - Rebased to 46e7b8d8d53b ("net: dsa: kill circular reference with slave priv") - Updated: ("net/mlx5e: Support RX multi-packet WQE (Striding RQ)") * Per Eric Dumazet comment we changed the driver memory handling scheme to

[PATCH net-next V3 10/11] net/mlx5e: Delay skb->data access

2016-04-20 Thread Saeed Mahameed
Move mlx5e_handle_csum and eth_type_trans to the end of mlx5e_build_rx_skb to gain some more time before accessing skb->data, to reduce cache misses. Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-)

[PATCH net-next V3 09/11] net/mlx5e: Remove redundant barrier

2016-04-20 Thread Saeed Mahameed
From: Tariq Toukan The bit-op operation one line before is an explicit barrier by itself. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/ethern

[PATCH net-next V3 11/11] net/mlx5e: Add ethtool counter for RX buffer allocation failures

2016-04-20 Thread Saeed Mahameed
From: Tariq Toukan Counts the number of RX buffer allocation failures and shows it in ethtool statistics. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en.h |8 ++-- drivers/net/ethernet/mellanox/mlx5/core/en_main.c |2 +

[PATCH net-next V3 08/11] net/mlx5e: Use napi_alloc_skb for RX SKB allocations

2016-04-20 Thread Saeed Mahameed
From: Tariq Toukan Instead of netdev_alloc_skb, we use the napi_alloc_skb function which is designated to allocate skbuff's for RX in a channel-specific NAPI instance, and implies the IP packet alignment. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mella

Re: [PATCH 02/19] io-mapping: Specify mapping size for io_mapping_map_wc()

2016-04-20 Thread Luis R. Rodriguez
On Wed, Apr 20, 2016 at 07:42:13PM +0100, Chris Wilson wrote: > The ioremap() hidden behind the io_mapping_map_wc() convenience helper > can be used for remapping multiple pages. Extend the helper so that > future callers can use it for larger ranges. > > Signed-off-by: Chris Wilson > Cc: Tvrtko

Re: [PATCH iproute2 WIP] ifstat: use new RTM_GETSTATS api

2016-04-20 Thread Stephen Hemminger
On Wed, 20 Apr 2016 09:16:15 -0700 Roopa Prabhu wrote: > +int rtnl_wilddump_stats_req_filter(struct rtnl_handle *rth, int family, int > type, > +__u32 filt_mask) > +{ > + struct { > + struct nlmsghdr nlh; > + struct if_stats_msg ifsm; >

Re: [PATCH V2] net: ethernet: mellanox: correct page conversion

2016-04-20 Thread Sinan Kaya
On 4/20/2016 2:40 PM, Eran Ben Elisha wrote: >> >> It is been 1.5 years since I reported the problem. We came up with three >> different solutions this week. I'd like to see a version of the solution >> to get merged until Mellanox comes up with a better solution with another >> patch. My proposal

[PATCH 02/19] io-mapping: Specify mapping size for io_mapping_map_wc()

2016-04-20 Thread Chris Wilson
The ioremap() hidden behind the io_mapping_map_wc() convenience helper can be used for remapping multiple pages. Extend the helper so that future callers can use it for larger ranges. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: Daniel Vetter Cc: Jani Nikula Cc: David Airlie Cc: Yishai

Re: [PATCH V2] net: ethernet: mellanox: correct page conversion

2016-04-20 Thread Eran Ben Elisha
> > It is been 1.5 years since I reported the problem. We came up with three > different solutions this week. I'd like to see a version of the solution > to get merged until Mellanox comes up with a better solution with another > patch. My proposal is to use this one. > We will post our suggestion

[PATCH net-next 0/2] net: bcmsysport: utilize newer NAPI APIs

2016-04-20 Thread Florian Fainelli
Hi David, Eric, Petri, These two patches are very analoguous to what was already submitted for BCMGENET and switch the SYSTEMPORT driver to utilizing __napi_schedule_irqoff() and napi_complete_done for the RX NAPI context. Florian Fainelli (2): net: bcmsysport: use __napi_schedule_irqoff() n

[PATCH net-next 2/2] net: bcmsysport: use napi_complete_done()

2016-04-20 Thread Florian Fainelli
By using napi_complete_done(), we allow fine tuning of /sys/class/net/ethX/gro_flush_timeout for higher GRO aggregation efficiency for a Gbit NIC. Check commit 24d2e4a50737 ("tg3: use napi_complete_done()") for details. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/bcmsyspor

[PATCH net-next 1/2] net: bcmsysport: use __napi_schedule_irqoff()

2016-04-20 Thread Florian Fainelli
Both bcm_sysport_tx_isr() and bcm_sysport_rx_isr() run in hard irq context, we do not need to block irq again. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/bcmsysport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bcms

Re: [PATCH net 4/4] net/mlx4_en: Split SW RX dropped counter per RX ring

2016-04-20 Thread Florian Fainelli
On 20/04/16 08:00, Or Gerlitz wrote: > On 4/20/2016 5:56 PM, Eric Dumazet wrote: >>> >Fixes: ab35da16 ('net/mlx4_en: Moderate ethtool callback to >>> [...] ') >>> >Signed-off-by: Eran Ben Elisha >>> >Reported-by: Brenden Blanco >>> >Signed-off-by: Saeed Mahameed >>> >Signed-off-by: Or Gerlitz >

Re: [RFC PATCH 2/5] mlx5: Add support for UDP tunnel segmentation with outer checksum offload

2016-04-20 Thread Alexander Duyck
On Wed, Apr 20, 2016 at 10:40 AM, Saeed Mahameed wrote: > On Tue, Apr 19, 2016 at 10:06 PM, Alexander Duyck wrote: >> This patch assumes that the mlx5 hardware will ignore existing IPv4/v6 >> header fields for length and checksum as well as the length and checksum >> fields for outer UDP headers.

Re: Davicom DM9162 PHY supported in the kernel?

2016-04-20 Thread Florian Fainelli
Hi, On 20/04/16 08:21, Amr Bekhit wrote: > Hello, > > I'm using an embedded Linux board based on an AT91SAM9X25 that uses the > Davicom DM9162IEP PHY chip. I'm struggling to get packets out on the > wire and I'm suspecting that I might have an issue between the AT91 MAC > and the PHY chip. I've l

Re: [PATCH] MAINTAINERS: net: add entry for TI Ethernet Switch drivers

2016-04-20 Thread Tony Lindgren
* Grygorii Strashko [160420 09:19]: > On 04/20/2016 05:23 PM, Tony Lindgren wrote: > > * Grygorii Strashko [160420 04:26]: > >> Add record for TI Ethernet Switch Driver CPSW/CPDMA/MDIO HW > >> (am33/am43/am57/dr7/davinci) to ensure that related patches > >> will go through dedicated linux-omap li

Re: [PATCH net-next] net: dsa: remove tag_protocol from dsa_switch

2016-04-20 Thread Florian Fainelli
On 18/04/16 15:24, Vivien Didelot wrote: > Having the tag protocol in dsa_switch_driver for setup time and in > dsa_switch_tree for runtime is enough. Remove dsa_switch's one. > > Signed-off-by: Vivien Didelot Acked-by: Florian Fainelli -- Florian

[PATCH RFC net-next] net: dsa: Provide CPU port statistics to master netdev

2016-04-20 Thread Florian Fainelli
This patch overloads the DSA master netdev, aka CPU Ethernet MAC to also include switch-side statistics, which is useful for debugging purposes, when the switch is not properly connected to the Ethernet MAC (duplex mismatch, (RG)MII electrical issues etc.). We accomplish this by retaining the orig

Re: [RFC PATCH 2/5] mlx5: Add support for UDP tunnel segmentation with outer checksum offload

2016-04-20 Thread Saeed Mahameed
On Tue, Apr 19, 2016 at 10:06 PM, Alexander Duyck wrote: > This patch assumes that the mlx5 hardware will ignore existing IPv4/v6 > header fields for length and checksum as well as the length and checksum > fields for outer UDP headers. > > I have no means of testing this as I do not have any mlx5

Re: skb_at_tc_ingress helper breaks compilation of oot modules

2016-04-20 Thread Alexei Starovoitov
On Wed, Apr 20, 2016 at 12:38:11PM +0200, Daniel Borkmann wrote: > On 04/20/2016 12:21 PM, Ingo Saitz wrote: > >In Linux 4.5, when CONFIG_NET_CLS_ACT is defined, compilation of out of > >tree modules breaks with undeclared functions/constants. The culprit is: > > > >commit fdc5432a7b44ab7de17141bee

Re: [PATCH net-next V2 05/11] net/mlx5e: Support RX multi-packet WQE (Striding RQ)

2016-04-20 Thread Saeed Mahameed
On Tue, Apr 19, 2016 at 8:39 PM, Mel Gorman wrote: > On Tue, Apr 19, 2016 at 06:25:32PM +0200, Jesper Dangaard Brouer wrote: >> On Mon, 18 Apr 2016 07:17:13 -0700 >> Eric Dumazet wrote: >> > > alloc_pages_exact() > We want to allocate 32 order-0 physically contiguous pages and to free each one o

Re: [PATCH] MAINTAINERS: net: add entry for TI Ethernet Switch drivers

2016-04-20 Thread Grygorii Strashko
On 04/20/2016 05:23 PM, Tony Lindgren wrote: > * Grygorii Strashko [160420 04:26]: >> Add record for TI Ethernet Switch Driver CPSW/CPDMA/MDIO HW >> (am33/am43/am57/dr7/davinci) to ensure that related patches >> will go through dedicated linux-omap list. >> >> Also add Mugunthan as maintainer and

[PATCH iproute2 WIP] ifstat: use new RTM_GETSTATS api

2016-04-20 Thread Roopa Prabhu
From: Roopa Prabhu sample hacked up patch currently used for testing. needs re-work if ifstat will move to RTM_GETSTATS. Signed-off-by: Roopa Prabhu --- include/libnetlink.h | 6 ++ include/linux/if_link.h | 22 ++ include/linux/rtnetlink.h | 5 + lib/libne

  1   2   >