On Wed, Apr 20, 2016 at 12:38:11PM +0200, Daniel Borkmann wrote: > On 04/20/2016 12:21 PM, Ingo Saitz wrote: > >In Linux 4.5, when CONFIG_NET_CLS_ACT is defined, compilation of out of > >tree modules breaks with undeclared functions/constants. The culprit is: > > > >commit fdc5432a7b44ab7de17141beec19d946b9344e91 > >Author: Daniel Borkmann <dan...@iogearbox.net> > >Date: Thu Jan 7 15:50:22 2016 +0100 > > > > net, sched: add skb_at_tc_ingress helper > > > >which uses G_TC_AT and AT_INGRESS but only includes linux/pkt_cls.h, > >which does not include these #defines for oot builds. Unfortunately I'm > >not sure what the correct fix is, maybe the uapi folks could help, but i > >attached a simple testcase and build log (Makefile is straight from > >kernelnewbies). > > Hmm, your fail.c test case only contains '#include <net/ipv6.h>'? > > Note, upstream kernel never cared about out-of-tree modules, only > in-tree code. ;) Did you run into an issue with any in-tree code?
I'm glad it broke out of tree module. We should do it more often. llvm constantly reshuffles internal api to incentivize upstreaming and working with the community.
