RE: [PATCH net v2] r8169:fix "rtl_counters_cond == 1 (loop: 1000, delay: 10)" log spam.

2016-02-22 Thread Hau
> Nits: > > - the tp->TxDescArray test provides the required synchronization: see > rtl8169_{open/close} and their pm_runtime_{get / put}. > > - ioaddr is not really needed : tp->mmio_addr appears only once and it does > not mess the 72..80 cols limit. > > - even if the device can only be au

Re: [patch net-next 1/9] Introduce devlink infrastructure

2016-02-22 Thread Jiri Pirko
Mon, Feb 22, 2016 at 11:29:06PM CET, ro...@cumulusnetworks.com wrote: >On 2/22/16, 10:31 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Introduce devlink infrastructure for drivers to register and expose to >> userspace via generic Netlink interface. >> >> There are two basic objects defined: >>

Re: [patch net-next 0/9] Introduce devlink interface and first drivers to use it

2016-02-22 Thread Jiri Pirko
Tue, Feb 23, 2016 at 06:12:15AM CET, go...@cumulusnetworks.com wrote: >On Mon, Feb 22, 2016 at 07:31:55PM +0100, Jiri Pirko wrote: >> From: Jiri Pirko >> >> There a is need for some userspace API that would allow to expose things >> that are not directly related to any device class like net_devic

Re: [net-next PATCH 0/5] net_sched: Add support for IFE action

2016-02-22 Thread Cong Wang
On Mon, Feb 22, 2016 at 5:21 AM, Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > > > As agreed at netconf in Seville, here's the patch finally (1 year > was just too long to wait). > Described in netdev01 paper: > "Distributing Linux Traffic Control Classifier-Action Subsystem" >

[PATCH 19/20] batman-adv: Rename batadv_tt_global_entry *_free_ref function to *_put

2016-02-22 Thread Antonio Quartulli
From: Sven Eckelmann The batman-adv source code is the only place in the kernel which uses the *_free_ref naming scheme for the *_put functions. Changing it to *_put makes it more consistent and makes it easier to understand the connection to the *_get functions. Signed-off-by: Sven Eckelmann S

[PATCH 15/20] batman-adv: Rename batadv_nc_node *_free_ref function to *_put

2016-02-22 Thread Antonio Quartulli
From: Sven Eckelmann The batman-adv source code is the only place in the kernel which uses the *_free_ref naming scheme for the *_put functions. Changing it to *_put makes it more consistent and makes it easier to understand the connection to the *_get functions. Signed-off-by: Sven Eckelmann S

[PATCH 10/20] batman-adv: Rename batadv_dat_entry *_free_ref function to *_put

2016-02-22 Thread Antonio Quartulli
From: Sven Eckelmann The batman-adv source code is the only place in the kernel which uses the *_free_ref naming scheme for the *_put functions. Changing it to *_put makes it more consistent and makes it easier to understand the connection to the *_get functions. Signed-off-by: Sven Eckelmann S

[PATCH v2] net: jme: fix suspend/resume on JMC260

2016-02-22 Thread Diego Viola
The JMC260 network card fails to suspend/resume because the call to jme_start_irq() was too early, moving the call to jme_start_irq() after the jme_reset_link() function makes it work. Prior this change suspend/resume would fail unless /sys/power/pm_async=0 was explicitly specified. Signed-off-by

[PATCH 13/20] batman-adv: Rename batadv_tvlv_container *_free_ref function to *_put

2016-02-22 Thread Antonio Quartulli
From: Sven Eckelmann The batman-adv source code is the only place in the kernel which uses the *_free_ref naming scheme for the *_put functions. Changing it to *_put makes it more consistent and makes it easier to understand the connection to the *_get functions. Signed-off-by: Sven Eckelmann S

[PATCH 14/20] batman-adv: Rename batadv_softif_vlan *_free_ref function to *_put

2016-02-22 Thread Antonio Quartulli
From: Sven Eckelmann The batman-adv source code is the only place in the kernel which uses the *_free_ref naming scheme for the *_put functions. Changing it to *_put makes it more consistent and makes it easier to understand the connection to the *_get functions. Signed-off-by: Sven Eckelmann S

[PATCH 12/20] batman-adv: Rename batadv_tvlv_handler *_free_ref function to *_put

2016-02-22 Thread Antonio Quartulli
From: Sven Eckelmann The batman-adv source code is the only place in the kernel which uses the *_free_ref naming scheme for the *_put functions. Changing it to *_put makes it more consistent and makes it easier to understand the connection to the *_get functions. Signed-off-by: Sven Eckelmann S

[PATCH 11/20] batman-adv: Rename batadv_gw_node *_free_ref function to *_put

2016-02-22 Thread Antonio Quartulli
From: Sven Eckelmann The batman-adv source code is the only place in the kernel which uses the *_free_ref naming scheme for the *_put functions. Changing it to *_put makes it more consistent and makes it easier to understand the connection to the *_get functions. Signed-off-by: Sven Eckelmann S

[PATCH 16/20] batman-adv: Rename batadv_nc_path *_free_ref function to *_put

2016-02-22 Thread Antonio Quartulli
From: Sven Eckelmann The batman-adv source code is the only place in the kernel which uses the *_free_ref naming scheme for the *_put functions. Changing it to *_put makes it more consistent and makes it easier to understand the connection to the *_get functions. Signed-off-by: Sven Eckelmann S

[PATCH 17/20] batman-adv: Rename batadv_orig_node_vlan *_free_ref function to *_put

2016-02-22 Thread Antonio Quartulli
From: Sven Eckelmann The batman-adv source code is the only place in the kernel which uses the *_free_ref naming scheme for the *_put functions. Changing it to *_put makes it more consistent and makes it easier to understand the connection to the *_get functions. Signed-off-by: Sven Eckelmann S

[PATCH 18/20] batman-adv: Rename batadv_tt_local_entry *_free_ref function to *_put

2016-02-22 Thread Antonio Quartulli
From: Sven Eckelmann The batman-adv source code is the only place in the kernel which uses the *_free_ref naming scheme for the *_put functions. Changing it to *_put makes it more consistent and makes it easier to understand the connection to the *_get functions. Signed-off-by: Sven Eckelmann S

[PATCH 20/20] batman-adv: Rename batadv_tt_orig_list_entry *_free_ref function to *_put

2016-02-22 Thread Antonio Quartulli
From: Sven Eckelmann The batman-adv source code is the only place in the kernel which uses the *_free_ref naming scheme for the *_put functions. Changing it to *_put makes it more consistent and makes it easier to understand the connection to the *_get functions. Signed-off-by: Sven Eckelmann S

[PATCH 08/20] batman-adv: Rename batadv_backbone_gw *_free_ref function to *_put

2016-02-22 Thread Antonio Quartulli
From: Sven Eckelmann The batman-adv source code is the only place in the kernel which uses the *_free_ref naming scheme for the *_put functions. Changing it to *_put makes it more consistent and makes it easier to understand the connection to the *_get functions. Signed-off-by: Sven Eckelmann S

[PATCH 01/20] batman-adv: remove unused BATADV_BONDING_TQ_THRESHOLD constant

2016-02-22 Thread Antonio Quartulli
BATADV_BONDING_TQ_THRESHOLD is not used anymore since the implementation of the bat_neigh_is_similar_or_better() API function. Such function uses the more generic BATADV_TQ_SIMILARITY_THRESHOLD constant. Therefore, remove definition of the unused BATADV_BONDING_TQ_THRESHOLD constant. Signed-off-b

[PATCH 04/20] batman-adv: Rename batadv_neigh_node *_free_ref function to *_put

2016-02-22 Thread Antonio Quartulli
From: Sven Eckelmann The batman-adv source code is the only place in the kernel which uses the *_free_ref naming scheme for the *_put functions. Changing it to *_put makes it more consistent and makes it easier to understand the connection to the *_get functions. Signed-off-by: Sven Eckelmann S

[PATCH 09/20] batman-adv: Rename batadv_claim *_free_ref function to *_put

2016-02-22 Thread Antonio Quartulli
From: Sven Eckelmann The batman-adv source code is the only place in the kernel which uses the *_free_ref naming scheme for the *_put functions. Changing it to *_put makes it more consistent and makes it easier to understand the connection to the *_get functions. Signed-off-by: Sven Eckelmann S

[PATCH 07/20] batman-adv: Rename batadv_hardif_neigh *_free_ref function to *_put

2016-02-22 Thread Antonio Quartulli
From: Sven Eckelmann The batman-adv source code is the only place in the kernel which uses the *_free_ref naming scheme for the *_put functions. Changing it to *_put makes it more consistent and makes it easier to understand the connection to the *_get functions. Signed-off-by: Sven Eckelmann S

[PATCH 05/20] batman-adv: Rename batadv_neigh_ifinfo *_free_ref function to *_put

2016-02-22 Thread Antonio Quartulli
From: Sven Eckelmann The batman-adv source code is the only place in the kernel which uses the *_free_ref naming scheme for the *_put functions. Changing it to *_put makes it more consistent and makes it easier to understand the connection to the *_get functions. Signed-off-by: Sven Eckelmann S

[PATCH 06/20] batman-adv: Rename batadv_orig_ifinfo *_free_ref function to *_put

2016-02-22 Thread Antonio Quartulli
From: Sven Eckelmann The batman-adv source code is the only place in the kernel which uses the *_free_ref naming scheme for the *_put functions. Changing it to *_put makes it more consistent and makes it easier to understand the connection to the *_get functions. Signed-off-by: Sven Eckelmann S

[PATCH 03/20] batman-adv: Rename batadv_hardif *_free_ref function to *_put

2016-02-22 Thread Antonio Quartulli
From: Sven Eckelmann The batman-adv source code is the only place in the kernel which uses the *_free_ref naming scheme for the *_put functions. Changing it to *_put makes it more consistent and makes it easier to understand the connection to the *_get functions. Signed-off-by: Sven Eckelmann S

[PATCH 02/20] batman-adv: Rename batadv_orig_node *_free_ref function to *_put

2016-02-22 Thread Antonio Quartulli
From: Sven Eckelmann The batman-adv source code is the only place in the kernel which uses the *_free_ref naming scheme for the *_put functions. Changing it to *_put makes it more consistent and makes it easier to understand the connection to the *_get functions. Signed-off-by: Sven Eckelmann S

pull request [net-next]: batman-adv 20160223

2016-02-22 Thread Antonio Quartulli
Hello David, thanks for notifying me about the merge ! This is another pull request intended for net-next and it is basically all cleanup work, mostly by Sven Eckelmann. First the BATADV_BONDING_TQ_THRESHOLD constant gets removed as it was defined but not used anywhere, then all our *_free_ref f

[PATCH net-next RFC] rtnetlink: add new RTM_GETSTATS to dump link stats

2016-02-22 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds a new RTM_GETSTATS message to query link stats via netlink from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK returns a lot more than just stats and is expensive in some cases when frequent polling for stats from userspace is a common operation

Re: [B.A.T.M.A.N.] pull request [net]: batman-adv 20160216

2016-02-22 Thread David Miller
From: David Miller Date: Tue, 23 Feb 2016 00:12:35 -0500 (EST) > From: Antonio Quartulli > Date: Tue, 23 Feb 2016 13:07:50 +0800 > >> I know this kind of mails steal you some time, but do you have any plan >> about merging net into net-next in the next days ? > > It's what I'm working on right

Re: [PATCH] net: jme: fix suspend/resume on JMC260

2016-02-22 Thread Diego Viola
On Tue, Feb 23, 2016 at 2:11 AM, Diego Viola wrote: > On Tue, Feb 23, 2016 at 1:42 AM, David Miller wrote: >> From: Diego Viola >> Date: Mon, 22 Feb 2016 22:58:48 -0300 >> >>> On Mon, Feb 22, 2016 at 10:46 PM, Fabio Estevam wrote: On Mon, Feb 22, 2016 at 9:32 PM, Diego Viola wrote: >

[PATCH] ipv4: do not cache local route when using SO_BINDTODEVICE

2016-02-22 Thread Kouya Shimura
After v3.6, output routes are cached, however, the 'rt_iif' field of struct rtable can not be shared by various traffics using SO_BINDTODEVICE. It causes that traffic can not reach the local receiver which also uses SO_BINDTODEVICE after another traffic creates a local route cache. /* sender a

Re: [B.A.T.M.A.N.] pull request [net]: batman-adv 20160216

2016-02-22 Thread David Miller
From: Antonio Quartulli Date: Tue, 23 Feb 2016 13:07:50 +0800 > I know this kind of mails steal you some time, but do you have any plan > about merging net into net-next in the next days ? It's what I'm working on right now.

Re: [patch net-next 0/9] Introduce devlink interface and first drivers to use it

2016-02-22 Thread Andy Gospodarek
On Mon, Feb 22, 2016 at 07:31:55PM +0100, Jiri Pirko wrote: > From: Jiri Pirko > > There a is need for some userspace API that would allow to expose things > that are not directly related to any device class like net_device of > ib_device, but rather chip-wide/switch-ASIC-wide stuff. > > Use cas

Re: [PATCH] net: jme: fix suspend/resume on JMC260

2016-02-22 Thread Diego Viola
On Tue, Feb 23, 2016 at 1:42 AM, David Miller wrote: > From: Diego Viola > Date: Mon, 22 Feb 2016 22:58:48 -0300 > >> On Mon, Feb 22, 2016 at 10:46 PM, Fabio Estevam wrote: >>> On Mon, Feb 22, 2016 at 9:32 PM, Diego Viola wrote: Signed-off-by: Diego Viola >>> >>> You should write a commit

Re: [B.A.T.M.A.N.] pull request [net]: batman-adv 20160216

2016-02-22 Thread Antonio Quartulli
On Sat, Feb 20, 2016 at 01:28:40PM +0800, Antonio Quartulli wrote: > On Fri, Feb 19, 2016 at 03:37:18PM -0500, David Miller wrote: > > And thanks for the heads up about the potential merge issues, I'll watch > > for that. > > > > Hi David, > > actually I just realized that the patches that will

Re: [patch net-next 6/9] mlxsw: spectrum: Unmap local port from module during teardown

2016-02-22 Thread Andy Gospodarek
On Mon, Feb 22, 2016 at 12:32:47PM -0800, John Fastabend wrote: > On 16-02-22 10:32 AM, Jiri Pirko wrote: > > From: Ido Schimmel > > > > When splitting a port we replace it with 2 or 4 other ports. To be able > > to do that we need to remove the original port netdev and unmap it from > > its modu

Re: [PATCH] net: jme: fix suspend/resume on JMC260

2016-02-22 Thread David Miller
From: Diego Viola Date: Mon, 22 Feb 2016 22:58:48 -0300 > On Mon, Feb 22, 2016 at 10:46 PM, Fabio Estevam wrote: >> On Mon, Feb 22, 2016 at 9:32 PM, Diego Viola wrote: >>> Signed-off-by: Diego Viola >> >> You should write a commit log. > > I thought about including the link to my bug report:

Re: [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default

2016-02-22 Thread Jesse Gross
On Sat, Feb 20, 2016 at 11:51 AM, Tom Herbert wrote: > On Fri, Feb 19, 2016 at 6:18 PM, Jesse Gross wrote: >> On Fri, Feb 19, 2016 at 4:14 PM, Tom Herbert wrote: >>> On Fri, Feb 19, 2016 at 4:08 PM, Jesse Gross wrote: On Fri, Feb 19, 2016 at 3:10 PM, Alex Duyck wrote: > On Fri, Feb 19

Re: [PATCH v7 6/8] x86: tsc: Always Running Timer (ART) correlated clocksource

2016-02-22 Thread Andy Lutomirski
On Mon, Feb 22, 2016 at 6:38 PM, Christopher Hall wrote: > On Thu, 18 Feb 2016 13:11:33 -0800, Andy Lutomirski wrote: >>> >>> +#define X86_FEATURE_INVARIANT_TSC (7*32+4) /* Intel Invariant TSC */ > > > This is removed. It was basically an alias for NONSTOP_TSC and not needed. > >> >>> +/* >>> + *

Re: [PATCH v7 6/8] x86: tsc: Always Running Timer (ART) correlated clocksource

2016-02-22 Thread Christopher Hall
On Thu, 18 Feb 2016 13:11:33 -0800, Andy Lutomirski wrote: +#define X86_FEATURE_INVARIANT_TSC (7*32+4) /* Intel Invariant TSC */ This is removed. It was basically an alias for NONSTOP_TSC and not needed. +/* + * Convert ART to TSC given numerator/denominator found in detect_art() + */ +st

Re: [RFC PATCH net-next 0/3] Extend macvtap with multiple qdiscs

2016-02-22 Thread Jason Wang
On 02/08/2016 11:14 AM, Vladislav Yasevich wrote: > This is an RFC series to extend macvtap with multiple qdisc. Right now > multiqueue macvtap setups suffer from lock contention. Macvtap sets > the queue index and thus gets a default qdisc allocated to it. Since > it later users dev_queue_xmi

Re: [PATCH] net: jme: fix suspend/resume on JMC260

2016-02-22 Thread Diego Viola
On Mon, Feb 22, 2016 at 10:58 PM, Diego Viola wrote: > On Mon, Feb 22, 2016 at 10:46 PM, Fabio Estevam wrote: >> On Mon, Feb 22, 2016 at 9:32 PM, Diego Viola wrote: >>> Signed-off-by: Diego Viola >> >> You should write a commit log. > > I thought about including the link to my bug report: > htt

Re: [PATCH] net: jme: fix suspend/resume on JMC260

2016-02-22 Thread Diego Viola
On Mon, Feb 22, 2016 at 10:46 PM, Fabio Estevam wrote: > On Mon, Feb 22, 2016 at 9:32 PM, Diego Viola wrote: >> Signed-off-by: Diego Viola > > You should write a commit log. I thought about including the link to my bug report: https://bugzilla.kernel.org/show_bug.cgi?id=112351 What else would

Re: 4.4.1 skb_warn_bad_offload+0xc5/0x110

2016-02-22 Thread Wakko Warner
Please keep me in CC. Hannes Frederic Sowa wrote: > [full-quote for netdev] > On 16.02.2016 01:08, Wakko Warner wrote: > >I've been seeing the following on some of my VMs ran under qemu. The VMs do > >not have internet connectivity. This happened when some files were accessed > >via NFS to anoth

Re: [PATCH] net: jme: fix suspend/resume on JMC260

2016-02-22 Thread Fabio Estevam
On Mon, Feb 22, 2016 at 9:32 PM, Diego Viola wrote: > Signed-off-by: Diego Viola You should write a commit log.

Re: [PATCH] jme: remove the jme driver as it is no longer maintained

2016-02-22 Thread Diego Viola
On Sun, Feb 21, 2016 at 2:17 PM, Diego Viola wrote: > On Sun, Feb 21, 2016 at 9:45 AM, One Thousand Gnomes > wrote: >>> I would appreciate some hint from someone who is more experienced with >>> drivers. >> >> Start by testing >> >> - loading the driver as a module >> - using the networking >> -

[PATCH net] bpf: fix csum setting for bpf_set_tunnel_key

2016-02-22 Thread Daniel Borkmann
The fix in 35e2d1152b22 ("tunnels: Allow IPv6 UDP checksums to be correctly controlled.") changed behavior for bpf_set_tunnel_key() when in use with IPv6 and thus uncovered a bug that TUNNEL_CSUM needed to be set but wasn't. As a result, the stack dropped ingress vxlan IPv6 packets, that have been

[PATCH][net-next][v2] bridge: allow the maximum mtu to 64k

2016-02-22 Thread roy . qing . li
From: Li RongQing A linux bridge always adopts the smallest MTU of the enslaved devices. When no device are enslaved, it defaults to a MTU of 1500 and refuses to use a larger one. This is problematic when using bridges enslaving only virtual NICs (vnetX) like it's common with KVM guests. Steps t

netfilter: warning at net/ipv4/netfilter/nf_nat_l3proto_ipv4.c:275 nf_nat_ipv4_fn

2016-02-22 Thread Sasha Levin
Hi all, I've hit the following warning while fuzzing with trinity inside a kvmtool guest running the latest -next kernel: [ 3196.268106] WARNING: CPU: 3 PID: 660 at net/ipv4/netfilter/nf_nat_l3proto_ipv4.c:275 nf_nat_ipv4_fn+0x65d/0xab0() [ 3196.268120] Modules linked in: [ 3196.268142] CPU: 3

Re: [PATCH][net-next] bridge: increase mtu to 9000

2016-02-22 Thread Li RongQing
On Tue, Feb 23, 2016 at 1:58 AM, Stephen Hemminger wrote: >> guest VMs. >> >> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1399064 >> >> Signed-off-by: Li RongQing > > Your change works, but I agree with Hannes. Just allow up to 64 * 1024 like > loopback does. And no need for a #define f

Re: Computer fails to resume from suspend unless I rmmod jme before initiating the suspend

2016-02-22 Thread Diego Viola
On Mon, Feb 22, 2016 at 4:20 PM, Pavel Machek wrote: > On Mon 2016-02-22 15:59:48, Diego Viola wrote: >> On Mon, Feb 22, 2016 at 7:09 AM, Pavel Machek wrote: >> > Hi! >> > >> >> Every time I initiate a suspend (systemctl suspend) the machine hangs >> >> at resume unless I unload the jme

[PATCH] net: jme: fix suspend/resume on JMC260

2016-02-22 Thread Diego Viola
Signed-off-by: Diego Viola --- drivers/net/ethernet/jme.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c index b1de7af..8adbe8f 100644 --- a/drivers/net/ethernet/jme.c +++ b/drivers/net/ethernet/jme.c @@ -3312,13 +3312

Re: iproute2 query

2016-02-22 Thread Marcus Furlong
On 22 February 2016 at 07:05, Stephen Hemminger wrote: > On Fri, 19 Feb 2016 20:12:04 +1100 > Marcus Furlong wrote: > >> Hi, >> >> Just wondering if the following command should work: >> >> # ip route add 192.168.27.27/24 dev eth0 scope link src 192.168.27.27 >> RTNETLINK answers: Invalid argumen

Re: [PATCH can-next 1/2] CAN: rcar: add gen[12] fallback compatibility strings

2016-02-22 Thread Simon Horman
On Mon, Feb 22, 2016 at 10:40:37AM +0100, Marc Kleine-Budde wrote: > On 02/22/2016 04:37 AM, Rob Herring wrote: > > On Mon, Feb 22, 2016 at 11:15:49AM +0900, Simon Horman wrote: > >> Add fallback compatibility string for R-Car Gen 1 and Gen2 families. > >> This is in keeping with the fallback schem

Re: [PATCH can-next 1/2] CAN: rcar: add gen[12] fallback compatibility strings

2016-02-22 Thread Simon Horman
On Mon, Feb 22, 2016 at 04:40:39PM +0100, Geert Uytterhoeven wrote: > On Mon, Feb 22, 2016 at 3:15 AM, Simon Horman > wrote: > > Add fallback compatibility string for R-Car Gen 1 and Gen2 families. > > This is in keeping with the fallback scheme being adopted wherever > > appropriate for drivers f

Re: [PATCH V2 net-next 2/3] lan78xx: add ethtool set & get pause functions

2016-02-22 Thread Ben Hutchings
On Mon, 2016-02-22 at 20:28 +, woojung@microchip.com wrote: > > -Original Message- > > From: Ben Hutchings [mailto:b...@decadent.org.uk] > > Sent: Monday, February 22, 2016 3:05 PM > > To: David Miller; Woojung Huh - C21699 > > Cc: netdev@vger.kernel.org > > Subject: Re: [PATCH V2 n

Re: [PATCH can-next 2/2] CAN: rcar: add device tree support for r8a779[234]

2016-02-22 Thread Simon Horman
On Mon, Feb 22, 2016 at 02:48:39PM +0100, Geert Uytterhoeven wrote: > On Mon, Feb 22, 2016 at 3:15 AM, Simon Horman > wrote: > > Simply document new compatibility string. > > As a previous patch adds a generic R-Car Gen2 compatibility string > > there appears to be no need for a driver updates. >

[Patch net-next v2 1/2] net_sched: prepare tcf_hashinfo_destroy() for netns support

2016-02-22 Thread Cong Wang
We only release the memory of the hashtable itself, not its entries inside. This is not a problem yet since we only call it in module release path, and module is refcount'ed by actions. This would be a problem after we move the per module hinfo into per netns in the latter patch. Cc: Jamal Hadi Sa

[Patch net-next v2 0/2] net_sched: add network namespace support for tc actions

2016-02-22 Thread Cong Wang
This patchset adds network namespace support for tc actions. v2: * pull the first patch into net-next * reduce code duplication by introducing more helper functions Cong Wang (2): net_sched: prepare tcf_hashinfo_destroy() for netns support net_sched: add network namespace support for tc actio

[Patch net-next v2 2/2] net_sched: add network namespace support for tc actions

2016-02-22 Thread Cong Wang
Currently tc actions are stored in a per-module hashtable, therefore are visible to all network namespaces. This is probably the last part of the tc subsystem which is not aware of netns now. This patch makes them per-netns, several tc action API's need to be adjusted for this. The tc action API c

Re: [Patch net-next] net_sched: add network namespace support for tc actions

2016-02-22 Thread Cong Wang
On Mon, Feb 22, 2016 at 5:42 AM, Jamal Hadi Salim wrote: > I did a quick look and i am struggling with it. The patch seems largish > The issue is that we need to do this per kernel module so the code > churn maybe unavoidable; hinfo stored in act_ops complicates things. > Having said that: All th

Re: [PATCH net v2] r8169:fix "rtl_counters_cond == 1 (loop: 1000, delay: 10)" log spam.

2016-02-22 Thread Francois Romieu
Chunhao Lin : [...] > diff --git a/drivers/net/ethernet/realtek/r8169.c > b/drivers/net/ethernet/realtek/r8169.c > index 537974c..a645f8d 100644 > --- a/drivers/net/ethernet/realtek/r8169.c > +++ b/drivers/net/ethernet/realtek/r8169.c > @@ -7730,10 +7730,13 @@ rtl8169_get_stats64(struct net_devic

Re: net: netcp: regarding commit 899077: netcp: try to reduce type confusion in descriptors

2016-02-22 Thread Murali Karicheri
Arnd, On 02/22/2016 05:13 PM, Arnd Bergmann wrote: > On Monday 22 February 2016 16:48:14 Murali Karicheri wrote: >> Arnd, >> >> As promised, here is what I found wrong with the commit 899077 that >> introduced a >> regression. With these changes, I am able to boot kernel without issues on >> K2

Re: [patch net-next 1/9] Introduce devlink infrastructure

2016-02-22 Thread roopa
On 2/22/16, 10:31 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Introduce devlink infrastructure for drivers to register and expose to > userspace via generic Netlink interface. > > There are two basic objects defined: > devlink - one instance for every "parent device", for example switch ASIC > de

Re: net: netcp: regarding commit 899077: netcp: try to reduce type confusion in descriptors

2016-02-22 Thread Arnd Bergmann
On Monday 22 February 2016 16:48:14 Murali Karicheri wrote: > Arnd, > > As promised, here is what I found wrong with the commit 899077 that > introduced a > regression. With these changes, I am able to boot kernel without issues on K2 > platforms. Thanks so much for looking into this! > From

Re: [PATCH 1/4] net: ethernet: dwmac: add Ethernet glue logic for stm32 chip

2016-02-22 Thread Joachim Eastwood
On 22 February 2016 at 15:50, Alexandre Torgue wrote: > 2016-02-13 14:48 GMT+01:00 Joachim Eastwood : >> On 3 February 2016 at 15:54, Alexandre TORGUE >> wrote: >>> + plat_dat->bsp_priv = dwmac; >>> + plat_dat->init = stm32_dwmac_init; >>> + plat_dat->exit = stm32_dwmac_exit; >

[PATCH net-next] bgmac: support Ethernet device on BCM47094 SoC

2016-02-22 Thread Rafał Miłecki
It needs very similar workarounds to the one on BCM4707. It was tested on D-Link DIR-885L home router. Signed-off-by: Rafał Miłecki --- It's the same patch as last time, just with a proper prefix ("net-next") --- drivers/net/ethernet/broadcom/bgmac.c | 6 -- 1 file changed, 4 insertions(+),

net: netcp: regarding commit 899077: netcp: try to reduce type confusion in descriptors

2016-02-22 Thread Murali Karicheri
Arnd, As promised, here is what I found wrong with the commit 899077 that introduced a regression. With these changes, I am able to boot kernel without issues on K2 platforms. >From the commit description, it appears that you are trying to make the driver >do the right thing if compiled for a

Re: [patch net-next 6/9] mlxsw: spectrum: Unmap local port from module during teardown

2016-02-22 Thread Ido Schimmel
Hi John, Mon, Feb 22, 2016 at 10:32:47PM IST, john.fastab...@gmail.com wrote: >On 16-02-22 10:32 AM, Jiri Pirko wrote: >> From: Ido Schimmel >> >> When splitting a port we replace it with 2 or 4 other ports. To be able >> to do that we need to remove the original port netdev and unmap it from >>

Re: [patch net-next 6/9] mlxsw: spectrum: Unmap local port from module during teardown

2016-02-22 Thread John Fastabend
On 16-02-22 01:00 PM, Ido Schimmel wrote: > Hi John, > > Mon, Feb 22, 2016 at 10:32:47PM IST, john.fastab...@gmail.com wrote: >> On 16-02-22 10:32 AM, Jiri Pirko wrote: >>> From: Ido Schimmel >>> >>> When splitting a port we replace it with 2 or 4 other ports. To be able >>> to do that we need to

Re: [PATCH] codel: cast the output of MS2TIME to codel_time_t

2016-02-22 Thread Emmanuel Grumbach
On Mon, Feb 22, 2016 at 9:53 PM, David Miller wrote: > From: Emmanuel Grumbach > Date: Mon, 22 Feb 2016 13:49:47 +0200 > >> This will allow to pass the typecheck in the comparators: >> codel_time_{after,before} >> >> Signed-off-by: Emmanuel Grumbach > > I do not see any existing code where this

Re: [net-next PATCH 5/5] Support to encoding decoding skb queue map on IFE action

2016-02-22 Thread John Fastabend
On 16-02-22 05:21 AM, Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > > hard code static value of 10 for qmap > mark of 12 > prio of 13 > and hashid of 11 > > sudo tc filter add dev $ETH parent 1: protocol ip prio 10 \ > u32 match ip protocol 1 0xff flowid 1:2 \ > action ife encode \ > type 0

Re: [PATCH] netcp: fix typo in netcp_setup_tc

2016-02-22 Thread David Miller
From: Arnd Bergmann Date: Mon, 22 Feb 2016 21:50:39 +0100 > A change to the prototype of netcp_setup_tc() missed a '*' > character, which broke compilation of hte netcp driver: > > drivers/net/ethernet/ti/netcp_core.c: In function 'netcp_setup_tc': > drivers/net/ethernet/ti/netcp_core.c:1839:31:

[PATCH] netcp: fix typo in netcp_setup_tc

2016-02-22 Thread Arnd Bergmann
A change to the prototype of netcp_setup_tc() missed a '*' character, which broke compilation of hte netcp driver: drivers/net/ethernet/ti/netcp_core.c: In function 'netcp_setup_tc': drivers/net/ethernet/ti/netcp_core.c:1839:31: error: invalid type argument of '->' (have 'struct tc_to_netdev') dr

[PATCH net 5/5] ppp: protect ppp->npmode

2016-02-22 Thread Guillaume Nault
ppp->npmode is read by ppp_ioctl(), ppp_receive_nonmp_frame() and ppp_start_xmit(). But it is only modified by ppp_ioctl(). However, the only protected access is done by ppp_receive_nonmp_frame() which runs under ppp_recv_lock() protection. We could protect ppp->npmode with ppp_recv_lock() in ppp_

[PATCH net 1/5] ppp: lock ppp structure before modifying mru in ppp_ioctl()

2016-02-22 Thread Guillaume Nault
PPP's Tx and Rx paths read ppp->mru under protection of ppp_xmit_lock() and ppp_recv_lock() respectively. Therefore ppp_ioctl() must hold the xmit and recv locks before concurrently updating ppp->mru. Signed-off-by: Guillaume Nault --- drivers/net/ppp/ppp_generic.c | 3 +++ 1 file changed, 3 ins

[PATCH net 4/5] ppp: protect access to ppp->last_{xmit,recv} in ppp_ioctl()

2016-02-22 Thread Guillaume Nault
ppp->last_xmit is witten to by ppp_send_frame() while protected by ppp_xmit_lock(). Likewise, ppp->last_recv is written to by ppp_receive_nonmp_frame() while protected by ppp_recv_lock(). Holding both locks is therefore necessary before ppp_ioctl() can safely read these fields. Signed-off-by: Gui

[PATCH net 2/5] ppp: fix unprotected accesses to ppp->flags and ppp->n_channels

2016-02-22 Thread Guillaume Nault
Reading ppp->flags has to be done under protection of ppp_recv_lock() or ppp_xmit_lock() (for Rx and Tx paths respectively). Therefore, both locks have to be held before writing. This patch adds missing locking in ppp_read(), ppp_poll() and ppp_ioctl(). As a side effect, it fixes unprotected acces

[PATCH net 0/5] ppp: fix locking issues related to ppp_ioctl()

2016-02-22 Thread Guillaume Nault
This series fixes unprotected accesses to several struct ppp fields. Only fields used in ppp_ioctl() have been considered, though. Locking of the xstate and rstate fields remains incomplete: although a side effect of patch #2 provides protection in ppp_ioctl(), xstate and rstate can still be modif

[PATCH net 3/5] ppp: protect ppp->debug in ppp_ioctl()

2016-02-22 Thread Guillaume Nault
ppp->debug is read in the Tx and Rx paths while under protection of ppp_xmit_lock() and ppp_recv_lock() respectively. So ppp_ioctl() must hold both locks before concurrently updating it. Signed-off-by: Guillaume Nault --- Locking is not strictly necessary for PPPIOCGDEBUG, because ppp->debug can

Re: [patch net-next 6/9] mlxsw: spectrum: Unmap local port from module during teardown

2016-02-22 Thread John Fastabend
On 16-02-22 10:32 AM, Jiri Pirko wrote: > From: Ido Schimmel > > When splitting a port we replace it with 2 or 4 other ports. To be able > to do that we need to remove the original port netdev and unmap it from > its module. However, we first mark it as disabled, as active ports > cannot be unmap

RE: [PATCH V2 net-next 2/3] lan78xx: add ethtool set & get pause functions

2016-02-22 Thread Woojung.Huh
> -Original Message- > From: Ben Hutchings [mailto:b...@decadent.org.uk] > Sent: Monday, February 22, 2016 3:05 PM > To: David Miller; Woojung Huh - C21699 > Cc: netdev@vger.kernel.org > Subject: Re: [PATCH V2 net-next 2/3] lan78xx: add ethtool set & get pause > functions > > On Mon, 2016-

Re: [PATCH][V2] rtlwifi: pass struct rtl_stats by reference as it is more efficient

2016-02-22 Thread Larry Finger
On 02/22/2016 05:35 AM, Colin King wrote: From: Colin Ian King passing rtl_stats by value is inefficient; the structure is over 300 bytes in size and generally just one field (packet_report_type) is being accessed, so the pass by value is a relatively large overhead. This change just affects ju

Re: [PATCH V2 net-next 2/3] lan78xx: add ethtool set & get pause functions

2016-02-22 Thread Ben Hutchings
On Mon, 2016-02-22 at 14:10 -0500, David Miller wrote: > From: > Date: Mon, 22 Feb 2016 18:28:18 + > > >> This is incorrect; you should always return the manual settings > >> (fc_request_control flags) here.  If autonegotiation is enabled then > >> your get_settings function will return the a

Re: [PATCH] codel: cast the output of MS2TIME to codel_time_t

2016-02-22 Thread David Miller
From: Emmanuel Grumbach Date: Mon, 22 Feb 2016 13:49:47 +0200 > This will allow to pass the typecheck in the comparators: > codel_time_{after,before} > > Signed-off-by: Emmanuel Grumbach I do not see any existing code where this would matter. Maybe it was not meant to be fed directly? And if

Re: [PATCHv2 00/10] RFKill airplane-mode indicator

2016-02-22 Thread João Paulo Rechi Vita
On 22 February 2016 at 12:00, Dan Williams wrote: > On Mon, 2016-02-22 at 11:36 -0500, João Paulo Rechi Vita wrote: >> This series implements an airplane-mode indicator LED trigger, which >> can be >> used by platform drivers. The default policy have have airplane-mode >> set when >> all the radio

[PATCHv3] rfkill: Userspace control for airplane mode

2016-02-22 Thread João Paulo Rechi Vita
Provide an interface for the airplane-mode indicator be controlled from userspace. User has to first acquire the control through RFKILL_OP_AIRPLANE_MODE_INDICATOR_ACQUIRE and keep the fd open for the whole time it wants to be in control of the indicator. Closing the fd restores the default policy.

Re: IPv6 route to gateway on fe80::1%eth0 when I have fe80::1%br0 locally

2016-02-22 Thread Marc Haber
On Mon, Feb 22, 2016 at 05:15:41PM +0100, Hannes Frederic Sowa wrote: > On 22.02.2016 16:47, Marc Haber wrote: > >Can you reproduce the behavior with accept_ra_from_local =0 as well? > >Unfortunately, the debugging VM I build works fine, it's just the > >physical host showing this behavior. This is

Re: Computer fails to resume from suspend unless I rmmod jme before initiating the suspend

2016-02-22 Thread Pavel Machek
On Mon 2016-02-22 15:59:48, Diego Viola wrote: > On Mon, Feb 22, 2016 at 7:09 AM, Pavel Machek wrote: > > Hi! > > > >> Every time I initiate a suspend (systemctl suspend) the machine hangs > >> at resume unless I unload the jme driver. > > > > It seems to have some kind of suspend/resume

Re: [PATCH V2 net-next 2/3] lan78xx: add ethtool set & get pause functions

2016-02-22 Thread David Miller
From: Date: Mon, 22 Feb 2016 18:28:18 + >> This is incorrect; you should always return the manual settings >> (fc_request_control flags) here.  If autonegotiation is enabled then >> your get_settings function will return the actual pause flags. >> > What do you mean "return actual pause flag

[PATCH net-next 0/2] be2net patches

2016-02-22 Thread Ajit Khaparde
Please consider applying to net-next Ajit Khaparde (2): Patch 1: Declare some u16 fields as u32 to improve performance Patch 2: Fix a UE caused by passing large frames to the ASIC drivers/net/ethernet/emulex/benet/be.h | 21 - drivers/net/ethernet/emulex/benet/be_cmd

[PATCH net-next 2/2] be2net: Fix a UE caused by passing large frames to the ASIC

2016-02-22 Thread Ajit Khaparde
In QnQ configurations like Flex-10 where the VLANs are inserted by the ASIC, on rare occasions the HW is encountering a scenario where the final frame length ends to be greater than what the ASIC can support. This is because when the TXULP pulls the TX WRB to check the length of the frame to be tr

[PATCH net-next 1/2] be2net: Declare some u16 fields as u32 to improve performance

2016-02-22 Thread Ajit Khaparde
When 16-bit integers are loaded on CPUs with high order native register sizes, the CPU could use some extra ops before using them. And currently some of the frequently used fields in the driver like the producer and consumer indices of the queues are declared as u16. This patch declares such field

Re: Computer fails to resume from suspend unless I rmmod jme before initiating the suspend

2016-02-22 Thread Diego Viola
On Mon, Feb 22, 2016 at 7:09 AM, Pavel Machek wrote: > Hi! > >> Every time I initiate a suspend (systemctl suspend) the machine hangs >> at resume unless I unload the jme driver. > > It seems to have some kind of suspend/resume support. ... and it is > rather complex. > > Maybe jme_start

Re: [PATCH v7 0/8] Patchset enabling hardware based cross-timestamps for next gen Intel platforms

2016-02-22 Thread John Stultz
On Mon, Feb 22, 2016 at 10:33 AM, Christopher Hall wrote: > I just sent another patchset (v8). I corrected the comment problems pointed > out by Richard Cochran. I also changed the arch/x86 code to use "non-stop" > TSC rather than "invariant" TSC. They are *exactly* the same thing (i.e. > read fro

Re: [PATCH v7 0/8] Patchset enabling hardware based cross-timestamps for next gen Intel platforms

2016-02-22 Thread Christopher Hall
On Thu, 18 Feb 2016 11:26:24 -0800, John Stultz wrote: On Fri, Feb 12, 2016 at 12:25 PM, Christopher S. Hall wrote: Modern Intel hardware adds an Always Running Timer (ART) that allows the network and audio device clocks to precisely cross timestamp the device clock with the system clock. Thi

[patch net-next 1/9] Introduce devlink infrastructure

2016-02-22 Thread Jiri Pirko
From: Jiri Pirko Introduce devlink infrastructure for drivers to register and expose to userspace via generic Netlink interface. There are two basic objects defined: devlink - one instance for every "parent device", for example switch ASIC devlink port - one instance for every physical port of t

[patch net-next 2/9] mlx4: Implement devlink interface

2016-02-22 Thread Jiri Pirko
From: Jiri Pirko Implement newly introduced devlink interface. Add devlink port instances for every port and set the port types accordingly. Signed-off-by: Jiri Pirko --- drivers/infiniband/hw/mlx4/main.c | 7 drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 8 - driver

[patch net-next 7/9] mlxsw: spectrum: Store local port to module mapping during init

2016-02-22 Thread Jiri Pirko
From: Ido Schimmel The port netdevs are each associated with a different local port number in the device. These local ports are grouped into groups of 4 (e.g. (1-4), (5-8)) called clusters. The cluster constitutes the one of two possible modules they can be mapped to. This mapping is board-specif

[patch net-next 6/9] mlxsw: spectrum: Unmap local port from module during teardown

2016-02-22 Thread Jiri Pirko
From: Ido Schimmel When splitting a port we replace it with 2 or 4 other ports. To be able to do that we need to remove the original port netdev and unmap it from its module. However, we first mark it as disabled, as active ports cannot be unmapped. Signed-off-by: Ido Schimmel Signed-off-by: Ji

[patch net-next 4/9] mlxsw: Implement devlink interface

2016-02-22 Thread Jiri Pirko
From: Jiri Pirko Implement newly introduced devlink interface. Add devlink port instances for every port and set the port types accordingly. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/core.c | 24 ++-- drivers/net/ethernet/mellanox/mlxsw/spectrum.

  1   2   3   >