> Nits: > > - the tp->TxDescArray test provides the required synchronization: see > rtl8169_{open/close} and their pm_runtime_{get / put}. > > - ioaddr is not really needed : tp->mmio_addr appears only once and it does > not mess the 72..80 cols limit. > > - even if the device can only be automatically runtime suspended some time > after a link down event, you may address davem's point regarding stats > reliability and move rtl8169_rx_missed + rtl8169_update_counters after > rtl8169_net_suspend.
I will submit the new patch according to your advice. Thanks. Please consider the environment before printing this e-mail.