Re: [RFC PATCH net-next 2/3] macvlan: add queue selection functionality

2016-02-08 Thread Pankaj Gupta
> > This patch adds a simple queue selection function to macvlan > layer. In most cases, this will just use the standard fallback > fuction, but when rx-queue has been recoreded we'll try to use > that value. > > Signed-off-by: Vladislav Yasevich > --- > drivers/net/macvlan.c | 20 +++

[PATCH] ip6_gre: clear IPCB in ip6gre_xmit2 in case dst_link_failure called

2016-02-08 Thread Bernie Harris
skb->cb may contain data from previous layers (in the observed case the qdisc layer). In the observed scenario, the data was misinterpreted as ip header options, which later caused the ihl to be set to an invalid value (<5). This resulted in an infinite loop in the mips implementation of ip_fast_cs

Re: gro: Make GRO aware of lightweight tunnels.

2016-02-08 Thread Dave Jones
On Tue, Feb 02, 2016 at 02:28:58AM +, Linux Kernel wrote: > Web: > https://git.kernel.org/torvalds/c/ce87fc6ce3f9f4488546187e3757cf666d9d4a2a > Commit: ce87fc6ce3f9f4488546187e3757cf666d9d4a2a > Parent: 5f2f3cad8b878b23f17a11dd5af4f4a2cc41c797 > Refname:refs/heads/maste

[PATCH 1/4] ethtool: correctly ensure {GS}CHANNELS doesn't conflict with GS{RXFH}

2016-02-08 Thread Jacob Keller
Ethernet drivers implementing both {GS}RXFH and {GS}CHANNELS ethtool ops incorrectly allow SCHANNELS when it would conflict with the settings from SRXFH. This occurs because it is not possible for drivers to understand whether their Rx flow indirection table has been configured or is in the default

[PATCH 2/4] ethtool: ensure channel counts are within bounds during SCHANNELS

2016-02-08 Thread Jacob Keller
Add a sanity check to ensure that all requested channel sizes are within bounds, which should reduce errors in driver implementation. Signed-off-by: Jacob Keller --- net/core/ethtool.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/net/core/ethtool.c b/net/cor

[PATCH v2 0/4] ethtool: correct {GS}CHANNELS and {GS}RXFH conflict

2016-02-08 Thread Jacob Keller
This patch series fixes up ethtool_set_channels operation which allowed modifying the RXFH table indirectly by reducing the number of queues below the current max queue used by the Rx flow table. Most drivers incorrectly allowed this to destroy the Rx flow table and would then start by reinitializi

[PATCH v2 4/4] ethtool: support setting default Rx flow indirection table

2016-02-08 Thread Jacob Keller
Signed-off-by: Jacob Keller --- ethtool.8.in | 5 - ethtool.c| 46 -- 2 files changed, 36 insertions(+), 15 deletions(-) diff --git a/ethtool.8.in b/ethtool.8.in index eeffa70415b5..b7d56fbe4484 100644 --- a/ethtool.8.in +++ b/ethtool.8.in @@

[PATCH 3/4] fm10k: don't reinitialize RSS flow table when RXFH configured

2016-02-08 Thread Jacob Keller
Also print an error message incase we do have to reconfigure as this should no longer happen anymore due to ethtool changes. If it somehow does occur, user should be made aware of it. Signed-off-by: Jacob Keller --- drivers/net/ethernet/intel/fm10k/fm10k_main.c | 10 -- 1 file changed, 8

Re: [PATCH net-next v7 01/19] lib/bitmap.c: conversion routines to/from u32 array

2016-02-08 Thread Andrew Morton
On Sun, 7 Feb 2016 17:08:45 -0800 David Decotigny wrote: > From: David Decotigny > > Aimed at transferring bitmaps to/from user-space in a 32/64-bit agnostic > way. > > Tested: > unit tests (next patch) on qemu i386, x86_64, ppc, ppc64 BE and LE, > ARM. > > @@ -1060,6 +1062,90 @@ int bit

[PATCH iproute2 v2 10/21] iplink: bridge: add support for IFLA_BR_MCAST_QUERIER

2016-02-08 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov This patch implements support for the IFLA_BR_MCAST_QUERIER attribute in iproute2 so it can toggle the mcast querier value. Signed-off-by: Nikolay Aleksandrov --- ip/iplink_bridge.c | 13 + 1 file changed, 13 insertions(+) diff --git a/ip/iplink_bridge.c

[PATCH iproute2 v2 08/21] iplink: bridge: add support for IFLA_BR_MCAST_SNOOPING

2016-02-08 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov This patch implements support for the IFLA_BR_MCAST_SNOOPING attribute in iproute2 so it can change the multicast snooping value. Signed-off-by: Nikolay Aleksandrov --- ip/iplink_bridge.c | 13 + 1 file changed, 13 insertions(+) diff --git a/ip/iplink_bri

[PATCH iproute2 v2 01/21] iplink: bridge: export bridge_id and designated_root

2016-02-08 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Netlink returns the bridge_id and designated_root, we just need to make them visible. Signed-off-by: Nikolay Aleksandrov --- v2: use ether_ntoa_r in bridge_id dump ip/iplink_bridge.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/ip/i

[PATCH iproute2 v2 02/21] iplink: bridge: export root_(port|path_cost), topology_change and change_detected

2016-02-08 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Netlink already export these values, we just need to make them visible. Signed-off-by: Nikolay Aleksandrov --- ip/iplink_bridge.c | 16 1 file changed, 16 insertions(+) diff --git a/ip/iplink_bridge.c b/ip/iplink_bridge.c index 3bbbcaa120cf..33ffa6c2

[PATCH iproute2 v2 04/21] iplink: bridge: add support for IFLA_BR_GROUP_FWD_MASK

2016-02-08 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov This patch implements support for the IFLA_BR_GROUP_FWD_MASK attribute in iproute2 so it can change the group forwarding mask. Signed-off-by: Nikolay Aleksandrov --- ip/iplink_bridge.c | 13 + 1 file changed, 13 insertions(+) diff --git a/ip/iplink_bridge

[PATCH iproute2 v2 09/21] iplink: bridge: add support for IFLA_BR_MCAST_QUERY_USE_IFADDR

2016-02-08 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov This patch implements support for the IFLA_BR_MCAST_QUERY_USE_IFADDR attribute in iproute2 so it can toggle the multicast_query_use_ifaddr val. Signed-off-by: Nikolay Aleksandrov --- ip/iplink_bridge.c | 15 +++ 1 file changed, 15 insertions(+) diff --git

[PATCH iproute2 v2 06/21] iplink: bridge: add support for IFLA_BR_VLAN_DEFAULT_PVID

2016-02-08 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov This patch implements support for the IFLA_BR_VLAN_DEFAULT_PVID attribute in iproute2 so it can change the default pvid. Signed-off-by: Nikolay Aleksandrov --- ip/iplink_bridge.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/ip/iplink_bridge.c b/

[PATCH iproute2 v2 13/21] iplink: bridge: add support for IFLA_BR_MCAST_LAST_MEMBER_CNT

2016-02-08 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov This patch implements support for the IFLA_BR_MCAST_LAST_MEMBER_CNT attribute in iproute2 so it can change the last member count value. Signed-off-by: Nikolay Aleksandrov --- ip/iplink_bridge.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/ip/ip

[PATCH iproute2 v2 14/21] iplink: bridge: add support for IFLA_BR_MCAST_STARTUP_QUERY_CNT

2016-02-08 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov This patch implements support for the IFLA_BR_MCAST_STARTUP_QUERY_CNT attribute in iproute2 so it can change the startup query count. Signed-off-by: Nikolay Aleksandrov --- ip/iplink_bridge.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/ip/ipli

[PATCH iproute2 v2 15/21] iplink: bridge: add support for IFLA_BR_MCAST_LAST_MEMBER_INTVL

2016-02-08 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov This patch implements support for the IFLA_BR_MCAST_LAST_MEMBER_INTVL attribute in iproute2 so it can change the last member interval. Signed-off-by: Nikolay Aleksandrov --- ip/iplink_bridge.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/ip/ipl

[PATCH iproute2 v2 19/21] iplink: bridge: add support for IFLA_BR_MCAST_QUERY_RESPONSE_INTVL

2016-02-08 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov This patch implements support for the IFLA_BR_MCAST_QUERY_RESPONSE_INTVL attribute in iproute2 so it can change the query response interval. Signed-off-by: Nikolay Aleksandrov --- ip/iplink_bridge.c | 16 1 file changed, 16 insertions(+) diff --git a

[PATCH iproute2 v2 17/21] iplink: bridge: add support for IFLA_BR_MCAST_QUERIER_INTVL

2016-02-08 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov This patch implements support for the IFLA_BR_MCAST_QUERIER_INTVL attribute in iproute2 so it can change the querier interval. Signed-off-by: Nikolay Aleksandrov --- ip/iplink_bridge.c | 16 1 file changed, 16 insertions(+) diff --git a/ip/iplink_bri

[PATCH iproute2 v2 12/21] iplink: bridge: add support for IFLA_BR_MCAST_HASH_MAX

2016-02-08 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov This patch implements support for the IFLA_BR_MCAST_HASH_MAX attribute in iproute2 so it can change the maximum hashed entries. Signed-off-by: Nikolay Aleksandrov --- ip/iplink_bridge.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/ip/iplink_brid

[PATCH iproute2 v2 21/21] iplink: bridge: add support for netfilter call attributes

2016-02-08 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov This patch implements support for the IFLA_BR_NF_CALL_(IP|IP6|ARP)TABLES attributes in iproute2 so it can change their values. Signed-off-by: Nikolay Aleksandrov --- ip/iplink_bridge.c | 45 + 1 file changed, 45 insertions(+

[PATCH iproute2 v2 20/21] iplink: bridge: add support for IFLA_BR_MCAST_STARTUP_QUERY_INTVL

2016-02-08 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov This patch implements support for the IFLA_BR_MCAST_STARTUP_QUERY_INTVL attribute in iproute2 so it can change the startup query interval. Signed-off-by: Nikolay Aleksandrov --- ip/iplink_bridge.c | 16 1 file changed, 16 insertions(+) diff --git a/i

[PATCH iproute2 v2 16/21] iplink: bridge: add support for IFLA_BR_MCAST_MEMBERSHIP_INTVL

2016-02-08 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov This patch implements support for the IFLA_BR_MCAST_MEMBERSHIP_INTVL attribute in iproute2 so it can change the membership interval. Signed-off-by: Nikolay Aleksandrov --- ip/iplink_bridge.c | 16 1 file changed, 16 insertions(+) diff --git a/ip/ipli

[PATCH iproute2 v2 18/21] iplink: bridge: add support for IFLA_BR_MCAST_QUERY_INTVL

2016-02-08 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov This patch implements support for the IFLA_BR_MCAST_QUERY_INTVL attribute in iproute2 so it can change the query interval. Signed-off-by: Nikolay Aleksandrov --- ip/iplink_bridge.c | 16 1 file changed, 16 insertions(+) diff --git a/ip/iplink_bridge.

[PATCH iproute2 v2 03/21] iplink: bridge: export read-only timers

2016-02-08 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Netlink already provides hello_timer, tcn_timer, topology_change_timer and gc_timer, so let's make them visible. Signed-off-by: Nikolay Aleksandrov --- v2: export timers in seconds.milliseconds format as per Stephen's comment include/utils.h| 18 +

[PATCH iproute2 v2 11/21] iplink: bridge: add support for IFLA_BR_MCAST_HASH_ELASTICITY

2016-02-08 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov This patch implements support for the IFLA_BR_MCAST_HASH_ELASTICTITY attribute in iproute2 so it can change the hash elasticity value. Signed-off-by: Nikolay Aleksandrov --- ip/iplink_bridge.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/ip/ipl

[PATCH iproute2 v2 07/21] iplink: bridge: add support for IFLA_BR_MCAST_ROUTER

2016-02-08 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov This patch implements support for the IFLA_BR_MCAST_ROUTER attribute in iproute2 so it can change the multicast router value. Signed-off-by: Nikolay Aleksandrov --- ip/iplink_bridge.c | 13 + 1 file changed, 13 insertions(+) diff --git a/ip/iplink_bridge.

[PATCH iproute2 v2 00/21] bridge: complete netlink support

2016-02-08 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Hi, After I added support for all attributes in the kernel, it's time to make use of them in iproute2. I've tested changing/viewing all of the attributes. I'll send a separate set to add support for the ports attributes. For the future, adding a switch to change to "seco

[PATCH iproute2 v2 05/21] iplink: bridge: add support for IFLA_BR_GROUP_ADDR

2016-02-08 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov This patch implements support for the IFLA_BR_GROUP_ADDR attribute in iproute2 so it can change the group address. Signed-off-by: Nikolay Aleksandrov --- ip/iplink_bridge.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/ip/iplink_bridge.c b/i

Re: [PATCH net v3 2/4] net: add rx_nohandler stat counter

2016-02-08 Thread Eric Dumazet
On Mon, 2016-02-08 at 11:38 -0800, Stephen Hemminger wrote: > The iproute2 command can be fixed, but adding dependency on size of response > gets gross fast. Imagine when 4 more fields get added, this doesn't scale > well. Really ? I see no problem at all doing the proper tests. > > Also, the

Re: [PATCH 8/9] rfkill: Userspace control for airplane mode

2016-02-08 Thread Julian Calaby
Hi João, On Tue, Feb 9, 2016 at 2:41 AM, João Paulo Rechi Vita wrote: > Provide an interface for the airplane-mode indicator be controlled from > userspace. User has to first acquire the control through > RFKILL_OP_AIRPLANE_MODE_ACQUIRE and keep the fd open for the whole time > it wants to be in

Re: [PATCH 5/9] rfkill: Factor rfkill_global_states[].cur assignments

2016-02-08 Thread Julian Calaby
Hi João, On Tue, Feb 9, 2016 at 2:41 AM, João Paulo Rechi Vita wrote: > Factor all assignments to rfkill_global_states[].cur into a single > function rfkill_update_global_state(). > > Signed-off-by: João Paulo Rechi Vita Looks sane to me. Reviewed-by: Julian Calaby > --- > net/rfkill/core.c

Re: [PATCH 3/9] rfkill: Point to the correct deprecated doc location

2016-02-08 Thread Julian Calaby
Hi João, On Tue, Feb 9, 2016 at 2:41 AM, João Paulo Rechi Vita wrote: > The "claim" sysfs interface has been removed, so its documentation now > lives in the "removed" folder. > > Signed-off-by: João Paulo Rechi Vita Looks right to me. Reviewed-by: Julian Calaby > --- > Documentation/ABI/st

Re: [PATCH 2/9] rfkill: Remove extra blank line

2016-02-08 Thread Julian Calaby
Hi João, On Tue, Feb 9, 2016 at 2:41 AM, João Paulo Rechi Vita wrote: > Signed-off-by: João Paulo Rechi Vita Looks sane to me. Reviewed-by: Julian Calaby > --- > net/rfkill/core.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/rfkill/core.c b/net/rfkill/core.c > index ffbc375..

Re: [PATCH 1/9] rfkill: Improve documentation language

2016-02-08 Thread Julian Calaby
Hi João, On Tue, Feb 9, 2016 at 2:41 AM, João Paulo Rechi Vita wrote: > Signed-off-by: João Paulo Rechi Vita Looks right to me. Reviewed-by: Julian Calaby > --- > net/rfkill/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/rfkill/core.c b/net/rfkill/co

Re: [PATCH iproute2 01/21] iplink: bridge: export bridge_id and designated_root

2016-02-08 Thread Nikolay Aleksandrov
On 02/08/2016 11:25 PM, Nikolay Aleksandrov wrote: > On 02/08/2016 11:21 PM, Stephen Hemminger wrote: >> On Mon, 8 Feb 2016 12:55:07 +0100 >> Nikolay Aleksandrov wrote: >> >>> >>> +static void br_dump_bridge_id(const struct ifla_bridge_id *id, char *buf, >>> + size_t len

Re: [PATCH iproute2 03/21] iplink: bridge: export read-only timers

2016-02-08 Thread Nikolay Aleksandrov
On 02/08/2016 11:23 PM, Stephen Hemminger wrote: > On Mon, 8 Feb 2016 12:55:09 +0100 > Nikolay Aleksandrov wrote: > >> + >> +if (tb[IFLA_BR_HELLO_TIMER]) >> +fprintf(f, "hello_timer %llu ", >> +rta_getattr_u64(tb[IFLA_BR_HELLO_TIMER])); >> + >> +if (tb[IFL

Re: [PATCH iproute2 01/21] iplink: bridge: export bridge_id and designated_root

2016-02-08 Thread Nikolay Aleksandrov
On 02/08/2016 11:21 PM, Stephen Hemminger wrote: > On Mon, 8 Feb 2016 12:55:07 +0100 > Nikolay Aleksandrov wrote: > >> >> +static void br_dump_bridge_id(const struct ifla_bridge_id *id, char *buf, >> + size_t len) >> +{ >> +const unsigned char *x = (const unsigned

Re: [PATCH iproute2 03/21] iplink: bridge: export read-only timers

2016-02-08 Thread Stephen Hemminger
On Mon, 8 Feb 2016 12:55:09 +0100 Nikolay Aleksandrov wrote: > + > + if (tb[IFLA_BR_HELLO_TIMER]) > + fprintf(f, "hello_timer %llu ", > + rta_getattr_u64(tb[IFLA_BR_HELLO_TIMER])); > + > + if (tb[IFLA_BR_TCN_TIMER]) > + fprintf(f, "tcn_timer %l

Re: [PATCH iproute2 01/21] iplink: bridge: export bridge_id and designated_root

2016-02-08 Thread Stephen Hemminger
On Mon, 8 Feb 2016 12:55:07 +0100 Nikolay Aleksandrov wrote: > > +static void br_dump_bridge_id(const struct ifla_bridge_id *id, char *buf, > + size_t len) > +{ > + const unsigned char *x = (const unsigned char *)id; > + > + snprintf(buf, len, "%.2x%.2x.%.2x%.

Re: [PATCH 3/4] ethtool: can't set combined and tx/rx channel counts at the same time

2016-02-08 Thread Keller, Jacob E
On Mon, 2016-02-08 at 20:52 +, Jakub Kicinski wrote: > On Mon,  8 Feb 2016 12:06:04 -0800, Jacob Keller wrote: > > + /* can't set combined and separate channels at the same > > time */ > > + if ((channels.combined_count && > > +  (channels.rx_count || channels.tx_count)) > > + r

Re: [PATCH next 2/3] ipvlan: mode is u16

2016-02-08 Thread Mahesh Bandewar
On Sun, Feb 7, 2016 at 11:19 AM, David Miller wrote: > From: Mahesh Bandewar > Date: Tue, 2 Feb 2016 11:20:30 -0800 > >> From: Mahesh Bandewar >> >> The mode argument was erronusly defined as u32 but it has always >> been u16. >> >> Signed-off-by: Mahesh Bandewar > > This patch is changing mor

[PATCH v2 3/4] igmp: Namespaceify igmp_llm_reports sysctl knob

2016-02-08 Thread Nikolay Borisov
From: Nikolay Borisov This was initially introduced in df2cf4a78e488d26 ("IGMP: Inhibit reports for local multicast groups") by defining the sysctl in the ipv4_net_table array, however it was never implemented to be namespace aware. Fix this by changing the code accordingly. --- v2: Move defini

Re: [PATCH 3/4] ethtool: can't set combined and tx/rx channel counts at the same time

2016-02-08 Thread Keller, Jacob E
On Mon, 2016-02-08 at 20:52 +, Jakub Kicinski wrote: > On Mon,  8 Feb 2016 12:06:04 -0800, Jacob Keller wrote: > > + /* can't set combined and separate channels at the same > > time */ > > + if ((channels.combined_count && > > +  (channels.rx_count || channels.tx_count)) > > + r

Re: [PATCH 3/4] igmp: Namespaceify igmp_llm_reports sysctl knob

2016-02-08 Thread kbuild test robot
Hi Nikolay, [auto build test WARNING on net-next/master] [also build test WARNING on next-20160208] [cannot apply to net/master v4.5-rc3] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits

Re: [PATCH] net: fec: Add "phy-reset-active-low" property to DT

2016-02-08 Thread Andrew Lunn
On Mon, Feb 08, 2016 at 10:46:42PM +0100, Arnd Bergmann wrote: > On Monday 08 February 2016 21:21:13 Bernhard Walle wrote: > > We need that for a custom hardware that needs the reverse reset > > sequence. > > > > Signed-off-by: Bernhard Walle > > > > Why can't this be specified in the gpios pro

Re: [PATCH] net: fec: Add "phy-reset-active-low" property to DT

2016-02-08 Thread Andrew Lunn
On Mon, Feb 08, 2016 at 09:21:13PM +0100, Bernhard Walle wrote: > We need that for a custom hardware that needs the reverse reset > sequence. > > Signed-off-by: Bernhard Walle > --- > Documentation/devicetree/bindings/net/fsl-fec.txt | 3 +++ > drivers/net/ethernet/freescale/fec_main.c |

Re: [PATCH] net: fec: Add "phy-reset-active-low" property to DT

2016-02-08 Thread Arnd Bergmann
On Monday 08 February 2016 21:21:13 Bernhard Walle wrote: > We need that for a custom hardware that needs the reverse reset > sequence. > > Signed-off-by: Bernhard Walle > Why can't this be specified in the gpios property? Arnd

[PATCH 4/4] igmp: Namespacify igmp_qrv sysctl knob

2016-02-08 Thread Nikolay Borisov
Signed-off-by: Nikolay Borisov --- include/linux/igmp.h | 2 -- include/net/netns/ipv4.h | 1 + net/ipv4/igmp.c| 29 + net/ipv4/sysctl_net_ipv4.c | 20 ++-- net/ipv4/tcp_ipv4.c| 1 + 5 files changed, 29 insertions(+), 24 d

[PATCH 0/4] Make igmp sysctl knobs namespace aware

2016-02-08 Thread Nikolay Borisov
This series continue making more of the net related sysctls namespace aware. The first 2 and last patches are straight forward and convert sysctls which weren't defined to be namespace aware. The only thing in them is that each removes a define which is used in only one place (to initialise the

[PATCH 2/4] igmp: Namespaceify igmp_max_msf sysctl knob

2016-02-08 Thread Nikolay Borisov
Signed-off-by: Nikolay Borisov --- include/linux/igmp.h | 1 - include/net/netns/ipv4.h | 1 + net/ipv4/igmp.c| 5 + net/ipv4/ip_sockglue.c | 5 +++-- net/ipv4/sysctl_net_ipv4.c | 14 +++--- net/ipv4/tcp_ipv4.c| 1 + 6 files changed, 13 insertions(

[PATCH 3/4] igmp: Namespaceify igmp_llm_reports sysctl knob

2016-02-08 Thread Nikolay Borisov
This was initially introduced in commit df2cf4a78e48 ("IGMP: Inhibit reports for local multicast groups") by defining the sysctl in the ipv4_net_table array, however it was never implemented to be namespace aware. Fix this by changing the code accordingly. Signed-off-by: Nikolay Borisov --- incl

[PATCH 1/4] igmp: Namespaceify igmp_max_memberships sysctl knob

2016-02-08 Thread Nikolay Borisov
Signed-off-by: Nikolay Borisov --- include/linux/igmp.h | 1 - include/net/netns/ipv4.h | 2 ++ net/ipv4/igmp.c| 4 +--- net/ipv4/sysctl_net_ipv4.c | 14 +++--- net/ipv4/tcp_ipv4.c| 2 ++ 5 files changed, 12 insertions(+), 11 deletions(-) diff --git a/incl

Re: [PATCH iproute2] iplink: bond_slave: fix ad_actor/partner_oper_port_state output

2016-02-08 Thread Nikolay Aleksandrov
On 02/08/2016 05:13 PM, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > It seems that I've made a mistake when I exported these, instead of a > space in the end I've put a newline character which is wrong and breaks > the single line output. > > Fixes: 7d6bc3b87abad ("bonding: export

Re: [PATCH 3/4] ethtool: can't set combined and tx/rx channel counts at the same time

2016-02-08 Thread Jakub Kicinski
On Mon, 8 Feb 2016 12:06:04 -0800, Jacob Keller wrote: > + /* can't set combined and separate channels at the same time */ > + if ((channels.combined_count && > + (channels.rx_count || channels.tx_count)) > + return -EINVAL; > + > /* ensure the new Rx count fits with

Re: [PATCH 1/4] ethtool: correctly ensure {GS}CHANNELS doesn't conflict with GS{RXFH}

2016-02-08 Thread Jakub Kicinski
Build bot seems upset so let me throw few stones as well. On Mon, 8 Feb 2016 12:06:02 -0800, Jacob Keller wrote: > > +static inline int ethool_get_max_rxfh_channel(struct net_device *dev, u32 > *max) static inline in C sources is frowned upon. > + u32 dev_size, current_max = 0; > + u32

Re: [PATCH 1/4] ethtool: correctly ensure {GS}CHANNELS doesn't conflict with GS{RXFH}

2016-02-08 Thread kbuild test robot
Hi Jacob, [auto build test ERROR on net/master] [also build test ERROR on v4.5-rc3 next-20160208] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Jacob-Keller/ethtool-correctly-ensure-GS

Re: [PATCH 3/4] ethtool: can't set combined and tx/rx channel counts at the same time

2016-02-08 Thread kbuild test robot
Hi Jacob, [auto build test WARNING on net/master] [also build test WARNING on v4.5-rc3 next-20160208] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Jacob-Keller/ethtool-correctly-ensure-GS

Re: [PATCH 1/4] ethtool: correctly ensure {GS}CHANNELS doesn't conflict with GS{RXFH}

2016-02-08 Thread kbuild test robot
Hi Jacob, [auto build test ERROR on net/master] [also build test ERROR on v4.5-rc3 next-20160208] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Jacob-Keller/ethtool-correctly-ensure-GS

Re: [PATCH 2/4] ethtool: ensure channel counts are within bounds during SCHANNELS

2016-02-08 Thread kbuild test robot
Hi Jacob, [auto build test ERROR on net/master] [also build test ERROR on v4.5-rc3 next-20160208] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Jacob-Keller/ethtool-correctly-ensure-GS

[PATCH] net: fec: Add "phy-reset-active-low" property to DT

2016-02-08 Thread Bernhard Walle
We need that for a custom hardware that needs the reverse reset sequence. Signed-off-by: Bernhard Walle --- Documentation/devicetree/bindings/net/fsl-fec.txt | 3 +++ drivers/net/ethernet/freescale/fec_main.c | 8 ++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/Do

Re: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

2016-02-08 Thread George Spelvin
David Laight wrote: > I'd need convincing that unrolling the loop like that gives any significant > gain. > You have a dependency chain on the carry flag so have delays between the > 'adcq' > instructions (these may be more significant than the memory reads from l1 > cache). If the carry chain

Re: [PATCH 3/4] ethtool: can't set combined and tx/rx channel counts at the same time

2016-02-08 Thread kbuild test robot
Hi Jacob, [auto build test ERROR on net/master] [also build test ERROR on v4.5-rc3 next-20160208] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Jacob-Keller/ethtool-correctly-ensure-GS

[PATCH v2 net] bonding: don't use stale speed and duplex information

2016-02-08 Thread Jay Vosburgh
There is presently a race condition between the bonding periodic link monitor and the updating of a slave's speed and duplex. The former occurs on a periodic basis, and the latter in response to a driver's calling of netif_carrier_on. It is possible for the periodic monitor to ru

[PATCH 4/4] fm10k: don't reinitialize RSS flow table when RXFH configured

2016-02-08 Thread Jacob Keller
Also print an error message incase we do have to reconfigure as this should no longer happen anymore due to ethtool changes. If it somehow does occur, user should be made aware of it. Signed-off-by: Jacob Keller --- drivers/net/ethernet/intel/fm10k/fm10k_main.c | 10 -- 1 file changed, 8

[PATCH 3/4] ethtool: can't set combined and tx/rx channel counts at the same time

2016-02-08 Thread Jacob Keller
Based on reading current implementations of {GS}CHANNELS, most drivers either support only combined counts or only separate counts. At least one driver supported setting combined or separate channels. No driver supported combined and separate channels setting at the same time, and this patch adds a

[PATCH 0/3] ethtool: correct {GS}CHANNELS and {GS}RXFH conflict

2016-02-08 Thread Jacob Keller
This patch series fixes up ethtool_set_channels operation which allowed modifying the RXFH table indirectly by reducing the number of queues below the current max queue used by the Rx flow table. Most drivers incorrectly allowed this to destroy the Rx flow table and would then start by reinitializi

[PATCH 2/4] ethtool: ensure channel counts are within bounds during SCHANNELS

2016-02-08 Thread Jacob Keller
Add a sanity check to ensure that all requested channel sizes are within bounds, which should reduce errors in driver implementation. Signed-off-by: Jacob Keller --- net/core/ethtool.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/net/core/ethtool.c b/net/c

[PATCH 1/4] ethtool: correctly ensure {GS}CHANNELS doesn't conflict with GS{RXFH}

2016-02-08 Thread Jacob Keller
Ethernet drivers implementing both {GS}RXFH and {GS}CHANNELS ethtool ops incorrectly allow SCHANNELS when it would conflict with the settings from SRXFH. This occurs because it is not possible for drivers to understand whether their Rx flow indirection table has been configured or is in the default

Re: [PATCH 2/2] fm10k: correctly report error when changing number of channels

2016-02-08 Thread Keller, Jacob E
On Mon, 2016-02-08 at 19:23 +, Jakub Kiciński wrote: > On Mon, 8 Feb 2016 17:13:15 +, Keller, Jacob E wrote: > > Maybe we can store it as a flag in the netdev structure instead? > > Either flag in the netdev or keep your reset callback.  Neither seems > spectacularly clean.  Maybe someone

[PATCH net] bonding: don't use stale speed and duplex information

2016-02-08 Thread Jay Vosburgh
There is presently a race condition between the bonding periodic link monitor and the updating of a slave's speed and duplex. The former occurs on a periodic basis, and the latter in response to a driver's calling of netif_carrier_on. It is possible for the periodic monitor to ru

Re: [PATCH net v3 2/4] net: add rx_nohandler stat counter

2016-02-08 Thread Stephen Hemminger
On Mon, 8 Feb 2016 13:32:54 -0500 Jarod Wilson wrote: > On Sun, Feb 07, 2016 at 12:19:28PM -0800, Eric Dumazet wrote: > > On Sun, 2016-02-07 at 14:46 -0500, David Miller wrote: > > > > > > Why was this userspace ABI change allowed? > > > > The stats structure is exposed to user space via netlink

Re: [PATCH 2/2] fm10k: correctly report error when changing number of channels

2016-02-08 Thread Jakub Kiciński
On Mon, 8 Feb 2016 17:13:15 +, Keller, Jacob E wrote: > On Mon, 2016-02-08 at 13:26 +, Jakub Kicinski wrote: > > On Fri,  5 Feb 2016 12:30:21 -0800, Jacob Keller wrote: > > > +#define FM10K_FLAG_RETA_TABLE_CONFIGURED (u32)(BIT(6)) > > > > If we go with your proposal every driver will have

Re: Disabling XPS for 4.4.0-1+ixgbe+OpenStack VM over a VLAN means 65% increase in netperf TCP_STREAM

2016-02-08 Thread Rick Jones
Shame on me for not including bare-iron TCP_RR: stack@fcperf-cp1-comp0001-mgmt:~$ grep "1 1" xps_tcp_rr_on_* | awk '{t+=$6;r+=$9;s+=$10}END{print "throughput",t/NR,"recv sd",r/NR,"send sd",s/NR}' throughput 18589.4 recv sd 21.6296 send sd 20.5931 stack@fcperf-cp1-comp0001-mgmt:~$ grep "

Re: [patch net-next RFC 0/6] Introduce devlink interface and first drivers to use it

2016-02-08 Thread Doug Ledford
On 02/07/2016 03:18 PM, roopa wrote: > On 2/3/16, 2:47 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> There a is need for some userspace API that would allow to expose things >> that are not directly related to any device class like net_device of >> ib_device, but rather chip-wide/switch-ASIC-wid

[PATCH] af_unix: Don't set err in unix_stream_read_generic unless there was an error

2016-02-08 Thread Rainer Weikusat
The present unix_stream_read_generic contains various code sequences of the form err = -EDISASTER; if () goto out; This has the unfortunate side effect of possibly causing the error code to bleed through to the final out: return copied ? : err; and then to be wrongly returned if

Re: [PATCH v2 6/6] dt-bindings: net: ks8995: add bindings documentation for ks8995

2016-02-08 Thread Sergei Shtylyov
Hello. On 02/08/2016 08:35 PM, Helmut Buchsbaum wrote: Signed-off-by: Helmut Buchsbaum --- .../devicetree/bindings/net/micrel-ks8995.txt| 20 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/micrel-ks8995.txt diff --gi

Re: [PATCH] af_unix: Don't set err in unix_stream_read_generic unless there was an error

2016-02-08 Thread Sergei Shtylyov
Hello. On 02/08/2016 06:33 PM, Rainer Weikusat wrote: The present unix_stream_read_generic contains various code sequences of the form err = -EDISASTER; if () goto out; This has the unfortunate side effect of possibly causing the error code to bleed through to the final out:

Re: [PATCH net v3 2/4] net: add rx_nohandler stat counter

2016-02-08 Thread Jarod Wilson
On Sun, Feb 07, 2016 at 12:19:28PM -0800, Eric Dumazet wrote: > On Sun, 2016-02-07 at 14:46 -0500, David Miller wrote: > > > > Why was this userspace ABI change allowed? > > > The stats structure is exposed to user space via netlink > > > and changing the size of responses will break iproute2 comm

Re: [PATCH] af_unix: Don't set err in unix_stream_read_generic unless there was an error

2016-02-08 Thread Rainer Weikusat
The present unix_stream_read_generic contains various code sequences of the form err = -EDISASTER; if () goto out; This has the unfortunate side effect of possibly causing the error code to bleed through to the final out: return copied ? : err; and then to be wrongly returned if

Re: Disabling XPS for 4.4.0-1+ixgbe+OpenStack VM over a VLAN means 65% increase in netperf TCP_STREAM

2016-02-08 Thread Rick Jones
On 02/04/2016 11:38 AM, Tom Herbert wrote: I'd start with verifying the XPS configuration is sane and then trying to reproduce the issue outside of using VMs, if both of those are okay then maybe look at some sort of bad interaction with OpenStack configuration. So, looking at bare-iron, I can

Re: [PATCH 8/9] rfkill: Userspace control for airplane mode

2016-02-08 Thread João Paulo Rechi Vita
On 8 February 2016 at 11:11, Dan Williams wrote: > On Mon, 2016-02-08 at 10:41 -0500, João Paulo Rechi Vita wrote: >> Provide an interface for the airplane-mode indicator be controlled >> from >> userspace. User has to first acquire the control through >> RFKILL_OP_AIRPLANE_MODE_ACQUIRE and keep t

Re: [PATCH v3 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2016-02-08 Thread Bendik Rønning Opstad
Eric, thank you for the feedback! On Wed, Feb 3, 2016 at 8:34 PM, Eric Dumazet wrote: > On Wed, 2016-02-03 at 19:17 +0100, Bendik Rønning Opstad wrote: >> On Tue, Feb 2, 2016 at 9:35 PM, Eric Dumazet wrote: >>> Really this looks very complicated. >> >> Can you be more specific? > > A lot of code

[PATCH v2 1/6] net: phy: spi_ks8995: introduce spi_device_id table

2016-02-08 Thread Helmut Buchsbaum
Refactor to use spi_device_id table to facilitate easy extendability. Signed-off-by: Helmut Buchsbaum --- drivers/net/phy/spi_ks8995.c | 42 -- 1 file changed, 40 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy/sp

[PATCH v2 3/6] net: phy: spi_ks8995: add support for resetting switch using GPIO

2016-02-08 Thread Helmut Buchsbaum
When using device tree it is no more possible to reset the PHY at board level. Furthermore, doing in the driver allows to power down the switch when it is not used any more. The patch introduces a new optional property "reset-gpios" denoting an appropriate GPIO handle, e.g.: reset-gpios = <&gpio0

[PATCH v2 5/6] net: phy: spi_ks8995: add support for MICREL KSZ8795CLX

2016-02-08 Thread Helmut Buchsbaum
Add support for MICREL KSZ8795CLX Integrated 5-Port, 10-/100-Managed Ethernet Switch with Gigabit GMII/RGMII and MII/RMII interfaces. Signed-off-by: Helmut Buchsbaum --- drivers/net/phy/spi_ks8995.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/net/ph

[PATCH v2 4/6] net: phy: spi_ks8995: generalize creation of SPI commands

2016-02-08 Thread Helmut Buchsbaum
Prepare creating SPI reads and writes for other switch families. The KS8995 family uses the straight forward <8bit CMD><8bit ADDR> sequence. To be able to support KSZ8795 family, which uses <3bit CMD><12bit ADDR><1 bit TR> make the SPI command creation chip variant dependent. Signe

[PATCH v2 6/6] dt-bindings: net: ks8995: add bindings documentation for ks8995

2016-02-08 Thread Helmut Buchsbaum
Signed-off-by: Helmut Buchsbaum --- .../devicetree/bindings/net/micrel-ks8995.txt| 20 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/micrel-ks8995.txt diff --git a/Documentation/devicetree/bindings/net/micrel-ks8995.txt b

[PATCH v2 0/6] Add support for MICREL KSZ8795CLX 5-port switch

2016-02-08 Thread Helmut Buchsbaum
This patch series refactors the spi-ks8995 driver to finally add support for the MICREL KSZ8795CLX. Additionally support for controlling a GPIO line for resetting the switch is added. Helmut Changes since v1: - removed initializing registers from Device Tree following Florian's advice - fixe

[PATCH v2 2/6] net: phy: spi_ks8995: verify chip and determine revision

2016-02-08 Thread Helmut Buchsbaum
Since the chip variant is now determined by spi_device_id, verify family and chip id and determine the revision id. Signed-off-by: Helmut Buchsbaum --- drivers/net/phy/spi_ks8995.c | 118 +-- 1 file changed, 80 insertions(+), 38 deletions(-) diff --git a/

Re: [PATCH v3 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2016-02-08 Thread Bendik Rønning Opstad
Sorry guys, I messed up that email by including HTML, and it got rejected by netdev@vger.kernel.org. I'll resend it properly formatted. Bendik On 08/02/16 18:17, Bendik Rønning Opstad wrote: > Eric, thank you for the feedback! > > On Wed, Feb 3, 2016 at 8:34 PM, Eric Dumazet wrote: >> On Wed, 2

Re: [PATCH 8/9] rfkill: Userspace control for airplane mode

2016-02-08 Thread João Paulo Rechi Vita
Hello Marcel, On 8 February 2016 at 11:20, Marcel Holtmann wrote: > Hi Joa Paulo, > >> Provide an interface for the airplane-mode indicator be controlled from >> userspace. User has to first acquire the control through >> RFKILL_OP_AIRPLANE_MODE_ACQUIRE and keep the fd open for the whole time >>

Re: [PATCH/RFC v4 net-next] ravb: Add dma queue interrupt support

2016-02-08 Thread Yoshihiro Kaneko
Hi Sergei-san, 2016-02-08 2:09 GMT+09:00 Sergei Shtylyov : > Hello. > > On 02/07/2016 07:50 PM, Yoshihiro Kaneko wrote: > >> I apologize for not responding to you earlier. > > >Absolutely no problem, these reviews/tests take time from my main tasks > anyway. :-) > > From: Kazuya Mizuguchi

Re: [PATCH 8/9] rfkill: Userspace control for airplane mode

2016-02-08 Thread Johannes Berg
On 2016-02-08 17:20, Marcel Holtmann wrote: as explained in an earlier response, the concept Airplane Mode seems to be imposing policy into the kernel. Do we really want have this as a kernel exposed API. This patch is the one that *solves* that problem ... please read it more carefully? jo

Re: [PATCH 2/2] fm10k: correctly report error when changing number of channels

2016-02-08 Thread Keller, Jacob E
On Mon, 2016-02-08 at 13:26 +, Jakub Kicinski wrote: > Hi Jacob! > > First of all thanks for putting your time into sorting this out, > figuring out what to do with user-set RSS table when queues are > reconfigured was a head scratcher for me as well. > Yep! > On Fri,  5 Feb 2016 12:30:21 -

RE: bonding reports interface up with 0 Mbps

2016-02-08 Thread Tantilov, Emil S
>-Original Message- >From: Jay Vosburgh [mailto:jay.vosbu...@canonical.com] >Sent: Thursday, February 04, 2016 4:37 PM >To: Tantilov, Emil S >Cc: netdev@vger.kernel.org; go...@cumulusnetworks.com; zhuyj >; j...@mellanox.com >Subject: Re: bonding reports interface up with 0 Mbps > >Jay Vosb

Re: [PATCH 8/9] rfkill: Userspace control for airplane mode

2016-02-08 Thread Marcel Holtmann
Hi Joa Paulo, > Provide an interface for the airplane-mode indicator be controlled from > userspace. User has to first acquire the control through > RFKILL_OP_AIRPLANE_MODE_ACQUIRE and keep the fd open for the whole time > it wants to be in control of the indicator. Closing the fd or using > RFKIL

Re: [PATCH net-next 1/2] mpls: packet stats

2016-02-08 Thread Robert Shearman
On 06/02/16 10:58, Francois Romieu wrote: Robert Shearman : [...] diff --git a/net/mpls/Makefile b/net/mpls/Makefile index 9ca923625016..6fdd61b9eae3 100644 --- a/net/mpls/Makefile +++ b/net/mpls/Makefile [...] @@ -98,6 +94,29 @@ bool mpls_pkt_too_big(const struct sk_buff *skb, unsigned int

  1   2   >