On Sun, Feb 7, 2016 at 11:19 AM, David Miller <da...@davemloft.net> wrote: > From: Mahesh Bandewar <mah...@bandewar.net> > Date: Tue, 2 Feb 2016 11:20:30 -0800 > >> From: Mahesh Bandewar <mahe...@google.com> >> >> The mode argument was erronusly defined as u32 but it has always >> been u16. >> >> Signed-off-by: Mahesh Bandewar <mahe...@google.com> > > This patch is changing more than this. > > Specifically it is invoking ipvlan_set_port_mode() instead of assigning > port->mode directly in ipvlan_link_new(). > > That minimally needs to be documented in the commit log message. > > But I also wonder if for some reason in this conect the direct > assignment happens to be fine. That's pretty much why you should > explain things.
Directly assigning does serve the same purpose, however when there is a helper to do just that (and other things in future) it would help keep all related things at one place avoiding errors in future. Since it's a minor improvement I did not mention that into the commit log. I'll update the commit log and resend.
