[PATCH 1/1] ixgbe: force to synchronize reporting "link on" and getting speed and duplex

2015-12-22 Thread zyjzyj2000
From: Zhu Yanjun In X540 NIC, there is a time span between reporting "link on" and getting the speed and duplex. To a bonding driver in 802.3ad mode, this time span will make it not work well if the time span is big enough. The big time span will make bonding driver change the state of the slave

[PATCHv2 net-next 4/4] cxgb4: Use napi_complete_done() api in napi handler

2015-12-22 Thread Hariprasad Shenai
Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/cxgb4/sge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/sge.c b/drivers/net/ethernet/chelsio/cxgb4/sge.c index 138be46..5e3ffa7 100644 --- a/drivers/net/ethernet/chelsio/c

[PATCHv2 net-next 3/4] cxgb4: Use the node info to alloc_ring() for RX queues

2015-12-22 Thread Hariprasad Shenai
Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/cxgb4/sge.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/sge.c b/drivers/net/ethernet/chelsio/cxgb4/sge.c index 0333435..138be46 100644 --- a/drivers/net/ethernet/che

[PATCHv2 net-next 0/4] Trivial enhancements for cxgb4

2015-12-22 Thread Hariprasad Shenai
Hi This series adds a debug message if adapter isn't inserted in right PCI slot. Changes naming conventions for iSCSI rx queues, use node info while allocating rx queue and use napi_complete_done() api in napi handler. This patch series has been created against net-next tree and includes patches

[PATCHv2 net-next 2/4] cxgb4: get naming correct for iscsi queues

2015-12-22 Thread Hariprasad Shenai
All the upper level protocols like rdma, iscsi have their own offload rx queues, so instead of using the generic naming convention be specific while naming them. Improves code readability Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 13 +++--- drivers

[PATCHv2 net-next 1/4] cxgb4: Warn if device doesn't have enough PCI bandwidth

2015-12-22 Thread Hariprasad Shenai
Check if the device get enough bandwidth from the entire PCI chain to satisfy its capabilities. This patch determines the PCIe device's bandwidth capabilities by reading its PCIe Link Capabilities registers and then call the pcie_get_minimum_link function to ensure that the adapter is hooked into a

Re: [PATCH net-next 3/5] cxgb4: add dcb info node in debugfs

2015-12-22 Thread Hariprasad Shenai
On Tue, Dec 22, 2015 at 15:45:52 -0500, David Miller wrote: > From: Or Gerlitz > Date: Mon, 21 Dec 2015 09:33:22 +0200 > > > On Mon, Dec 21, 2015 at 9:16 AM, Hariprasad Shenai > > wrote: > >> Add new /sys/kernel/debug/cxgb4/*/dcb_info node to dump out > >> various Data Center Bridging informatio

RE: [PATCH v2] r8152: fix lockup when runtime PM is enabled

2015-12-22 Thread Hayes Wang
Oliver Neukum [mailto:oneu...@suse.com] [...] > It is clear to me that you cannot get away with using the same operation > for resume() and reset_resume() in your driver. It is fundamentally > impossible. Firmware cannot fix it. I would think how to fix it. > Sorry for the length of the explanati

[PATCH 3/3] drivers: net: cpsw: use of_phy_connect() in fixed-link case

2015-12-22 Thread David Rivshin (Allworx)
From: David Rivshin If a fixed-link DT subnode is used, the phy_device was looked up so that a PHY ID string could be constructed and passed to phy_connect(). This is not necessary, as the device_node can be passed directly to of_phy_connect() instead. This reuses the same codepath as if the phy-

[PATCH 1/3] drivers: net: cpsw: fix parsing of phy-handle DT property in dual_emac config

2015-12-22 Thread David Rivshin (Allworx)
From: David Rivshin Commit 9e42f715264ff158478fa30eaed847f6e131366b ("drivers: net: cpsw: add phy-handle parsing") saved the "phy-handle" phandle into a new cpsw_priv field. However, phy connections are per-slave, so the phy_node field should be in cpsw_slave_data rather than cpsw_priv. This wou

[PATCH 2/3] drivers: net: cpsw: fix error messages when using phy-handle DT property

2015-12-22 Thread David Rivshin (Allworx)
From: David Rivshin The phy-handle, phy_id, and fixed-link properties are mutually exclusive, and only one need be specified. However if phy-handle was specified, an error message would complain about the lack of phy_id or fixed-link. Also, if phy-handle was specified and the subsequent of_phy_c

[PATCH 0/3] drivers: net: cpsw: phy-handle fixes

2015-12-22 Thread David Rivshin (Allworx)
From: David Rivshin This series is based on the tip of the net tree. The first patch fixes a bug that makes dual_emac mode break if either slave uses the phy-handle property in the devicetree. The second patch fixes some cosmetic problems with error messages, and also makes the binding document

Re: [PATCH net-next 1/4] soreuseport: define reuseport groups

2015-12-22 Thread Craig Gallek
On Tue, Dec 22, 2015 at 5:11 PM, kbuild test robot wrote: > Hi Craig, > > [auto build test ERROR on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Craig-Gallek/Faster-SO_REUSEPORT/20151223-040911 > config: arm-mvebu_v7_defconfig (attached as .config) > reproduce: >

Re: [RFC PATCH 16/17] calipso: Add validation of CALIPSO option.

2015-12-22 Thread Huw Davies
On Tue, Dec 22, 2015 at 10:47:43PM +0100, Hannes Frederic Sowa wrote: > On 22.12.2015 17:59, Huw Davies wrote: > > I'm confused about this one. AFAICS, this will drop packets that we > > can't process. We don't send the icmp error, but I can certainly add > > that. Is that what you mean? > > Ac

Re: [PATCH 1/1] phy: micrel: Fix finding PHY properties in MAC node for KSZ9031.

2015-12-22 Thread David Miller
From: Andrew Lunn Date: Tue, 22 Dec 2015 12:06:34 +0100 > On Tue, Dec 22, 2015 at 11:58:40AM +0100, Henri Roosen wrote: >> Commit 651df2183543 ("phy: micrel: Fix finding PHY properties in MAC >> node.") only fixes finding PHY properties in MAC node for KSZ9021. This >> commit applies the same fi

Re: [PATCH net-next 1/4] soreuseport: define reuseport groups

2015-12-22 Thread kbuild test robot
Hi Craig, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Craig-Gallek/Faster-SO_REUSEPORT/20151223-040911 config: arm-mvebu_v7_defconfig (attached as .config) reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plai

Re: [PATCH net-next 1/4] soreuseport: define reuseport groups

2015-12-22 Thread David Miller
From: Craig Gallek Date: Tue, 22 Dec 2015 16:58:11 -0500 > On Tue, Dec 22, 2015 at 4:40 PM, David Miller wrote: >> From: Craig Gallek >> Date: Tue, 22 Dec 2015 15:05:07 -0500 >> >>> + for (i = 0; i < reuse->num_socks; i++) { >>> + if (reuse->socks[i] == sk) { >>> +

Re: [PATCH v2 -next 0/3] tcp: honour SO_BINDTODEVICE for TW_RST case too

2015-12-22 Thread David Miller
From: Florian Westphal Date: Mon, 21 Dec 2015 21:29:23 +0100 > This is V2, this time as a small series since I followed Erics advice > to split this into smaller chunks, I hope this makes it easier to > review. > > First patch adds inet_sk_transparent helper. > Second patch contains an if/else s

Re: [Patch net] addrconf: always initialize sysctl table data

2015-12-22 Thread David Miller
From: Cong Wang Date: Mon, 21 Dec 2015 10:55:45 -0800 > When sysctl performs restrict writes, it allows to write from > a middle position of a sysctl file, which requires us to initialize > the table data before calling proc_dostring() for the write case. > > Fixes: 3d1bec99320d ("ipv6: introduc

Re: [PATCH net-next 1/4] soreuseport: define reuseport groups

2015-12-22 Thread Craig Gallek
On Tue, Dec 22, 2015 at 4:40 PM, David Miller wrote: > From: Craig Gallek > Date: Tue, 22 Dec 2015 15:05:07 -0500 > >> + for (i = 0; i < reuse->num_socks; i++) { >> + if (reuse->socks[i] == sk) { >> + reuse->socks[i] = reuse->socks[reuse->num_socks - 1]; >> +

Re: suspicious RCU usage (netlink/rhashtable)

2015-12-22 Thread Dave Jones
On Tue, Dec 22, 2015 at 04:50:20PM -0500, David Miller wrote: > > > > Simple fix is below. Though, I don't understand the history of the > > > > multiple locks in this structure to be sure it's correct. I'll send > > > > it as a formal patch. Please reject if it's not the right approach.

[PATCH v2] net-next: Add tcindex to conntrack and add netfilter target/matches

2015-12-22 Thread Luuk Paulussen
This patch implements support for setting/matching the skb->tc_index field from Xtables, as well as allowing it to be saved/restored using connection tracking. This provides 16 extra bits of mark space that can be saved/restored from the connection (for performance benefits) when the marking is be

[no subject]

2015-12-22 Thread Luuk Paulussen
Sorry for the resend. I forgot to include relevant netfilter maintainers in CC list Changes from v1 are to add dependency on NF_CONNTRACK to Kconfig to resolve the build issue and some style fixups from checkpatch. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body

Re: suspicious RCU usage (netlink/rhashtable)

2015-12-22 Thread David Miller
From: Dave Jones Date: Tue, 22 Dec 2015 16:47:34 -0500 > On Tue, Dec 22, 2015 at 04:42:25PM -0500, David Miller wrote: > > From: Craig Gallek > > Date: Tue, 22 Dec 2015 16:38:32 -0500 > > > > > On Tue, Dec 22, 2015 at 4:28 PM, David Miller > wrote: > > >> From: Craig Gallek > > >> Date

Re: IPv6 route to gateway on fe80::1%eth0 when I have fe80::1%br0 locally

2015-12-22 Thread Hannes Frederic Sowa
Hi Marc, On 22.12.2015 22:28, Marc Haber wrote: > Hi Hannes, > > thanks for your mail. > > On Tue, Dec 22, 2015 at 04:15:14PM +0100, Hannes Frederic Sowa wrote: >> On 12.12.2015 20:58, Marc Haber wrote: >>> Any hints would be appreciated. >> >> This sysctl should help: >> >> accept_ra_from_local

Re: [RFC PATCH 16/17] calipso: Add validation of CALIPSO option.

2015-12-22 Thread Hannes Frederic Sowa
On 22.12.2015 17:59, Huw Davies wrote: > On Tue, Dec 22, 2015 at 02:50:20PM +0100, Hannes Frederic Sowa wrote: >> On 22.12.2015 12:46, Huw Davies wrote: >>> >>> +/* CALIPSO RFC 5570 */ >>> + >>> +static bool ipv6_hop_calipso(struct sk_buff *skb, int optoff) >>> +{ >>> + const unsigned char *nh

Re: suspicious RCU usage (netlink/rhashtable)

2015-12-22 Thread Dave Jones
On Tue, Dec 22, 2015 at 04:42:25PM -0500, David Miller wrote: > From: Craig Gallek > Date: Tue, 22 Dec 2015 16:38:32 -0500 > > > On Tue, Dec 22, 2015 at 4:28 PM, David Miller wrote: > >> From: Craig Gallek > >> Date: Tue, 22 Dec 2015 15:51:19 -0500 > >> > >>> I was actually just looking

Re: suspicious RCU usage (netlink/rhashtable)

2015-12-22 Thread Craig Gallek
On Tue, Dec 22, 2015 at 4:42 PM, David Miller wrote: > From: Craig Gallek > Date: Tue, 22 Dec 2015 16:38:32 -0500 > >> On Tue, Dec 22, 2015 at 4:28 PM, David Miller wrote: >>> From: Craig Gallek >>> Date: Tue, 22 Dec 2015 15:51:19 -0500 >>> I was actually just looking at this as well (thou

Re: [PATCH -next 2/3] tcp: send_reset: test for non-NULL sk first

2015-12-22 Thread Hannes Frederic Sowa
On 21.12.2015 21:29, Florian Westphal wrote: > tcp_md5_do_lookup requires a full socket, so once we extend > _send_reset() to also accept timewait socket we would have to change > > if (!sk && hash_location) > > to something like > > if ((!sk || !sk_fullsock(sk)) && hash_location) { > ... > }

Re: [PATCH -next 1/3] net: add inet_sk_transparent() helper

2015-12-22 Thread Hannes Frederic Sowa
On 21.12.2015 21:29, Florian Westphal wrote: > Avoids cluttering tcp_v4_send_reset when followup patch extends > it to deal with timewait sockets. > > Suggested-by: Eric Dumazet > Signed-off-by: Florian Westphal Acked-by: Hannes Frederic Sowa -- To unsubscribe from this list: send the line "u

Re: [PATCH v2 -next 3/3] tcp: honour SO_BINDTODEVICE for TW_RST case too

2015-12-22 Thread Hannes Frederic Sowa
On 21.12.2015 21:29, Florian Westphal wrote: > Hannes points out that when we generate tcp reset for timewait sockets we > pretend we found no socket and pass NULL sk to tcp_vX_send_reset(). > > Make it cope with inet tw sockets and then provide tw sk. > > This makes RSTs appear on correct interf

Re: suspicious RCU usage (netlink/rhashtable)

2015-12-22 Thread David Miller
From: Craig Gallek Date: Tue, 22 Dec 2015 16:38:32 -0500 > On Tue, Dec 22, 2015 at 4:28 PM, David Miller wrote: >> From: Craig Gallek >> Date: Tue, 22 Dec 2015 15:51:19 -0500 >> >>> I was actually just looking at this as well (though a slightly >>> different stack). The issue is with: c6ff5268

Re: [PATCH net-next 1/4] soreuseport: define reuseport groups

2015-12-22 Thread David Miller
From: Craig Gallek Date: Tue, 22 Dec 2015 15:05:07 -0500 > + for (i = 0; i < reuse->num_socks; i++) { > + if (reuse->socks[i] == sk) { > + reuse->socks[i] = reuse->socks[reuse->num_socks - 1]; > + reuse->num_socks--; > +

Re: suspicious RCU usage (netlink/rhashtable)

2015-12-22 Thread Craig Gallek
On Tue, Dec 22, 2015 at 4:28 PM, David Miller wrote: > From: Craig Gallek > Date: Tue, 22 Dec 2015 15:51:19 -0500 > >> I was actually just looking at this as well (though a slightly >> different stack). The issue is with: c6ff5268293e rhashtable: Fix >> walker list corruption >> >> It changed th

Re: suspicious RCU usage (netlink/rhashtable)

2015-12-22 Thread David Miller
From: Craig Gallek Date: Tue, 22 Dec 2015 15:51:19 -0500 > I was actually just looking at this as well (though a slightly > different stack). The issue is with: c6ff5268293e rhashtable: Fix > walker list corruption > > It changed the lock acquired in rhashtable_walk_init to use the new > spinlo

Re: IPv6 route to gateway on fe80::1%eth0 when I have fe80::1%br0 locally

2015-12-22 Thread Marc Haber
Hi Hannes, thanks for your mail. On Tue, Dec 22, 2015 at 04:15:14PM +0100, Hannes Frederic Sowa wrote: > On 12.12.2015 20:58, Marc Haber wrote: > > Any hints would be appreciated. > > This sysctl should help: > > accept_ra_from_local - BOOLEAN > Accept RA with source-address that is fou

Re: pull request (net): ipsec 2015-12-22

2015-12-22 Thread David Miller
From: Steffen Klassert Date: Tue, 22 Dec 2015 10:35:18 +0100 > Just one patch to fix dst_entries_init with multiple namespaces. > From Dan Streetman. > > Please pull or let me know if there are problems. Pulled, thanks Steffen. -- To unsubscribe from this list: send the line "unsubscribe netdev

Re: [patch net-next v2] mlxsw: core: Use devm_kzalloc to allocate mlxsw_hwmon structure

2015-12-22 Thread David Miller
From: Jiri Pirko Date: Tue, 22 Dec 2015 09:43:07 +0100 > From: Jiri Pirko > > KASan reported use-after-free for the hwmon structure. So fix this by > using devm_kzalloc and let the core take care about freeing the memory > during device dettach. > > Reported-by: Ido Schimmel > Fixes: 89309da3

Re: net: user-controllable kmalloc size in __sctp_setsockopt_connectx

2015-12-22 Thread Marcelo Ricardo Leitner
Hi, On Tue, Dec 22, 2015 at 09:13:54PM +0100, Dmitry Vyukov wrote: > Hello, ... > > [] __sctp_setsockopt_connectx+0xc6/0x150 > net/sctp/socket.c:1318 > [< inline >] sctp_getsockopt_connectx3 net/sctp/socket.c:1410 > [] sctp_getsockopt+0x25ee/0x3e00 net/sctp/socket.c:6007 > [] sock_com

Re: [PATCH] net: tcp: deal with listen sockets properly in tcp_abort.

2015-12-22 Thread David Miller
From: Lorenzo Colitti Date: Tue, 22 Dec 2015 00:03:44 +0900 > When closing a listen socket, tcp_abort currently calls > tcp_done without clearing the request queue. If the socket has a > child socket that is established but not yet accepted, the child > socket is then left without a parent, causi

Re: [patch net-next] mlxsw: core: Allow to reset temperature history via hwmon interface

2015-12-22 Thread David Miller
From: Jiri Pirko Date: Mon, 21 Dec 2015 11:14:21 +0100 > From: Jiri Pirko > > Add another sysfs hwmon attribute to expose possibility to reset > temperature sensors history. > > Signed-off-by: Jiri Pirko Applied, thanks Jiri. -- To unsubscribe from this list: send the line "unsubscribe netde

Re: [PATCH] ipv6/addrlabel: fix ip6addrlbl_get()

2015-12-22 Thread David Miller
From: Andrey Ryabinin Date: Mon, 21 Dec 2015 12:54:45 +0300 > ip6addrlbl_get() has never worked. If ip6addrlbl_hold() succeeded, > ip6addrlbl_get() will exit with '-ESRCH'. If ip6addrlbl_hold() failed, > ip6addrlbl_get() will use about to be free ip6addrlbl_entry pointer. > > Fix this by inverti

Re: [patch net] switchdev: bridge: Pass ageing time as clock_t instead of jiffies

2015-12-22 Thread David Miller
From: Jiri Pirko Date: Mon, 21 Dec 2015 09:56:01 +0100 > From: Ido Schimmel > > The bridge's ageing time is offloaded to hardware when: > 1) A port joins a bridge > 2) The ageing time of the bridge is changed > > In the first case the ageing time is offloaded as jiffies, but in the

Re: suspicious RCU usage (netlink/rhashtable)

2015-12-22 Thread Craig Gallek
On Tue, Dec 22, 2015 at 3:45 PM, Dave Jones wrote: > === > [ INFO: suspicious RCU usage. ] > 4.4.0-rc6-think+ #1 Not tainted > --- > lib/rhashtable.c:522 suspicious rcu_dereference_protected() usage! > > other info that might help us debug th

Re: suspicious RCU usage (netlink/rhashtable)

2015-12-22 Thread David Miller
From: Dave Jones Date: Tue, 22 Dec 2015 15:45:39 -0500 > === > [ INFO: suspicious RCU usage. ] > 4.4.0-rc6-think+ #1 Not tainted > --- > lib/rhashtable.c:522 suspicious rcu_dereference_protected() usage! > > other info that might help us de

suspicious RCU usage (netlink/rhashtable)

2015-12-22 Thread Dave Jones
=== [ INFO: suspicious RCU usage. ] 4.4.0-rc6-think+ #1 Not tainted --- lib/rhashtable.c:522 suspicious rcu_dereference_protected() usage! other info that might help us debug this: rcu_scheduler_active = 1, debug_locks = 0 2 locks held by t

Re: [PATCH net-next 3/5] cxgb4: add dcb info node in debugfs

2015-12-22 Thread David Miller
From: Or Gerlitz Date: Mon, 21 Dec 2015 09:33:22 +0200 > On Mon, Dec 21, 2015 at 9:16 AM, Hariprasad Shenai > wrote: >> Add new /sys/kernel/debug/cxgb4/*/dcb_info node to dump out >> various Data Center Bridging information. > > why? what's wrong with using the lldp tool for that purpose? Agre

Re: [PATCH] dccp: fix use-after-free after cloning struct dccp_sock

2015-12-22 Thread David Miller
From: Vegard Nossum Date: Sun, 20 Dec 2015 21:53:27 +0100 > @@ -115,6 +115,10 @@ struct sock *dccp_create_openreq_child(const struct sock > *sk, > newdp->dccps_isr = dreq->dreq_isr; > newdp->dccps_gsr = dreq->dreq_gsr; > > + newdp->dccps_hc_rx_ackvec = N

Re: [PATCH] sh_eth: fix 16-bit descriptor field access endianness too

2015-12-22 Thread David Miller
From: Sergei Shtylyov Date: Sun, 20 Dec 2015 01:48:04 +0300 > Commit 1299653affa4 ("sh_eth: fix descriptor access endianness") only > addressed the 32-bit buffer address field byte-swapping but the driver > still accesses 16-bit frame/buffer length descriptor fields without the > necessary byte-

Re: [PATCH v2] RDS: don't pretend to use cpu notifiers

2015-12-22 Thread David Miller
From: Santosh Shilimkar Date: Sat, 19 Dec 2015 12:55:43 -0800 > From: Sebastian Andrzej Siewior > > It looks like an attempt to use CPU notifier here which was never > completed. Nobody tried to wire it up completely since 2k9. So I unwind > this code and get rid of everything not required. Oh

Re: [PATCH] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2015-12-22 Thread David Miller
From: Vijay Pandurangan Date: Fri, 18 Dec 2015 14:34:59 -0500 > Packets that arrive from real hardware devices have ip_summed == > CHECKSUM_UNNECESSARY if the hardware verified the checksums, or > CHECKSUM_NONE if the packet is bad or it was unable to verify it. The > current version of veth will

net: user-controllable kmalloc size in __sctp_setsockopt_connectx

2015-12-22 Thread Dmitry Vyukov
Hello, The following program triggers WARNING in kmalloc: // autogenerated by syzkaller (http://github.com/google/syzkaller) #include #include #include #include int main() { long r0 = syscall(SYS_mmap, 0x2000ul, 0x4000ul, 0x3ul, 0x32ul, 0xul, 0x0ul); long

Re: [REGRESSION] tcp/ipv4: kernel panic because of (possible) division by zero

2015-12-22 Thread Oleksandr Natalenko
That is correct, I have net.ipv4.tcp_ecn set to 1. I've recompiled the kernel with proposed patch, now still waiting for issue to be triggered. Could I manually simulate the erroneous TCP ECN behavior to speed up the debugging? On понеділок, 21 грудня 2015 р. 18:10:32 EET Yuchung Cheng wrote:

Re: [PATCH net-next 2/5] sfc: Handle MCDI proxy authorisation

2015-12-22 Thread David Miller
From: Bert Kenward Date: Fri, 18 Dec 2015 17:09:04 + > +#ifdef DEBUG > + WARN_ON(1); > +#endif Don't do stuff like this. Either the assertion is valid and belongs here, or it doesn't. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message t

[PATCH net-next 4/4] soreuseport: BPF selection functional test

2015-12-22 Thread Craig Gallek
From: Craig Gallek This program will build classic and extended BPF programs and validate the socket selection logic when used with SO_ATTACH_REUSEPORT_CBPF and SO_ATTACH_REUSEPORT_EBPF. It also validates the re-programing flow and several edge cases. Signed-off-by: Craig Gallek --- tools/tes

[PATCH net-next 1/4] soreuseport: define reuseport groups

2015-12-22 Thread Craig Gallek
From: Craig Gallek struct sock_reuseport is an optional shared structure referenced by each socket belonging to a reuseport group. When a socket is bound to an address/port not yet in use and the reuseport flag has been set, the structure will be allocated and attached to the newly bound socket.

[PATCH net-next 3/4] soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF

2015-12-22 Thread Craig Gallek
From: Craig Gallek Expose socket options for setting a classic or extended BPF program for use when selecting sockets in an SO_REUSEPORT group. These options can be used on the first socket to belong to a group before bind or on any socket in the group after bind. This change includes refactori

[PATCH net-next 0/4] Faster SO_REUSEPORT

2015-12-22 Thread Craig Gallek
From: Craig Gallek This series contains two optimizations for the SO_REUSEPORT feature: Faster lookup when selecting a socket for an incoming packet and the ability to select the socket from the group using a BPF program. This series only includes the UDP path. I plan to submit a follow-up incl

[PATCH net-next 2/4] soreuseport: fast reuseport UDP socket selection

2015-12-22 Thread Craig Gallek
From: Craig Gallek Include a struct sock_reuseport instance when a UDP socket binds to a specific address for the first time with the reuseport flag set. When selecting a socket for an incoming UDP packet, use the information available in sock_reuseport if present. This required adding an additi

Re: [PATCH] net-sysfs: use to_net_dev in net_namespace()

2015-12-22 Thread David Miller
From: Geliang Tang Date: Tue, 22 Dec 2015 23:11:49 +0800 > Use to_net_dev() instead of open-coding it. > > Signed-off-by: Geliang Tang Applied to net-next, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More ma

Re: [PATCH 0/2] Netfilter fixes for net

2015-12-22 Thread David Miller
From: Pablo Neira Ayuso Date: Tue, 22 Dec 2015 18:53:15 +0100 > The following patchset contains two netfilter fixes: > > 1) Oneliner from Florian to dump missing NFT_CT_L3PROTOCOL netlink >attribute, from Florian Westphal. > > 2) Another oneliner for nf_tables to use skb->protocol from the

Re: [net-next 00/10][pull request] 100GbE Intel Wired LAN Driver Updates 2015-12-22

2015-12-22 Thread David Miller
From: Jeff Kirsher Date: Tue, 22 Dec 2015 06:02:02 -0800 > This series contains updates to fm10k only. Pulled, thanks a lot Jeff. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.

Re: [PATCH V1 00/16] add Intel(R) X722 iWARP driver

2015-12-22 Thread Doug Ledford
On 12/21/2015 06:13 PM, Faisal Latif wrote: > This (V1) series contains the addition of the i40iw.ko driver after > incorporating the feedback from Christoph Hellwig and Joe Perches for > initial series. > > This driver provides iWARP RDMA functionality for the Intel(R) X722 Ethernet > controller

Re: [PATCH v2 -next 3/3] tcp: honour SO_BINDTODEVICE for TW_RST case too

2015-12-22 Thread Eric Dumazet
On Mon, 2015-12-21 at 21:29 +0100, Florian Westphal wrote: > Hannes points out that when we generate tcp reset for timewait sockets we > pretend we found no socket and pass NULL sk to tcp_vX_send_reset(). > > Make it cope with inet tw sockets and then provide tw sk. > > This makes RSTs appear on

Re: [PATCH -next 1/3] net: add inet_sk_transparent() helper

2015-12-22 Thread Eric Dumazet
On Mon, 2015-12-21 at 21:29 +0100, Florian Westphal wrote: > Avoids cluttering tcp_v4_send_reset when followup patch extends > it to deal with timewait sockets. > > Suggested-by: Eric Dumazet > Signed-off-by: Florian Westphal > --- Acked-by: Eric Dumazet -- To unsubscribe from this list: sen

Re: [PATCH -next 2/3] tcp: send_reset: test for non-NULL sk first

2015-12-22 Thread Eric Dumazet
On Mon, 2015-12-21 at 21:29 +0100, Florian Westphal wrote: > tcp_md5_do_lookup requires a full socket, so once we extend > _send_reset() to also accept timewait socket we would have to change > Acked-by: Eric Dumazet -- To unsubscribe from this list: send the line "unsubscribe netdev" in the b

Re: [PATCH 1/2] can: sja1000: add documentation for Technologic Systems version

2015-12-22 Thread Rob Herring
On Mon, Dec 21, 2015 at 9:09 AM, Damien Riegel wrote: > On Sat, Dec 19, 2015 at 09:37:42PM -0600, Rob Herring wrote: >> On Fri, Dec 18, 2015 at 03:17:24PM -0500, Damien Riegel wrote: >> > This commit adds documentation for the Technologic Systems version of >> > SJA1000. The difference with the NX

Re: [PATCH 3/8] cgroup: implement cgroup_get_from_path() and expose cgroup_put()

2015-12-22 Thread Tejun Heo
Hello, Serge. On Mon, Dec 21, 2015 at 06:22:41PM -0600, Serge E. Hallyn wrote: > I'm trying to figure out how to handle this in the cgroup ns patchset. > Is this going to be purely used internally? From the user i see in > this patchset it looks like I should leave it be (and have @path always >

[PATCH 1/2] netfilter: nf_tables: use skb->protocol instead of assuming ethernet header

2015-12-22 Thread Pablo Neira Ayuso
Otherwise we may end up with incorrect network and transport header for other protocols. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_tables_netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/nf_tables_netdev.c b/net/netfilter/nf_tables_netdev.c i

[PATCH 2/2] netfilter: nft_ct: include direction when dumping NFT_CT_L3PROTOCOL key

2015-12-22 Thread Pablo Neira Ayuso
From: Florian Westphal one nft userspace test case fails with 'ct l3proto original ipv4' mismatches 'ct l3proto ipv4' ... because NFTA_CT_DIRECTION attr is missing. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nft_ct.c | 1 + 1 file changed, 1 insertion

[PATCH 0/2] Netfilter fixes for net

2015-12-22 Thread Pablo Neira Ayuso
Hi David, The following patchset contains two netfilter fixes: 1) Oneliner from Florian to dump missing NFT_CT_L3PROTOCOL netlink attribute, from Florian Westphal. 2) Another oneliner for nf_tables to use skb->protocol from the new netdev family, we can't assume ethernet there. You can pu

Re: [RFC PATCH 00/17] CALIPSO implementation

2015-12-22 Thread Huw Davies
On Tue, Dec 22, 2015 at 09:28:37AM -0800, Casey Schaufler wrote: > On 12/22/2015 3:46 AM, Huw Davies wrote: > > This patch series implements RFC 5570 - Common Architecture Label IPv6 > > Security Option (CALIPSO). Its goal is to set MLS sensitivity labels > > on IPv6 packets using a hop-by-hop opt

Re: [RFC PATCH 00/17] CALIPSO implementation

2015-12-22 Thread Casey Schaufler
On 12/22/2015 3:46 AM, Huw Davies wrote: > This patch series implements RFC 5570 - Common Architecture Label IPv6 > Security Option (CALIPSO). Its goal is to set MLS sensitivity labels > on IPv6 packets using a hop-by-hop option. CALIPSO very similar to > its IPv4 cousin CIPSO and much of this se

Re: [PATCH net-next V2 3/4] net/mlx5e: Add HW timestamping (TS) support

2015-12-22 Thread Richard Cochran
On Tue, Dec 22, 2015 at 12:00:52PM +0200, Saeed Mahameed wrote: > Ok, but what will happen if somehow tstamp->overflow_period is zero ? > the work will run too rapidly. > don't we need to have protection against such case. Why not return an error in that case? Thanks, Richard -- To unsubscribe fr

Re: [RFC PATCH 16/17] calipso: Add validation of CALIPSO option.

2015-12-22 Thread Huw Davies
On Tue, Dec 22, 2015 at 02:50:20PM +0100, Hannes Frederic Sowa wrote: > On 22.12.2015 12:46, Huw Davies wrote: > > > > +/* CALIPSO RFC 5570 */ > > + > > +static bool ipv6_hop_calipso(struct sk_buff *skb, int optoff) > > +{ > > + const unsigned char *nh = skb_network_header(skb); > > + > > + i

Re: IPv6 route to gateway on fe80::1%eth0 when I have fe80::1%br0 locally

2015-12-22 Thread Hannes Frederic Sowa
On 12.12.2015 20:58, Marc Haber wrote: > Any hints would be appreciated. This sysctl should help: accept_ra_from_local - BOOLEAN Accept RA with source-address that is found on local machine if the RA is otherwise proper and able to be accepted. Default is to NOT accept the

[PATCH] net-sysfs: use to_net_dev in net_namespace()

2015-12-22 Thread Geliang Tang
Use to_net_dev() instead of open-coding it. Signed-off-by: Geliang Tang --- net/core/net-sysfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index bca8c35..b6c8a66 100644 --- a/net/core/net-sysfs.c +++ b/net/core/net-sysfs.c

Re: [PATCH/RFC v2 net-next] ravb: Add dma queue interrupt support

2015-12-22 Thread Sergei Shtylyov
Hello. On 12/20/2015 12:15 PM, Yoshihiro Kaneko wrote: From: Kazuya Mizuguchi This patch supports the following interrupts. - One interrupt for multiple (descriptor, error, management) - One interrupt for emac - Four interrupts for dma queue (best effort rx/tx, network control rx/tx) Yo

[net-next 00/10][pull request] 100GbE Intel Wired LAN Driver Updates 2015-12-22

2015-12-22 Thread Jeff Kirsher
This series contains updates to fm10k only. Bruce cleans up the initialization of fm10k_workqueue at the global level, which fixes a checkpatch.pl error. Made several other cleanups of the driver, like making structures that do not change constant, remove unused code, cleanup code comments and us

[net-next 01/10] fm10k: don't initialize fm10k_workqueue at global level

2015-12-22 Thread Jeff Kirsher
From: Bruce Allan Cleans up checkpatch GLOBAL_INITIALIZERS error Signed-off-by: Bruce Allan Signed-off-by: Jacob Keller Tested-by: Krishneil Singh Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/fm10k/fm10k_main.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff

[net-next 07/10] fm10k: remove unused struct element

2015-12-22 Thread Jeff Kirsher
From: Bruce Allan Signed-off-by: Bruce Allan Tested-by: Krishneil Singh Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/fm10k/fm10k_type.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_type.h b/drivers/net/ethernet/intel/fm10k/fm10k_type

[net-next 08/10] fm10k: use true/false for boolean get_host_state

2015-12-22 Thread Jeff Kirsher
From: Bruce Allan Signed-off-by: Bruce Allan Tested-by: Krishneil Singh Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/i

[net-next 03/10] fm10k: Cleanup exception handling for changing queues

2015-12-22 Thread Jeff Kirsher
From: Alexander Duyck This patch is meant to cleanup the exception handling for the paths where we reset the interrupts and then reconfigure them. In all of these paths we had very different levels of exception handling. I have updated the driver so that all of the paths should result in a simi

[net-next 02/10] fm10k: correctly pack TLV structures and explain reasoning

2015-12-22 Thread Jeff Kirsher
From: Jacob Keller The TLV format for little endian structures is actually 4 byte aligned copy. To this end, we need to add an additional __aligned(4) marker along with __packed to ensure that these structures are actually 4 byte aligned and packed correctly. Use of just __packed will not work as

[net-next 10/10] fm10k: IS_ENABLED() is not appropriate for boolean kconfig option

2015-12-22 Thread Jeff Kirsher
From: Bruce Allan Tri-states need 'if IS_ENABLED()', booleans should use 'ifdef'. Signed-off-by: Bruce Allan Tested-by: Krishneil Singh Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/fm10k/fm10k_netdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dr

[net-next 05/10] fm10k: address operator not needed when declaring function pointers

2015-12-22 Thread Jeff Kirsher
From: Bruce Allan Signed-off-by: Bruce Allan Tested-by: Krishneil Singh Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/fm10k/fm10k_pf.c | 58 ++--- drivers/net/ethernet/intel/fm10k/fm10k_vf.c | 38 +-- 2 files changed, 48 insertions(+), 48 d

[net-next 04/10] fm10k: use ether_addr_equal instead of memcmp

2015-12-22 Thread Jeff Kirsher
From: Jacob Keller When comparing MAC addresses, use ether_addr_equal instead of memcmp to ETH_ALEN length. Found and replaced using the following sed: sed -e 's/memcmp\x28\(.*\), ETH_ALEN\x29/!ether_addr_equal\x28\1\x29/' Reported-by: Bruce Allan Signed-off-by: Jacob Keller Reviewed-by: Bru

[net-next 06/10] fm10k: constify fm10k_mac_ops, fm10k_iov_ops and fm10k_info structures

2015-12-22 Thread Jeff Kirsher
From: Bruce Allan These structures never change so declare them as const. Signed-off-by: Bruce Allan Tested-by: Krishneil Singh Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/fm10k/fm10k_pf.c | 6 +++--- drivers/net/ethernet/intel/fm10k/fm10k_pf.h | 2 +- drivers/net/ethernet

[net-next 09/10] fm10k: cleanup mailbox code comments etc

2015-12-22 Thread Jeff Kirsher
From: Bruce Allan Cleanup a number of issues with function header comments, lower-case acronyms (i.e. FIFO, TLV), duplicate comments and a stubbed-out header comment for fm10k_sm_mbx_init. Signed-off-by: Bruce Allan Tested-by: Krishneil Singh Signed-off-by: Jeff Kirsher --- drivers/net/ether

Re: [RFC PATCH 16/17] calipso: Add validation of CALIPSO option.

2015-12-22 Thread Hannes Frederic Sowa
On 22.12.2015 12:46, Huw Davies wrote: > > +/* CALIPSO RFC 5570 */ > + > +static bool ipv6_hop_calipso(struct sk_buff *skb, int optoff) > +{ > + const unsigned char *nh = skb_network_header(skb); > + > + if (nh[optoff + 1] < 8) > + goto drop; > + > + if (nh[optoff + 6] * 4

Re: [RFC PATCH 13/17] calipso: Allow request sockets to be relabelled by the lsm.

2015-12-22 Thread Hannes Frederic Sowa
On 22.12.2015 12:46, Huw Davies wrote: > tot_len += sizeof(*opt2); > - opt2 = sock_kmalloc(sk, tot_len, GFP_ATOMIC); > + if (sk) > + opt2 = sock_kmalloc(sk, tot_len, GFP_ATOMIC); > + else > + opt2 = kmalloc(tot_len, GFP_ATOMIC); > if (!opt2) >

Re: [RFC PATCH 08/17] ipv6: Add ipv6_renew_options_kern() that accepts a kernel mem pointer.

2015-12-22 Thread Hannes Frederic Sowa
On 22.12.2015 12:46, Huw Davies wrote: > The functionality is equivalent to ipv6_renew_options() except > that the newopt pointer is in kernel, not user, memory > > The kernel memory implementation will be used by the CALIPSO network > labelling engine, which needs to be able to set IPv6 hop-by-ho

RE: [PATCH] net: phy: adds backplane driver for Freescale's PCS PHY

2015-12-22 Thread Shaohui Xie
> > I did missed the device tree binding documentation. > > This driver expected a property "lane-instance" in mdio bus node, and > > "lane-handle" and "lane-range" properties in phy node. > > > > The "lane-instance" indicates what the phy should be probed as, > > 1000BASE-KX or 10GBASE-KR, seems p

[RFC PATCH 02/17] netlabel: Add an address family to domain hash entries.

2015-12-22 Thread Huw Davies
The reason is to allow different labelling protocols for different address families with the same domain. This requires the addition of an address family attribute in the netlink communication protocol. It is used in several messages: NLBL_MGMT_C_ADD and NLBL_MGMT_C_ADDDEF take it as an optional

[RFC PATCH 05/17] netlabel: Add support for enumerating the CALIPSO DOI list.

2015-12-22 Thread Huw Davies
Enumerate the DOI list through the NLBL_CALIPSO_C_LISTALL command. It takes no attributes. Signed-off-by: Huw Davies --- include/net/netlabel.h | 4 ++ net/ipv6/calipso.c | 41 net/netlabel/netlabel_calipso.c | 106 +++

[RFC PATCH 11/17] netlabel: Prevent setsockopt() from changing the hop-by-hop option.

2015-12-22 Thread Huw Davies
If a socket has a netlabel in place then don't let setsockopt() alter the socket's IPv6 hop-by-hop option. This is in the same spirit as the existing check for IPv4. Signed-off-by: Huw Davies --- security/selinux/netlabel.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-)

[RFC PATCH 14/17] calipso: Allow the lsm to label the skbuff directly.

2015-12-22 Thread Huw Davies
In some cases, the lsm needs to add the label to the skbuff directly. A NF_INET_LOCAL_OUT IPv6 hook is added to selinux to match the IPv4 behaviour. This allows selinux to label the skbuffs that it requires. Signed-off-by: Huw Davies --- include/net/ipv6.h | 2 +- include/net/net

[RFC PATCH 12/17] ipv6: Allow request socks to contain IPv6 options.

2015-12-22 Thread Huw Davies
If set, these will that precedence over the parent's options during both sending and child creation. If they're not set, the parent's options (if any) will be used. This is to allow the security_inet_conn_request() hook to modify the IPv6 options in just the same way that it already may do for IP

[RFC PATCH 09/17] netlabel: Move bitmap manipulation functions to the NetLabel core.

2015-12-22 Thread Huw Davies
This is to allow the CALIPSO labelling engine to use these. Signed-off-by: Huw Davies --- include/net/netlabel.h | 6 +++ net/ipv4/cipso_ipv4.c| 88 +--- net/netlabel/netlabel_kapi.c | 70 +++ 3 files changed,

[RFC PATCH 13/17] calipso: Allow request sockets to be relabelled by the lsm.

2015-12-22 Thread Huw Davies
Request sockets need to have a label that takes into account the incoming connection as well as their parent's label. This is used for the outgoing SYN-ACK and for their child full-socket. Signed-off-by: Huw Davies --- include/net/netlabel.h | 6 net/ipv6/calipso.c |

  1   2   >