On Tue, Dec 22, 2015 at 15:45:52 -0500, David Miller wrote: > From: Or Gerlitz <gerlitz...@gmail.com> > Date: Mon, 21 Dec 2015 09:33:22 +0200 > > > On Mon, Dec 21, 2015 at 9:16 AM, Hariprasad Shenai > > <haripra...@chelsio.com> wrote: > >> Add new /sys/kernel/debug/cxgb4/*/dcb_info node to dump out > >> various Data Center Bridging information. > > > > why? what's wrong with using the lldp tool for that purpose? > > Agreed, and I don't like your explanation. > > Even if you are using firmware managed DCB, the lldp tool should be > usable for querying. > > People need to stop putting so much crap into debugfs, it's a serious > pet peeve of mine. > > Every piece of driver unique interface crap you put into debugfs is a > _HARDSHIP_ for the user. Because they have to learn a unique way to > do X in every driver that tries to export the same kind of > functionality.
Will drop this from the series for now and send V2 for the same. Will send a separate series for adding lldptool support for firmware managed DCB. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
