On 10/31/2015 1:40 AM, huangdaode wrote:
On 2015/10/30 22:20, Arnd Bergmann wrote:
On Tuesday 27 October 2015 19:16:34 huangdaode wrote:
mdio@803c {
#address-cells = <1>;
#size-cells = <0>;
- compatible = "hisilicon,mdi
On 2015/10/30 22:20, Arnd Bergmann wrote:
On Tuesday 27 October 2015 19:16:34 huangdaode wrote:
mdio@803c {
#address-cells = <1>;
#size-cells = <0>;
- compatible = "hisilicon,mdio","hisilicon,hns-mdio";
+
On Fri, 2015-10-30 at 14:50 -0700, Linus Torvalds wrote:
> On Fri, Oct 30, 2015 at 2:23 PM, Linus Torvalds
> wrote:
> > On Fri, Oct 30, 2015 at 2:02 PM, Al Viro wrote:
> >>
> >> Your variant has 1:64 ratio; obviously better than now, but we can actually
> >> do 1:bits-per-cacheline quite easily.
On Fri, Oct 30, 2015 at 04:52:41PM -0700, Linus Torvalds wrote:
> I really suspect this patch is "good enough" in reality, and I would
> *much* rather do something like this than add a new non-POSIX flag
> that people have to update their binaries for. I agree with Eric that
> *some* people will d
On Fri, Oct 30, 2015 at 03:16:26PM -0700, Yang Shi wrote:
> When running bpf samples on rt kernel, it reports the below warning:
>
> BUG: sleeping function called from invalid context at
> kernel/locking/rtmutex.c:917
> in_atomic(): 1, irqs_disabled(): 128, pid: 477, name: ping
> Preemption disab
Fixes the following kernel BUG :
BUG: using __this_cpu_add() in preemptible [] code: bash/2758
caller is __this_cpu_preempt_check+0x13/0x15
CPU: 0 PID: 2758 Comm: bash Tainted: P O 3.18.19 #2
8170eaca 880110d1b788 81482b2a
On Fri, 2015-10-30 at 21:42 +, Haiyang Zhang wrote:
>
>
> With your 2nd patch, I saw:
> [ 19.242104] Wow ! headroom=164 while hh_len(eth0)=240
>
> After adding the 3rd patch with increased LL_MAX_HEADER,
> the warning and stack trace no longer show up.
>
> Also, could you fix the net cor
On Fri, Oct 30, 2015 at 3:33 PM, Al Viro wrote:
> On Fri, Oct 30, 2015 at 02:50:46PM -0700, Linus Torvalds wrote:
>
>> Anyway. This is a pretty simple patch, and I actually think that we
>> could just get rid of the "next_fd" logic entirely with this. That
>> would make this *patch* be more compli
All the mv88e6xxx drivers use the exact same code in their probe
function to lookup the switch name given its ID. Thus introduce a
mv88e6xxx_switch_id structure and a mv88e6xxx_lookup_name function in
the common mv88e6xxx code.
In the meantime make __mv88e6xxx_reg_{read,write} static since we do n
On (10/30/15 22:03), Nelson, Shannon wrote:
> The more common idiom in our driver would be
>
> err = i40e_get_platform_mac_addr(..);
> if (err) {
Ok.
> Have you tested this beyond a compile?
> Do you have a DT model to try this against?
yes.
> In looking at a couple other drivers,
Hello.
On 04/07/2015 10:33 PM, David Miller wrote:
The explicitly inline functions belong to the header files, so move
cpu_to_edmac() and edmac_to_cpu() into the driver header.
While at it, make these functions return 'u32' instead of '__u32'.
Signed-off-by: Sergei Shtylyov
Then... um
Iff the first dma_alloc_coherent() call fails in sh_eth_ring_init(), the
following is printed to the kernel console:
WARNING: CPU: 0 PID: 1 at drivers/base/dma-mapping.c:334
dma_common_free_remap+0x48/0x6c()
trying to free invalid coherent area: (null)
Modules linked in:
CPU: 0 PID: 1 Comm: s
sh_eth_ring_free() called in the sh_eth_ring_init()'s error path expects
the arrays pointed to by 'sh_eth_private::[rt]x_skbuff' to be initialized
with NULLs but they are allocated with just kmalloc_array() and so are left
filled with random data. Use kcalloc() instead.
Signed-off-by: Sergei Sh
Hello.
Here's a set of 2 patches against DaveM's 'net.git' repo which fix couple of
bugs in the sh_eth_ring_init() function.
[1/2] sh_eth: fix uninitialized arrays in sh_eth_ring_init()
[2/2] sh_eth: fix WARNING in dma_common_free_remap()
MBR, Sergei
--
To unsubscribe from this list: send th
It's easy to forget to lock the smi_mutex before calling the low-level
_mv88e6xxx_reg_{read,write}, so add a assert_smi_lock function in them.
Signed-off-by: Vivien Didelot
---
drivers/net/dsa/mv88e6xxx.c | 25 ++---
1 file changed, 14 insertions(+), 11 deletions(-)
diff --g
When running bpf samples on rt kernel, it reports the below warning:
BUG: sleeping function called from invalid context at
kernel/locking/rtmutex.c:917
in_atomic(): 1, irqs_disabled(): 128, pid: 477, name: ping
Preemption disabled at:[] kprobe_perf_func+0x30/0x228
CPU: 3 PID: 477 Comm: ping Not
On Fri, Oct 30, 2015 at 02:50:46PM -0700, Linus Torvalds wrote:
> Anyway. This is a pretty simple patch, and I actually think that we
> could just get rid of the "next_fd" logic entirely with this. That
> would make this *patch* be more complicated, but it would make the
> resulting *code* be simp
Mans Rullgard :
[...]
> diff --git a/drivers/net/ethernet/aurora/nb8800.c
> b/drivers/net/ethernet/aurora/nb8800.c
> new file mode 100644
> index 000..ce61439
> --- /dev/null
> +++ b/drivers/net/ethernet/aurora/nb8800.c
[...]
> +static int nb8800_mdio_read(struct mii_bus *bus, int phy_id, int
Am 30.10.2015 um 23:03 schrieb Haiyang Zhang:
>
>
>> -Original Message-
>> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
>> Sent: Friday, October 30, 2015 6:56 AM
>> To: Haiyang Zhang
>> Cc: Richard Weinberger ; David Miller
>> ; o...@aepfle.de; jasow...@redhat.com; driverdev-
>> d
> -Original Message-
> From: Sowmini Varadhan [mailto:sowmini.varad...@oracle.com]
> Sent: Friday, October 30, 2015 12:25 PM
>
> On (10/30/15 18:57), Nelson, Shannon wrote:
> > > >
> > > > Going along with this being the equivalent of the ixgbe patch, I'd
> > > > prefer the new code to b
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Friday, October 30, 2015 6:56 AM
> To: Haiyang Zhang
> Cc: Richard Weinberger ; David Miller
> ; o...@aepfle.de; jasow...@redhat.com; driverdev-
> de...@linuxdriverproject.org; LKML ;
> netdev@vger.kernel.
On Fri, Oct 30, 2015 at 2:23 PM, Linus Torvalds
wrote:
> On Fri, Oct 30, 2015 at 2:02 PM, Al Viro wrote:
>>
>> Your variant has 1:64 ratio; obviously better than now, but we can actually
>> do 1:bits-per-cacheline quite easily.
>
> Ok, but in that case you end up needing a counter for each cachel
> -Original Message-
> From: Eric Dumazet [mailto:eric.duma...@gmail.com]
> Sent: Friday, October 30, 2015 4:19 PM
> To: Haiyang Zhang
> Cc: eduma...@google.com; David Miller ;
> netdev@vger.kernel.org; KY Srinivasan
> Subject: Re: [patch] tcp: attach SYNACK messages to request sockets
On Fri, Oct 30, 2015 at 2:02 PM, Al Viro wrote:
>
> Your variant has 1:64 ratio; obviously better than now, but we can actually
> do 1:bits-per-cacheline quite easily.
Ok, but in that case you end up needing a counter for each cacheline
too (to count how many bits, in order to know when to say "c
On Oct. Friday 30 (44) 09:52 PM, Andrew Lunn wrote:
> On Fri, Oct 30, 2015 at 04:36:56PM -0400, Vivien Didelot wrote:
> > All the mv88e6xxx drivers use the exact same code in their probe
> > function to lookup the switch name given its ID.
>
> I did consider this before. But they are not exactly t
On Oct. Friday 30 (44) 10:01 PM, Andrew Lunn wrote:
> > > > static int _mv88e6xxx_reg_read(struct dsa_switch *ds, int addr, int
> > > > reg)
> > > > {
> > > > - struct mii_bus *bus = dsa_host_dev_to_mii_bus(ds->master_dev);
> > > > + struct mii_bus *bus;
> > > > int ret;
> >
On Fri, Oct 30, 2015 at 05:43:21PM +, David Laight wrote:
> ISTM that the correct call should be listen(fd, 0);
> Although that doesn't help a thread stuck in recvmsg() for a datagram.
>
> It is also tempting to think that close(fd) should sleep until all
> io activities using that fd have co
On Fri, Oct 30, 2015 at 12:12 PM, Eric Dumazet wrote:
> On Fri, 2015-10-30 at 10:47 -0700, Ani Sinha wrote:
>
>> for 32 bit archs, it does in SNMP_ADD_STATS64_USER()
>
> Sure. But x86 these days is 64bit, at 99 % maybe.
>
> We do not make changes that looks 'maybe better' for i486 or i586
>
> Just
> > > static int _mv88e6xxx_reg_read(struct dsa_switch *ds, int addr, int reg)
> > > {
> > > - struct mii_bus *bus = dsa_host_dev_to_mii_bus(ds->master_dev);
> > > + struct mii_bus *bus;
> > > int ret;
> > >
> > > + assert_smi_lock(ds);
> > > +
> > > + bus = dsa_host_dev_to_mii_bus(ds->master
On Fri, Oct 30, 2015 at 10:18:12AM -0700, Linus Torvalds wrote:
> I do wonder if we couldn't just speed up the bitmap allocator by an
> order of magnitude. It would be nicer to be able to make existing
> loads faster without any new "don't bother with POSIX semantics" flag.
>
> We could, for exam
On Fri, Oct 30, 2015 at 04:36:56PM -0400, Vivien Didelot wrote:
> All the mv88e6xxx drivers use the exact same code in their probe
> function to lookup the switch name given its ID.
I did consider this before. But they are not exactly the same, when
you consider the masking of the lower nibble whi
Same changes ported to 4.2.5 with some minor improvments (I hope),
namely,
- applied a round of DeMorgan to the 'quick' check function in
order to simplify the condition
- fixed a (minor) error in the dgram_sendmsg change: In case the
2nd check resulted in 'can
Hi Andrew,
On Oct. Friday 30 (44) 09:41 PM, Andrew Lunn wrote:
> On Fri, Oct 30, 2015 at 04:35:42PM -0400, Vivien Didelot wrote:
> > It's easy to forget to lock the smi_mutex before calling the low-level
> > _mv88e6xxx_reg_{read,write}, so add a assert_smi_lock function in them.
> >
> > Signed-of
All the mv88e6xxx drivers use the exact same code in their probe
function to lookup the switch name given its ID. Thus introduce a
mv88e6xxx_switch_id structure and a mv88e6xxx_lookup_name function in
the common mv88e6xxx code.
In the meantime make __mv88e6xxx_reg_{read,write} static since they we
Hello.
On 10/30/2015 02:11 AM, Sergei Shtylyov wrote:
Iff the first dma_alloc_coherent() call fails in sh_eth_ring_init(), the
following is printed to the kernel console:
WARNING: CPU: 0 PID: 1 at drivers/base/dma-mapping.c:334
dma_common_free_remap+0x48/0x6c()
Oops, I got the function
On Fri, Oct 30, 2015 at 01:14:02PM +0100, Stefan Sørensen wrote:
> The list of rx timestamps are currently only pruned of old entries when a
> new entry is inserted. If no new entries are added, old timestamps may
> survive beyond their lifetime, possible causing them to be attached to
> packets wi
> -Original Message-
> From: Eric Dumazet [mailto:eric.duma...@gmail.com]
> Sent: Friday, October 30, 2015 1:03 PM
> To: Haiyang Zhang
> Cc: eduma...@google.com; David Miller ;
> netdev@vger.kernel.org; KY Srinivasan
> Subject: Re: [patch] tcp: attach SYNACK messages to request sockets
It's easy to forget to lock the smi_mutex before calling the low-level
_mv88e6xxx_reg_{read,write}, so add a assert_smi_lock function in them.
Signed-off-by: Vivien Didelot
---
drivers/net/dsa/mv88e6xxx.c | 31 ++-
1 file changed, 18 insertions(+), 13 deletions(-)
di
On Fri, Oct 30, 2015 at 04:35:42PM -0400, Vivien Didelot wrote:
> It's easy to forget to lock the smi_mutex before calling the low-level
> _mv88e6xxx_reg_{read,write}, so add a assert_smi_lock function in them.
>
> Signed-off-by: Vivien Didelot
> ---
> drivers/net/dsa/mv88e6xxx.c | 31 ++
On Fri, Oct 30, 2015 at 01:14:04PM +0100, Stefan Sørensen wrote:
> In the packet timestamping function, check that the ptp version and
> protocol of the packet matches what we have configured the hardware to
> actually generate timestamps for, before looking/waiting for a timestamp.
>
> Signed-off
On Fri, Oct 30, 2015 at 01:14:03PM +0100, Stefan Sørensen wrote:
> Change the definition of PTP_CLASS_L2 to not have any bits overlapping with
> the other defined protocol values, allowing the PTP_CLASS_* definitions to
> be for simple filtering on packet type.
>
> Signed-off-by: Stefan Sørensen
On Fri, Oct 30, 2015 at 01:14:01PM +0100, Stefan Sørensen wrote:
> Currently rx_timestamp_work reschedules itself as a regular workqueue item,
> effectively causing it run constantly as long as there are packets left in
> the queue. Fix by using delayed workqueue items, limiting it to run only
> ev
On Fri, Oct 30, 2015 at 01:14:00PM +0100, Stefan Sørensen wrote:
> Only using the message type and sequence id for matching timestamps with
> packets is error prone, particularly if packets can be reordered. Fix by
> extending the check to include the hash of bytes 20-29 (source id in PTPv2)
> that
On Fri, 2015-10-30 at 13:02 -0700, Eric Dumazet wrote:
> So it looks like you have a device with a very big hh_len
>
> MAX_TCP_HEADER is not enough space to hold all headers, and this is the
> bug that needs to be fixed. This is scary to realloc all tcp packets !
>
drivers/net/hyperv/netvsc_drv
On 10/30/2015 09:35 AM, Jarod Wilson wrote:
Alexander Duyck wrote:
On 10/23/2015 08:40 PM, Jarod Wilson wrote:
There are some netdev features that make little sense to toggle on and
off in a stacked device setup on only one device in the stack. The prime
example is a bonded connection, where it
On Fri, 2015-10-30 at 19:38 +, Haiyang Zhang wrote:
>
> > -Original Message-
> > From: Eric Dumazet [mailto:eric.duma...@gmail.com]
> > Sent: Thursday, October 29, 2015 6:59 PM
> > To: Haiyang Zhang
> > Cc: eduma...@google.com; David Miller ;
> > netdev@vger.kernel.org; KY Srinivasan
On 10/30/2015 09:25 AM, Jarod Wilson wrote:
Michal Kubecek wrote:
On Fri, Oct 23, 2015 at 10:51:09PM -0700, Alexander Duyck wrote:
On 10/23/2015 08:40 PM, Jarod Wilson wrote:
+static netdev_features_t netdev_sync_upper_features(struct
net_device *lower,
+struct net_device *upper, netdev_fe
> -Original Message-
> From: Eric Dumazet [mailto:eric.duma...@gmail.com]
> Sent: Thursday, October 29, 2015 6:59 PM
> To: Haiyang Zhang
> Cc: eduma...@google.com; David Miller ;
> netdev@vger.kernel.org; KY Srinivasan
> Subject: Re: [patch] tcp: attach SYNACK messages to request socket
On Fri, 2015-10-30 at 11:22 -0700, Cong Wang wrote:
> When the bottom qdisc decides to, for example, drop some packet,
> it calls qdisc_tree_decrease_qlen() to update the queue length
> for all its ancestors, we need to update the backlog too to
> keep the stats on root qdisc accurate.
>
> Cc: Jam
On (10/30/15 18:57), Nelson, Shannon wrote:
> > >
> > > Going along with this being the equivalent of the ixgbe patch, I'd
> > > prefer the new code to be in i40e_main.c, rather than in i40e_common.c.
> > > In the design of our drivers, the common file is essentially a device
> > > specific layer,
On 10/30/2015 10:31 AM, Benjamin Poirier wrote:
Using eiac instead of reading icr allows us to avoid interference with
rx and tx interrupts in the Other interrupt handler.
According to the 82574 datasheet section 10.2.4.1, interrupt causes that
trigger the Other interrupt are
1) Link Status Chan
On Fri, 2015-10-30 at 10:47 -0700, Ani Sinha wrote:
> for 32 bit archs, it does in SNMP_ADD_STATS64_USER()
Sure. But x86 these days is 64bit, at 99 % maybe.
We do not make changes that looks 'maybe better' for i486 or i586
Just do the same that multiple similar patches did.
Example :
757efd32
Nikolay Aleksandrov wrote:
On 10/06/2015 09:53 PM, Jarod Wilson wrote:
From: Uwe Koziolek
With some very finicky switch hardware, active backup bonding can get into
a situation where we play ping-pong between interfaces, trying to get one
to come up as the active slave. There seems to be an iss
> -Original Message-
> From: Sowmini Varadhan [mailto:sowmini.varad...@oracle.com]
> Sent: Friday, October 30, 2015 11:37 AM
> To:
> Subject: Re: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or
> IDPROM
>
> On (10/30/15 18:28), Nelson, Shannon wrote:
> >
> > Going along with
On (10/30/15 18:28), Nelson, Shannon wrote:
>
> Going along with this being the equivalent of the ixgbe patch, I'd
> prefer the new code to be in i40e_main.c, rather than in i40e_common.c.
> In the design of our drivers, the common file is essentially a device
> specific layer, and the OS and plat
> -Original Message-
> From: Sowmini Varadhan [mailto:sowmini.varad...@oracle.com]
> Sent: Friday, October 30, 2015 8:04 AM
> To:
> Subject: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or IDPROM
>
>
> This is the i40e equivalent of commit c762dff24c06 ("ixgbe: Look up MAC
>
Similarly, we need to update backlog too when we update qlen.
Cc: Jamal Hadi Salim
Signed-off-by: Cong Wang
---
net/sched/sch_dsmark.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/sched/sch_dsmark.c b/net/sched/sch_dsmark.c
index cfddb1c..d0dff0c 100644
--- a/net/sched/sch_dsmark.
When the bottom qdisc decides to, for example, drop some packet,
it calls qdisc_tree_decrease_qlen() to update the queue length
for all its ancestors, we need to update the backlog too to
keep the stats on root qdisc accurate.
Cc: Jamal Hadi Salim
Acked-by: Jamal Hadi Salim
Signed-off-by: Cong W
We saw qlen!=0 but backlog==0 on our production machine:
qdisc htb 1: dev eth0 root refcnt 2 r2q 10 default 1 direct_packets_stat 0 ver
3.17
Sent 172680457356 bytes 222469449 pkt (dropped 0, overlimits 123575834
requeues 0)
backlog 0b 72p requeues 0
The problem is we only count qlen for HTB q
On Fri, Oct 30, 2015 at 8:12 PM, Sowmini Varadhan
wrote:
> On (10/30/15 20:06), Andy Shevchenko wrote:
>>
>> > +#include "i40e.h"
>>
>> Why do you need this one exactly?
>
> I needed it to find pf->pdev below.
>
>> > + struct device_node *dp = pci_device_to_OF_node(pf->pdev);
>
> Without it,
For hierarchical qdisc like HTB, we currently only update its qlen
but leave its backlog as zero:
qdisc htb 1: dev eth0 root refcnt 2 r2q 10 default 1 direct_packets_stat 0
ver 3.17
Sent 172680457356 bytes 222469449 pkt (dropped 0, overlimits 123575834
requeues 0)
backlog 0b 72p re
Remove nearly duplicated code and prepare for the following patch.
Cc: Jamal Hadi Salim
Acked-by: Jamal Hadi Salim
Signed-off-by: Cong Wang
---
include/net/sch_generic.h | 17 +
net/sched/sch_cbq.c | 7 +--
net/sched/sch_drr.c | 6 +-
net/sched/sch_dsmark.
On (10/30/15 20:06), Andy Shevchenko wrote:
>
> > +#include "i40e.h"
>
> Why do you need this one exactly?
I needed it to find pf->pdev below.
> > + struct device_node *dp = pci_device_to_OF_node(pf->pdev);
Without it, you will get:
:
CC [M] drivers/net/ethernet/intel
On Fri, Oct 30, 2015 at 5:03 PM, Sowmini Varadhan
wrote:
>
> This is the i40e equivalent of commit c762dff24c06 ("ixgbe: Look up MAC
> address in Open Firmware or IDPROM").
>
> As with that fix, attempt to look up the MAC address in Open Firmware
> on systems that support it, and use IDPROM on SPA
On 10/29/2015 07:41 PM, Lan Tianyu wrote:
On 2015年10月30日 00:17, Alexander Duyck wrote:
On 10/29/2015 01:33 AM, Lan Tianyu wrote:
On 2015年10月29日 14:58, Alexander Duyck wrote:
Your code was having to do a bunch of shuffling in order to get things
set up so that you could bring the interface back
On Fri, Oct 30, 2015 at 4:00 AM, Eric Dumazet wrote:
> On Fri, 2015-10-30 at 11:48 +0100, Florian Westphal wrote:
>> Hannes Frederic Sowa wrote:
>> > > > > @@ -936,7 +936,9 @@ static void ipmr_cache_resolve(struct net *net,
>> > > > > struct mr_table *mrt,
>> > > > >
>> > > > >
From: David Holland
> Sent: 29 October 2015 14:59
> On Tue, Oct 27, 2015 at 10:52:46AM +, Alan Burlison wrote:
> > >But in general, this is basically a problem with the application: the file
> > >descriptor space is shared between threads and having one thread sniping
> > >at open files, you
msi-x interrupts are not shared so there's no need to check if the
interrupt was really from this adapter.
Signed-off-by: Benjamin Poirier
---
drivers/net/ethernet/intel/e1000e/netdev.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c
b/drivers
Hi,
For this series:
Benjamin Poirier (4):
e1000e: Remove unreachable code
e1000e: Do not read icr in Other interrupt
e1000e: Do not write lsc to ics in msi-x mode
e1000e: Fix msi-x interrupt automask
drivers/net/ethernet/intel/e1000e/defines.h | 3 +-
drivers/net/ethernet/intel/e1000
Since the introduction of 82574 support in e1000e, the driver has worked
on the assumption that msi-x interrupt generation is automatically
disabled after each irq. As it turns out, this is not the case.
Currently, rx interrupts can fire multiple times before and during napi
processing. This can be
In msi-x mode, there is no handler for the lsc interrupt so there is no
point in writing that to ics now that we always assume Other interrupts
are caused by lsc.
Reviewed-by: Jasna Hodzic
Signed-off-by: Benjamin Poirier
---
drivers/net/ethernet/intel/e1000e/defines.h | 3 ++-
drivers/net/ethe
Using eiac instead of reading icr allows us to avoid interference with
rx and tx interrupts in the Other interrupt handler.
According to the 82574 datasheet section 10.2.4.1, interrupt causes that
trigger the Other interrupt are
1) Link Status Change.
2) Receiver Overrun.
3) MDIO Access Complete.
On Thu, Oct 29, 2015 at 5:35 AM, Eric Dumazet wrote:
>
> Well, I already tested the O_FD_FASTALLOC thing, and I can tell you
> find_next_zero_bit() is nowhere to be found in kernel profiles anymore.
> It also lowers time we hold the fd array spinlock while doing fd alloc.
I do wonder if we couldn
This is the same patch as for ixgbe but applied differently according to
busy polling.
see commit "ixgbe: Fix handling of napi budget when multiple queues are
enabled per vector"
Signed-off-by: William Dauchy
---
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 2 ++
1 file changed, 2 insert
V19: Rebased to latest net-next 4.3.0-rc6+
commit 6d08f617872cc048173d59f1ce4660b030bab5a6
plus a few reviewer's suggested changes.
Note: changes to netdev-vport.c are not included. dev_queue_xmit() is
now called directly as the send vport ops function and length
adjustments for vlans don't apply.
Add support for 802.1ad including the ability to push and pop double
tagged vlans. Add support for 802.1ad to netlink parsing and flow
conversion. Uses double nested encap attributes to represent double
tagged vlan. Inner TPID encoded along with ctci in nested attributes.
Signed-off-by: Thomas F H
This is to simplify using double tagged vlans. This function allows all
valid vlan ethertypes to be checked in a single function call.
Signed-off-by: Thomas F Herbert
---
include/linux/if_vlan.h | 16
1 file changed, 16 insertions(+)
diff --git a/include/linux/if_vlan.h b/inclu
openvswitch: Add support for 8021.AD
Change the description of the VLAN tpid field.
Signed-off-by: Thomas F Herbert
---
include/uapi/linux/openvswitch.h | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/op
From: Ido Schimmel
The flag used to indicate if a VLAN should be used for filtering - as
opposed to context only - on the bridge itself (e.g. br0) is called
'brentry' and not 'brvlan'.
Signed-off-by: Ido Schimmel
Acked-by: Nikolay Aleksandrov
---
net/bridge/br_vlan.c | 6 +++---
1 file change
From: Nikolay Aleksandrov
Hi,
This is a set from Ido which takes care of one failure path error in
nbp_vlan_init (patch 1) and a few comment errors (patch 2).
I must admit I didn't expect the port init continues after a vlan init
failure but should've checked to make sure. Thanks to Ido for catch
On Fri, Oct 30, 2015 at 10:23:32AM +0200, Julian Anastasov wrote:
> Fix two problems from the change that introduced RTNH_F_LINKDOWN
> flag. The first patch deals with the removal of local route on
> DOWN event. The second patch makes sure the RTNH_F_LINKDOWN
> flag is properly updated on UP event
From: Eric Dumazet
IPv6 request sockets store a pointer to skb containing the SYN packet
to be able to transfer it to full blown socket when 3WHS is done
(ireq->pktopts -> np->pktoptions)
As explained in commit 5e0724d027f0 ("tcp/dccp: fix hashdance race for
passive sessions"), we must transfer
From: Ido Schimmel
When adding a port to a bridge we initialize VLAN filtering on it. We do
not bail out in case an error occurred in nbp_vlan_init, as it can be
used as a non VLAN filtering bridge.
However, if VLAN filtering is required and an error occurred in
nbp_vlan_init, we should set vlgr
Alexander Duyck wrote:
On 10/23/2015 08:40 PM, Jarod Wilson wrote:
There are some netdev features that make little sense to toggle on and
off in a stacked device setup on only one device in the stack. The prime
example is a bonded connection, where it really doesn't make sense to
disable LRO on
Michal Kubecek wrote:
On Fri, Oct 23, 2015 at 10:51:09PM -0700, Alexander Duyck wrote:
On 10/23/2015 08:40 PM, Jarod Wilson wrote:
+static netdev_features_t netdev_sync_upper_features(struct net_device *lower,
+ struct net_device *upper, netdev_features_t features)
+{
+ netdev_featu
On Fri, Oct 30, 2015 at 04:44:13PM +0100, Neil Armstrong wrote:
> On 10/29/2015 04:28 PM, Andrew Lunn wrote:
> >> Is 6060 supported by the 6352 family? It doesn't share any mv88e6xxx
> >> code...
> >
> > It is a totally separate driver. Nothing shared at all.. It is an old
> > device, and only do
On 10/30/2015 07:55 AM, William Dauchy wrote:
Hi Alexander,
On Tue, Sep 22, 2015 at 11:35 PM, Alexander Duyck wrote:
This patch corrects an issue in which the polling routine would increase
the budget for Rx to at least 1 per queue if multiple queues were present.
This would result in Rx packe
On 10/30/2015 4:15 AM, David Miller wrote:
From: Santosh Shilimkar
Date: Wed, 28 Oct 2015 15:51:12 -0700
+ &rs->rs_bound_node, ht_parms)) {
*port = rs->rs_bound_port;
ret = 0;
rdsd
To further improve the RDS connection scalabilty on massive systems
where number of sockets grows into tens of thousands of sockets, there
is a need of larger bind hashtable. Pre-allocated 8K or 16K table is
not very flexible in terms of memory utilisation. The rhashtable
infrastructure gives us t
On 10/29/2015 04:28 PM, Andrew Lunn wrote:
>> Is 6060 supported by the 6352 family? It doesn't share any mv88e6xxx
>> code...
>
> It is a totally separate driver. Nothing shared at all.. It is an old
> device, and only does 10/100. It could be it is just too different to
> support via mv88e6xxx.
On Thu, Oct 29, 2015 at 6:21 PM, Neal P. Murphy
wrote:
> On Thu, 29 Oct 2015 17:01:24 -0700
> Ani Sinha wrote:
>
>> On Wed, Oct 28, 2015 at 11:40 PM, Neal P. Murphy
>> wrote:
>> > On Wed, 28 Oct 2015 02:36:50 -0400
>> > "Neal P. Murphy" wrote:
>> >
>> >> On Mon, 26 Oct 2015 21:06:33 +0100
>> >>
On Friday, October 30, 2015 at 03:53:31 PM, Oliver Hartkopp wrote:
> On 10/30/2015 03:24 PM, Marek Vasut wrote:
> > On Friday, October 30, 2015 at 03:17:44 PM, Marc Kleine-Budde wrote:
> >> On 10/30/2015 03:01 PM, Marek Vasut wrote:
> >>> Are you absolutelly positive this doesn't break kernel ABI p
On 29/10/15 18:46, roopa wrote:
On 10/29/15, 9:53 AM, Robert Shearman wrote:
On 29/10/15 15:49, Roopa Prabhu wrote:
From: Roopa Prabhu
Adds support for both RTNH_F_DEAD and RTNH_F_LINKDOWN flags.
This resembles ipv4 fib code. I also picked fib_rebalance from
ipv4. Enabled weights support for
This is the i40e equivalent of commit c762dff24c06 ("ixgbe: Look up MAC
address in Open Firmware or IDPROM").
As with that fix, attempt to look up the MAC address in Open Firmware
on systems that support it, and use IDPROM on SPARC if no OF address
is found.
Reviewed-by: Martin K. Petersen
Sign
Hi Alexander,
On Tue, Sep 22, 2015 at 11:35 PM, Alexander Duyck wrote:
> This patch corrects an issue in which the polling routine would increase
> the budget for Rx to at least 1 per queue if multiple queues were present.
> This would result in Rx packets being processed when the budget was 0 wh
On 10/30/2015 03:24 PM, Marek Vasut wrote:
> On Friday, October 30, 2015 at 03:17:44 PM, Marc Kleine-Budde wrote:
>> On 10/30/2015 03:01 PM, Marek Vasut wrote:
>>> Are you absolutelly positive this doesn't break kernel ABI please ?
>>>
>>> I am a little worried there, since the size of can_clock
On Tuesday 27 October 2015 19:16:34 huangdaode wrote:
> mdio@803c {
> #address-cells = <1>;
> #size-cells = <0>;
> - compatible = "hisilicon,mdio","hisilicon,hns-mdio";
> + compatible = "hisilicon,hns-mdio","h
On Friday, October 30, 2015 at 03:17:44 PM, Marc Kleine-Budde wrote:
> On 10/30/2015 03:01 PM, Marek Vasut wrote:
> > On Friday, October 30, 2015 at 02:40:26 PM, Marc Kleine-Budde wrote:
> >> On 10/30/2015 01:48 PM, Marek Vasut wrote:
> >>> The sizeof() is invoked on an incorrect variable, likely d
On 10/30/2015 03:01 PM, Marek Vasut wrote:
> On Friday, October 30, 2015 at 02:40:26 PM, Marc Kleine-Budde wrote:
>> On 10/30/2015 01:48 PM, Marek Vasut wrote:
>>> The sizeof() is invoked on an incorrect variable, likely due to some
>>> copy-paste error, and this might result in memory corruption.
as result of function rds_iw_flush_mr_pool is nowhere checked,
changing its return type from int to void.
also removing the unused variable rc as there is nothing to return
Signed-off-by: Saurabh Sengar
---
v2 : modify patch description, as per the comments from Sergei Shtylyov
net/rds/iw_rdma
1 - 100 of 148 matches
Mail list logo
