On Fri, 2015-10-30 at 21:42 +0000, Haiyang Zhang wrote: > > > With your 2nd patch, I saw: > [ 19.242104] Wow ! headroom=164 while hh_len(eth0)=240 > > After adding the 3rd patch with increased LL_MAX_HEADER, > the warning and stack trace no longer show up. > > Also, could you fix the net core code so that it doesn't > panic even with reallocated header?
Well, the reason we have a net-next tree, is that we can let new features settling for a while, and eventually detect and fix old bugs. In your case, having the proper LL_MAX_HEADER will likely improve performance of TCP_RR like workloads by a nice number : Re-allocating/copying all TCP packets without notice was _not_ a nice feature. Panicing while in net-next mode certainly is something a developer will notice and report. BTW, it is possible we have to revert the SYNACK attachment to request sockets, if it turns out we have too many bugs to fix. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
