On Friday, October 30, 2015 at 03:17:44 PM, Marc Kleine-Budde wrote: > On 10/30/2015 03:01 PM, Marek Vasut wrote: > > On Friday, October 30, 2015 at 02:40:26 PM, Marc Kleine-Budde wrote: > >> On 10/30/2015 01:48 PM, Marek Vasut wrote: > >>> The sizeof() is invoked on an incorrect variable, likely due to some > >>> copy-paste error, and this might result in memory corruption. Fix this. > >>> > >>> Signed-off-by: Marek Vasut <ma...@denx.de> > >>> Cc: Wolfgang Grandegger <w...@grandegger.com> > >>> Cc: Marc Kleine-Budde <m...@pengutronix.de> > >>> Cc: netdev@vger.kernel.org > >> > >> Applies to can and added stable on Cc. > > > > Are you absolutelly positive this doesn't break kernel ABI please ? > > > > I am a little worried there, since the size of can_clock and can_ctrlmode > > structures differ. > > struct can_clock is a u32, see [1] > struct can_ctrlmode is 2 x u32. > > in libsocketcan[2] it's accessed like this: > > memcpy(res, > > > > RTA_DATA(can_attr[IFLA_CAN_CLOCK]), > > sizeof(struct can_clock)); > > I think it should be ok.
In that case, yes, it's good. Hopefully, noone wrote his own thing. Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
