[PATCH] net: rds: chnaging the return type from int to void

2015-10-29 Thread Saurabh Sengar
as return type of function rds_iw_flush_mr_pool no where checked, chnaging its return type from int to void. also removing the unused variable rc as there is nothing to return. Signed-off-by: Saurabh Sengar --- net/rds/iw_rdma.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff

[PATCH 5/5] xfrm: Increment statistic counter on inner mode error

2015-10-29 Thread Steffen Klassert
Increment the LINUX_MIB_XFRMINSTATEMODEERROR statistic counter to notify about dropped packets if we fail to fetch a inner mode. Signed-off-by: Steffen Klassert --- net/xfrm/xfrm_input.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/xfrm/xfrm_input.c b/net/xfrm/xfrm_

[PATCH 4/5] xfrm4: Reload skb header pointers after calling pskb_may_pull.

2015-10-29 Thread Steffen Klassert
A call to pskb_may_pull may change the pointers into the packet, so reload the pointers after the call. Signed-off-by: Steffen Klassert --- net/ipv4/xfrm4_policy.c | 33 ++--- 1 file changed, 26 insertions(+), 7 deletions(-) diff --git a/net/ipv4/xfrm4_policy.c b/net

pull request (net-next): ipsec-next 2015-10-30

2015-10-29 Thread Steffen Klassert
1) The flow cache is limited by the flow cache limit which depends on the number of cpus and the xfrm garbage collector threshold which is independent of the number of cpus. This leads to the fact that on systems with more than 16 cpus we hit the xfrm garbage collector limit and refuse

[PATCH 3/5] xfrm4: Fix header checks in _decode_session4.

2015-10-29 Thread Steffen Klassert
We skip the header informations if the data pointer points already behind the header in question for some protocols. This is because we call pskb_may_pull with a negative value converted to unsigened int from pskb_may_pull in this case. Skipping the header informations can lead to incorrect policy

[PATCH 2/5] xfrm: Fix unaligned access to stats in copy_to_user_state()

2015-10-29 Thread Steffen Klassert
From: Sowmini Varadhan On sparc, deleting established SAs (e.g., by restarting ipsec) results in unaligned access messages via xfrm_del_sa -> km_state_notify -> xfrm_send_state_notify(). Even though struct xfrm_usersa_info is aligned on 8-byte boundaries, netlink attributes are fundamentally onl

[PATCH 1/5] xfrm: Let the flowcache handle its size by default.

2015-10-29 Thread Steffen Klassert
The xfrm flowcache size is limited by the flowcache limit (4096 * number of online cpus) and the xfrm garbage collector threshold (2 * 32768), whatever is reached first. This means that we can hit the garbage collector limit only on systems with more than 16 cpus. On such systems we simply refuse n

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-29 Thread David Holland
On Thu, Oct 29, 2015 at 04:15:33PM +, Alan Burlison wrote: > >close(2) as specified by POSIX doesn't prohibit this weird revoke-like > >behavior, but there's nothing in there that mandates it either. (I > >thought this discussion had already clarified that.) > > There was an attempt to in

Re: stmmac: Reporting ethtool_ts_info

2015-10-29 Thread Rayagond Kokatanur
On Tue, Oct 27, 2015 at 11:41 AM, Phil Reid wrote: > G'day All, > > The stmmac driver checks (priv->hwts_tx_en) && (priv->hwts_rx_en) before > reporting WHTSTAMP capabilities. > No other driver seems to do this. hwts_*_en indicate if timestamping is > enabled, not if the interface is capable of it

[PATCH] NET: ATM: MPOA: Remove 32-bit timekeeping

2015-10-29 Thread Tina Ruchandani
net/atm/mpoa_* files use 'struct timeval' to store event timestamps. struct timeval uses a 32-bit seconds field which will overflow in the year 2038 and beyond. Morever, the timestamps are being compared only to get seconds elapsed, so struct timeval which stores a seconds and microseconds field is

Re: kernel BUG in ipmr_queue_xmit()

2015-10-29 Thread Eric Dumazet
On Thu, 2015-10-29 at 18:41 -0700, Ani Sinha wrote: > > Signed-off-by: Ani Sinha > --- > net/ipv4/ipmr.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c > index 866ee89..48df3cc 100644 > --- a/net/ipv4/ipmr.c > +++ b/net/ipv4/ipmr.c > @@ -936,7 +936

[PATCH v6] isdn: Use ktime_t instead of 'struct timeval'

2015-10-29 Thread Tina Ruchandani
'struct timeval' uses 32-bit representation for seconds which will overflow in year 2038 and beyond. mISDN/clock.c needs to compute and store elapsed time in intervals of 125 microseconds. This patch replaces the usage of 'struct timeval' with 64-bit ktime_t which is y2038 safe. The patch also repl

Re: [patch net-next 00/12] mlxsw: driver update

2015-10-29 Thread David Miller
From: Jiri Pirko Date: Wed, 28 Oct 2015 10:16:53 +0100 > This driver update mainly brings support for user to be able to setup > flooding on specified port, via bridge flag. Also, there is a fix in ageing > time conversion. The rest is just cosmetics. Series applied, thanks Jiri. -- To unsubscri

Re: [PATCH net-next v2 0/2] drivers: xgene: Add support RGMII TX/RX delay configuration

2015-10-29 Thread David Miller
From: Iyappan Subramanian Date: Mon, 26 Oct 2015 15:25:14 -0700 > X-Gene RGMII ethernet controller has a RGMII bridge that performs the > task of converting the RGMII signal {RX_CLK,RX_CTL, RX_DATA[3:0]} from > PHY to GMII signal {RX_DV,RX_ER,RX_DATA[7:0]} and vice versa. This > RGMII bridge has

Re: [PATCHv2 net 1/2] ipv4: fix to not remove local route on link down

2015-10-29 Thread David Miller
From: Julian Anastasov Date: Mon, 26 Oct 2015 23:59:12 +0200 ... > -int fib_sync_down_dev(struct net_device *dev, unsigned long event) > +/* Event force Flags Description > + * NETDEV_CHANGE 0 LINKDOWNCarrier OFF, not for scope host > + * NETDEV_DOWN

Re: [PATCH net-next v3] bridge: set is_local and is_static before fdb entry is added to the fdb hashtable

2015-10-29 Thread David Miller
From: Roopa Prabhu Date: Tue, 27 Oct 2015 07:52:56 -0700 > From: Roopa Prabhu > > Problem Description: > We can add fdbs pointing to the bridge with NULL ->dst but that has a > few race conditions because br_fdb_insert() is used which first creates > the fdb and then, after the fdb has been pub

Re: [PATCH v8 3/3] geneve: add IPv6 bits to geneve_fill_metadata_dst

2015-10-29 Thread David Miller
From: "John W. Linville" Date: Tue, 27 Oct 2015 09:49:00 -0400 > Signed-off-by: John W. Linville Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v7 2/3] geneve: handle ipv6 priority like ipv4 tos

2015-10-29 Thread David Miller
From: "John W. Linville" Date: Mon, 26 Oct 2015 17:01:45 -0400 > Other callers of udp_tunnel6_xmit_skb just pass 0 for the prio > argument. Jesse Gross suggested that prio is really > the same as IPv4's tos and should be handled the same, so this is my > interpretation of that suggestion. > >

Re: [PATCH v7 1/3] geneve: implement support for IPv6-based tunnels

2015-10-29 Thread David Miller
From: "John W. Linville" Date: Mon, 26 Oct 2015 17:01:44 -0400 > NOTE: Link-local IPv6 addresses for remote endpoints are not supported, > since the driver currently has no capacity for binding a geneve > interface to a specific link. > > Signed-off-by: John W. Linville > Reviewed-by: Jesse Gro

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

2015-10-29 Thread Lan Tianyu
On 2015年10月30日 00:17, Alexander Duyck wrote: > On 10/29/2015 01:33 AM, Lan Tianyu wrote: >> On 2015年10月29日 14:58, Alexander Duyck wrote: >>> Your code was having to do a bunch of shuffling in order to get things >>> set up so that you could bring the interface back up. I would argue >>> that it ma

ip rule tos not works on many tos value

2015-10-29 Thread 神楽坂玲奈
``` # ip rule add tos 0x10 lookup 1# run successfully # ip rule add tos 0x20 lookup 2 RTNETLINK answers: Invalid argument ``` i tried all 1-255 tos values, and find just these values can be used: 2 4 6 8 10 12 14 16 18 what should i do if i want to use more tos value? ``` $ cat /etc/iproute

[PATCH] net: hisilicon: Remove .owner assignment from platform_driver

2015-10-29 Thread huangdaode
platform_driver doesn't need to set .owner, because platform_driver_register() will set it. Signed-off-by: huangdaode --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilic

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-29 Thread David Miller
From: Al Viro Date: Thu, 29 Oct 2015 17:07:48 + > _IF_ you are doing that kind of "close a descriptor under other threads" > thing, you need to inform the potentially affected threads anyway, and > you'd better not rely on them being currently in kernel mode. +1 -- To unsubscribe from this l

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-29 Thread David Miller
From: Alan Burlison Date: Thu, 29 Oct 2015 17:12:44 + > On 29/10/2015 17:07, Al Viro wrote: > >> Could the esteemed sir possibly be ars^H^H^Hprevailed upon to quote >> the exact >> place in POSIX that requires such behaviour? > > If that's the way the conversation is going to go, sorry, no.

Re: [PATCH 1/1] commit c6825c0976fa7893692e0e43b09740b419b23c09 upstream.

2015-10-29 Thread Neal P. Murphy
On Thu, 29 Oct 2015 17:01:24 -0700 Ani Sinha wrote: > On Wed, Oct 28, 2015 at 11:40 PM, Neal P. Murphy > wrote: > > On Wed, 28 Oct 2015 02:36:50 -0400 > > "Neal P. Murphy" wrote: > > > >> On Mon, 26 Oct 2015 21:06:33 +0100 > >> Pablo Neira Ayuso wrote: > >> > >> > Hi, > >> > > >> > On Mon, Oct

[PATCH net] net: bcmgenet: Software reset EPHY after power on

2015-10-29 Thread Florian Fainelli
The EPHY on GENET v1->v3 is extremely finicky, and will show occasional failures based on the timing and reset sequence, ranging from duplicate packets, to extremely high latencies. Perform an additional software reset, and re-configuration to make sure it is in a consistent and working state. Fi

Re: [BUG] Any-IP IPv6 support broken

2015-10-29 Thread Maciej Żenczykowski
What are you trying to do? The intent of the patch is to be able to terminate connections from outside the machine that are reaching the machine (perhaps delivered inside a tunnel or via some other mechanism: static arp entries, routing via the machine, etc), that the kernel wouldn't normally thin

Re: [PATCH net] i40e: Look up MAC address in Open Firmware or IDPROM

2015-10-29 Thread Andy Shevchenko
On Fri, Oct 30, 2015 at 1:34 AM, Sowmini Varadhan wrote: > > > This is the i40e equivalent of commit c762dff24c06 ("ixgbe: Look up MAC > address in Open Firmware or IDPROM"). > > As with that fix, attempt to look up the MAC address in Open Firmware > on systems that uspport it, and use IDPROM on S

Re: [PATCH 1/1] commit c6825c0976fa7893692e0e43b09740b419b23c09 upstream.

2015-10-29 Thread Ani Sinha
On Wed, Oct 28, 2015 at 11:40 PM, Neal P. Murphy wrote: > On Wed, 28 Oct 2015 02:36:50 -0400 > "Neal P. Murphy" wrote: > >> On Mon, 26 Oct 2015 21:06:33 +0100 >> Pablo Neira Ayuso wrote: >> >> > Hi, >> > >> > On Mon, Oct 26, 2015 at 11:55:39AM -0700, Ani Sinha wrote: >> > > netfilter: nf_conntra

Re: [PATCH net-next V18 3/3] 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-10-29 Thread Thomas F Herbert
Pravin, please look at comment inline below: On 10/27/15 1:22 PM, Pravin Shelar wrote: On Tue, Oct 27, 2015 at 9:45 AM, Thomas F Herbert wrote: On 10/26/15 10:10 PM, Pravin Shelar wrote: Thanks for the review. On Sun, Oct 25, 2015 at 5:11 PM, Thomas F Herbert wrote: Add support for 802.1ad

Re: [PATCH v2 1/3] virtio_net: Stop doing DMA from the stack

2015-10-29 Thread Andy Lutomirski
On Wed, Oct 28, 2015 at 12:07 AM, Michael S. Tsirkin wrote: > How about this instead? Less code, more robust. > > Warning: untested. If you do like this approach, Tested-by would be > appreciated. I like it. Tested-by: Andy Lutomirski --Andy -- To unsubscribe from this list: send the line "un

[PATCH net] i40e: Look up MAC address in Open Firmware or IDPROM

2015-10-29 Thread Sowmini Varadhan
This is the i40e equivalent of commit c762dff24c06 ("ixgbe: Look up MAC address in Open Firmware or IDPROM"). As with that fix, attempt to look up the MAC address in Open Firmware on systems that uspport it, and use IDPROM on SPARC if no OF address is found. Reviewed-by: Martin K. Petersen Sig

Re: [PATCH 2/2] sh_eth: fix WARNING in dma_free_coherent()

2015-10-29 Thread Sergei Shtylyov
On 10/30/2015 12:52 AM, Sergei Shtylyov wrote: Iff the first dma_alloc_coherent() call fails in sh_eth_ring_init(), the following is printed to the kernel console: WARNING: CPU: 0 PID: 1 at drivers/base/dma-mapping.c:334 dma_common_free_remap+0x48/0x6c() Oops, I got the function name wr

Re: [patch] tcp: attach SYNACK messages to request sockets instead of listener

2015-10-29 Thread Eric Dumazet
On Thu, 2015-10-29 at 21:49 +, Haiyang Zhang wrote: > Hi Eric, > > I saw a panic in __dev_kfree_skb_any() when I ssh into some > Ubuntu VM with latest Linux-next tree on Hyper-V host. > With git bisecting, I found the patch below is the first commit > with this issue. I also included the stac

Re: [PATCH RFC net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2015-10-29 Thread Bendik Rønning Opstad
On Monday, October 26, 2015 02:58:03 PM Yuchung Cheng wrote: > On Mon, Oct 26, 2015 at 2:35 PM, Andreas Petlund wrote: > > > On 26 Oct 2015, at 15:50, Neal Cardwell wrote: > > > > > > On Fri, Oct 23, 2015 at 4:50 PM, Bendik Rønning Opstad > > > > > > wrote: > > >> @@ -2409,6 +2412,15 @@ static

Re: [patch] tcp: attach SYNACK messages to request sockets instead of listener

2015-10-29 Thread Haiyang Zhang
Hi Eric, I saw a panic in __dev_kfree_skb_any() when I ssh into some Ubuntu VM with latest Linux-next tree on Hyper-V host. With git bisecting, I found the patch below is the first commit with this issue. I also included the stack trace here. Do you have any idea about what the problem might be?

[PATCH 2/2] sh_eth: fix WARNING in dma_free_coherent()

2015-10-29 Thread Sergei Shtylyov
Iff the first dma_alloc_coherent() call fails in sh_eth_ring_init(), the following is printed to the kernel console: WARNING: CPU: 0 PID: 1 at drivers/base/dma-mapping.c:334 dma_common_free_remap+0x48/0x6c() trying to free invalid coherent area: (null) Modules linked in: CPU: 0 PID: 1 Comm: s

[PATCH 1/2] sh_eth: fix uninitialized arrays in sh_eth_ring_init()

2015-10-29 Thread Sergei Shtylyov
sh_eth_ring_free() called in the sh_eth_ring_init()'s error path expects the arrays pointed by sh_eth_private::[rt]x_skbuff to be initialized with NULLs but they are allocated with just kmalloc_array() and so left filled with random data. Use kcalloc() instead. Signed-off-by: Sergei Shtylyov

[PATCH 0/2] sh_eth: fix bugs in sh_eth_ring_init()

2015-10-29 Thread Sergei Shtylyov
Hello. Here's a set of 2 patches against DaveM's 'net.git' repo which fix couple of bugs in the sh_eth_ring_init() function. [1/2] sh_eth: fix uninitialized arrays in sh_eth_ring_init() [2/2] sh_eth: fix WARNING in dma_free_coherent() MBR, Sergei -- To unsubscribe from this list: send the li

[PATCH net-next v2] ipv4: use l4 hash for locally generated multipath flows

2015-10-29 Thread Paolo Abeni
This patch changes how the multipath hash is computed for locally generated flows: now the hash comprises l4 information. This allows better utilization of the available paths when the existing flows have the same source IP and the same destination IP: with l3 hash, even when multiple connections

Re: [PATCH net-next] ipv4: use l4 hash for locally generated multipath flows

2015-10-29 Thread Paolo Abeni
On Thu, 2015-10-29 at 11:43 -0700, Eric Dumazet wrote: > On Thu, 2015-10-29 at 17:52 +0100, Paolo Abeni wrote: > > On Thu, 2015-10-29 at 08:28 -0700, Eric Dumazet wrote: > > > On Thu, 2015-10-29 at 16:00 +0100, Paolo Abeni wrote: > > > > > > > This patch do not add dissection code: it use the info

Re: [PATCHv2 net 2/2] ipv4: update RTNH_F_LINKDOWN flag on UP event

2015-10-29 Thread Julian Anastasov
Hello, On Tue, 27 Oct 2015, Andy Gospodarek wrote: > > Of course, we have a semantic problem when setting > > RTNH_F_LINKDOWN on last address removal, i.e. this event > > has nothing to do with the link state. But it works because > > RTNH_F_LINKDOWN is valid for lookups only when DE

pull-request: wireless-drivers-next 2015-10-29

2015-10-29 Thread Kalle Valo
Hi Dave, here's hopefully my last pull request for 4.4. ssb had a new Kconfig entry and that's why this touches arch/mips/bcm47xx/Kconfig. ssb also did some code shuffling and moved code from b43 to ssb subsystem. Otherwise should be business as usual. While writing this I noticed that Fengwei Yi

Re: [PATCH 0/2] sh_eth: RX buffer alignment fixes

2015-10-29 Thread Sergei Shtylyov
Hello. On 10/27/2015 04:32 AM, David Miller wrote: Here's a set of 2 patches against DaveM's 'net.git' repo which are the fixes to the RX buffer size calculation. [1/2] sh_eth: fix RX buffer size alignment [2/2] sh_eth: fix RX buffer size calculation Series applied, thanks. Will you

Re: [BUG] Any-IP IPv6 support broken

2015-10-29 Thread Hannes Frederic Sowa
On Thu, Oct 29, 2015, at 19:58, Gilberto Bertin wrote: > > > On 29 Oct 2015, at 18:39, Hannes Frederic Sowa > > wrote: > > > > Try the loopback interface: > > > > ip -6 route add local abcd:abcd:abcd:abcd::/64 dev *lo* > > > > Otherwise packets should end up in neighbor subsystem and you do

RE: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2015-10-29 Thread Haiyang Zhang
> -Original Message- > From: Richard Weinberger [mailto:richard.weinber...@gmail.com] > Sent: Tuesday, October 27, 2015 6:36 PM > To: David Miller > Cc: Haiyang Zhang ; o...@aepfle.de; Greg Kroah- > Hartman ; netdev@vger.kernel.org; jasow...@redhat.com; > driverdev-de...@linuxdriverproje

Re: [BUG] Any-IP IPv6 support broken

2015-10-29 Thread Gilberto Bertin
> On 29 Oct 2015, at 18:39, Hannes Frederic Sowa > wrote: > > Try the loopback interface: > > ip -6 route add local abcd:abcd:abcd:abcd::/64 dev *lo* > > Otherwise packets should end up in neighbor subsystem and you don't want > that, still. ;) > Thanks for the reply. I know it’s working o

Re: [PATCH net-next RFC] mpls: support for dead routes

2015-10-29 Thread roopa
On 10/29/15, 9:53 AM, Robert Shearman wrote: > On 29/10/15 15:49, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> Adds support for both RTNH_F_DEAD and RTNH_F_LINKDOWN flags. >> This resembles ipv4 fib code. I also picked fib_rebalance from >> ipv4. Enabled weights support for nexthop, just becaus

Re: [PATCH net-next] ipv4: use l4 hash for locally generated multipath flows

2015-10-29 Thread Eric Dumazet
On Thu, 2015-10-29 at 17:52 +0100, Paolo Abeni wrote: > On Thu, 2015-10-29 at 08:28 -0700, Eric Dumazet wrote: > > On Thu, 2015-10-29 at 16:00 +0100, Paolo Abeni wrote: > > > > > This patch do not add dissection code: it use the information provided > > > by the available flowi4 structure. Moreove

Re: [BUG] Any-IP IPv6 support broken

2015-10-29 Thread Hannes Frederic Sowa
Hello, On Thu, Oct 29, 2015, at 16:00, Gilberto Bertin wrote: > 2- note that it's not actually working with IPv6 addresses: > > # ip -6 route add local abcd:abcd:abcd:abcd::/64 dev eth0 Try the loopback interface: ip -6 route add local abcd:abcd:abcd:abcd::/64 dev *lo* Otherwise packets shoul

Re: [PATCH 0/8] mm: memcontrol: account socket memory in unified hierarchy

2015-10-29 Thread Johannes Weiner
On Thu, Oct 29, 2015 at 12:27:47PM +0300, Vladimir Davydov wrote: > On Wed, Oct 28, 2015 at 11:58:10AM -0700, Johannes Weiner wrote: > > Having the hard limit as a failsafe (or a minimum for other consumers) > > is one thing, and certainly something I'm open to for cgroupv2, should > > we have prob

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-29 Thread Alan Burlison
[off list] On 29/10/2015 17:07, Al Viro wrote: Could the esteemed sir possibly be ars^H^H^Hprevailed upon to quote the exact place in POSIX that requires such behaviour? If that's the way the conversation is going to go, sorry, no. -- Alan Burlison -- -- To unsubscribe from this list: send t

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-29 Thread Al Viro
On Thu, Oct 29, 2015 at 04:15:33PM +, Alan Burlison wrote: > There was an attempt to interpret POSIX that way, with which I still > disagree. If a FD is closed or reassigned then any current pending > operations on it should be terminated. Could the esteemed sir possibly be ars^H^H^Hprevailed

Re: [PATCH net-next RFC] mpls: support for dead routes

2015-10-29 Thread Robert Shearman
On 29/10/15 15:49, Roopa Prabhu wrote: From: Roopa Prabhu Adds support for both RTNH_F_DEAD and RTNH_F_LINKDOWN flags. This resembles ipv4 fib code. I also picked fib_rebalance from ipv4. Enabled weights support for nexthop, just because the infrastructure is already there. Signed-off-by: Roop

Re: [PATCH net-next] ipv4: use l4 hash for locally generated multipath flows

2015-10-29 Thread Paolo Abeni
On Thu, 2015-10-29 at 08:28 -0700, Eric Dumazet wrote: > On Thu, 2015-10-29 at 16:00 +0100, Paolo Abeni wrote: > > > This patch do not add dissection code: it use the information provided > > by the available flowi4 structure. Moreover the skb is not available on > > the calling site (in __ip_rout

[PATCH v4] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

2015-10-29 Thread Mans Rullgard
This adds a driver for the Aurora VLSI NB8800 Ethernet controller. It is an almost complete rewrite of a driver originally found in a Sigma Designs 2.6.22 tree. Signed-off-by: Mans Rullgard --- Changes: - Make ethtool_ops const - Fix race in tx path on smp systems - Use different interrupt method

[iproute PATCH v2] lib/utils: improve error messages of get_addr() and get_prefix()

2015-10-29 Thread Phil Sutter
Instead of statically complaining about illegal inet address, use get_family() to get the address family right. Based on a patch by Hangbin Liu to print "inet6" for AF_INET6 made more generic by me. Signed-off-by: Phil Sutter --- Changes since v1: - Rebased this patch on top of Stephen Hemminger

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

2015-10-29 Thread Alexander Duyck
On 10/29/2015 01:33 AM, Lan Tianyu wrote: On 2015年10月29日 14:58, Alexander Duyck wrote: Your code was having to do a bunch of shuffling in order to get things set up so that you could bring the interface back up. I would argue that it may actually be faster at least on the bring-up to just drop

[iproute PATCH] lib/utils: improve error messages of get_addr() and get_prefix()

2015-10-29 Thread Phil Sutter
Instead of statically complaining about illegal inet address, use get_family() to get the address family right. Based on a patch by Hangbin Liu to print "inet6" for AF_INET6 made more generic by me. Signed-off-by: Phil Sutter --- lib/utils.c | 6 -- 1 file changed, 4 insertions(+), 2 deleti

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-29 Thread Alan Burlison
On 29/10/2015 16:01, David Holland wrote: Hardly; it moves the burden of doing stupid things to the application. If as you said the goal is to shut down all threads cleanly, then it doesn't need to keep track in detail anyway; it can just post SIGTERM to every thread, or SIGUSR1 if SIGTERM is ba

Re: [PATCH 5/8] mm: memcontrol: account socket memory on unified hierarchy

2015-10-29 Thread Johannes Weiner
On Thu, Oct 29, 2015 at 04:25:46PM +0100, Michal Hocko wrote: > On Tue 27-10-15 09:42:27, Johannes Weiner wrote: > > On Tue, Oct 27, 2015 at 05:15:54PM +0100, Michal Hocko wrote: > > > On Tue 27-10-15 11:41:38, Johannes Weiner wrote: > > > > IMO that's an implementation detail and a historical arti

RE: [V5, 2/6] fsl/fman: Add FMan support

2015-10-29 Thread Liberman Igal
Regards, Igal Liberman > -Original Message- > From: Wood Scott-B07421 > Sent: Thursday, October 29, 2015 5:25 PM > To: Liberman Igal-B31950 > Cc: netdev@vger.kernel.org; linuxppc-...@lists.ozlabs.org; linux- > ker...@vger.kernel.org; Bucur Madalin-Cristian-B32716 > > Subject: Re: [V5, 2

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-29 Thread David Holland
On Thu, Oct 29, 2015 at 03:18:40PM +, Alan Burlison wrote: > On 29/10/2015 14:58, David Holland wrote: > >ISTM that the best way to do this is to post a signal to the thread so > >accept bails with EINTR, at which point it can check to see if it's > >supposed to be exiting. > > Yes, you

Re: [V5, 2/6] fsl/fman: Add FMan support

2015-10-29 Thread Scott Wood
On Thu, 2015-10-29 at 10:22 -0500, Liberman Igal-B31950 wrote: > Regards, > Igal Liberman > > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Wednesday, October 28, 2015 11:31 PM > > To: Liberman Igal-B31950 > > Cc: netdev@vger.kernel.org; linuxppc-...@lists.ozlabs.org; linux-

Re: [PATCH 5/8] mm: memcontrol: account socket memory on unified hierarchy

2015-10-29 Thread Michal Hocko
On Tue 27-10-15 09:42:27, Johannes Weiner wrote: > On Tue, Oct 27, 2015 at 05:15:54PM +0100, Michal Hocko wrote: > > On Tue 27-10-15 11:41:38, Johannes Weiner wrote: [...] > Or it could be exactly the other way around when you have a workload > that is heavy on filesystem metadata. I don't see why

[PATCH net-next RFC] mpls: support for dead routes

2015-10-29 Thread Roopa Prabhu
From: Roopa Prabhu Adds support for both RTNH_F_DEAD and RTNH_F_LINKDOWN flags. This resembles ipv4 fib code. I also picked fib_rebalance from ipv4. Enabled weights support for nexthop, just because the infrastructure is already there. Signed-off-by: Roopa Prabhu --- I want to get this in befor

Re: [PATCH net-next] ipv4: use l4 hash for locally generated multipath flows

2015-10-29 Thread Tom Herbert
On Thu, Oct 29, 2015 at 8:00 AM, Paolo Abeni wrote: > On Thu, 2015-10-29 at 07:31 -0700, Eric Dumazet wrote: >> On Wed, 2015-10-28 at 18:39 +0100, Paolo Abeni wrote: >> > This patch changes how the multipath hash is computed for locally >> > generated UDP or TCP flows: now the hash comprises also

Re: [PATCH v2 1/6] net: dsa: Use delayed work instead of timer+work for polling

2015-10-29 Thread Andrew Lunn
> Is 6060 supported by the 6352 family? It doesn't share any mv88e6xxx > code... It is a totally separate driver. Nothing shared at all.. It is an old device, and only does 10/100. It could be it is just too different to support via mv88e6xxx. Andrew -- To unsubscribe from this list: send the

Re: [PATCH net-next] ipv4: use l4 hash for locally generated multipath flows

2015-10-29 Thread Eric Dumazet
On Thu, 2015-10-29 at 16:00 +0100, Paolo Abeni wrote: > This patch do not add dissection code: it use the information provided > by the available flowi4 structure. Moreover the skb is not available on > the calling site (in __ip_route_output_key_hash) and pushing it all the > way will require a lo

Re: [BUG] Any-IP IPv6 support broken

2015-10-29 Thread Eric Dumazet
On Thu, 2015-10-29 at 15:00 +, Gilberto Bertin wrote: > Hello, > testing Any-IP on my machine, I noticed that it's not working with IPv6 > addresses. > Tests are performed on a 4.1 kernel. > > Steps to reproduce the bug: > > 1- make sure Any-IP is working with IPv4 addresses: > > # ip -4 rou

RE: [V5, 2/6] fsl/fman: Add FMan support

2015-10-29 Thread Liberman Igal
Regards, Igal Liberman > -Original Message- > From: Wood Scott-B07421 > Sent: Wednesday, October 28, 2015 11:31 PM > To: Liberman Igal-B31950 > Cc: netdev@vger.kernel.org; linuxppc-...@lists.ozlabs.org; linux- > ker...@vger.kernel.org; Bucur Madalin-Cristian-B32716 > > Subject: Re: [V5,

dynamically set number of queues for 82598 devices

2015-10-29 Thread William Dauchy
Hello David, I faced the problem described in commit 7e3f5c8: ixgbe: fix bounds checking in ixgbe_setup_tc for 82598 This patch resolves an issue where users were not able to dynamically set number of queues for 82598 via ethtool -L I backported it for my v4.1.x build but I was wondering if thi

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-29 Thread Alan Burlison
On 29/10/2015 14:58, David Holland wrote: ISTM that the best way to do this is to post a signal to the thread so accept bails with EINTR, at which point it can check to see if it's supposed to be exiting. Yes, you could use pthread_kill, but that would require keeping a list of the tids of al

Re: [RFC PATCH v3 2/5] net: dsa: bcm_sf2: cleanup resources in remove callback

2015-10-29 Thread Andrew Lunn
On Thu, Oct 29, 2015 at 03:45:30PM +0100, Neil Armstrong wrote: > Implement a remove callback allowing the switch driver to cleanup > resources it used: interrupts and remapped register ranges. > > Signed-off-by: Florian Fainelli > Signed-off-by: Neil Armstrong > --- > drivers/net/dsa/bcm_sf2.c

Re: [PATCH v2 1/6] net: dsa: Use delayed work instead of timer+work for polling

2015-10-29 Thread Vivien Didelot
On Oct. Thursday 29 (44) 03:40 PM, Andrew Lunn wrote: > > Thanks for the hint, I will test this, but while reviewing the datasheet, > > the port 5 has no PHY, so must only be used as cpu port. > > Not necessarily. All that is needed is an external phy. Linux does not > care what MDIO bus that phy

[GIT] Networking

2015-10-29 Thread David Miller
This is the same as the previous pull request, with the ipv6 overflow fix redone. The merge conflict is therefore gone too. 1) Fix two regressions in ipv6 route lookups, particularly wrt. output interface specifications in the lookup key. From David Ahern. 2) Fix checks in ipv6 IPSEC tunnel

Re: [PATCH net-next] ipv4: use l4 hash for locally generated multipath flows

2015-10-29 Thread Paolo Abeni
On Thu, 2015-10-29 at 07:31 -0700, Eric Dumazet wrote: > On Wed, 2015-10-28 at 18:39 +0100, Paolo Abeni wrote: > > This patch changes how the multipath hash is computed for locally > > generated UDP or TCP flows: now the hash comprises also l4 information > > (source and destination port). > > > >

[BUG] Any-IP IPv6 support broken

2015-10-29 Thread Gilberto Bertin
Hello, testing Any-IP on my machine, I noticed that it's not working with IPv6 addresses. Tests are performed on a 4.1 kernel. Steps to reproduce the bug: 1- make sure Any-IP is working with IPv4 addresses: # ip -4 route add local 4.4.4.0/24 dev eth0 with this command every packets with an IP i

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-29 Thread David Holland
On Tue, Oct 27, 2015 at 10:52:46AM +, Alan Burlison wrote: > >But in general, this is basically a problem with the application: the file > >descriptor space is shared between threads and having one thread sniping > >at open files, you do have a problem and whatever the kernel does in that >

Re: [RFC PATCH v3 1/5] net: dsa: allow switch drivers to cleanup their resources

2015-10-29 Thread Neil Armstrong
On 10/29/2015 03:50 PM, Andrew Lunn wrote: > On Thu, Oct 29, 2015 at 03:45:24PM +0100, Neil Armstrong wrote: >> --- a/net/dsa/dsa.c >> +++ b/net/dsa/dsa.c >> @@ -459,6 +459,10 @@ static void dsa_switch_destroy(struct dsa_switch *ds) >> } >> >> mdiobus_unregister(ds->slave_mii_bus); >> + >

Re: BUG: fsl FEC ethernet tx checksum offloading doesn't work with RMII interface

2015-10-29 Thread Fabio Estevam
On Wed, Oct 28, 2015 at 10:36 AM, David Jander wrote: > I can search further down, but 4.1 is also broken. > Are there specific changes or versions you are suspicious of? I was just trying to understand if this was a regression or if it has always been broken. -- To unsubscribe from this list: s

Re: [RFC PATCH v3 1/5] net: dsa: allow switch drivers to cleanup their resources

2015-10-29 Thread Andrew Lunn
On Thu, Oct 29, 2015 at 03:45:24PM +0100, Neil Armstrong wrote: > Some switch drivers might request interrupts, remap register ranges, > allow such drivers to implement a "remove" callback doing just that. > > Signed-off-by: Florian Fainelli > Signed-off-by: Neil Armstrong > --- > include/net/d

[RFC PATCH v3 1/5] net: dsa: allow switch drivers to cleanup their resources

2015-10-29 Thread Neil Armstrong
Some switch drivers might request interrupts, remap register ranges, allow such drivers to implement a "remove" callback doing just that. Signed-off-by: Florian Fainelli Signed-off-by: Neil Armstrong --- include/net/dsa.h | 1 + net/dsa/dsa.c | 4 2 files changed, 5 insertions(+) diff

[RFC PATCH v3 0/5] net: dsa: cleanup dsa driver

2015-10-29 Thread Neil Armstrong
Introduce a new remove callback to allow DSA drivers to cleanup their ressources. Then add a remove implementation for bcm_sf2 and mv88e6xxx. This patch was not tested due of a lack of hardware. v2: add remove callback patch to the serie v3: separate & fix ppu remove callback into a proper patch

[RFC PATCH v3 5/5] net: dsa: add mv88e6xxx ppu remove function for mv88e6131

2015-10-29 Thread Neil Armstrong
The mv88e6131 also need to call remove for the ppu part of mv88e6xxx. Add the ppu remove function and add a mv88e6131 specific remove callback calling the ppu remove function. Signed-off-by: Neil Armstrong --- drivers/net/dsa/mv88e6131.c | 9 - drivers/net/dsa/mv88e6xxx.c | 10 +

[RFC PATCH v3 2/5] net: dsa: bcm_sf2: cleanup resources in remove callback

2015-10-29 Thread Neil Armstrong
Implement a remove callback allowing the switch driver to cleanup resources it used: interrupts and remapped register ranges. Signed-off-by: Florian Fainelli Signed-off-by: Neil Armstrong --- drivers/net/dsa/bcm_sf2.c | 20 1 file changed, 20 insertions(+) diff --git a/dri

[RFC PATCH v3 4/5] net: dsa: make usage of mv88e6xxx common remove function

2015-10-29 Thread Neil Armstrong
Make usage of previously introduced mv88e6xxx common remove function in all mv88e6xxx drivers. Signed-off-by: Neil Armstrong --- drivers/net/dsa/mv88e6123_61_65.c | 1 + drivers/net/dsa/mv88e6131.c | 1 + drivers/net/dsa/mv88e6171.c | 1 + drivers/net/dsa/mv88e6352.c | 1 + 4 f

[RFC PATCH v3 3/5] net: dsa: mv88e6xxx: add common remove function

2015-10-29 Thread Neil Armstrong
With the previously introduced remove callback, add a mv88e6xxx common remove function to cleanup all resources. Signed-off-by: Neil Armstrong --- drivers/net/dsa/mv88e6xxx.c | 8 drivers/net/dsa/mv88e6xxx.h | 1 + 2 files changed, 9 insertions(+) diff --git a/drivers/net/dsa/mv88e6xxx

Re: [PATCH v2 1/6] net: dsa: Use delayed work instead of timer+work for polling

2015-10-29 Thread Andrew Lunn
> Thanks for the hint, I will test this, but while reviewing the datasheet, > the port 5 has no PHY, so must only be used as cpu port. Not necessarily. All that is needed is an external phy. Linux does not care what MDIO bus that phy hangs off. It could be the same MDIO bus as the switch, or some

Re: [PATCH net-next] ipv4: use l4 hash for locally generated multipath flows

2015-10-29 Thread Eric Dumazet
On Wed, 2015-10-28 at 18:39 +0100, Paolo Abeni wrote: > This patch changes how the multipath hash is computed for locally > generated UDP or TCP flows: now the hash comprises also l4 information > (source and destination port). > > This allows better utilization of the available paths when the exi

[PATCH net-next] net: dsa: use switchdev obj for VLAN add/del ops

2015-10-29 Thread Vivien Didelot
Simplify DSA by pushing the switchdev objects for VLAN add and delete operations down to its drivers. Currently only mv88e6xxx is affected. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6171.c | 2 +- drivers/net/dsa/mv88e6352.c | 2 +- drivers/net/dsa/mv88e6xxx.c | 108

Re: [RFC] unix: fix use-after-free in unix_dgram_poll()

2015-10-29 Thread Rainer Weikusat
Jason Baron writes: > On 10/28/2015 12:46 PM, Rainer Weikusat wrote: >> Rainer Weikusat writes: >>> Jason Baron writes: [...] >> and the not-so-nice additional property that the connect and >> disconnect functions need to take the peer_wait.lock spinlock >> explicitly so that this lock is used

Re: [PATCH v2 1/6] net: dsa: Use delayed work instead of timer+work for polling

2015-10-29 Thread Neil Armstrong
On 10/29/2015 02:51 PM, Andrew Lunn wrote: > On Thu, Oct 29, 2015 at 02:22:41PM +0100, Neil Armstrong wrote: > Hi Neil, Frode > > I assume you have see: > > http://permalink.gmane.org/gmane.linux.network/380777 > > which is now in net-next. > > The only driver making use of poll_link is mv88e60

Re: [PATCH v2 5/6] net: dsa: add missing calls in dsa_switch_destroy

2015-10-29 Thread Neil Armstrong
On 10/29/2015 03:00 PM, Andrew Lunn wrote: > On Thu, Oct 29, 2015 at 02:23:25PM +0100, Neil Armstrong wrote: >> >> +netif_carrier_off(ds->ports[port]); >> unregister_netdev(ds->ports[port]); >> +phy_disconnect(p->phy); >> free_netdev(ds->ports[port]

Re: [PATCH v2 5/6] net: dsa: add missing calls in dsa_switch_destroy

2015-10-29 Thread Andrew Lunn
On Thu, Oct 29, 2015 at 02:23:25PM +0100, Neil Armstrong wrote: > Add missing netif_carrier_off and phy_disconnect calls to the > dsa_switch_destroy function to make sure the netdev and phy > ressources are clean before complete removal. > > Signed-off-by: Frode Isaksen > Signed-off-by: Neil Arms

[PATCH net-next v2 3/5] bpf: consolidate bpf_prog_put{,_rcu} dismantle paths

2015-10-29 Thread Daniel Borkmann
We currently have duplicated cleanup code in bpf_prog_put() and bpf_prog_put_rcu() cleanup paths. Back then we decided that it was not worth it to make it a common helper called by both, but with the recent addition of resource charging, we could have avoided the fix in commit ac00737f4e81 ("bpf: N

[PATCH net-next v2 4/5] bpf: add support for persistent maps/progs

2015-10-29 Thread Daniel Borkmann
This work adds support for "persistent" eBPF maps/programs. The term "persistent" is to be understood that maps/programs have a facility that lets them survive process termination. This is desired by various eBPF subsystem users. Just to name one example: tc classifier/action. Whenever tc parses t

[PATCH net-next v2 1/5] bpf: abstract anon_inode_getfd invocations

2015-10-29 Thread Daniel Borkmann
Since we're going to use anon_inode_getfd() invocations in more than just the current places, make a helper function for both, so that we only need to pass a map/prog pointer to the helper itself in order to get a fd. The new helpers are called bpf_map_new_fd() and bpf_prog_new_fd(). Signed-off-by

[PATCH net-next v2 0/5] BPF updates

2015-10-29 Thread Daniel Borkmann
This set adds support for persistent maps/progs. Please see individual patches for further details. A man-page update to bpf(2) will be sent later on, also a iproute2 patch for support in tc. Thanks! v1 -> v2: - Reworked most of patch 4 and 5 - Rebased to latest net-next Daniel Borkmann (5):

[PATCH net-next v2 2/5] bpf: align and clean bpf_{map,prog}_get helpers

2015-10-29 Thread Daniel Borkmann
Add a bpf_map_get() function that we're going to use later on and align/clean the remaining helpers a bit so that we have them a bit more consistent: - __bpf_map_get() and __bpf_prog_get() that both work on the fd struct, check whether the descriptor is eBPF and return the pointer to the

  1   2   >