[PATCH net-next v4] af_mpls: fix undefined reference to ip6_route_output

2015-07-27 Thread Roopa Prabhu
From: Roopa Prabhu Undefined reference to ip6_route_output and ip_route_output was reported with CONFIG_INET=n and CONFIG_IPV6=n. This patch adds new CONFIG_MPLS_NEXTHOP_DEVLOOKUP to lookup nexthop device if user has not specified it in RTA_OIF attribute. Make CONFIG_MPLS_NEXTHOP_DEVLOOKUP depen

Re: [PATCH] rsi: Fix failure to load firmware after memory leak fix and fix the leak

2015-07-27 Thread Mike Looijmans
On 27-07-15 12:28, Kalle Valo wrote: Mike Looijmans writes: Fixes commit eae79b4f3e82ca63a53478a161b190a0d38fe526 ("rsi: fix memory leak in rsi_load_ta_instructions()") which stopped the driver from functioning. You can abbreviate the commit id: Fixes commit eae79b4f3e82 ("rsi: fix memory

Re: [net-next PATCH 2/2] drivers: net: cpsw: add separate napi for tx packet handling for performance improvment

2015-07-27 Thread Mugunthan V N
On Tuesday 28 July 2015 02:52 AM, Francois Romieu wrote: > Mugunthan V N : > [...] >> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c >> index d68d759..4f98537 100644 >> --- a/drivers/net/ethernet/ti/cpsw.c >> +++ b/drivers/net/ethernet/ti/cpsw.c >> @@ -752,13 +753,22

Re: [net-next PATCH 2/2] drivers: net: cpsw: add separate napi for tx packet handling for performance improvment

2015-07-27 Thread Mugunthan V N
On Tuesday 28 July 2015 02:52 AM, Francois Romieu wrote: > Mugunthan V N : > [...] >> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c >> index d68d759..4f98537 100644 >> --- a/drivers/net/ethernet/ti/cpsw.c >> +++ b/drivers/net/ethernet/ti/cpsw.c >> @@ -752,13 +753,22

[PATCH v2] rsi: Fix failure to load firmware after memory leak fix and fix the leak

2015-07-27 Thread Mike Looijmans
Fixes commit eae79b4f3e82 ("rsi: fix memory leak in rsi_load_ta_instructions()") which stopped the driver from functioning. Firmware data has been allocated using vmalloc(), resulting in memory that cannot be used for DMA. Hence the firmware was first copied to a buffer allocated with kmalloc() in

Re: [PATCH net-next v3] af_mpls: fix undefined reference to ip6_route_output

2015-07-27 Thread roopa
On 7/27/15, 9:20 PM, David Miller wrote: From: Roopa Prabhu Date: Mon, 27 Jul 2015 17:41:17 -0700 @@ -33,4 +33,11 @@ config MPLS_IPTUNNEL ---help--- mpls ip tunnel support. +config MPLS_NEXTHOP_DEVLOOKUP + bool "MPLS: nexthop oif dev lookup" + depends on MPLS_R

Re: [PATCH net-next v3] af_mpls: fix undefined reference to ip6_route_output

2015-07-27 Thread David Miller
From: Roopa Prabhu Date: Mon, 27 Jul 2015 17:41:17 -0700 > @@ -33,4 +33,11 @@ config MPLS_IPTUNNEL > ---help--- >mpls ip tunnel support. > > +config MPLS_NEXTHOP_DEVLOOKUP > + bool "MPLS: nexthop oif dev lookup" > + depends on MPLS_ROUTING && INET && (IPV6 || IPV6=n) > +

Re: [PATCH 3/5] Add calls to translate Always Running Timer (ART) to system time

2015-07-27 Thread John Stultz
On Mon, Jul 27, 2015 at 5:46 PM, Christopher Hall wrote: > +static bool checked_art_to_tsc(cycle_t *tsc) > +{ > + if (!has_art()) > + return false; > + *tsc = art_to_tsc(*tsc); > + return true; > +} > + > +static int art_to_rawmono64(struct timespec64 *rawmono, cycl

Re: [PATCH 1/5] Add functions producing system time given a backing counter value

2015-07-27 Thread John Stultz
On Mon, Jul 27, 2015 at 8:44 PM, John Stultz wrote: > On Mon, Jul 27, 2015 at 5:46 PM, Christopher Hall > wrote: >> * counter_to_rawmono64 >> * counter_to_mono64 >> * counter_to_realtime64 >> >> Enables drivers to translate a captured system clock counter to system >> time. This is useful for net

Re: [PATCHv2] net/ipv6: add sysctl option accept_ra_hop_limit

2015-07-27 Thread YOSHIFUJI Hideaki
Hi, Hangbin Liu wrote: > 2015-07-28 7:50 GMT+08:00 YOSHIFUJI Hideaki/吉藤英明 > : >> Hi, >> >> Hangbin Liu wrote: >>> Commit 6fd99094de2b ("ipv6: Don't reduce hop limit for an interface") >>> disabled accept hop limit from RA if it is higher than the current hop >>> limit for security stuff. But this

Re: [PATCH 1/5] Add functions producing system time given a backing counter value

2015-07-27 Thread John Stultz
On Mon, Jul 27, 2015 at 5:46 PM, Christopher Hall wrote: > * counter_to_rawmono64 > * counter_to_mono64 > * counter_to_realtime64 > > Enables drivers to translate a captured system clock counter to system > time. This is useful for network and audio devices that capture timestamps > in terms of bo

Re: [RFC PATCH v4 net-next 1/4] tcp: replace cnt & rtt with struct in pkts_acked()

2015-07-27 Thread Alexei Starovoitov
On Mon, Jul 27, 2015 at 07:30:39PM +, Lawrence Brakmo wrote: > > > I prefer the cleanliness of passing a structure and don¹t think the > overhead will be significant enough to worry about it. > Will the compiler pass struct values in registers if the struct is > passed by value? In passing s

RE: [RFC PATCH 0/2] net: macb: Add mdio driver for accessing multiple phy devices

2015-07-27 Thread Punnaiah Choudary Kalluri
Hi Nicolas, > -Original Message- > From: Nicolas Ferre [mailto:nicolas.fe...@atmel.com] > Sent: Monday, July 27, 2015 1:07 PM > To: Michal Simek; Punnaiah Choudary Kalluri; Anirudha Sarangi; > da...@davemloft.net; Florian Fainelli; and...@lunn.ch > Cc: Harini Katakam; kpc...@gmail.com; > k

Re: [PATCHv2] net/ipv6: add sysctl option accept_ra_hop_limit

2015-07-27 Thread Hangbin Liu
2015-07-28 7:50 GMT+08:00 YOSHIFUJI Hideaki/吉藤英明 : > Hi, > > Hangbin Liu wrote: >> Commit 6fd99094de2b ("ipv6: Don't reduce hop limit for an interface") >> disabled accept hop limit from RA if it is higher than the current hop >> limit for security stuff. But this behavior kind of break the RFC def

[RFC PATCH 1/1] net/ipv4: Enable flow-based ECMP

2015-07-27 Thread Richard Laing
From: Richard Laing Enable flow-based ECMP. Currently if equal-cost multipath is enabled the kernel chooses between equal cost paths for each matching packet, essentially packets are round-robined between the routes. This means that packets from a single flow can traverse different routes. If on

RE: [PATCH] phylib: add driver for aquantia phy

2015-07-27 Thread Shaohui Xie
> > for this Aquantia PHY, SUPPORTED_1baseT_Full is a valid define, > should I set it as below: > > .features = PHY_GBIT_FEATURES | SUPPORTED_1baseT_Full, > > PHY_GBIT_FEATURES means 10/100/1000 half and full-duplex are supported, > which are not supported as you indicated above, I would

[PATCH 1/3] net: mdio-octeon: Modify driver to work on both ThunderX and Octeon

2015-07-27 Thread mohun106
From: Radha Mohan Chintakuntla This patch modifies the mdio-octeon driver to work on both ThunderX and Octeon SoCs from Cavium Inc. Signed-off-by: Sunil Goutham Signed-off-by: Radha Mohan Chintakuntla Signed-off-by: David Daney --- drivers/net/phy/Kconfig |9 ++- drivers/net/phy/md

[PATCH 0/3] Add MDIO support to ThunderX NIC driver

2015-07-27 Thread mohun106
From: Radha Mohan Chintakuntla This patch series adds MDIO support to ThunderX NIC driver by making use of existing mdio-octeon driver. In the process modified the mdio-octeon driver to work on both Octeon and ThunderX platforms. Radha Mohan Chintakuntla (3): net: mdio-octeon: Modify driver to

[PATCH 3/3] net: thunderx: Select CONFIG_MDIO_OCTEON for ThunderX NIC

2015-07-27 Thread mohun106
From: Radha Mohan Chintakuntla The CONFIG_MDIO_OCTEON is required so that the ThunderX NIC driver can talk to the PHY drivers. Signed-off-by: Radha Mohan Chintakuntla --- drivers/net/ethernet/cavium/Kconfig |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/e

[PATCH 2/3] net: mdio-octeon: Fix octeon_mdiobus_probe function for return values

2015-07-27 Thread mohun106
From: Radha Mohan Chintakuntla This patch fixes a possible crash in the octeon_mdiobus_probe function if the return values are not handled properly. Signed-off-by: Radha Mohan Chintakuntla Signed-off-by: Tomasz Nowicki --- drivers/net/phy/mdio-octeon.c | 14 +- 1 files changed,

Re: Buggy cable detection on i.MX51, fec driver and LAN8700 PHY

2015-07-27 Thread Fabio Estevam
On Mon, Jul 27, 2015 at 11:50 AM, Igor Plyatov wrote: > Dear all, > > very often we observe issue with Ethernet cable detection during cable > unplugging and plugging. > > We use Voipac i.MX51 SOMs (System On Modules). They are based on Freescale > i.MX51 CPU with LAN7800 PHY in MII mode. The sche

Re: [PATCH 3/5] Add calls to translate Always Running Timer (ART) to system time

2015-07-27 Thread Andy Lutomirski
On 07/27/2015 05:46 PM, Christopher Hall wrote: * art_to_mono64 * art_to_rawmono64 * art_to_realtime64 Intel audio and PCH ethernet devices use the Always Running Timer (ART) to relate their device clock to system time Signed-off-by: Christopher Hall --- arch/x86/Kconfig | 12

linux-next: manual merge of the net-next tree with the net tree

2015-07-27 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/ipv4/ip_fragment.c between commit: 0e60d245a0be ("inet: frag: change *_frag_mem_limit functions to take netns_frags as argument") from the net tree and commit: 14fe22e33462 ("Revert "ipv4: use skb coalescing i

RE: Buggy cable detection on i.MX51, fec driver and LAN8700 PHY

2015-07-27 Thread Duan Andy
From: Igor Plyatov Sent: Monday, July 27, 2015 10:51 PM > To: linux-ker...@vger.kernel.org; netdev@vger.kernel.org > Cc: Florian Fainelli; Joe Perches; Zhou Luwei-B45643; Duan Fugang-B38611; > Richard Cochran; David S. Miller; Uwe Kleine-König; Estevam Fabio-R49496; > Lothar Waßmann; Li Frank-B205

[PATCH 2/5] Added functions mapping TSC value to system time

2015-07-27 Thread Christopher Hall
* tsc_to_rawmono64 * tsc_to_realtime64 * tsc_to_mono64 These function build on the counter_to_* time translation function specifically for TSC based system clock Signed-off-by: Christopher Hall --- arch/x86/include/asm/tsc.h | 5 + arch/x86/kernel/tsc.c | 18 ++ 2 file

[PATCH 0/5] Patchset enabling hardware based cross-timestamps for next gen Intel platforms

2015-07-27 Thread Christopher Hall
Next generation Intel platforms will have an Always Running Timer (ART) that always runs when the system is powered and is available to both the CPU and various on-board devices. Initially, those devices include audio and network. The ART will give these devices the capability of precisely cross t

[PATCH 1/5] Add functions producing system time given a backing counter value

2015-07-27 Thread Christopher Hall
* counter_to_rawmono64 * counter_to_mono64 * counter_to_realtime64 Enables drivers to translate a captured system clock counter to system time. This is useful for network and audio devices that capture timestamps in terms of both the system clock and device clock. Signed-off-by: Christopher Hall

[PATCH 5/5] Enables cross timestamping in the e1000e driver

2015-07-27 Thread Christopher Hall
Adds getsynctime64() callback which captures "raw" cross timestamp between ART and Ethernet device clock Translates captured ART to REALTIME clock Signed-off-by: Christopher Hall --- drivers/net/ethernet/intel/e1000e/defines.h | 7 +++ drivers/net/ethernet/intel/e1000e/ptp.c | 83 ++

[PATCH 3/5] Add calls to translate Always Running Timer (ART) to system time

2015-07-27 Thread Christopher Hall
* art_to_mono64 * art_to_rawmono64 * art_to_realtime64 Intel audio and PCH ethernet devices use the Always Running Timer (ART) to relate their device clock to system time Signed-off-by: Christopher Hall --- arch/x86/Kconfig | 12 arch/x86/include/asm/art.h | 42 ++

[PATCH 4/5] Add support for driver cross-timestamp to PTP_SYS_OFFSET ioctl

2015-07-27 Thread Christopher Hall
This patch allows system and device time ("cross-timestamp") to be performed by the driver. Currently, the cross-timestamping is performed in the PTP_SYS_OFFSET ioctl. The PTP clock driver reads gettimeofday() and the gettime64() callback provided by the driver. The cross-timestamp is best effort

[PATCH net-next v3] af_mpls: fix undefined reference to ip6_route_output

2015-07-27 Thread Roopa Prabhu
From: Roopa Prabhu This patch fixes undefined reference to ip6_route_output and ip_route_output with CONFIG_INET=n and CONFIG_IPV6=n. The patch adds new CONFIG_MPLS_NEXTHOP_DEVLOOKUP to lookup nexthop device if user has not specified it in RTA_OIF attribute. Make CONFIG_MPLS_NEXTHOP_DEVLOOKUP de

Re: [PATCH net-next v2 2/2] ipv6: Avoid rt6_probe() taking writer lock in the fast path

2015-07-27 Thread YOSHIFUJI Hideaki
Hi, Martin KaFai Lau wrote: > The patch checks neigh->nud_state before acquiring the writer lock. > Note that rt6_probe() is only used in CONFIG_IPV6_ROUTER_PREF. > > 40 udpflood processes and a /64 gateway route are used. > The gateway has NUD_PERMANENT. Each of them is run for 30s. > At the en

Re: [PATCH net-next v2 1/2] ipv6: Re-arrange code in rt6_probe()

2015-07-27 Thread YOSHIFUJI Hideaki/吉藤英明
Martin KaFai Lau wrote: > It is a prep work for the next patch to remove write_lock > from rt6_probe(). > > 1. Reduce the number of if(neigh) check. From 4 to 1. > 2. Bring the write_(un)lock() closer to the operations that the >lock is protecting. > > Hopefully, the above make rt6_probe() m

Re: [PATCHv2] net/ipv6: add sysctl option accept_ra_hop_limit

2015-07-27 Thread YOSHIFUJI Hideaki/吉藤英明
Hi, Hangbin Liu wrote: > Commit 6fd99094de2b ("ipv6: Don't reduce hop limit for an interface") > disabled accept hop limit from RA if it is higher than the current hop > limit for security stuff. But this behavior kind of break the RFC definition. > > RFC 4861, 6.3.4. Processing Received Router

RE: [Intel-wired-lan] [PATCH 1/2] igb: Teardown SR-IOV before unregister_netdev()

2015-07-27 Thread Williams, Mitch A
ACK > -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Alex Williamson > Sent: Monday, July 27, 2015 4:19 PM > To: intel-wired-...@lists.osuosl.org; Kirsher, Jeffrey T > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org > Su

RE: [Intel-wired-lan] [PATCH 2/2] ixgbe: Teardown SR-IOV before unregister_netdev()

2015-07-27 Thread Williams, Mitch A
ACK > -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Alex Williamson > Sent: Monday, July 27, 2015 4:19 PM > To: intel-wired-...@lists.osuosl.org; Kirsher, Jeffrey T > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org > Su

Re: kernel warning in tcp_fragment

2015-07-27 Thread Martin KaFai Lau
On Wed, Jul 22, 2015 at 11:55:35AM -0700, Jovi Zhangwei wrote: > Sorry for disturbing, our production system(3.14 and 3.18 stable > kernel) have many tcp_fragment warnings, > the trace is same as below one which you discussed before. > > https://urldefense.proofpoint.com/v1/url?u=http://comments.g

[PATCH 0/2] igb/ixgbe: Fix ordering of SR-IOV teardown

2015-07-27 Thread Alex Williamson
When running a Windows 2012 R2 guest with a pair of VFs assigned through vfio-pci, we run into a problem trying to hot-unplug those VFs after the PF has unregistered the netdev. This is a common scenario if the PF is unbound from the driver while VFs are active. In the case of igb, the resulting

[PATCH 1/2] igb: Teardown SR-IOV before unregister_netdev()

2015-07-27 Thread Alex Williamson
When the .remove() callback for a PF is called, SR-IOV support for the device is disabled, which requires unbinding and removing the VFs. The VFs may be in-use either by the host kernel or userspace, such as assigned to a VM through vfio-pci. In this latter case, the VFs may be removed either by s

[PATCH 2/2] ixgbe: Teardown SR-IOV before unregister_netdev()

2015-07-27 Thread Alex Williamson
When the .remove() callback for a PF is called, SR-IOV support for the device is disabled, which requires unbinding and removing the VFs. The VFs may be in-use either by the host kernel or userspace, such as assigned to a VM through vfio-pci. In this latter case, the VFs may be removed either by s

Re: [PATCH net v3] macvtap: fix network header pointer for VLAN tagged pkts

2015-07-27 Thread David Miller
From: Ivan Vecera Date: Thu, 23 Jul 2015 16:37:43 +0200 > Network header is set with offset ETH_HLEN but it is not true for VLAN > (multiple-)tagged and results in checksum issues in lower devices. > > v2: leave skb->protocol untouched (thx Vlad), comment added > v3: moved after skb_probe_transp

[PATCH] netfilter: ipt_SYNPROXY: fix sending window update to client

2015-07-27 Thread Phil Sutter
Upon receipt of SYNACK from the server, ipt_SYNPROXY first sends back an ACK to finish the server handshake, then calls nf_ct_seqadj_init() to initiate sequence number adjustment of forwarded packets to the client and finally sends a window update to the client to unblock it's TX queue. Since synp

[patch -master] netfilter: xt_CT: checking for IS_ERR() instead of NULL

2015-07-27 Thread Dan Carpenter
We recently changed this from nf_conntrack_alloc() to nf_ct_tmpl_alloc() so the error handling needs to changed to check for NULL instead of IS_ERR(). Fixes: 0838aa7fcfcd ('netfilter: fix netns dependencies with conntrack templates') Signed-off-by: Dan Carpenter diff --git a/net/netfilter/xt_CT

Re: [PATCH] packet: Allow packets with only a header (but no payload)

2015-07-27 Thread Martin Blumenstingl
Hi Johann, On Tue, Jul 21, 2015 at 6:51 PM, Willem de Bruijn wrote: > I don't see a simple way of verifying the safety of allowing packets > without data short of a code audit, which would be huge, especially > when taking device driver logic into account. Perhaps someone > remembers why that sta

[patch] packet: missing dev_put() in packet_do_bind()

2015-07-27 Thread Dan Carpenter
From: Lars Westerhoff When binding a PF_PACKET socket, the use count of the bound interface is always increased with dev_hold in dev_get_by_{index,name}. However, when rebound with the same protocol and device as in the previous bind the use count of the interface was not decreased. Ultimately,

ip6t_SYNPROXY crashes kernel

2015-07-27 Thread Phil Sutter
Hi, When synproxy_send_server_ack() calls synproxy_send_tcp(), it passes NULL as third parameter (struct nf_conntrack *nfct). And the first thing synproxy_send_tcp() does, is dereference it: | struct net *net = nf_ct_net((struct nf_conn *)nfct); I could not find a commit leading to this breakage

Re: [PATCH net-next 0/4] net/mlx4_en: Hardware accelerated 802.1ad

2015-07-27 Thread David Miller
From: Amir Vadai Date: Mon, 27 Jul 2015 14:46:30 +0300 > This patchset by Hadar introduces support in Hardware accelerated 802.1ad, for > ConnectX-3pro NIC's. In order to support existing deployment, and due to some > hardware limitations, the feature is disabled by default, and needed to be > e

Re: [PATCH V3 net-next 0/3] ARM BPF JIT features

2015-07-27 Thread David Miller
From: Nicolas Schichan Date: Mon, 27 Jul 2015 15:06:48 +0200 > This series adds support for more instructions to the ARM BPF JIT > namely skb netdevice type retrieval, skb payload offset retrieval, and > skb packet type retrieval. > > This allows 35 tests to use the JIT instead of 29 before. >

Re: [net PATCH] fib_trie: Drop unnecessary calls to leaf_pull_suffix

2015-07-27 Thread David Miller
From: Alexander Duyck Date: Mon, 27 Jul 2015 13:08:06 -0700 > It was reported that update_suffix was taking a long time on systems where > a large number of leaves were attached to a single node. As it turns out > fib_table_flush was calling update_suffix for each leaf that didn't have all > of

Re: [PATCH] phylib: add driver for aquantia phy

2015-07-27 Thread Florian Fainelli
On 27/07/15 01:30, Shaohui Xie wrote: >> -Original Message- >> From: Florian Fainelli [mailto:f.faine...@gmail.com] >> Sent: Friday, July 24, 2015 12:39 PM >> To: shh@gmail.com; netdev@vger.kernel.org; da...@davemloft.net >> Cc: Xie Shaohui-B21989 >> Subject: Re: [PATCH] phylib: add dri

Re: [PATCH iproute2 net-next] bridge: mdb: add support for router add/del notifications monitoring

2015-07-27 Thread Nikolay Aleksandrov
> On 27 Jul 2015, at 23:40, Stephen Hemminger > wrote: > > On Mon, 27 Jul 2015 13:44:05 +0200 > Nikolay Aleksandrov wrote: > >> From: Nikolay Aleksandrov >> >> This patch adds support for ADDMDB/DELMDB notifications about router ports >> which have been added or deleted/expired respectively

Re: [PATCH iproute2 net-next] bridge: mdb: add support for router add/del notifications monitoring

2015-07-27 Thread Stephen Hemminger
On Mon, 27 Jul 2015 13:44:05 +0200 Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > This patch adds support for ADDMDB/DELMDB notifications about router ports > which have been added or deleted/expired respectively. > > Example output: > $ bridge -s monitor mdb > Deleted router port

Re: [PATCH 1/2] iproute2: Add support for IPv6 VTI tunnels to ip6tunnel

2015-07-27 Thread Stephen Hemminger
On Thu, 2 Oct 2014 11:11:40 +0200 Jiri Pirko wrote: > Thu, Oct 02, 2014 at 10:48:20AM CEST, steffen.klass...@secunet.com wrote: > >On Thu, Oct 02, 2014 at 10:41:09AM +0200, Jiri Pirko wrote: > >> Fri, Sep 26, 2014 at 09:10:56AM CEST, steffen.klass...@secunet.com wrote: > >> > > >> >@@ -459,11 +46

Re: [PATCH iproute2] xfrm: remove duplicated include

2015-07-27 Thread Stephen Hemminger
On Sat, 25 Jul 2015 04:44:24 -0400 Zhang Shengju wrote: > Remove dupldated include for , since it's already > included by 'xfrm.h'. > > Signed-off-by: Zhang Shengju Applied, thanks -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.

Re: [PATCH iproute2] tc: fix bpf compilation with old glibc

2015-07-27 Thread Stephen Hemminger
On Wed, 22 Jul 2015 14:29:30 +0200 Nicolas Dichtel wrote: > Error was: > f_bpf.o: In function `bpf_parse_opt': > f_bpf.c:(.text+0x88f): undefined reference to `secure_getenv' > m_bpf.o: In function `parse_bpf': > m_bpf.c:(.text+0x587): undefined reference to `secure_getenv' > collect2: error: ld

Re: Fw: [Bug 102051] New: Unexpected TCP behavior

2015-07-27 Thread Eric Dumazet
On Mon, 2015-07-27 at 14:02 -0700, Stephen Hemminger wrote: > > Begin forwarded message: > > Date: Mon, 27 Jul 2015 20:06:07 + > From: "bugzilla-dae...@bugzilla.kernel.org" > > To: "shemmin...@linux-foundation.org" > Subject: [Bug 102051] New: Unexpected TCP behavior > > > https://bugzil

Re: [net:master 41/49] drivers/net/ethernet/cadence/macb.c:164:1: error: macro "writel" passed 3 arguments, but takes just 2

2015-07-27 Thread David Miller
From: Andy Shevchenko Date: Mon, 27 Jul 2015 14:07:53 +0300 > I do use compiler from Debian for AVR32, didn't check this on other > architectures. > > Possible something like following will fix it: That isn't going to fix it. You misunderstand the nature of the problem I think, the issue looks

Re: [patch net-next 0/4] Introduce Mellanox Technologies Switch ASICs switchdev drivers

2015-07-27 Thread Florian Fainelli
On 27/07/15 13:27, Jiri Pirko wrote: > Mon, Jul 27, 2015 at 10:21:54PM CEST, sfel...@gmail.com wrote: >> On Thu, Jul 23, 2015 at 8:43 AM, Jiri Pirko wrote: >>> This patchset introduces Mellanox Technologies Switch driver infrastructure >>> and support for SwitchX-2 ASIC. >> >> You guys did a great

Re: [net-next PATCH 2/2] drivers: net: cpsw: add separate napi for tx packet handling for performance improvment

2015-07-27 Thread Francois Romieu
Mugunthan V N : [...] > diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c > index d68d759..4f98537 100644 > --- a/drivers/net/ethernet/ti/cpsw.c > +++ b/drivers/net/ethernet/ti/cpsw.c > @@ -752,13 +753,22 @@ static irqreturn_t cpsw_tx_interrupt(int irq, void > *dev_id)

Re: [RFC PATCH 4/4] vhost: Add cgroup-aware creation of worker threads

2015-07-27 Thread Michael S. Tsirkin
On Mon, Jul 13, 2015 at 12:07:35AM -0400, Bandan Das wrote: > With the help of the cgroup function to compare groups introduced > in the previous patch, this changes worker creation policy. > If the new device belongs to different cgroups than any of the > devices we are currently serving, we end u

Re: [PATCH iproute2] ip: replace white-spaces with tabs

2015-07-27 Thread Stephen Hemminger
On Sat, 25 Jul 2015 08:54:53 -0400 Zhang Shengju wrote: > Replace white-spaces with tabs > > Signed-off-by: Zhang Shengju > --- > ip/ip.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > There were more places that needed this, went ahead and made ip.c and bridge.c checkpatch

Re: [RFC PATCH 0/4] Shared vhost design

2015-07-27 Thread Michael S. Tsirkin
On Mon, Jul 27, 2015 at 03:48:19PM -0400, Bandan Das wrote: > Eyal Moscovici writes: > > > Hi, > > > > The test showed the same relative numbers as we got in our internal > > testing. I was wondering about the configuration in regards to NUMA. From > Thanks for confirming. > > > our testing we

Re: [RFC PATCH 0/4] Shared vhost design

2015-07-27 Thread Michael S. Tsirkin
On Mon, Jul 13, 2015 at 12:07:31AM -0400, Bandan Das wrote: > Hello, > > There have been discussions on improving the current vhost design. The first > attempt, to my knowledge was Shirley Ma's patch to create a dedicated vhost > worker per cgroup. > > http://comments.gmane.org/gmane.linux.networ

Re: [net PATCH] fib_trie: Drop unnecessary calls to leaf_pull_suffix

2015-07-27 Thread David Ahern
On 7/27/15 2:08 PM, Alexander Duyck wrote: It was reported that update_suffix was taking a long time on systems where a large number of leaves were attached to a single node. As it turns out fib_table_flush was calling update_suffix for each leaf that didn't have all of the aliases stripped from

Fw: [Bug 102051] New: Unexpected TCP behavior

2015-07-27 Thread Stephen Hemminger
Begin forwarded message: Date: Mon, 27 Jul 2015 20:06:07 + From: "bugzilla-dae...@bugzilla.kernel.org" To: "shemmin...@linux-foundation.org" Subject: [Bug 102051] New: Unexpected TCP behavior https://bugzilla.kernel.org/show_bug.cgi?id=102051 Bug ID: 102051 Summa

Re: [PATCH net-next]r8169: Correct values on dma_alloc_coherent

2015-07-27 Thread Francois Romieu
Corcodel Marian : [...] > diff --git a/drivers/net/ethernet/realtek/r8169.c > b/drivers/net/ethernet/realtek/r8169.c > index 3df51fa..fd249a6 100644 > --- a/drivers/net/ethernet/realtek/r8169.c > +++ b/drivers/net/ethernet/realtek/r8169.c > @@ -6724,8 +6724,8 @@ static int rtl8169_init_ring(struc

Re: [PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-27 Thread Eric W. Biederman
David Ahern writes: > Allow tasks to have a default device index for binding sockets. If set > the value is passed to all AF_INET/AF_INET6 sockets when they are > created. > > The task setting is passed parent to child on fork, but can be set or > changed after task creation using prctl (if task

Re: [net-next 0/16] Proposal for VRF-lite - v3

2015-07-27 Thread Eric W. Biederman
David Ahern writes: > In the context of internet scale routing a requirement that always comes > up is the need to partition the available routing tables into disjoint > routing planes. A specific use case is the multi-tenancy problem where > each tenant has their own unique routing tables and in

Re: [patch net-next 0/4] Introduce Mellanox Technologies Switch ASICs switchdev drivers

2015-07-27 Thread Jiri Pirko
Mon, Jul 27, 2015 at 10:21:54PM CEST, sfel...@gmail.com wrote: >On Thu, Jul 23, 2015 at 8:43 AM, Jiri Pirko wrote: >> This patchset introduces Mellanox Technologies Switch driver infrastructure >> and support for SwitchX-2 ASIC. > >You guys did a great job on the driver; looking forward to seeing

Re: [patch net-next 0/4] Introduce Mellanox Technologies Switch ASICs switchdev drivers

2015-07-27 Thread Scott Feldman
On Thu, Jul 23, 2015 at 8:43 AM, Jiri Pirko wrote: > This patchset introduces Mellanox Technologies Switch driver infrastructure > and support for SwitchX-2 ASIC. You guys did a great job on the driver; looking forward to seeing L2/L3 hooked up. Very nice, aesthetically pleasing code. Is this a

[net PATCH] fib_trie: Drop unnecessary calls to leaf_pull_suffix

2015-07-27 Thread Alexander Duyck
It was reported that update_suffix was taking a long time on systems where a large number of leaves were attached to a single node. As it turns out fib_table_flush was calling update_suffix for each leaf that didn't have all of the aliases stripped from it. As a result, on this large node removin

Re: [PATCH net-next] route: allow to route in a peer netns via lwt framework

2015-07-27 Thread Nicolas Dichtel
Le 24/07/2015 17:19, David Ahern a écrit : In this case you are knowingly dropping packets. Would be nice to have a counter showing that. Ok. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://

Re: [PATCH net-next 13/16] net: Introduce VRF device driver - v2

2015-07-27 Thread Nikolay Aleksandrov
On 07/27/2015 08:31 PM, David Ahern wrote: > This driver borrows heavily from IPvlan and teaming drivers. > > Routing domains (VRF-lite) are created by instantiating a VRF master > device with an associated table and enslaving all routed interfaces that > participate in the domain. As part of the

[PATCH net-next 1/1] Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver

2015-07-27 Thread Woojung.Huh
This patch adds a driver for LAN7800 family of USB 2.0 & USB 3.0 to Gigabit Ethernet. - remove module param which can be configurable by standard mechanism. - remove other module parms except msg_level per review comment. Signed-off-by: Woojung Huh --- drivers/net/usb/Kconfig | 10 + driver

Re: [PATCH net-next v2] route: allow to route in a peer netns via lwt framework

2015-07-27 Thread Nicolas Dichtel
Le 24/07/2015 17:39, Eric Dumazet a écrit : On Fri, 2015-07-24 at 16:16 +0200, Nicolas Dichtel wrote: This patch takes advantage of the newly added lwtunnel framework to allow the user to set routes that point to a peer netns. Packets are injected to the peer netns via the loopback device. It

Re: [RFC PATCH 0/4] Shared vhost design

2015-07-27 Thread Bandan Das
Eyal Moscovici writes: > Hi, > > The test showed the same relative numbers as we got in our internal > testing. I was wondering about the configuration in regards to NUMA. From Thanks for confirming. > our testing we saw that if the VMs are spread across 2 NUMA nodes then > having a shared vh

Re: [RFC PATCH v4 net-next 1/4] tcp: replace cnt & rtt with struct in pkts_acked()

2015-07-27 Thread Lawrence Brakmo
On 7/27/15, 11:46 AM, "Stephen Hemminger" wrote: >On Fri, 24 Jul 2015 19:47:03 -0700 >Lawrence Brakmo wrote: > >> Replace 2 arguments (cnt and rtt) in the congestion control modules' >> pkts_acked() function with a struct. This will allow adding more >> information without having to modify exi

Re: kernel warning in tcp_fragment

2015-07-27 Thread Jovi Zhangwei
ping... On Wed, Jul 22, 2015 at 11:55 AM, Jovi Zhangwei wrote: > Hi Neal and Martin, > > Sorry for disturbing, our production system(3.14 and 3.18 stable > kernel) have many tcp_fragment warnings, > the trace is same as below one which you discussed before. > > http://comments.gmane.org/gmane.lin

Re: [PATCH net-next 3/3] openvswitch: 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-07-27 Thread Pravin Shelar
On Sun, Jul 26, 2015 at 7:52 AM, Thomas F Herbert wrote: > Add support for 802.1ad including the ability to push and pop double > tagged vlans. Add support for 802.1ad to netlink parsing and flow > conversion. Uses double nested encap attributes to represent double > tagged vlan. Inner TPID encode

Re: [PATCH 02/10] dpaa_eth: add support for DPAA Ethernet

2015-07-27 Thread Scott Wood
On Fri, 2015-07-24 at 10:45 -0500, Bucur Madalin-Cristian-B32716 wrote: > > -Original Message- > > From: Joe Perches [mailto:j...@perches.com] > > On Wed, 2015-07-22 at 19:16 +0300, Madalin Bucur wrote: > > > +static int __init dpa_load(void) > > > +{ > > [] > > > + err = platform_driver_re

Re: netns refcnt leak for kernel accept sock

2015-07-27 Thread Sowmini Varadhan
On (07/27/15 11:37), Cong Wang wrote: > > dlm uses a kernel TCP socket too, but it allocates a new socket and calls > ->accept() by itself. ;) sure, and rds does this in rds_tcp_accept_one() too. But the newsk being created in sk_clone_lock is the one on an incoming syn, i.e., the one that is

Re: [RFC PATCH v4 net-next 1/4] tcp: replace cnt & rtt with struct in pkts_acked()

2015-07-27 Thread Stephen Hemminger
On Fri, 24 Jul 2015 19:47:03 -0700 Lawrence Brakmo wrote: > Replace 2 arguments (cnt and rtt) in the congestion control modules' > pkts_acked() function with a struct. This will allow adding more > information without having to modify existing congestion control > modules (tcp_nv in particular ne

Re: netns refcnt leak for kernel accept sock

2015-07-27 Thread Cong Wang
On Mon, Jul 27, 2015 at 11:19 AM, Sowmini Varadhan wrote: > On (07/27/15 11:13), Cong Wang wrote: >> >> That refcnt should be released in sock destructor too, when the tcp >> connection is terminated. > > yes, but in my case, the listen socket is opened as part of > the ->init indirection in perne

Re: [PATCH 8/8] can: replace timestamp as unique skb attribute

2015-07-27 Thread Oliver Hartkopp
Hello Greg, On 12.07.2015 21:18, Marc Kleine-Budde wrote: From: Oliver Hartkopp Commit 514ac99c64b "can: fix multiple delivery of a single CAN frame for overlapping CAN filters" requires the skb->tstamp to be set to check for identical CAN skbs. Without timestamping to be required by user spa

[PATCH net-next 05/16] net: Use VRF device index for lookups on TX

2015-07-27 Thread David Ahern
As with ingress use the index of VRF master device for route lookups on egress. However, the oif should only be used to direct the lookups to a specific table. Routes in the table are not based on the VRF device but rather interfaces that are part of the VRF so do not consider the oif for lookups w

[PATCH] iproute2: Add support for VRF device

2015-07-27 Thread David Ahern
Allow user to create a vrf device and specify its table binding. Based on the iplink_vlan implementation. Signed-off-by: Shrijeet Mukherjee Signed-off-by: David Ahern --- include/linux/if_link.h | 8 + ip/Makefile | 2 +- ip/iplink.c | 2 +- ip/iplink_vrf.c

[PATCH net-next 06/16] net: Tx via VRF device

2015-07-27 Thread David Ahern
If out device is enslaved to a VRF device we want packets to go through the VRF master device first. This allows for example iptables rules and tc rules to be configured on the VRF as a whole as well as the option for rules on specific netdevices. This is accomplished by updating the dev in the dst

[PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-27 Thread David Ahern
Allow tasks to have a default device index for binding sockets. If set the value is passed to all AF_INET/AF_INET6 sockets when they are created. The task setting is passed parent to child on fork, but can be set or changed after task creation using prctl (if task has CAP_NET_ADMIN permissions). T

[PATCH net-next 13/16] net: Introduce VRF device driver - v2

2015-07-27 Thread David Ahern
This driver borrows heavily from IPvlan and teaming drivers. Routing domains (VRF-lite) are created by instantiating a VRF master device with an associated table and enslaving all routed interfaces that participate in the domain. As part of the enslavement, all connected routes for the enslaved de

[PATCH net-next 09/16] net: Add routes to the table associated with the device

2015-07-27 Thread David Ahern
When a device associated with a VRF is brought up or down routes should be added to/removed from the table associated with the VRF. fib_magic defaults to using the main or local tables. Have it use the table with the device if there is one. A part of this is directing prefsrc validations to the co

[PATCH net-next 07/16] net: Add inet_addr lookup by table

2015-07-27 Thread David Ahern
Currently inet_addr_type and inet_dev_addr_type expect local addresses to be in the local table. With the VRF device local routes for devices associated with a VRF will be in the table associated with the VRF. Provide an alternate inet_addr lookup to use a specific table rather than defaulting to t

[PATCH net-next 12/16] net: Add ipv4 route helper to set next hop

2015-07-27 Thread David Ahern
Signed-off-by: David Ahern --- include/net/route.h | 3 +++ net/ipv4/route.c| 10 ++ 2 files changed, 13 insertions(+) diff --git a/include/net/route.h b/include/net/route.h index b14cbec93fbd..900d50fbcfc7 100644 --- a/include/net/route.h +++ b/include/net/route.h @@ -107,6 +107,7

[PATCH net-next 11/16] net: Use VRF device index for socket lookups

2015-07-27 Thread David Ahern
The intent of the VRF device is to leverage the existing SO_BINDTODEVICE as a means of creating L3 domains. Since sockets are expected to be bound to the VRF device the index of the master device needs to be used for socket lookups. Signed-off-by: Shrijeet Mukherjee Signed-off-by: David Ahern --

[PATCH net-next 15/16] net: Add chvrf command

2015-07-27 Thread David Ahern
Example of how to use the default bind to interface option for tasks and correlate with VRF devices. Signed-off-by: David Ahern --- tools/net/Makefile | 6 +- tools/net/chvrf.c | 225 + 2 files changed, 229 insertions(+), 2 deletions(-) cre

[PATCH net-next 08/16] net: Fix up inet_addr_type checks

2015-07-27 Thread David Ahern
Currently inet_addr_type and inet_dev_addr_type expect local addresses to be in the local table. With the VRF device local routes for devices associated with a VRF will be in the table associated with the VRF. Provide an alternate inet_addr lookup to use a specific table rather than defaulting to t

[PATCH net-next 04/16] net: Use VRF device index for lookups on RX

2015-07-27 Thread David Ahern
On ingress use index of VRF master device for route lookups if real device is enslaved. Rules are expected to be installed for the VRF device to direct lookups to a specific table. Signed-off-by: Shrijeet Mukherjee Signed-off-by: David Ahern --- net/ipv4/fib_frontend.c | 8 +++- net/ipv4/ro

[PATCH net-next 02/16] net: export a few FIB functions

2015-07-27 Thread David Ahern
Required by the VRF driver. Signed-off-by: Shrijeet Mukherjee Signed-off-by: David Ahern --- net/ipv4/fib_frontend.c | 2 ++ net/ipv4/fib_trie.c | 1 + 2 files changed, 3 insertions(+) diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c index 6b98de0d7949..c565fc182240 100644 --

[PATCH net-next 03/16] net: Introduce VRF related flags and helpers

2015-07-27 Thread David Ahern
Add a VRF_MASTER flag for interfaces and helper functions for determining if a device is a VRF_MASTER. Add link attribute for passing VRF_TABLE id. Add vrf_ptr to netdevice. Add various macros for determining if a device is a VRF device, the index of the master VRF device and table associated wi

[PATCH net-next 01/16] net: Refactor rtable allocation and initialization

2015-07-27 Thread David Ahern
All callers to rt_dst_alloc have nearly the same initialization following a successful allocation. Consolidate it into ip_route_new_rtable. Signed-off-by: David Ahern --- include/net/route.h | 3 ++ net/ipv4/route.c| 111 +++- 2 files changed

[net-next 0/16] Proposal for VRF-lite - v3

2015-07-27 Thread David Ahern
In the context of internet scale routing a requirement that always comes up is the need to partition the available routing tables into disjoint routing planes. A specific use case is the multi-tenancy problem where each tenant has their own unique routing tables and in the very least need different

  1   2   >