Hi Nicolas, > -----Original Message----- > From: Nicolas Ferre [mailto:nicolas.fe...@atmel.com] > Sent: Monday, July 27, 2015 1:07 PM > To: Michal Simek; Punnaiah Choudary Kalluri; Anirudha Sarangi; > da...@davemloft.net; Florian Fainelli; and...@lunn.ch > Cc: Harini Katakam; kpc...@gmail.com; > kalluripunnaiahchoud...@gmail.com; netdev@vger.kernel.org; Punnaiah > Choudary Kalluri > Subject: Re: [RFC PATCH 0/2] net: macb: Add mdio driver for accessing > multiple phy devices > > Le 20/07/2015 15:30, Michal Simek a écrit : > > Hi Nicolas, > > > > have you had a time to look at this? > > Michal, > > Sorry for the delay. > > With the insight of Florian and Andrew, I do agree to move to your > "Implementation 1" and a separate driver for mdio bus. > > The only thing that worries me it that the architecture AVR32 which we > are sharing this driver with doesn't have support for device tree (and > may never have). So, it would be good to make sure to keep compatibility > with it. > > Another point to take into account is the transition period: we have > several SoC .dtsi/dts that will need to be converted and we'll need to > add this mdio support before that it's integrated in netdev: we have to > think about it in advance.
Ok. I will send you updated patch for mdio support soon and we will finalize next Course of actions if it doesn't break the existing flow. Thanks, Punnaiah > > Thanks, bye. > > > > On 07/13/2015 06:48 AM, Punnaiah Choudary Kalluri wrote: > >> This patch is to add support for the design that has multiple ethernet > >> mac controllers and single mdio bus connected to multiple phy devices. > >> i.e mdio lines are connected to any of the ethernet mac controller and > >> all the phy devices will be accessed using the phy maintenance interface > >> in that mac controller. > >> > >> ______ _____ > >> | | |PHY0 | > >> | MAC0 |-----------------| | > >> |______| | |_____| > >> | > >> ______ | _____ > >> | | | | | > >> | MAC1 | |_________|PHY1 | > >> |______| |____ | > >> > >> So, i come up with two implementations for addressing the above > configuration. > >> > >> Implementation 1: > >> Have separate driver for mdio bus > >> Create a DT node for all the PHY devices connected to the mdio bus > >> This driver will share the register space of the mac controller that has > >> mdio bus connected. > >> > >> Implementation 2: > >> Add new property "has-mdio" and it should be 1 for the mac that has > mdio bus > >> connected. > >> Create the mdio bus only when the has-mdio property is 1 > >> > >> Please review the two implementations and suggest which one is better > to proceed > >> further. In my opinion implementation 1 will be the ideal one. > >> > >> Currently i have tested the patches with single mac and single phy > >> configuration. I need to take care of few more cases before releasing the > final patch > >> but before that i would like to have your opinion on the above > implementations > >> and finalize one implementation. so that i can enhance it further. > >> > >> Punnaiah Choudary Kalluri (1): > >> net: macb: Add mdio driver for accessing multiple phy devices > >> net: macb: Add support for single mac managing more than one phy > >> > >> > >> drivers/net/ethernet/cadence/Makefile | 2 +- > >> drivers/net/ethernet/cadence/macb.c | 93 +------------- > >> drivers/net/ethernet/cadence/macb.h | 3 +- > >> drivers/net/ethernet/cadence/macb_mdio.c | 204 > ++++++++++++++++++++++++++++++ > >> 4 files changed, 211 insertions(+), 91 deletions(-) > >> create mode 100644 drivers/net/ethernet/cadence/macb_mdio.c > >> > > > > > > > > > -- > Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
