Re: [PATCH/RFC net-next] rocker: forward packets to CPU when a port in promiscuous mode

On Wed, Jul 8, 2015 at 9:25 PM, Simon Horman wrote: > This change allows the CPU to see all packets seen by a port when the > netdev associated with the port is in promiscuous mode. > > This change was previously posted as part of a larger patch and in turn > patchset which also aimed to allow roc

Re: [Patch net] fq_codel: fix a use-after-free

On Mon, 2015-07-13 at 12:30 -0700, Cong Wang wrote: > Fixes: 25331d6ce42b ("net: sched: implement qstat helper routines") > Cc: John Fastabend > Signed-off-by: Cong Wang > Signed-off-by: Cong Wang > --- > net/sched/sch_fq_codel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: net: Fix skb csum races when peeking

On Mon, 2015-07-13 at 20:01 +0800, Herbert Xu wrote: > ---8<--- > When we calculate the checksum on the recv path, we store the > result in the skb as an optimisation in case we need the checksum > again down the line. > > This is in fact bogus for the MSG_PEEK case as this is done without > any

Re: linux-4.2-rc2/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1993: possible bad error checking ?

Hello David thx to have looked at this. I'll check the code and eventually fix it, unless you already have a patch to propose. Kind Regards Peppe On 7/13/2015 11:48 AM, David Binderman wrote: Hello there, [linux-4.2-rc2/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1993]: (style) Check

[PATCH net] ipv6: lock socket in ip6_datagram_connect()

From: Eric Dumazet ip6_datagram_connect() is doing a lot of socket changes without socket being locked. This looks wrong, at least for udp_lib_rehash() which could corrupt lists because of concurrent udp_sk(sk)->udp_portaddr_hash accesses. Signed-off-by: Eric Dumazet --- include/net/ip.h|

Re: [rhashtable] WARNING: CPU: 0 PID: 1 at lib/debugobjects.c:301 __debug_object_init()

99d6a06e4c4b1 # 10:25 0- > 66 rhashtable: Per bucket locks & deferred expansion/shrinking > # extra tests on HEAD of linux-devel/devel-spot-201507122014 > git bisect good 3afd2c3f65a385c405a084d80431c84b103cb6df # 10:28 66+ > 49 0day head guard for 'd

[rhashtable] WARNING: CPU: 0 PID: 1 at lib/debugobjects.c:301 __debug_object_init()

pub/scm/linux/kernel/git/davem/net # extra tests on tree/branch next/master git bisect good 2eb62d762a2112579f259903e62ba18d16c51f66 # 10:36 66+ 20 Add linux-next specific files for 20150713 This script may reproduce the error.

Re: mmap()ed AF_NETLINK: lockdep and sleep-in-atomic warnings

On Mon, Jul 13, 2015 at 6:18 AM, Kirill A. Shutemov wrote: > Hi, > > This simple test-case trigers few locking asserts in kernel: > > #define _GNU_SOURCE > #include > #include > #include > #include > #include > #include > #include > > #define SOL_NETLINK 270 > > int main(int argc, char **ar

Re: [PATCH 4/6] net: ieee802154: Remove redundant spi driver bus initialization

Hi Antonio, > In ancient times it was necessary to manually initialize the bus > field of an spi_driver to spi_bus_type. These days this is done in > spi_register_driver(), so we can drop the manual assignment. > > Signed-off-by: Antonio Borneo > To: Alan Ott > To: Alexander Aring > To: Varka

[PATCH] e1000e: Move e1000e_disable_aspm_locked() inside CONFIG_PM

e1000e_disable_aspm_locked() is only used in __e1000_resume() which is inside CONFIG_PM. So when CONFIG_PM=n we get a "defined but not used" warning for e1000e_disable_aspm_locked(). Move it inside the existing CONFIG_PM block to avoid the warning. Signed-off-by: Michael Ellerman --- drivers/ne

Re: [PATCH net] bridge: mdb: fix double add notification

On Mon, Jul 13, 2015 at 6:36 AM, Nikolay Aleksandrov wrote: > Since the mdb add/del code was introduced there have been 2 br_mdb_notify > calls when doing br_mdb_add() resulting in 2 notifications on each add. > > Example: > Command: bridge mdb add dev br0 port eth1 grp 239.0.0.1 permanent > Bef

Re: [RFC PATCH 0/2] net: macb: Add mdio driver for accessing multiple phy devices

On Tue, Jul 14, 2015 at 12:13 AM, Florian Fainelli wrote: > On 12/07/15 21:48, Punnaiah Choudary Kalluri wrote: >> This patch is to add support for the design that has multiple ethernet >> mac controllers and single mdio bus connected to multiple phy devices. >> i.e mdio lines are connected to any

RE: [PATCH v3] Add support for driver cross-timestamp to PTP_SYS_OFFSET ioctl

I am assuming the patch is rejected at this point. I will re-submit later as soon as I am able to post a full end to end solution. Chris > -Original Message- > From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: Thursday, July 09, 2015 7:58 AM > To: Hall, Christopher S > Cc:

linux-next: manual merge of the net-next tree with Linus' tree

Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/bridge/br_mdb.c between commit: f1158b74e54f ("bridge: mdb: zero out the local br_ip variable before use") from Linus' tree and commit: 74fe61f17e99 ("bridge: mdb: add vlan support for user entries") from the

Re: [PATCH net-next v5 1/4] net core: Add protodown support.

On Mon, Jul 13, 2015 at 2:34 PM, David Miller wrote: > From: anurad...@cumulusnetworks.com > Date: Thu, 9 Jul 2015 15:35:27 -0700 > >> +/* proto_flags - port state information can be passed to the switch driver >> and >> + * used to determine the phys state of the switch port */ >> +enum { >> +

[PATCH net-next 3/3] rhashtable: Add scored lookups

This patch adds a mechanism to do scored lookups in an rhashtable. This mechanism is based on the UDP and TCP listener socket lookup functions. When a bucket is traversed, a matching score is computed for each entry and the input key. The entry with the highest non-zero score is returned, and if t

[PATCH net-next 0/3] rhashtable: Wildcard and scored lookups

This patch set implements: - A compare function can be passed in the lookup. This allows for comparison to include "wildcard fields" - Order insertion within a bucket, so that entries with more specific information can be matched first. - Scored lookups. This is like the socket lookup

[PATCH net-next 2/3] rhashtable: allow lookup function to have compare function agument

Added rhashtable_lookup_fast_cmpfn which does a lookup in an rhash table with the compare function being taken from an argument. This allows different compare functions to be used on the same table. Signed-off-by: Tom Herbert --- include/linux/rhashtable.h | 17 + 1 file changed,

[PATCH net-next 1/3] rhashtable: Add a function for in order insertion in buckets

The obj_orderfn function may be specified in the parameters for a rhashtable. When inserting an element this function is used to order objects in a bucket list (greatest to least ordering value).This allows entries to have wild card fields, where entries with more specific information match are pla

Re: [PATCH 1/2] isdn/gigaset: reset tty->receive_room when attaching ser_gigaset

Am 14.07.2015 um 01:14 schrieb Peter Hurley: > On 07/13/2015 06:37 PM, Tilman Schmidt wrote: >> Commit 79901317ce80 ("n_tty: Don't flush buffer when closing ldisc"), >> first merged in kernel release 3.10, caused the following regression >> in the Gigaset M101 driver: >> >> Before that commit, when

[PATCH 1/2] isdn/gigaset: reset tty->receive_room when attaching ser_gigaset

Commit 79901317ce80 ("n_tty: Don't flush buffer when closing ldisc"), first merged in kernel release 3.10, caused the following regression in the Gigaset M101 driver: Before that commit, when closing the N_TTY line discipline in preparation to switching to N_GIGASET_M101, receive_room would be res

[PATCH 2/2] isdn/gigaset: drop unused ldisc methods

The line discipline read and write methods are optional so the dummy methods in ser_gigaset are unnecessary and can be removed. Signed-off-by: Tilman Schmidt --- drivers/isdn/gigaset/ser-gigaset.c | 24 1 files changed, 0 insertions(+), 24 deletions(-) diff --git a/dr

[PATCH 0/2] Fix long-standing regression in ser_gigaset ISDN driver

This series fixes a serious regression in the Gigaset M101 driver introduced in kernel release 3.10 and removes some unneeded code. Please also queue up patch 1 of the series for inclusion in the stable/longterm releases 3.10 and later. Tilman Schmidt (2): isdn/gigaset: reset tty->receive_room

Re: [PATCH 1/2] isdn/gigaset: reset tty->receive_room when attaching ser_gigaset

On 07/13/2015 06:37 PM, Tilman Schmidt wrote: > Commit 79901317ce80 ("n_tty: Don't flush buffer when closing ldisc"), > first merged in kernel release 3.10, caused the following regression > in the Gigaset M101 driver: > > Before that commit, when closing the N_TTY line discipline in > preparation

Re: [RFC net-next 18/22] openvswitch: Make tunnel set action attach a metadata dst

Hi Thomas, On 10 July 2015 at 07:19, Thomas Graf wrote: > diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c > index ecfa530..05fe46b 100644 > --- a/net/openvswitch/flow_netlink.c > +++ b/net/openvswitch/flow_netlink.c > @@ -1548,11 +1548,45 @@ static struct sw_flow_acti

Re: [PATCH net-next] tc: fix tc actions in case of shared skb

On 7/13/15 1:55 PM, Daniel Borkmann wrote: On 07/13/2015 10:17 PM, Alexei Starovoitov wrote: ... We cannot check tc actions from pktgen, since they can be added dynamically. So I see three options: 1 get rid of burst hack for both RX and TX in pktgen (kills performance) 2 add unlikely(skb_shread

[PATCH] pkt_sched: sch_qfq: remove unused member of struct qfq_sched

The member (u32) "num_active_agg" of struct qfq_sched has been unused since its introduction in 462dbc9101acd38e92eda93c0726857517a24bbd "pkt_sched: QFQ Plus: fair-queueing service at DRR cost" and (AFAICT) there is no active plan to use it; this removes the member. Signed-off-by: Andrea Parri Ac

[PATCH] rfkill-gpio: Add support for the Realtek 8723 BT

http://thread.gmane.org/gmane.linux.kernel.wireless.general/127706/focu s=127896 Signed-off-by: Bastien Nocera --- net/rfkill/rfkill-gpio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c index d5d58d9..9471024 100644 --- a/net/rfkill/rfki

Re: [PATCH net-next] bridge: mdb: add vlan support for user entries

From: Nikolay Aleksandrov Date: Fri, 10 Jul 2015 08:02:08 -0700 > Until now all user mdb entries were added in vlan 0, this patch adds > support to allow the user to specify the vlan for the entry. > About the uapi change a hole in struct br_mdb_entry is used so the size > and offsets are kept th

Re: [PATCH net-next v5 1/4] net core: Add protodown support.

From: anurad...@cumulusnetworks.com Date: Thu, 9 Jul 2015 15:35:27 -0700 > +/* proto_flags - port state information can be passed to the switch driver > and > + * used to determine the phys state of the switch port */ > +enum { > + IF_PROTOF_DOWN = 1<<0 /* set switch port phys stat

Re: [PATCH] net/bonding: Add function bond_remove_proc_entry at __bond_release_one

On 07/13/2015 11:05 PM, Nikolay Aleksandrov wrote: > On 07/13/2015 08:57 PM, cls...@linux.vnet.ibm.com wrote: >> From: Carol L Soto >> >> Add function bond_remove_proc_entry at __bond_release_one to avoid stack >> trace at rmmod bonding. >> >> [68830.202239] remove_proc_entry: removing non-empty

Re: [PATCH] net/bonding: Add function bond_remove_proc_entry at __bond_release_one

On 07/13/2015 08:57 PM, cls...@linux.vnet.ibm.com wrote: > From: Carol L Soto > > Add function bond_remove_proc_entry at __bond_release_one to avoid stack > trace at rmmod bonding. > > [68830.202239] remove_proc_entry: removing non-empty directory > 'net/bonding', leaking at least 'bond0' > [68

Re: [PATCH net-next] tc: fix tc actions in case of shared skb

On 07/13/2015 10:17 PM, Alexei Starovoitov wrote: ... We cannot check tc actions from pktgen, since they can be added dynamically. So I see three options: 1 get rid of burst hack for both RX and TX in pktgen (kills performance) 2 add unlikely(skb_shread) check to few tc actions 3 do nothing I th

virtio-net TSO Lockup

We've been encountering an issue in the virtio-net driver that cause it to become unresponsive after a period of high load. This issue goes away if we disable TSO on the interface. Once this issue has been triggered, the interface can still receive traffic, but will not transmit anything. S

Re: [RFC PATCH 0/2] net: macb: Add mdio driver for accessing multiple phy devices

On 12/07/15 21:48, Punnaiah Choudary Kalluri wrote: > This patch is to add support for the design that has multiple ethernet > mac controllers and single mdio bus connected to multiple phy devices. > i.e mdio lines are connected to any of the ethernet mac controller and > all the phy devices will b

Re: [PATCH net-next] tc: fix tc actions in case of shared skb

On 7/13/15 1:04 PM, David Miller wrote: From: Alexei Starovoitov Date: Mon, 13 Jul 2015 12:47:42 -0700 In all normal cases skb->users == 1, but pktgen is using trick: atomic_add(burst, &skb->users); so when testing something like: You can want pktgen rx (which is the only buggy case as far a

Re: [PATCH 1/2] sctp: SCTP_SOCKOPT_PEELOFF return socket pointer for kernel users

On 13-07-2015 16:58, David Miller wrote: From: Marcelo Ricardo Leitner Date: Mon, 13 Jul 2015 16:05:27 -0300 On 13-07-2015 15:59, David Miller wrote: From: Neil Horman Date: Mon, 13 Jul 2015 06:39:11 -0400 Initially Marcelo had created duplicate code paths, one to return an fd, one to retu

Re: [PATCH] Logically DeadCode

On 3 July 2015 at 06:52, Rahul Jain wrote: > From 0c34030166a150d6d9f1ab52e7bb40a5440a68c2 Mon Sep 17 00:00:00 2001 > From: Rahul Jain > Date: Fri, 3 Jul 2015 10:19:12 +0530 > Subject: [PATCH] Logically DeadCode You didn't use any prefix for the commit message, it's unclear (Logically DeadCode w

Re: [PATCH net-next] net: Build IPv6 into kernel by default

From: Tom Herbert Date: Mon, 13 Jul 2015 08:48:00 -0700 > This patch makes the default to build IPv6 into the kernel. IPv6 > now has significant traction and any remaining vestiges of IPv6 > not being provided parity with IPv4 should be swept away. IPv6 is now > core to the Internet and kernel. >

Re: [PATCH net-next] ebpf: remove self-assignment in interpreter's tail call

From: Daniel Borkmann Date: Mon, 13 Jul 2015 20:49:32 +0200 > ARG1 = BPF_R1 as it stands, evaluates to regs[BPF_REG_1] = regs[BPF_REG_1] > and thus has no effect. Add a comment instead, explaining what happens and > why it's okay to just remove it. Since from user space side, a tail call is > inv

Re: [PATCH net-next] tc: fix tc actions in case of shared skb

From: Alexei Starovoitov Date: Mon, 13 Jul 2015 12:47:42 -0700 > In all normal cases skb->users == 1, but pktgen is using trick: > atomic_add(burst, &skb->users); > so when testing something like: You can want pktgen rx (which is the only buggy case as far as I can see, TX is fine) to run fast,

Re: [PATCH] Revert "net: fec: Ensure clocks are enabled while using mdio bus"

From: Fabio Estevam Date: Mon, 13 Jul 2015 08:13:52 -0300 > This reverts commit 6c3e921b18edca290099adfddde8a50236bf2d80. > > commit 6c3e921b18ed ("net: fec: Ensure clocks are enabled while using mdio > bus") prevents the kernel to boot on mx6 boards, so let's revert it. > > Reported-by: Tyler

Re: [PATCH net-next] tc: fix tc actions in case of shared skb

On 7/11/15 9:29 PM, David Miller wrote: From: Alexei Starovoitov Date: Fri, 10 Jul 2015 17:10:11 -0700 TC actions need to check for very unlikely event skb->users != 1, otherwise subsequent pskb_may_pull/pskb_expand_head will crash. When skb_shared() just drop the packet, since in the middle o

Re: [PATCH 1/2] sctp: SCTP_SOCKOPT_PEELOFF return socket pointer for kernel users

From: Marcelo Ricardo Leitner Date: Mon, 13 Jul 2015 16:05:27 -0300 > On 13-07-2015 15:59, David Miller wrote: >> From: Neil Horman >> Date: Mon, 13 Jul 2015 06:39:11 -0400 >> >>> Initially Marcelo had created duplicate code paths, one to return an >>> fd, one to return a file struct. If you wo

[PATCH] net: qlcnic: Deletion of unnecessary memset

There is no need to memset memory allocated with vzalloc. Signed-off-by: Christophe JAILLET --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c

[Patch net] fq_codel: fix a use-after-free

Fixes: 25331d6ce42b ("net: sched: implement qstat helper routines") Cc: John Fastabend Signed-off-by: Cong Wang Signed-off-by: Cong Wang --- net/sched/sch_fq_codel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_fq_codel.c b/net/sched/sch_fq_codel.c index d75

[PATCH] net/bonding: Add function bond_remove_proc_entry at __bond_release_one

From: Carol L Soto Add function bond_remove_proc_entry at __bond_release_one to avoid stack trace at rmmod bonding. [68830.202239] remove_proc_entry: removing non-empty directory 'net/bonding', leaking at least 'bond0' [68830.202257] [ cut here ] [68830.202260] WARNING:

Re: [PATCH 1/2] sctp: SCTP_SOCKOPT_PEELOFF return socket pointer for kernel users

On 13-07-2015 15:59, David Miller wrote: From: Neil Horman Date: Mon, 13 Jul 2015 06:39:11 -0400 Initially Marcelo had created duplicate code paths, one to return an fd, one to return a file struct. If you would rather go in that direction, I'm sure he can propose it again, but that seems les

Re: Fighting out-of-order reception with RPS?

On Sun, Jul 12, 2015 at 12:15 PM, Oliver Hartkopp wrote: > Hello Eric, > > On 07/11/2015 06:35 AM, Eric Dumazet wrote: >> On Fri, 2015-07-10 at 22:36 +0200, Oliver Hartkopp wrote: > >>> Hm. Doesn't sound like a good solution when there's a difference between >>> NAPI >>> and non-NAPI drivers in m

[PATCH net] tcp: don't use F-RTO on non-recurring timeouts

Currently F-RTO may repeatedly send new data packets on non-recurring timeouts in CA_Loss mode. This is a bug because F-RTO (RFC5682) should only be used on either new recovery or recurring timeouts. This exacerbates the recovery progress during frequent timeout & repair, because we prioritize sen

Re: [PATCH net-next] ebpf: remove self-assignment in interpreter's tail call

On 7/13/15 11:49 AM, Daniel Borkmann wrote: ARG1 = BPF_R1 as it stands, evaluates to regs[BPF_REG_1] = regs[BPF_REG_1] and thus has no effect. Add a comment instead, explaining what happens and why it's okay to just remove it. Since from user space side, a tail call is invoked as a pseudo helper

Re: [PATCH 1/2] sctp: SCTP_SOCKOPT_PEELOFF return socket pointer for kernel users

From: Neil Horman Date: Mon, 13 Jul 2015 06:39:11 -0400 > Initially Marcelo had created duplicate code paths, one to return an > fd, one to return a file struct. If you would rather go in that > direction, I'm sure he can propose it again, but that seems less > correct to me than this solution.

[PATCH net-next] ebpf: remove self-assignment in interpreter's tail call

ARG1 = BPF_R1 as it stands, evaluates to regs[BPF_REG_1] = regs[BPF_REG_1] and thus has no effect. Add a comment instead, explaining what happens and why it's okay to just remove it. Since from user space side, a tail call is invoked as a pseudo helper function via bpf_tail_call_proto, the verifier

[PATCH V4 2/2] pci: Add VPD quirk for Intel Ethernet devices

From: Mark Rustad This quirk sets the PCI_DEV_FLAGS_VPD_REF_F0 flag on all Intel Ethernet device functions other than function 0. Signed-off-by: Mark Rustad --- Changes in V3: - Added a multifunction device check --- drivers/pci/quirks.c |9 + 1 file changed, 9 insertions(+) diff

[PATCH V4 1/2] pci: Add dev_flags bit to access VPD through function 0

From: Mark Rustad Add a dev_flags bit, PCI_DEV_FLAGS_VPD_REF_F0, to access VPD through function 0 to provide VPD access on other functions. This is for hardware devices that provide copies of the same VPD capability registers in multiple functions. Because the kernel expects that each function ha

[PATCH net-next] hv_netvsc: Add close of RNDIS filter into change mtu call

The current change mtu call only stops tx before removing RNDIS filter. In case ringbufer is not empty, the rndis_filter_device_remove() may hang on removing the buffers. This patch adds close of RNDIS filter before removing it, also a gradual waiting loop until the ring is empty. The change_mtu h

RE: [PATCH] bnx2:Make various functions to have a return type of void in the file bnx2.c

> Sony, > I also sent this patch and was wondering if I can get a reply on it. > From 4a607447562bec161fd947caae5eb02c2365c58a Mon Sep > 17 00:00:00 2001 > From: Nicholas Krause > Date: Wed, 8 Jul 2015 08:29:07 -0400 > Subject: [PATCH] bnx2i:Fix backwards locking scenario in the > function bnx2i_

[PATCH V4 0/2] pci: Provide a flag to access VPD through function 0

Many multi-function devices provide shared registers in extended config space for accessing VPD. The behavior of these registers means that the state must be tracked and access locked correctly for accesses not to hang or worse. One way to meet these needs is to always perform the accesses through

Re: [PATCH v2 18/22] fjes: unshare_watch_task

Hi Izumi-san, On Wed, 24 Jun 2015 11:55:50 +0900 Taku Izumi wrote: > This patch adds unshare_watch_task. > Shared buffer's status can be changed into unshared. > This task is used to monitor shared buffer's status. > > Signed-off-by: Taku Izumi > --- > drivers/net/fjes/fjes.h | 3 + >

Re: Linux 4.2 build error in net/netfilter/ipset/ip_set_hash_netnet.c

On Mon, Jul 13, 2015 at 9:13 AM, Akemi Yagi wrote: > On Sun, 05 Jul 2015 08:35:20 -0700, Guenter Roeck wrote: > >> On Sat, Jul 04, 2015 at 12:44:36AM -0700, Vinson Lee wrote: >>> Hi. >>> >>> With the latest Linux 4.2-rc1, I am hitting this build error with GCC >>> 4.4.7 on CentOS 6. >>> >>> CC

Re: [PATCH v1 08/12] IB/cma: Add net_dev and private data checks to RDMA CM

On Mon, Jun 22, 2015 at 03:42:37PM +0300, Haggai Eran wrote: > + switch (ib_event->event) { > + case IB_CM_REQ_RECEIVED: > + req->device = req_param->listen_id->device; > + req->port = req_param->port; > + req->local_gid = &req_param->primary_p

Re: [PATCH v1 11/12] IB/cma: Share ib_cm_ids between rdma_cm_ids

On Mon, Jun 22, 2015 at 03:42:40PM +0300, Haggai Eran wrote: > Use ib_cm_id_create_and_listen to create listening IB CM IDs or share ^^^ Is that the wrong name? ib_cm_insert_listen perhaps? I think I've looked at the details in this series I was concerned about, Sean

Re: [PATCH v1 05/12] IB/cm: Share listening CM IDs

On Mon, Jun 22, 2015 at 03:42:34PM +0300, Haggai Eran wrote: > spin_lock_irq(&cm.lock); > + if (--cm_id_priv->listen_sharecount > 0) { > + /* The id is still shared. */ > + atomic_dec(&cm_id_priv->refcount); Nit: This looks very str

Re: [PATCH 4/6] net: ieee802154: Remove redundant spi driver bus initialization

On Tue, Jun 23, 2015 at 10:52:52PM +0800, Antonio Borneo wrote: > In ancient times it was necessary to manually initialize the bus > field of an spi_driver to spi_bus_type. These days this is done in > spi_register_driver(), so we can drop the manual assignment. > Marcel, I don't see this patch

request for -stable: "route: Use ipv4_mtu instead of raw rt_pmtu"

Hi, Can you queue for active older -stables up to 3.18: commit 3cdaa5be9e81 "ipv4: Don't increase PMTU with Datagram Too Big message" commit cb6ccf09d6b9 "route: Use ipv4_mtu instead of raw rt_pmtu" commit 3cdaa5be9e81 made it to 3.19.y and was later fixed additionally with conversion to ipv4_mt

Re: [PATCH v2 15/22] fjes: net_device_ops.ndo_vlan_rx_add/kill_vid

Hi Izumi-san, On Wed, 24 Jun 2015 11:55:47 +0900 Taku Izumi wrote: > This patch adds net_device_ops.ndo_vlan_rx_add_vid and > net_device_ops.ndo_vlan_rx_kill_vid callback. > > Signed-off-by: Taku Izumi > --- > drivers/net/fjes/fjes_hw.c | 27 +++ > drivers/net/fjes/f

Re: Linux 4.2 build error in net/netfilter/ipset/ip_set_hash_netnet.c

On Sun, 05 Jul 2015 08:35:20 -0700, Guenter Roeck wrote: > On Sat, Jul 04, 2015 at 12:44:36AM -0700, Vinson Lee wrote: >> Hi. >> >> With the latest Linux 4.2-rc1, I am hitting this build error with GCC >> 4.4.7 on CentOS 6. >> >> CC net/netfilter/ipset/ip_set_hash_netnet.o >> net/netfilte

Re: [PATCH v2 10/22] fjes: tx_stall_task

Hi Izum-san, On Wed, 24 Jun 2015 11:55:42 +0900 Taku Izumi wrote: > This patch adds tx_stall_task. > When receiver's buffer is full, sender stops > its tx queue. This task is used to monitor > receiver's status and when receiver's buffer > is avairable, it resumes tx queue. > > Signed-off-by: T

[PATCH net-next] net: Build IPv6 into kernel by default

This patch makes the default to build IPv6 into the kernel. IPv6 now has significant traction and any remaining vestiges of IPv6 not being provided parity with IPv4 should be swept away. IPv6 is now core to the Internet and kernel. Points on IPv6 adoption: - Per Google statistics, IPv6 usage has

Re: [PATCH] ipv6: Fix finding best source address in ipv6_dev_get_saddr().

I am testing this patch which may be a little simpler. Also idev needs to be checked after __in6_dev_get Tom diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 4ab74d5..d631ac3 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -1363,9 +1363,10 @@ static void __ipv6_dev_get_s

Re: [PATCH] ipv6: Fix finding best source address in ipv6_dev_get_saddr().

At Mon, 13 Jul 2015 23:28:10 +0900, YOSHIFUJI Hideaki/吉藤英明 wrote: > > Commit 9131f3de2 ("ipv6: Do not iterate over all interfaces when > finding source address on specific interface.") did not properly > update best source address available. Plus, it introduced > possible NULL pointer dereferenc

Re: [PATCH] nf: IDLETIMER: fix lockdep warning

On Mon, Jul 13, 2015 at 08:02:36AM -0700, Dmitry Torokhov wrote: > On Mon, Jul 13, 2015 at 6:20 AM, Pablo Neira Ayuso > wrote: > > On Thu, Jul 09, 2015 at 05:15:01PM -0700, Dmitry Torokhov wrote: > >> Dynamically allocated sysfs attributes should be initialized with > >> sysfs_attr_init() otherwi

Re: [PATCH] nf: IDLETIMER: fix lockdep warning

On Mon, Jul 13, 2015 at 6:20 AM, Pablo Neira Ayuso wrote: > On Thu, Jul 09, 2015 at 05:15:01PM -0700, Dmitry Torokhov wrote: >> Dynamically allocated sysfs attributes should be initialized with >> sysfs_attr_init() otherwise lockdep will be angry with us: >> >> [ 45.468653] BUG: key ffc030fa

[PATCH] ipv6: Fix finding best source address in ipv6_dev_get_saddr().

Commit 9131f3de2 ("ipv6: Do not iterate over all interfaces when finding source address on specific interface.") did not properly update best source address available. Plus, it introduced possible NULL pointer dereference. Bug was reported by Erik Kline . Based on patch proposed by Hajime Tazaki

Re: net: Fix skb csum races when peeking

On Mon, Jul 13, 2015 at 08:01:42PM +0800, Herbert Xu wrote: > > PS we seem to no longer use the hardware checksum in case of > CHECKSUM_COMPLETE, I wonder why that is? Nevermind, it's still there. I was just looking in the wrong place. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au

Re: [PATCH net v4] rtnl/bond: don't send rtnl msg for unregistered iface

Hello, I have a quick question about this patch. On Wed, May 13, 2015 at 2:19 PM, Nicolas Dichtel wrote: > diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c > index 837d30b5ffed..7b25f1ef3d75 100644 > --- a/net/core/rtnetlink.c > +++ b/net/core/rtnetlink.c > @@ -2415,6 +2415,9 @@ void rtm

Re: [PATCH net-next v2] ipv6: Do not iterate over all interfaces when finding source address on specific interface.

Hi, Hajime Tazaki wrote: > > Yoshifuji-san, > > At Mon, 13 Jul 2015 17:38:48 +0900, > Erik Kline wrote: >> >> On 13 July 2015 at 15:32, YOSHIFUJI Hideaki >> wrote: >>> Hi, >>> >>> Erik Kline wrote: Hmm, when I run a UML linux with this patch (which, I'm ashamed to say, I failed to do

[PATCH net] bridge: mdb: fix double add notification

Since the mdb add/del code was introduced there have been 2 br_mdb_notify calls when doing br_mdb_add() resulting in 2 notifications on each add. Example: Command: bridge mdb add dev br0 port eth1 grp 239.0.0.1 permanent Before patch: root@debian:~# bridge monitor all [MDB]dev br0 port eth1 gr

[PATCH net-next 1/4 v2] gianfar: Bundle Rx allocation, cleanup

Use a more common consumer/ producer index design to improve rx buffer allocation. Instead of allocating a single new buffer (skb) on each iteration, bundle the allocation of several rx buffers at a time. This also opens the path for further memory optimizations. Remove useless check of rxq->rfb

mmap()ed AF_NETLINK: lockdep and sleep-in-atomic warnings

Hi, This simple test-case trigers few locking asserts in kernel: #define _GNU_SOURCE #include #include #include #include #include #include #include #define SOL_NETLINK 270 int main(int argc, char **argv) { unsigned int block_size = 16 * 4096; struct nl_mmap_req req = {

[PATCH net-next 3/4 v2] gianfar: Use ndev, more Rx path cleanup

Use "ndev" instead of "dev", as the rx queue back pointer to a net_device struct, to avoid name clashing with a "struct device" reference. This prepares the addition of a "struct device" back pointer to the rx queue structure. Remove duplicated rxq registration in the process. Move napi_gro_recei

[PATCH net-next 2/4 v2] gianfar: Fix and cleanup rxbd status handling

There are several (long standing) problems about how the status field of the rx buffer descriptor (rxbd) is currently handled on the error path: - too many unnecessary 16bit reads of the two halves of the rxbd status field (32bit), also resulting in overuse of endianness convesion macros; - "bdp->s

[PATCH net-next 4/4 v2] gianfar: Add paged allocation and Rx S/G

The eTSEC h/w is capable of scatter/gather on the receive side too if MAXFRM > MRBLR, when the allowed maximum Rx frame size is set to be greater than the maximum Rx buffer size (MRBLR). It's about time the driver makes use of this h/w capability, by supporting fixed buffer sizes and Rx S/G. The b

[PATCH net-next 0/4 v2] gianfar: Add Rx S/G

Hi David, This patch-set introduces scatter/gather support on the Rx side, addressing Rx path performance issues in the driver. Thanks. As an example, two boards connected back-to-back were used to measure the throughput, running the same kernel 4.1, before and after applying these patches. The ne

Re: [PATCH 1/2] sctp: SCTP_SOCKOPT_PEELOFF return socket pointer for kernel users

On 13-07-2015 07:39, Neil Horman wrote: On Fri, Jul 10, 2015 at 06:21:14PM -0700, David Miller wrote: From: Marcelo Ricardo Leitner Date: Thu, 9 Jul 2015 11:15:19 -0300 SCTP has this operation to peel off associations from a given socket and create a new socket using this association. We cur

Re: [PATCH] nf: IDLETIMER: fix lockdep warning

On Thu, Jul 09, 2015 at 05:15:01PM -0700, Dmitry Torokhov wrote: > Dynamically allocated sysfs attributes should be initialized with > sysfs_attr_init() otherwise lockdep will be angry with us: > > [ 45.468653] BUG: key ffc030fad4e0 not in .data! > [ 45.468655] [ cut here ]

Re: [PATCH net-next] tc: fix tc actions in case of shared skb

On 07/10/15 20:10, Alexei Starovoitov wrote: TC actions need to check for very unlikely event skb->users != 1, otherwise subsequent pskb_may_pull/pskb_expand_head will crash. When skb_shared() just drop the packet, since in the middle of actions it's too late to call skb_share_check(), since clas

Re: [PATCH v2] add stealth mode

On 2015-07-12 19:13, Matteo Croce wrote: 2015-07-08 15:32 GMT+02:00 Austin S Hemmelgarn : On 2015-07-06 15:44, Matteo Croce wrote: Just to name a few that I know of off the top of my head: 1. IP packets with any protocol number not supported by your current kernel (these return a special ICMP me

add some more infomation RE: Issue with active-backup mode bond and bridge

I test this issue in kernel 3.0.93. This issue is a reproduction problem. Step 1. Create a active-backup mode bond with two nics and make sure the IP is in the bond. Step 2. Create a bridge with brctl command Step 3. Join the bond to the bridge and make the IP in the bridge device Step 4. use "tc

Re: [net-next 12/16] i40evf: don't delete all the filters

Hello. On 7/13/2015 12:08 PM, Jeff Kirsher wrote: From: Mitch Williams Due to an inverted conditional, the driver was marking all of its MAC filters for deletion every time set_rx_mode was called. Depending upon the timing of the calls to set_rx_mode and the processing of the admin queue, t

[PATCH net] bridge: multicast: treat igmpv3 report with INCLUDE and no sources as a leave

From: Satish Ashok A report with INCLUDE/Change_to_include and empty source list should be treated as a leave, specified by RFC 3376, section 3.1: "If the requested filter mode is INCLUDE *and* the requested source list is empty, then the entry corresponding to the requested interface and multi

net: Fix skb csum races when peeking

On Mon, Jul 13, 2015 at 04:31:00PM +0800, Herbert Xu wrote: > On Mon, Jul 13, 2015 at 10:28:19AM +0200, Eric Dumazet wrote: > > > > Except that udp checksum are checked outside of spinlock protection. > > Good point. I wonder when this got broken. I'll do some digging. OK looks like I can claim

[PATCH] Revert "net: fec: Ensure clocks are enabled while using mdio bus"

This reverts commit 6c3e921b18edca290099adfddde8a50236bf2d80. commit 6c3e921b18ed ("net: fec: Ensure clocks are enabled while using mdio bus") prevents the kernel to boot on mx6 boards, so let's revert it. Reported-by: Tyler Baker Signed-off-by: Fabio Estevam --- drivers/net/ethernet/freescal

Re: [PATCH net-next v2] ipv6: Do not iterate over all interfaces when finding source address on specific interface.

Yoshifuji-san, At Mon, 13 Jul 2015 17:38:48 +0900, Erik Kline wrote: > > On 13 July 2015 at 15:32, YOSHIFUJI Hideaki > wrote: > > Hi, > > > > Erik Kline wrote: > >> Hmm, when I run a UML linux with this patch (which, I'm ashamed to > >> say, I failed to do before) I get these kinds of errors: >

Re: [PATCH 1/2] sctp: SCTP_SOCKOPT_PEELOFF return socket pointer for kernel users

On Fri, Jul 10, 2015 at 06:21:14PM -0700, David Miller wrote: > From: Marcelo Ricardo Leitner > Date: Thu, 9 Jul 2015 11:15:19 -0300 > > > SCTP has this operation to peel off associations from a given socket and > > create a new socket using this association. We currently have two ways > > to us

RE: GFIT

From: Cunliffe Bryan (RW3) CMFT Manchester Sent: 12 July 2015 21:11 To: Cunliffe Bryan (RW3) CMFT Manchester Subject: GFIT Donation has been made to you Email mrs.gloriamacke...@outlook.com for more Details Privacy and Co

RE: [PATCH] bnx2x: Update to FW version 7.12.30

> > > The new FW will allow us to utilize some new features in our driver, > > > mainly adding vlan filtering offload and vxlan offload support. > > > > > > In addition, this fixes several issues: > > > 1. Packets from a VF with pvid configured which were sent with a > > >different vlan were tr

Re: [PATCH v2 0/2] net: enable inband link state negotiation only when explicitly requested

13.07.2015 12:54, Sebastien Rannou пишет: > Hi Stas, > > On Fri, 10 Jul 2015, Stas Sergeev wrote: > >> Those who were affected by the change, please send your Tested-by, >> Thanks! > > I also confirm that this version of the patch solves the issue: > > Tested-by: Sebastien Rannou Thanks Sebast

Re: [PATCH v2 0/2] net: enable inband link state negotiation only when explicitly requested

Hi Stas, On Fri, 10 Jul 2015, Stas Sergeev wrote: > Those who were affected by the change, please send your Tested-by, > Thanks! I also confirm that this version of the patch solves the issue: Tested-by: Sebastien Rannou -- Sébastien

linux-4.2-rc2/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1993: possible bad error checking ?

Hello there, [linux-4.2-rc2/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1993]: (style) Checking if unsigned variable 'entry' is less than zero. Source code is     entry = priv->hw->mode->jumbo_frm(priv, skb, csum_insertion);     if (unlikely(entry < 0))     goto dma_map_er

  1   2   >